[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[ https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808481#comment-17808481 ] Maxim Solodovnik commented on RAT-325: -- [~pottlinger] Just have re-tested! 5 seconds for the build with unapproved licenses 3 seconds for the green build! Thanks for the fix! :) > Performance degradation compared to 0.15 > > > Key: RAT-325 > URL: https://issues.apache.org/jira/browse/RAT-325 > Project: Apache Rat > Issue Type: Bug > Components: cli >Affects Versions: 0.16 >Reporter: Jean-Baptiste Onofré >Assignee: Claude Warren >Priority: Major > Fix For: 0.16.1 > > > While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than > with 0.15. > I'm investigating why. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[
https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807540#comment-17807540
]
Maxim Solodovnik commented on RAT-325:
--
Hello [~pottlinger],
I've just re-run {{mvn clean apache-rat:0.16.1-SNAPSHOT:check -U}}
got {{apache-rat-*-0.16.1-20240116.065051-10.jar}}
and the check tooks too long
Can you double check the SNAPSHOT contains the fix? :)
> Performance degradation compared to 0.15
>
>
> Key: RAT-325
> URL: https://issues.apache.org/jira/browse/RAT-325
> Project: Apache Rat
> Issue Type: Bug
> Components: cli
>Affects Versions: 0.16
>Reporter: Jean-Baptiste Onofré
>Assignee: Claude Warren
>Priority: Major
> Fix For: 0.16.1
>
>
> While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than
> with 0.15.
> I'm investigating why.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (RAT-346) WARN in case user defined License family has the same name as existing one
[
https://issues.apache.org/jira/browse/RAT-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17806878#comment-17806878
]
Maxim Solodovnik commented on RAT-346:
--
Hello [~pottlinger],
After I run {{mvn clean apache-rat:0.16.1-SNAPSHOT:check -U}}
I can see the following output:
{code}
[WARNING] Parameter 'licenses' is deprecated: No reason given
[WARNING] Duplicate LicenseFamily category: MIT (action: IGNORE)
[WARNING] Duplicate License The MIT License (MIT) of type MIT (action: IGNORE)
{code}
Everything seems to work as expected!
Thanks for the fix!
And sorry for the noise :(
> WARN in case user defined License family has the same name as existing one
> --
>
> Key: RAT-346
> URL: https://issues.apache.org/jira/browse/RAT-346
> Project: Apache Rat
> Issue Type: Improvement
> Components: scan
>Affects Versions: 0.16
>Reporter: Claude Warren
>Assignee: Claude Warren
>Priority: Major
> Fix For: 0.16.1
>
>
> Could you please raise WARN in case user defined License family has the same
> name as internal one?
> It seems user defined one is `just ignored` in such case :(
> h2. Architecture remark
> I removed the API module because it consisted of a) class files that were not
> being used in the code but that were misleading in name; and more importantly
> b) because there were a number of test cases that would have been converted
> to Junit5 only to be removed again later.
> The harmonization is not necessarily the use of a single API module but
> rather that the options in each of the UIs should be similarly constructed
> (same basic phrasing) not have 2 UIs where one says
> "--enable-default-licenses" (default off) and the other says
> "--disable-default-licenses" (default on). Also there are options that have
> been added to one UI that are general in nature (i.e. not part of managing
> the specific platform the UI is on) and are not available in the other UIs.
> I will remove the commented out code. I should have before I submitted this
> pull request, but skipped it in favor of getting this code change infront of
> more eyes quickly.
> I also have to make a pass to update javadocs.
> @jbonofre Most of the changes in this request are the migration to Junit 5.
> The significant changes are the creation of the classes in the o.a.r..utils
> directory, the addition of methods to set the associated properties in
> ReportConfiguration along with the tests for those classes and changes.
> The request was to warn on duplication so the solution submitted does the
> following:
> Creates a ReportingSet class that is a SortedSet implementation (wrapping
> and delegating to a SortedSet). it intercepts the calls to add and addAll to
> determine if the new elements are already in the set and take an action.
> * If logging is enabled (not set to None on the very thing logging wrapper
> Log) write a message about the collision to the log at the specific level.
> * If the internal action (ReportingSet.Option) is set to IGNORE the change
> is ignored, OVERWRITE the old entry is replaced, FAIL an exception is thrown.
> Finally the ReportingSet has an instance variable called duplicateFmt that is
> a Function that produces the information to display in the message.
> The change to ReportConfiguration are to use ReportingSet to contain the
> Licenses and LicenseFamilies, and supporting methods to configure (as noted
> above).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (RAT-346) WARN in case user defined License family has the same name as existing one
[
https://issues.apache.org/jira/browse/RAT-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17806626#comment-17806626
]
Maxim Solodovnik commented on RAT-346:
--
[~pottlinger] I would say no warning is displayed :(((
my config:
{code}
MIT
licensed under the MIT
Licensed MIT
OM_CC_BY_4
CC BY 4.0 License
MIT
MIT
OM_CC_BY_4
CC BY 4.0
{code}
Filtered output of {{mvn clean apache-rat:0.16.1-SNAPSHOT:check}}
{code}
[INFO] --- apache-rat:0.16.1-SNAPSHOT:check (default-cli) @ openmeetings-web ---
[WARNING] Parameter 'licenses' is deprecated: No reason given
[INFO] Rat check: Summary over all files. Unapproved: 5, unknown: 5, generated:
63, approved: 596 licenses.
[WARNING] Files with unapproved licenses:
src/main/front/src/css/_cssemoticons.scss
src/main/front/src/chat/cssemoticons.js
src/main/webapp/css/theme_om/jquery-ui.css
src/main/webapp/css/theme_om/jquery-ui.min.css
src/main/webapp/css/images/audio.svg
[INFO]
[INFO] BUILD FAILURE
[INFO]
{code}
> WARN in case user defined License family has the same name as existing one
> --
>
> Key: RAT-346
> URL: https://issues.apache.org/jira/browse/RAT-346
> Project: Apache Rat
> Issue Type: Improvement
> Components: scan
>Affects Versions: 0.16
>Reporter: Claude Warren
>Assignee: Claude Warren
>Priority: Major
> Fix For: 0.16.1
>
>
> Could you please raise WARN in case user defined License family has the same
> name as internal one?
> It seems user defined one is `just ignored` in such case :(
> h2. Architecture remark
> I removed the API module because it consisted of a) class files that were not
> being used in the code but that were misleading in name; and more importantly
> b) because there were a number of test cases that would have been converted
> to Junit5 only to be removed again later.
> The harmonization is not necessarily the use of a single API module but
> rather that the options in each of the UIs should be similarly constructed
> (same basic phrasing) not have 2 UIs where one says
> "--enable-default-licenses" (default off) and the other says
> "--disable-default-licenses" (default on). Also there are options that have
> been added to one UI that are general in nature (i.e. not part of managing
> the specific platform the UI is on) and are not available in the other UIs.
> I will remove the commented out code. I should have before I submitted this
> pull request, but skipped it in favor of getting this code change infront of
> more eyes quickly.
> I also have to make a pass to update javadocs.
> @jbonofre Most of the changes in this request are the migration to Junit 5.
> The significant changes are the creation of the classes in the o.a.r..utils
> directory, the addition of methods to set the associated properties in
> ReportConfiguration along with the tests for those classes and changes.
> The request was to warn on duplication so the solution submitted does the
> following:
> Creates a ReportingSet class that is a SortedSet implementation (wrapping
> and delegating to a SortedSet). it intercepts the calls to add and addAll to
> determine if the new elements are already in the set and take an action.
> * If logging is enabled (not set to None on the very thing logging wrapper
> Log) write a message about the collision to the log at the specific level.
> * If the internal action (ReportingSet.Option) is set to IGNORE the change
> is ignored, OVERWRITE the old entry is replaced, FAIL an exception is thrown.
> Finally the ReportingSet has an instance variable called duplicateFmt that is
> a Function that produces the information to display in the message.
> The change to ReportConfiguration are to use ReportingSet to contain the
> Licenses and LicenseFamilies, and supporting methods to configure (as noted
> above).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (RAT-351) Automatic code formatters in Creadur RAT?
[ https://issues.apache.org/jira/browse/RAT-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17806429#comment-17806429 ] Maxim Solodovnik commented on RAT-351: -- I guess you can add maven-checkstyle-plugin with necessary rules :) > Automatic code formatters in Creadur RAT? > - > > Key: RAT-351 > URL: https://issues.apache.org/jira/browse/RAT-351 > Project: Apache Rat > Issue Type: Improvement >Reporter: Philipp Ottlinger >Priority: Major > > As more and more code changes come in via Github/PullRequests and > individually different IDE settings I'd like to once more discuss an > automated way of formatting the source code. > Any ideas? plugins? - > https://fullstackcode.dev/2023/09/10/simplify-your-code-formatting-with-the-maven-plugins/ > I guess it would ease work for contributors and would take energy away from > formatting wars -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[ https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17806251#comment-17806251 ] Maxim Solodovnik commented on RAT-325: -- looks promising! :) looking forward to get fresh SNAPSHOT to test locally :) I would also check the case when some unapproved licences are found > Performance degradation compared to 0.15 > > > Key: RAT-325 > URL: https://issues.apache.org/jira/browse/RAT-325 > Project: Apache Rat > Issue Type: Bug > Components: cli >Affects Versions: 0.16 >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 0.17, 0.16.1 > > > While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than > with 0.15. > I'm investigating why. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[
https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17806099#comment-17806099
]
Maxim Solodovnik commented on RAT-325:
--
Hello [~joc...@apache.org],
here are my steps:
Preparation:
{code}
git clone https://github.com/apache/openmeetings.git
cd openmeetings/openmeetings-web
{code}
h3. 1. to get 0.15 result (fastest)
run: {{mvn clean apache-rat:0.15:check}}
The results at my laptop:
{code}
[INFO]
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 1.005 s
[INFO] Finished at: 2024-01-12T22:33:06+07:00
[INFO]
{code}
--
h3. 2. to get worst results: edit {{../pom}} (i.e. {{pom.xml}} at project root)
comment out {{}} at line 1420
run: {{mvn clean apache-rat:0.16:check}}
The results at my laptop:
{code}
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 38:15 min
[INFO] Finished at: 2024-01-12T21:46:04+07:00
[INFO]
{code}
Seems the job done twice:
- to print summary i.e. {{Rat check: Summary over all files. Unapproved: 6,
unknown: 6, generated: 63, approved: 595 licenses.}}
- to print list of files
--
h3. 3. to get better results: edit {{../pom}} (i.e. {{pom.xml}} at project root)
un-comment {{}} at line 1394
run: {{mvn clean apache-rat:0.16:check}}
The results at my laptop:
{code}
[INFO]
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 18:19 min
[INFO] Finished at: 2024-01-12T22:05:08+07:00
[INFO]
{code}
My configuration:
{code}
Ubuntu 22.04.3 LTS
Apache Maven 3.9.1 (2e178502fcdbffc201671fb2537d0cb4b4cc58f8)
Maven home: /opt/maven
Java version: 17.0.9, vendor: Private Build, runtime:
/usr/lib/jvm/java-17-openjdk-amd64
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "5.15.0-91-generic", arch: "amd64", family: "unix"
16 core AMD Ryzen 7 6800H
64GB RAM
{code}
BTW according to CPU load the process is single threaded
> Performance degradation compared to 0.15
>
>
> Key: RAT-325
> URL: https://issues.apache.org/jira/browse/RAT-325
> Project: Apache Rat
> Issue Type: Bug
> Components: cli
>Affects Versions: 0.16
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 0.17
>
>
> While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than
> with 0.15.
> I'm investigating why.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (RAT-346) WARN in case user defined License family has the same name as existing one
[ https://issues.apache.org/jira/browse/RAT-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805910#comment-17805910 ] Maxim Solodovnik commented on RAT-346: -- Thanks a million! :) > WARN in case user defined License family has the same name as existing one > -- > > Key: RAT-346 > URL: https://issues.apache.org/jira/browse/RAT-346 > Project: Apache Rat > Issue Type: Improvement > Components: scan >Reporter: Claude Warren >Priority: Major > > Could you please raise WARN in case user defined License family has the same > name as internal one? > It seems user defined one is `just ignored` in such case :(( -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-343) Custom licensenses not working in contrast to v0.15
[ https://issues.apache.org/jira/browse/RAT-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805621#comment-17805621 ] Maxim Solodovnik commented on RAT-343: -- According to https://github.com/apache/creadur-rat/blob/master/apache-rat-core/src/main/resources/org/apache/rat/default.xml the syntax seems to be different Shall I try to create something similar ? :) > Custom licensenses not working in contrast to v0.15 > --- > > Key: RAT-343 > URL: https://issues.apache.org/jira/browse/RAT-343 > Project: Apache Rat > Issue Type: Bug > Components: license-meta-data, scan, site >Affects Versions: 0.16 >Reporter: Philipp Ottlinger >Priority: Major > > Due to the changes introduced in 0.16 projects with custom license > definitions do not seem to work anymore as reported by [~solomax] with > OpenMeetings: > [https://github.com/apache/openmeetings/blob/master/pom.xml#L1393] > Verify that the documentation provided in > [https://creadur.apache.org/rat/apache-rat-plugin/examples/custom-license.html] > is correct and ideally add an example usage to > [CreadurExamples|https://github.com/ottlinger/creadur-rat-examples] to > prevent future regressions. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[
https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805528#comment-17805528
]
Maxim Solodovnik commented on RAT-325:
--
Here are the results for our project: Apache OpenMeetings:
Rat 0.15
{code}
[INFO] Reactor Summary for Openmeetings 8.0.0-SNAPSHOT:
[INFO]
[INFO] Openmeetings ... SUCCESS [ 7.493 s]
[INFO] Openmeetings Tests . SUCCESS [ 5.237 s]
[INFO] Openmeetings Util .. SUCCESS [ 12.594 s]
[INFO] Openmeetings DB SUCCESS [ 16.765 s]
[INFO] Openmeetings Core .. SUCCESS [ 13.567 s]
[INFO] Openmeetings MediaServer ... SUCCESS [ 13.218 s]
[INFO] Openmeetings Install ... SUCCESS [ 12.963 s]
[INFO] Openmeetings Service ... SUCCESS [ 14.817 s]
[INFO] Openmeetings Webservices ... SUCCESS [ 13.905 s]
[INFO] Openmeetings Web ... SUCCESS [ 43.994 s]
[INFO] Openmeetings Screen Sharing applet . SUCCESS [ 7.467 s]
[INFO] Openmeetings Server SUCCESS [ 22.649 s]
[INFO]
[INFO] BUILD SUCCESS
{code}
Rat 0.16
{code}
[INFO] Reactor Summary for Openmeetings 8.0.0-SNAPSHOT:
[INFO]
[INFO] Openmeetings ... SUCCESS [ 10.183 s]
[INFO] Openmeetings Tests . SUCCESS [ 4.597 s]
[INFO] Openmeetings Util .. SUCCESS [ 13.439 s]
[INFO] Openmeetings DB SUCCESS [ 18.848 s]
[INFO] Openmeetings Core .. SUCCESS [ 14.530 s]
[INFO] Openmeetings MediaServer ... SUCCESS [ 13.718 s]
[INFO] Openmeetings Install ... SUCCESS [ 14.093 s]
[INFO] Openmeetings Service ... SUCCESS [ 18.380 s]
[INFO] Openmeetings Webservices ... SUCCESS [ 15.004 s]
[INFO] Openmeetings Web ... FAILURE [42:36 min]
[INFO] Openmeetings Screen Sharing applet . SKIPPED
[INFO] Openmeetings Server SKIPPED
[INFO]
[INFO] BUILD FAILURE
{code}
The results for modules without errors are very much the same
While for the failing module the results are ~60x slower :((
> Performance degradation compared to 0.15
>
>
> Key: RAT-325
> URL: https://issues.apache.org/jira/browse/RAT-325
> Project: Apache Rat
> Issue Type: Bug
> Components: cli
>Affects Versions: 0.16
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 0.17
>
>
> While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than
> with 0.15.
> I'm investigating why.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (RAT-325) Performance degradation compared to 0.15
[
https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805491#comment-17805491
]
Maxim Solodovnik edited comment on RAT-325 at 1/11/24 11:14 AM:
I'm currently testing {{0.16}}
the performance seems to degrade significantly (I'll provide exact numbers as
soon as I'll bypass new custom license syntax)
The weird thing I've noticed very lng delay between:
{code}
[INFO] --- apache-rat:0.16:check (default) @ openmeetings-web ---
[INFO] Rat check: Summary over all files. Unapproved: 6, unknown: 6, generated:
63, approved: 595 licenses.
{code}
and
{code}
[WARNING] Files with unapproved licenses:
/home/solomax/work/openmeetings/openmeetings/openmeetings-web/src/main/front/src/css/_cssemoticons.scss
/home/solomax/work/openmeetings/openmeetings/openmeetings-web/src/main/front/src/chat/cssemoticons.js
/home/solomax/work/openmeetings/openmeetings/openmeetings-web/src/main/webapp/css/theme_om/jquery-ui.css
/home/solomax/work/openmeetings/openmeetings/openmeetings-web/src/main/webapp/css/theme_om/jquery-ui.min.css
/home/solomax/work/openmeetings/openmeetings/openmeetings-web/src/main/webapp/css/images/audio.svg
/home/solomax/work/openmeetings/openmeetings/openmeetings-web/src/main/webapp/images/phone.svg
{code}
i.e. list of files with unapproved licensed is being printed more than a minute
(I would say 5+ minute) .
was (Author: solomax):
I'm currently testing {{0.16}}
the performance seems to degrade significantly (I'll provide exact numbers as
soon as I'll bypass new custom license syntax)
The weird thing I've noticed very lng delay between:
{code}
[INFO] --- apache-rat:0.16:check (default) @ openmeetings-web ---
[INFO] Rat check: Summary over all files. Unapproved: 6, unknown: 6, generated:
63, approved: 595 licenses.
{code}
and
{code}
[WARNING] Files with unapproved licenses:
/home/solomax/work/openmeetings/openmeetings/openmeetings-web/src/main/front/src/css/_cssemoticons.scss
/home/solomax/work/openmeetings/openmeetings/openmeetings-web/src/main/front/src/chat/cssemoticons.js
/home/solomax/work/openmeetings/openmeetings/openmeetings-web/src/main/webapp/css/theme_om/jquery-ui.css
/home/solomax/work/openmeetings/openmeetings/openmeetings-web/src/main/webapp/css/theme_om/jquery-ui.min.css
/home/solomax/work/openmeetings/openmeetings/openmeetings-web/src/main/webapp/css/images/audio.svg
/home/solomax/work/openmeetings/openmeetings/openmeetings-web/src/main/webapp/images/phone.svg
{code}
i.e. list of files with unapproved licensed is being printed for about minute
.
> Performance degradation compared to 0.15
>
>
> Key: RAT-325
> URL: https://issues.apache.org/jira/browse/RAT-325
> Project: Apache Rat
> Issue Type: Bug
> Components: cli
>Affects Versions: 0.16
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 0.17
>
>
> While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than
> with 0.15.
> I'm investigating why.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (RAT-325) Performance degradation compared to 0.15
[
https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805491#comment-17805491
]
Maxim Solodovnik edited comment on RAT-325 at 1/11/24 11:14 AM:
I'm currently testing {{0.16}}
the performance seems to degrade significantly (I'll provide exact numbers as
soon as I'll bypass new custom license syntax)
The weird thing I've noticed very lng delay between:
{code}
[INFO] --- apache-rat:0.16:check (default) @ openmeetings-web ---
[INFO] Rat check: Summary over all files. Unapproved: 6, unknown: 6, generated:
63, approved: 595 licenses.
{code}
and
{code}
[WARNING] Files with unapproved licenses:
/home/solomax/work/openmeetings/openmeetings/openmeetings-web/src/main/front/src/css/_cssemoticons.scss
/home/solomax/work/openmeetings/openmeetings/openmeetings-web/src/main/front/src/chat/cssemoticons.js
/home/solomax/work/openmeetings/openmeetings/openmeetings-web/src/main/webapp/css/theme_om/jquery-ui.css
/home/solomax/work/openmeetings/openmeetings/openmeetings-web/src/main/webapp/css/theme_om/jquery-ui.min.css
/home/solomax/work/openmeetings/openmeetings/openmeetings-web/src/main/webapp/css/images/audio.svg
/home/solomax/work/openmeetings/openmeetings/openmeetings-web/src/main/webapp/images/phone.svg
{code}
i.e. list of files with unapproved licensed is being printed more than a minute
(I would say 5+ minutes) .
was (Author: solomax):
I'm currently testing {{0.16}}
the performance seems to degrade significantly (I'll provide exact numbers as
soon as I'll bypass new custom license syntax)
The weird thing I've noticed very lng delay between:
{code}
[INFO] --- apache-rat:0.16:check (default) @ openmeetings-web ---
[INFO] Rat check: Summary over all files. Unapproved: 6, unknown: 6, generated:
63, approved: 595 licenses.
{code}
and
{code}
[WARNING] Files with unapproved licenses:
/home/solomax/work/openmeetings/openmeetings/openmeetings-web/src/main/front/src/css/_cssemoticons.scss
/home/solomax/work/openmeetings/openmeetings/openmeetings-web/src/main/front/src/chat/cssemoticons.js
/home/solomax/work/openmeetings/openmeetings/openmeetings-web/src/main/webapp/css/theme_om/jquery-ui.css
/home/solomax/work/openmeetings/openmeetings/openmeetings-web/src/main/webapp/css/theme_om/jquery-ui.min.css
/home/solomax/work/openmeetings/openmeetings/openmeetings-web/src/main/webapp/css/images/audio.svg
/home/solomax/work/openmeetings/openmeetings/openmeetings-web/src/main/webapp/images/phone.svg
{code}
i.e. list of files with unapproved licensed is being printed more than a minute
(I would say 5+ minute) .
> Performance degradation compared to 0.15
>
>
> Key: RAT-325
> URL: https://issues.apache.org/jira/browse/RAT-325
> Project: Apache Rat
> Issue Type: Bug
> Components: cli
>Affects Versions: 0.16
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 0.17
>
>
> While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than
> with 0.15.
> I'm investigating why.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (RAT-343) Custom licensenses not working in contrast to v0.15
[
https://issues.apache.org/jira/browse/RAT-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805493#comment-17805493
]
Maxim Solodovnik edited comment on RAT-343 at 1/11/24 10:33 AM:
[~claude] I've tried to add following {{configuration}}
{code}
MIT
licensed under the MIT
MIT
MIT
{code}
We have source file with following header
{code}
/*
* jQuery CSSEmoticons plugin 0.2.9
*
* Copyright (c) 2010 Steve Schwartz (JangoSteve)
*
* Dual licensed under the MIT and GPL licenses:
* http://www.opensource.org/licenses/mit-license.php
* http://www.gnu.org/licenses/gpl.html
*
* Date: Sun Oct 22 1:00:00 2010 -0500
*/
{code}
The line {{licensed under the MIT}} is in file, but the file is reported as
having unapproved license :(((
What am I doing wrong? :)
was (Author: solomax):
[~claude] I've tried to add following {{configuration}}
{code}
MIT
licensed under the MIT
MIT
MIT
{code}
We have source file with following header
{code}
/*
* jQuery CSSEmoticons plugin 0.2.9
*
* Copyright (c) 2010 Steve Schwartz (JangoSteve)
*
* Dual licensed under the MIT and GPL licenses:
* http://www.opensource.org/licenses/mit-license.php
* http://www.gnu.org/licenses/gpl.html
*
* Date: Sun Oct 22 1:00:00 2010 -0500
*/
{code}
The line {{licensed under the MIT}} is in file, but the file is reported as
having unapproved license :(((
What am I doing wrong? :)
> Custom licensenses not working in contrast to v0.15
> ---
>
> Key: RAT-343
> URL: https://issues.apache.org/jira/browse/RAT-343
> Project: Apache Rat
> Issue Type: Bug
> Components: license-meta-data, scan, site
>Affects Versions: 0.16
>Reporter: Philipp Ottlinger
>Priority: Major
>
> Due to the changes introduced in 0.16 projects with custom license
> definitions do not seem to work anymore as reported by [~solomax] with
> OpenMeetings:
> [https://github.com/apache/openmeetings/blob/master/pom.xml#L1393]
> Verify that the documentation provided in
> [https://creadur.apache.org/rat/apache-rat-plugin/examples/custom-license.html]
> is correct and ideally add an example usage to
> [CreadurExamples|https://github.com/ottlinger/creadur-rat-examples] to
> prevent future regressions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (RAT-343) Custom licensenses not working in contrast to v0.15
[
https://issues.apache.org/jira/browse/RAT-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805493#comment-17805493
]
Maxim Solodovnik commented on RAT-343:
--
[~claude] I've tried to add following {{configuration}}
{code}
MIT
licensed under the MIT
MIT
MIT
{code}
We have source file with following header
{code}
/*
* jQuery CSSEmoticons plugin 0.2.9
*
* Copyright (c) 2010 Steve Schwartz (JangoSteve)
*
* Dual licensed under the MIT and GPL licenses:
* http://www.opensource.org/licenses/mit-license.php
* http://www.gnu.org/licenses/gpl.html
*
* Date: Sun Oct 22 1:00:00 2010 -0500
*/
{code}
The line {{licensed under the MIT}} is in file, but the file is reported as
having unapproved license :(((
What am I doing wrong? :)
> Custom licensenses not working in contrast to v0.15
> ---
>
> Key: RAT-343
> URL: https://issues.apache.org/jira/browse/RAT-343
> Project: Apache Rat
> Issue Type: Bug
> Components: license-meta-data, scan, site
>Affects Versions: 0.16
>Reporter: Philipp Ottlinger
>Priority: Major
>
> Due to the changes introduced in 0.16 projects with custom license
> definitions do not seem to work anymore as reported by [~solomax] with
> OpenMeetings:
> [https://github.com/apache/openmeetings/blob/master/pom.xml#L1393]
> Verify that the documentation provided in
> [https://creadur.apache.org/rat/apache-rat-plugin/examples/custom-license.html]
> is correct and ideally add an example usage to
> [CreadurExamples|https://github.com/ottlinger/creadur-rat-examples] to
> prevent future regressions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (RAT-325) Performance degradation compared to 0.15
[
https://issues.apache.org/jira/browse/RAT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805491#comment-17805491
]
Maxim Solodovnik commented on RAT-325:
--
I'm currently testing {{0.16}}
the performance seems to degrade significantly (I'll provide exact numbers as
soon as I'll bypass new custom license syntax)
The weird thing I've noticed very lng delay between:
{code}
[INFO] --- apache-rat:0.16:check (default) @ openmeetings-web ---
[INFO] Rat check: Summary over all files. Unapproved: 6, unknown: 6, generated:
63, approved: 595 licenses.
{code}
and
{code}
[WARNING] Files with unapproved licenses:
/home/solomax/work/openmeetings/openmeetings/openmeetings-web/src/main/front/src/css/_cssemoticons.scss
/home/solomax/work/openmeetings/openmeetings/openmeetings-web/src/main/front/src/chat/cssemoticons.js
/home/solomax/work/openmeetings/openmeetings/openmeetings-web/src/main/webapp/css/theme_om/jquery-ui.css
/home/solomax/work/openmeetings/openmeetings/openmeetings-web/src/main/webapp/css/theme_om/jquery-ui.min.css
/home/solomax/work/openmeetings/openmeetings/openmeetings-web/src/main/webapp/css/images/audio.svg
/home/solomax/work/openmeetings/openmeetings/openmeetings-web/src/main/webapp/images/phone.svg
{code}
i.e. list of files with unapproved licensed is being printed for about minute
.
> Performance degradation compared to 0.15
>
>
> Key: RAT-325
> URL: https://issues.apache.org/jira/browse/RAT-325
> Project: Apache Rat
> Issue Type: Bug
> Components: cli
>Affects Versions: 0.16
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 0.17
>
>
> While testing 0.16-SNAPSHOT, I identified rat is much longer to execute than
> with 0.15.
> I'm investigating why.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (RAT-343) Custom licensenses not working in contrast to v0.15
[ https://issues.apache.org/jira/browse/RAT-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805016#comment-17805016 ] Maxim Solodovnik commented on RAT-343: -- [~claude] I believe #3 should be added: update the documentation :) I'm OK with changing our build, just not sure how :( > Custom licensenses not working in contrast to v0.15 > --- > > Key: RAT-343 > URL: https://issues.apache.org/jira/browse/RAT-343 > Project: Apache Rat > Issue Type: Bug > Components: license-meta-data, scan, site >Affects Versions: 0.16 >Reporter: Philipp Ottlinger >Priority: Major > > Due to the changes introduced in 0.16 projects with custom license > definitions do not seem to work anymore as reported by [~solomax] with > OpenMeetings: > [https://github.com/apache/openmeetings/blob/master/pom.xml#L1393] > Verify that the documentation provided in > [https://creadur.apache.org/rat/apache-rat-plugin/examples/custom-license.html] > is correct and ideally add an example usage to > [CreadurExamples|https://github.com/ottlinger/creadur-rat-examples] to > prevent future regressions. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-343) Custom licensenses not working in contrast to v0.15
[ https://issues.apache.org/jira/browse/RAT-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804608#comment-17804608 ] Maxim Solodovnik commented on RAT-343: -- Thanks for the fast reaction :) > Custom licensenses not working in contrast to v0.15 > --- > > Key: RAT-343 > URL: https://issues.apache.org/jira/browse/RAT-343 > Project: Apache Rat > Issue Type: Bug > Components: license-meta-data, scan, site >Affects Versions: 0.16 >Reporter: Philipp Ottlinger >Priority: Major > > Due to the changes introduced in 0.16 projects with custom license > definitions do not seem to work anymore as reported by [~solomax] with > OpenMeetings: > [https://github.com/apache/openmeetings/blob/master/pom.xml#L1393] > Verify that the documentation provided in > [https://creadur.apache.org/rat/apache-rat-plugin/examples/custom-license.html] > is correct and ideally add an example usage to > [CreadurExamples|https://github.com/ottlinger/creadur-rat-examples] to > prevent future regressions. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-309) Upgrade Maven Reporting API to 3.1.1/Complete with Maven Reporting Impl 3.2.0
[
https://issues.apache.org/jira/browse/RAT-309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17581659#comment-17581659
]
Maxim Solodovnik commented on RAT-309:
--
By bad: the issue is resolved by switching to {{maven-site-plugin:4.0.0-M3}}
sorry for the noise :(
> Upgrade Maven Reporting API to 3.1.1/Complete with Maven Reporting Impl 3.2.0
> -
>
> Key: RAT-309
> URL: https://issues.apache.org/jira/browse/RAT-309
> Project: Apache Rat
> Issue Type: Bug
>Affects Versions: 0.14
>Reporter: Michael Osipov
>Assignee: Philipp Ottlinger
>Priority: Major
> Fix For: 0.15
>
>
> This is basically a copy of MJAVADOC-723.
> It was discovered in RAT while verifying RAT-300 after 0.14 was released.
> [~michael-o] can you provide a bit more context? Does the problem have
> security implications apart from breaking the generation of maven-sites?
> Thanks
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (RAT-309) Upgrade Maven Reporting API to 3.1.1/Complete with Maven Reporting Impl 3.2.0
[
https://issues.apache.org/jira/browse/RAT-309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17581656#comment-17581656
]
Maxim Solodovnik commented on RAT-309:
--
Not sure If I should report separate issue or not :(
getting this error:
{code}
[INFO] Generating "Rat Report" report--- apache-rat-plugin:0.15-SNAPSHOT:rat
[WARNING] An issue has occurred with apache-rat-plugin:0.15-SNAPSHOT:rat
report, skipping LinkageError Receiver class org.apache.rat.mp.RatReportMojo
does not define or inherit an implementation of the resolved method 'abstract
void generate(org.codehaus.doxia.sink.Sink, java.util.Locale)' of interface
org.apache.maven.reporting.MavenReport., please report an issue to Maven dev
team.
java.lang.AbstractMethodError: Receiver class org.apache.rat.mp.RatReportMojo
does not define or inherit an implementation of the resolved method 'abstract
void generate(org.codehaus.doxia.sink.Sink, java.util.Locale)' of interface
org.apache.maven.reporting.MavenReport.
at
org.apache.maven.plugins.site.render.ReportDocumentRenderer.renderDocument
(ReportDocumentRenderer.java:235)
at org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.render
(DefaultSiteRenderer.java:348)
at org.apache.maven.plugins.site.render.SiteMojo.renderLocale
(SiteMojo.java:194)
at org.apache.maven.plugins.site.render.SiteMojo.execute (SiteMojo.java:143)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
(DefaultBuildPluginManager.java:137)
at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2
(MojoExecutor.java:370)
at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute
(MojoExecutor.java:351)
{code}
> Upgrade Maven Reporting API to 3.1.1/Complete with Maven Reporting Impl 3.2.0
> -
>
> Key: RAT-309
> URL: https://issues.apache.org/jira/browse/RAT-309
> Project: Apache Rat
> Issue Type: Bug
>Affects Versions: 0.14
>Reporter: Michael Osipov
>Assignee: Philipp Ottlinger
>Priority: Major
> Fix For: 0.15
>
>
> This is basically a copy of MJAVADOC-723.
> It was discovered in RAT while verifying RAT-300 after 0.14 was released.
> [~michael-o] can you provide a bit more context? Does the problem have
> security implications apart from breaking the generation of maven-sites?
> Thanks
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (RAT-294) Print files with unapproved license to console instead of only to a file in apache-rat-plugin to make it easier to understand on headless CI servers
[
https://issues.apache.org/jira/browse/RAT-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554909#comment-17554909
]
Maxim Solodovnik commented on RAT-294:
--
I can confirm
got at https://ci-builds.apache.org/job/OpenMeetings/job/openmeetings
Thanks for this! :)
{code}
[WARNING] Files with unapproved licenses:
.gitattributes
{code}
> Print files with unapproved license to console instead of only to a file in
> apache-rat-plugin to make it easier to understand on headless CI servers
>
>
> Key: RAT-294
> URL: https://issues.apache.org/jira/browse/RAT-294
> Project: Apache Rat
> Issue Type: Improvement
>Reporter: Michael Vorburger
>Priority: Major
> Fix For: 0.14
>
>
> Based on my experience with RAT in
> https://github.com/apache/logging-log4j2/pull/653:
> It would be cool if the {{apache-rat-plugin}} would just print the list of
> files with unapproved license to the console via STDOUT, instead of only into
> the {{target/rat.txt}} file - just because such files are typically much
> harder to get your hands on on a headless CI server than whatever was spewed
> to STDOUT on build logs.
> [~pottlinger]
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (RAT-303) Support https:// in apache license
[
https://issues.apache.org/jira/browse/RAT-303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17542804#comment-17542804
]
Maxim Solodovnik commented on RAT-303:
--
most waited ASF release :)))
> Support https:// in apache license
> --
>
> Key: RAT-303
> URL: https://issues.apache.org/jira/browse/RAT-303
> Project: Apache Rat
> Issue Type: Task
> Components: jar-license-meta-data
>Affects Versions: 0.13
>Reporter: Jarek Potiuk
>Priority: Major
> Fix For: 0.14
>
>
> Following the discussion in
> it would be great if "https://; is supported in Apache licence. Currently the
> license with modified link is not detected properly.
> h1. How to reproduce
> # Checkout apache airflow [https://github.com/apache/airflow/]
> # Modify airflow/templates.py and change http:// in license into https://
> # Run java -jar apache-rat-0.13.jar -E .rat-excludes -d .
> # Observe error produced:
>
> {{{}Printing headers for text files without a valid license
> header...{}}}{{{}={}}}
> {{== File: ./airflow/templates.py}}
> {{=}}
> {{#}}
> {{# Licensed to the Apache Software Foundation (ASF) under one}}
> {{# or more contributor license agreements. See the NOTICE file}}
> {{# distributed with this work for additional information}}
> {{# regarding copyright ownership. The ASF licenses this file}}
> {{# to you under the Apache License, Version 2.0 (the}}
> {{# "License"); you may not use this file except in compliance}}
> {{# with the License. You may obtain a copy of the License at}}
> {{#}}
> {{# https://www.apache.org/licenses/LICENSE-2.0}}
> {{#}}
> {{# Unless required by applicable law or agreed to in writing,}}
> {{# software distributed under the License is distributed on an}}
> {{# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY}}
> {{# KIND, either express or implied. See the License for the}}
> {{# specific language governing permissions and limitations}}
> {{{}# under the License.{}}}{{{}import jinja2.nativetypes{}}}
> {{import jinja2.sandbox}}
> {{class _AirflowEnvironmentMixin:}}
> {{ def __init__(self, **kwargs):}}
> {{ super().__init__(**kwargs)}}{{
> self.filters.update(FILTERS)}}{{ def is_safe_attribute(self, obj, attr,
> value):}}
> {{ """}}
> {{ Allow access to ``_`` prefix vars (but not ``__``).}}{{
> Unlike the stock SandboxedEnvironment, we allow access to "private"
> attributes (ones starting with}}
> {{ ``_``) whilst still blocking internal or truly private attributes
> (``__`` prefixed ones).}}
> {{ """}}
> {{ return not jinja2.sandbox.is_internal_attribute(obj, attr)}}
> {{class NativeEnvironment(_AirflowEnvironmentMixin,
> jinja2.nativetypes.NativeEnvironment):}}
> {{ """NativeEnvironment for Airflow task templates."""}}
> {{class SandboxedEnvironment(_AirflowEnvironmentMixin,
> jinja2.sandbox.SandboxedEnvironment):}}
> {{ """SandboxedEnvironment for Airflow task templates."""}}
> {{def ds_filter(value):}}
> {{ return value.strftime('%Y-%m-%d')}}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (RAT-303) Support https:// in apache license
[
https://issues.apache.org/jira/browse/RAT-303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17542799#comment-17542799
]
Maxim Solodovnik commented on RAT-303:
--
[~pottlinger] any ETA for the release? :)))
> Support https:// in apache license
> --
>
> Key: RAT-303
> URL: https://issues.apache.org/jira/browse/RAT-303
> Project: Apache Rat
> Issue Type: Task
> Components: jar-license-meta-data
>Affects Versions: 0.13
>Reporter: Jarek Potiuk
>Priority: Major
> Fix For: 0.14
>
>
> Following the discussion in
> it would be great if "https://; is supported in Apache licence. Currently the
> license with modified link is not detected properly.
> h1. How to reproduce
> # Checkout apache airflow [https://github.com/apache/airflow/]
> # Modify airflow/templates.py and change http:// in license into https://
> # Run java -jar apache-rat-0.13.jar -E .rat-excludes -d .
> # Observe error produced:
>
> {{{}Printing headers for text files without a valid license
> header...{}}}{{{}={}}}
> {{== File: ./airflow/templates.py}}
> {{=}}
> {{#}}
> {{# Licensed to the Apache Software Foundation (ASF) under one}}
> {{# or more contributor license agreements. See the NOTICE file}}
> {{# distributed with this work for additional information}}
> {{# regarding copyright ownership. The ASF licenses this file}}
> {{# to you under the Apache License, Version 2.0 (the}}
> {{# "License"); you may not use this file except in compliance}}
> {{# with the License. You may obtain a copy of the License at}}
> {{#}}
> {{# https://www.apache.org/licenses/LICENSE-2.0}}
> {{#}}
> {{# Unless required by applicable law or agreed to in writing,}}
> {{# software distributed under the License is distributed on an}}
> {{# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY}}
> {{# KIND, either express or implied. See the License for the}}
> {{# specific language governing permissions and limitations}}
> {{{}# under the License.{}}}{{{}import jinja2.nativetypes{}}}
> {{import jinja2.sandbox}}
> {{class _AirflowEnvironmentMixin:}}
> {{ def __init__(self, **kwargs):}}
> {{ super().__init__(**kwargs)}}{{
> self.filters.update(FILTERS)}}{{ def is_safe_attribute(self, obj, attr,
> value):}}
> {{ """}}
> {{ Allow access to ``_`` prefix vars (but not ``__``).}}{{
> Unlike the stock SandboxedEnvironment, we allow access to "private"
> attributes (ones starting with}}
> {{ ``_``) whilst still blocking internal or truly private attributes
> (``__`` prefixed ones).}}
> {{ """}}
> {{ return not jinja2.sandbox.is_internal_attribute(obj, attr)}}
> {{class NativeEnvironment(_AirflowEnvironmentMixin,
> jinja2.nativetypes.NativeEnvironment):}}
> {{ """NativeEnvironment for Airflow task templates."""}}
> {{class SandboxedEnvironment(_AirflowEnvironmentMixin,
> jinja2.sandbox.SandboxedEnvironment):}}
> {{ """SandboxedEnvironment for Airflow task templates."""}}
> {{def ds_filter(value):}}
> {{ return value.strftime('%Y-%m-%d')}}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (RAT-300) 0.13 not compatible with current Maven site plugin
[ https://issues.apache.org/jira/browse/RAT-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17535816#comment-17535816 ] Maxim Solodovnik commented on RAT-300: -- Thanks for the update [~pottlinger] ! > 0.13 not compatible with current Maven site plugin > -- > > Key: RAT-300 > URL: https://issues.apache.org/jira/browse/RAT-300 > Project: Apache Rat > Issue Type: Bug >Affects Versions: 0.13 >Reporter: Gary D. Gregory >Priority: Major > > The combination of 0.13 and Maven site plugin throws exceptions, see > reproducer in > [https://gist.github.com/garydgregory/967e40f120b8ed6f82d16cad973a2c4e] > Releasing 0.14 would fix this. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Resolved] (RAT-299) Maven console error
[
https://issues.apache.org/jira/browse/RAT-299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxim Solodovnik resolved RAT-299.
--
Resolution: Duplicate
Works as expected in latest SNAPSHOT
I should try it first
sorry for the noise :(
> Maven console error
> ---
>
> Key: RAT-299
> URL: https://issues.apache.org/jira/browse/RAT-299
> Project: Apache Rat
> Issue Type: Bug
> Components: maven
>Affects Versions: 0.13
>Reporter: Maxim Solodovnik
>Priority: Critical
>
> Just have updated {{maven-project-info-reports-plugin}} to version *3.2.2*
> Got these errors in console:
> {code}
> [INFO] Generating "Rat Report" report--- apache-rat-plugin:0.13:rat
> [WARNING] An issue has occurred with apache-rat-plugin:0.13:rat report,
> skipping LinkageError Receiver class org.apache.rat.mp.RatReportMojo does not
> define or inherit an implementation of the resolved method 'abstract void
> generate(org.apache.maven.doxia.sink.Sink, java.util.Locale)' of interface
> org.apache.maven.reporting.MavenReport., please report an issue to Maven dev
> team.
> java.lang.AbstractMethodError: Receiver class org.apache.rat.mp.RatReportMojo
> does not define or inherit an implementation of the resolved method 'abstract
> void generate(org.apache.maven.doxia.sink.Sink, java.util.Locale)' of
> interface org.apache.maven.reporting.MavenReport.
> at
> org.apache.maven.plugins.site.render.ReportDocumentRenderer.renderDocument
> (ReportDocumentRenderer.java:235)
> at org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.render
> (DefaultSiteRenderer.java:348)
> at org.apache.maven.plugins.site.render.SiteMojo.renderLocale
> (SiteMojo.java:194)
> {code}
> I would like to help with releasing of *apache-rat-plugin:0.14* :)
> let's try to release :)
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Created] (RAT-299) Maven console error
Maxim Solodovnik created RAT-299:
Summary: Maven console error
Key: RAT-299
URL: https://issues.apache.org/jira/browse/RAT-299
Project: Apache Rat
Issue Type: Bug
Components: maven
Affects Versions: 0.13
Reporter: Maxim Solodovnik
Just have updated {{maven-project-info-reports-plugin}} to version *3.2.2*
Got these errors in console:
{code}
[INFO] Generating "Rat Report" report--- apache-rat-plugin:0.13:rat
[WARNING] An issue has occurred with apache-rat-plugin:0.13:rat report,
skipping LinkageError Receiver class org.apache.rat.mp.RatReportMojo does not
define or inherit an implementation of the resolved method 'abstract void
generate(org.apache.maven.doxia.sink.Sink, java.util.Locale)' of interface
org.apache.maven.reporting.MavenReport., please report an issue to Maven dev
team.
java.lang.AbstractMethodError: Receiver class org.apache.rat.mp.RatReportMojo
does not define or inherit an implementation of the resolved method 'abstract
void generate(org.apache.maven.doxia.sink.Sink, java.util.Locale)' of interface
org.apache.maven.reporting.MavenReport.
at
org.apache.maven.plugins.site.render.ReportDocumentRenderer.renderDocument
(ReportDocumentRenderer.java:235)
at org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.render
(DefaultSiteRenderer.java:348)
at org.apache.maven.plugins.site.render.SiteMojo.renderLocale
(SiteMojo.java:194)
{code}
I would like to help with releasing of *apache-rat-plugin:0.14* :)
let's try to release :)
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (RAT-230) Short Apache header is not accepted by apache-rat-plugin
[
https://issues.apache.org/jira/browse/RAT-230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929942#comment-15929942
]
Maxim Solodovnik commented on RAT-230:
--
Will try :)
> Short Apache header is not accepted by apache-rat-plugin
>
>
> Key: RAT-230
> URL: https://issues.apache.org/jira/browse/RAT-230
> Project: Apache Rat
> Issue Type: Bug
> Components: maven
>Affects Versions: 0.12
>Reporter: Maxim Solodovnik
>Assignee: Karl Heinz Marbaise
> Fix For: 0.13
>
>
> Short Apache header, available here:
> https://www.apache.org/legal/src-headers.html#is-a-short-form-of-the-source-header-available
> is not accepted by maven-rat-plugin :(
> to test:
> create build.properties with following contents
> {code}
> #Licensed to the Apache Software Foundation (ASF) under one or more
> contributor license agreements; and to You under the Apache License, Version
> 2.0.
> buildnumber=AAA
> {code}
> run build
> File is listed as Unapproved
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Created] (RAT-230) Short Apache header is not accepted by maven-rat-plugin
Maxim Solodovnik created RAT-230:
Summary: Short Apache header is not accepted by maven-rat-plugin
Key: RAT-230
URL: https://issues.apache.org/jira/browse/RAT-230
Project: Apache Rat
Issue Type: Bug
Components: maven
Affects Versions: 0.12
Reporter: Maxim Solodovnik
Short Apache header, available here:
https://www.apache.org/legal/src-headers.html#is-a-short-form-of-the-source-header-available
is not accepted by maven-rat-plugin :(
to test:
create build.properties with following contents
{code}
#Licensed to the Apache Software Foundation (ASF) under one or more contributor
license agreements; and to You under the Apache License, Version 2.0.
buildnumber=AAA
{code}
run build
File is listed as Unapproved
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (RAT-229) Mp3 files are not treated as binary
[ https://issues.apache.org/jira/browse/RAT-229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902330#comment-15902330 ] Maxim Solodovnik commented on RAT-229: -- Example report: https://builds.apache.org/view/M-R/view/OpenMeetings/job/Openmeetings%203.2.x/ws/openmeetings-web/target/rat.txt > Mp3 files are not treated as binary > --- > > Key: RAT-229 > URL: https://issues.apache.org/jira/browse/RAT-229 > Project: Apache Rat > Issue Type: Bug >Affects Versions: 0.12 >Reporter: Maxim Solodovnik > > Mp3 file are not treated as binary and being printed as apache incompatible > to the report -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (RAT-229) Mp3 files are not treated as binary
Maxim Solodovnik created RAT-229: Summary: Mp3 files are not treated as binary Key: RAT-229 URL: https://issues.apache.org/jira/browse/RAT-229 Project: Apache Rat Issue Type: Bug Affects Versions: 0.12 Reporter: Maxim Solodovnik Mp3 file are not treated as binary and being printed as apache incompatible to the report -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (RAT-179) Maven plugin and Ant task do not support adding extra approved licences
[ https://issues.apache.org/jira/browse/RAT-179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Solodovnik updated RAT-179: - Attachment: rat-179.zip Example of Ant project Maven plugin and Ant task do not support adding extra approved licences --- Key: RAT-179 URL: https://issues.apache.org/jira/browse/RAT-179 Project: Apache Rat Issue Type: Bug Components: antlib, maven Affects Versions: 0.11 Reporter: Sebb Assignee: Philipp Ottlinger Attachments: RAT-179.tar.gz, rat-179.zip Users can add new license types using the licenses tag. h3. Affects: Maven- and ANT plugin h4. Maven These are not added to the approved licenses list. This has to be done through the licenseFamilies tag. However, the entries replace the defaults. There does not appear to be any way to update the approved list other than replacing it entirely, which is very inconvenient. This could be fixed by adding a new property analagous to addDefaultLicenseMatchers, e.g. addDefaultLicenseFamilies Or it might be easier for the user to configure if individual license entries could be tagged as approved. The default would need to be false for backwards compatibility. h4. Ant Same issue for Ant task; rat:approvedLicense/ configs replace the default set. Reported by [~solomax] via [mail|http://rat.markmail.org/thread/3qdpynxpejujbzm7#query:+page:1+mid:6c6nnolaydznkqhd+state:results] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
