Re: [PR] RAT-343: Enhance documentation about new configuration options [creadur-rat]

2024-01-16 Thread via GitHub


ottlinger merged PR #199:
URL: https://github.com/apache/creadur-rat/pull/199


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] RAT-343: Enhance documentation about new configuration options [creadur-rat]

2024-01-15 Thread via GitHub


solomax commented on PR #199:
URL: https://github.com/apache/creadur-rat/pull/199#issuecomment-1892969743

   @ottlinger Thanks for the additional examples! Everything is very clear :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] RAT-343: Enhance documentation about new configuration options [creadur-rat]

2024-01-15 Thread via GitHub


ottlinger commented on PR #199:
URL: https://github.com/apache/creadur-rat/pull/199#issuecomment-1892470369

   @solomax does the current version contain all your answers or did we miss 
something? спасибо
   
https://creadur.apache.org/rat0161/apache-rat-plugin/examples/custom-license.html
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] RAT-343: Enhance documentation about new configuration options [creadur-rat]

2024-01-14 Thread via GitHub


solomax commented on PR #199:
URL: https://github.com/apache/creadur-rat/pull/199#issuecomment-1891269178

   And maybe a NOTE regarding custom license name 
   Like `If default licences are enabled, please make sure custom license has 
unique name` :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] RAT-343: Enhance documentation about new configuration options [creadur-rat]

2024-01-14 Thread via GitHub


solomax commented on PR #199:
URL: https://github.com/apache/creadur-rat/pull/199#issuecomment-1891267871

   @ottlinger Maybe it would be possible to add example for `Matcher details` 
section? :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] RAT-343: Enhance documentation about new configuration options [creadur-rat]

2024-01-14 Thread via GitHub


garydgregory commented on PR #199:
URL: https://github.com/apache/creadur-rat/pull/199#issuecomment-1891085200

   When I got the error in 0.16.0, the first thing I did was look at the site, 
whi h was wrong. Then the JIRA was updated with corrected XML, so I used that. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] RAT-343: Enhance documentation about new configuration options [creadur-rat]

2024-01-14 Thread via GitHub


ottlinger commented on PR #199:
URL: https://github.com/apache/creadur-rat/pull/199#issuecomment-1891079323

   @Claudenw pls review - I already deployed this branch to:
   
https://creadur.apache.org/rat0161/apache-rat-plugin/examples/custom-license.html
   
   --
   
   @solomax @garydgregory would this info be helpful for you (if it had been 
included in r0.16 ;))
   Thanks for feedback.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org