[jira] [Commented] (RAT-107) useEclipseDefaultExcludes does not ignore sub-module's eclipse dotfiles.
[ https://issues.apache.org/jira/browse/RAT-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14056184#comment-14056184 ] ASF GitHub Bot commented on RAT-107: Github user richardcloudsoft commented on a diff in the pull request: https://github.com/apache/incubator-brooklyn/pull/49#discussion_r14706993 --- Diff: pom.xml --- @@ -678,6 +662,64 @@ + + + org.apache.rat + apache-rat-plugin + 0.10 + + + verify + +check + + + + + + + + + **/.git/** + **/.gitignore + **/.idea/** + **/*.iml + **/.classpath/** + **/.project + **/.settings/** + **/*.log + **/brooklyn*.log.* + + ignored/** + LICENSE.md + **/MANIFEST.MF + **/test-output/** + **/*.pem.pub + **/*.svg + **/*.crt + **/*.csr + **/*.key + **/*.key.org + **/*.psd + **/*.json --- End diff -- s/jClouds/jclouds/ `` > useEclipseDefaultExcludes does not ignore sub-module's eclipse dotfiles. > > > Key: RAT-107 > URL: https://issues.apache.org/jira/browse/RAT-107 > Project: Apache Rat > Issue Type: Bug > Components: maven >Affects Versions: 0.8 > Environment: Maven 3.03, Java 1.6.0_29, eclipse Indigo Service > release 1 >Reporter: jv > Labels: eclipse, maven > Attachments: apache-rat-project-RAT-107.patch > > > useEclipseDefaultExcludes works for ignoring eclipse dotfiles in the parent > pom's directory, but when used in conjuction with excludeSubProjects=false, > subProjects eclipse dotfiles are not ignored and I believe they should be. > This can be recreated by having a maven project with integrated submodules, > and setting up RAT to false and > true. In the generated > output file you will see the .project and .settings file/folder are not > included in the check, but the /.project and /.settings > file/folder are checked (and will presumably fail). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (RAT-107) useEclipseDefaultExcludes does not ignore sub-module's eclipse dotfiles.
[ https://issues.apache.org/jira/browse/RAT-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14056170#comment-14056170 ] ASF GitHub Bot commented on RAT-107: Github user Nakomis commented on a diff in the pull request: https://github.com/apache/incubator-brooklyn/pull/49#discussion_r14706576 --- Diff: pom.xml --- @@ -678,6 +662,64 @@ + + + org.apache.rat + apache-rat-plugin + 0.10 + + + verify + +check + + + + + + + + + **/.git/** + **/.gitignore + **/.idea/** + **/*.iml + **/.classpath/** + **/.project + **/.settings/** + **/*.log + **/brooklyn*.log.* + + ignored/** + LICENSE.md + **/MANIFEST.MF + **/test-output/** + **/*.pem.pub + **/*.svg + **/*.crt + **/*.csr + **/*.key + **/*.key.org + **/*.psd + **/*.json --- End diff -- I excluded json as it doesn't support comments, I had a quick look at json files in jClouds (just as an example of an Apache TLP) and their json files don't include the apache header > useEclipseDefaultExcludes does not ignore sub-module's eclipse dotfiles. > > > Key: RAT-107 > URL: https://issues.apache.org/jira/browse/RAT-107 > Project: Apache Rat > Issue Type: Bug > Components: maven >Affects Versions: 0.8 > Environment: Maven 3.03, Java 1.6.0_29, eclipse Indigo Service > release 1 >Reporter: jv > Labels: eclipse, maven > Attachments: apache-rat-project-RAT-107.patch > > > useEclipseDefaultExcludes works for ignoring eclipse dotfiles in the parent > pom's directory, but when used in conjuction with excludeSubProjects=false, > subProjects eclipse dotfiles are not ignored and I believe they should be. > This can be recreated by having a maven project with integrated submodules, > and setting up RAT to false and > true. In the generated > output file you will see the .project and .settings file/folder are not > included in the check, but the /.project and /.settings > file/folder are checked (and will presumably fail). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (RAT-107) useEclipseDefaultExcludes does not ignore sub-module's eclipse dotfiles.
[ https://issues.apache.org/jira/browse/RAT-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14056154#comment-14056154 ] ASF GitHub Bot commented on RAT-107: Github user aledsage commented on a diff in the pull request: https://github.com/apache/incubator-brooklyn/pull/49#discussion_r14705875 --- Diff: pom.xml --- @@ -678,6 +662,64 @@ + + + org.apache.rat + apache-rat-plugin + 0.10 + + + verify + +check + + + + + + + + + **/.git/** + **/.gitignore + **/.idea/** + **/*.iml + **/.classpath/** + **/.project + **/.settings/** + **/*.log + **/brooklyn*.log.* + + ignored/** + LICENSE.md + **/MANIFEST.MF + **/test-output/** + **/*.pem.pub + **/*.svg + **/*.crt + **/*.csr + **/*.key + **/*.key.org + **/*.psd + **/*.json + **/*.plxarc + **/services/brooklyn.location.LocationResolver --- End diff -- Presumably these services files could have the comment at the top as well? Not sure if required. @richardcloudsoft what do you think? > useEclipseDefaultExcludes does not ignore sub-module's eclipse dotfiles. > > > Key: RAT-107 > URL: https://issues.apache.org/jira/browse/RAT-107 > Project: Apache Rat > Issue Type: Bug > Components: maven >Affects Versions: 0.8 > Environment: Maven 3.03, Java 1.6.0_29, eclipse Indigo Service > release 1 >Reporter: jv > Labels: eclipse, maven > Attachments: apache-rat-project-RAT-107.patch > > > useEclipseDefaultExcludes works for ignoring eclipse dotfiles in the parent > pom's directory, but when used in conjuction with excludeSubProjects=false, > subProjects eclipse dotfiles are not ignored and I believe they should be. > This can be recreated by having a maven project with integrated submodules, > and setting up RAT to false and > true. In the generated > output file you will see the .project and .settings file/folder are not > included in the check, but the /.project and /.settings > file/folder are checked (and will presumably fail). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (RAT-107) useEclipseDefaultExcludes does not ignore sub-module's eclipse dotfiles.
[ https://issues.apache.org/jira/browse/RAT-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14056152#comment-14056152 ] ASF GitHub Bot commented on RAT-107: Github user aledsage commented on a diff in the pull request: https://github.com/apache/incubator-brooklyn/pull/49#discussion_r14705854 --- Diff: pom.xml --- @@ -678,6 +662,64 @@ + + + org.apache.rat + apache-rat-plugin + 0.10 + + + verify + +check + + + + + + + + + **/.git/** + **/.gitignore + **/.idea/** + **/*.iml + **/.classpath/** + **/.project + **/.settings/** + **/*.log + **/brooklyn*.log.* + + ignored/** + LICENSE.md + **/MANIFEST.MF + **/test-output/** + **/*.pem.pub + **/*.svg + **/*.crt + **/*.csr + **/*.key + **/*.key.org + **/*.psd + **/*.json --- End diff -- Is this ok to exclude? > useEclipseDefaultExcludes does not ignore sub-module's eclipse dotfiles. > > > Key: RAT-107 > URL: https://issues.apache.org/jira/browse/RAT-107 > Project: Apache Rat > Issue Type: Bug > Components: maven >Affects Versions: 0.8 > Environment: Maven 3.03, Java 1.6.0_29, eclipse Indigo Service > release 1 >Reporter: jv > Labels: eclipse, maven > Attachments: apache-rat-project-RAT-107.patch > > > useEclipseDefaultExcludes works for ignoring eclipse dotfiles in the parent > pom's directory, but when used in conjuction with excludeSubProjects=false, > subProjects eclipse dotfiles are not ignored and I believe they should be. > This can be recreated by having a maven project with integrated submodules, > and setting up RAT to false and > true. In the generated > output file you will see the .project and .settings file/folder are not > included in the check, but the /.project and /.settings > file/folder are checked (and will presumably fail). -- This message was sent by Atlassian JIRA (v6.2#6252)
