[jira] [Commented] (RAT-212) pom.xml license failure when url is https
[ https://issues.apache.org/jira/browse/RAT-212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15159506#comment-15159506 ] Christopher Tubbs commented on RAT-212: --- Example failure: {code:xml} Apache License, Version 2.0 https://www.apache.org/licenses/LICENSE-2.0 repo {code} Example success: {code:xml} Apache License, Version 2.0 http://www.apache.org/licenses/LICENSE-2.0 repo {code} > pom.xml license failure when url is https > - > > Key: RAT-212 > URL: https://issues.apache.org/jira/browse/RAT-212 > Project: Apache Rat > Issue Type: Bug >Affects Versions: 0.11 >Reporter: Christopher Tubbs > > apache-rat-plugin:check fails when the license information in the POM has a > url of "https://www.apache.org/licenses/LICENSE-2.0";, but not when it has a > url of "http://www.apache.org/licenses/LICENSE-2.0"; > It should probably not fail in the case of https. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (RAT-212) pom.xml license failure when url is https
[ https://issues.apache.org/jira/browse/RAT-212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15159720#comment-15159720 ] Philipp Ottlinger commented on RAT-212: --- Thanks for your report - since RAT scans for license snippets you may use the following workaround: * keep https in your pom url-structure * add a valid license header to your pom.xml such as: {code} http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd";> 4.0.0 {code} This solves the issue. I was not aware that we perform a scan of the pom's structure. I always thought we parse for a license snippet instead > pom.xml license failure when url is https > - > > Key: RAT-212 > URL: https://issues.apache.org/jira/browse/RAT-212 > Project: Apache Rat > Issue Type: Bug >Affects Versions: 0.11 >Reporter: Christopher Tubbs > > apache-rat-plugin:check fails when the license information in the POM has a > url of "https://www.apache.org/licenses/LICENSE-2.0";, but not when it has a > url of "http://www.apache.org/licenses/LICENSE-2.0"; > It should probably not fail in the case of https. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (RAT-212) pom.xml license failure when url is https
[ https://issues.apache.org/jira/browse/RAT-212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15159769#comment-15159769 ] Christopher Tubbs commented on RAT-212: --- Perhaps the parsing of the license snippet is also sensitive to http vs. https? I haven't tried. I only happened to notice this issue on an external (non-ASF) POM which uses the apache-rat-plugin. > pom.xml license failure when url is https > - > > Key: RAT-212 > URL: https://issues.apache.org/jira/browse/RAT-212 > Project: Apache Rat > Issue Type: Bug >Affects Versions: 0.11 >Reporter: Christopher Tubbs > > apache-rat-plugin:check fails when the license information in the POM has a > url of "https://www.apache.org/licenses/LICENSE-2.0";, but not when it has a > url of "http://www.apache.org/licenses/LICENSE-2.0"; > It should probably not fail in the case of https. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (RAT-212) pom.xml license failure when url is https
[ https://issues.apache.org/jira/browse/RAT-212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15381217#comment-15381217 ] Philipp Ottlinger commented on RAT-212: --- [~ctubbsii] if you get an okay from the legal team that a https-variant of the header is still licence-compliant we could easily add a workaround for your issue. > pom.xml license failure when url is https > - > > Key: RAT-212 > URL: https://issues.apache.org/jira/browse/RAT-212 > Project: Apache Rat > Issue Type: Bug >Affects Versions: 0.11 >Reporter: Christopher Tubbs > > apache-rat-plugin:check fails when the license information in the POM has a > url of "https://www.apache.org/licenses/LICENSE-2.0";, but not when it has a > url of "http://www.apache.org/licenses/LICENSE-2.0"; > It should probably not fail in the case of https. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (RAT-212) pom.xml license failure when url is https
[ https://issues.apache.org/jira/browse/RAT-212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15381322#comment-15381322 ] Christopher Tubbs commented on RAT-212: --- No problem, LEGAL-265 is the blocking issue. > pom.xml license failure when url is https > - > > Key: RAT-212 > URL: https://issues.apache.org/jira/browse/RAT-212 > Project: Apache Rat > Issue Type: Bug >Affects Versions: 0.11 >Reporter: Christopher Tubbs > > apache-rat-plugin:check fails when the license information in the POM has a > url of "https://www.apache.org/licenses/LICENSE-2.0";, but not when it has a > url of "http://www.apache.org/licenses/LICENSE-2.0"; > It should probably not fail in the case of https. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (RAT-212) pom.xml license failure when url is https
[ https://issues.apache.org/jira/browse/RAT-212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848744#comment-16848744 ] Niels Basjes commented on RAT-212: -- I put up a pull request that should fix this and simply support all urls mentioned in the LEGAL-265 ticket. Please review. > pom.xml license failure when url is https > - > > Key: RAT-212 > URL: https://issues.apache.org/jira/browse/RAT-212 > Project: Apache Rat > Issue Type: Bug >Affects Versions: 0.11 >Reporter: Christopher Tubbs >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > apache-rat-plugin:check fails when the license information in the POM has a > url of "https://www.apache.org/licenses/LICENSE-2.0";, but not when it has a > url of "http://www.apache.org/licenses/LICENSE-2.0"; > It should probably not fail in the case of https. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RAT-212) pom.xml license failure when url is https
[ https://issues.apache.org/jira/browse/RAT-212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849212#comment-16849212 ] Niels Basjes commented on RAT-212: -- In my working copy of Avro I had this additional rat config as a temporary workaround {{}} {{ }} {{ Also allow the license url to be https.}} {{ }} {{ https://www.apache.org/licenses/LICENSE-2.0}} {{ }} {{ }} {{}} I build rat from source, removed this config from my code and ran with Rat 0.14-SNAPSHOT Worked as expected. Thanks. > pom.xml license failure when url is https > - > > Key: RAT-212 > URL: https://issues.apache.org/jira/browse/RAT-212 > Project: Apache Rat > Issue Type: Bug >Affects Versions: 0.11 >Reporter: Christopher Tubbs >Priority: Major > Fix For: 0.14 > > Time Spent: 20m > Remaining Estimate: 0h > > apache-rat-plugin:check fails when the license information in the POM has a > url of "https://www.apache.org/licenses/LICENSE-2.0";, but not when it has a > url of "http://www.apache.org/licenses/LICENSE-2.0"; > It should probably not fail in the case of https. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RAT-212) pom.xml license failure when url is https
[ https://issues.apache.org/jira/browse/RAT-212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17477305#comment-17477305 ] Jorge Solórzano commented on RAT-212: - Is there an ETA for the 0.14 release that includes this fix? > pom.xml license failure when url is https > - > > Key: RAT-212 > URL: https://issues.apache.org/jira/browse/RAT-212 > Project: Apache Rat > Issue Type: Bug >Affects Versions: 0.11 >Reporter: Christopher Tubbs >Priority: Major > Fix For: 0.14 > > Time Spent: 20m > Remaining Estimate: 0h > > apache-rat-plugin:check fails when the license information in the POM has a > url of "https://www.apache.org/licenses/LICENSE-2.0";, but not when it has a > url of "http://www.apache.org/licenses/LICENSE-2.0"; > It should probably not fail in the case of https. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (RAT-212) pom.xml license failure when url is https
[ https://issues.apache.org/jira/browse/RAT-212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17554805#comment-17554805 ] Philipp Ottlinger commented on RAT-212: --- [~jorsol] [~nielsbasjes] [~ctubbsii] feel free to verify with 0.14 and close the issue. Thanks > pom.xml license failure when url is https > - > > Key: RAT-212 > URL: https://issues.apache.org/jira/browse/RAT-212 > Project: Apache Rat > Issue Type: Bug >Affects Versions: 0.11 >Reporter: Christopher Tubbs >Priority: Major > Fix For: 0.14 > > Time Spent: 20m > Remaining Estimate: 0h > > apache-rat-plugin:check fails when the license information in the POM has a > url of "https://www.apache.org/licenses/LICENSE-2.0";, but not when it has a > url of "http://www.apache.org/licenses/LICENSE-2.0"; > It should probably not fail in the case of https. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (RAT-212) pom.xml license failure when url is https
[ https://issues.apache.org/jira/browse/RAT-212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17554889#comment-17554889 ] Christopher Tubbs commented on RAT-212: --- I can confirm it works now with https. Applied to a moderately sized project in https://github.com/apache/accumulo/pull/2774 and works great. > pom.xml license failure when url is https > - > > Key: RAT-212 > URL: https://issues.apache.org/jira/browse/RAT-212 > Project: Apache Rat > Issue Type: Bug >Affects Versions: 0.11 >Reporter: Christopher Tubbs >Priority: Major > Fix For: 0.14 > > Time Spent: 20m > Remaining Estimate: 0h > > apache-rat-plugin:check fails when the license information in the POM has a > url of "https://www.apache.org/licenses/LICENSE-2.0";, but not when it has a > url of "http://www.apache.org/licenses/LICENSE-2.0"; > It should probably not fail in the case of https. -- This message was sent by Atlassian Jira (v8.20.7#820007)