Re: Is it OK to commit to trunk?

[Dennis Lundberg]

Seems I spoke to soon...
I need to fix the failing tests first.

On Tue, Nov 26, 2013 at 8:19 PM, Dennis Lundberg denn...@apache.org wrote:
 Hi Robert

 All my changes have been checked into trunk now.
 Feel free to merge when you have the time and strength for it.
 Give me a shout if you run into conflicts because of my changes.

 On Sat, Nov 16, 2013 at 10:40 AM, Robert Burrell Donkin
 rdon...@apache.org wrote:
 On 09/28/13 16:53, Dennis Lundberg wrote:

 Hi all,


 Hi Dennis


 I've got a bunch of small changes to Rat sitting on my local machine.
 Before I commit them, I wanted to ask if it's OK to commit to trunk,
 due to the pending changes made through GSOC.


 It'd be great to have your changes in trunk before merging the GSoc stuff.
 But if that's not possible, then I'd be happy to take a look at a patch if
 you're short of time.

 Robert



 --
 Dennis Lundberg



-- 
Dennis Lundberg

Re: Is it OK to commit to trunk?

[Robert Burrell Donkin]

On 11/26/13 20:58, Dennis Lundberg wrote:

All done!


Great :-)


On Tue, Nov 26, 2013 at 8:21 PM, Dennis Lundberg denn...@apache.org wrote:

Seems I spoke to soon...
I need to fix the failing tests first.

On Tue, Nov 26, 2013 at 8:19 PM, Dennis Lundberg denn...@apache.org wrote:

Hi Robert


Hi Dennis


All my changes have been checked into trunk now.
Feel free to merge when you have the time and strength for it.


I'm feeling good ATM, currently 375/555 commits into the merger of the 
GitHub code into the branch :-)



Give me a shout if you run into conflicts because of my changes.


Great I will do

I aspire to having the GSoc code in the subversion branch by the end of 
the week, so hopefully I'll be merging in your changes at the weekend :-)


Robert