[jira] [Resolved] (RAT-175) SourceCodeManagementSystems.hasIgnoreFile() should return boolean
[ https://issues.apache.org/jira/browse/RAT-175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved RAT-175. -- Resolution: Fixed URL: http://svn.apache.org/r1625239 Log: RAT-175 - SourceCodeManagementSystems.hasIgnoreFile() should return boolean Modified: creadur/rat/trunk/RELEASE_NOTES.txt creadur/rat/trunk/apache-rat-core/src/main/java/org/apache/rat/config/SourceCodeManagementSystems.java SourceCodeManagementSystems.hasIgnoreFile() should return boolean - Key: RAT-175 URL: https://issues.apache.org/jira/browse/RAT-175 Project: Apache Rat Issue Type: Bug Affects Versions: 0.11 Reporter: Sebb org.apache.rat.config.SourceCodeManagementSystems.hasIgnoreFile() currently returns Boolean. It should return boolean, to avoid the boxing conversions. AFAICT it is never used as a Boolean, only as a boolean -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (RAT-175) SourceCodeManagementSystems.hasIgnoreFile() should return boolean
[ https://issues.apache.org/jira/browse/RAT-175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb updated RAT-175: - Affects Version/s: 0.11 SourceCodeManagementSystems.hasIgnoreFile() should return boolean - Key: RAT-175 URL: https://issues.apache.org/jira/browse/RAT-175 Project: Apache Rat Issue Type: Bug Affects Versions: 0.11 Reporter: Sebb Fix For: 0.12 org.apache.rat.config.SourceCodeManagementSystems.hasIgnoreFile() currently returns Boolean. It should return boolean, to avoid the boxing conversions. AFAICT it is never used as a Boolean, only as a boolean -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (RAT-176) BinaryGuesser.isBinary(String name) ought to throw for null input
Sebb created RAT-176: Summary: BinaryGuesser.isBinary(String name) ought to throw for null input Key: RAT-176 URL: https://issues.apache.org/jira/browse/RAT-176 Project: Apache Rat Issue Type: Bug Affects Versions: 0.11 Reporter: Sebb Priority: Minor BinaryGuesser.isBinary(String name) currently just returns false for null input. It probably ought to return NPE (but this might mean some internal calls need to be updated) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Reopened] (RAT-81) MalformedInputException thrown when RAT tries reading file
[ https://issues.apache.org/jira/browse/RAT-81?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb reopened RAT-81: - Assignee: (was: Stefan Bodewig) It does not seem right to me to mark XML files with invalid contents as binary. Binary implies that the file does not need a license, but that is not the case. Such files should still have a valid license (unless excluded), so RAT should report the file as unreadable or similar. MalformedInputException thrown when RAT tries reading file -- Key: RAT-81 URL: https://issues.apache.org/jira/browse/RAT-81 Project: Apache Rat Issue Type: Bug Components: engine Affects Versions: 0.6, 0.7 Environment: Linux (Ubuntu) on x86, running with default file encoding set to UTF-8 Reporter: Marshall Schor Priority: Minor Fix For: 0.8 To reproduce, set the platform default locale to something that indicates UTF-8 file encoding. This causes code in (for example) org.apache.rat.document.impl.FileDocument which return FileReader to set up RAT to use a reader which is using the platform default character encoding (in this case UTF-8). If the file being processed is not encoded in this , it is possible that the reader will read some data which is invalid UTF-8 encodings, which causes the reader to throw a MalformedInputException error. One case we found: The file being examined had invalid UTF-8 encodings. First, Rat ran the BinaryGuesser - but that returned false because it attempted to read the first 100 or so chars, and got a MalformedInputException instead, so the try/catch block just ended up returning false (not binary). Then the HeaderChecker tried to read the file to check the header, and got this same exception - but this time, it made RAT fail. Here's the last part of the stack trace: Caused by: org.apache.rat.report.RatReportFailedException: Analysis failed at org.apache.rat.report.xml.XmlReport.report(XmlReport.java:66) at org.apache.rat.mp.FilesReportable.run(FilesReportable.java:69) at org.apache.rat.Report.report(Report.java:292) at org.apache.rat.Report.report(Report.java:272) at org.apache.rat.mp.AbstractRatMojo.createReport(AbstractRatMojo.java:341) ... 23 more Caused by: org.apache.rat.document.RatDocumentAnalysisException: Cannot analyse header at org.apache.rat.report.analyser.DocumentHeaderAnalyser.analyse(DocumentHeaderAnalyser.java:54) at org.apache.rat.document.impl.util.DocumentAnalyserMultiplexer.analyse(DocumentAnalyserMultiplexer.java:37) at org.apache.rat.document.impl.util.ConditionalAnalyser.matches(ConditionalAnalyser.java:44) at org.apache.rat.document.impl.util.ConditionalAnalyser.analyse(ConditionalAnalyser.java:50) at org.apache.rat.report.xml.XmlReport.report(XmlReport.java:64) ... 27 more Caused by: org.apache.rat.analysis.RatHeaderAnalysisException: Cannot read header for /home/tgoetz/tmp/uimaj-2.3.1/uimaj-core/src/test/resources/pearTests/encodingTests/UTF16_with_signature.xml at org.apache.rat.report.analyser.HeaderCheckWorker.read(HeaderCheckWorker.java:96) at org.apache.rat.report.analyser.DocumentHeaderAnalyser.analyse(DocumentHeaderAnalyser.java:50) ... 31 more Caused by: sun.io.MalformedInputException at sun.io.ByteToCharUTF8.convert(ByteToCharUTF8.java:294) at sun.nio.cs.StreamDecoder$ConverterSD.convertInto(StreamDecoder.java:316) at sun.nio.cs.StreamDecoder$ConverterSD.implRead(StreamDecoder.java:366) at sun.nio.cs.StreamDecoder.read(StreamDecoder.java:252) at java.io.InputStreamReader.read(InputStreamReader.java:212) at java.io.BufferedReader.fill(BufferedReader.java:157) at java.io.BufferedReader.readLine(BufferedReader.java:320) at java.io.BufferedReader.readLine(BufferedReader.java:383) at org.apache.rat.report.analyser.HeaderCheckWorker.readLine(HeaderCheckWorker.java:111) at org.apache.rat.report.analyser.HeaderCheckWorker.read(HeaderCheckWorker.java:89) ... 32 more Work-around: mark these files for explicit exclusion. Fix: change the binaryguesser to read the files in binary (not assuming any character coding) and operate with that data. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (RAT-81) MalformedInputException thrown when RAT tries reading file
[ https://issues.apache.org/jira/browse/RAT-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14135430#comment-14135430 ] Sebb commented on RAT-81: - Also I'm not sure that the test files do have any errors in them MalformedInputException thrown when RAT tries reading file -- Key: RAT-81 URL: https://issues.apache.org/jira/browse/RAT-81 Project: Apache Rat Issue Type: Bug Components: engine Affects Versions: 0.6, 0.7 Environment: Linux (Ubuntu) on x86, running with default file encoding set to UTF-8 Reporter: Marshall Schor Priority: Minor Fix For: 0.8 To reproduce, set the platform default locale to something that indicates UTF-8 file encoding. This causes code in (for example) org.apache.rat.document.impl.FileDocument which return FileReader to set up RAT to use a reader which is using the platform default character encoding (in this case UTF-8). If the file being processed is not encoded in this , it is possible that the reader will read some data which is invalid UTF-8 encodings, which causes the reader to throw a MalformedInputException error. One case we found: The file being examined had invalid UTF-8 encodings. First, Rat ran the BinaryGuesser - but that returned false because it attempted to read the first 100 or so chars, and got a MalformedInputException instead, so the try/catch block just ended up returning false (not binary). Then the HeaderChecker tried to read the file to check the header, and got this same exception - but this time, it made RAT fail. Here's the last part of the stack trace: Caused by: org.apache.rat.report.RatReportFailedException: Analysis failed at org.apache.rat.report.xml.XmlReport.report(XmlReport.java:66) at org.apache.rat.mp.FilesReportable.run(FilesReportable.java:69) at org.apache.rat.Report.report(Report.java:292) at org.apache.rat.Report.report(Report.java:272) at org.apache.rat.mp.AbstractRatMojo.createReport(AbstractRatMojo.java:341) ... 23 more Caused by: org.apache.rat.document.RatDocumentAnalysisException: Cannot analyse header at org.apache.rat.report.analyser.DocumentHeaderAnalyser.analyse(DocumentHeaderAnalyser.java:54) at org.apache.rat.document.impl.util.DocumentAnalyserMultiplexer.analyse(DocumentAnalyserMultiplexer.java:37) at org.apache.rat.document.impl.util.ConditionalAnalyser.matches(ConditionalAnalyser.java:44) at org.apache.rat.document.impl.util.ConditionalAnalyser.analyse(ConditionalAnalyser.java:50) at org.apache.rat.report.xml.XmlReport.report(XmlReport.java:64) ... 27 more Caused by: org.apache.rat.analysis.RatHeaderAnalysisException: Cannot read header for /home/tgoetz/tmp/uimaj-2.3.1/uimaj-core/src/test/resources/pearTests/encodingTests/UTF16_with_signature.xml at org.apache.rat.report.analyser.HeaderCheckWorker.read(HeaderCheckWorker.java:96) at org.apache.rat.report.analyser.DocumentHeaderAnalyser.analyse(DocumentHeaderAnalyser.java:50) ... 31 more Caused by: sun.io.MalformedInputException at sun.io.ByteToCharUTF8.convert(ByteToCharUTF8.java:294) at sun.nio.cs.StreamDecoder$ConverterSD.convertInto(StreamDecoder.java:316) at sun.nio.cs.StreamDecoder$ConverterSD.implRead(StreamDecoder.java:366) at sun.nio.cs.StreamDecoder.read(StreamDecoder.java:252) at java.io.InputStreamReader.read(InputStreamReader.java:212) at java.io.BufferedReader.fill(BufferedReader.java:157) at java.io.BufferedReader.readLine(BufferedReader.java:320) at java.io.BufferedReader.readLine(BufferedReader.java:383) at org.apache.rat.report.analyser.HeaderCheckWorker.readLine(HeaderCheckWorker.java:111) at org.apache.rat.report.analyser.HeaderCheckWorker.read(HeaderCheckWorker.java:89) ... 32 more Work-around: mark these files for explicit exclusion. Fix: change the binaryguesser to read the files in binary (not assuming any character coding) and operate with that data. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (RAT-177) final arrays should be private
Sebb created RAT-177: Summary: final arrays should be private Key: RAT-177 URL: https://issues.apache.org/jira/browse/RAT-177 Project: Apache Rat Issue Type: Bug Affects Versions: 0.11 Reporter: Sebb There are quite a few public string arrays in the guessers and the file Defaults.java These are intended to be constants, but elements of a final array are not themselves final. The arrays should be made private, and suitable accessors provided, depending on how the entries are used. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (RAT-178) BinaryGuesser should not ignore all IOExceptions
Sebb created RAT-178: Summary: BinaryGuesser should not ignore all IOExceptions Key: RAT-178 URL: https://issues.apache.org/jira/browse/RAT-178 Project: Apache Rat Issue Type: Bug Reporter: Sebb BinaryGuesser currently ignores most IOExceptions. This includes unreadable and non-existent files. This seems wrong, and means that unit tests may fail to notice that the test file is not present. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (RAT-179) Maven plugin and Ant task do not support adding extra approved licences
[ https://issues.apache.org/jira/browse/RAT-179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb updated RAT-179: - Summary: Maven plugin and Ant task do not support adding extra approved licences (was: Maven plugin does not support adding extra approved licences) Maven plugin and Ant task do not support adding extra approved licences --- Key: RAT-179 URL: https://issues.apache.org/jira/browse/RAT-179 Project: Apache Rat Issue Type: Bug Reporter: Sebb Users can add new license types using the licenses tag. These are not added to the approved licenses list. This has to be done through the licenseFamilies tag. However, the entries replace the defaults. There does not appear to be any way to update the approved list other than replacing it entirely, which is very inconvenient. This could be fixed by adding a new property analagous to addDefaultLicenseMatchers, e.g. addDefaultLicenseFamilies Or it might be easier for the user to configure if individual license entries could be tagged as approved. The default would need to be false for backwards compatibility. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (RAT-179) Maven plugin and Ant task do not support adding extra approved licences
[ https://issues.apache.org/jira/browse/RAT-179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14136581#comment-14136581 ] Sebb commented on RAT-179: -- Same issue for Ant task; rat:approvedLicense/ configs replace the default set. Maven plugin and Ant task do not support adding extra approved licences --- Key: RAT-179 URL: https://issues.apache.org/jira/browse/RAT-179 Project: Apache Rat Issue Type: Bug Reporter: Sebb Users can add new license types using the licenses tag. These are not added to the approved licenses list. This has to be done through the licenseFamilies tag. However, the entries replace the defaults. There does not appear to be any way to update the approved list other than replacing it entirely, which is very inconvenient. This could be fixed by adding a new property analagous to addDefaultLicenseMatchers, e.g. addDefaultLicenseFamilies Or it might be easier for the user to configure if individual license entries could be tagged as approved. The default would need to be false for backwards compatibility. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (RAT-182) BinaryGuesser - allow modification of binary file types
Sebb created RAT-182: Summary: BinaryGuesser - allow modification of binary file types Key: RAT-182 URL: https://issues.apache.org/jira/browse/RAT-182 Project: Apache Rat Issue Type: New Feature Reporter: Sebb The list of file types that are assumed to be binary is currently hard-coded into the BinaryGuesser class. This is restrictive; it should be possible to change the list of binary extensions. Ideally support both replacing the list entirely as well as adding/removing items from the list. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (RAT-181) BinaryGuesser should treat *.truststore as binary
[ https://issues.apache.org/jira/browse/RAT-181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved RAT-181. -- Resolution: Fixed Fix Version/s: 0.12 URL: http://svn.apache.org/r1629333 Log: RAT-181 BinaryGuesser should treat *.truststore as binary Modified: creadur/rat/trunk/RELEASE_NOTES.txt creadur/rat/trunk/apache-rat-core/src/main/java/org/apache/rat/document/impl/guesser/BinaryGuesser.java BinaryGuesser should treat *.truststore as binary - Key: RAT-181 URL: https://issues.apache.org/jira/browse/RAT-181 Project: Apache Rat Issue Type: Bug Reporter: Sebb Fix For: 0.12 BinaryGuesser treats KEYSTORE files as binary so it should also treat TRUSTSTORE files as binary -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (RAT-191) Upgrade to apache parent version 16
[ https://issues.apache.org/jira/browse/RAT-191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved RAT-191. -- Resolution: Fixed Thanks URL: http://svn.apache.org/r1658062 Log: RAT-191 - Upgrade to apache parent version 16 Modified: creadur/rat/trunk/pom.xml Upgrade to apache parent version 16 --- Key: RAT-191 URL: https://issues.apache.org/jira/browse/RAT-191 Project: Apache Rat Issue Type: Improvement Affects Versions: 0.12 Reporter: Karl Heinz Marbaise Priority: Minor Fix For: 0.12 Attachments: RAT-191.patch Currently the whole RAT projects is based on org.apache:apache:14 which can be updated to verson 16. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (RAT-193) Take advantage of inheritance from ASF parent version 16
[ https://issues.apache.org/jira/browse/RAT-193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved RAT-193. -- Resolution: Fixed Take advantage of inheritance from ASF parent version 16 Key: RAT-193 URL: https://issues.apache.org/jira/browse/RAT-193 Project: Apache Rat Issue Type: Improvement Affects Versions: 0.12 Reporter: Karl Heinz Marbaise Priority: Minor Fix For: 0.12 Attachments: RAT-193.patch Take into account the properties which are inherited from parent. Use the defaults of the plugins instead of explicitly defining them. Use the plugin versions which are defined in the parent. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (RAT-158) SAXParser warnings
[
https://issues.apache.org/jira/browse/RAT-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14322048#comment-14322048
]
Sebb commented on RAT-158:
--
The patch won't be needed once the Apache Pom is re-released.
Alternatively it won't be needed if Doxia is released with the fix.
So I don't think it makes sense to apply the patch yet.
Maybe do so just before RAT is released, assuming the underlying issue has not
yet been fixed.
SAXParser warnings
--
Key: RAT-158
URL: https://issues.apache.org/jira/browse/RAT-158
Project: Apache Rat
Issue Type: Bug
Affects Versions: 0.10
Environment: Apache Maven 3.0.4
Maven home: /usr/share/maven
Java version: 1.6.0_30, vendor: Sun Microsystems Inc.
Java home: /usr/lib/jvm/java-6-openjdk-amd64/jre
Default locale: en_US, platform encoding: UTF-8
OS name: linux, version: 3.11.0-17-generic, arch: amd64, family: unix
Reporter: John Vines
Assignee: Philipp Ottlinger
Priority: Minor
Attachments: RAT-158.patch
I have rat configured as such
{code} plugin
groupIdorg.apache.rat/groupId
artifactIdapache-rat-plugin/artifactId
inheritedfalse/inherited
executions
execution
phaseverify/phase
goals
goalcheck/goal
/goals
/execution
/executions
configuration
excludes
exclude**/conf/**/exclude
/excludes
/configuration
/plugin
{code}
And with every build where it triggers, I see
{code}
Warning: org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property
'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not
recognized.
Warning: org.apache.xerces.parsers.SAXParser: Feature
'http://javax.xml.XMLConstants/feature/secure-processing' is not recognized.
Warning: org.apache.xerces.parsers.SAXParser: Property
'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not
recognized.
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (RAT-158) SAXParser warnings
[
https://issues.apache.org/jira/browse/RAT-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14326779#comment-14326779
]
Hudson commented on RAT-158:
SUCCESS: Integrated in ASF Parent Pom #119 (See
[https://builds.apache.org/job/ASF%20Parent%20Pom/119/])
[RAT-158] remove Xerces in m-site-p too to avoid RAT-158 in reporting
(hboutemy: http://svn.apache.org/viewvc/?view=revrev=1660764)
* /maven/pom/trunk/asf/pom.xml
SAXParser warnings
--
Key: RAT-158
URL: https://issues.apache.org/jira/browse/RAT-158
Project: Apache Rat
Issue Type: Bug
Affects Versions: 0.10
Environment: Apache Maven 3.0.4
Maven home: /usr/share/maven
Java version: 1.6.0_30, vendor: Sun Microsystems Inc.
Java home: /usr/lib/jvm/java-6-openjdk-amd64/jre
Default locale: en_US, platform encoding: UTF-8
OS name: linux, version: 3.11.0-17-generic, arch: amd64, family: unix
Reporter: John Vines
Priority: Minor
Fix For: 0.12
Attachments: RAT-158-2.patch, RAT-158.patch
I have rat configured as such
{code} plugin
groupIdorg.apache.rat/groupId
artifactIdapache-rat-plugin/artifactId
inheritedfalse/inherited
executions
execution
phaseverify/phase
goals
goalcheck/goal
/goals
/execution
/executions
configuration
excludes
exclude**/conf/**/exclude
/excludes
/configuration
/plugin
{code}
And with every build where it triggers, I see
{code}
Warning: org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property
'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not
recognized.
Warning: org.apache.xerces.parsers.SAXParser: Feature
'http://javax.xml.XMLConstants/feature/secure-processing' is not recognized.
Warning: org.apache.xerces.parsers.SAXParser: Property
'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not
recognized.
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (RAT-180) Incorrect text in report
[ https://issues.apache.org/jira/browse/RAT-180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14548018#comment-14548018 ] Sebb commented on RAT-180: -- Updated text looks OK. Incorrect text in report Key: RAT-180 URL: https://issues.apache.org/jira/browse/RAT-180 Project: Apache Rat Issue Type: Bug Reporter: Sebb Assignee: Philipp Ottlinger Priority: Minor The report contains the lines: Binary files (which do not require AL headers) will be marked B ... Printing headers for files without AL header This assumes that only AL headers are required/allowed. The text should be made more generic, for example Binary files (which do not require a licence header) will be marked B ... Printing headers for text files without a license header -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (RAT-138) RAT runs very slowly on some input
[ https://issues.apache.org/jira/browse/RAT-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14578669#comment-14578669 ] Hudson commented on RAT-138: SUCCESS: Integrated in tobago-trunk #1386 (See [https://builds.apache.org/job/tobago-trunk/1386/]) updated rat-plugin to fix slowness (see RAT-138) (deki: http://svn.apache.org/viewvc/?view=revrev=1684365) * /myfaces/tobago/trunk/pom.xml RAT runs very slowly on some input -- Key: RAT-138 URL: https://issues.apache.org/jira/browse/RAT-138 Project: Apache Rat Issue Type: Bug Components: engine Affects Versions: 0.8, 0.9 Reporter: Sebb Labels: perfomance, regression Fix For: 0.10 Commons IO discovered that mvn site was spending a lot of time running RAT 0.9. Reverting to 0.8 fixes the problem. Turns out that certain files seem to cause RAT to chew CPU in the Pattern.matcher; here is a sample stack trace from a thread dump: main prio=6 tid=0x003c8c00 nid=0xa4c runnable [0x00a5e000] java.lang.Thread.State: RUNNABLE at java.util.regex.Pattern$Curly.match0(Pattern.java:4166) at java.util.regex.Pattern$Curly.match(Pattern.java:4132) at java.util.regex.Matcher.match(Matcher.java:1221) at java.util.regex.Matcher.matches(Matcher.java:559) at org.apache.rat.analysis.license.FullTextMatchingLicense.match(FullTextMatchingLicense.java:79) at org.apache.rat.analysis.util.HeaderMatcherMultiplexer.match(HeaderMatcherMultiplexer.java:42) at org.apache.rat.analysis.HeaderCheckWorker.readLine(HeaderCheckWorker.java:113) at org.apache.rat.analysis.HeaderCheckWorker.read(HeaderCheckWorker.java:84) at org.apache.rat.analysis.DocumentHeaderAnalyser.analyse(DocumentHeaderAnalyser.java:43) at org.apache.rat.analysis.DefaultAnalyserFactory$DefaultAnalyser.analyse(DefaultAnalyserFactory.java:60) at org.apache.rat.document.impl.util.DocumentAnalyserMultiplexer.analyse(DocumentAnalyserMultiplexer.java:37) at org.apache.rat.report.claim.util.ClaimReporterMultiplexer.report(ClaimReporterMultiplexer.java:42) at org.apache.rat.mp.FilesReportable.run(FilesReportable.java:68) at org.apache.rat.Report.report(Report.java:393) at org.apache.rat.Report.report(Report.java:373) at org.apache.rat.mp.AbstractRatMojo.createReport(AbstractRatMojo.java:462) at org.apache.rat.mp.RatReportMojo.createReport(RatReportMojo.java:148) at org.apache.rat.mp.RatReportMojo.generate(RatReportMojo.java:310) at org.apache.rat.mp.RatReportMojo.execute(RatReportMojo.java:210) I assume there must be a problem with one of the REs which is triggering lots of backtracking when applied to files under site-content/, which is a working copy of: https://svn.apache.org/repos/infra/websites/production/commons/content/proper/commons-io Last Changed Rev: 861378 This directory should not have been included in the RAT scan, but the files don't cause problems for RAT 0.8. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (RAT-209) Ignore short files when checking licenses
[
https://issues.apache.org/jira/browse/RAT-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebb updated RAT-209:
-
Description:
A license header is not usually required for short files that have no creative
content.
For example
{code:title=project.css|borderStyle=solid}
@import url("http://commons.apache.org/style/commons-maven.css;);
{code}
It would be useful to be able to skip -ignore- these when listing which files
don't have headers.
The criteria for ignoring files could be expressed as file size and/or number
of lines. The criteria used should be documented on the RAT report.
Files which don't have headers but which fulfil the criteria could either be
listed at the end of the report in a separate section from the missing headers,
or they could be listed in the main file list with a different category, e.g.
NA.
was:
A license header is not usually required for short files that have no creative
content.
For example
{code:title=project.css|borderStyle=solid}
@import url("http://commons.apache.org/style/commons-maven.css;);
{code}
It would be useful to be able to ignore these when listing which files don't
have headers.
The criteria for ignoring files could be expressed as file size and/or number
of lines. The criteria used should be documented on the RAT report.
Files which don't have headers but which fulfil the criteria could either be
listed at the end of the report in a separate section from the missing headers,
or they could be listed in the main file list with a different category, e.g.
NA.
> Ignore short files when checking licenses
> -
>
> Key: RAT-209
> URL: https://issues.apache.org/jira/browse/RAT-209
> Project: Apache Rat
> Issue Type: Improvement
>Reporter: Sebb
>
> A license header is not usually required for short files that have no
> creative content.
> For example
> {code:title=project.css|borderStyle=solid}
> @import url("http://commons.apache.org/style/commons-maven.css;);
> {code}
> It would be useful to be able to skip -ignore- these when listing which files
> don't have headers.
> The criteria for ignoring files could be expressed as file size and/or number
> of lines. The criteria used should be documented on the RAT report.
> Files which don't have headers but which fulfil the criteria could either be
> listed at the end of the report in a separate section from the missing
> headers, or they could be listed in the main file list with a different
> category, e.g. NA.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (RAT-209) Ignore short files when checking licenses
[
https://issues.apache.org/jira/browse/RAT-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebb updated RAT-209:
-
Description:
A license header is not usually required for short files that have no creative
content.
For example
{code:title=project.css|borderStyle=solid}
@import url("http://commons.apache.org/style/commons-maven.css;);
{code}
It would be useful to be able to -ignore- skip these when listing which files
don't have headers.
The criteria for ignoring files could be expressed as file size and/or number
of lines. The criteria used should be documented on the RAT report.
Files which don't have headers but which fulfil the criteria could either be
listed at the end of the report in a separate section from the missing headers,
or they could be listed in the main file list with a different category, e.g.
NA.
was:
A license header is not usually required for short files that have no creative
content.
For example
{code:title=project.css|borderStyle=solid}
@import url("http://commons.apache.org/style/commons-maven.css;);
{code}
It would be useful to be able to skip -ignore- these when listing which files
don't have headers.
The criteria for ignoring files could be expressed as file size and/or number
of lines. The criteria used should be documented on the RAT report.
Files which don't have headers but which fulfil the criteria could either be
listed at the end of the report in a separate section from the missing headers,
or they could be listed in the main file list with a different category, e.g.
NA.
> Ignore short files when checking licenses
> -
>
> Key: RAT-209
> URL: https://issues.apache.org/jira/browse/RAT-209
> Project: Apache Rat
> Issue Type: Improvement
>Reporter: Sebb
>
> A license header is not usually required for short files that have no
> creative content.
> For example
> {code:title=project.css|borderStyle=solid}
> @import url("http://commons.apache.org/style/commons-maven.css;);
> {code}
> It would be useful to be able to -ignore- skip these when listing which files
> don't have headers.
> The criteria for ignoring files could be expressed as file size and/or number
> of lines. The criteria used should be documented on the RAT report.
> Files which don't have headers but which fulfil the criteria could either be
> listed at the end of the report in a separate section from the missing
> headers, or they could be listed in the main file list with a different
> category, e.g. NA.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (RAT-158) SAXParser warnings
[
https://issues.apache.org/jira/browse/RAT-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358988#comment-15358988
]
Hudson commented on RAT-158:
SUCCESS: Integrated in ASF Parent Pom #153 (See
[https://builds.apache.org/job/ASF%20Parent%20Pom/153/])
[MPOM-129] Upgrade apache-rat-plugin to 0.12
o Removed supplemental excludes for DEPENDENCIES (RAT-184)
o Remvoed supplemental dependencies to doxia-core (RAT-158, DOXIA-526)
(khmarbaise: [http://svn.apache.org/viewvc/?view=rev=1750928])
* pom.xml
> SAXParser warnings
> --
>
> Key: RAT-158
> URL: https://issues.apache.org/jira/browse/RAT-158
> Project: Apache Rat
> Issue Type: Bug
>Affects Versions: 0.10
> Environment: Apache Maven 3.0.4
> Maven home: /usr/share/maven
> Java version: 1.6.0_30, vendor: Sun Microsystems Inc.
> Java home: /usr/lib/jvm/java-6-openjdk-amd64/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "3.11.0-17-generic", arch: "amd64", family: "unix"
>Reporter: John Vines
>Priority: Minor
> Fix For: 0.12
>
> Attachments: RAT-158-2.patch, RAT-158.patch
>
>
> I have rat configured as such
> {code}
> org.apache.rat
> apache-rat-plugin
> false
>
>
> verify
>
>check
>
>
>
>
>
> **/conf/**
>
>
>
> {code}
> And with every build where it triggers, I see
> {code}
> Warning: org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property
> 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not
> recognized.
> Warning: org.apache.xerces.parsers.SAXParser: Feature
> 'http://javax.xml.XMLConstants/feature/secure-processing' is not recognized.
> Warning: org.apache.xerces.parsers.SAXParser: Property
> 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not
> recognized.
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (RAT-220) JDK version 1.6
[ https://issues.apache.org/jira/browse/RAT-220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15481714#comment-15481714 ] Sebb commented on RAT-220: -- +1 We should not change the Java version merely to be consistent with other Creadur projects. There needs to be a clear end-user benefit to requiring the upgrade. > JDK version 1.6 > --- > > Key: RAT-220 > URL: https://issues.apache.org/jira/browse/RAT-220 > Project: Apache Rat > Issue Type: Improvement >Reporter: Karl Heinz Marbaise >Assignee: Jochen Wiedmann > > Currently the RAT project defines as Java compatibility 1.5 but Tentacles > defines 1.6 and Whiskers as well 1.6 so it would be a good idea to go to 1.6 > as minimumIf someone needs to work with 1.5 toolchain can be used. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WHISKER-17) Can't verify the link of using image instead of Text
[
https://issues.apache.org/jira/browse/WHISKER-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577973#comment-16577973
]
Sebb commented on WHISKER-17:
-
Looks like this should be a WHIMSY issue, not WHISKER.
> Can't verify the link of using image instead of Text
>
>
> Key: WHISKER-17
> URL: https://issues.apache.org/jira/browse/WHISKER-17
> Project: Apache Whisker
> Issue Type: Bug
>Reporter: Sheng Wu
>Priority: Major
>
> I already posted some messages in ML.
> [https://lists.apache.org/thread.html/b8e1f085f244f8aa020d5cf68bf2ac3c8071bb0e02bffd6cbeed91f3@%3Cdev.whimsical.apache.org%3E]
>
> The following HTML can't be verified by whimsical. Whisker will say
> `[Foundation|https://whimsy.apache.org/pods/check/foundation] link` isn't
> found.
> {code:java}
> Sponsorship and
> Donate Apache Software Foundation http://www.apache.org/foundation/sponsorship.html;
> target="blank">
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (RAT-255) How to put the location of the license header on top of the package
[ https://issues.apache.org/jira/browse/RAT-255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] slievrly updated RAT-255: - Attachment: image-2019-06-12-11-38-26-729.png > How to put the location of the license header on top of the package > --- > > Key: RAT-255 > URL: https://issues.apache.org/jira/browse/RAT-255 > Project: Apache Rat > Issue Type: Improvement > Components: maven >Affects Versions: 0.13 >Reporter: slievrly >Priority: Major > Fix For: 0.14 > > Attachments: image-2019-06-11-18-28-02-474.png, > image-2019-06-12-11-38-26-729.png > > > How to put the location of the license header on top of the package？I expect > the result as shown. > !image-2019-06-11-18-28-02-474.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RAT-255) How to put the location of the license header on top of the package
[
https://issues.apache.org/jira/browse/RAT-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861727#comment-16861727
]
slievrly commented on RAT-255:
--
[~hugo.hirsch] Sorry, I can't provide a link to the project. This is tested
locally.
This is my rat configuration：
{code:java}
org.apache.rat
apache-rat-plugin
${apache-rat-plugin.version}
verify.rat
verify
check
forced
true
**/*.versionsBackup
**/.idea/
**/*.iml
**/*.txt
**/*.load
**/*.flex
**/*.fc
**/*.javascript
**/*.properties
**/*.thrift
**/*.sh
**/*.bat
**/*.md
.git/
.gitignore
.repository/
**/.settings/*
**/.classpath
**/.project
**/target/**
**/*.log
CODE_OF_CONDUCT.md
.codecov.yml
.travis.yml
PULL_REQUEST_TEMPLATE.md
CONTRIBUTING.md
README.md
**/codestyle/*
**/resources/META-INF/**
**/org/apache/dubbo/common/threadlocal/InternalThreadLocal.java
**/org/apache/dubbo/common/threadlocal/InternalThreadLocalMap.java
{code}
result：
!image-2019-06-12-11-39-52-228.png!
expect：
!image-2019-06-12-11-38-26-729.png!
problems：
1. I expect the location of the license header to be on top of the package.
2. I expect the number of characters per line to be strictly consistent,
otherwise it will be forced to format.
> How to put the location of the license header on top of the package
> ---
>
> Key: RAT-255
> URL: https://issues.apache.org/jira/browse/RAT-255
> Project: Apache Rat
> Issue Type: Improvement
> Components: maven
>Affects Versions: 0.13
>Reporter: slievrly
>Priority: Major
> Fix For: 0.14
>
> Attachments: image-2019-06-11-18-28-02-474.png,
> image-2019-06-12-11-38-26-729.png, image-2019-06-12-11-39-52-228.png
>
>
> How to put the location of the license header on top of the package？I expect
> the result as shown.
> !image-2019-06-11-18-28-02-474.png!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (RAT-255) How to put the location of the license header on top of the package
[ https://issues.apache.org/jira/browse/RAT-255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] slievrly updated RAT-255: - Attachment: image-2019-06-12-11-39-52-228.png > How to put the location of the license header on top of the package > --- > > Key: RAT-255 > URL: https://issues.apache.org/jira/browse/RAT-255 > Project: Apache Rat > Issue Type: Improvement > Components: maven >Affects Versions: 0.13 >Reporter: slievrly >Priority: Major > Fix For: 0.14 > > Attachments: image-2019-06-11-18-28-02-474.png, > image-2019-06-12-11-38-26-729.png, image-2019-06-12-11-39-52-228.png > > > How to put the location of the license header on top of the package？I expect > the result as shown. > !image-2019-06-11-18-28-02-474.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (RAT-255) How to put the location of the license header on top of the package
[ https://issues.apache.org/jira/browse/RAT-255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] slievrly updated RAT-255: - Attachment: image-2019-06-15-01-48-09-901.png > How to put the location of the license header on top of the package > --- > > Key: RAT-255 > URL: https://issues.apache.org/jira/browse/RAT-255 > Project: Apache Rat > Issue Type: Improvement > Components: maven >Affects Versions: 0.13 >Reporter: slievrly >Priority: Major > Fix For: 0.14 > > Attachments: image-2019-06-11-18-28-02-474.png, > image-2019-06-12-11-38-26-729.png, image-2019-06-12-11-39-52-228.png, > image-2019-06-15-01-48-09-901.png > > > How to put the location of the license header on top of the package？I expect > the result as shown. > !image-2019-06-11-18-28-02-474.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (RAT-255) How to put the location of the license header on top of the package
[ https://issues.apache.org/jira/browse/RAT-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864329#comment-16864329 ] slievrly edited comment on RAT-255 at 6/14/19 6:19 PM: --- [~hugo.hirsch] when i run command line like this: java -jar apache-rat-0.13.jar --addlicense --copyright "Copyright 2008 Foo" --force --dir "/Users/min.ji/Git/github/incubator-dubbo/dubbo-common/src/main/java/org/apache/dubbo/common/beanutil" << Please use the "--help" option to see a list of valid commands and options. It reminds me of the following information, but I have not found any improper use. ref to [https://creadur.apache.org/rat/apache-rat/index.html] was (Author: slievrly): [~hugo.hirsch] when i run command line like this: java -jar apache-rat-0.13.jar --addlicense --copyright "Copyright 2008 Foo" --force --dir "/Users/min.ji/Git/github/incubator-dubbo/dubbo-common/src/main/java/org/apache/dubbo/common/beanutil" Please use the "--help" option to see a list of valid commands and options It reminds me of the following information. I have not found any improper use. ref to [https://creadur.apache.org/rat/apache-rat/index.html] > How to put the location of the license header on top of the package > --- > > Key: RAT-255 > URL: https://issues.apache.org/jira/browse/RAT-255 > Project: Apache Rat > Issue Type: Improvement > Components: maven >Affects Versions: 0.13 >Reporter: slievrly >Priority: Major > Fix For: 0.14 > > Attachments: image-2019-06-11-18-28-02-474.png, > image-2019-06-12-11-38-26-729.png, image-2019-06-12-11-39-52-228.png, > image-2019-06-15-01-48-09-901.png, image-2019-06-15-01-49-36-968.png > > > How to put the location of the license header on top of the package？I expect > the result as shown. > !image-2019-06-11-18-28-02-474.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RAT-255) How to put the location of the license header on top of the package
[ https://issues.apache.org/jira/browse/RAT-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864329#comment-16864329 ] slievrly commented on RAT-255: -- [~hugo.hirsch] when i run command line like this: java -jar apache-rat-0.13.jar --addlicense --copyright "Copyright 2008 Foo" --force --dir "/Users/min.ji/Git/github/incubator-dubbo/dubbo-common/src/main/java/org/apache/dubbo/common/beanutil" Please use the "--help" option to see a list of valid commands and options It reminds me of the following information. I have not found any improper use. ref to [https://creadur.apache.org/rat/apache-rat/index.html] > How to put the location of the license header on top of the package > --- > > Key: RAT-255 > URL: https://issues.apache.org/jira/browse/RAT-255 > Project: Apache Rat > Issue Type: Improvement > Components: maven >Affects Versions: 0.13 >Reporter: slievrly >Priority: Major > Fix For: 0.14 > > Attachments: image-2019-06-11-18-28-02-474.png, > image-2019-06-12-11-38-26-729.png, image-2019-06-12-11-39-52-228.png, > image-2019-06-15-01-48-09-901.png, image-2019-06-15-01-49-36-968.png > > > How to put the location of the license header on top of the package？I expect > the result as shown. > !image-2019-06-11-18-28-02-474.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RAT-255) How to put the location of the license header on top of the package
[ https://issues.apache.org/jira/browse/RAT-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864269#comment-16864269 ] slievrly commented on RAT-255: -- [~hugo.hirsch] Thank you very much for your patience. I will try. > How to put the location of the license header on top of the package > --- > > Key: RAT-255 > URL: https://issues.apache.org/jira/browse/RAT-255 > Project: Apache Rat > Issue Type: Improvement > Components: maven >Affects Versions: 0.13 >Reporter: slievrly >Priority: Major > Fix For: 0.14 > > Attachments: image-2019-06-11-18-28-02-474.png, > image-2019-06-12-11-38-26-729.png, image-2019-06-12-11-39-52-228.png > > > How to put the location of the license header on top of the package？I expect > the result as shown. > !image-2019-06-11-18-28-02-474.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RAT-255) How to put the location of the license header on top of the package
[ https://issues.apache.org/jira/browse/RAT-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864307#comment-16864307 ] slievrly commented on RAT-255: -- when i use rat's plugin2maven, `mvn clean verify` and set copyrightMessage like this. !image-2019-06-15-01-48-09-901.png! it generate license header like this: !image-2019-06-15-01-49-36-968.png! i will try use CLI. > How to put the location of the license header on top of the package > --- > > Key: RAT-255 > URL: https://issues.apache.org/jira/browse/RAT-255 > Project: Apache Rat > Issue Type: Improvement > Components: maven >Affects Versions: 0.13 >Reporter: slievrly >Priority: Major > Fix For: 0.14 > > Attachments: image-2019-06-11-18-28-02-474.png, > image-2019-06-12-11-38-26-729.png, image-2019-06-12-11-39-52-228.png, > image-2019-06-15-01-48-09-901.png, image-2019-06-15-01-49-36-968.png > > > How to put the location of the license header on top of the package？I expect > the result as shown. > !image-2019-06-11-18-28-02-474.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (RAT-255) How to put the location of the license header on top of the package
[ https://issues.apache.org/jira/browse/RAT-255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] slievrly updated RAT-255: - Attachment: image-2019-06-15-01-49-36-968.png > How to put the location of the license header on top of the package > --- > > Key: RAT-255 > URL: https://issues.apache.org/jira/browse/RAT-255 > Project: Apache Rat > Issue Type: Improvement > Components: maven >Affects Versions: 0.13 >Reporter: slievrly >Priority: Major > Fix For: 0.14 > > Attachments: image-2019-06-11-18-28-02-474.png, > image-2019-06-12-11-38-26-729.png, image-2019-06-12-11-39-52-228.png, > image-2019-06-15-01-48-09-901.png, image-2019-06-15-01-49-36-968.png > > > How to put the location of the license header on top of the package？I expect > the result as shown. > !image-2019-06-11-18-28-02-474.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RAT-255) How to put the location of the license header on top of the package
[ https://issues.apache.org/jira/browse/RAT-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864621#comment-16864621 ] slievrly commented on RAT-255: -- [~hugo.hirsch] if i not set copyrightMsg, like I said above，ref to attachment `image-2019-06-12-11-39-52-228.png` I want the license header to be at the beginning of the file, and the number of words in each line of the license header is exactly the same as I said above. This is irrelevant to my IDE format. I have not set automatic format. Later I tried setting up copyrightMsg, hoping to get a fixed header, but found that it was not generated in my pre-set format and seems to appear twice. [^image-2019-06-12-11-39-52-228.png]my OS： macOS 10.14.2 . I did not understand the rules of its broken line > How to put the location of the license header on top of the package > --- > > Key: RAT-255 > URL: https://issues.apache.org/jira/browse/RAT-255 > Project: Apache Rat > Issue Type: Improvement > Components: maven >Affects Versions: 0.13 >Reporter: slievrly >Priority: Major > Fix For: 0.14 > > Attachments: image-2019-06-11-18-28-02-474.png, > image-2019-06-12-11-38-26-729.png, image-2019-06-12-11-39-52-228.png, > image-2019-06-15-01-48-09-901.png, image-2019-06-15-01-49-36-968.png > > > How to put the location of the license header on top of the package？I expect > the result as shown. > !image-2019-06-11-18-28-02-474.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (RAT-255) How to put the location of the license header on top of the package
slievrly created RAT-255: Summary: How to put the location of the license header on top of the package Key: RAT-255 URL: https://issues.apache.org/jira/browse/RAT-255 Project: Apache Rat Issue Type: Improvement Components: maven Affects Versions: 0.13 Reporter: slievrly Fix For: 0.14 Attachments: image-2019-06-11-18-28-02-474.png How to put the location of the license header on top of the package？I expect the result as shown. !image-2019-06-11-18-28-02-474.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (RAT-284) Hacking identity theft
Jennifer created RAT-284: Summary: Hacking identity theft Key: RAT-284 URL: https://issues.apache.org/jira/browse/RAT-284 Project: Apache Rat Issue Type: Bug Reporter: Jennifer -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (RAT-280) Can not download apache-rat-0.13-bin.tar.gz.sha512
[ https://issues.apache.org/jira/browse/RAT-280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307759#comment-17307759 ] runzhiwang commented on RAT-280: [~pottlinger] Thank you very much, it works for me now. > Can not download apache-rat-0.13-bin.tar.gz.sha512 > --- > > Key: RAT-280 > URL: https://issues.apache.org/jira/browse/RAT-280 > Project: Apache Rat > Issue Type: Bug >Reporter: runzhiwang >Priority: Major > > I can not download > https://dist.apache.org/repos/dist/release/creadur/apache-rat-0.13/apache-rat-0.13-bin.tar.gz.sha512 > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (RAT-280) Can not download apache-rat-0.13-bin.tar.gz.sha512
[ https://issues.apache.org/jira/browse/RAT-280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] runzhiwang updated RAT-280: --- Description: I can not download https://dist.apache.org/repos/dist/release/creadur/apache-rat-0.13/apache-rat-0.13-bin.tar.gz.sha512 > Can not download apache-rat-0.13-bin.tar.gz.sha512 > --- > > Key: RAT-280 > URL: https://issues.apache.org/jira/browse/RAT-280 > Project: Apache Rat > Issue Type: Bug >Reporter: runzhiwang >Priority: Major > > I can not download > https://dist.apache.org/repos/dist/release/creadur/apache-rat-0.13/apache-rat-0.13-bin.tar.gz.sha512 > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (RAT-280) Can not download apache-rat-0.13-bin.tar.gz.sha512
runzhiwang created RAT-280: -- Summary: Can not download apache-rat-0.13-bin.tar.gz.sha512 Key: RAT-280 URL: https://issues.apache.org/jira/browse/RAT-280 Project: Apache Rat Issue Type: Bug Reporter: runzhiwang -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (RAT-280) Can not download apache-rat-0.13-bin.tar.gz.sha512
[ https://issues.apache.org/jira/browse/RAT-280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307691#comment-17307691 ] runzhiwang commented on RAT-280: [~joc...@apache.org] Hi, could you help fix this ? thanks a lot. > Can not download apache-rat-0.13-bin.tar.gz.sha512 > --- > > Key: RAT-280 > URL: https://issues.apache.org/jira/browse/RAT-280 > Project: Apache Rat > Issue Type: Bug >Reporter: runzhiwang >Priority: Major > > I can not download > https://dist.apache.org/repos/dist/release/creadur/apache-rat-0.13/apache-rat-0.13-bin.tar.gz.sha512 > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (RAT-298) Source repo info seems very out of date
[ https://issues.apache.org/jira/browse/RAT-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17518805#comment-17518805 ] elharo commented on RAT-298: That is this page https://creadur.apache.org/rat/source-repository.html points to https://svn.apache.org/repos/asf/creadur/rat/tags/apache-rat-project-0.13/ > Source repo info seems very out of date > --- > > Key: RAT-298 > URL: https://issues.apache.org/jira/browse/RAT-298 > Project: Apache Rat > Issue Type: Bug >Reporter: elharo >Priority: Major > > Trying to find the source code from the website I was led into an old SVN > repo that still uses Maven 2.2 and Java 1.5. I'm pretty sure this isn't > current. Please update. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (RAT-298) Source repo info seems very out of date
elharo created RAT-298: -- Summary: Source repo info seems very out of date Key: RAT-298 URL: https://issues.apache.org/jira/browse/RAT-298 Project: Apache Rat Issue Type: Bug Reporter: elharo Trying to find the source code from the website I was led into an old SVN repo that still uses Maven 2.2 and Java 1.5. I'm pretty sure this isn't current. Please update. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (RAT-283) Unify Java 8 requirement or non-requirement
[ https://issues.apache.org/jira/browse/RAT-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17518808#comment-17518808 ] elharo commented on RAT-283: Seems so. I took a quick glance in pom.xml on Github amd didn't notice any especially old dependencies any more. Feel free to close and mark fixed. > Unify Java 8 requirement or non-requirement > --- > > Key: RAT-283 > URL: https://issues.apache.org/jira/browse/RAT-283 > Project: Apache Rat > Issue Type: Bug >Reporter: Elliotte Rusty Harold >Assignee: Philipp Ottlinger >Priority: Major > > In the pom.xml I find dependencies that are very old to avoid requiring Java > *1.6* or later. However I also see commons-io 2.8.0 that requires Java *1.8* > or later. Make a clear decision on the minimum version of Java and upgrade or > downgrade dependencies accordingly. > FYI Apache Maven requires Java 1.7 so I'd prefer not to go higher than that. > ``` > > commons-collections > commons-collections > > 3.2.2 > > > commons-io > commons-io > 2.8.0 > > > org.apache.commons > commons-lang3 > > 3.5 > > > org.apache.commons > commons-compress > > 1.19 > > ``` -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (RAT-117) Tentacles uses a snapshot dependency that is not in mvn central - build failure
Hugo Hirsch created RAT-117: --- Summary: Tentacles uses a snapshot dependency that is not in mvn central - build failure Key: RAT-117 URL: https://issues.apache.org/jira/browse/RAT-117 Project: Apache Rat Issue Type: Bug Environment: hirsch:~/Desktop/s/creadur/tentacles/trunk$ svn info Pfad: . URL: http://svn.apache.org/repos/asf/creadur/tentacles/trunk Basis des Projektarchivs: http://svn.apache.org/repos/asf UUID des Projektarchivs: 13f79535-47bb-0310-9956-ffa450edef68 Revision: 1351441 Knotentyp: Verzeichnis Plan: normal Letzter Autor: dblevins Letzte geänderte Rev: 1232283 Letztes Änderungsdatum: 2012-01-17 04:07:20 +0100 (Di, 17. Jan 2012) hirsch:~/Desktop/s/creadur/tentacles/trunk$ Reporter: Hugo Hirsch Tentacles uses a snapshot dependency that results in build failures on a default mvn setup (mvn 3.0.4). Patch in pom.xml is: @@ -67,7 +67,8 @@ dependency groupIdorg.codehaus.swizzle/groupId artifactIdswizzle-stream/artifactId - version1.6.2-SNAPSHOT/version + !--version1.6.2-SNAPSHOT/version-- + version1.6.1/version /dependency dependency -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (RAT-117) Tentacles uses a snapshot dependency that is not in mvn central - build failure
[ https://issues.apache.org/jira/browse/RAT-117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Burrell Donkin resolved RAT-117. --- Resolution: Fixed Applied. Many thanks for supplying the patch. Tentacles uses a snapshot dependency that is not in mvn central - build failure --- Key: RAT-117 URL: https://issues.apache.org/jira/browse/RAT-117 Project: Apache Rat Issue Type: Bug Environment: hirsch:~/Desktop/s/creadur/tentacles/trunk$ svn info Pfad: . URL: http://svn.apache.org/repos/asf/creadur/tentacles/trunk Basis des Projektarchivs: http://svn.apache.org/repos/asf UUID des Projektarchivs: 13f79535-47bb-0310-9956-ffa450edef68 Revision: 1351441 Knotentyp: Verzeichnis Plan: normal Letzter Autor: dblevins Letzte geänderte Rev: 1232283 Letztes Änderungsdatum: 2012-01-17 04:07:20 +0100 (Di, 17. Jan 2012) hirsch:~/Desktop/s/creadur/tentacles/trunk$ Reporter: Hugo Hirsch Assignee: Robert Burrell Donkin Labels: build, maven Attachments: RAT117-pom.xml.patch Tentacles uses a snapshot dependency that results in build failures on a default mvn setup (mvn 3.0.4). Patch in pom.xml is: @@ -67,7 +67,8 @@ dependency groupIdorg.codehaus.swizzle/groupId artifactIdswizzle-stream/artifactId - version1.6.2-SNAPSHOT/version + !--version1.6.2-SNAPSHOT/version-- + version1.6.1/version /dependency dependency -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (RAT-122) Maven Plugin: field to ignore errors and continue the build
[ https://issues.apache.org/jira/browse/RAT-122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Burrell Donkin reassigned RAT-122: - Assignee: Robert Burrell Donkin Maven Plugin: field to ignore errors and continue the build --- Key: RAT-122 URL: https://issues.apache.org/jira/browse/RAT-122 Project: Apache Rat Issue Type: Bug Components: maven Reporter: Olivier Lamy (*$^¨%`£) Assignee: Robert Burrell Donkin Attachments: RAT-122 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (RAT-120) fix some maven warning and upgrade some dependencies.
[ https://issues.apache.org/jira/browse/RAT-120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Burrell Donkin updated RAT-120: -- Fix Version/s: 0.9 fix some maven warning and upgrade some dependencies. - Key: RAT-120 URL: https://issues.apache.org/jira/browse/RAT-120 Project: Apache Rat Issue Type: Bug Components: maven Affects Versions: 0.9 Reporter: Olivier Lamy (*$^¨%`£) Assignee: Robert Burrell Donkin Fix For: 0.9 Attachments: RAT-120 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (RAT-122) Maven Plugin: field to ignore errors and continue the build
[ https://issues.apache.org/jira/browse/RAT-122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Burrell Donkin updated RAT-122: -- Fix Version/s: 0.9 Maven Plugin: field to ignore errors and continue the build --- Key: RAT-122 URL: https://issues.apache.org/jira/browse/RAT-122 Project: Apache Rat Issue Type: Bug Components: maven Reporter: Olivier Lamy (*$^¨%`£) Assignee: Robert Burrell Donkin Fix For: 0.9 Attachments: RAT-122 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (WHISKER-7) Document When Copyright Notice Is Appropriate
Robert Burrell Donkin created WHISKER-7: --- Summary: Document When Copyright Notice Is Appropriate Key: WHISKER-7 URL: https://issues.apache.org/jira/browse/WHISKER-7 Project: Apache Whisker Issue Type: Bug Reporter: Robert Burrell Donkin Assignee: Robert Burrell Donkin copyright-notice is intended to help licenses such as the MIT License where a copyright claim is conventionally included right at the top of the license text. Other licences (such as Apache License, Version 2) are slient on copyright claims or use a NOTICE to contain collective copyright claims. For primary licenses of this sort, to ensure that the copyright claims end up in the NOTICE (where they belong) these claims need to be included in the notice sections. This wasn't very well explain and is confusing. Documentation needs to be improved. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (WHISKER-9) Improve Source Element Documentation
Robert Burrell Donkin created WHISKER-9: --- Summary: Improve Source Element Documentation Key: WHISKER-9 URL: https://issues.apache.org/jira/browse/WHISKER-9 Project: Apache Whisker Issue Type: Bug Reporter: Robert Burrell Donkin Assignee: Robert Burrell Donkin The source element document (http://creadur.apache.org/whisker/meta-data.html#Source_Links) is too brief and technical, adding up to confusion. Improve that section, add an example to the main documentation and link to it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WHISKER-10) Investigate Whether with-license issues are skipped without copyright-notice
[ https://issues.apache.org/jira/browse/WHISKER-10?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13490072#comment-13490072 ] Robert Burrell Donkin commented on WHISKER-10: -- As expected, removing the primary copyright notice removes just the generated copyright claim Investigate Whether with-license issues are skipped without copyright-notice Key: WHISKER-10 URL: https://issues.apache.org/jira/browse/WHISKER-10 Project: Apache Whisker Issue Type: Bug Reporter: Robert Burrell Donkin Assignee: Robert Burrell Donkin In some circumstances, it seems necessary to add copyright-notice elements before with-license elements are printed correctly. Create tests to prove whether this is still the case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (RAT-124) Rat plugin should exclude the configuration directory used by IDEA
Dennis Lundberg created RAT-124: --- Summary: Rat plugin should exclude the configuration directory used by IDEA Key: RAT-124 URL: https://issues.apache.org/jira/browse/RAT-124 Project: Apache Rat Issue Type: Bug Components: maven Affects Versions: 0.8 Reporter: Dennis Lundberg Assignee: Dennis Lundberg Fix For: 0.9 The plugin currently excludes the older file based configuration files for IDEA: *.ipr, *.iml, *.iws. It should also exclude the newer directory based configuration directory: .idea. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (RAT-116) Docs don't say what the default excludes are
[ https://issues.apache.org/jira/browse/RAT-116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg resolved RAT-116. - Resolution: Fixed Fix Version/s: 0.9 Assignee: Dennis Lundberg Documentation updated in r1405598 to better show what is excluded http://svn.apache.org/viewvc?view=revisionrevision=1405598 We should probably open new issues if we want to exclude more files by default. Docs don't say what the default excludes are Key: RAT-116 URL: https://issues.apache.org/jira/browse/RAT-116 Project: Apache Rat Issue Type: Bug Components: docs, maven Reporter: Sebb Assignee: Dennis Lundberg Fix For: 0.9 The description for useDefaultExcludes does not say what the excludes are. The default should exclude .pmd but does not seem to. Probably all .* files in the top level directory should be excluded. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAT-98) Maven RAT report does not document skipped files
[
https://issues.apache.org/jira/browse/RAT-98?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13490248#comment-13490248
]
Dennis Lundberg commented on RAT-98:
The current behavior of the Maven plugin is to log the files that are excluded
in the build log.
It can look like this example, where I have excluded the BUILD.txt file:
[INFO]
[INFO] Building Apache Rat
[INFO]task-segment: [org.apache.rat:apache-rat-plugin:0.9-SNAPSHOT:check]
[INFO]
[INFO] snapshot org.apache.rat:apache-rat-core:0.9-SNAPSHOT: checking for
updates from apache.snapshots
[INFO] [apache-rat:check {execution: default-cli}]
[INFO] Exclude: BUILD.txt
Did you want for this to be included in the report?
Maven RAT report does not document skipped files
Key: RAT-98
URL: https://issues.apache.org/jira/browse/RAT-98
Project: Apache Rat
Issue Type: Bug
Reporter: Sebb
The Maven RAT report should document which files have been skipped using the
exclude option.
Either by listing the configuration details, or better by listing the file
names with a marker, e.g. EX to show they were deliberately skipped.
Note: this only refers to files listed in exclude entries, not files which
are excluded by default.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WHISKER-10) Investigate Whether with-license issues are skipped without copyright-notice
[ https://issues.apache.org/jira/browse/WHISKER-10?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13490903#comment-13490903 ] Robert Burrell Donkin commented on WHISKER-10: -- Added a new integration test using the full descriptor, and then removed the copyright notices without harm to the resources. Chip confirms that this potential issue doesn't seem to effect the current codebase. [1] http://mail-archives.apache.org/mod_mbox/creadur-dev/201211.mbox/%3CCA%2B96GG5BtWqjkVTzCC8zGazCfvxwGZP9B7TK5-LYosVA_DBa-g%40mail.gmail.com%3E Investigate Whether with-license issues are skipped without copyright-notice Key: WHISKER-10 URL: https://issues.apache.org/jira/browse/WHISKER-10 Project: Apache Whisker Issue Type: Bug Reporter: Robert Burrell Donkin Assignee: Robert Burrell Donkin In some circumstances, it seems necessary to add copyright-notice elements before with-license elements are printed correctly. Create tests to prove whether this is still the case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAT-98) Maven RAT report does not document skipped files
[ https://issues.apache.org/jira/browse/RAT-98?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13491746#comment-13491746 ] Robert Burrell Donkin commented on RAT-98: -- +1 Maven RAT report does not document skipped files Key: RAT-98 URL: https://issues.apache.org/jira/browse/RAT-98 Project: Apache Rat Issue Type: Bug Reporter: Sebb The Maven RAT report should document which files have been skipped using the exclude option. Either by listing the configuration details, or better by listing the file names with a marker, e.g. EX to show they were deliberately skipped. Note: this only refers to files listed in exclude entries, not files which are excluded by default. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (WHISKER-11) Support configuration which adds sources links into LICENSE
Robert Burrell Donkin created WHISKER-11: Summary: Support configuration which adds sources links into LICENSE Key: WHISKER-11 URL: https://issues.apache.org/jira/browse/WHISKER-11 Project: Apache Whisker Issue Type: Bug Reporter: Robert Burrell Donkin Assignee: Robert Burrell Donkin Adding source links into LICENSE is not necessary from a legal perspective but is a nice way to credit included software. Add a configuration setting for Whisker to control this feature. http://mail-archives.apache.org/mod_mbox/creadur-dev/201211.mbox/%3C5092DD11.4070404%40blueyonder.co.uk%3E -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (RAT-123) Improve Rat Core Documentation
[ https://issues.apache.org/jira/browse/RAT-123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Burrell Donkin resolved RAT-123. --- Resolution: Fixed Reworked main page Improve Rat Core Documentation -- Key: RAT-123 URL: https://issues.apache.org/jira/browse/RAT-123 Project: Apache Rat Issue Type: Bug Affects Versions: 0.8 Reporter: Robert Burrell Donkin Assignee: Robert Burrell Donkin As noted[1], the documentation for the core module is poor. Good idea to improve it before the next release. [1] http://mail-archives.apache.org/mod_mbox/creadur-dev/201210.mbox/%3C507C74EF.8040603%40apache.org%3E -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (RAT-125) Support applied ASL20 license headers, including checking for required copyright header line
Ate Douma created RAT-125: - Summary: Support applied ASL20 license headers, including checking for required copyright header line Key: RAT-125 URL: https://issues.apache.org/jira/browse/RAT-125 Project: Apache Rat Issue Type: Improvement Affects Versions: 0.9 Reporter: Ate Douma Fix For: 0.9 Attachments: RAT-125.patch While checking on an ASL20 license header itself is supported by Apache Rat (duh), properly checking an applied ASL20 license (for usage *outside* the ASF) isn't supported yet. I've created an AppliedApacheSoftwareLicense20 check which does check this, using the http://apache.org/licenses/LICENSE-2.0.html#apply template as template (duh). This header matcher itself extends a more generic CopyrightHeader matcher, which only takes care of the copyright header line validation, using a regex pattern + configurable copyright owner. I'll attach a patch with the above two header matchers + unit tests shortly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (RAT-125) Support applied ASL20 license headers, including checking for required copyright header line
[ https://issues.apache.org/jira/browse/RAT-125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ate Douma updated RAT-125: -- Attachment: RAT-125.patch Support applied ASL20 license headers, including checking for required copyright header line Key: RAT-125 URL: https://issues.apache.org/jira/browse/RAT-125 Project: Apache Rat Issue Type: Improvement Affects Versions: 0.9 Reporter: Ate Douma Fix For: 0.9 Attachments: RAT-125.patch While checking on an ASL20 license header itself is supported by Apache Rat (duh), properly checking an applied ASL20 license (for usage *outside* the ASF) isn't supported yet. I've created an AppliedApacheSoftwareLicense20 check which does check this, using the http://apache.org/licenses/LICENSE-2.0.html#apply template as template (duh). This header matcher itself extends a more generic CopyrightHeader matcher, which only takes care of the copyright header line validation, using a regex pattern + configurable copyright owner. I'll attach a patch with the above two header matchers + unit tests shortly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (RAT-125) Support applied ASL20 license headers, including checking for required copyright header line
[ https://issues.apache.org/jira/browse/RAT-125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ate Douma updated RAT-125: -- Description: While checking on an ASL20 license header itself is supported by Apache Rat (duh), properly checking an applied ASL20 license (for usage *outside* the ASF) isn't supported yet. I've created an AppliedApacheSoftwareLicense20 check which does check this, using the http://apache.org/licenses/LICENSE-2.0.html#apply template as template (duh). This header matcher itself extends a more generic CopyrightHeader matcher, which only takes care of the copyright header line validation, using a regex pattern + configurable copyright owner. As an example the following configuration: plugin groupIdorg.apache.rat/groupId artifactIdapache-rat-plugin/artifactId version0.9-SNAPSHOT/version configuration licenses license implementation=org.apache.rat.analysis.license.AppliedApacheSoftwareLicense20 copyrightOwnerFooBar \(www\.foobar\.com\)/copyrightOwner /license /licenses /configuration /plugin will properly match a license header like: Copyright 2012 FooBar (www.foobar.com) Licensed under the Apache License, Version 2.0 (the License); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. I'll attach a patch with the two header matchers + unit tests shortly. was: While checking on an ASL20 license header itself is supported by Apache Rat (duh), properly checking an applied ASL20 license (for usage *outside* the ASF) isn't supported yet. I've created an AppliedApacheSoftwareLicense20 check which does check this, using the http://apache.org/licenses/LICENSE-2.0.html#apply template as template (duh). This header matcher itself extends a more generic CopyrightHeader matcher, which only takes care of the copyright header line validation, using a regex pattern + configurable copyright owner. I'll attach a patch with the above two header matchers + unit tests shortly. Support applied ASL20 license headers, including checking for required copyright header line Key: RAT-125 URL: https://issues.apache.org/jira/browse/RAT-125 Project: Apache Rat Issue Type: Improvement Affects Versions: 0.9 Reporter: Ate Douma Fix For: 0.9 Attachments: RAT-125.patch While checking on an ASL20 license header itself is supported by Apache Rat (duh), properly checking an applied ASL20 license (for usage *outside* the ASF) isn't supported yet. I've created an AppliedApacheSoftwareLicense20 check which does check this, using the http://apache.org/licenses/LICENSE-2.0.html#apply template as template (duh). This header matcher itself extends a more generic CopyrightHeader matcher, which only takes care of the copyright header line validation, using a regex pattern + configurable copyright owner. As an example the following configuration: plugin groupIdorg.apache.rat/groupId artifactIdapache-rat-plugin/artifactId version0.9-SNAPSHOT/version configuration licenses license implementation=org.apache.rat.analysis.license.AppliedApacheSoftwareLicense20 copyrightOwnerFooBar \(www\.foobar\.com\)/copyrightOwner /license /licenses /configuration /plugin will properly match a license header like: Copyright 2012 FooBar (www.foobar.com) Licensed under the Apache License, Version 2.0 (the License); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. I'll attach a patch with the two header matchers + unit tests shortly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAT-126) Default excludes do not ignore .git/ repository
[ https://issues.apache.org/jira/browse/RAT-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13581561#comment-13581561 ] Robert Burrell Donkin commented on RAT-126: --- Hi Bernd We're pushing towards releasing Apache Rat 0.9 very soon. If you could supply a patch including appropriate tests, we might be able to squeeze a fix in. Otherwise, it will probably need to wait until 0.10 (though I hope we'll be able to release more often in the new future). Robert Default excludes do not ignore .git/ repository --- Key: RAT-126 URL: https://issues.apache.org/jira/browse/RAT-126 Project: Apache Rat Issue Type: Bug Components: maven Affects Versions: 0.8 Environment: Windows 7, Maven 3.0.4, Oracle JDK 1.7.0_11, Eclipse Reporter: Bernd Eckenfels Priority: Minor When running the RAT 0.8 maven plugin from command line (no POM entry for the plugin) in a Eclipse+Maven project which is checked out from .git/ the plugin will not by default exclude the repository dotdir. C:\ws\proj\ws\apache-maven-3.0.4\bin\mvn -s ..\empty.xml org.apache.rat:apache-rat-plugin:check ... [INFO] --- apache-rat-plugin:0.8:check (default-cli) @ et-otp --- [INFO] No excludes ... The excludes should eighter be contained in the eclipse defaults or have its own dotfile or scm category. A workaround would be to specify the excludes, unfortunatelly there seems to be no expression associated with the exclude property of the mojo. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (RAT-127) Print report file location in error message
[ https://issues.apache.org/jira/browse/RAT-127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bernd Eckenfels updated RAT-127: Attachment: rat127.patch Took me some time to get that damned SVN work with my Windows (I am not sure if the native eol setting in the repository is so good.) Anyway, here is the patch with a new test case and enhanced warning+exception message. It also adds a info() logging line with basic statistics for check goal. I hereby agree that you use this changed code under any license you may like. Print report file location in error message --- Key: RAT-127 URL: https://issues.apache.org/jira/browse/RAT-127 Project: Apache Rat Issue Type: Wish Components: maven Affects Versions: 0.8 Environment: Windows 7, Maven 3.0.4, Oracle JDK 1.7.0_11, Eclipse Reporter: Bernd Eckenfels Priority: Minor Labels: maven, ux Attachments: rat127.patch When running the RAT 0.8 maven plugin from command line (no POM entry for the plugin) it will print a short error message how many violations it found, but this message could be enhanced by pointing to the report file: C:\ws\proj\ws\apache-maven-3.0.4\bin\mvn -s ..\empty.xml org.apache.rat:apache-rat-plugin:check ... [INFO] --- apache-rat-plugin:0.8:check (default-cli) @ proj --- ... [ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.8:check (default-cli) on project proj: Too many unapproved licenses: 26 - [Help 1] Better: [ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.8:check (default-cli) on project proj: Too many unapproved licenses: 26. See target/rat.txt The excludes should eighter be contained in the eclipse defaults or have its own dotfile or scm category. A workaround would be to specify the excludes, unfortunatelly there seems to be no expression associated with the exclude property of the mojo. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAT-126) Default excludes do not ignore .git/ repository
[ https://issues.apache.org/jira/browse/RAT-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13587516#comment-13587516 ] Robert Burrell Donkin commented on RAT-126: --- Executing a freshly built 0.9-SNAPSHOT from the command line also indicates that there are no excludes: $ mvn org.apache.rat:apache-rat-plugin:0.9-SNAPSHOT:check [INFO] Scanning for projects... [INFO] [INFO] [INFO] Building some-project 1.0-SNAPSHOT [INFO] [INFO] [INFO] --- apache-rat-plugin:0.9-SNAPSHOT:check (default-cli) @ some-project --- [INFO] No excludes [INFO] Rat check: Summary of files. Unapproved: 3 unknown: 3 generated: 0 approved: 0 licence. [INFO] [INFO] BUILD FAILURE [INFO] [INFO] Total time: 2.673s [INFO] Finished at: Tue Feb 26 20:38:26 GMT 2013 [INFO] Final Memory: 6M/245M [INFO] [ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.9-SNAPSHOT:check (default-cli) on project some-project: Too many files with unapproved license: 3 See RAT report in: /opt/development/2012/kata/temp/some-project/target/rat.txt - [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException Default excludes do not ignore .git/ repository --- Key: RAT-126 URL: https://issues.apache.org/jira/browse/RAT-126 Project: Apache Rat Issue Type: Bug Components: maven Affects Versions: 0.8 Environment: Windows 7, Maven 3.0.4, Oracle JDK 1.7.0_11, Eclipse Reporter: Bernd Eckenfels Priority: Minor When running the RAT 0.8 maven plugin from command line (no POM entry for the plugin) in a Eclipse+Maven project which is checked out from .git/ the plugin will not by default exclude the repository dotdir. C:\ws\proj\ws\apache-maven-3.0.4\bin\mvn -s ..\empty.xml org.apache.rat:apache-rat-plugin:check ... [INFO] --- apache-rat-plugin:0.8:check (default-cli) @ et-otp --- [INFO] No excludes ... The excludes should eighter be contained in the eclipse defaults or have its own dotfile or scm category. A workaround would be to specify the excludes, unfortunatelly there seems to be no expression associated with the exclude property of the mojo. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAT-126) Default excludes do not ignore .git/ repository
[ https://issues.apache.org/jira/browse/RAT-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13587583#comment-13587583 ] Robert Burrell Donkin commented on RAT-126: --- The 'No excludes' message is quite confusing. I've improved this message and added extra debug logging. For me, mvn org.apache.rat:apache-rat-plugin:0.9-SNAPSHOT:check now ignores the .git/ directory, via plexus DirectoryScanner.DEFAULTEXCLUDES. I'm using mvn 3.0.5. So, I think this might be fixed. Please retest once the release candidate is available. Default excludes do not ignore .git/ repository --- Key: RAT-126 URL: https://issues.apache.org/jira/browse/RAT-126 Project: Apache Rat Issue Type: Bug Components: maven Affects Versions: 0.8 Environment: Windows 7, Maven 3.0.4, Oracle JDK 1.7.0_11, Eclipse Reporter: Bernd Eckenfels Priority: Minor When running the RAT 0.8 maven plugin from command line (no POM entry for the plugin) in a Eclipse+Maven project which is checked out from .git/ the plugin will not by default exclude the repository dotdir. C:\ws\proj\ws\apache-maven-3.0.4\bin\mvn -s ..\empty.xml org.apache.rat:apache-rat-plugin:check ... [INFO] --- apache-rat-plugin:0.8:check (default-cli) @ et-otp --- [INFO] No excludes ... The excludes should eighter be contained in the eclipse defaults or have its own dotfile or scm category. A workaround would be to specify the excludes, unfortunatelly there seems to be no expression associated with the exclude property of the mojo. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (RAT-125) Support applied ASL20 license headers, including checking for required copyright header line
[ https://issues.apache.org/jira/browse/RAT-125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Burrell Donkin resolved RAT-125. --- Resolution: Fixed Support applied ASL20 license headers, including checking for required copyright header line Key: RAT-125 URL: https://issues.apache.org/jira/browse/RAT-125 Project: Apache Rat Issue Type: Improvement Affects Versions: 0.9 Reporter: Ate Douma Assignee: Robert Burrell Donkin Fix For: 0.9 Attachments: RAT-125.patch While checking on an ASL20 license header itself is supported by Apache Rat (duh), properly checking an applied ASL20 license (for usage *outside* the ASF) isn't supported yet. I've created an AppliedApacheSoftwareLicense20 check which does check this, using the http://apache.org/licenses/LICENSE-2.0.html#apply template as template (duh). This header matcher itself extends a more generic CopyrightHeader matcher, which only takes care of the copyright header line validation, using a regex pattern + configurable copyright owner. As an example the following configuration: plugin groupIdorg.apache.rat/groupId artifactIdapache-rat-plugin/artifactId version0.9-SNAPSHOT/version configuration licenses license implementation=org.apache.rat.analysis.license.AppliedApacheSoftwareLicense20 copyrightOwnerFooBar \(www\.foobar\.com\)/copyrightOwner /license /licenses /configuration /plugin will properly match a license header like: Copyright 2012 FooBar (www.foobar.com) Licensed under the Apache License, Version 2.0 (the License); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. I'll attach a patch with the two header matchers + unit tests shortly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (RAT-125) Support applied ASL20 license headers, including checking for required copyright header line
[ https://issues.apache.org/jira/browse/RAT-125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Burrell Donkin closed RAT-125. - Thanks for the patch Support applied ASL20 license headers, including checking for required copyright header line Key: RAT-125 URL: https://issues.apache.org/jira/browse/RAT-125 Project: Apache Rat Issue Type: Improvement Affects Versions: 0.9 Reporter: Ate Douma Assignee: Robert Burrell Donkin Fix For: 0.9 Attachments: RAT-125.patch While checking on an ASL20 license header itself is supported by Apache Rat (duh), properly checking an applied ASL20 license (for usage *outside* the ASF) isn't supported yet. I've created an AppliedApacheSoftwareLicense20 check which does check this, using the http://apache.org/licenses/LICENSE-2.0.html#apply template as template (duh). This header matcher itself extends a more generic CopyrightHeader matcher, which only takes care of the copyright header line validation, using a regex pattern + configurable copyright owner. As an example the following configuration: plugin groupIdorg.apache.rat/groupId artifactIdapache-rat-plugin/artifactId version0.9-SNAPSHOT/version configuration licenses license implementation=org.apache.rat.analysis.license.AppliedApacheSoftwareLicense20 copyrightOwnerFooBar \(www\.foobar\.com\)/copyrightOwner /license /licenses /configuration /plugin will properly match a license header like: Copyright 2012 FooBar (www.foobar.com) Licensed under the Apache License, Version 2.0 (the License); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. I'll attach a patch with the two header matchers + unit tests shortly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAT-126) Default excludes do not ignore .git/ repository
[ https://issues.apache.org/jira/browse/RAT-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13587618#comment-13587618 ] Bernd Eckenfels commented on RAT-126: - The fix looks good, it (suddenly?) also ignores the .git directory. BTW: I wonder if it is better to list only ignored resources instead of the exclude patterns. Especially for the number printed this is much more interesting. Default excludes do not ignore .git/ repository --- Key: RAT-126 URL: https://issues.apache.org/jira/browse/RAT-126 Project: Apache Rat Issue Type: Bug Components: maven Affects Versions: 0.8 Environment: Windows 7, Maven 3.0.4, Oracle JDK 1.7.0_11, Eclipse Reporter: Bernd Eckenfels Priority: Minor When running the RAT 0.8 maven plugin from command line (no POM entry for the plugin) in a Eclipse+Maven project which is checked out from .git/ the plugin will not by default exclude the repository dotdir. C:\ws\proj\ws\apache-maven-3.0.4\bin\mvn -s ..\empty.xml org.apache.rat:apache-rat-plugin:check ... [INFO] --- apache-rat-plugin:0.8:check (default-cli) @ et-otp --- [INFO] No excludes ... The excludes should eighter be contained in the eclipse defaults or have its own dotfile or scm category. A workaround would be to specify the excludes, unfortunatelly there seems to be no expression associated with the exclude property of the mojo. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (RAT-127) Print report file location in error message
[ https://issues.apache.org/jira/browse/RAT-127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Burrell Donkin closed RAT-127. - Print report file location in error message --- Key: RAT-127 URL: https://issues.apache.org/jira/browse/RAT-127 Project: Apache Rat Issue Type: Wish Components: maven Affects Versions: 0.8 Environment: Windows 7, Maven 3.0.4, Oracle JDK 1.7.0_11, Eclipse Reporter: Bernd Eckenfels Assignee: Robert Burrell Donkin Priority: Minor Labels: maven, ux Fix For: 0.9 Attachments: rat127.patch When running the RAT 0.8 maven plugin from command line (no POM entry for the plugin) it will print a short error message how many violations it found, but this message could be enhanced by pointing to the report file: C:\ws\proj\ws\apache-maven-3.0.4\bin\mvn -s ..\empty.xml org.apache.rat:apache-rat-plugin:check ... [INFO] --- apache-rat-plugin:0.8:check (default-cli) @ proj --- ... [ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.8:check (default-cli) on project proj: Too many unapproved licenses: 26 - [Help 1] Better: [ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.8:check (default-cli) on project proj: Too many unapproved licenses: 26. See target/rat.txt -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (RAT-128) Use the proper name for Apache License
David Crossley created RAT-128: -- Summary: Use the proper name for Apache License Key: RAT-128 URL: https://issues.apache.org/jira/browse/RAT-128 Project: Apache Rat Issue Type: Bug Components: license-meta-data Reporter: David Crossley The old license was called the Apache Software License, but not the new one. It is called the Apache License. However RAT mixes up the terminology using Apache Software License and ASL20. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAT-128) Use the proper name for Apache License
[ https://issues.apache.org/jira/browse/RAT-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13591607#comment-13591607 ] David Crossley commented on RAT-128: Here are some useful recent discussion points: http://mail-archives.apache.org/mod_mbox/www-legal-discuss/201302.mbox/%3c5122b834.40...@shanecurcuru.org%3E http://mail-archives.apache.org/mod_mbox/www-legal-discuss/201302.mbox/%3ccd48d6d3.8da73%25pode...@blackducksoftware.com%3E Use the proper name for Apache License -- Key: RAT-128 URL: https://issues.apache.org/jira/browse/RAT-128 Project: Apache Rat Issue Type: Bug Components: license-meta-data Reporter: David Crossley The old license was called the Apache Software License, but not the new one. It is called the Apache License. However RAT mixes up the terminology using Apache Software License and ASL20. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (RAT-130) GSOC Port Apache Rat to New Languages, Integrate With New Build Systems
Robert Burrell Donkin created RAT-130: - Summary: GSOC Port Apache Rat to New Languages, Integrate With New Build Systems Key: RAT-130 URL: https://issues.apache.org/jira/browse/RAT-130 Project: Apache Rat Issue Type: Wish Reporter: Robert Burrell Donkin Apache Rat helps projects audit and comprehend the licenses qualities of the software they ship. Today, Apache Rat is coded in Java and integrates with Apache Maven and Apache Ant (as well as the command line). Ports to other other languages and build systems would help increase adoption. This would be an ideal project for a student interested in using a variety of languages (for example Ruby, Python, JavaScript and CoffeeScript) perhaps porting to a new language or build system each week.The exact scope of schedule would be negotiable. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (RAT-131) GSOC Refactor Apache Rat Core to a Classic Object Oriented Design
Robert Burrell Donkin created RAT-131: - Summary: GSOC Refactor Apache Rat Core to a Classic Object Oriented Design Key: RAT-131 URL: https://issues.apache.org/jira/browse/RAT-131 Project: Apache Rat Issue Type: Wish Reporter: Robert Burrell Donkin The core code for Apache Rat has difficulties which lead to a high bar for contributions: * based on an experimental streaming architecture * hard to understand * poorly covered by edge-to-edge tests Replace this by a conventional object-oriented design with clear model based on the domain. A good opportunity for a student interested in Agile, test-first approaches and domain-driven design with a good sense of object-oriented design to showcase their skills and learn about open source development. The emphasis would be on high quality, test-driven code driving a clear, well documented design, -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (RAT-132) GSOC License Lexicon
Robert Burrell Donkin created RAT-132: - Summary: GSOC License Lexicon Key: RAT-132 URL: https://issues.apache.org/jira/browse/RAT-132 Project: Apache Rat Issue Type: Wish Reporter: Robert Burrell Donkin Apache Rat and Apache Whiskers are tools which help people to audit and comprehend licenses within releases. Both Rat and Whiskers lack both a comprehensive library and consistent terminology for licenses: a license lexicon. Though this ticket is raised under Rat, a successful GSOC would hopefully lead to the development of an independent product. This GSOC project would both compile a set of meta-data, plus perhaps support libraries which could be reused both by these projects and more widely. Collate comprehensive license meta-data, beginning with all OSI approved open source licenses and working outwards to include other common binary only licenses. This meta-data might include: * descriptions of common source boilerplates * generation and recognition templates * consistent language, both machine and human readable This is most suitable for students whose interests focus more in semantics than coding. The scope and direction are negotiable. For students interested in text parsing, this meta-data could be used to create fast parsers. For students interested in technology law, the semantics could be extend to include relationships between licenses. For students more interested in informatics, there would be an opportunity to work on a comprehensive collection. For all students, this is an opportunity to showcase communication skills. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAT-130) GSOC Port Apache Rat to New Languages, Integrate With New Build Systems
[ https://issues.apache.org/jira/browse/RAT-130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13614124#comment-13614124 ] Ishan somasiri commented on RAT-130: So are you suggesting to port Rat to a totally new language or a build system every week with in the GSoC project period? That means roughly 14 new languages/build systems at the completion of GSoC 2013, right? (Considering the time frame of GSoC) GSOC Port Apache Rat to New Languages, Integrate With New Build Systems Key: RAT-130 URL: https://issues.apache.org/jira/browse/RAT-130 Project: Apache Rat Issue Type: Wish Reporter: Robert Burrell Donkin Labels: build, coffeescript, gsoc2013, javascript, python, ruby, tools Apache Rat helps projects audit and comprehend the licenses qualities of the software they ship. Today, Apache Rat is coded in Java and integrates with Apache Maven and Apache Ant (as well as the command line). Ports to other other languages and build systems would help increase adoption. This would be an ideal project for a student interested in using a variety of languages (for example Ruby, Python, JavaScript and CoffeeScript) perhaps porting to a new language or build system each week.The exact scope of schedule would be negotiable. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (RAT-147) binary guesser design improvement
Marshall Schor created RAT-147: -- Summary: binary guesser design improvement Key: RAT-147 URL: https://issues.apache.org/jira/browse/RAT-147 Project: Apache Rat Issue Type: Improvement Affects Versions: 0.8 Reporter: Marshall Schor Priority: Minor A release manager cut a release; RAT was run, all was OK. Another user tried building from source / tag, and RAT complained of 2 files missing headers. This was traced to the binary guesser which read the 1st 200 bytes of a file and guessed if it was binary. The file in question had a UTF-8 byte-order mark at the beginning, and was, in fact after that, plain ASCII. The reason for 2 different results: the release manager's OS had a default file encoding set to US-ASCII (as determined by running a small Java program that prints out the value of System.property(file.encoding). This encoding is for 7-bit ASCII, so the guesser when decoding this gets a malformed exception on the 3 bytes at the beginning of the file. This causes the guesser to conclude this is a binary file which doesn't need to be RAT-checked. The other user was on a Windows 7 machine, which has the file.encoding defaulting to Cp1252 - which does have code points defined for the first 3 bytes, and therefore doesn't throw any exception. This makes the guesser guess that this isn't a binary file, and it checks the file and reports a missing header (the file is test data...). Workaround - add the file to the explicit excludes. Potential problem - on a machine with default encoding US-ASCII, RAT will improperly skip checking files which perhaps should have headers, if they have a UTF-8 byte-order mark. Potential problem #2 - RAT is dependent on the default file encoding setting for part of its behavior, causing differences in what it checks. I'm not sure what a good solution would be here. It might range from eliminating the binary guesser that looks at the first 200 bytes of a file, to forcing UTF-8 as the charset to use. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (RAT-148) LicenseAddingReport#report has useless call to metaData.getData
Chris A. Mattmann created RAT-148:
-
Summary: LicenseAddingReport#report has useless call to
metaData.getData
Key: RAT-148
URL: https://issues.apache.org/jira/browse/RAT-148
Project: Apache Rat
Issue Type: Bug
Components: reports
Reporter: Chris A. Mattmann
Fix For: 0.9
While perusing the current trunk code, I noticed that
LicenseAddingReport.java#report has a useless call to metaData.getData:
{code:java}
public class LicenseAddingReport extends AbstractReport {
private final AbstractLicenceAppender appender;
public LicenseAddingReport(String pCopyrightMsg, boolean pForced) {
appender = pCopyrightMsg == null ? new ApacheV2LicenceAppender() : new
ApacheV2LicenceAppender(pCopyrightMsg);
appender.setForce(pForced);
}
@Override
public void report(org.apache.rat.api.Document document) throws
RatException {
final MetaData metaData = document.getMetaData();
final Datum licenseHeader =
metaData.get(MetaData.RAT_URL_HEADER_CATEGORY);
if (licenseHeader == null
||
MetaData.RAT_LICENSE_FAMILY_CATEGORY_DATUM_UNKNOWN.getValue().equals(licenseHeader.getValue()))
{
final File file = new File(document.getName());
if (file.isFile()) {
try {
appender.append(file);
} catch (IOException e) {
throw new RatException(e.getMessage(), e);
}
}
}
metaData.getData();
}
}
{code}
Looks to me that metaData is a local final variable, and that the call to
getData returns a MetaData object, which in turn is never used.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (RAT-148) LicenseAddingReport#report has useless call to metaData.getData
[
https://issues.apache.org/jira/browse/RAT-148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris A. Mattmann updated RAT-148:
--
Attachment: RAT-148.Mattmann.082813.patch.txt
LicenseAddingReport#report has useless call to metaData.getData
---
Key: RAT-148
URL: https://issues.apache.org/jira/browse/RAT-148
Project: Apache Rat
Issue Type: Bug
Components: reports
Reporter: Chris A. Mattmann
Fix For: 0.9
Attachments: RAT-148.Mattmann.082813.patch.txt
While perusing the current trunk code, I noticed that
LicenseAddingReport.java#report has a useless call to metaData.getData:
{code:java}
public class LicenseAddingReport extends AbstractReport {
private final AbstractLicenceAppender appender;
public LicenseAddingReport(String pCopyrightMsg, boolean pForced) {
appender = pCopyrightMsg == null ? new ApacheV2LicenceAppender() :
new ApacheV2LicenceAppender(pCopyrightMsg);
appender.setForce(pForced);
}
@Override
public void report(org.apache.rat.api.Document document) throws
RatException {
final MetaData metaData = document.getMetaData();
final Datum licenseHeader =
metaData.get(MetaData.RAT_URL_HEADER_CATEGORY);
if (licenseHeader == null
||
MetaData.RAT_LICENSE_FAMILY_CATEGORY_DATUM_UNKNOWN.getValue().equals(licenseHeader.getValue()))
{
final File file = new File(document.getName());
if (file.isFile()) {
try {
appender.append(file);
} catch (IOException e) {
throw new RatException(e.getMessage(), e);
}
}
}
metaData.getData();
}
}
{code}
Looks to me that metaData is a local final variable, and that the call to
getData returns a MetaData object, which in turn is never used.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (RAT-149) RAT provides no incremental output
[ https://issues.apache.org/jira/browse/RAT-149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris A. Mattmann updated RAT-149: -- Issue Type: Improvement (was: Bug) RAT provides no incremental output -- Key: RAT-149 URL: https://issues.apache.org/jira/browse/RAT-149 Project: Apache Rat Issue Type: Improvement Components: scan Affects Versions: 0.8 Reporter: Chris A. Mattmann I've got a current RAT job running through a fairly large (30Gb) Git repository and it's been running for over 8 days straight. We need RAT to generate incremental output, perhaps with a verbose flag, and something to the effect of: Processing [filename] Time to analyze: [Xms] Approved licenses: [Y] Disapproved licenses: [Z] Or something on 1 line, or whatever. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (RAT-149) RAT provides no incremental output
Chris A. Mattmann created RAT-149: - Summary: RAT provides no incremental output Key: RAT-149 URL: https://issues.apache.org/jira/browse/RAT-149 Project: Apache Rat Issue Type: Bug Components: scan Affects Versions: 0.8 Reporter: Chris A. Mattmann I've got a current RAT job running through a fairly large (30Gb) Git repository and it's been running for over 8 days straight. We need RAT to generate incremental output, perhaps with a verbose flag, and something to the effect of: Processing [filename] Time to analyze: [Xms] Approved licenses: [Y] Disapproved licenses: [Z] Or something on 1 line, or whatever. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAT-150) RAT should use Apache Tika to simply guess ignored [application/X] file types and focus on the [text/Y] family as a sensible default
[ https://issues.apache.org/jira/browse/RAT-150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13753677#comment-13753677 ] Chris A. Mattmann commented on RAT-150: --- Agree, will support this in a back compat way. I'm working on a patch for your guys review. Do you use Review Board? RAT should use Apache Tika to simply guess ignored [application/X] file types and focus on the [text/Y] family as a sensible default Key: RAT-150 URL: https://issues.apache.org/jira/browse/RAT-150 Project: Apache Rat Issue Type: New Feature Components: mime-meta-data, scan Affects Versions: 0.8 Reporter: Chris A. Mattmann RAT could use Apache Tika to automatically guess file types, obviating the need to specify an explicit white list or black list. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (RAT-153) Do not add extra empty lines when appending headers for the Apache License
Dennis Lundberg created RAT-153: --- Summary: Do not add extra empty lines when appending headers for the Apache License Key: RAT-153 URL: https://issues.apache.org/jira/browse/RAT-153 Project: Apache Rat Issue Type: Bug Affects Versions: 0.10 Reporter: Dennis Lundberg Assignee: Dennis Lundberg Fix For: 0.11 When adding license headers for the Apache License empty leading and trailing lines are added, although these lines should not be part of the license header. See http://www.apache.org/legal/src-headers.html for reference. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Created] (RAT-154) Indentation of the license header should be decided per family
Dennis Lundberg created RAT-154: --- Summary: Indentation of the license header should be decided per family Key: RAT-154 URL: https://issues.apache.org/jira/browse/RAT-154 Project: Apache Rat Issue Type: Bug Affects Versions: 0.10 Reporter: Dennis Lundberg Assignee: Dennis Lundberg Fix For: 0.11 The current indentation of the license header is done the same way for every family of source files. This is not optimal as different families might want different indentations. Move the indentation to each family instead. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Resolved] (RAT-135) addLicenseHeaders is missing a space on license header.
[ https://issues.apache.org/jira/browse/RAT-135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg resolved RAT-135. - Resolution: Fixed Fix Version/s: 0.11 Assignee: Dennis Lundberg Fixed in [r1545782|http://svn.apache.org/viewvc?view=revisionrevision=1545782]. addLicenseHeaders is missing a space on license header. --- Key: RAT-135 URL: https://issues.apache.org/jira/browse/RAT-135 Project: Apache Rat Issue Type: Bug Components: cli, maven Affects Versions: 0.10 Reporter: Chris Riccomini Assignee: Dennis Lundberg Fix For: 0.11 The Apache license that gets pre-pended by default is as follows: bq. /** * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file to You under the Apache License, Version 2.0 * (the License); you may not use this file except in compliance with * the License. You may obtain a copy of the License at * *http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an AS IS BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. */ The last line is missing a space. It should be: bq. /** * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file to You under the Apache License, Version 2.0 * (the License); you may not use this file except in compliance with * the License. You may obtain a copy of the License at * *http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an AS IS BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. */ -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Created] (RAT-155) Do not add empty first and last lines in the license header for certain families
Dennis Lundberg created RAT-155: --- Summary: Do not add empty first and last lines in the license header for certain families Key: RAT-155 URL: https://issues.apache.org/jira/browse/RAT-155 Project: Apache Rat Issue Type: Bug Affects Versions: 0.10 Reporter: Dennis Lundberg Assignee: Dennis Lundberg Fix For: 0.11 For families with asymmetrical comment formats like C and SGML it makes sense to have specially crafted first and last lines, simply because the format demands them. For other families it makes no sense because they are just empty (commented out) lines, so they should be removed. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Created] (RAT-156) Add some symmetry when applying license headers to files with file type specific headers
Dennis Lundberg created RAT-156:
---
Summary: Add some symmetry when applying license headers to files
with file type specific headers
Key: RAT-156
URL: https://issues.apache.org/jira/browse/RAT-156
Project: Apache Rat
Issue Type: Bug
Affects Versions: 0.10
Reporter: Dennis Lundberg
Assignee: Dennis Lundberg
Fix For: 0.11
Some file types may have a file type specific header. For example a java file
should start with a package declaration, an XML file might have an XML
declaration and similarly for PHP files. The current output in not symmetrical
when applying license headers to these files.
Current formats, after license headers have been applied by Rat:
{code:xml}
?xml version='1.0'?
[license header]
[empty line]
document
...
/document
{code}
{code:java}
package org.apache.rat;
[license header]
[empty line]
public class MyClass {
...
}
{code}
We should add an empty line before the license headers, like this:
{code:xml}
?xml version='1.0'?
[empty line]
[license header]
[empty line]
document
...
/document
{code}
{code:java}
package org.apache.rat;
[empty line]
[license header]
[empty line]
public class MyClass {
...
}
{code}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Resolved] (RAT-156) Add some symmetry when applying license headers to files with file type specific headers
[
https://issues.apache.org/jira/browse/RAT-156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Lundberg resolved RAT-156.
-
Resolution: Fixed
Fixed in [r1545788|http://svn.apache.org/viewvc?view=revisionrevision=1545788].
Add some symmetry when applying license headers to files with file type
specific headers
Key: RAT-156
URL: https://issues.apache.org/jira/browse/RAT-156
Project: Apache Rat
Issue Type: Bug
Affects Versions: 0.10
Reporter: Dennis Lundberg
Assignee: Dennis Lundberg
Fix For: 0.11
Some file types may have a file type specific header. For example a java
file should start with a package declaration, an XML file might have an XML
declaration and similarly for PHP files. The current output in not
symmetrical when applying license headers to these files.
Current formats, after license headers have been applied by Rat:
{code:xml}
?xml version='1.0'?
[license header]
[empty line]
document
...
/document
{code}
{code:java}
package org.apache.rat;
[license header]
[empty line]
public class MyClass {
...
}
{code}
We should add an empty line before the license headers, like this:
{code:xml}
?xml version='1.0'?
[empty line]
[license header]
[empty line]
document
...
/document
{code}
{code:java}
package org.apache.rat;
[empty line]
[license header]
[empty line]
public class MyClass {
...
}
{code}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (RAT-129) Add support for CDDL 1.0
[ https://issues.apache.org/jira/browse/RAT-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13832906#comment-13832906 ] Dennis Lundberg commented on RAT-129: - Shouldn't this issue be resolved if the patch has been applied? Add support for CDDL 1.0 Key: RAT-129 URL: https://issues.apache.org/jira/browse/RAT-129 Project: Apache Rat Issue Type: Improvement Reporter: Francesco Chicchiriccò Fix For: 0.11 Attachments: RAT-129.patch The CDDL 1.0 is not currently supported. The attached patch adds this feature. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (RAT-157) Use the *ignore file for the SCM to determine excludes
[ https://issues.apache.org/jira/browse/RAT-157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lucas theisen updated RAT-157: -- Description: As I understand it, RAT is used to ensure the LICENSE text is in all source files. Anything ignored by SCM is not technically a source file. These other files are usually specific to the developer environment. And the developer will already be adding such files to their own *SCMignore*. Perhaps a pluggable ingore mechanism that could have an implementation per SCM and would know how to parse that ignore and translate filter out all the files it specifies. Perhaps this could be an option to the the rat config `useGitIgnore` or something. What do you think? (was: As I understand it, RAT is used to ensure the LICENSE text is in all source files. Anything ignored by SCM is not technically a source file. These other files are usually specific to the developer environment. And the developer will already be adding such files to their own `SCMignore`. Perhaps a pluggable ingore mechanism that could have an implementation per SCM and would know how to parse that ignore and translate filter out all the files it specifies. Perhaps this could be an option to the the rat config `useGitIgnore` or something. What do you think?) Use the *ignore file for the SCM to determine excludes -- Key: RAT-157 URL: https://issues.apache.org/jira/browse/RAT-157 Project: Apache Rat Issue Type: New Feature Reporter: lucas theisen Priority: Minor As I understand it, RAT is used to ensure the LICENSE text is in all source files. Anything ignored by SCM is not technically a source file. These other files are usually specific to the developer environment. And the developer will already be adding such files to their own *SCMignore*. Perhaps a pluggable ingore mechanism that could have an implementation per SCM and would know how to parse that ignore and translate filter out all the files it specifies. Perhaps this could be an option to the the rat config `useGitIgnore` or something. What do you think? -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Created] (RAT-158) SAXParser warnings
John Vines created RAT-158:
--
Summary: SAXParser warnings
Key: RAT-158
URL: https://issues.apache.org/jira/browse/RAT-158
Project: Apache Rat
Issue Type: Bug
Affects Versions: 0.10
Environment: Apache Maven 3.0.4
Maven home: /usr/share/maven
Java version: 1.6.0_30, vendor: Sun Microsystems Inc.
Java home: /usr/lib/jvm/java-6-openjdk-amd64/jre
Default locale: en_US, platform encoding: UTF-8
OS name: linux, version: 3.11.0-17-generic, arch: amd64, family: unix
Reporter: John Vines
Priority: Minor
I have rat configured as such
{code} plugin
groupIdorg.apache.rat/groupId
artifactIdapache-rat-plugin/artifactId
inheritedfalse/inherited
executions
execution
phaseverify/phase
goals
goalcheck/goal
/goals
/execution
/executions
configuration
excludes
exclude**/conf/**/exclude
/excludes
/configuration
/plugin
{code}
And with every build where it triggers, I see
{code}
Warning: org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property
'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not
recognized.
Warning: org.apache.xerces.parsers.SAXParser: Feature
'http://javax.xml.XMLConstants/feature/secure-processing' is not recognized.
Warning: org.apache.xerces.parsers.SAXParser: Property
'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not
recognized.
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Closed] (RAT-159) Detect OpenOffice documents as being archives
[ https://issues.apache.org/jira/browse/RAT-159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg closed RAT-159. --- Resolution: Fixed Fixed in [r1585578|http://svn.apache.org/viewvc?view=revisionrevision=1585578]. Detect OpenOffice documents as being archives - Key: RAT-159 URL: https://issues.apache.org/jira/browse/RAT-159 Project: Apache Rat Issue Type: Bug Affects Versions: 0.10 Reporter: Dennis Lundberg Assignee: Dennis Lundberg Fix For: 0.11 Rat currently does not recognize OpenOffice documents. This means that they will be flagged as not having a license header. They are in fact archives, so Rat should detect them as such. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (RAT-129) Add support for CDDL 1.0
[ https://issues.apache.org/jira/browse/RAT-129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg reassigned RAT-129: --- Assignee: Sebb Add support for CDDL 1.0 Key: RAT-129 URL: https://issues.apache.org/jira/browse/RAT-129 Project: Apache Rat Issue Type: Improvement Reporter: Francesco Chicchiriccò Assignee: Sebb Fix For: 0.11 Attachments: RAT-129.patch The CDDL 1.0 is not currently supported. The attached patch adds this feature. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (RAT-129) Add support for CDDL 1.0
[ https://issues.apache.org/jira/browse/RAT-129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg updated RAT-129: Assignee: Sebb Sebb, you were the one who applied the patch. That means you are the assignee of this issue. Add support for CDDL 1.0 Key: RAT-129 URL: https://issues.apache.org/jira/browse/RAT-129 Project: Apache Rat Issue Type: Improvement Reporter: Francesco Chicchiriccò Assignee: Sebb Fix For: 0.11 Attachments: RAT-129.patch The CDDL 1.0 is not currently supported. The attached patch adds this feature. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (RAT-160) Fails to ignore build.log created by maven-invoker-plugin
Christopher Tubbs created RAT-160: - Summary: Fails to ignore build.log created by maven-invoker-plugin Key: RAT-160 URL: https://issues.apache.org/jira/browse/RAT-160 Project: Apache Rat Issue Type: Bug Affects Versions: 0.10 Reporter: Christopher Tubbs Fix For: 0.11 When using maven-invoker-plugin to run integration-tests for a maven plugin project, maven-invoker-plugin creates a build.log file in the basedir for the project. This may be a bug in maven-invoker-plugin. Perhaps it'd be better to put this file in its build directory, rather than its basedir. Regardless, the apache-rat-plugin should ignore this build.log file. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (RAT-160) Fails to ignore build.log created by maven-invoker-plugin
[
https://issues.apache.org/jira/browse/RAT-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13965895#comment-13965895
]
Christopher Tubbs commented on RAT-160:
---
[~denn...@apache.org], I'm doing the same thing. The rat check isn't failing
for the plugin module. It's failing the IT test, because the project being
tested as the integration test includes my plugin, and a few other standard
ones, including rat, to ensure that my plugin works with all these.
Example:
{code}
myplugin/
myplugin/pom.xml
myplugin/src/it/test-project
myplugin/target/test-project/pom.xml
myplugin/target/test-project/build.log -- problem is here
myplugin/target/test-project/target
{code}
Fails to ignore build.log created by maven-invoker-plugin
-
Key: RAT-160
URL: https://issues.apache.org/jira/browse/RAT-160
Project: Apache Rat
Issue Type: Bug
Affects Versions: 0.10
Reporter: Christopher Tubbs
Fix For: 0.11
When using maven-invoker-plugin to run integration-tests for a maven plugin
project, maven-invoker-plugin creates a build.log file in the basedir for the
project.
This may be a bug in maven-invoker-plugin. Perhaps it'd be better to put this
file in its build directory, rather than its basedir. Regardless, the
apache-rat-plugin should ignore this build.log file.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (RAT-160) Fails to ignore build.log created by maven-invoker-plugin
[ https://issues.apache.org/jira/browse/RAT-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13968689#comment-13968689 ] Dennis Lundberg commented on RAT-160: - Christopher Tubbs, I'm not sure I understand your structure, but the Rat plugin excludes the target directory by default. So it should not be checked by Rat at all. Could you share you configuration? Fails to ignore build.log created by maven-invoker-plugin - Key: RAT-160 URL: https://issues.apache.org/jira/browse/RAT-160 Project: Apache Rat Issue Type: Bug Affects Versions: 0.10 Reporter: Christopher Tubbs Fix For: 0.11 When using maven-invoker-plugin to run integration-tests for a maven plugin project, maven-invoker-plugin creates a build.log file in the basedir for the project. This may be a bug in maven-invoker-plugin. Perhaps it'd be better to put this file in its build directory, rather than its basedir. Regardless, the apache-rat-plugin should ignore this build.log file. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (RAT-160) Fails to ignore build.log created by maven-invoker-plugin
[ https://issues.apache.org/jira/browse/RAT-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13968743#comment-13968743 ] Christopher Tubbs commented on RAT-160: --- [~denn...@apache.org]: Here's an example project to demonstrate the issue: https://github.com/ctubbsii/test-maven-plugin based on the maven-plugin archetype. Note that the check-licenses-outer execution of the RAT plugin succeeds fine, but the check-licenses-inner execution (the one in the IT project itself) does not. Note that the invoker plugin creates two target directories. The outer one is for the plugin project. The inner one is for the IT project, meant to test the plugin. Fails to ignore build.log created by maven-invoker-plugin - Key: RAT-160 URL: https://issues.apache.org/jira/browse/RAT-160 Project: Apache Rat Issue Type: Bug Affects Versions: 0.10 Reporter: Christopher Tubbs Fix For: 0.11 When using maven-invoker-plugin to run integration-tests for a maven plugin project, maven-invoker-plugin creates a build.log file in the basedir for the project. This may be a bug in maven-invoker-plugin. Perhaps it'd be better to put this file in its build directory, rather than its basedir. Regardless, the apache-rat-plugin should ignore this build.log file. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (RAT-162) CDDL1License.matches slow with large inputs
[
https://issues.apache.org/jira/browse/RAT-162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Gaul updated RAT-162:
Description:
mvn apache-rat:check runs slowly with large files. I accidentally had a 100 MB
log file which took over a minute to for RAT to parse. The stack trace
included:
{noformat}
main prio=10 tid=0x7f322800a000 nid=0x6730 runnable [0x7f3230235000]
java.lang.Thread.State: RUNNABLE
at java.util.regex.Pattern$Curly.match0(Pattern.java:4166)
at java.util.regex.Pattern$Curly.match(Pattern.java:4132)
at java.util.regex.Pattern$Start.match(Pattern.java:3408)
at java.util.regex.Matcher.search(Matcher.java:1199)
at java.util.regex.Matcher.find(Matcher.java:592)
at
org.apache.rat.analysis.license.CDDL1License.matches(CDDL1License.java:65)
at
org.apache.rat.analysis.license.SimplePatternBasedLicense.match(SimplePatternBasedLicense.java:69)
{noformat}
I attached a patch which caches the Patterns in CDDL1License which works around
this issue.
was:
mvn apache-rat:check runs slowly with large files. I accidentally had a 100 MB
log file which took over a minute to for RAT to parse. The stack trace
included:
{noformat}
main prio=10 tid=0x7f322800a000 nid=0x6730 runnable [0x7f3230235000]
java.lang.Thread.State: RUNNABLE
at java.util.regex.Pattern$Curly.match0(Pattern.java:4166)
at java.util.regex.Pattern$Curly.match(Pattern.java:4132)
at java.util.regex.Pattern$Start.match(Pattern.java:3408)
at java.util.regex.Matcher.search(Matcher.java:1199)
at java.util.regex.Matcher.find(Matcher.java:592)
at
org.apache.rat.analysis.license.CDDL1License.matches(CDDL1License.java:65)
at
org.apache.rat.analysis.license.SimplePatternBasedLicense.match(SimplePatternBasedLicense.java:69)
{noformat}
I attached a patch which caches the Patterns in CDDL1License works around this
issue.
CDDL1License.matches slow with large inputs
---
Key: RAT-162
URL: https://issues.apache.org/jira/browse/RAT-162
Project: Apache Rat
Issue Type: Improvement
Affects Versions: 0.10
Reporter: Andrew Gaul
Fix For: 0.11
Attachments: RAT-162.patch
mvn apache-rat:check runs slowly with large files. I accidentally had a 100
MB log file which took over a minute to for RAT to parse. The stack trace
included:
{noformat}
main prio=10 tid=0x7f322800a000 nid=0x6730 runnable [0x7f3230235000]
java.lang.Thread.State: RUNNABLE
at java.util.regex.Pattern$Curly.match0(Pattern.java:4166)
at java.util.regex.Pattern$Curly.match(Pattern.java:4132)
at java.util.regex.Pattern$Start.match(Pattern.java:3408)
at java.util.regex.Matcher.search(Matcher.java:1199)
at java.util.regex.Matcher.find(Matcher.java:592)
at
org.apache.rat.analysis.license.CDDL1License.matches(CDDL1License.java:65)
at
org.apache.rat.analysis.license.SimplePatternBasedLicense.match(SimplePatternBasedLicense.java:69)
{noformat}
I attached a patch which caches the Patterns in CDDL1License which works
around this issue.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (RAT-161) Support exclusion of paths: path/to/file.ext
[ https://issues.apache.org/jira/browse/RAT-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14028421#comment-14028421 ] Erik Erlandson commented on RAT-161: to put it another way, as I understand from the doc (and the code), you can either: a) specify path names, in maven config, via exclude.../exclude, but not regular expressions b) specify a list of regex via '-E', one per line, which cannot currently span paths, that is match across directory '/' c) specify regex on the CL via -'e' The purpose of this RFE is to allow regular expressions, which *can* span paths, so one can include patterns like 'path/to/file.ext' and '*.pom' in the same configuration. This might either be done by extending (a) to include regex that can match across '/', or enhancing (b) to include such regular expressions as well. Those are not mutually exclusive. Support exclusion of paths: path/to/file.ext Key: RAT-161 URL: https://issues.apache.org/jira/browse/RAT-161 Project: Apache Rat Issue Type: New Feature Components: reports Reporter: Erik Erlandson Priority: Minor Fix For: 0.11 It would be advantageous to be able to exclude specific files, e.g. path/to/file.ext The current '-E' feature cannot do this, as the filter patterns are only applied to individual files as directory tree is traversed, so a filter will never see path/to/file.ext, only path, to and file.ext See for example: SPARK-1493 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (RAT-161) Support exclusion of paths: path/to/file.ext
[ https://issues.apache.org/jira/browse/RAT-161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik Erlandson updated RAT-161: --- Attachment: (was: RAT-161.patch2) Support exclusion of paths: path/to/file.ext Key: RAT-161 URL: https://issues.apache.org/jira/browse/RAT-161 Project: Apache Rat Issue Type: New Feature Components: reports Reporter: Erik Erlandson Priority: Minor Fix For: 0.11 Attachments: RAT-161.2.patch, RAT-161.patch It would be advantageous to be able to exclude specific files, e.g. path/to/file.ext The current '-E' feature cannot do this, as the filter patterns are only applied to individual files as directory tree is traversed, so a filter will never see path/to/file.ext, only path, to and file.ext See for example: SPARK-1493 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (RAT-161) Support exclusion of paths: path/to/file.ext
[ https://issues.apache.org/jira/browse/RAT-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14045939#comment-14045939 ] Erik Erlandson commented on RAT-161: It would be helpful for Spark if I could get this (or something like it) into RAT. If there are any questions or problems with the proposal I'll be happy to try and work them out. Support exclusion of paths: path/to/file.ext Key: RAT-161 URL: https://issues.apache.org/jira/browse/RAT-161 Project: Apache Rat Issue Type: New Feature Components: reports Reporter: Erik Erlandson Priority: Minor Fix For: 0.11 Attachments: RAT-161.2.patch It would be advantageous to be able to exclude specific files, e.g. path/to/file.ext The current '-E' feature cannot do this, as the filter patterns are only applied to individual files as directory tree is traversed, so a filter will never see path/to/file.ext, only path, to and file.ext See for example: SPARK-1493 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (RAT-107) useEclipseDefaultExcludes does not ignore sub-module's eclipse dotfiles.
[ https://issues.apache.org/jira/browse/RAT-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14056170#comment-14056170 ] ASF GitHub Bot commented on RAT-107: Github user Nakomis commented on a diff in the pull request: https://github.com/apache/incubator-brooklyn/pull/49#discussion_r14706576 --- Diff: pom.xml --- @@ -678,6 +662,64 @@ /execution /executions /plugin +!-- Needed for command-line access, e.g mvn apache-rat:rat and mvn apache-rat:check -- +plugin + groupIdorg.apache.rat/groupId + artifactIdapache-rat-plugin/artifactId + version0.10/version + executions +execution + phaseverify/phase + goals +goalcheck/goal + /goals +/execution + /executions + configuration +!-- + If you wish to override this list in the component (child) pom, ensure you use + excludes combine.children=merge + so that the child pom entries replace the parent entries + -- +excludes combine.children=append + !-- git and IDE project files -- + !-- see https://issues.apache.org/jira/browse/RAT-107 -- + exclude**/.git/**/exclude + exclude**/.gitignore/exclude + exclude**/.idea/**/exclude + exclude**/*.iml/exclude + exclude**/.classpath/**/exclude + exclude**/.project/exclude + exclude**/.settings/**/exclude + exclude**/*.log/exclude + exclude**/brooklyn*.log.*/exclude + !-- files not requiring licence -- + excludeignored/**/exclude + excludeLICENSE.md/exclude + exclude**/MANIFEST.MF/exclude + exclude**/test-output/**/exclude + exclude**/*.pem.pub/exclude + exclude**/*.svg/exclude + exclude**/*.crt/exclude + exclude**/*.csr/exclude + exclude**/*.key/exclude + exclude**/*.key.org/exclude + exclude**/*.psd/exclude + exclude**/*.json/exclude --- End diff -- I excluded json as it doesn't support comments, I had a quick look at json files in jClouds (just as an example of an Apache TLP) and their json files don't include the apache header useEclipseDefaultExcludes does not ignore sub-module's eclipse dotfiles. Key: RAT-107 URL: https://issues.apache.org/jira/browse/RAT-107 Project: Apache Rat Issue Type: Bug Components: maven Affects Versions: 0.8 Environment: Maven 3.03, Java 1.6.0_29, eclipse Indigo Service release 1 Reporter: jv Labels: eclipse, maven Attachments: apache-rat-project-RAT-107.patch useEclipseDefaultExcludes works for ignoring eclipse dotfiles in the parent pom's directory, but when used in conjuction with excludeSubProjects=false, subProjects eclipse dotfiles are not ignored and I believe they should be. This can be recreated by having a maven project with integrated submodules, and setting up RAT to excludeSubProjectsfalse/excludeSubProjects and useEclipseDefaultExcludestrue/useEclipseDefaultExcludes. In the generated output file you will see the .project and .settings file/folder are not included in the check, but the submodule/.project and submodule/.settings file/folder are checked (and will presumably fail). -- This message was sent by Atlassian JIRA (v6.2#6252)
