Re: ctakes-web-rest changes [EXTERNAL]
Thanks Tim. Great work. On Friday, December 21, 2018, Miller, Timothy < timothy.mil...@childrens.harvard.edu> wrote: > There is certainly no need to apologize! It's 100x easier for me to change > an existing version that runs than to write it from scratch since I don't > really know REST that well, so thanks for contributing that code. That's > the beauty of open source teams with different expertise! > Tim > > > From: Gandhi Rajan Natarajan > Sent: Friday, December 21, 2018 3:13 AM > To: dev@ctakes.apache.org > Subject: RE: ctakes-web-rest changes [EXTERNAL] > > Hi Tim, > > Thanks for taking your time out and checking this. Have left my comments > in the JIRA issue. Sorry that I could not improvise on the REST module > which is more suitable for our business needs due to lack of domain > expertise. > > Regards, > Gandhi > > -Original Message- > From: Miller, Timothy > Sent: Friday, December 21, 2018 1:54 AM > To: dev@ctakes.apache.org > Subject: ctakes-web-rest changes > > Hello all, > I've been trying out the ctakes-web-rest module for a project that uses > python where I wanted an easy way to send a sentence and get back some CUI > annotations. There was an issue where the returned json map was keyed by > the string of the concept, so it would only return one discovered concept > if more than one had the same string. In the course of fixing that I > noticed the code was writing the CAS to xmi, then manually parsing that > file, rather than just interrogating the JCas object, so I rewrote that as > well to use uimafit. Finally, I commented out the "full" pipeline -- it is > just too resource heavy to try to run 2 independent pipelines in parallel > on the same machine. I think the state of the module right now is suitable > for people who want to try and would make their own changes if they want > different pipelines (i.e., it's not yet shrink-wrapped) so I would prefer > it in a state with a simple pipeline that runs well. > > Please take a look at the following issue with the attached patch and let > me know if there are any obvious problems. > https://urldefense.proofpoint.com/v2/url?u=https-3A__issues. > apache.org_jira_browse_CTAKES-2D529=DwIGaQ=qS4goWBT7poplM69zy_ > 3xhKwEW14JZMSdioCoppxeFU=Heup-IbsIg9Q1TPOylpP9FE4GTK- > OqdTDRRNQXipowRLRjx0ibQrHEo8uYx6674h=k-ebO4GxtYSuyXd6BYi7jXvTFAafL_ > nm1IIPeVzHdKA=yHIpAw72nyKeovPpQpuIFW1AxiENG54X5iOIKTtxtto= > > Overall, it's in nice shape and I'm excited to get it into a usable shape, > I think this is a use case that would satisfy a lot of users. > > Tim > > This email and any files transmitted with it are confidential and intended > solely for the use of the individual or entity to whom they are addressed. > If you are not the named addressee you should not disseminate, distribute > or copy this e-mail. Please notify the sender or system manager by email > immediately if you have received this e-mail by mistake and delete this > e-mail from your system. If you are not the intended recipient you are > notified that disclosing, copying, distributing or taking any action in > reliance on the contents of this information is strictly prohibited and > against the law. > -- Regards, Gandhi "The best way to find urself is to lose urself in the service of others !!!"
Re: ctakes-web-rest changes [EXTERNAL]
There is certainly no need to apologize! It's 100x easier for me to change an existing version that runs than to write it from scratch since I don't really know REST that well, so thanks for contributing that code. That's the beauty of open source teams with different expertise! Tim From: Gandhi Rajan Natarajan Sent: Friday, December 21, 2018 3:13 AM To: dev@ctakes.apache.org Subject: RE: ctakes-web-rest changes [EXTERNAL] Hi Tim, Thanks for taking your time out and checking this. Have left my comments in the JIRA issue. Sorry that I could not improvise on the REST module which is more suitable for our business needs due to lack of domain expertise. Regards, Gandhi -Original Message- From: Miller, Timothy Sent: Friday, December 21, 2018 1:54 AM To: dev@ctakes.apache.org Subject: ctakes-web-rest changes Hello all, I've been trying out the ctakes-web-rest module for a project that uses python where I wanted an easy way to send a sentence and get back some CUI annotations. There was an issue where the returned json map was keyed by the string of the concept, so it would only return one discovered concept if more than one had the same string. In the course of fixing that I noticed the code was writing the CAS to xmi, then manually parsing that file, rather than just interrogating the JCas object, so I rewrote that as well to use uimafit. Finally, I commented out the "full" pipeline -- it is just too resource heavy to try to run 2 independent pipelines in parallel on the same machine. I think the state of the module right now is suitable for people who want to try and would make their own changes if they want different pipelines (i.e., it's not yet shrink-wrapped) so I would prefer it in a state with a simple pipeline that runs well. Please take a look at the following issue with the attached patch and let me know if there are any obvious problems. https://urldefense.proofpoint.com/v2/url?u=https-3A__issues.apache.org_jira_browse_CTAKES-2D529=DwIGaQ=qS4goWBT7poplM69zy_3xhKwEW14JZMSdioCoppxeFU=Heup-IbsIg9Q1TPOylpP9FE4GTK-OqdTDRRNQXipowRLRjx0ibQrHEo8uYx6674h=k-ebO4GxtYSuyXd6BYi7jXvTFAafL_nm1IIPeVzHdKA=yHIpAw72nyKeovPpQpuIFW1AxiENG54X5iOIKTtxtto= Overall, it's in nice shape and I'm excited to get it into a usable shape, I think this is a use case that would satisfy a lot of users. Tim This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you are not the named addressee you should not disseminate, distribute or copy this e-mail. Please notify the sender or system manager by email immediately if you have received this e-mail by mistake and delete this e-mail from your system. If you are not the intended recipient you are notified that disclosing, copying, distributing or taking any action in reliance on the contents of this information is strictly prohibited and against the law.
RE: ctakes-web-rest changes
Hi Tim, Thanks for taking your time out and checking this. Have left my comments in the JIRA issue. Sorry that I could not improvise on the REST module which is more suitable for our business needs due to lack of domain expertise. Regards, Gandhi -Original Message- From: Miller, Timothy Sent: Friday, December 21, 2018 1:54 AM To: dev@ctakes.apache.org Subject: ctakes-web-rest changes Hello all, I've been trying out the ctakes-web-rest module for a project that uses python where I wanted an easy way to send a sentence and get back some CUI annotations. There was an issue where the returned json map was keyed by the string of the concept, so it would only return one discovered concept if more than one had the same string. In the course of fixing that I noticed the code was writing the CAS to xmi, then manually parsing that file, rather than just interrogating the JCas object, so I rewrote that as well to use uimafit. Finally, I commented out the "full" pipeline -- it is just too resource heavy to try to run 2 independent pipelines in parallel on the same machine. I think the state of the module right now is suitable for people who want to try and would make their own changes if they want different pipelines (i.e., it's not yet shrink-wrapped) so I would prefer it in a state with a simple pipeline that runs well. Please take a look at the following issue with the attached patch and let me know if there are any obvious problems. https://issues.apache.org/jira/browse/CTAKES-529 Overall, it's in nice shape and I'm excited to get it into a usable shape, I think this is a use case that would satisfy a lot of users. Tim This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you are not the named addressee you should not disseminate, distribute or copy this e-mail. Please notify the sender or system manager by email immediately if you have received this e-mail by mistake and delete this e-mail from your system. If you are not the intended recipient you are notified that disclosing, copying, distributing or taking any action in reliance on the contents of this information is strictly prohibited and against the law.
