[GitHub] [curator] tisonkun commented on pull request #313: Build on jdk Set release target to 8 for jdk11 compiler
tisonkun commented on PR #313: URL: https://github.com/apache/curator/pull/313#issuecomment-1238178504 We already build for JDK8 and JDK11 on master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@curator.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [curator] tisonkun closed pull request #313: Build on jdk Set release target to 8 for jdk11 compiler
tisonkun closed pull request #313: Build on jdk Set release target to 8 for jdk11 compiler URL: https://github.com/apache/curator/pull/313 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@curator.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [curator] tisonkun closed pull request #243: [Fix] Curator-444
tisonkun closed pull request #243: [Fix] Curator-444 URL: https://github.com/apache/curator/pull/243 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@curator.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [curator] tisonkun commented on pull request #243: [Fix] Curator-444
tisonkun commented on PR #243: URL: https://github.com/apache/curator/pull/243#issuecomment-1238169978 Closed as stale. There're many changes since this patch was made in the first place. Feel free to resubmit it if it's still relevant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@curator.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (CURATOR-373) Add option to PersistentNode to not overwrite/delete existing node
[ https://issues.apache.org/jira/browse/CURATOR-373?focusedWorklogId=806378&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-806378 ] ASF GitHub Bot logged work on CURATOR-373: -- Author: ASF GitHub Bot Created on: 06/Sep/22 13:40 Start Date: 06/Sep/22 13:40 Worklog Time Spent: 10m Work Description: tisonkun closed pull request #182: CURATOR-373 Add option to PersistentNode to not overwrite/delete existing node URL: https://github.com/apache/curator/pull/182 Issue Time Tracking --- Worklog Id: (was: 806378) Time Spent: 20m (was: 10m) > Add option to PersistentNode to not overwrite/delete existing node > -- > > Key: CURATOR-373 > URL: https://issues.apache.org/jira/browse/CURATOR-373 > Project: Apache Curator > Issue Type: Wish > Components: Recipes >Reporter: Péter Lakos >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Currently, when PersistentNode.start() is called, and a node at the specified > path already exists, this existing node's data is overwritten with the > PersistentNode's data. > Similarly, when PersistentNode.close() is called, the node is deleted, even > if a node existed at the specified path before PersistentNode.start() was > called. > Add an option to PersistentNode to not overwrite/delete an existing node. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (CURATOR-379) unfixForNamespace corrupts child path when it contains namespace
[
https://issues.apache.org/jira/browse/CURATOR-379?focusedWorklogId=806379&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-806379
]
ASF GitHub Bot logged work on CURATOR-379:
--
Author: ASF GitHub Bot
Created on: 06/Sep/22 13:40
Start Date: 06/Sep/22 13:40
Worklog Time Spent: 10m
Work Description: tisonkun closed pull request #194: [CURATOR-379]
unfixForNamespace corrupts child path when it contains namespace
URL: https://github.com/apache/curator/pull/194
Issue Time Tracking
---
Worklog Id: (was: 806379)
Remaining Estimate: 0h
Time Spent: 10m
> unfixForNamespace corrupts child path when it contains namespace
>
>
> Key: CURATOR-379
> URL: https://issues.apache.org/jira/browse/CURATOR-379
> Project: Apache Curator
> Issue Type: Bug
> Components: Framework
>Affects Versions: 2.11.1
>Reporter: Marvin Bredal Lillehaug
>Priority: Minor
> Fix For: awaiting-response
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When a child path starts with the namespace unfixForNamespace removes the
> namespace string, thus creating a invalid path.
> With namespace "foo" the result of unfixForNamespace("/foobar") is "bar".
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (CURATOR-373) Add option to PersistentNode to not overwrite/delete existing node
[ https://issues.apache.org/jira/browse/CURATOR-373?focusedWorklogId=806377&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-806377 ] ASF GitHub Bot logged work on CURATOR-373: -- Author: ASF GitHub Bot Created on: 06/Sep/22 13:40 Start Date: 06/Sep/22 13:40 Worklog Time Spent: 10m Work Description: tisonkun commented on PR #182: URL: https://github.com/apache/curator/pull/182#issuecomment-1238167670 Closed as stale. There're many changes since this patch was made in the first place. Feel free to resubmit it if it's still relevant. Issue Time Tracking --- Worklog Id: (was: 806377) Remaining Estimate: 0h Time Spent: 10m > Add option to PersistentNode to not overwrite/delete existing node > -- > > Key: CURATOR-373 > URL: https://issues.apache.org/jira/browse/CURATOR-373 > Project: Apache Curator > Issue Type: Wish > Components: Recipes >Reporter: Péter Lakos >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Currently, when PersistentNode.start() is called, and a node at the specified > path already exists, this existing node's data is overwritten with the > PersistentNode's data. > Similarly, when PersistentNode.close() is called, the node is deleted, even > if a node existed at the specified path before PersistentNode.start() was > called. > Add an option to PersistentNode to not overwrite/delete an existing node. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (CURATOR-379) unfixForNamespace corrupts child path when it contains namespace
[
https://issues.apache.org/jira/browse/CURATOR-379?focusedWorklogId=806380&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-806380
]
ASF GitHub Bot logged work on CURATOR-379:
--
Author: ASF GitHub Bot
Created on: 06/Sep/22 13:40
Start Date: 06/Sep/22 13:40
Worklog Time Spent: 10m
Work Description: tisonkun commented on PR #194:
URL: https://github.com/apache/curator/pull/194#issuecomment-1238167997
Closed as stale. There're many changes since this patch was made in the
first place. Feel free to resubmit it if it's still relevant.
Issue Time Tracking
---
Worklog Id: (was: 806380)
Time Spent: 20m (was: 10m)
> unfixForNamespace corrupts child path when it contains namespace
>
>
> Key: CURATOR-379
> URL: https://issues.apache.org/jira/browse/CURATOR-379
> Project: Apache Curator
> Issue Type: Bug
> Components: Framework
>Affects Versions: 2.11.1
>Reporter: Marvin Bredal Lillehaug
>Priority: Minor
> Fix For: awaiting-response
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When a child path starts with the namespace unfixForNamespace removes the
> namespace string, thus creating a invalid path.
> With namespace "foo" the result of unfixForNamespace("/foobar") is "bar".
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [curator] tisonkun commented on pull request #194: [CURATOR-379] unfixForNamespace corrupts child path when it contains namespace
tisonkun commented on PR #194: URL: https://github.com/apache/curator/pull/194#issuecomment-1238167997 Closed as stale. There're many changes since this patch was made in the first place. Feel free to resubmit it if it's still relevant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@curator.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [curator] tisonkun closed pull request #194: [CURATOR-379] unfixForNamespace corrupts child path when it contains namespace
tisonkun closed pull request #194: [CURATOR-379] unfixForNamespace corrupts child path when it contains namespace URL: https://github.com/apache/curator/pull/194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@curator.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [curator] tisonkun commented on pull request #182: CURATOR-373 Add option to PersistentNode to not overwrite/delete existing node
tisonkun commented on PR #182: URL: https://github.com/apache/curator/pull/182#issuecomment-1238167670 Closed as stale. There're many changes since this patch was made in the first place. Feel free to resubmit it if it's still relevant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@curator.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [curator] tisonkun closed pull request #182: CURATOR-373 Add option to PersistentNode to not overwrite/delete existing node
tisonkun closed pull request #182: CURATOR-373 Add option to PersistentNode to not overwrite/delete existing node URL: https://github.com/apache/curator/pull/182 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@curator.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (CURATOR-314) Listenable support for GroupMember recipe
[ https://issues.apache.org/jira/browse/CURATOR-314?focusedWorklogId=806375&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-806375 ] ASF GitHub Bot logged work on CURATOR-314: -- Author: ASF GitHub Bot Created on: 06/Sep/22 13:39 Start Date: 06/Sep/22 13:39 Worklog Time Spent: 10m Work Description: tisonkun commented on PR #141: URL: https://github.com/apache/curator/pull/141#issuecomment-1238167114 Closed as stale. There're many changes since this patch was made in the first place. Feel free to resubmit it if it's still relevant. Issue Time Tracking --- Worklog Id: (was: 806375) Remaining Estimate: 0h Time Spent: 10m > Listenable support for GroupMember recipe > - > > Key: CURATOR-314 > URL: https://issues.apache.org/jira/browse/CURATOR-314 > Project: Apache Curator > Issue Type: Improvement > Components: Recipes >Reporter: Shivram Khandeparker >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > The GroupMember recipe currently doesn't provide any membership change > events. I wanted this feature in my project and I've implemented it by making > a copy of GroupMember in my project and adding the necessary classes and > interfaces. I wanted to contribute this back to curator -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (CURATOR-314) Listenable support for GroupMember recipe
[ https://issues.apache.org/jira/browse/CURATOR-314?focusedWorklogId=806376&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-806376 ] ASF GitHub Bot logged work on CURATOR-314: -- Author: ASF GitHub Bot Created on: 06/Sep/22 13:39 Start Date: 06/Sep/22 13:39 Worklog Time Spent: 10m Work Description: tisonkun closed pull request #141: [CURATOR-314] Listenable support for GroupMember recipe URL: https://github.com/apache/curator/pull/141 Issue Time Tracking --- Worklog Id: (was: 806376) Time Spent: 20m (was: 10m) > Listenable support for GroupMember recipe > - > > Key: CURATOR-314 > URL: https://issues.apache.org/jira/browse/CURATOR-314 > Project: Apache Curator > Issue Type: Improvement > Components: Recipes >Reporter: Shivram Khandeparker >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > The GroupMember recipe currently doesn't provide any membership change > events. I wanted this feature in my project and I've implemented it by making > a copy of GroupMember in my project and adding the necessary classes and > interfaces. I wanted to contribute this back to curator -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [curator] tisonkun closed pull request #141: [CURATOR-314] Listenable support for GroupMember recipe
tisonkun closed pull request #141: [CURATOR-314] Listenable support for GroupMember recipe URL: https://github.com/apache/curator/pull/141 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@curator.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [curator] tisonkun commented on pull request #141: [CURATOR-314] Listenable support for GroupMember recipe
tisonkun commented on PR #141: URL: https://github.com/apache/curator/pull/141#issuecomment-1238167114 Closed as stale. There're many changes since this patch was made in the first place. Feel free to resubmit it if it's still relevant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@curator.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (CURATOR-265) Dynamic Reconfig APIs needs some work and more accurate testing
[ https://issues.apache.org/jira/browse/CURATOR-265?focusedWorklogId=806373&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-806373 ] ASF GitHub Bot logged work on CURATOR-265: -- Author: ASF GitHub Bot Created on: 06/Sep/22 13:35 Start Date: 06/Sep/22 13:35 Worklog Time Spent: 10m Work Description: tisonkun closed pull request #112: [CURATOR-265] Make sure EnsembleTracker only notifies listeners when … URL: https://github.com/apache/curator/pull/112 Issue Time Tracking --- Worklog Id: (was: 806373) Time Spent: 20m (was: 10m) > Dynamic Reconfig APIs needs some work and more accurate testing > --- > > Key: CURATOR-265 > URL: https://issues.apache.org/jira/browse/CURATOR-265 > Project: Apache Curator > Issue Type: Sub-task > Components: Recipes >Affects Versions: 3.0.0 >Reporter: Jordan Zimmerman >Assignee: Jordan Zimmerman >Priority: Major > Fix For: 3.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > The new dynamic reconfig APIs don't have all permutations and the tests are > flakey. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (CURATOR-265) Dynamic Reconfig APIs needs some work and more accurate testing
[ https://issues.apache.org/jira/browse/CURATOR-265?focusedWorklogId=806372&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-806372 ] ASF GitHub Bot logged work on CURATOR-265: -- Author: ASF GitHub Bot Created on: 06/Sep/22 13:35 Start Date: 06/Sep/22 13:35 Worklog Time Spent: 10m Work Description: tisonkun commented on PR #112: URL: https://github.com/apache/curator/pull/112#issuecomment-1238161002 Closed as stale. There're many changes since this patch was made in the first place. Feel free to resubmit it if it's still relevant. Issue Time Tracking --- Worklog Id: (was: 806372) Remaining Estimate: 0h Time Spent: 10m > Dynamic Reconfig APIs needs some work and more accurate testing > --- > > Key: CURATOR-265 > URL: https://issues.apache.org/jira/browse/CURATOR-265 > Project: Apache Curator > Issue Type: Sub-task > Components: Recipes >Affects Versions: 3.0.0 >Reporter: Jordan Zimmerman >Assignee: Jordan Zimmerman >Priority: Major > Fix For: 3.0.0 > > Time Spent: 10m > Remaining Estimate: 0h > > The new dynamic reconfig APIs don't have all permutations and the tests are > flakey. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [curator] tisonkun closed pull request #112: [CURATOR-265] Make sure EnsembleTracker only notifies listeners when …
tisonkun closed pull request #112: [CURATOR-265] Make sure EnsembleTracker only notifies listeners when … URL: https://github.com/apache/curator/pull/112 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@curator.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [curator] tisonkun commented on pull request #112: [CURATOR-265] Make sure EnsembleTracker only notifies listeners when …
tisonkun commented on PR #112: URL: https://github.com/apache/curator/pull/112#issuecomment-1238161002 Closed as stale. There're many changes since this patch was made in the first place. Feel free to resubmit it if it's still relevant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@curator.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (CURATOR-232) Consolidate test code
[
https://issues.apache.org/jira/browse/CURATOR-232?focusedWorklogId=806371&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-806371
]
ASF GitHub Bot logged work on CURATOR-232:
--
Author: ASF GitHub Bot
Created on: 06/Sep/22 13:34
Start Date: 06/Sep/22 13:34
Worklog Time Spent: 10m
Work Description: tisonkun closed pull request #89: CURATOR-232
Consolidate Timing and Client
URL: https://github.com/apache/curator/pull/89
Issue Time Tracking
---
Worklog Id: (was: 806371)
Time Spent: 20m (was: 10m)
> Consolidate test code
> -
>
> Key: CURATOR-232
> URL: https://issues.apache.org/jira/browse/CURATOR-232
> Project: Apache Curator
> Issue Type: Improvement
> Components: Tests
>Reporter: Mike Drob
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Writing additional tests for Curator can be fairly intimidating to new users,
> and it looks like things just get copy and pasted a lot. We can consolidate a
> lot of test code, starting with how we expose {{Timing}} and
> {{CuratorFramework}} objects. This is a probably going to be a longer term
> effort with several JIRAs, so I'm not concerned with this one issue covering
> absolutely everything, I just want to make new tests easier to write.
> One easy route is to make heavier use of annotations, like the
> {{@BeforeMethod}} and {{@AfterMethod}} instead of {{try/finally}} when making
> sure resources are cleaned up.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (CURATOR-232) Consolidate test code
[
https://issues.apache.org/jira/browse/CURATOR-232?focusedWorklogId=806370&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-806370
]
ASF GitHub Bot logged work on CURATOR-232:
--
Author: ASF GitHub Bot
Created on: 06/Sep/22 13:34
Start Date: 06/Sep/22 13:34
Worklog Time Spent: 10m
Work Description: tisonkun commented on PR #89:
URL: https://github.com/apache/curator/pull/89#issuecomment-1238160442
Closed as stale. There're many changes since this patch was made in the
first place. Feel free to resubmit it if it's still relevant.
Issue Time Tracking
---
Worklog Id: (was: 806370)
Remaining Estimate: 0h
Time Spent: 10m
> Consolidate test code
> -
>
> Key: CURATOR-232
> URL: https://issues.apache.org/jira/browse/CURATOR-232
> Project: Apache Curator
> Issue Type: Improvement
> Components: Tests
>Reporter: Mike Drob
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Writing additional tests for Curator can be fairly intimidating to new users,
> and it looks like things just get copy and pasted a lot. We can consolidate a
> lot of test code, starting with how we expose {{Timing}} and
> {{CuratorFramework}} objects. This is a probably going to be a longer term
> effort with several JIRAs, so I'm not concerned with this one issue covering
> absolutely everything, I just want to make new tests easier to write.
> One easy route is to make heavier use of annotations, like the
> {{@BeforeMethod}} and {{@AfterMethod}} instead of {{try/finally}} when making
> sure resources are cleaned up.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [curator] tisonkun commented on pull request #89: CURATOR-232 Consolidate Timing and Client
tisonkun commented on PR #89: URL: https://github.com/apache/curator/pull/89#issuecomment-1238160442 Closed as stale. There're many changes since this patch was made in the first place. Feel free to resubmit it if it's still relevant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@curator.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [curator] tisonkun closed pull request #89: CURATOR-232 Consolidate Timing and Client
tisonkun closed pull request #89: CURATOR-232 Consolidate Timing and Client URL: https://github.com/apache/curator/pull/89 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@curator.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (CURATOR-235) LeaderSelector.internalRequeue should be private
[ https://issues.apache.org/jira/browse/CURATOR-235?focusedWorklogId=806368&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-806368 ] ASF GitHub Bot logged work on CURATOR-235: -- Author: ASF GitHub Bot Created on: 06/Sep/22 13:32 Start Date: 06/Sep/22 13:32 Worklog Time Spent: 10m Work Description: tisonkun commented on PR #87: URL: https://github.com/apache/curator/pull/87#issuecomment-1238157507 This is on the master https://github.com/apache/curator/commit/0bec8a066f8a4b5d26ef3621800543a54b46ac3e. But it's from another author. Sorry that we don't handle this PR in time >_< Issue Time Tracking --- Worklog Id: (was: 806368) Remaining Estimate: 0h Time Spent: 10m > LeaderSelector.internalRequeue should be private > > > Key: CURATOR-235 > URL: https://issues.apache.org/jira/browse/CURATOR-235 > Project: Apache Curator > Issue Type: Bug > Components: Recipes >Affects Versions: 2.8.0 >Reporter: Nandor Kracser >Assignee: Jordan Zimmerman >Priority: Minor > Fix For: 2.9.0 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (CURATOR-235) LeaderSelector.internalRequeue should be private
[ https://issues.apache.org/jira/browse/CURATOR-235?focusedWorklogId=806369&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-806369 ] ASF GitHub Bot logged work on CURATOR-235: -- Author: ASF GitHub Bot Created on: 06/Sep/22 13:32 Start Date: 06/Sep/22 13:32 Worklog Time Spent: 10m Work Description: tisonkun closed pull request #87: CURATOR-235 LeaderSelector.internalRequeue should be private URL: https://github.com/apache/curator/pull/87 Issue Time Tracking --- Worklog Id: (was: 806369) Time Spent: 20m (was: 10m) > LeaderSelector.internalRequeue should be private > > > Key: CURATOR-235 > URL: https://issues.apache.org/jira/browse/CURATOR-235 > Project: Apache Curator > Issue Type: Bug > Components: Recipes >Affects Versions: 2.8.0 >Reporter: Nandor Kracser >Assignee: Jordan Zimmerman >Priority: Minor > Fix For: 2.9.0 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [curator] tisonkun closed pull request #87: CURATOR-235 LeaderSelector.internalRequeue should be private
tisonkun closed pull request #87: CURATOR-235 LeaderSelector.internalRequeue should be private URL: https://github.com/apache/curator/pull/87 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@curator.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [curator] tisonkun commented on pull request #87: CURATOR-235 LeaderSelector.internalRequeue should be private
tisonkun commented on PR #87: URL: https://github.com/apache/curator/pull/87#issuecomment-1238157507 This is on the master https://github.com/apache/curator/commit/0bec8a066f8a4b5d26ef3621800543a54b46ac3e. But it's from another author. Sorry that we don't handle this PR in time >_< -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@curator.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [curator] tisonkun closed pull request #74: LeaderSelector mutex resurrection
tisonkun closed pull request #74: LeaderSelector mutex resurrection URL: https://github.com/apache/curator/pull/74 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@curator.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [curator] tisonkun commented on pull request #74: LeaderSelector mutex resurrection
tisonkun commented on PR #74: URL: https://github.com/apache/curator/pull/74#issuecomment-1238151301 Closed as stale. There're many changes since this patch was made in the first place. Feel free to resubmit it if it's still relevant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@curator.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (CURATOR-157) Avoid stack traces closing PathChildrenCache followed by closing CuratorFramework
[
https://issues.apache.org/jira/browse/CURATOR-157?focusedWorklogId=806362&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-806362
]
ASF GitHub Bot logged work on CURATOR-157:
--
Author: ASF GitHub Bot
Created on: 06/Sep/22 13:26
Start Date: 06/Sep/22 13:26
Worklog Time Spent: 10m
Work Description: tisonkun closed pull request #51: CURATOR-157 Avoid
stack traces on close
URL: https://github.com/apache/curator/pull/51
Issue Time Tracking
---
Worklog Id: (was: 806362)
Time Spent: 50m (was: 40m)
> Avoid stack traces closing PathChildrenCache followed by closing
> CuratorFramework
> -
>
> Key: CURATOR-157
> URL: https://issues.apache.org/jira/browse/CURATOR-157
> Project: Apache Curator
> Issue Type: Improvement
>Reporter: Bruno Dumon
>Assignee: Jordan Zimmerman
>Priority: Major
> Attachments: LogProblemIllustration.java
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> When closing PathChildrenCache, and immediately afterwards closing
> CuratorFramework, some ERROR-level stack traces are logged.
> This was previously reported on the mailing list:
> http://curator.markmail.org/thread/bmfr62ekx5p2vv7f
> The cause is that the BackgroundCallback defined in
> PathChildrenCache.refresh() will, when triggered, perform some more ZooKeeper
> operations.
> Thus one can get in sequences such as:
> * operation with BackgroundCallback is submitted
> * processResult of the BackgroundCallback is called
> * PathChildrenCache is closed
> * CuratorFramework is closed
> * processResult, which is running on another thread, comes to the point it
> does operations on ZooKeeper, which fail because ZooKeeper is closed.
> There is no real impact on the application, it is just for log-esthetical
> reasons that I'd like to avoid it.
> In the more common case, the processResult will receive an
> IllegalStateException, which could be easily catched and ignored in
> PathChildrenCache if the PathChildrenCache is closed:
> {noformat}
> 14/10/30 11:24:51 ERROR
> org.apache.curator.framework.imps.CuratorFrameworkImpl: Background exception
> was not retry-able or retry gave up
> java.lang.IllegalStateException: instance must be started before calling this
> method
> at
> com.google.common.base.Preconditions.checkState(Preconditions.java:149)
> at
> org.apache.curator.framework.imps.CuratorFrameworkImpl.getData(CuratorFrameworkImpl.java:360)
> at
> org.apache.curator.framework.recipes.cache.PathChildrenCache.getDataAndStat(PathChildrenCache.java:545)
> at
> org.apache.curator.framework.recipes.cache.PathChildrenCache.processChildren(PathChildrenCache.java:668)
> at
> org.apache.curator.framework.recipes.cache.PathChildrenCache.access$200(PathChildrenCache.java:68)
> at
> org.apache.curator.framework.recipes.cache.PathChildrenCache$4.processResult(PathChildrenCache.java:490)
> at
> org.apache.curator.framework.imps.CuratorFrameworkImpl.sendToBackgroundCallback(CuratorFrameworkImpl.java:715)
> at
> org.apache.curator.framework.imps.CuratorFrameworkImpl.processBackgroundOperation(CuratorFrameworkImpl.java:502)
> at
> org.apache.curator.framework.imps.GetChildrenBuilderImpl$2.processResult(GetChildrenBuilderImpl.java:166)
> at
> org.apache.zookeeper.ClientCnxn$EventThread.processEvent(ClientCnxn.java:590)
> at org.apache.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:498)
> {noformat}
> But sometimes it also fails with other async operations deeper down:
> {noformat}
> 14/10/30 11:24:51 ERROR
> org.apache.curator.framework.imps.CuratorFrameworkImpl: Background exception
> was not retry-able or retry gave up
> java.lang.IllegalStateException: Client is not started
> at
> com.google.common.base.Preconditions.checkState(Preconditions.java:149)
> at
> org.apache.curator.CuratorZookeeperClient.getZooKeeper(CuratorZookeeperClient.java:113)
> at
> org.apache.curator.framework.imps.CuratorFrameworkImpl.getZooKeeper(CuratorFrameworkImpl.java:474)
> at
> org.apache.curator.framework.imps.GetDataBuilderImpl.performBackgroundOperation(GetDataBuilderImpl.java:263)
> at
> org.apache.curator.framework.imps.OperationAndData.callPerformBackgroundOperation(OperationAndData.java:65)
> at
> org.apache.curator.framework.imps.CuratorFrameworkImpl.performBackgroundOperation(CuratorFrameworkImpl.java:789)
> at
> org.apache.curator.framework.imps.CuratorFrameworkImpl.processBackgroundOperation(CuratorFrameworkImpl.java:487)
> at
> org.apache.curator.framework.imps.GetDataBuilderImpl.forPath(GetDataBuilderImpl.java:275)
> at
> org.apache.curator.framework.imps.GetDa
[jira] [Work logged] (CURATOR-157) Avoid stack traces closing PathChildrenCache followed by closing CuratorFramework
[
https://issues.apache.org/jira/browse/CURATOR-157?focusedWorklogId=806361&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-806361
]
ASF GitHub Bot logged work on CURATOR-157:
--
Author: ASF GitHub Bot
Created on: 06/Sep/22 13:26
Start Date: 06/Sep/22 13:26
Worklog Time Spent: 10m
Work Description: tisonkun commented on PR #51:
URL: https://github.com/apache/curator/pull/51#issuecomment-1238150761
Closed as stale. There're many changes since this patch was made in the
first place. Feel free to resubmit it if it's still relevant.
BTW, `NodeCache` and `PathChildrenCache` are deprecated now, you can use
`CuratorCache` instead to see if this is still an issue.
Issue Time Tracking
---
Worklog Id: (was: 806361)
Time Spent: 40m (was: 0.5h)
> Avoid stack traces closing PathChildrenCache followed by closing
> CuratorFramework
> -
>
> Key: CURATOR-157
> URL: https://issues.apache.org/jira/browse/CURATOR-157
> Project: Apache Curator
> Issue Type: Improvement
>Reporter: Bruno Dumon
>Assignee: Jordan Zimmerman
>Priority: Major
> Attachments: LogProblemIllustration.java
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> When closing PathChildrenCache, and immediately afterwards closing
> CuratorFramework, some ERROR-level stack traces are logged.
> This was previously reported on the mailing list:
> http://curator.markmail.org/thread/bmfr62ekx5p2vv7f
> The cause is that the BackgroundCallback defined in
> PathChildrenCache.refresh() will, when triggered, perform some more ZooKeeper
> operations.
> Thus one can get in sequences such as:
> * operation with BackgroundCallback is submitted
> * processResult of the BackgroundCallback is called
> * PathChildrenCache is closed
> * CuratorFramework is closed
> * processResult, which is running on another thread, comes to the point it
> does operations on ZooKeeper, which fail because ZooKeeper is closed.
> There is no real impact on the application, it is just for log-esthetical
> reasons that I'd like to avoid it.
> In the more common case, the processResult will receive an
> IllegalStateException, which could be easily catched and ignored in
> PathChildrenCache if the PathChildrenCache is closed:
> {noformat}
> 14/10/30 11:24:51 ERROR
> org.apache.curator.framework.imps.CuratorFrameworkImpl: Background exception
> was not retry-able or retry gave up
> java.lang.IllegalStateException: instance must be started before calling this
> method
> at
> com.google.common.base.Preconditions.checkState(Preconditions.java:149)
> at
> org.apache.curator.framework.imps.CuratorFrameworkImpl.getData(CuratorFrameworkImpl.java:360)
> at
> org.apache.curator.framework.recipes.cache.PathChildrenCache.getDataAndStat(PathChildrenCache.java:545)
> at
> org.apache.curator.framework.recipes.cache.PathChildrenCache.processChildren(PathChildrenCache.java:668)
> at
> org.apache.curator.framework.recipes.cache.PathChildrenCache.access$200(PathChildrenCache.java:68)
> at
> org.apache.curator.framework.recipes.cache.PathChildrenCache$4.processResult(PathChildrenCache.java:490)
> at
> org.apache.curator.framework.imps.CuratorFrameworkImpl.sendToBackgroundCallback(CuratorFrameworkImpl.java:715)
> at
> org.apache.curator.framework.imps.CuratorFrameworkImpl.processBackgroundOperation(CuratorFrameworkImpl.java:502)
> at
> org.apache.curator.framework.imps.GetChildrenBuilderImpl$2.processResult(GetChildrenBuilderImpl.java:166)
> at
> org.apache.zookeeper.ClientCnxn$EventThread.processEvent(ClientCnxn.java:590)
> at org.apache.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:498)
> {noformat}
> But sometimes it also fails with other async operations deeper down:
> {noformat}
> 14/10/30 11:24:51 ERROR
> org.apache.curator.framework.imps.CuratorFrameworkImpl: Background exception
> was not retry-able or retry gave up
> java.lang.IllegalStateException: Client is not started
> at
> com.google.common.base.Preconditions.checkState(Preconditions.java:149)
> at
> org.apache.curator.CuratorZookeeperClient.getZooKeeper(CuratorZookeeperClient.java:113)
> at
> org.apache.curator.framework.imps.CuratorFrameworkImpl.getZooKeeper(CuratorFrameworkImpl.java:474)
> at
> org.apache.curator.framework.imps.GetDataBuilderImpl.performBackgroundOperation(GetDataBuilderImpl.java:263)
> at
> org.apache.curator.framework.imps.OperationAndData.callPerformBackgroundOperation(OperationAndData.java:65)
> at
> org.apache.curator.framework.imps.CuratorFrameworkImpl.performBackgroundOperation(CuratorFrameworkImpl.java:789)
> at
> org.apache.cu
[GitHub] [curator] tisonkun closed pull request #51: CURATOR-157 Avoid stack traces on close
tisonkun closed pull request #51: CURATOR-157 Avoid stack traces on close URL: https://github.com/apache/curator/pull/51 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@curator.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [curator] tisonkun commented on pull request #51: CURATOR-157 Avoid stack traces on close
tisonkun commented on PR #51: URL: https://github.com/apache/curator/pull/51#issuecomment-1238150761 Closed as stale. There're many changes since this patch was made in the first place. Feel free to resubmit it if it's still relevant. BTW, `NodeCache` and `PathChildrenCache` are deprecated now, you can use `CuratorCache` instead to see if this is still an issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@curator.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [curator] tisonkun closed pull request #99: CURATOR-233 Fix DistributedDoubleBarrier::leave
tisonkun closed pull request #99: CURATOR-233 Fix DistributedDoubleBarrier::leave URL: https://github.com/apache/curator/pull/99 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@curator.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [curator] tisonkun commented on pull request #99: CURATOR-233 Fix DistributedDoubleBarrier::leave
tisonkun commented on PR #99: URL: https://github.com/apache/curator/pull/99#issuecomment-1238149186 Closed as stale. There're many changes since this patch was made in the first place. Feel free to resubmit it if it's still relevant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@curator.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [curator] tisonkun commented on pull request #10: initial BasicAuthExhibitorRestClient
tisonkun commented on PR #10: URL: https://github.com/apache/curator/pull/10#issuecomment-1238148859 Closed as stale. There're many changes since this patch was made in the first place. Feel free to resubmit it if it's still relevant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@curator.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [curator] tisonkun closed pull request #10: initial BasicAuthExhibitorRestClient
tisonkun closed pull request #10: initial BasicAuthExhibitorRestClient URL: https://github.com/apache/curator/pull/10 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@curator.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [curator] tisonkun commented on pull request #2: Curator 94
tisonkun commented on PR #2: URL: https://github.com/apache/curator/pull/2#issuecomment-1238148360 Closed as stale. There're many changes since this patch was made in the first place. Feel free to resubmit it if it's still relevant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@curator.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [curator] tisonkun closed pull request #2: Curator 94
tisonkun closed pull request #2: Curator 94 URL: https://github.com/apache/curator/pull/2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@curator.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (CURATOR-565) checkExists didn't check useContainerParentsIfAvailable flag
[ https://issues.apache.org/jira/browse/CURATOR-565?focusedWorklogId=806359&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-806359 ] ASF GitHub Bot logged work on CURATOR-565: -- Author: ASF GitHub Bot Created on: 06/Sep/22 13:23 Start Date: 06/Sep/22 13:23 Worklog Time Spent: 10m Work Description: tisonkun closed pull request #354: [CURATOR-565] check useContainerParentsIfAvailable for ExistsBuilderImpl. URL: https://github.com/apache/curator/pull/354 Issue Time Tracking --- Worklog Id: (was: 806359) Time Spent: 1.5h (was: 1h 20m) > checkExists didn't check useContainerParentsIfAvailable flag > > > Key: CURATOR-565 > URL: https://issues.apache.org/jira/browse/CURATOR-565 > Project: Apache Curator > Issue Type: Bug > Components: Framework >Affects Versions: 4.3.0 >Reporter: Tianzhou Wang >Priority: Critical > Time Spent: 1.5h > Remaining Estimate: 0h > > When use zookeeper server 3.4.x with 3.5.x client. > when use checkExists().creatingParentContainersIfNeeded() would lead > Unimplemented Exception even dontUseContainerParents() was called for > CuratorFrameworkFactory.builder(). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (CURATOR-565) checkExists didn't check useContainerParentsIfAvailable flag
[ https://issues.apache.org/jira/browse/CURATOR-565?focusedWorklogId=806358&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-806358 ] ASF GitHub Bot logged work on CURATOR-565: -- Author: ASF GitHub Bot Created on: 06/Sep/22 13:23 Start Date: 06/Sep/22 13:23 Worklog Time Spent: 10m Work Description: tisonkun commented on PR #354: URL: https://github.com/apache/curator/pull/354#issuecomment-1238147029 Closed as stale. Feel free to resubmit it if you're still willing to proceed. Issue Time Tracking --- Worklog Id: (was: 806358) Time Spent: 1h 20m (was: 1h 10m) > checkExists didn't check useContainerParentsIfAvailable flag > > > Key: CURATOR-565 > URL: https://issues.apache.org/jira/browse/CURATOR-565 > Project: Apache Curator > Issue Type: Bug > Components: Framework >Affects Versions: 4.3.0 >Reporter: Tianzhou Wang >Priority: Critical > Time Spent: 1h 20m > Remaining Estimate: 0h > > When use zookeeper server 3.4.x with 3.5.x client. > when use checkExists().creatingParentContainersIfNeeded() would lead > Unimplemented Exception even dontUseContainerParents() was called for > CuratorFrameworkFactory.builder(). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [curator] tisonkun closed pull request #354: [CURATOR-565] check useContainerParentsIfAvailable for ExistsBuilderImpl.
tisonkun closed pull request #354: [CURATOR-565] check useContainerParentsIfAvailable for ExistsBuilderImpl. URL: https://github.com/apache/curator/pull/354 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@curator.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [curator] tisonkun commented on pull request #354: [CURATOR-565] check useContainerParentsIfAvailable for ExistsBuilderImpl.
tisonkun commented on PR #354: URL: https://github.com/apache/curator/pull/354#issuecomment-1238147029 Closed as stale. Feel free to resubmit it if you're still willing to proceed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@curator.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
