[GitHub] [curator] tisonkun commented on pull request #430: CURATOR-644. CURATOR-645. Fix livelock in LeaderLatch
tisonkun commented on PR #430: URL: https://github.com/apache/curator/pull/430#issuecomment-1258904417 Merging... I'm looking into a related change #398 and then prepare the next release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@curator.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [curator] tisonkun commented on pull request #430: CURATOR-644. CURATOR-645. Fix livelock in LeaderLatch
tisonkun commented on PR #430: URL: https://github.com/apache/curator/pull/430#issuecomment-1253118096 @eolivelli @cammckenzie @Randgalt Perhaps we can release a 5.4.0 later this month and I'd ask for a review on this patch for a consensus whether we include it or only the debug logging part. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@curator.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [curator] tisonkun commented on pull request #430: CURATOR-644. CURATOR-645. Fix livelock in LeaderLatch
tisonkun commented on PR #430: URL: https://github.com/apache/curator/pull/430#issuecomment-1242995908 Updated. I believe this patch is ready to merge. Please help with reviewing @eolivelli @Randgalt @cammckenzie -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@curator.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [curator] tisonkun commented on pull request #430: CURATOR-644. CURATOR-645. Fix livelock in LeaderLatch
tisonkun commented on PR #430: URL: https://github.com/apache/curator/pull/430#issuecomment-1231626148 Thanks for your inputs @XComp! I'll try to integrate your comment this week or the next. Since we merge several fixes into the master branch, and there're users asking for a new release, if we don't have a consensus on this patch, I'll push the changes on debug logging first so that reporters of CURATOR-644 and CURATOR-645 can use the new version to provide an exact error log output :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@curator.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [curator] tisonkun commented on pull request #430: CURATOR-644. CURATOR-645. Fix livelock in LeaderLatch
tisonkun commented on PR #430: URL: https://github.com/apache/curator/pull/430#issuecomment-1225647386 @XComp they're logically resolved simultaneously. That is, if you resolve CURATOR-644, you resolve CURATOR-645 - they're the same issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@curator.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [curator] tisonkun commented on pull request #430: CURATOR-644. CURATOR-645. Fix livelock in LeaderLatch
tisonkun commented on PR #430: URL: https://github.com/apache/curator/pull/430#issuecomment-1183862731 cc @rikimberley @yuri-tceretian -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@curator.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [curator] tisonkun commented on pull request #430: CURATOR-644. CURATOR-645. Fix livelock in LeaderLatch
tisonkun commented on PR #430: URL: https://github.com/apache/curator/pull/430#issuecomment-1182730213 I notice that background are running serially and the order is the same as request sending. Perhaps we can setup invariant based on this premise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@curator.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
