Re: 3.2.2 cdi integration and @Context.

[Romain Manni-Bucau]

Mainly but I strongly think cxf shouldnt assume it can own default. At
least we should observe beans to skip the add if already here and have a
bus property to fully skip it - or extension event to configure jaxrs
extension.

Le 6 févr. 2018 20:53, "John D. Ament"  a écrit :

> So then your issue is simply the javax.servlet ones, right?
>
> On Tue, Feb 6, 2018 at 2:14 PM Romain Manni-Bucau 
> wrote:
>
> > Le 6 févr. 2018 20:07, "John D. Ament"  a écrit :
> >
> > If we remove @Default then it won't be injectable without
> > @ContextResolved.  Are you seeing an issue though?
> >
> >
> > Yes. Owb-web provides all servlet beans so it leads to ambiguous
> > resolution.
> >
> > Also not being in the spec it must use a custom classifier imo - think of
> > request issue deltaspike had cause of that.
> >
> > Min is to toggle them off by default and probably another toggle for
> other
> > context types. Typically meecrowave supports context injection without
> > @Inject (as in the spec) so this just slows down the runtime for no gain.
> >
> > Side note: vetoing conflicting bean doeznt work since in a container cxf
> > would be wrong more often than the built in bean. Think to a
> > jaxrs/jsf/servlet app, the cdi container knows better how to inject the
> > request for instance - no need of cxf threadlocal which is not set by jsf
> > ;).
> >
> >
> >
> > On Tue, Feb 6, 2018 at 1:59 PM Romain Manni-Bucau  >
> > wrote:
> >
> > > Cdi provides a servlet context, request etc... bean. With cxf
> contextbean
> > > it is now ambiguous and you cant use a cdi container with cxf. The
> > default
> > > qualifier must be dropped from that bean.
> > >
> > > Le 6 févr. 2018 19:57, "John D. Ament"  a
> écrit
> > :
> > >
> > > > Sorry don't really understand your response.
> > > >
> > > > On Tue, Feb 6, 2018 at 1:52 PM Romain Manni-Bucau <
> > rmannibu...@gmail.com
> > > >
> > > > wrote:
> > > >
> > > > > @Inject X x; should match not a single CXF injection but
> > > > > ContextProducerBean matches @Default. Read too fast and though it
> was
> > > > > @Context but just looks like @Default shouldnt be in the beans.
> > > > >
> > > > >
> > > > > Romain Manni-Bucau
> > > > > @rmannibucau  |  Blog
> > > > >  | Old Blog
> > > > >  | Github <
> > > > > https://github.com/rmannibucau> |
> > > > > LinkedIn  | Book
> > > > > <
> > > > > https://www.packtpub.com/application-development/java-
> > > > ee-8-high-performance
> > > > > >
> > > > >
> > > > > 2018-02-06 19:50 GMT+01:00 John D. Ament :
> > > > >
> > > > > > On Tue, Feb 6, 2018 at 1:49 PM Romain Manni-Bucau <
> > > > rmannibu...@gmail.com
> > > > > >
> > > > > > wrote:
> > > > > >
> > > > > > > Hi guys,
> > > > > > >
> > > > > > > doesn't cdi integration of jaxrs miss a:
> > > > > > >
> > > > > > > bbd.addQualifier(Context.class);
> > > > > > >
> > > > > > >
> > > > > > What class is that?
> > > > > >
> > > > > >
> > > > > > > ?
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > Romain Manni-Bucau
> > > > > > > @rmannibucau  |  Blog
> > > > > > >  | Old Blog
> > > > > > >  | Github <
> > > > > > > https://github.com/rmannibucau> |
> > > > > > > LinkedIn  | Book
> > > > > > > <
> > > > > > > https://www.packtpub.com/application-development/java-
> > > > > > ee-8-high-performance
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>

Re: 3.2.2 cdi integration and @Context.

[John D. Ament]

So then your issue is simply the javax.servlet ones, right?

On Tue, Feb 6, 2018 at 2:14 PM Romain Manni-Bucau 
wrote:

> Le 6 févr. 2018 20:07, "John D. Ament"  a écrit :
>
> If we remove @Default then it won't be injectable without
> @ContextResolved.  Are you seeing an issue though?
>
>
> Yes. Owb-web provides all servlet beans so it leads to ambiguous
> resolution.
>
> Also not being in the spec it must use a custom classifier imo - think of
> request issue deltaspike had cause of that.
>
> Min is to toggle them off by default and probably another toggle for other
> context types. Typically meecrowave supports context injection without
> @Inject (as in the spec) so this just slows down the runtime for no gain.
>
> Side note: vetoing conflicting bean doeznt work since in a container cxf
> would be wrong more often than the built in bean. Think to a
> jaxrs/jsf/servlet app, the cdi container knows better how to inject the
> request for instance - no need of cxf threadlocal which is not set by jsf
> ;).
>
>
>
> On Tue, Feb 6, 2018 at 1:59 PM Romain Manni-Bucau 
> wrote:
>
> > Cdi provides a servlet context, request etc... bean. With cxf contextbean
> > it is now ambiguous and you cant use a cdi container with cxf. The
> default
> > qualifier must be dropped from that bean.
> >
> > Le 6 févr. 2018 19:57, "John D. Ament"  a écrit
> :
> >
> > > Sorry don't really understand your response.
> > >
> > > On Tue, Feb 6, 2018 at 1:52 PM Romain Manni-Bucau <
> rmannibu...@gmail.com
> > >
> > > wrote:
> > >
> > > > @Inject X x; should match not a single CXF injection but
> > > > ContextProducerBean matches @Default. Read too fast and though it was
> > > > @Context but just looks like @Default shouldnt be in the beans.
> > > >
> > > >
> > > > Romain Manni-Bucau
> > > > @rmannibucau  |  Blog
> > > >  | Old Blog
> > > >  | Github <
> > > > https://github.com/rmannibucau> |
> > > > LinkedIn  | Book
> > > > <
> > > > https://www.packtpub.com/application-development/java-
> > > ee-8-high-performance
> > > > >
> > > >
> > > > 2018-02-06 19:50 GMT+01:00 John D. Ament :
> > > >
> > > > > On Tue, Feb 6, 2018 at 1:49 PM Romain Manni-Bucau <
> > > rmannibu...@gmail.com
> > > > >
> > > > > wrote:
> > > > >
> > > > > > Hi guys,
> > > > > >
> > > > > > doesn't cdi integration of jaxrs miss a:
> > > > > >
> > > > > > bbd.addQualifier(Context.class);
> > > > > >
> > > > > >
> > > > > What class is that?
> > > > >
> > > > >
> > > > > > ?
> > > > > >
> > > > > >
> > > > > >
> > > > > > Romain Manni-Bucau
> > > > > > @rmannibucau  |  Blog
> > > > > >  | Old Blog
> > > > > >  | Github <
> > > > > > https://github.com/rmannibucau> |
> > > > > > LinkedIn  | Book
> > > > > > <
> > > > > > https://www.packtpub.com/application-development/java-
> > > > > ee-8-high-performance
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>

Re: 3.2.2 cdi integration and @Context.

[Romain Manni-Bucau]

Le 6 févr. 2018 20:07, "John D. Ament"  a écrit :

If we remove @Default then it won't be injectable without
@ContextResolved.  Are you seeing an issue though?


Yes. Owb-web provides all servlet beans so it leads to ambiguous resolution.

Also not being in the spec it must use a custom classifier imo - think of
request issue deltaspike had cause of that.

Min is to toggle them off by default and probably another toggle for other
context types. Typically meecrowave supports context injection without
@Inject (as in the spec) so this just slows down the runtime for no gain.

Side note: vetoing conflicting bean doeznt work since in a container cxf
would be wrong more often than the built in bean. Think to a
jaxrs/jsf/servlet app, the cdi container knows better how to inject the
request for instance - no need of cxf threadlocal which is not set by jsf
;).



On Tue, Feb 6, 2018 at 1:59 PM Romain Manni-Bucau 
wrote:

> Cdi provides a servlet context, request etc... bean. With cxf contextbean
> it is now ambiguous and you cant use a cdi container with cxf. The default
> qualifier must be dropped from that bean.
>
> Le 6 févr. 2018 19:57, "John D. Ament"  a écrit :
>
> > Sorry don't really understand your response.
> >
> > On Tue, Feb 6, 2018 at 1:52 PM Romain Manni-Bucau  >
> > wrote:
> >
> > > @Inject X x; should match not a single CXF injection but
> > > ContextProducerBean matches @Default. Read too fast and though it was
> > > @Context but just looks like @Default shouldnt be in the beans.
> > >
> > >
> > > Romain Manni-Bucau
> > > @rmannibucau  |  Blog
> > >  | Old Blog
> > >  | Github <
> > > https://github.com/rmannibucau> |
> > > LinkedIn  | Book
> > > <
> > > https://www.packtpub.com/application-development/java-
> > ee-8-high-performance
> > > >
> > >
> > > 2018-02-06 19:50 GMT+01:00 John D. Ament :
> > >
> > > > On Tue, Feb 6, 2018 at 1:49 PM Romain Manni-Bucau <
> > rmannibu...@gmail.com
> > > >
> > > > wrote:
> > > >
> > > > > Hi guys,
> > > > >
> > > > > doesn't cdi integration of jaxrs miss a:
> > > > >
> > > > > bbd.addQualifier(Context.class);
> > > > >
> > > > >
> > > > What class is that?
> > > >
> > > >
> > > > > ?
> > > > >
> > > > >
> > > > >
> > > > > Romain Manni-Bucau
> > > > > @rmannibucau  |  Blog
> > > > >  | Old Blog
> > > > >  | Github <
> > > > > https://github.com/rmannibucau> |
> > > > > LinkedIn  | Book
> > > > > <
> > > > > https://www.packtpub.com/application-development/java-
> > > > ee-8-high-performance
> > > > > >
> > > > >
> > > >
> > >
> >
>

Re: 3.2.2 cdi integration and @Context.

[John D. Ament]

If we remove @Default then it won't be injectable without
@ContextResolved.  Are you seeing an issue though?

On Tue, Feb 6, 2018 at 1:59 PM Romain Manni-Bucau 
wrote:

> Cdi provides a servlet context, request etc... bean. With cxf contextbean
> it is now ambiguous and you cant use a cdi container with cxf. The default
> qualifier must be dropped from that bean.
>
> Le 6 févr. 2018 19:57, "John D. Ament"  a écrit :
>
> > Sorry don't really understand your response.
> >
> > On Tue, Feb 6, 2018 at 1:52 PM Romain Manni-Bucau  >
> > wrote:
> >
> > > @Inject X x; should match not a single CXF injection but
> > > ContextProducerBean matches @Default. Read too fast and though it was
> > > @Context but just looks like @Default shouldnt be in the beans.
> > >
> > >
> > > Romain Manni-Bucau
> > > @rmannibucau  |  Blog
> > >  | Old Blog
> > >  | Github <
> > > https://github.com/rmannibucau> |
> > > LinkedIn  | Book
> > > <
> > > https://www.packtpub.com/application-development/java-
> > ee-8-high-performance
> > > >
> > >
> > > 2018-02-06 19:50 GMT+01:00 John D. Ament :
> > >
> > > > On Tue, Feb 6, 2018 at 1:49 PM Romain Manni-Bucau <
> > rmannibu...@gmail.com
> > > >
> > > > wrote:
> > > >
> > > > > Hi guys,
> > > > >
> > > > > doesn't cdi integration of jaxrs miss a:
> > > > >
> > > > > bbd.addQualifier(Context.class);
> > > > >
> > > > >
> > > > What class is that?
> > > >
> > > >
> > > > > ?
> > > > >
> > > > >
> > > > >
> > > > > Romain Manni-Bucau
> > > > > @rmannibucau  |  Blog
> > > > >  | Old Blog
> > > > >  | Github <
> > > > > https://github.com/rmannibucau> |
> > > > > LinkedIn  | Book
> > > > > <
> > > > > https://www.packtpub.com/application-development/java-
> > > > ee-8-high-performance
> > > > > >
> > > > >
> > > >
> > >
> >
>

Re: 3.2.2 cdi integration and @Context.

[John D. Ament]

Sorry don't really understand your response.

On Tue, Feb 6, 2018 at 1:52 PM Romain Manni-Bucau 
wrote:

> @Inject X x; should match not a single CXF injection but
> ContextProducerBean matches @Default. Read too fast and though it was
> @Context but just looks like @Default shouldnt be in the beans.
>
>
> Romain Manni-Bucau
> @rmannibucau  |  Blog
>  | Old Blog
>  | Github <
> https://github.com/rmannibucau> |
> LinkedIn  | Book
> <
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >
>
> 2018-02-06 19:50 GMT+01:00 John D. Ament :
>
> > On Tue, Feb 6, 2018 at 1:49 PM Romain Manni-Bucau  >
> > wrote:
> >
> > > Hi guys,
> > >
> > > doesn't cdi integration of jaxrs miss a:
> > >
> > > bbd.addQualifier(Context.class);
> > >
> > >
> > What class is that?
> >
> >
> > > ?
> > >
> > >
> > >
> > > Romain Manni-Bucau
> > > @rmannibucau  |  Blog
> > >  | Old Blog
> > >  | Github <
> > > https://github.com/rmannibucau> |
> > > LinkedIn  | Book
> > > <
> > > https://www.packtpub.com/application-development/java-
> > ee-8-high-performance
> > > >
> > >
> >
>

Re: 3.2.2 cdi integration and @Context.

[John D. Ament]

On Tue, Feb 6, 2018 at 1:49 PM Romain Manni-Bucau 
wrote:

> Hi guys,
>
> doesn't cdi integration of jaxrs miss a:
>
> bbd.addQualifier(Context.class);
>
>
What class is that?


> ?
>
>
>
> Romain Manni-Bucau
> @rmannibucau  |  Blog
>  | Old Blog
>  | Github <
> https://github.com/rmannibucau> |
> LinkedIn  | Book
> <
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >
>

3.2.2 cdi integration and @Context.

[Romain Manni-Bucau]

Hi guys,

doesn't cdi integration of jaxrs miss a:

bbd.addQualifier(Context.class);

?



Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | Book

[GitHub] sberyozkin commented on issue #378: [CXF-7636] wadl2java: support Oneway annotation

[GitBox]

sberyozkin commented on issue #378: [CXF-7636] wadl2java: support Oneway 
annotation
URL: https://github.com/apache/cxf/pull/378#issuecomment-363500413
 
 
   Hi Alexey, looks fine to me, please merge


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[RESULT] [VOTE] CXF 3.2.2

[Daniel Kulp]

We have 14 +1 votes and no other votes.This vote passes.

Dan




> On Feb 2, 2018, at 2:57 PM, Daniel Kulp  wrote:
> 
> This is a vote to release CXF 3.2.2.   We’ve fixed over 60 JIRA issues, 
> definitely time to release it.   This also includes releases of build-utils 
> (3.4.0) and xjc-utils (3.2.1) to allow it to build on Java 9 and with the 
> latest checkstyle plugins.
> 
> 
> Staging area:
> https://repository.apache.org/content/repositories/orgapachecxf-1112/
> 
> 
> Tags:
> https://gitbox.apache.org/repos/asf?p=cxf-build-utils.git;a=commit;h=f362ab215acb17e744a8df4001b60e91dafb3a46
> https://gitbox.apache.org/repos/asf?p=cxf-xjc-utils.git;a=commit;h=932ad93e601c19dab833b96a3649502334e90821
> https://gitbox.apache.org/repos/asf?p=cxf.git;a=commit;h=d579d7949d119dcf3d312059085bc200bcb3bbea
> 
> 
> Here is my +1.
> 
> 
> -- 
> Daniel Kulp
> dk...@apache.org - http://dankulp.com/blog
> Talend Community Coder - http://coders.talend.com
> 

-- 
Daniel Kulp
dk...@apache.org - http://dankulp.com/blog
Talend Community Coder - http://coders.talend.com

[GitHub] amarkevich opened a new pull request #378: [CXF-7636] wadl2java: support Oneway annotation

[GitBox]

amarkevich opened a new pull request #378: [CXF-7636] wadl2java: support Oneway 
annotation
URL: https://github.com/apache/cxf/pull/378
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Remove obsolete RxJava code and keep RxJava2 only one

[Sergey Beryozkin]

I'd still favour removing RxJava, if you would like to keep it then I 
guess the new module would indeed have to be introduced


Cheers, Sergey

On 06/02/18 03:49, John D. Ament wrote:

I was just about to remove the optional marking on reactive streams, and
noticed that rxjava was still around.  I guess it was decided to keep it?
I'll point out, this now makes the dependency chain even harder to follow
(since rxjava2 uses reactive streams, but rxjava does not).

John

On Wed, Nov 15, 2017 at 6:53 PM Andriy Redko  wrote:


Hey Sergey,

That would be ideal I think (move RxJava into separate module). RxJava2 and
RxJava are quite different frameworks, some people just stuck with RxJava
so
we could support them there. Thanks.

Best Regards,
 Andriy Redko

JDA> What about just leaving the old RxJava code in a module by itself
(when I
JDA> was looking recently, it didn't make much sense to see both RxJava and
JDA> RxJava2 in one module).

JDA> On Wed, Nov 15, 2017 at 10:56 AM Sergey Beryozkin <
sberyoz...@gmail.com>
JDA> wrote:


Hi



cxf-rt-rs-extension-rx ships the code for both (old) RxJava and RxJava2
code. It supports returning RxJava2 Flowable and Observable on the
server and accepting it on the client, and the same for the (old) RxJava
Observable...



While even the (old) RxJava code is very new for CXF, the reality is
that RxJava has been around for a while now and with RxJava2 embracing
org.reactivestreams, it's hard to see CXF users preferring to start with
the (old) RxJava.



The other minor problem is that cxf-rt-rs-extension-rx has optional
RxJava and RxJava2 deps to be able to ship the relevant code in the same
module and splitting it into 2 modules will be too much at this point.



I suggest that unless some users confirm (I CC to the users) that they
need to use the (old) RxJava code, then we just remove it and make
things much simpler...



Thanks, Sergey