Time to release CXF 3.2.9 ?
Looks we have bunch of issues fixed and improvements since CXF 3.2.8 . Is it time to start a CXF 3.2.9 release ? Thanks, Jim
[GitHub] [cxf] reta commented on a change in pull request #542: CXF-8022: Thread hangs using Reactor Flux when Exception is Thrown
reta commented on a change in pull request #542: CXF-8022: Thread hangs using
Reactor Flux when Exception is Thrown
URL: https://github.com/apache/cxf/pull/542#discussion_r276878394
##
File path:
rt/rs/extensions/reactor/src/main/java/org/apache/cxf/jaxrs/reactor/client/ReactorInvokerImpl.java
##
@@ -201,13 +202,15 @@
@Override
public Flux flux(String name, Entity entity, Class
responseType) {
Future futureResponse = webClient.async().method(name,
entity);
-return Flux.fromIterable(toIterable(futureResponse, responseType));
+return Flux.fromStream(() ->
+StreamSupport.stream(toIterable(futureResponse,
responseType).spliterator(), false));
}
@Override
public Flux flux(String name, Class responseType) {
Future futureResponse = webClient.async().method(name);
-return Flux.fromIterable(toIterable(futureResponse, responseType));
+return Flux.fromStream(() ->
Review comment:
So when the `toIterable` fails (fe empty response, or alike), it does thrown
the exception from `getFlux` method, which is unexpected. Instead, the
exception should be propagated using `onError` callback, following the reactive
stream. Using the supplier fixes that.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cxf] reta commented on a change in pull request #542: CXF-8022: Thread hangs using Reactor Flux when Exception is Thrown
reta commented on a change in pull request #542: CXF-8022: Thread hangs using
Reactor Flux when Exception is Thrown
URL: https://github.com/apache/cxf/pull/542#discussion_r276878394
##
File path:
rt/rs/extensions/reactor/src/main/java/org/apache/cxf/jaxrs/reactor/client/ReactorInvokerImpl.java
##
@@ -201,13 +202,15 @@
@Override
public Flux flux(String name, Entity entity, Class
responseType) {
Future futureResponse = webClient.async().method(name,
entity);
-return Flux.fromIterable(toIterable(futureResponse, responseType));
+return Flux.fromStream(() ->
+StreamSupport.stream(toIterable(futureResponse,
responseType).spliterator(), false));
}
@Override
public Flux flux(String name, Class responseType) {
Future futureResponse = webClient.async().method(name);
-return Flux.fromIterable(toIterable(futureResponse, responseType));
+return Flux.fromStream(() ->
Review comment:
So when the `toIterable` fails (fe empty response, or alike), it does thrown
the exception from `getFlux` method, which is unexpected. Instead, the
exception should be propagated using `onError` callback, following the reactive
stream.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cxf] deki commented on issue #543: [CXF-8025]: Fix Wrapper Style for multilevel xsd:extension elements
deki commented on issue #543: [CXF-8025]: Fix Wrapper Style for multilevel xsd:extension elements URL: https://github.com/apache/cxf/pull/543#issuecomment-484622821 Don't worry, sometimes there are flanky tests on Jenkins. Thanks for your PR, looks good to me, but let's wait for another review before merging it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cxf] jpoje-gtri edited a comment on issue #543: [CXF-8025]: Fix Wrapper Style for multilevel xsd:extension elements
jpoje-gtri edited a comment on issue #543: [CXF-8025]: Fix Wrapper Style for multilevel xsd:extension elements URL: https://github.com/apache/cxf/pull/543#issuecomment-484369642 Weird, that test passes for me locally. I ran the full test suite with no failures on the cxf-3.3.1 tag and a few failures on master that were exactly the same with/without the patch (master from Tuesday). This was on OSX with java 8 and maven 3.6. (update 4/18: ran the PR branch on RHEL today and it passed) Thoughts? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[build] PR builds start continuously on Jenkins
Hi, There are almost no changes, check Build History https://builds.apache.org/job/CXF-Trunk-PR/
[GitHub] [cxf] amarkevich opened a new pull request #544: replace Stack with Deque
amarkevich opened a new pull request #544: replace Stack with Deque URL: https://github.com/apache/cxf/pull/544 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cxf] jpoje-gtri commented on issue #543: [CXF-8025]: Fix Wrapper Style for multilevel xsd:extension elements
jpoje-gtri commented on issue #543: [CXF-8025]: Fix Wrapper Style for multilevel xsd:extension elements URL: https://github.com/apache/cxf/pull/543#issuecomment-484369642 Weird, that test passes for me locally. I ran the full test suite with no failures on the cxf-3.3.1 tag and a few failures on master that were exactly the same with/without the patch (master from Tuesday). This was on OSX with java 8 and maven 3.6. Thoughts? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
