[GitHub] [cxf] jimma commented on a change in pull request #924: Various fixes for jakarta support

2022-03-23 Thread GitBox 


jimma commented on a change in pull request #924:
URL: https://github.com/apache/cxf/pull/924#discussion_r833834666



##
File path: core/src/main/java/org/apache/cxf/common/jaxb/JAXBUtils.java
##
@@ -1174,6 +1176,54 @@ private static Object createEscapeHandler(Class cls, 
String simpleClassName)
 }
 return null;
 }
-
-
+public static JAXBContext createJAXBContext(Set> classes,

Review comment:
   That is duplicate. I removed one. Thanks for review @reta  .




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: Systest failures with wss4j-3.0.0-SNAPSHOT

2022-03-23 Thread Jim Ma 
Thanks for the quick fix, Colm.

It seems there is another failure under services/sts/systests/advanced:

[INFO] Running org.apache.cxf.systest.sts.renew.SAMLRenewTest
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
10.297 s <<< FAILURE! - in org.apache.cxf.systest.sts.renew.SAMLRenewTest
[ERROR]
org.apache.cxf.systest.sts.renew.SAMLRenewTest.testRenewExpiredTokens  Time
elapsed: 9.671 s  <<< ERROR!
jakarta.xml.ws.soap.SOAPFaultException: A security error was encountered
when verifying the message
at
org.apache.cxf.systest.sts.renew.SAMLRenewTest.doubleIt(SAMLRenewTest.java:145)
at
org.apache.cxf.systest.sts.renew.SAMLRenewTest.testRenewExpiredTokens(SAMLRenewTest.java:116)
Caused by: org.apache.cxf.binding.soap.SoapFault: A security error was
encountered when verifying the message
at
org.apache.cxf.systest.sts.renew.SAMLRenewTest.doubleIt(SAMLRenewTest.java:145)
at
org.apache.cxf.systest.sts.renew.SAMLRenewTest.testRenewExpiredTokens(SAMLRenewTest.java:116)

I checked these spring configuration files and other places, and didn't
find the place we need to change to the jakarta namespace.
Is there anything else we need to check ?



On Wed, Mar 23, 2022 at 7:15 PM Colm O hEigeartaigh 
wrote:

> The SAML failures were caused by a hard-coded String in SAMLUtils, I
> fixed it in CXF master here:
>
> https://github.com/apache/cxf/commit/1e90f53f720b76c2dbac910e58ef0b291f98c032
>
> Colm.
>
> On Tue, Mar 22, 2022 at 12:48 PM Jim Ma  wrote:
> >
> > Hi Colm,
> >
> > Please checkout my working branch :
> https://github.com/jimma/cxf/tree/wss4j-30-jakarta
> > Build all cxf artifacts first with: mvn clean install -Pfastinstall
> > then go to systests/ws-security, run these tests and you'll get these
> test failures.
> > Please let me know if you have other issues when trying this out.
> >
> > Thanks,
> > Jim
> >
> > On Tue, Mar 22, 2022 at 5:18 PM Colm O hEigeartaigh 
> wrote:
> >>
> >> Hi Jim,
> >>
> >> Which branch are you testing this on in CXF?
> >>
> >> Colm.
> >>
> >> On Mon, Mar 21, 2022 at 7:26 AM Jim Ma  wrote:
> >> >
> >> > Hi Colm,
> >> > After I upgraded wss4j version to 3.0.0-SNAPSHOT(jakarta version)  in
> CXF,
> >> > I got the following ws-security systests failures.
> >> > Could you please help look at if there is still something we need to
> fix in
> >> > wss4j ? Or we need to fix it in CXF ?
> >> >
> >> > Thanks,
> >> > Jim
> >> >
> >> > 
> >> > [ERROR]
> >> > org.apache.cxf.systest.ws
> .saml.SamlTokenTest.testAudienceRestrictionServiceName[14036:dom]
> >> >  Time elapsed: 0.076 s  <<< ERROR!
> >> > jakarta.xml.ws.soap.SOAPFaultException: A security error was
> encountered
> >> > when verifying the message
> >> > at
> >> > org.apache.cxf.systest.ws
> .saml.SamlTokenTest.testAudienceRestrictionServiceName(SamlTokenTest.java:1194)
> >> > Caused by: org.apache.cxf.binding.soap.SoapFault: A security error was
> >> > encountered when verifying the message
> >> > at
> >> > org.apache.cxf.systest.ws
> .saml.SamlTokenTest.testAudienceRestrictionServiceName(SamlTokenTest.java:1194)
> >> >
> >> > [ERROR]
> >> > org.apache.cxf.systest.ws
> .saml.SamlTokenTest.testAudienceRestrictionServiceName[14036:streaming]
> >> >  Time elapsed: 0.069 s  <<< ERROR!
> >> > jakarta.xml.ws.soap.SOAPFaultException: A security error was
> encountered
> >> > when verifying the message
> >> > at
> >> > org.apache.cxf.systest.ws
> .saml.SamlTokenTest.testAudienceRestrictionServiceName(SamlTokenTest.java:1194)
> >> > Caused by: org.apache.cxf.binding.soap.SoapFault: A security error was
> >> > encountered when verifying the message
> >> > at
> >> > org.apache.cxf.systest.ws
> .saml.SamlTokenTest.testAudienceRestrictionServiceName(SamlTokenTest.java:1194)
> >> >
> >> > [ERROR]
> >> > org.apache.cxf.systest.ws
> .saml.SamlTokenTest.testAudienceRestrictionServiceName[14037:dom]
> >> >  Time elapsed: 0.048 s  <<< ERROR!
> >> > jakarta.xml.ws.soap.SOAPFaultException:
> >> > javax.xml.stream.XMLStreamException:
> >> > org.apache.wss4j.common.ext.WSSecurityException: A security error was
> >> > encountered when verifying the message
> >> > at
> >> > org.apache.cxf.systest.ws
> .saml.SamlTokenTest.testAudienceRestrictionServiceName(SamlTokenTest.java:1194)
> >> > Caused by: org.apache.cxf.binding.soap.SoapFault:
> >> > javax.xml.stream.XMLStreamException:
> >> > org.apache.wss4j.common.ext.WSSecurityException: A security error was
> >> > encountered when verifying the message
> >> > at
> >> > org.apache.cxf.systest.ws
> .saml.SamlTokenTest.testAudienceRestrictionServiceName(SamlTokenTest.java:1194)
> >> >
> >> > [ERROR]
> >> > org.apache.cxf.systest.ws
> .saml.SamlTokenTest.testAudienceRestrictionServiceName[14037:streaming]
> >> >  Time elapsed: 0.062 s  <<< ERROR!
> >> > jakarta.xml.ws.soap.SOAPFaultException:
> >> > javax.xml.stream.XMLStreamException:
> >> > org.apache.wss4j.common.ext.WSSecurityException: A security error was
> >> > encountered when verifying the message
> >> >

Re: Systest failures with wss4j-3.0.0-SNAPSHOT

2022-03-23 Thread Colm O hEigeartaigh 
The SAML failures were caused by a hard-coded String in SAMLUtils, I
fixed it in CXF master here:
https://github.com/apache/cxf/commit/1e90f53f720b76c2dbac910e58ef0b291f98c032

Colm.

On Tue, Mar 22, 2022 at 12:48 PM Jim Ma  wrote:
>
> Hi Colm,
>
> Please checkout my working branch : 
> https://github.com/jimma/cxf/tree/wss4j-30-jakarta
> Build all cxf artifacts first with: mvn clean install -Pfastinstall
> then go to systests/ws-security, run these tests and you'll get these test 
> failures.
> Please let me know if you have other issues when trying this out.
>
> Thanks,
> Jim
>
> On Tue, Mar 22, 2022 at 5:18 PM Colm O hEigeartaigh  
> wrote:
>>
>> Hi Jim,
>>
>> Which branch are you testing this on in CXF?
>>
>> Colm.
>>
>> On Mon, Mar 21, 2022 at 7:26 AM Jim Ma  wrote:
>> >
>> > Hi Colm,
>> > After I upgraded wss4j version to 3.0.0-SNAPSHOT(jakarta version)  in CXF,
>> > I got the following ws-security systests failures.
>> > Could you please help look at if there is still something we need to fix in
>> > wss4j ? Or we need to fix it in CXF ?
>> >
>> > Thanks,
>> > Jim
>> >
>> > 
>> > [ERROR]
>> > org.apache.cxf.systest.ws.saml.SamlTokenTest.testAudienceRestrictionServiceName[14036:dom]
>> >  Time elapsed: 0.076 s  <<< ERROR!
>> > jakarta.xml.ws.soap.SOAPFaultException: A security error was encountered
>> > when verifying the message
>> > at
>> > org.apache.cxf.systest.ws.saml.SamlTokenTest.testAudienceRestrictionServiceName(SamlTokenTest.java:1194)
>> > Caused by: org.apache.cxf.binding.soap.SoapFault: A security error was
>> > encountered when verifying the message
>> > at
>> > org.apache.cxf.systest.ws.saml.SamlTokenTest.testAudienceRestrictionServiceName(SamlTokenTest.java:1194)
>> >
>> > [ERROR]
>> > org.apache.cxf.systest.ws.saml.SamlTokenTest.testAudienceRestrictionServiceName[14036:streaming]
>> >  Time elapsed: 0.069 s  <<< ERROR!
>> > jakarta.xml.ws.soap.SOAPFaultException: A security error was encountered
>> > when verifying the message
>> > at
>> > org.apache.cxf.systest.ws.saml.SamlTokenTest.testAudienceRestrictionServiceName(SamlTokenTest.java:1194)
>> > Caused by: org.apache.cxf.binding.soap.SoapFault: A security error was
>> > encountered when verifying the message
>> > at
>> > org.apache.cxf.systest.ws.saml.SamlTokenTest.testAudienceRestrictionServiceName(SamlTokenTest.java:1194)
>> >
>> > [ERROR]
>> > org.apache.cxf.systest.ws.saml.SamlTokenTest.testAudienceRestrictionServiceName[14037:dom]
>> >  Time elapsed: 0.048 s  <<< ERROR!
>> > jakarta.xml.ws.soap.SOAPFaultException:
>> > javax.xml.stream.XMLStreamException:
>> > org.apache.wss4j.common.ext.WSSecurityException: A security error was
>> > encountered when verifying the message
>> > at
>> > org.apache.cxf.systest.ws.saml.SamlTokenTest.testAudienceRestrictionServiceName(SamlTokenTest.java:1194)
>> > Caused by: org.apache.cxf.binding.soap.SoapFault:
>> > javax.xml.stream.XMLStreamException:
>> > org.apache.wss4j.common.ext.WSSecurityException: A security error was
>> > encountered when verifying the message
>> > at
>> > org.apache.cxf.systest.ws.saml.SamlTokenTest.testAudienceRestrictionServiceName(SamlTokenTest.java:1194)
>> >
>> > [ERROR]
>> > org.apache.cxf.systest.ws.saml.SamlTokenTest.testAudienceRestrictionServiceName[14037:streaming]
>> >  Time elapsed: 0.062 s  <<< ERROR!
>> > jakarta.xml.ws.soap.SOAPFaultException:
>> > javax.xml.stream.XMLStreamException:
>> > org.apache.wss4j.common.ext.WSSecurityException: A security error was
>> > encountered when verifying the message
>> > at
>> > org.apache.cxf.systest.ws.saml.SamlTokenTest.testAudienceRestrictionServiceName(SamlTokenTest.java:1194)
>> > Caused by: org.apache.cxf.binding.soap.SoapFault:
>> > javax.xml.stream.XMLStreamException:
>> > org.apache.wss4j.common.ext.WSSecurityException: A security error was
>> > encountered when verifying the message
>> > at
>> > org.apache.cxf.systest.ws.saml.SamlTokenTest.testAudienceRestrictionServiceName(SamlTokenTest.java:1194)
>> > [INFO] Running org.apache.cxf.systest.ws.xkms.XKMSTest
>> > [ERROR] Tests run: 12, Failures: 0, Errors: 12, Skipped: 0, Time elapsed:
>> > 1.006 s <<< FAILURE! - in org.apache.cxf.systest.ws.xkms.XKMSTest
>> > [ERROR]
>> > org.apache.cxf.systest.ws.xkms.XKMSTest.testRegisterUnitTest[14087:dom]
>> >  Time elapsed: 0.079 s  <<< ERROR!
>> > jakarta.xml.ws.WebServiceException:
>> > org.apache.cxf.service.factory.ServiceConstructionException: Could not find
>> > portType named {http://xkms_wsdl._03._2002.w3.org/}XKMSPortType
>> > at
>> > org.apache.cxf.systest.ws.xkms.XKMSTest.testRegisterUnitTest(XKMSTest.java:135)
>> > Caused by: org.apache.cxf.service.factory.ServiceConstructionException:
>> > Could not find portType named {http://xkms_wsdl._03._
>> > 2002.w3.org/}XKMSPortType
>> > at
>> > org.apache.cxf.systest.ws.xkms.XKMSTest.testRegisterUnitTest(XKMSTest.java:135)
>> >
>> > [ERROR]
>> > org.apache.cxf.systest.ws.xkms.XKMSTest.testSymmetricBinding[14087:dom]
>> >  Time