Re: [DISCUSS] CXF 3.5.x and beyond

[Andrey Redko]

Hi Jim,

No objections from my side, thank you.

Best Regards,
Andriy Redko

On Tue, Sep 27, 2022, 9:31 PM Jim Ma  wrote:

> Hi all,
> If there is no objection, I will create a branch "osgi-pre-removal-v4.0"
> to record the changes before the osgi and karaf removal, then
> merge the this PR https://github.com/apache/cxf/pull/999 to the main
> branch.
>
> Thanks,
> Jim
>
> On Thu, Sep 22, 2022 at 9:06 PM Andrey Redko  wrote:
>
>> This is great, thanks Jim, I will also take a look shortly. Thanks!
>>
>> Best Regards,
>> Andriy Redko
>>
>> On Wed, Sep 21, 2022, 1:02 AM Jim Ma  wrote:
>>
>>> Hi All,
>>> I tried to remove the osgi and karaf from CXF with this draft PR :
>>>  https://github.com/apache/cxf/pull/999
>>> .
>>> This mainly removed the osgi code,test, examples and dependency, but for
>>> some class like SpringBus which deeply coupled with osgi:
>>>
>>> https://github.com/apache/cxf/blob/main/core/src/main/java/org/apache/cxf/bus/spring/SpringBus.java#L133-L142
>>> 
>>> I added the comment "//uncomment this when osgi comes back" to mark
>>> these commented lines for osgi. With the branch created before
>>> this change is merged to main, I am sure this will make it easy to bring
>>> the osgi and karaf back when the Jakarta support is ready in the future.
>>>
>>> Please help review this PR. If you have any comment or question,  please
>>> let me know.
>>>
>>> Thanks,
>>> Jim
>>>
>>>
>>> On Sat, Sep 10, 2022 at 4:05 AM Andriy Redko  wrote:
>>>
 Hi Jim,

 That is correct, I am working on
 https://issues.apache.org/jira/browse/CXF-8717 as part of
 Jetty 11 migration, the Atmosphere implementation seems to be fine.
 Thanks.

 Best Regards,
 Andriy Redko


 JM> Thanks for the update, Andiry. You already did a lot of work on
 third party
 JM> jakarta support !

 JM> Just to understand the CXF Jakarta support work status, are these
 issues we
 JM> can start without waiting for the dependency release ?
 JM> https://issues.apache.org/jira/browse/CXF-8716
 JM> https://issues.apache.org/jira/browse/CXF-8717
 JM> https://issues.apache.org/jira/browse/CXF-8719



 JM> On Thu, Sep 8, 2022 at 8:04 PM Andriy Redko 
 wrote:

 >> Hi Jim,
 >>
 >> Yeah, we may need some time, I am also finalizing work on the
 Wiremock (
 >> https://github.com/wiremock/wiremock/pull/1942),
 >> we use it in tests extensively. One of the largest efforts is
 migration to
 >> Jetty 11, I have started on that already but
 >> have difficulties with WebSockets migration, it needs rework and
 that is
 >> my focus at the moment. The Swagger 1.x we have
 >> to drop I believe, I don't see roadmap on Jakarta support there.
 >>
 >> Thanks!
 >>
 >> Best Regards,
 >> Andriy Redko
 >>
 >> JM> Hi Andriy,
 >> JM> It looks like we still have to wait for the other dependency
 jakarta
 >> JM> support available, like brave's new release to include this
 change :
 >> JM> https://github.com/openzipkin/brave/pull/1344.  Do you see any
 other
 >> JM> dependencies that haven't been released yet except OSGI and
 Karaf ?
 >>
 >> JM> Thanks,
 >> JM> Jim
 >>
 >>
 >> JM> On Wed, Sep 7, 2022 at 8:11 PM Jim Ma 
 wrote:
 >>
 >> >> Thanks for the informative input, Freeman.
 >> >> IMO, If we want to decouple OSGI/Karaf, the 4.0 major release is
 a good
 >> >> chance to do this job. When OSGI/Karaf jakarta release is ready,
 >> >> We can look at bringing this back with more improvement and
 refactor
 >> work
 >> >> to make it loosely coupled with core code.
 >> >>
 >> >> On Wed, Sep 7, 2022 at 5:34 AM Freeman Fang <
 freeman.f...@gmail.com>
 >> >> wrote:
 >> >>
 >> >>> Hi Jim,
 >> >>>
 >> >>> Sorry for the late reply, just back from vacation.
 >> >>>
 >> >>> About the OSGi part, the main problem is that the OSGi R9 spec
 which
 >> will
 >> >>> support Jakarta namespace is in progress and isn't released
 yet(and I
 >> don't
 >> >>> think there is a concrete release date for OSGi R9 spec in the
 new
 >> future).
 >> >>> Before OSGi R9 spec gets released and adopted by OSGi
 implementations
 >> like
 >> >>> Felix/Equinox, I don't think there is much we can do in CXF or
 even in
 >> >>> Karaf about this part.
 >> >>>
 >> >>> And Andriy, you are right,  release CXF 4.0 M1 without
 OSGi/Karaf bit
 >> >>> seems the only option we have so far,  and I'm +1 for this way
 >> now(Since we
 >> >>> don't know how long we need to wait for the proper OSGi spec
 released
 >> and
 >> >>> upstream projects can support it).

Re: [DISCUSS] CXF 3.5.x and beyond

[Jim Ma]

Hi all,
If there is no objection, I will create a branch "osgi-pre-removal-v4.0" to
record the changes before the osgi and karaf removal, then
merge the this PR https://github.com/apache/cxf/pull/999 to the main branch.

Thanks,
Jim

On Thu, Sep 22, 2022 at 9:06 PM Andrey Redko  wrote:

> This is great, thanks Jim, I will also take a look shortly. Thanks!
>
> Best Regards,
> Andriy Redko
>
> On Wed, Sep 21, 2022, 1:02 AM Jim Ma  wrote:
>
>> Hi All,
>> I tried to remove the osgi and karaf from CXF with this draft PR :
>>  https://github.com/apache/cxf/pull/999
>> .
>> This mainly removed the osgi code,test, examples and dependency, but for
>> some class like SpringBus which deeply coupled with osgi:
>>
>> https://github.com/apache/cxf/blob/main/core/src/main/java/org/apache/cxf/bus/spring/SpringBus.java#L133-L142
>> 
>> I added the comment "//uncomment this when osgi comes back" to mark these
>> commented lines for osgi. With the branch created before
>> this change is merged to main, I am sure this will make it easy to bring
>> the osgi and karaf back when the Jakarta support is ready in the future.
>>
>> Please help review this PR. If you have any comment or question,  please
>> let me know.
>>
>> Thanks,
>> Jim
>>
>>
>> On Sat, Sep 10, 2022 at 4:05 AM Andriy Redko  wrote:
>>
>>> Hi Jim,
>>>
>>> That is correct, I am working on
>>> https://issues.apache.org/jira/browse/CXF-8717 as part of
>>> Jetty 11 migration, the Atmosphere implementation seems to be fine.
>>> Thanks.
>>>
>>> Best Regards,
>>> Andriy Redko
>>>
>>>
>>> JM> Thanks for the update, Andiry. You already did a lot of work on
>>> third party
>>> JM> jakarta support !
>>>
>>> JM> Just to understand the CXF Jakarta support work status, are these
>>> issues we
>>> JM> can start without waiting for the dependency release ?
>>> JM> https://issues.apache.org/jira/browse/CXF-8716
>>> JM> https://issues.apache.org/jira/browse/CXF-8717
>>> JM> https://issues.apache.org/jira/browse/CXF-8719
>>>
>>>
>>>
>>> JM> On Thu, Sep 8, 2022 at 8:04 PM Andriy Redko 
>>> wrote:
>>>
>>> >> Hi Jim,
>>> >>
>>> >> Yeah, we may need some time, I am also finalizing work on the
>>> Wiremock (
>>> >> https://github.com/wiremock/wiremock/pull/1942),
>>> >> we use it in tests extensively. One of the largest efforts is
>>> migration to
>>> >> Jetty 11, I have started on that already but
>>> >> have difficulties with WebSockets migration, it needs rework and that
>>> is
>>> >> my focus at the moment. The Swagger 1.x we have
>>> >> to drop I believe, I don't see roadmap on Jakarta support there.
>>> >>
>>> >> Thanks!
>>> >>
>>> >> Best Regards,
>>> >> Andriy Redko
>>> >>
>>> >> JM> Hi Andriy,
>>> >> JM> It looks like we still have to wait for the other dependency
>>> jakarta
>>> >> JM> support available, like brave's new release to include this
>>> change :
>>> >> JM> https://github.com/openzipkin/brave/pull/1344.  Do you see any
>>> other
>>> >> JM> dependencies that haven't been released yet except OSGI and Karaf
>>> ?
>>> >>
>>> >> JM> Thanks,
>>> >> JM> Jim
>>> >>
>>> >>
>>> >> JM> On Wed, Sep 7, 2022 at 8:11 PM Jim Ma 
>>> wrote:
>>> >>
>>> >> >> Thanks for the informative input, Freeman.
>>> >> >> IMO, If we want to decouple OSGI/Karaf, the 4.0 major release is a
>>> good
>>> >> >> chance to do this job. When OSGI/Karaf jakarta release is ready,
>>> >> >> We can look at bringing this back with more improvement and
>>> refactor
>>> >> work
>>> >> >> to make it loosely coupled with core code.
>>> >> >>
>>> >> >> On Wed, Sep 7, 2022 at 5:34 AM Freeman Fang <
>>> freeman.f...@gmail.com>
>>> >> >> wrote:
>>> >> >>
>>> >> >>> Hi Jim,
>>> >> >>>
>>> >> >>> Sorry for the late reply, just back from vacation.
>>> >> >>>
>>> >> >>> About the OSGi part, the main problem is that the OSGi R9 spec
>>> which
>>> >> will
>>> >> >>> support Jakarta namespace is in progress and isn't released
>>> yet(and I
>>> >> don't
>>> >> >>> think there is a concrete release date for OSGi R9 spec in the new
>>> >> future).
>>> >> >>> Before OSGi R9 spec gets released and adopted by OSGi
>>> implementations
>>> >> like
>>> >> >>> Felix/Equinox, I don't think there is much we can do in CXF or
>>> even in
>>> >> >>> Karaf about this part.
>>> >> >>>
>>> >> >>> And Andriy, you are right,  release CXF 4.0 M1 without OSGi/Karaf
>>> bit
>>> >> >>> seems the only option we have so far,  and I'm +1 for this way
>>> >> now(Since we
>>> >> >>> don't know how long we need to wait for the proper OSGi spec
>>> released
>>> >> and
>>> >> >>> upstream projects can support it).
>>> >> >>>
>>> >> >>> Just my 2 cents.
>>> >> >>> Best Regards
>>> >> >>> Freeman
>>> >> >>>
>>> >> >>> On Mon, Aug 22, 2022 at 10:34 PM Jim Ma 
>>> wrote:
>>> >> >>>
>>> >>  For OSGI and Karaf Jakarta native, I remembered I talked with
>>> Freeman
>>> >>  about this topic 

[GitHub] [cxf] coheigea closed pull request #1001: Fix ws-discovery test on non-M1 Macs

[GitBox]

coheigea closed pull request #1001: Fix ws-discovery test on non-M1 Macs
URL: https://github.com/apache/cxf/pull/1001


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cxf] coheigea commented on pull request #1001: Fix ws-discovery test on non-M1 Macs

[GitBox]

coheigea commented on PR #1001:
URL: https://github.com/apache/cxf/pull/1001#issuecomment-1259652935

   Closing after review, we will revert the original commit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cxf] reta commented on pull request #1000: CXF-8714: Migration path for Swagger v1.x

[GitBox]

reta commented on PR #1000:
URL: https://github.com/apache/cxf/pull/1000#issuecomment-1259460864

   > @reta LGTM . More test resource files we can probably remove them too ?
   > 
   > * Files under 
https://github.com/reta/cxf/tree/CXF-8714/systests/jaxrs/src/test/resources/org/apache/cxf/systest/jaxrs/description
   > 
   > * 
https://github.com/reta/cxf/blob/CXF-8714/systests/jaxrs/src/test/resources/files/swagger.properties.
   
   @jimma absolutely, missed that, thank you for noticing, removed resources as 
well


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: Please update 4.0-SNAPSHOT

[Dennis Kieselhorst]

Hi Andriy,

I think you are close, the errors are just Javadoc-related for Swagger and 
Jetty 9. Great work so far, really unfortunate that I didn't found the time to 
contribute...

Best,
Dennis