[GitHub] cxf issue #183: [CXF-7093] Change the spring boot example to use samples par...
Github user johnament commented on the issue: https://github.com/apache/cxf/pull/183 I'm not sure what you mean. That didn't change other than the way mvn is called - mvn -Pclient/server vs mvn spring-boot:run for all 3 modules. If you want me to make that work I can. The problem is that the wrong spring boot version was getting used.. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cxf issue #183: [CXF-7093] Change the spring boot example to use samples par...
Github user sberyozkin commented on the issue: https://github.com/apache/cxf/pull/183 While I appreciate this quality patch I'd like to say that the way the spring_boot_scan server and client applications are started is really off topic for CXF-7093, however as I noted I can def live with asking users to do 'mvn spring-boot:run' again instead of -Pserver or -Pclient. Re "java -jar" - I'll experiment tomorrow --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cxf issue #183: [CXF-7093] Change the spring boot example to use samples par...
Github user johnament commented on the issue: https://github.com/apache/cxf/pull/183 Well we can make spring boot the default goal. I'm not sure about your question though. This just changes the file name and I've been able to run the examples with these instructions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cxf issue #183: [CXF-7093] Change the spring boot example to use samples par...
Github user sberyozkin commented on the issue: https://github.com/apache/cxf/pull/183 John, does the demo work without a version qualifier of the final jar, when it is started with a "java -jar" ? Also as a side note I'm not convinced -Pserver does not make sense for the server only applications as it hides the specific plugin options - but I'm fine with getting rid of them whenever possible --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cxf issue #183: [CXF-7093] Change the spring boot example to use samples par...
Github user reta commented on the issue: https://github.com/apache/cxf/pull/183 IMO, looks cleaner, thanks @johnament, leaving decision to @sberyozkin as he authored or/and worked on these examples. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cxf issue #183: [CXF-7093] Change the spring boot example to use samples par...
Github user johnament commented on the issue: https://github.com/apache/cxf/pull/183 Sorry - just realized the commits weren't squashed. Fixed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
