[GitHub] reta commented on issue #339: CXF-7544: Support @Context-based injection into proxied CDI beans
reta commented on issue #339: CXF-7544: Support @Context-based injection into proxied CDI beans URL: https://github.com/apache/cxf/pull/339#issuecomment-344591904 Better solution is required, closing This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] reta commented on issue #339: CXF-7544: Support @Context-based injection into proxied CDI beans
reta commented on issue #339: CXF-7544: Support @Context-based injection into proxied CDI beans URL: https://github.com/apache/cxf/pull/339#issuecomment-344359630 @rmannibucau Thank a lot for the advice, I will try the implementation with `@AroundInvoke`, the `ServerProviderfactory` sadly is not a singleton but per-factory bean (so there could be more than one) ... Anyway, this is something very CXFy, figuring out the way to do that :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] reta commented on issue #339: CXF-7544: Support @Context-based injection into proxied CDI beans
reta commented on issue #339: CXF-7544: Support @Context-based injection into proxied CDI beans URL: https://github.com/apache/cxf/pull/339#issuecomment-344359630 @rmannibucau Thank a lot for the advice, I will retry the implementation with `@AroundInvoke`, the `ServerProviderfactory` sadly is not a singleton but per-factory bean (so there could be more than one) ... Anyway, this is something very CXFy, figuring out the way to do that :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] reta commented on issue #339: CXF-7544: Support @Context-based injection into proxied CDI beans
reta commented on issue #339: CXF-7544: Support @Context-based injection into proxied CDI beans URL: https://github.com/apache/cxf/pull/339#issuecomment-344284976 @rmannibucau Yes, I tried this approach first thing (and would very likely complement this PR to handle the `@Context` arguments in constructors). The issue I hit hard is that I couldn't trace back the `ServerProviderFactory` to use for constructor injection :( Plus, the `InvocationContext::target` is set to `null` so I don't have access to the instance being constructed (very likely because ?? is being constructed indeed). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] reta commented on issue #339: CXF-7544: Support @Context-based injection into proxied CDI beans
reta commented on issue #339: CXF-7544: Support @Context-based injection into proxied CDI beans URL: https://github.com/apache/cxf/pull/339#issuecomment-344284976 @rmannibucau Yes, I tried this approach first thing (and would very likely complement this PR to handle the `@Context` arguments in constructors). The issue I hit hard is that I couldn't trace back the `ServerProviderFactory` to use for constructor injection :( Plus, the `InvocationContext::target` is set to `null` so I don't have access to the instance being constructed (very likely because it is being constructed indeed). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] reta commented on issue #339: CXF-7544: Support @Context-based injection into proxied CDI beans
reta commented on issue #339: CXF-7544: Support @Context-based injection into proxied CDI beans URL: https://github.com/apache/cxf/pull/339#issuecomment-344284976 @rmannibucau Yes, I tried this approach first thing (and would very likely complement this PR to handle the `@Context` arguments in constructors). The issue I hit hard is that I couldn't trace back the `ServerProviderFactory` to use for constructor injection :( Plus, the `InvocationContext::target` is set to `null` so I don't have access to the instance being constructed (very likely because is being constructed indeed). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] reta commented on issue #339: CXF-7544: Support @Context-based injection into proxied CDI beans
reta commented on issue #339: CXF-7544: Support @Context-based injection into proxied CDI beans URL: https://github.com/apache/cxf/pull/339#issuecomment-344261613 @johnament @sberyozkin @rmannibucau could you guys take a look? The are few things I don't like (but don't have a better idea yet how to implement). The PR solves the simplest case with field injection (at the moment). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
