Re: [cxf] branch master updated: update swagger-core to latest version
Hi Dennis Np, sometimes I miss the failures as well :-). As I said earlier, it looks like 1.5.18 went to a pre 1.5.16 model. The Swagger 2 to Open Api conversion test does pass with 1.5.18 in 3.1.x but note the conversion filter is diff betweem 3.1.x and the master; in 3.1.x, in ContainerResponseFilter it sees Swagger instance as a response body, on the master it sees a String... Thanks Sergey On 01/02/18 14:43, Dennis Kieselhorst wrote: Hi Sergey, my bad I wasn't able to run all tests locally. The ServerLauncher class produces a long classpath resulting in CreateProcess error=206 on my current environment. In general it looked fine and I thought Jenkins will run the testcases as well. So let's use 1.5.17 for 3.2.2 and I'll try to resolve the issues later on when I can reproduce then. Cheers Dennis
Re: [cxf] branch master updated: update swagger-core to latest version
Hi Sergey, my bad I wasn't able to run all tests locally. The ServerLauncher class produces a long classpath resulting in CreateProcess error=206 on my current environment. In general it looked fine and I thought Jenkins will run the testcases as well. So let's use 1.5.17 for 3.2.2 and I'll try to resolve the issues later on when I can reproduce then. Cheers Dennis
Re: [cxf] branch master updated: update swagger-core to latest version
FYI, that jenkins job did not reach these tests: [INFO] Apache CXF JAX-RS System Tests . SKIPPED On 01/02/18 14:24, Sergey Beryozkin wrote: Hi Dennis All related tests in systests/jaxrs fail if I run then directly from systests/jaxrs: [ERROR] Errors: [ERROR] Swagger2CustomPropertiesTest.testApiListingIsProperlyReturnedJSON:67->AbstractSwagger2ServiceDescriptionTest.doTestApiListingIsProperlyReturnedJSON:134->AbstractSwagger2ServiceDescriptionTest.doTestApiListingIsProperlyReturnedJSON:137->AbstractSwagger2ServiceDescriptionTest.doTestApiListingIsProperlyReturnedJSON:148 » NullPointer [ERROR] Swagger2FilterServiceDescriptionTest.testApiListingIsProperlyReturnedJSON:54->AbstractSwagger2ServiceDescriptionTest.doTestApiListingIsProperlyReturnedJSON:134->AbstractSwagger2ServiceDescriptionTest.doTestApiListingIsProperlyReturnedJSON:137->AbstractSwagger2ServiceDescriptionTest.doTestApiListingIsProperlyReturnedJSON:148 » NullPointer [ERROR] Swagger2NonAnnotatedServiceDescriptionTest.testApiListingIsProperlyReturnedJSON:76->AbstractSwagger2ServiceDescriptionTest.doTestApiListingIsProperlyReturnedJSON:134->AbstractSwagger2ServiceDescriptionTest.doTestApiListingIsProperlyReturnedJSON:137->AbstractSwagger2ServiceDescriptionTest.doTestApiListingIsProperlyReturnedJSON:148 » NullPointer [ERROR] Swagger2RegularServiceDescriptionTest.testApiListingIsProperlyReturnedJSON:54->AbstractSwagger2ServiceDescriptionTest.doTestApiListingIsProperlyReturnedJSON:134->AbstractSwagger2ServiceDescriptionTest.doTestApiListingIsProperlyReturnedJSON:137->AbstractSwagger2ServiceDescriptionTest.doTestApiListingIsProperlyReturnedJSON:148 » NullPointer [ERROR] Swagger2XForwardedDescriptionTest.testApiListingIsProperlyReturnedJSON:38->AbstractSwagger2ServiceDescriptionTest.doTestApiListingIsProperlyReturnedJSON:134->AbstractSwagger2ServiceDescriptionTest.doTestApiListingIsProperlyReturnedJSON:137->AbstractSwagger2ServiceDescriptionTest.doTestApiListingIsProperlyReturnedJSON:147 » InternalServerError [ERROR] Swagger2XForwardedDescriptionTest.testApiListingIsProperlyReturnedJSONXForwarded:43->AbstractSwagger2ServiceDescriptionTest.doTestApiListingIsProperlyReturnedJSON:137->AbstractSwagger2ServiceDescriptionTest.doTestApiListingIsProperlyReturnedJSON:147 » InternalServerError [ERROR] SwaggerToOpenApiConversionTest.testOpenApiJSON:104 » InternalServerError HTTP ... Can you try the same please ? Thanks, Sergey On 01/02/18 14:10, Sergey Beryozkin wrote: Hi Dennis All Swagger 2 tests in systests/jaxrs... Let me rebuild everything and try again Thanks, Sergey On 01/02/18 14:04, Dennis Kieselhorst wrote: Hi Sergey, which tests are failing for you? I don't see any related test failures here: https://builds.apache.org/view/A-D/view/CXF/job/CXF-Trunk-JDK18/lastCompletedBuild/testReport/ They fixed pretty print (https://github.com/swagger-api/swagger-core/issues/2320) and read only properties (https://github.com/swagger-api/swagger-core/pull/2502). Moreover the Jackson version was aligned (https://github.com/swagger-api/swagger-core/pull/2576). That's why I thought it's a good idea to update. Cheers Dennis
Re: [cxf] branch master updated: update swagger-core to latest version
Hi Dennis All related tests in systests/jaxrs fail if I run then directly from systests/jaxrs: [ERROR] Errors: [ERROR] Swagger2CustomPropertiesTest.testApiListingIsProperlyReturnedJSON:67->AbstractSwagger2ServiceDescriptionTest.doTestApiListingIsProperlyReturnedJSON:134->AbstractSwagger2ServiceDescriptionTest.doTestApiListingIsProperlyReturnedJSON:137->AbstractSwagger2ServiceDescriptionTest.doTestApiListingIsProperlyReturnedJSON:148 » NullPointer [ERROR] Swagger2FilterServiceDescriptionTest.testApiListingIsProperlyReturnedJSON:54->AbstractSwagger2ServiceDescriptionTest.doTestApiListingIsProperlyReturnedJSON:134->AbstractSwagger2ServiceDescriptionTest.doTestApiListingIsProperlyReturnedJSON:137->AbstractSwagger2ServiceDescriptionTest.doTestApiListingIsProperlyReturnedJSON:148 » NullPointer [ERROR] Swagger2NonAnnotatedServiceDescriptionTest.testApiListingIsProperlyReturnedJSON:76->AbstractSwagger2ServiceDescriptionTest.doTestApiListingIsProperlyReturnedJSON:134->AbstractSwagger2ServiceDescriptionTest.doTestApiListingIsProperlyReturnedJSON:137->AbstractSwagger2ServiceDescriptionTest.doTestApiListingIsProperlyReturnedJSON:148 » NullPointer [ERROR] Swagger2RegularServiceDescriptionTest.testApiListingIsProperlyReturnedJSON:54->AbstractSwagger2ServiceDescriptionTest.doTestApiListingIsProperlyReturnedJSON:134->AbstractSwagger2ServiceDescriptionTest.doTestApiListingIsProperlyReturnedJSON:137->AbstractSwagger2ServiceDescriptionTest.doTestApiListingIsProperlyReturnedJSON:148 » NullPointer [ERROR] Swagger2XForwardedDescriptionTest.testApiListingIsProperlyReturnedJSON:38->AbstractSwagger2ServiceDescriptionTest.doTestApiListingIsProperlyReturnedJSON:134->AbstractSwagger2ServiceDescriptionTest.doTestApiListingIsProperlyReturnedJSON:137->AbstractSwagger2ServiceDescriptionTest.doTestApiListingIsProperlyReturnedJSON:147 » InternalServerError [ERROR] Swagger2XForwardedDescriptionTest.testApiListingIsProperlyReturnedJSONXForwarded:43->AbstractSwagger2ServiceDescriptionTest.doTestApiListingIsProperlyReturnedJSON:137->AbstractSwagger2ServiceDescriptionTest.doTestApiListingIsProperlyReturnedJSON:147 » InternalServerError [ERROR] SwaggerToOpenApiConversionTest.testOpenApiJSON:104 » InternalServerError HTTP ... Can you try the same please ? Thanks, Sergey On 01/02/18 14:10, Sergey Beryozkin wrote: Hi Dennis All Swagger 2 tests in systests/jaxrs... Let me rebuild everything and try again Thanks, Sergey On 01/02/18 14:04, Dennis Kieselhorst wrote: Hi Sergey, which tests are failing for you? I don't see any related test failures here: https://builds.apache.org/view/A-D/view/CXF/job/CXF-Trunk-JDK18/lastCompletedBuild/testReport/ They fixed pretty print (https://github.com/swagger-api/swagger-core/issues/2320) and read only properties (https://github.com/swagger-api/swagger-core/pull/2502). Moreover the Jackson version was aligned (https://github.com/swagger-api/swagger-core/pull/2576). That's why I thought it's a good idea to update. Cheers Dennis
Re: [cxf] branch master updated: update swagger-core to latest version
Hi Dennis All Swagger 2 tests in systests/jaxrs... Let me rebuild everything and try again Thanks, Sergey On 01/02/18 14:04, Dennis Kieselhorst wrote: Hi Sergey, which tests are failing for you? I don't see any related test failures here: https://builds.apache.org/view/A-D/view/CXF/job/CXF-Trunk-JDK18/lastCompletedBuild/testReport/ They fixed pretty print (https://github.com/swagger-api/swagger-core/issues/2320) and read only properties (https://github.com/swagger-api/swagger-core/pull/2502). Moreover the Jackson version was aligned (https://github.com/swagger-api/swagger-core/pull/2576). That's why I thought it's a good idea to update. Cheers Dennis
Re: [cxf] branch master updated: update swagger-core to latest version
Hi Sergey, which tests are failing for you? I don't see any related test failures here: https://builds.apache.org/view/A-D/view/CXF/job/CXF-Trunk-JDK18/lastCompletedBuild/testReport/ They fixed pretty print (https://github.com/swagger-api/swagger-core/issues/2320) and read only properties (https://github.com/swagger-api/swagger-core/pull/2502). Moreover the Jackson version was aligned (https://github.com/swagger-api/swagger-core/pull/2576). That's why I thought it's a good idea to update. Cheers Dennis
Re: [cxf] branch master updated: update swagger-core to latest version
I've reverted back to 1.5.17 as I see systests failing with it. FYI, tests pass OK with 1.5.18 in 3.1.x which stayed at 1.5.12. In 3.1.x we retained the the same feature code but on the master, when upgrading to 1.5.16 (?) we had to change that as the same model did nnot work anymore. Now it appears 1.5.18 has changed internally to the older per 1.5.16 model. IMHO, it only makes sense to move to newer 1.5.x versions when it can bring something new to the users, rewriting Swagger2Feature with every swagger-jaxrs/core 1.5.x iteration seems a bit too much :-) Thanks, Sergey On 01/02/18 09:33, Sergey Beryozkin wrote: Hi Dennis We were looking with Francesco at this version and saw some issues, do systest/jaxrs tests pass for you ? Thanks, Sergey On 01/02/18 09:30, d...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. deki pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cxf.git The following commit(s) were added to refs/heads/master by this push: new 2cd77ba update swagger-core to latest version 2cd77ba is described below commit 2cd77bae06fc51ef2bc6d7679db1fdf6e9476af1 Author: Dennis Kieselhorst AuthorDate: Thu Feb 1 10:30:00 2018 +0100 update swagger-core to latest version --- parent/pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/parent/pom.xml b/parent/pom.xml index 9c80f55..ea4516d 100644 --- a/parent/pom.xml +++ b/parent/pom.xml @@ -159,7 +159,7 @@ 1.2.1 2.3.2.RELEASE spring-test - 1.5.17 + 1.5.18 2.0.0-rc4 3.9.2 2.0
Re: [cxf] branch master updated: update swagger-core to latest version
Hi Dennis We were looking with Francesco at this version and saw some issues, do systest/jaxrs tests pass for you ? Thanks, Sergey On 01/02/18 09:30, d...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. deki pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cxf.git The following commit(s) were added to refs/heads/master by this push: new 2cd77ba update swagger-core to latest version 2cd77ba is described below commit 2cd77bae06fc51ef2bc6d7679db1fdf6e9476af1 Author: Dennis Kieselhorst AuthorDate: Thu Feb 1 10:30:00 2018 +0100 update swagger-core to latest version --- parent/pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/parent/pom.xml b/parent/pom.xml index 9c80f55..ea4516d 100644 --- a/parent/pom.xml +++ b/parent/pom.xml @@ -159,7 +159,7 @@ 1.2.1 2.3.2.RELEASE spring-test -1.5.17 +1.5.18 2.0.0-rc4 3.9.2 2.0
