[jira] [Updated] (DATAFU-95) Improve wrong JDK error message
[
https://issues.apache.org/jira/browse/DATAFU-95?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthew Hayes updated DATAFU-95:
Fix Version/s: 1.3.1
> Improve wrong JDK error message
> ---
>
> Key: DATAFU-95
> URL: https://issues.apache.org/jira/browse/DATAFU-95
> Project: DataFu
> Issue Type: Improvement
>Reporter: Jakob Homan
>Assignee: Matthew Hayes
>Priority: Minor
> Fix For: 1.3.1
>
>
> Right now if one tries to build against JDK1.7, the resulting failure is a
> bit unclear:
> {noformat}Download
> https://repo1.maven.org/maven2/org/eclipse/equinox/app/1.3.200-v20130910-1609/app-1.3.200-v20130910-1609.jar
> /Users/jahoman/repos/datafu/build-plugin/src/main/java/org/adrianwalker/multilinestring/MultilineProcessor.java:18:
> error: cannot find symbol
> @SupportedSourceVersion(SourceVersion.RELEASE_8)
> ^
> symbol: variable RELEASE_8
> location: class SourceVersion
> 1 error
> :build-plugin:compileJava FAILED
> FAILURE: Build failed with an exception.
> {noformat}
> It may be better to use something like [The
> Sweeney|https://github.com/boxheed/gradle-sweeney-plugin] to enforce this and
> provide a better, faster message on failure.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (DATAFU-95) Improve wrong JDK error message
[
https://issues.apache.org/jira/browse/DATAFU-95?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthew Hayes reassigned DATAFU-95:
---
Assignee: Matthew Hayes
> Improve wrong JDK error message
> ---
>
> Key: DATAFU-95
> URL: https://issues.apache.org/jira/browse/DATAFU-95
> Project: DataFu
> Issue Type: Improvement
>Reporter: Jakob Homan
>Assignee: Matthew Hayes
>Priority: Minor
> Fix For: 1.3.1
>
>
> Right now if one tries to build against JDK1.7, the resulting failure is a
> bit unclear:
> {noformat}Download
> https://repo1.maven.org/maven2/org/eclipse/equinox/app/1.3.200-v20130910-1609/app-1.3.200-v20130910-1609.jar
> /Users/jahoman/repos/datafu/build-plugin/src/main/java/org/adrianwalker/multilinestring/MultilineProcessor.java:18:
> error: cannot find symbol
> @SupportedSourceVersion(SourceVersion.RELEASE_8)
> ^
> symbol: variable RELEASE_8
> location: class SourceVersion
> 1 error
> :build-plugin:compileJava FAILED
> FAILURE: Build failed with an exception.
> {noformat}
> It may be better to use something like [The
> Sweeney|https://github.com/boxheed/gradle-sweeney-plugin] to enforce this and
> provide a better, faster message on failure.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (DATAFU-114) Make FirstTupleFromBag implement Accumulator
[ https://issues.apache.org/jira/browse/DATAFU-114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthew Hayes updated DATAFU-114: - Assignee: Eyal Allweil > Make FirstTupleFromBag implement Accumulator > > > Key: DATAFU-114 > URL: https://issues.apache.org/jira/browse/DATAFU-114 > Project: DataFu > Issue Type: Improvement >Affects Versions: 1.3.0 > Environment: All >Reporter: Eyal Allweil >Assignee: Eyal Allweil >Priority: Minor > Labels: easyfix, newbie, performance > Fix For: 1.3.1 > > Attachments: FirstTupleFromBag.java > > > FirstTupleFromBag only needs the first tuple from the bag, but because it > doesn't implement Accumulator the entire bag needs to be passed to it > in-memory. The fix is very minor and will make the UDF support large bags. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DATAFU-114) Make FirstTupleFromBag implement Accumulator
[ https://issues.apache.org/jira/browse/DATAFU-114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133456#comment-15133456 ] Matthew Hayes commented on DATAFU-114: -- Try the patch in DATAFU-95 I just attached and see if that helps your build issue. It should work with JDK 1.7 now. By the way, I've had good success switching Java versions using jenv (https://github.com/gcuisinier/jenv). Haven't tried it on Ubuntu but it seems like it would work. Also in the future a patch+RB makes it easier to review and apply the changes. > Make FirstTupleFromBag implement Accumulator > > > Key: DATAFU-114 > URL: https://issues.apache.org/jira/browse/DATAFU-114 > Project: DataFu > Issue Type: Improvement >Affects Versions: 1.3.0 > Environment: All >Reporter: Eyal Allweil >Priority: Minor > Labels: easyfix, newbie, performance > Fix For: 1.3.1 > > Attachments: FirstTupleFromBag.java > > > FirstTupleFromBag only needs the first tuple from the bag, but because it > doesn't implement Accumulator the entire bag needs to be passed to it > in-memory. The fix is very minor and will make the UDF support large bags. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (DATAFU-114) Make FirstTupleFromBag implement Accumulator
[ https://issues.apache.org/jira/browse/DATAFU-114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthew Hayes updated DATAFU-114: - Fix Version/s: 1.3.1 > Make FirstTupleFromBag implement Accumulator > > > Key: DATAFU-114 > URL: https://issues.apache.org/jira/browse/DATAFU-114 > Project: DataFu > Issue Type: Improvement >Affects Versions: 1.3.0 > Environment: All >Reporter: Eyal Allweil >Priority: Minor > Labels: easyfix, newbie, performance > Fix For: 1.3.1 > > Attachments: FirstTupleFromBag.java > > > FirstTupleFromBag only needs the first tuple from the bag, but because it > doesn't implement Accumulator the entire bag needs to be passed to it > in-memory. The fix is very minor and will make the UDF support large bags. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Review Request 43235: DATAFU-95: Improve wrong JDK error message
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43235/ --- Review request for DataFu. Repository: datafu Description --- Use @SupportedSourceVersion(SourceVersion.RELEASE_7) in MultilineProcessor.java. It doesn't seem there was any need to require RELEASE_8. Ensure build-plugin is built (except when releasing to maven), as otherwise we can't run tests in Eclipse. Add sweeney to check JDK 1.7 is used. Bump the datafu version to 1.3.1 as this was missed after the last release. Diffs - build-plugin/build.gradle e7a38ce build-plugin/src/main/java/org/adrianwalker/multilinestring/MultilineProcessor.java ab3fa27 build.gradle 97ab950 datafu-hourglass/src/main/java/datafu/hourglass/jobs/AbstractJob.java 16679f3 datafu-pig/.gitignore fe4962d gradle.properties 9e3bd2f gradle/buildscript.gradle 10b8ca4 Diff: https://reviews.apache.org/r/43235/diff/ Testing --- Thanks, Matthew Hayes
[jira] [Commented] (DATAFU-114) Make FirstTupleFromBag implement Accumulator
[
https://issues.apache.org/jira/browse/DATAFU-114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133366#comment-15133366
]
Matthew Hayes commented on DATAFU-114:
--
Sorry for the late response. The change looks reasonable to me. There should
be a test for this though (understandable there isn't one since you couldn't
build it). I went ahead and wrote one below. If this test looks reasonable to
you I'll commit both pieces of code. I'm taking a look at DATAFU-95.
{code}
@Test
public void firstTupleFromBagAccumulateTest() throws Exception
{
TupleFactory tf = TupleFactory.getInstance();
BagFactory bf = BagFactory.getInstance();
FirstTupleFromBag op = new FirstTupleFromBag();
Tuple defaultValue = tf.newTuple(1000);
op.accumulate(tf.newTuple(Arrays.asList(bf.newDefaultBag(Arrays.asList(tf.newTuple(4))),
defaultValue)));
op.accumulate(tf.newTuple(Arrays.asList(bf.newDefaultBag(Arrays.asList(tf.newTuple(9))),
defaultValue)));
op.accumulate(tf.newTuple(Arrays.asList(bf.newDefaultBag(Arrays.asList(tf.newTuple(16))),
defaultValue)));
assertEquals(op.getValue(), tf.newTuple(4));
op.cleanup();
op.accumulate(tf.newTuple(Arrays.asList(bf.newDefaultBag(Arrays.asList(tf.newTuple(11))),
defaultValue)));
op.accumulate(tf.newTuple(Arrays.asList(bf.newDefaultBag(Arrays.asList(tf.newTuple(17))),
defaultValue)));
op.accumulate(tf.newTuple(Arrays.asList(bf.newDefaultBag(Arrays.asList(tf.newTuple(5))),
defaultValue)));
assertEquals(op.getValue(), tf.newTuple(11));
op.cleanup();
op.accumulate(tf.newTuple(Arrays.asList(bf.newDefaultBag(), defaultValue)));
assertEquals(op.getValue(), defaultValue);
op.cleanup();
}
{code}
> Make FirstTupleFromBag implement Accumulator
>
>
> Key: DATAFU-114
> URL: https://issues.apache.org/jira/browse/DATAFU-114
> Project: DataFu
> Issue Type: Improvement
>Affects Versions: 1.3.0
> Environment: All
>Reporter: Eyal Allweil
>Priority: Minor
> Labels: easyfix, newbie, performance
> Attachments: FirstTupleFromBag.java
>
>
> FirstTupleFromBag only needs the first tuple from the bag, but because it
> doesn't implement Accumulator the entire bag needs to be passed to it
> in-memory. The fix is very minor and will make the UDF support large bags.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DATAFU-114) Make FirstTupleFromBag implement Accumulator
[ https://issues.apache.org/jira/browse/DATAFU-114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15131991#comment-15131991 ] Eyal Allweil commented on DATAFU-114: - Anyone? > Make FirstTupleFromBag implement Accumulator > > > Key: DATAFU-114 > URL: https://issues.apache.org/jira/browse/DATAFU-114 > Project: DataFu > Issue Type: Improvement >Affects Versions: 1.3.0 > Environment: All >Reporter: Eyal Allweil >Priority: Minor > Labels: easyfix, newbie, performance > Attachments: FirstTupleFromBag.java > > > FirstTupleFromBag only needs the first tuple from the bag, but because it > doesn't implement Accumulator the entire bag needs to be passed to it > in-memory. The fix is very minor and will make the UDF support large bags. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
