[ 
https://issues.apache.org/jira/browse/DATAFU-123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eyal Allweil updated DATAFU-123:
--------------------------------
    Attachment: DATAFU-123.patch

The change ended up being smaller than what I originally described - all I did 
was add the "pig.import.search.path" property with the value of the 
src/main/resources directory to PigTests.

This means that any macro files that are put there can be tested, both in 
Gradle and Eclipse. I put some sample counting macros there and a test for them.

In general, any macro file placed in src/main/resources can be used by 
registering the DataFu jar.

If we include this patch, we should update the Contributing page so that 
instructions for contributing Pig macros are easy to find and understand.

> Allow DataFu to include macros 
> -------------------------------
>
>                 Key: DATAFU-123
>                 URL: https://issues.apache.org/jira/browse/DATAFU-123
>             Project: DataFu
>          Issue Type: Improvement
>            Reporter: Eyal Allweil
>            Assignee: Eyal Allweil
>              Labels: testability
>         Attachments: DATAFU-123.patch
>
>
> A few changes to allow macros to be contributed to DataFu. If a macro file is 
> placed in src/main/resources, it can be used by registering the DataFu jar. 
> Such macros can then be tested both from within Eclipse and Gradle.
> There are three small parts:
> 1) All unit tests that use createPigTest methods will automatically register 
> the DataFu jar.
> 2) Some changes to fix the PigTests.getJarPath() functionality, which doesn't 
> appear to work. (these changes are aligned with the proposed patch for 
> [DATAFU-106|https://issues.apache.org/jira/browse/DATAFU-106])
> 3) A sample macro and test
> The changes here will allow moving forward with 
> [DATAFU-61|https://issues.apache.org/jira/browse/DATAFU-61] and including the 
> macro I suggested for 
> [DATAFU-119|https://issues.apache.org/jira/browse/DATAFU-119]. (I also have 
> additional content in mind)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to