[jira] [Commented] (DATAFU-125) Upgrade Gradle to v4 or later

2017-10-20 Thread Matthew Hayes (JIRA) 

[ 
https://issues.apache.org/jira/browse/DATAFU-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212978#comment-16212978
 ] 

Matthew Hayes commented on DATAFU-125:
--

Great!  The other things I would check are these from RELEASE.md.

{noformat}
./gradlew check
./gradlew clean release -Prelease=true
{noformat}

These ensure we won't run into issues doing our next release.  I think this 
should be sufficient testing to merge this change in.  We can hold off on doing 
the upgrade to Gradle 4. I'm okay with changing the title of this JIRA to 
"Upgrade to Gradle v3 or later."  My intention was to get us on a newer version 
since we're so behind.  Upgrading to Gradle 4 will be trickier due to the 
autojar issue you found.



> Upgrade Gradle to v4 or later
> -
>
> Key: DATAFU-125
> URL: https://issues.apache.org/jira/browse/DATAFU-125
> Project: DataFu
>  Issue Type: Task
>Reporter: Matthew Hayes
> Attachments: DATAFU-125.patch
>
>
> We should update to the most recent version of Gradle.  We're currently using 
> 2.4.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (DATAFU-125) Upgrade Gradle to v4 or later

2017-10-21 Thread Eyal Allweil (JIRA) 

[ 
https://issues.apache.org/jira/browse/DATAFU-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16214208#comment-16214208
 ] 

Eyal Allweil commented on DATAFU-125:
-

_check_ and _clean release_ run and return SUCCESS. Are there any special files 
I should check that are the result of the _release_ task?

I also ran a script on the packaged jar (the regular one, not core or the 
jarjar) and it ran fine.

> Upgrade Gradle to v4 or later
> -
>
> Key: DATAFU-125
> URL: https://issues.apache.org/jira/browse/DATAFU-125
> Project: DataFu
>  Issue Type: Task
>Reporter: Matthew Hayes
> Attachments: DATAFU-125.patch
>
>
> We should update to the most recent version of Gradle.  We're currently using 
> 2.4.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (DATAFU-125) Upgrade Gradle to v4 or later

2017-10-25 Thread Matthew Hayes (JIRA) 

[ 
https://issues.apache.org/jira/browse/DATAFU-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16219834#comment-16219834
 ] 

Matthew Hayes commented on DATAFU-125:
--

The only thing I can think of checking is to take the zip package created by 
release, unzip it, and make sure you can build the jar from that source.  If 
that works then I say go ahead and merge this in.  +1

> Upgrade Gradle to v4 or later
> -
>
> Key: DATAFU-125
> URL: https://issues.apache.org/jira/browse/DATAFU-125
> Project: DataFu
>  Issue Type: Task
>Reporter: Matthew Hayes
> Attachments: DATAFU-125.patch
>
>
> We should update to the most recent version of Gradle.  We're currently using 
> 2.4.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (DATAFU-125) Upgrade Gradle to v4 or later

2017-10-26 Thread Eyal Allweil (JIRA) 

[ 
https://issues.apache.org/jira/browse/DATAFU-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16220371#comment-16220371
 ] 

Eyal Allweil commented on DATAFU-125:
-

When I build with _./gradlew clean release -Prelease=true_, I don't get a zip 
file. In fact, I don't get jars either - I need to use _assemble_ to make them 
(both on master with and without upgrading Gradle). Am I using the wrong 
command? Does it work for you, [~matterhayes]?

> Upgrade Gradle to v4 or later
> -
>
> Key: DATAFU-125
> URL: https://issues.apache.org/jira/browse/DATAFU-125
> Project: DataFu
>  Issue Type: Task
>Reporter: Matthew Hayes
>Assignee: Eyal Allweil
> Attachments: DATAFU-125.patch
>
>
> We should update to the most recent version of Gradle.  We're currently using 
> 2.4.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (DATAFU-125) Upgrade Gradle to v4 or later

2017-11-27 Thread Matthew Hayes (JIRA) 

[ 
https://issues.apache.org/jira/browse/DATAFU-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267858#comment-16267858
 ] 

Matthew Hayes commented on DATAFU-125:
--

Sorry, instead of zip I should have said tgz.  When you run {{./gradlew clean 
release -Prelease=true}} it should produce a tgz file at 
{{build/distribution/source}} containing the source code.  If you copy this 
somewhere else and extract it you should be able to run {{./gradlew assemble}} 
to build the jars.

I'll go ahead and test this change now to confirm this works.  If it does I'll 
merge in the change for you.

> Upgrade Gradle to v4 or later
> -
>
> Key: DATAFU-125
> URL: https://issues.apache.org/jira/browse/DATAFU-125
> Project: DataFu
>  Issue Type: Task
>Reporter: Matthew Hayes
>Assignee: Eyal Allweil
> Attachments: DATAFU-125.patch
>
>
> We should update to the most recent version of Gradle.  We're currently using 
> 2.4.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (DATAFU-125) Upgrade Gradle to v4 or later

2017-11-27 Thread Matthew Hayes (JIRA) 

[ 
https://issues.apache.org/jira/browse/DATAFU-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267883#comment-16267883
 ] 

Matthew Hayes commented on DATAFU-125:
--

When I tried applying this change it wasn't running Gradle 3.5.1 as intended 
when I tested with {{./gradlew --version}}.  It was still running 2.4 for me.  
I think the issue is that we should be {{gradle.properties}} instead.  Also we 
should delete these files:

{noformat}
gradle/wrapper/gradle-wrapper.jar
gradle/wrapper/gradle-wrapper.properties
gradlew
{noformat}

These files can all be generated by running {{gradle -b bootstrap.gradle}}.  
Whenever you change the gradle version in {{gradle.properties}} you can rerun 
this bootstrap command to update the gradle version.  It was probably a mistake 
to have these three files checked in.

> Upgrade Gradle to v4 or later
> -
>
> Key: DATAFU-125
> URL: https://issues.apache.org/jira/browse/DATAFU-125
> Project: DataFu
>  Issue Type: Task
>Reporter: Matthew Hayes
>Assignee: Eyal Allweil
> Attachments: DATAFU-125.patch
>
>
> We should update to the most recent version of Gradle.  We're currently using 
> 2.4.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (DATAFU-125) Upgrade Gradle to v4 or later

2017-11-27 Thread Matthew Hayes (JIRA) 

[ 
https://issues.apache.org/jira/browse/DATAFU-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267895#comment-16267895
 ] 

Matthew Hayes commented on DATAFU-125:
--

Testing done with new patch:

1) Ran {{./gradlew clean release -Prelease=true}} to build tgz.
2) Extracted tgz to new directory and ran {{gradle -b bootstrap.gradle}}.
3) Ran {{./gradlew --version}} and confirmed version is 3.5.1.
4) Ran {{./gradlew assemble}}.  Confirmed JARs are built.

> Upgrade Gradle to v4 or later
> -
>
> Key: DATAFU-125
> URL: https://issues.apache.org/jira/browse/DATAFU-125
> Project: DataFu
>  Issue Type: Task
>Reporter: Matthew Hayes
>Assignee: Eyal Allweil
> Attachments: DATAFU-125-v2.patch, DATAFU-125.patch
>
>
> We should update to the most recent version of Gradle.  We're currently using 
> 2.4.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)