[jira] [Commented] (DATAFU-48) Upgrade Guava to 17.0

2017-10-25 Thread Matthew Hayes (JIRA)

[ 
https://issues.apache.org/jira/browse/DATAFU-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219828#comment-16219828
 ] 

Matthew Hayes commented on DATAFU-48:
-

Great thanks for checking.

> Upgrade Guava to 17.0
> -
>
> Key: DATAFU-48
> URL: https://issues.apache.org/jira/browse/DATAFU-48
> Project: DataFu
>  Issue Type: Improvement
>Reporter: Philip (flip) Kromer
>Assignee: Philip (flip) Kromer
>Priority: Minor
>  Labels: build, dependency, guava, version
> Attachments: 0001-DATAFU-48-Upgrade-gradle-to-17.0.patch, 
> DATAFU-48-update-gradle-to-20.0.patch
>
>
> Specifically motivated by the improvements to hashing library, but also 
> because we're six versions behind at the moment.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (DATAFU-48) Upgrade Guava to 17.0

2017-10-22 Thread Eyal Allweil (JIRA)

[ 
https://issues.apache.org/jira/browse/DATAFU-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16214212#comment-16214212
 ] 

Eyal Allweil commented on DATAFU-48:


As an additional check, I ran a Pig script which uses 
_SimpleRandomSampleWithReplacementVote_ (which uses Guava) to see that it still 
runs correctly.

> Upgrade Guava to 17.0
> -
>
> Key: DATAFU-48
> URL: https://issues.apache.org/jira/browse/DATAFU-48
> Project: DataFu
>  Issue Type: Improvement
>Reporter: Philip (flip) Kromer
>Assignee: Philip (flip) Kromer
>Priority: Minor
>  Labels: build, dependency, guava, version
> Attachments: 0001-DATAFU-48-Upgrade-gradle-to-17.0.patch, 
> DATAFU-48-update-gradle-to-20.0.patch
>
>
> Specifically motivated by the improvements to hashing library, but also 
> because we're six versions behind at the moment.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (DATAFU-48) Upgrade Guava to 17.0

2017-10-20 Thread Matthew Hayes (JIRA)

[ 
https://issues.apache.org/jira/browse/DATAFU-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16213002#comment-16213002
 ] 

Matthew Hayes commented on DATAFU-48:
-

+1 patch to upgrade to guava 20.0 looks good to me.

> Upgrade Guava to 17.0
> -
>
> Key: DATAFU-48
> URL: https://issues.apache.org/jira/browse/DATAFU-48
> Project: DataFu
>  Issue Type: Improvement
>Reporter: Philip (flip) Kromer
>Assignee: Philip (flip) Kromer
>Priority: Minor
>  Labels: build, dependency, guava, version
> Attachments: 0001-DATAFU-48-Upgrade-gradle-to-17.0.patch, 
> DATAFU-48-update-gradle-to-20.0.patch
>
>
> Specifically motivated by the improvements to hashing library, but also 
> because we're six versions behind at the moment.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (DATAFU-48) Upgrade Guava to 17.0

2017-10-20 Thread Matthew Hayes (JIRA)

[ 
https://issues.apache.org/jira/browse/DATAFU-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16212998#comment-16212998
 ] 

Matthew Hayes commented on DATAFU-48:
-

I don't remember what the symptom was.  Looking at the {{build.gradle}}, guava 
is being autojarred into the JAR:

{noformat}
autojarred "com.google.guava:guava:$guavaVersion"
{noformat}

Also the namespace is changed to avoid conflict.

{noformat}
rule pattern: "com.google.common.**", result: "datafu.com.google.common.@1"
{noformat}

So, this shouldn't cause any runtime issue when trying to use the JAR in 
Hadoop.  Maybe it was a build issue before.  If you're able to run the tests 
successfully then it seems there is no issue now.

> Upgrade Guava to 17.0
> -
>
> Key: DATAFU-48
> URL: https://issues.apache.org/jira/browse/DATAFU-48
> Project: DataFu
>  Issue Type: Improvement
>Reporter: Philip (flip) Kromer
>Assignee: Philip (flip) Kromer
>Priority: Minor
>  Labels: build, dependency, guava, version
> Attachments: 0001-DATAFU-48-Upgrade-gradle-to-17.0.patch, 
> DATAFU-48-update-gradle-to-20.0.patch
>
>
> Specifically motivated by the improvements to hashing library, but also 
> because we're six versions behind at the moment.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (DATAFU-48) Upgrade Guava to 17.0

2017-10-19 Thread Eyal Allweil (JIRA)

[ 
https://issues.apache.org/jira/browse/DATAFU-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16210769#comment-16210769
 ] 

Eyal Allweil commented on DATAFU-48:


None, actually. Hadoop 1 and 2 are using 11.0.2, like us. Hadoop 3 is [using 
21|https://issues.apache.org/jira/browse/HADOOP-10101].

> Upgrade Guava to 17.0
> -
>
> Key: DATAFU-48
> URL: https://issues.apache.org/jira/browse/DATAFU-48
> Project: DataFu
>  Issue Type: Improvement
>Reporter: Philip (flip) Kromer
>Assignee: Philip (flip) Kromer
>Priority: Minor
>  Labels: build, dependency, guava, version
> Attachments: 0001-DATAFU-48-Upgrade-gradle-to-17.0.patch, 
> DATAFU-48-update-gradle-to-20.0.patch
>
>
> Specifically motivated by the improvements to hashing library, but also 
> because we're six versions behind at the moment.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (DATAFU-48) Upgrade Guava to 17.0

2017-10-10 Thread Matthew Hayes (JIRA)

[ 
https://issues.apache.org/jira/browse/DATAFU-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199212#comment-16199212
 ] 

Matthew Hayes commented on DATAFU-48:
-

It's been awhile since I looked at this.  Which Hadoop versions are using Guava 
20.0?

> Upgrade Guava to 17.0
> -
>
> Key: DATAFU-48
> URL: https://issues.apache.org/jira/browse/DATAFU-48
> Project: DataFu
>  Issue Type: Improvement
>Reporter: Philip (flip) Kromer
>Assignee: Philip (flip) Kromer
>Priority: Minor
>  Labels: build, dependency, guava, version
> Attachments: 0001-DATAFU-48-Upgrade-gradle-to-17.0.patch, 
> DATAFU-48-update-gradle-to-20.0.patch
>
>
> Specifically motivated by the improvements to hashing library, but also 
> because we're six versions behind at the moment.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)