[jira] [Commented] (DATAFU-95) Improve wrong JDK error message

2016-03-09 Thread Matthew Hayes (JIRA) 

[ 
https://issues.apache.org/jira/browse/DATAFU-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15187463#comment-15187463
 ] 

Matthew Hayes commented on DATAFU-95:
-

Committed and pushed to master.

> Improve wrong JDK error message
> ---
>
> Key: DATAFU-95
> URL: https://issues.apache.org/jira/browse/DATAFU-95
> Project: DataFu
>  Issue Type: Improvement
>Reporter: Jakob Homan
>Assignee: Matthew Hayes
>Priority: Minor
> Fix For: 1.3.1
>
> Attachments: DATAFU-95.patch
>
>
> Right now if one tries to build against JDK1.7, the resulting failure is a 
> bit unclear:
> {noformat}Download 
> https://repo1.maven.org/maven2/org/eclipse/equinox/app/1.3.200-v20130910-1609/app-1.3.200-v20130910-1609.jar
> /Users/jahoman/repos/datafu/build-plugin/src/main/java/org/adrianwalker/multilinestring/MultilineProcessor.java:18:
>  error: cannot find symbol
> @SupportedSourceVersion(SourceVersion.RELEASE_8)
>  ^
>   symbol:   variable RELEASE_8
>   location: class SourceVersion
> 1 error
> :build-plugin:compileJava FAILED
> FAILURE: Build failed with an exception.
> {noformat}
> It may be better to use something like [The 
> Sweeney|https://github.com/boxheed/gradle-sweeney-plugin] to enforce this and 
> provide a better, faster message on failure.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DATAFU-95) Improve wrong JDK error message

2016-03-08 Thread Sam Shah (JIRA) 

[ 
https://issues.apache.org/jira/browse/DATAFU-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185483#comment-15185483
 ] 

Sam Shah commented on DATAFU-95:


+1 patch looks good

> Improve wrong JDK error message
> ---
>
> Key: DATAFU-95
> URL: https://issues.apache.org/jira/browse/DATAFU-95
> Project: DataFu
>  Issue Type: Improvement
>Reporter: Jakob Homan
>Assignee: Matthew Hayes
>Priority: Minor
> Fix For: 1.3.1
>
> Attachments: DATAFU-95.patch
>
>
> Right now if one tries to build against JDK1.7, the resulting failure is a 
> bit unclear:
> {noformat}Download 
> https://repo1.maven.org/maven2/org/eclipse/equinox/app/1.3.200-v20130910-1609/app-1.3.200-v20130910-1609.jar
> /Users/jahoman/repos/datafu/build-plugin/src/main/java/org/adrianwalker/multilinestring/MultilineProcessor.java:18:
>  error: cannot find symbol
> @SupportedSourceVersion(SourceVersion.RELEASE_8)
>  ^
>   symbol:   variable RELEASE_8
>   location: class SourceVersion
> 1 error
> :build-plugin:compileJava FAILED
> FAILURE: Build failed with an exception.
> {noformat}
> It may be better to use something like [The 
> Sweeney|https://github.com/boxheed/gradle-sweeney-plugin] to enforce this and 
> provide a better, faster message on failure.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DATAFU-95) Improve wrong JDK error message

2016-02-04 Thread Matthew Hayes (JIRA) 

[ 
https://issues.apache.org/jira/browse/DATAFU-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15133449#comment-15133449
 ] 

Matthew Hayes commented on DATAFU-95:
-

Patch attached and RB here: https://reviews.apache.org/r/43235/

Following [~jghoman]'s suggestion I added sweeney to check the JDK version.  It 
now works with JDK 1.7.

> Improve wrong JDK error message
> ---
>
> Key: DATAFU-95
> URL: https://issues.apache.org/jira/browse/DATAFU-95
> Project: DataFu
>  Issue Type: Improvement
>Reporter: Jakob Homan
>Assignee: Matthew Hayes
>Priority: Minor
> Fix For: 1.3.1
>
> Attachments: DATAFU-95.patch
>
>
> Right now if one tries to build against JDK1.7, the resulting failure is a 
> bit unclear:
> {noformat}Download 
> https://repo1.maven.org/maven2/org/eclipse/equinox/app/1.3.200-v20130910-1609/app-1.3.200-v20130910-1609.jar
> /Users/jahoman/repos/datafu/build-plugin/src/main/java/org/adrianwalker/multilinestring/MultilineProcessor.java:18:
>  error: cannot find symbol
> @SupportedSourceVersion(SourceVersion.RELEASE_8)
>  ^
>   symbol:   variable RELEASE_8
>   location: class SourceVersion
> 1 error
> :build-plugin:compileJava FAILED
> FAILURE: Build failed with an exception.
> {noformat}
> It may be better to use something like [The 
> Sweeney|https://github.com/boxheed/gradle-sweeney-plugin] to enforce this and 
> provide a better, faster message on failure.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DATAFU-95) Improve wrong JDK error message

2016-01-14 Thread Eyal Allweil (JIRA) 

[ 
https://issues.apache.org/jira/browse/DATAFU-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15097858#comment-15097858
 ] 

Eyal Allweil commented on DATAFU-95:


As an immediate, easy-to-do improvement, writing what Java version is required 
in the main README on GitHub would be great.

> Improve wrong JDK error message
> ---
>
> Key: DATAFU-95
> URL: https://issues.apache.org/jira/browse/DATAFU-95
> Project: DataFu
>  Issue Type: Improvement
>Reporter: Jakob Homan
>Priority: Minor
>
> Right now if one tries to build against JDK1.7, the resulting failure is a 
> bit unclear:
> {noformat}Download 
> https://repo1.maven.org/maven2/org/eclipse/equinox/app/1.3.200-v20130910-1609/app-1.3.200-v20130910-1609.jar
> /Users/jahoman/repos/datafu/build-plugin/src/main/java/org/adrianwalker/multilinestring/MultilineProcessor.java:18:
>  error: cannot find symbol
> @SupportedSourceVersion(SourceVersion.RELEASE_8)
>  ^
>   symbol:   variable RELEASE_8
>   location: class SourceVersion
> 1 error
> :build-plugin:compileJava FAILED
> FAILURE: Build failed with an exception.
> {noformat}
> It may be better to use something like [The 
> Sweeney|https://github.com/boxheed/gradle-sweeney-plugin] to enforce this and 
> provide a better, faster message on failure.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)