Re: ContainerManagedTransactionStrategy issue

2014-10-29 Thread hwaastad
OK,
after going back to my ear project I still have an issue using repositories
and CMT.
(war is OK)

versions 1.0.3 is ok. 1.0.3 is not.

1. method expressions are working
2. @Query annotation is working
3. All abstract functions (find/save/findall etc etc) are not working

I have a simple ear project using tomee 1.7.1 plus. If needed, I can publish
it to github.

Can I file an issue in JIRA?

br hw



--
View this message in context: 
http://apache-deltaspike-incubator-discussions.2316169.n4.nabble.com/ContainerManagedTransactionStrategy-issue-tp4659285p4659297.html
Sent from the Apache DeltaSpike Incubator Discussions mailing list archive at 
Nabble.com.


[jira] [Resolved] (DELTASPIKE-757) Create tests for WindowContextQuotaHandler

2014-10-29 Thread Rafael Benevides (JIRA)

 [ 
https://issues.apache.org/jira/browse/DELTASPIKE-757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rafael Benevides resolved DELTASPIKE-757.
-
Resolution: Fixed

Commit b62fad9d427a1bc2

 Create tests for WindowContextQuotaHandler
 --

 Key: DELTASPIKE-757
 URL: https://issues.apache.org/jira/browse/DELTASPIKE-757
 Project: DeltaSpike
  Issue Type: Bug
  Components: Core
Affects Versions: 1.0.3
Reporter: Rafael Benevides
Assignee: Rafael Benevides
 Fix For: 1.0.5






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Anchor links fixed

2014-10-29 Thread Rafael Benevides

Hi All,

I just fixed the anchor links issue that was bothering me since a long 
time ago:


Now when you click on a link at the documentation website, the title is 
not hidden anymore. Example: 
http://deltaspike.apache.org/documentation/jsf.html#_creating_custom_meta_data_via_viewmetadata


If it's not working for you, maybe the css still cached.

--

*Rafael Benevides | Senior Software Engineer*
JBoss Developer
M: +55-61-9269-6576

Red Hat

Better technology. Faster innovation. Powered by community collaboration.
See how it works at www.redhat.com http://www.redhat.com/

LinkedIn http://www.linkedin.com/company/3258288 Youtube 
https://www.youtube.com/redhatlatam


[jira] [Comment Edited] (DELTASPIKE-701) Add method in EntityRepository to merge a detached entity and remove it

2014-10-29 Thread Denis Falqueto (JIRA)

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14188547#comment-14188547
 ] 

Denis Falqueto edited comment on DELTASPIKE-701 at 10/29/14 4:44 PM:
-

I would like to propose a subtle change in the implementation:

public void attachAndRemove(Entity entity) {

if (!entityManager.contains(entity)) {

entity = entityManager.merge(entity);

}

entityManager.remove(entity);

}

It's just a simpler code path.


was (Author: denisfalqueto):
I would like to propose a subtle change in the implementation:

public void attachAndRemove(Entity entity) {
// Entity is detached so perform a merge before removing.
if (!entityManager.contains(entity))
entity = entityManager.merge(entity);
}
entityManager.remove(entity);
}

It's just a simpler code path.

 Add method in EntityRepository to merge a detached entity and remove it
 ---

 Key: DELTASPIKE-701
 URL: https://issues.apache.org/jira/browse/DELTASPIKE-701
 Project: DeltaSpike
  Issue Type: Improvement
  Components: Data-Module
Reporter: Juliano Marques
Assignee: Thomas Hug

 It will be nice if EntityRepository has a method like:
 public void attachAndRemove(Entity entity) {
 if (entityManager.contains(entity)) {
 entityManager.remove(entity);
 } else {
 entityManager.remove(entityManager.merge(entity));
 }
 }
 This method will be useful to handle java.lang.IllegalArgumentException: 
 Removing a detached instance exceptions.
 Workaround: Create a query delegate with this method.
 http://mail-archives.apache.org/mod_mbox/deltaspike-users/201408.mbox/%3CCAAuOd%3DXhb%3D-ssdzU%3DTdxWg8d18XXC15U7EjNiGya9eEgaA%2BUpA%40mail.gmail.com%3E



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Reopened] (DELTASPIKE-758) Document WindowContextQuotaHandler

2014-10-29 Thread Gerhard Petracek (JIRA)

 [ 
https://issues.apache.org/jira/browse/DELTASPIKE-758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gerhard Petracek reopened DELTASPIKE-758:
-

the default is 1024 for non-jsf apps and 64 for jsf-apps see 
DefaultWindowContextQuotaHandler#init and DefaultClientWindowConfig#init

 Document WindowContextQuotaHandler
 --

 Key: DELTASPIKE-758
 URL: https://issues.apache.org/jira/browse/DELTASPIKE-758
 Project: DeltaSpike
  Issue Type: Task
  Components: Documentation
Reporter: Rafael Benevides
Assignee: Rafael Benevides





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (DELTASPIKE-759) 1.0.3 breaks abstractentityrepositories in ear project

2014-10-29 Thread Helge Waastad (JIRA)
Helge Waastad created DELTASPIKE-759:


 Summary: 1.0.3 breaks abstractentityrepositories in ear project
 Key: DELTASPIKE-759
 URL: https://issues.apache.org/jira/browse/DELTASPIKE-759
 Project: DeltaSpike
  Issue Type: Bug
  Components: Data-Module
Affects Versions: 1.0.3
 Environment: openjdk 1.7
ubuntu 14.04
tomee 1.7.1
Reporter: Helge Waastad


In dialog woith Thomas Hug, I've decided to file a bug report.

https://github.com/hwaastad/DeltaspikeEnterprise.git

A simple EAR project having ear,ejb,web and a jpa module.

Using containermanagedtransactionstrategy in beans.xml, jta em producer and jta 
in persistence.xml

A simple timerservice is started by a servletcontextlistener in web module.
timer is just persisting a dummy person object using a remote EJB in ejb module 
(because my current production environment is a distributed setup)

Before 1.0.3 this has been working smooth as silk, however in 1.0.3 all bad 
things happen.

1. parent pom has a deltaspike.version set to 1.0.3
2. compile project
3. in ear module, do mvn tomee:run (fires up a TomEE 1.7.1)
4. Verify repositories are failing
5. set version 1.0.2 and recompile
6. mvn tomee:run and verify its working ok

It is also possible to compile war module using a standalone profile and mvn 
tomee:run in wen module will verify its working fine in bothe 1.0.2 AND 1.0.3

I have also made a simple openejb test aswell in another project which I 
happily will provide if needed/necessary

br hw



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: ContainerManagedTransactionStrategy issue

2014-10-29 Thread hwaastad
Hi TH,
Ok I've tried to be as explicit as I could:

https://issues.apache.org/jira/browse/DELTASPIKE-759

If anything else is needed, I'll do whatever I can. I do really want this to
be OK :-)

br hw



--
View this message in context: 
http://apache-deltaspike-incubator-discussions.2316169.n4.nabble.com/ContainerManagedTransactionStrategy-issue-tp4659285p4659307.html
Sent from the Apache DeltaSpike Incubator Discussions mailing list archive at 
Nabble.com.


[jira] [Updated] (DELTASPIKE-759) 1.0.3 breaks abstractentityrepositories in ear project

2014-10-29 Thread Gerhard Petracek (JIRA)

 [ 
https://issues.apache.org/jira/browse/DELTASPIKE-759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gerhard Petracek updated DELTASPIKE-759:

Assignee: Thomas Hug

 1.0.3 breaks abstractentityrepositories in ear project
 --

 Key: DELTASPIKE-759
 URL: https://issues.apache.org/jira/browse/DELTASPIKE-759
 Project: DeltaSpike
  Issue Type: Bug
  Components: Data-Module
Affects Versions: 1.0.3
 Environment: openjdk 1.7
 ubuntu 14.04
 tomee 1.7.1
Reporter: Helge Waastad
Assignee: Thomas Hug

 In dialog woith Thomas Hug, I've decided to file a bug report.
 https://github.com/hwaastad/DeltaspikeEnterprise.git
 A simple EAR project having ear,ejb,web and a jpa module.
 Using containermanagedtransactionstrategy in beans.xml, jta em producer and 
 jta in persistence.xml
 A simple timerservice is started by a servletcontextlistener in web module.
 timer is just persisting a dummy person object using a remote EJB in ejb 
 module (because my current production environment is a distributed setup)
 Before 1.0.3 this has been working smooth as silk, however in 1.0.3 all bad 
 things happen.
 1. parent pom has a deltaspike.version set to 1.0.3
 2. compile project
 3. in ear module, do mvn tomee:run (fires up a TomEE 1.7.1)
 4. Verify repositories are failing
 5. set version 1.0.2 and recompile
 6. mvn tomee:run and verify its working ok
 It is also possible to compile war module using a standalone profile and mvn 
 tomee:run in wen module will verify its working fine in bothe 1.0.2 AND 1.0.3
 I have also made a simple openejb test aswell in another project which I 
 happily will provide if needed/necessary
 br hw



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Javadoc review

2014-10-29 Thread Ron Smeral

Thanks for checking the PR! I'll continue the review soon.
How do I get this merged? Should I file an issue?

On 27.10.2014 14:52, Rafael Benevides wrote:

Hi Ron,

I did an overview look on it and I believe that these changes makes 
sense and are very welcome.


On 10/27/14 11:31, Ron Smeral wrote:

Hi,

I noticed some mistakes in Javadoc, which I wanted to fix, but then I 
noticed some more, and it quickly turned into a complete review of 
core/api javadoc.

So I issued https://github.com/apache/deltaspike/pull/10 .

It would be great if someone could have a look at it. The commit 
describes most of the changes I did, which range from corrections of 
simple typos up to complete logical restructuring of Javadoc in a few 
classes.


In case the change makes sense and is accepted, I have a few more 
javadoc fixes ready and I would continue reviewing the rest of the 
modules.


Thanks,

R.





--
Ron Smeral
JBoss Quality Engineer
Brno