[jira] [Resolved] (DELTASPIKE-769) add @Priority dyn. to deltaspike interceptors to avoid the manual config
[ https://issues.apache.org/jira/browse/DELTASPIKE-769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gerhard Petracek resolved DELTASPIKE-769. - Resolution: Fixed > add @Priority dyn. to deltaspike interceptors to avoid the manual config > > > Key: DELTASPIKE-769 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-769 > Project: DeltaSpike > Issue Type: New Feature > Components: Core >Affects Versions: 1.1.0 >Reporter: Gerhard Petracek >Assignee: Gerhard Petracek > Fix For: 1.1.1 > > > owb doesn't restrict interceptors to the bda which hosts the config -> > interceptors provided by deltaspike are active per default for the whole > application. weld users have to add all of our interceptors to the beans.xml > to use them. since cdi 1.1 global enablement is also supported by weld once > @Priority gets used. > we can add it dyn. in case @Priority is on the classpath -> the usage of ds > gets simpler for weld users and doesn't look that fragmented. > currently weld has a bug which adds an interceptor twice if it is enabled via > beans.xml as well as @Priority - therefore we could e.g. detect multiple > invocations (for the same method) in project-stage development and unit-test > (-> additional benefit for users of our test-control module) or check the > content of beans.xml in case of the same project-stages (during > bootstrapping). that would also mean that we can't use our own interceptors > internally (since they are enabled for owb 1.1.x/1.2.x users via beans.xml). > however, currently we aren't doing that anyway, but we have to check it > during bootstrapping to avoid side-effects with features added later on. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (DELTASPIKE-781) AnnotatedTypeImpl doesn't work for Annotation AnnotatedType
[
https://issues.apache.org/jira/browse/DELTASPIKE-781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Antoine Sabot-Durand updated DELTASPIKE-781:
Summary: AnnotatedTypeImpl doesn't work for Annotation AnnotatedType (was:
AnnotatedTypeImpl doesn't work for Annotion AnnotatedType)
> AnnotatedTypeImpl doesn't work for Annotation AnnotatedType
> ---
>
> Key: DELTASPIKE-781
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-781
> Project: DeltaSpike
> Issue Type: Bug
> Components: Core
>Affects Versions: 1.1.0
>Reporter: Antoine Sabot-Durand
>Assignee: Antoine Sabot-Durand
> Fix For: 1.1.1
>
> Attachments: DELTASPIKE-781.patch
>
>
> I needed to create AnnotatedType for Annotation to register it as an
> interceptor binding with {{BeforeBeanDiscovery#addInterceptorBinding}} and
> realised that the builded {{AnnotatedType}} thru {{AnnotatedTypeBuilder}}
> contained all the {{Annotation}} class methods where it should have contained
> none. That makes the container (Weld or OWB) crash.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (DELTASPIKE-781) AnnotatedTypeImpl doesn't work for Annotion AnnotatedType
[
https://issues.apache.org/jira/browse/DELTASPIKE-781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Antoine Sabot-Durand resolved DELTASPIKE-781.
-
Resolution: Fixed
Fix Version/s: 1.1.1
Added a test to avoid adding methods to {{AnnotatedTypeImpl}} if the
{{AnnotatedType}} is an annotation. Added a small related test as well.
> AnnotatedTypeImpl doesn't work for Annotion AnnotatedType
> -
>
> Key: DELTASPIKE-781
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-781
> Project: DeltaSpike
> Issue Type: Bug
> Components: Core
>Affects Versions: 1.1.0
>Reporter: Antoine Sabot-Durand
>Assignee: Antoine Sabot-Durand
> Fix For: 1.1.1
>
> Attachments: DELTASPIKE-781.patch
>
>
> I needed to create AnnotatedType for Annotation to register it as an
> interceptor binding with {{BeforeBeanDiscovery#addInterceptorBinding}} and
> realised that the builded {{AnnotatedType}} thru {{AnnotatedTypeBuilder}}
> contained all the {{Annotation}} class methods where it should have contained
> none. That makes the container (Weld or OWB) crash.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (DELTASPIKE-781) AnnotatedTypeImpl doesn't work for Annotion AnnotatedType
[
https://issues.apache.org/jira/browse/DELTASPIKE-781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Antoine Sabot-Durand updated DELTASPIKE-781:
Attachment: DELTASPIKE-781.patch
This patch solves the bug and add a corresponding test
> AnnotatedTypeImpl doesn't work for Annotion AnnotatedType
> -
>
> Key: DELTASPIKE-781
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-781
> Project: DeltaSpike
> Issue Type: Bug
> Components: Core
>Affects Versions: 1.1.0
>Reporter: Antoine Sabot-Durand
>Assignee: Antoine Sabot-Durand
> Attachments: DELTASPIKE-781.patch
>
>
> I needed to create AnnotatedType for Annotation to register it as an
> interceptor binding with {{BeforeBeanDiscovery#addInterceptorBinding}} and
> realised that the builded {{AnnotatedType}} thru {{AnnotatedTypeBuilder}}
> contained all the {{Annotation}} class methods where it should have contained
> none. That makes the container (Weld or OWB) crash.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (DELTASPIKE-781) AnnotatedTypeImpl doesn't work for Annotion AnnotatedType
Antoine Sabot-Durand created DELTASPIKE-781:
---
Summary: AnnotatedTypeImpl doesn't work for Annotion AnnotatedType
Key: DELTASPIKE-781
URL: https://issues.apache.org/jira/browse/DELTASPIKE-781
Project: DeltaSpike
Issue Type: Bug
Components: Core
Affects Versions: 1.1.0
Reporter: Antoine Sabot-Durand
I needed to create AnnotatedType for Annotation to register it as an
interceptor binding with {{BeforeBeanDiscovery#addInterceptorBinding}} and
realised that the builded {{AnnotatedType}} thru {{AnnotatedTypeBuilder}}
contained all the {{Annotation}} class methods where it should have contained
none. That makes the container (Weld or OWB) crash.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (DELTASPIKE-781) AnnotatedTypeImpl doesn't work for Annotion AnnotatedType
[
https://issues.apache.org/jira/browse/DELTASPIKE-781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Antoine Sabot-Durand reassigned DELTASPIKE-781:
---
Assignee: Antoine Sabot-Durand
> AnnotatedTypeImpl doesn't work for Annotion AnnotatedType
> -
>
> Key: DELTASPIKE-781
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-781
> Project: DeltaSpike
> Issue Type: Bug
> Components: Core
>Affects Versions: 1.1.0
>Reporter: Antoine Sabot-Durand
>Assignee: Antoine Sabot-Durand
>
> I needed to create AnnotatedType for Annotation to register it as an
> interceptor binding with {{BeforeBeanDiscovery#addInterceptorBinding}} and
> realised that the builded {{AnnotatedType}} thru {{AnnotatedTypeBuilder}}
> contained all the {{Annotation}} class methods where it should have contained
> none. That makes the container (Weld or OWB) crash.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-780) support more advanced cases by extending existing transaction-strategies
[ https://issues.apache.org/jira/browse/DELTASPIKE-780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14213755#comment-14213755 ] Gerhard Petracek commented on DELTASPIKE-780: - @romain: then just use ee-jta as it is and ignore the annotation we have since codi. this ticket is just about adding additional (simple) hooks ( see https://git-wip-us.apache.org/repos/asf?p=deltaspike.git;a=commit;h=e3ce1da6945f6336efca40b11cc14ae18ebfe117 ). > support more advanced cases by extending existing transaction-strategies > > > Key: DELTASPIKE-780 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-780 > Project: DeltaSpike > Issue Type: Improvement > Components: JPA-Module >Affects Versions: 1.1.0 >Reporter: Gerhard Petracek >Assignee: Gerhard Petracek > Fix For: 1.1.1 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-780) support more advanced cases by extending existing transaction-strategies
[ https://issues.apache.org/jira/browse/DELTASPIKE-780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14213753#comment-14213753 ] Romain Manni-Bucau commented on DELTASPIKE-780: --- Well for you. For me it always has been very limited compared to ee (jta). What I meant was however different: since there is a standard api we can just use it for advanced cases > support more advanced cases by extending existing transaction-strategies > > > Key: DELTASPIKE-780 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-780 > Project: DeltaSpike > Issue Type: Improvement > Components: JPA-Module >Affects Versions: 1.1.0 >Reporter: Gerhard Petracek >Assignee: Gerhard Petracek > Fix For: 1.1.1 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (DELTASPIKE-777) Create and publish Javadocs section
[
https://issues.apache.org/jira/browse/DELTASPIKE-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14213751#comment-14213751
]
Gerhard Petracek edited comment on DELTASPIKE-777 at 11/15/14 8:24 PM:
---
please fix javadoc.sh by adding:
{code}
#!/bin/sh
#
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
#
{code}
or remove it
was (Author: gpetracek):
please fix javadoc.sh by adding:
#!/bin/sh
#
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
#
or remove it
> Create and publish Javadocs section
> ---
>
> Key: DELTASPIKE-777
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-777
> Project: DeltaSpike
> Issue Type: Task
> Components: Documentation
>Affects Versions: 1.1.0
>Reporter: Rafael Benevides
>Assignee: Rafael Benevides
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-777) Create and publish Javadocs section
[ https://issues.apache.org/jira/browse/DELTASPIKE-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14213751#comment-14213751 ] Gerhard Petracek commented on DELTASPIKE-777: - please fix javadoc.sh by adding: #!/bin/sh # # Licensed to the Apache Software Foundation (ASF) under one # or more contributor license agreements. See the NOTICE file # distributed with this work for additional information # regarding copyright ownership. The ASF licenses this file # to you under the Apache License, Version 2.0 (the # "License"); you may not use this file except in compliance # with the License. You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, # software distributed under the License is distributed on an # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. # or remove it > Create and publish Javadocs section > --- > > Key: DELTASPIKE-777 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-777 > Project: DeltaSpike > Issue Type: Task > Components: Documentation >Affects Versions: 1.1.0 >Reporter: Rafael Benevides >Assignee: Rafael Benevides > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-780) support more advanced cases by extending existing transaction-strategies
[ https://issues.apache.org/jira/browse/DELTASPIKE-780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14213750#comment-14213750 ] Gerhard Petracek commented on DELTASPIKE-780: - @romain: org.apache.deltaspike.jpa.api.transaction.Transactional isn't obsolete just because there is javax.transaction.Transactional it's way more flexible. it's like @Exclude vs @Vetoed (there it's maybe a bit more obvious). > support more advanced cases by extending existing transaction-strategies > > > Key: DELTASPIKE-780 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-780 > Project: DeltaSpike > Issue Type: Improvement > Components: JPA-Module >Affects Versions: 1.1.0 >Reporter: Gerhard Petracek >Assignee: Gerhard Petracek > Fix For: 1.1.1 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (DELTASPIKE-780) support more advanced cases by extending existing transaction-strategies
[ https://issues.apache.org/jira/browse/DELTASPIKE-780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gerhard Petracek resolved DELTASPIKE-780. - Resolution: Fixed > support more advanced cases by extending existing transaction-strategies > > > Key: DELTASPIKE-780 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-780 > Project: DeltaSpike > Issue Type: Improvement > Components: JPA-Module >Affects Versions: 1.1.0 >Reporter: Gerhard Petracek >Assignee: Gerhard Petracek > Fix For: 1.1.1 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-780) support more advanced cases by extending existing transaction-strategies
[ https://issues.apache.org/jira/browse/DELTASPIKE-780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14213737#comment-14213737 ] Romain Manni-Bucau commented on DELTASPIKE-780: --- @Transactional being standard now do we need it? > support more advanced cases by extending existing transaction-strategies > > > Key: DELTASPIKE-780 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-780 > Project: DeltaSpike > Issue Type: Improvement > Components: JPA-Module >Affects Versions: 1.1.0 >Reporter: Gerhard Petracek >Assignee: Gerhard Petracek > Fix For: 1.1.1 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (DELTASPIKE-780) support more advanced cases by extending existing transaction-strategies
Gerhard Petracek created DELTASPIKE-780: --- Summary: support more advanced cases by extending existing transaction-strategies Key: DELTASPIKE-780 URL: https://issues.apache.org/jira/browse/DELTASPIKE-780 Project: DeltaSpike Issue Type: Improvement Components: JPA-Module Affects Versions: 1.1.0 Reporter: Gerhard Petracek Assignee: Gerhard Petracek Fix For: 1.1.1 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
