[jira] [Commented] (DELTASPIKE-940) @Transactional and @EntityManagerConfig each use a different method to resolve EntityManagers

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16062177#comment-16062177
 ] 

ASF subversion and git services commented on DELTASPIKE-940:


Commit 256431539ca8b01aa237d33f5bcb723e292f8893 in deltaspike's branch 
refs/heads/master from [~johndament]
[ https://git-wip-us.apache.org/repos/asf?p=deltaspike.git;h=2564315 ]

DELTASPIKE-940 - First step in merging support for qualifiers and entity 
manager resolvers in data and JPA modules.


> @Transactional and @EntityManagerConfig each use a different method to 
> resolve EntityManagers
> -
>
> Key: DELTASPIKE-940
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-940
> Project: DeltaSpike
>  Issue Type: Improvement
>  Components: Data-Module, JPA-Module
>Reporter: Xavier Dury
>Assignee: John D. Ament
>Priority: Minor
> Fix For: 1.8.1
>
> Attachments: ds940.patch
>
>
> When an application uses multiple {{EntityManager}}'s, there must be a way to 
> specify which one(s) should be used. Currently, {{@Transactional}} and 
> {{@EntityManagerConfig}} use different approaches:
> - {{@Transactional}} can take one or more qualifiers directly in its 
> {{qualifier()}} member ({{@Transactional(qualifier = MyDB.class)}})
> - While {{@EntityManagerConfig}} must define an {{EntityManagerResolver}} 
> ({{@EntityManagerConfig(entityManagerResolver = 
> MyDBEntityManagerResolver.class}})
> I think both should be unified and use a single way to specify which 
> {{EntityManager}} to use. IMHO, the {{@Transactional}} way of doing looks 
> better and should be applied to {{@EntityManagerConfig}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (DELTASPIKE-1252) data-documentation missing Optional return value

[John D. Ament (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DELTASPIKE-1252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John D. Ament resolved DELTASPIKE-1252.
---
Resolution: Fixed

> data-documentation missing Optional return value
> 
>
> Key: DELTASPIKE-1252
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1252
> Project: DeltaSpike
>  Issue Type: Bug
>  Components: Data-Module, Documentation
>Affects Versions: 1.7.2
>Reporter: Jan Matèrne
>Assignee: John D. Ament
>Priority: Minor
> Fix For: 1.8.1
>
>
> http://deltaspike.apache.org/documentation/data.html lists the format for 
> methods:
> (Entity|List) (prefix)(Property[Comparator]){Operator Property 
> [Comparator]}
> Here java.util.Optional is missing:
> "(Entity|Optional|List) 
> (prefix)(Property[Comparator]){Operator Property [Comparator]}
>  
> Or in more concrete words:
> • The query method must either return an entity or an java.util.Optional 
> or a list of entities.
> • It must start with the findBy prefix ..."



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)