[jira] [Commented] (DELTASPIKE-1365) Support extra JPQL comparators in method expressions
[ https://issues.apache.org/jira/browse/DELTASPIKE-1365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16737529#comment-16737529 ] ASF GitHub Bot commented on DELTASPIKE-1365: Github user moghaddam closed the pull request at: https://github.com/apache/deltaspike/pull/81 > Support extra JPQL comparators in method expressions > > > Key: DELTASPIKE-1365 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-1365 > Project: DeltaSpike > Issue Type: Improvement > Components: Data-Module >Reporter: Ehsan Zaery Moghaddam >Priority: Minor > Fix For: 1.9.1 > > > The method expressions is currently supporting primary JPQL operators while > it seems feasible to implement other operators like "In", "NotIn", > "StartingWith", "True", etc. > I tried to add some of them and seems they works (of course thanks to the way > they've been designed so that it's easy to extend them). I'm just curious if > there is any technical consideration/limitation preventing us to have these > operators or is it because they were never been requested? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DELTASPIKE-1330) Criteria with OR generate AND on query
[
https://issues.apache.org/jira/browse/DELTASPIKE-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16724372#comment-16724372
]
ASF GitHub Bot commented on DELTASPIKE-1330:
Github user arthurgregorio closed the pull request at:
https://github.com/apache/deltaspike/pull/82
> Criteria with OR generate AND on query
> --
>
> Key: DELTASPIKE-1330
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1330
> Project: DeltaSpike
> Issue Type: Bug
> Components: Data-Module
>Affects Versions: 1.8.1
> Environment: JDK 8u161, Wildfly 11, JEE 7
>Reporter: Arthur Pereira Gregório
>Priority: Critical
>
> If I use a OR on criteria the generated query use AND instead of OR to mix
> the properties after WHERE clause.
> Sample:
> {code:java}
> // code placeholder
> default List findAllBy(String filter, Boolean blocked, int start, int
> pageSize) {
> final Criteria criteria = criteria();
> if (isNotBlank(filter)) {
> criteria.or(this.criteria()
> .likeIgnoreCase(User_.name, filter)
> .likeIgnoreCase(User_.username, filter)
> .likeIgnoreCase(User_.email, filter));
> }
> if (blocked != null) {
> criteria.eq(this.getBlockedProperty(), blocked);
> }
> criteria.orderDesc(PersistentEntity_.createdOn);
> return criteria.createQuery()
> .setFirstResult(start)
> .setMaxResults(pageSize)
> .getResultList();
> }
> {code}
>
> Generate this hibernate query:
> 17:41:24,813 INFO [stdout] (default task-64) Hibernate: select user0_.id as
> id1_4_, user0_.created_by as created_2_4_, user0_.created_on as created_3_4_,
> user0_.modified_by as modified4_4_, user0_.modified_on as modified5_4_,
> user0_.blocked as blocked6_4_, user0_.email as email7_4_, user0_.id_group as
> id_grou12_4_, user0_.name as name8_4_, user0_.password as password9_4_,
> user0_.store_type as store_t10_4_, user0_.username as usernam11_4_ from
> security.users user0_ *where (upper(user0_.name) like ?) and
> (upper(user0_.username) like ?) and (upper(user0_.email) like ?)* order by
> user0_.created_on desc limit ?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DELTASPIKE-1330) Criteria with OR generate AND on query
[
https://issues.apache.org/jira/browse/DELTASPIKE-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16722911#comment-16722911
]
ASF GitHub Bot commented on DELTASPIKE-1330:
GitHub user arthurgregorio opened a pull request:
https://github.com/apache/deltaspike/pull/82
DELTASPIKE-1330 fix
just updated line 47 to the correct method call
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/arthurgregorio/deltaspike master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/deltaspike/pull/82.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #82
commit 8f306265774ced53bd890c7b920c9e0f825e527f
Author: Arthur Gregório
Date: 2018-12-17T11:48:00Z
fix for DELTASPIKE-1330
> Criteria with OR generate AND on query
> --
>
> Key: DELTASPIKE-1330
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1330
> Project: DeltaSpike
> Issue Type: Bug
> Components: Data-Module
>Affects Versions: 1.8.1
> Environment: JDK 8u161, Wildfly 11, JEE 7
>Reporter: Arthur Pereira Gregório
>Priority: Critical
>
> If I use a OR on criteria the generated query use AND instead of OR to mix
> the properties after WHERE clause.
> Sample:
> {code:java}
> // code placeholder
> default List findAllBy(String filter, Boolean blocked, int start, int
> pageSize) {
> final Criteria criteria = criteria();
> if (isNotBlank(filter)) {
> criteria.or(this.criteria()
> .likeIgnoreCase(User_.name, filter)
> .likeIgnoreCase(User_.username, filter)
> .likeIgnoreCase(User_.email, filter));
> }
> if (blocked != null) {
> criteria.eq(this.getBlockedProperty(), blocked);
> }
> criteria.orderDesc(PersistentEntity_.createdOn);
> return criteria.createQuery()
> .setFirstResult(start)
> .setMaxResults(pageSize)
> .getResultList();
> }
> {code}
>
> Generate this hibernate query:
> 17:41:24,813 INFO [stdout] (default task-64) Hibernate: select user0_.id as
> id1_4_, user0_.created_by as created_2_4_, user0_.created_on as created_3_4_,
> user0_.modified_by as modified4_4_, user0_.modified_on as modified5_4_,
> user0_.blocked as blocked6_4_, user0_.email as email7_4_, user0_.id_group as
> id_grou12_4_, user0_.name as name8_4_, user0_.password as password9_4_,
> user0_.store_type as store_t10_4_, user0_.username as usernam11_4_ from
> security.users user0_ *where (upper(user0_.name) like ?) and
> (upper(user0_.username) like ?) and (upper(user0_.email) like ?)* order by
> user0_.created_on desc limit ?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DELTASPIKE-1365) Support extra JPQL comparators in method expressions
[ https://issues.apache.org/jira/browse/DELTASPIKE-1365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16720132#comment-16720132 ] ASF GitHub Bot commented on DELTASPIKE-1365: GitHub user moghaddam opened a pull request: https://github.com/apache/deltaspike/pull/81 DELTASPIKE-1365: Support extra JPQL comparators in method expressions Here is the implementation of [Support extra JPQL comparators in method expressions](https://issues.apache.org/jira/browse/DELTASPIKE-1365) Following comparators are added: - NotLike - IsNull - NotIn - In - True - False - Containing - StartingWith - EndingWith You can merge this pull request into a Git repository by running: $ git pull https://github.com/moghaddam/deltaspike DELTASPIKE-1365 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/deltaspike/pull/81.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #81 commit 8317195f9f12080ba07c3a658e70f9c438d56616 Author: Ehsan Zaery Moghaddam Date: 2018-12-13T12:48:37Z DELTASPIKE-1365: Support extra JPQL comparators in method expressions > Support extra JPQL comparators in method expressions > > > Key: DELTASPIKE-1365 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-1365 > Project: DeltaSpike > Issue Type: Improvement > Components: Data-Module >Reporter: Ehsan Zaery Moghaddam >Priority: Minor > > The method expressions is currently supporting primary JPQL operators while > it seems feasible to implement other operators like "In", "NotIn", > "StartingWith", "True", etc. > I tried to add some of them and seems they works (of course thanks to the way > they've been designed so that it's easy to extend them). I'm just curious if > there is any technical consideration/limitation preventing us to have these > operators or is it because they were never been requested? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DELTASPIKE-1299) Order by items are applied in alphabetic order
[
https://issues.apache.org/jira/browse/DELTASPIKE-1299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248896#comment-16248896
]
ASF GitHub Bot commented on DELTASPIKE-1299:
GitHub user Mobe91 opened a pull request:
https://github.com/apache/deltaspike/pull/75
DELTASPIKE-1299: fixed orderby item order
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Mobe91/deltaspike DELTASPIKE-1299
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/deltaspike/pull/75.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #75
commit 873886ee2bb4fa6a9d61dae66b18757f0bb85f32
Author: Moritz Becker
Date: 2017-11-12T15:30:13Z
DELTASPIKE-1299: fixed orderby item order
> Order by items are applied in alphabetic order
> --
>
> Key: DELTASPIKE-1299
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1299
> Project: DeltaSpike
> Issue Type: Bug
> Components: Data-Module
>Affects Versions: 1.8.0
>Reporter: Moritz Becker
>
> DeltaSpike data applies the order bys in parsed methods in alphabetic order
> which leads to semantically incorrect queries.
> For example, the method {{findAllOrderByNameAscIdDesc}} produces the
> following query:
> {code:sql}
> select * from ... order by id desc, name asc
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (DELTASPIKE-1278) PropertyFileConfig does not respect optional on external resources
[
https://issues.apache.org/jira/browse/DELTASPIKE-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124734#comment-16124734
]
ASF GitHub Bot commented on DELTASPIKE-1278:
Github user asfgit closed the pull request at:
https://github.com/apache/deltaspike/pull/74
> PropertyFileConfig does not respect optional on external resources
> --
>
> Key: DELTASPIKE-1278
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1278
> Project: DeltaSpike
> Issue Type: Bug
> Components: Configuration
>Affects Versions: 1.8.0
>Reporter: Dennis Rippinger
>
> Adding a property file from an external location (e.g. local file system)
> marked as optional is not respected by {{PropertyFileUtils}}. It creates a
> list of possible resource URLs, but does not check for their existence in all
> branches of its logic. This results in a list of possible nonexistent
> resources which could be optional, leading to an IllegalStateException.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (DELTASPIKE-1278) PropertyFileConfig does not respect optional on external resources
[
https://issues.apache.org/jira/browse/DELTASPIKE-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16071623#comment-16071623
]
ASF GitHub Bot commented on DELTASPIKE-1278:
GitHub user DennisRippinger opened a pull request:
https://github.com/apache/deltaspike/pull/74
DELTASPIKE-1278: Added an additonal check
This PR adds an additional check to ensure that a given file url does
exist. This allows the `EnvironmentPropertyConfigSourceProvider` to respect a
positive optional flag. It is still to question how to handle other non
`file:\\` urls. I also thought about making optional handling part of
`PropertyFileUtils#loadProperties`but wasn't sure if this brings problems to
other places.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DennisRippinger/deltaspike DELTASPIKE-1278
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/deltaspike/pull/74.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #74
commit 158acc70d729328b3c507bd9809de2e5de685c1d
Author: Dennis Rippinger
Date: 2017-07-02T12:43:31Z
DELTASPIKE-1278: Added an additonal check to ensure local resources do
exist to respect optional flag.
> PropertyFileConfig does not respect optional on external resources
> --
>
> Key: DELTASPIKE-1278
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1278
> Project: DeltaSpike
> Issue Type: Bug
> Components: Configuration
>Affects Versions: 1.8.0
>Reporter: Dennis Rippinger
>
> Adding a property file from an external location (e.g. local file system)
> marked as optional is not respected by {{PropertyFileUtils}}. It creates a
> list of possible resource URLs, but does not check for their existence in all
> branches of its logic. This results in a list of possible nonexistent
> resources which could be optional, leading to an IllegalStateException.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (DELTASPIKE-1224) Use newer release version of Apache RAT / release audit tool
[
https://issues.apache.org/jira/browse/DELTASPIKE-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15696436#comment-15696436
]
ASF GitHub Bot commented on DELTASPIKE-1224:
Github user asfgit closed the pull request at:
https://github.com/apache/deltaspike/pull/72
> Use newer release version of Apache RAT / release audit tool
>
>
> Key: DELTASPIKE-1224
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1224
> Project: DeltaSpike
> Issue Type: Improvement
> Components: Build
>Affects Versions: 1.7.2
> Environment: HEAD
>Reporter: Philipp Ottlinger
> Fix For: 1.8.0
>
> Attachments: DELTASPIKE-1224_useNewerRAT.diff
>
>
> Currently v0.8 is used, while the latest release is 0.12.
> {code}
> diff --git a/deltaspike/pom.xml b/deltaspike/pom.xml
> index 1460bb0..dd6835f 100644
> --- a/deltaspike/pom.xml
> +++ b/deltaspike/pom.xml
> @@ -83,7 +83,7 @@
>
> org.apache.rat
> apache-rat-plugin
> -0.8
> +0.12
>
>
> .idea/**/*
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1224) Use newer release version of Apache RAT / release audit tool
[
https://issues.apache.org/jira/browse/DELTASPIKE-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15694276#comment-15694276
]
ASF GitHub Bot commented on DELTASPIKE-1224:
GitHub user ottlinger opened a pull request:
https://github.com/apache/deltaspike/pull/72
DELTASPIKE-1224: update to latest RAT release
Update to latest RAT release -
https://issues.apache.org/jira/browse/DELTASPIKE-1224
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ottlinger/deltaspike master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/deltaspike/pull/72.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #72
commit a94386f019225f42aa051673c99da09ddccb1094
Author: P. Ottlinger
Date: 2016-11-24T21:48:58Z
DELTASPIKE-1224: update to latest RAT release
Update to latest RAT release -
https://issues.apache.org/jira/browse/DELTASPIKE-1224
> Use newer release version of Apache RAT / release audit tool
>
>
> Key: DELTASPIKE-1224
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1224
> Project: DeltaSpike
> Issue Type: Improvement
> Components: Build
>Affects Versions: 1.7.2
> Environment: HEAD
>Reporter: Philipp Ottlinger
> Fix For: 1.8.0
>
> Attachments: DELTASPIKE-1224_useNewerRAT.diff
>
>
> Currently v0.8 is used, while the latest release is 0.12.
> {code}
> diff --git a/deltaspike/pom.xml b/deltaspike/pom.xml
> index 1460bb0..dd6835f 100644
> --- a/deltaspike/pom.xml
> +++ b/deltaspike/pom.xml
> @@ -83,7 +83,7 @@
>
> org.apache.rat
> apache-rat-plugin
> -0.8
> +0.12
>
>
> .idea/**/*
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1216) AbstractFullEntityRepository should implement FullEntityRepository
[ https://issues.apache.org/jira/browse/DELTASPIKE-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15642679#comment-15642679 ] ASF GitHub Bot commented on DELTASPIKE-1216: Github user asfgit closed the pull request at: https://github.com/apache/deltaspike/pull/71 > AbstractFullEntityRepository should implement FullEntityRepository > -- > > Key: DELTASPIKE-1216 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-1216 > Project: DeltaSpike > Issue Type: Improvement > Components: Data-Module >Affects Versions: 1.7.1 >Reporter: Anthony Vanelverdinghe >Priority: Minor > > In practice, AbstractFullEntityRepository implements the FullEntityRepository > interface, but it's not specified to do so in its implements clause. > Because of this: > - it's not immediately obvious from AbstractFullEntityRepository's Javadoc > that it actually implements FullEntityRepository > - and, analog, FullEntityRepository's Javadoc doesn't have an "All Known > Implementing Classes:" clause which lists AbstractFullEntityRepository -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1216) AbstractFullEntityRepository should implement FullEntityRepository
[ https://issues.apache.org/jira/browse/DELTASPIKE-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15633768#comment-15633768 ] ASF GitHub Bot commented on DELTASPIKE-1216: GitHub user anthonyvdotbe opened a pull request: https://github.com/apache/deltaspike/pull/71 DELTASPIKE-1216 AbstractFullEntityRepository should implement FullEnt… …ityRepository You can merge this pull request into a Git repository by running: $ git pull https://github.com/anthonyvdotbe/deltaspike DELTASPIKE-1216 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/deltaspike/pull/71.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #71 > AbstractFullEntityRepository should implement FullEntityRepository > -- > > Key: DELTASPIKE-1216 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-1216 > Project: DeltaSpike > Issue Type: Improvement > Components: Data-Module >Affects Versions: 1.7.1 >Reporter: Anthony Vanelverdinghe >Priority: Minor > > In practice, AbstractFullEntityRepository implements the FullEntityRepository > interface, but it's not specified to do so in its implements clause. > Because of this: > - it's not immediately obvious from AbstractFullEntityRepository's Javadoc > that it actually implements FullEntityRepository > - and, analog, FullEntityRepository's Javadoc doesn't have an "All Known > Implementing Classes:" clause which lists AbstractFullEntityRepository -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1211) SingleResultType.OPTIONAL refers to nonexistent constant SINGLE
[ https://issues.apache.org/jira/browse/DELTASPIKE-1211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15621468#comment-15621468 ] ASF GitHub Bot commented on DELTASPIKE-1211: Github user anthonyvdotbe closed the pull request at: https://github.com/apache/deltaspike/pull/70 > SingleResultType.OPTIONAL refers to nonexistent constant SINGLE > --- > > Key: DELTASPIKE-1211 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-1211 > Project: DeltaSpike > Issue Type: Bug > Components: Data-Module >Affects Versions: 1.7.1 >Reporter: Anthony Vanelverdinghe >Assignee: John D. Ament >Priority: Trivial > Fix For: 1.7.2 > > > The > [Javadoc|https://deltaspike.apache.org/javadoc/1.7.1/org/apache/deltaspike/data/api/SingleResultType.html#OPTIONAL] > of SingleResultType.OPTIONAL refers to the nonexistent constant SINGLE, > instead of the intended constant JPA. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1209) Textual fixes for documentation of Data Module
[ https://issues.apache.org/jira/browse/DELTASPIKE-1209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15621466#comment-15621466 ] ASF GitHub Bot commented on DELTASPIKE-1209: Github user anthonyvdotbe closed the pull request at: https://github.com/apache/deltaspike/pull/68 > Textual fixes for documentation of Data Module > -- > > Key: DELTASPIKE-1209 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-1209 > Project: DeltaSpike > Issue Type: Bug > Components: Data-Module, Documentation >Reporter: Anthony Vanelverdinghe >Assignee: John D. Ament >Priority: Trivial > Labels: documentation > Fix For: 1.7.2 > > > * cenertalization -> centralization > * are outlines -> are outlined > * simples way -> simplest way > * of your query DeltaSpike expects -> of your query. DeltaSpike expects > * While repositories defines several base interfaces -> While several base > interfaces are defined for repositories > * mapResultList(List -> mapResultList(List > * override two methods -> override three methods > * Beside keeping track -> Besides keeping track > * Transactions code example -> add DelegateQueryHandler -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1210) DelegateQueryHandler has missing Javadoc
[
https://issues.apache.org/jira/browse/DELTASPIKE-1210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15621467#comment-15621467
]
ASF GitHub Bot commented on DELTASPIKE-1210:
Github user anthonyvdotbe closed the pull request at:
https://github.com/apache/deltaspike/pull/69
> DelegateQueryHandler has missing Javadoc
>
>
> Key: DELTASPIKE-1210
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1210
> Project: DeltaSpike
> Issue Type: Bug
> Components: Data-Module
>Affects Versions: 1.7.1
>Reporter: Anthony Vanelverdinghe
>Assignee: John D. Ament
>Priority: Trivial
> Fix For: 1.7.2
>
>
> The
> [Javadoc|https://deltaspike.apache.org/javadoc/1.7.1/org/apache/deltaspike/data/spi/DelegateQueryHandler.html]
> of DelegateQueryHandler says:
> {quote}
> The extension is now usable with:
> {quote}
> without giving an actual example.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1211) SingleResultType.OPTIONAL refers to nonexistent constant SINGLE
[ https://issues.apache.org/jira/browse/DELTASPIKE-1211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615190#comment-15615190 ] ASF GitHub Bot commented on DELTASPIKE-1211: GitHub user anthonyvdotbe opened a pull request: https://github.com/apache/deltaspike/pull/70 DELTASPIKE-1211: Fix SingleResultType Javadoc link You can merge this pull request into a Git repository by running: $ git pull https://github.com/anthonyvdotbe/deltaspike DELTASPIKE-1211 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/deltaspike/pull/70.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #70 commit d53ffdbfac68b978273b942898e2e81101f53891 Author: Anthony Vanelverdinghe Date: 2016-10-28T11:55:52Z DELTASPIKE-1211: Fix SingleResultType Javadoc link > SingleResultType.OPTIONAL refers to nonexistent constant SINGLE > --- > > Key: DELTASPIKE-1211 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-1211 > Project: DeltaSpike > Issue Type: Bug > Components: Data-Module >Affects Versions: 1.7.1 >Reporter: Anthony Vanelverdinghe >Priority: Trivial > > The > [Javadoc|https://deltaspike.apache.org/javadoc/1.7.1/org/apache/deltaspike/data/api/SingleResultType.html#OPTIONAL] > of SingleResultType.OPTIONAL refers to the nonexistent constant SINGLE, > instead of the intended constant JPA. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1210) DelegateQueryHandler has missing Javadoc
[
https://issues.apache.org/jira/browse/DELTASPIKE-1210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615172#comment-15615172
]
ASF GitHub Bot commented on DELTASPIKE-1210:
GitHub user anthonyvdotbe opened a pull request:
https://github.com/apache/deltaspike/pull/69
DELTASPIKE-1210: DelegateQueryHandler Javadoc fix
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/anthonyvdotbe/deltaspike DELTASPIKE-1210
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/deltaspike/pull/69.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #69
commit cea1d787a4845b100a261bb3328636d316a5f606
Author: Anthony Vanelverdinghe
Date: 2016-10-28T11:46:44Z
DELTASPIKE-1210: DelegateQueryHandler Javadoc fix
> DelegateQueryHandler has missing Javadoc
>
>
> Key: DELTASPIKE-1210
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1210
> Project: DeltaSpike
> Issue Type: Bug
> Components: Data-Module
>Affects Versions: 1.7.1
>Reporter: Anthony Vanelverdinghe
>Priority: Trivial
>
> The
> [Javadoc|https://deltaspike.apache.org/javadoc/1.7.1/org/apache/deltaspike/data/spi/DelegateQueryHandler.html]
> of DelegateQueryHandler says:
> {quote}
> The extension is now usable with:
> {quote}
> without giving an actual example.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1209) Textual fixes for documentation of Data Module
[ https://issues.apache.org/jira/browse/DELTASPIKE-1209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615138#comment-15615138 ] ASF GitHub Bot commented on DELTASPIKE-1209: GitHub user anthonyvdotbe opened a pull request: https://github.com/apache/deltaspike/pull/68 DELTASPIKE-1209: Update Data Module documentation You can merge this pull request into a Git repository by running: $ git pull https://github.com/anthonyvdotbe/deltaspike DELTASPIKE-1209 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/deltaspike/pull/68.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #68 commit ebe1a0224e4011358449933b51a14d2fed95e600 Author: Anthony Vanelverdinghe Date: 2016-10-28T11:25:45Z DELTASPIKE-1209: Update Data Module documentation > Textual fixes for documentation of Data Module > -- > > Key: DELTASPIKE-1209 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-1209 > Project: DeltaSpike > Issue Type: Bug > Components: Data-Module, Documentation >Reporter: Anthony Vanelverdinghe >Priority: Trivial > Labels: documentation > > * cenertalization -> centralization > * are outlines -> are outlined > * simples way -> simplest way > * of your query DeltaSpike expects -> of your query. DeltaSpike expects > * While repositories defines several base interfaces -> While several base > interfaces are defined for repositories > * mapResultList(List -> mapResultList(List > * override two methods -> override three methods > * Beside keeping track -> Besides keeping track > * Transactions code example -> add DelegateQueryHandler -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1208) deltaspike configuration: Variable Replacement in Configured Values is NOT fully stage aware
[
https://issues.apache.org/jira/browse/DELTASPIKE-1208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15613949#comment-15613949
]
ASF GitHub Bot commented on DELTASPIKE-1208:
Github user asfgit closed the pull request at:
https://github.com/apache/deltaspike/pull/67
> deltaspike configuration: Variable Replacement in Configured Values is NOT
> fully stage aware
>
>
> Key: DELTASPIKE-1208
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1208
> Project: DeltaSpike
> Issue Type: Bug
> Components: Configuration
>Affects Versions: 1.7.1
>Reporter: Valentin Maechler
>Assignee: John D. Ament
>Priority: Minor
> Fix For: 1.7.2
>
> Attachments: DELTASPIKE-1208.patch
>
>
> using the following apache-deltaspike.properties
> {code}
> some-service-url=${edge-server-url}/some-service
> edge-server-url=undefined
> edge-server-url.Development=http://development:8081
> edge-server-url.Staging=http://staging:8081
> edge-server-url.Production=http://prod:8081
> {code}
> and executing the following code:
> {code}
> System.out.println("some-service-url="+ConfigResolver.getProjectStageAwarePropertyValue("some-service-url"));
> {code}
> having the following java VM arg set:
> {code}
> -Dorg.apache.deltaspike.ProjectStage=Staging
> {code}
> should result in the output:
> some-service-url=http://staging:8081/some-service
> I have already contributed a bug fix for DELTASPIKE-1167 - unfortunately that
> didn't fully solve the issue.
> -I plan to provide a fix for this soon.- [UPDATE] patch added
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1207) Incorrect exception handling in DynamicMBeanWrapper.invoke()
[
https://issues.apache.org/jira/browse/DELTASPIKE-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15613831#comment-15613831
]
ASF GitHub Bot commented on DELTASPIKE-1207:
Github user asfgit closed the pull request at:
https://github.com/apache/deltaspike/pull/66
> Incorrect exception handling in DynamicMBeanWrapper.invoke()
>
>
> Key: DELTASPIKE-1207
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1207
> Project: DeltaSpike
> Issue Type: Bug
> Components: Core
>Affects Versions: 1.7.1
>Reporter: Falko Modler
>
> {{DynamicMBeanWrapper.invoke(String, Object[], String[])}} just re-throws any
> exception as a {{RuntimeException}}.
> This makes it impossible for a client to determine the specific exception
> which might have been thrown on purpose by the MBean method. See also:
> {code:java|title=JavaDoc of javax.management.DynamicMBean.invoke(String,
> Object[], String[])}
> ...
> * @exception MBeanException Wraps a java.lang.Exception
> thrown by the MBean's invoked method.
> * @exception ReflectionException Wraps a
> java.lang.Exception thrown while trying to invoke the method
> */
> public Object invoke(String actionName, Object params[], String
> signature[])
> throws MBeanException, ReflectionException ;
> {code}
> So the correct approach is to handle {{InvocationTargetException}}
> specifically by wrapping it's *cause* in a {{MBeanException}} and throwing
> that {{MBeanException}}.
> All other exceptions should be wrapped in a {{ReflectionException}}.
> PS: I filed DELTASPIKE-984 some time ago which led to a slight improvement of
> the very same {{invoke}} method but obviously my suggestions regarding
> {{MBeanException}} haven't been considered (I don't know why).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1189) Migrate index.html into git
[ https://issues.apache.org/jira/browse/DELTASPIKE-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15613830#comment-15613830 ] ASF GitHub Bot commented on DELTASPIKE-1189: Github user asfgit closed the pull request at: https://github.com/apache/deltaspike/pull/62 > Migrate index.html into git > --- > > Key: DELTASPIKE-1189 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-1189 > Project: DeltaSpike > Issue Type: Task > Components: Documentation >Reporter: John D. Ament >Assignee: Andrea Cosentino > Fix For: 1.7.2 > > Attachments: index_adoc_reformatting.patch > > > Our index.html is still managed in subversion. We should move this into git. > Source file can be found at > http://svn.apache.org/repos/asf/deltaspike/site/trunk/content/index.html > It should end up in the site module of the build. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1208) deltaspike configuration: Variable Replacement in Configured Values is NOT fully stage aware
[
https://issues.apache.org/jira/browse/DELTASPIKE-1208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15590918#comment-15590918
]
ASF GitHub Bot commented on DELTASPIKE-1208:
GitHub user maecval opened a pull request:
https://github.com/apache/deltaspike/pull/67
DELTASPIKE-1208: Fixed variable replacement in configured values for …
### deltaspike configuration issue DELTASPIKE-1208
(https://issues.apache.org/jira/browse/DELTASPIKE-1208)
This solves the issue that the "foo.bar" was not resolved correctly in the
following case when using getProjectStageAwarePropertyValue.
configuration values:
```
foo.url=${bar.url}/services
bar.url=undefined
bar.url.UnitTest=http://bar-dev
bar.url.Production=http://bar-prod
```
Expected for project stage "Production"
```
http://bar-prod/services
```
when executing
```
ConfigResolver.getProjectStageAwarePropertyValue("foo.url")
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/maecval/deltaspike DELTASPIKE-1208
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/deltaspike/pull/67.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #67
commit 0c90a6188f63b731bab119074d9f903ffc530ea5
Author: tzhmava4
Date: 2016-10-20T05:52:42Z
DELTASPIKE-1208: Fixed variable replacement in configured values for
getProjectStageAwarePropertyValue
> deltaspike configuration: Variable Replacement in Configured Values is NOT
> fully stage aware
>
>
> Key: DELTASPIKE-1208
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1208
> Project: DeltaSpike
> Issue Type: Bug
> Components: Configuration
>Affects Versions: 1.7.1
>Reporter: Valentin Maechler
>Assignee: John D. Ament
>Priority: Minor
> Fix For: 1.7.2
>
> Attachments: DELTASPIKE-1208.patch
>
>
> using the following apache-deltaspike.properties
> {code}
> some-service-url=${edge-server-url}/some-service
> edge-server-url=undefined
> edge-server-url.Development=http://development:8081
> edge-server-url.Staging=http://staging:8081
> edge-server-url.Production=http://prod:8081
> {code}
> and executing the following code:
> {code}
> System.out.println("some-service-url="+ConfigResolver.getProjectStageAwarePropertyValue("some-service-url"));
> {code}
> having the following java VM arg set:
> {code}
> -Dorg.apache.deltaspike.ProjectStage=Staging
> {code}
> should result in the output:
> some-service-url=http://staging:8081/some-service
> I have already contributed a bug fix for DELTASPIKE-1167 - unfortunately that
> didn't fully solve the issue.
> -I plan to provide a fix for this soon.- [UPDATE] patch added
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1207) Incorrect exception handling in DynamicMBeanWrapper.invoke()
[
https://issues.apache.org/jira/browse/DELTASPIKE-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15586765#comment-15586765
]
ASF GitHub Bot commented on DELTASPIKE-1207:
GitHub user famod opened a pull request:
https://github.com/apache/deltaspike/pull/66
DELTASPIKE-1207: fix exception handling in DynamicMBeanWrapper.invoke()
Ok, this fix enables the transfer of a exception thrown by the MBean method
to the client.
Tomorrow I'm going to update the JIRA ticket with some output examples.
Not sure about the logging removal, though. In my project we have a logging
interceptor for MBeans which logs exceptions anyway so another log entry from
DynamicMBeanWrapper just "pollutes" the logfile.
Exceptions aren't swallowed either, so ...
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/famod/deltaspike DELTASPIKE-1207
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/deltaspike/pull/66.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #66
commit 0bd61f2fa4d2c08b7554d5f2826b9c99cad8e7a6
Author: famod
Date: 2016-10-16T20:17:47Z
DELTASPIKE-1207: fix exception handling in DynamicMBeanWrapper.invoke()
commit 6252c3998756b1f2eb6e0835c9583ec489f88cd6
Author: famod
Date: 2016-10-16T20:28:29Z
DELTASPIKE-1207: fix exception handling in DynamicMBeanWrapper.invoke()
fix tabs
commit d19e47b0b9252b046e7e1a82be0ba6b7608f5e07
Author: famod
Date: 2016-10-16T20:55:18Z
DELTASPIKE-1207: fix exception handling in DynamicMBeanWrapper.invoke()
remove unnecessary cast to Exception
commit 717f6fd08aaa38089002d0832da3a01529474bb1
Author: famod
Date: 2016-10-16T21:24:49Z
DELTASPIKE-1207: fix exception handling in DynamicMBeanWrapper.invoke()
cause needs to be passed to MBeanException constructor, not e (and so
casting is needed after all)
commit d341dc8f0900054c5e7f46d1833ede749c0c597f
Author: famod
Date: 2016-10-18T21:40:24Z
DELTASPIKE-1207: fix exception handling in DynamicMBeanWrapper.invoke()
- don't wrap MBeanException directly thrown by the MBean method
- document exception handling in @JmxManaged
> Incorrect exception handling in DynamicMBeanWrapper.invoke()
>
>
> Key: DELTASPIKE-1207
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1207
> Project: DeltaSpike
> Issue Type: Bug
> Components: Core
>Affects Versions: 1.7.1
>Reporter: Falko Modler
>
> {{DynamicMBeanWrapper.invoke(String, Object[], String[])}} just re-throws any
> exception as a {{RuntimeException}}.
> This makes it impossible for a client to determine the specific exception
> which might have been thrown on purpose by the MBean method. See also:
> {code:java|title=JavaDoc of javax.management.DynamicMBean.invoke(String,
> Object[], String[])}
> ...
> * @exception MBeanException Wraps a java.lang.Exception
> thrown by the MBean's invoked method.
> * @exception ReflectionException Wraps a
> java.lang.Exception thrown while trying to invoke the method
> */
> public Object invoke(String actionName, Object params[], String
> signature[])
> throws MBeanException, ReflectionException ;
> {code}
> So the correct approach is to handle {{InvocationTargetException}}
> specifically by wrapping it's *cause* in a {{MBeanException}} and throwing
> that {{MBeanException}}.
> All other exceptions should be wrapped in a {{ReflectionException}}.
> PS: I filed DELTASPIKE-984 some time ago which led to a slight improvement of
> the very same {{invoke}} method but obviously my suggestions regarding
> {{MBeanException}} haven't been considered (I don't know why).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1201) add logout link to security example
[ https://issues.apache.org/jira/browse/DELTASPIKE-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15578292#comment-15578292 ] ASF GitHub Bot commented on DELTASPIKE-1201: Github user subaochen closed the pull request at: https://github.com/apache/deltaspike/pull/64 > add logout link to security example > --- > > Key: DELTASPIKE-1201 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-1201 > Project: DeltaSpike > Issue Type: Improvement > Components: Examples >Affects Versions: 1.7.2, 1.8.0 > Environment: ubuntu 15.04, wildfly 10.0.0.Final, JDK 1.8 >Reporter: Su Baochen >Priority: Minor > Labels: examples > Fix For: 1.7.2 > > Original Estimate: 1h > Remaining Estimate: 1h > > add logout link to secured page, so people can logout to return the home > page, then can try to relogin and then on. > Also, move @Secured(LogginAccessDecisionVoter.class) to Folder, in order to > protect the whole secured folder. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1203) create jpa examples
[ https://issues.apache.org/jira/browse/DELTASPIKE-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15578291#comment-15578291 ] ASF GitHub Bot commented on DELTASPIKE-1203: Github user subaochen closed the pull request at: https://github.com/apache/deltaspike/pull/65 > create jpa examples > --- > > Key: DELTASPIKE-1203 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-1203 > Project: DeltaSpike > Issue Type: Improvement > Components: Examples >Affects Versions: 1.7.2 >Reporter: Su Baochen >Priority: Minor > Labels: examples > Fix For: 1.7.2 > > > create new examples to show how to use jpa module -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1176) Support void methods in Futureable
[ https://issues.apache.org/jira/browse/DELTASPIKE-1176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15545824#comment-15545824 ] ASF GitHub Bot commented on DELTASPIKE-1176: Github user kalgon closed the pull request at: https://github.com/apache/deltaspike/pull/60 > Support void methods in Futureable > -- > > Key: DELTASPIKE-1176 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-1176 > Project: DeltaSpike > Issue Type: New Feature > Components: Core >Affects Versions: 1.7.0 >Reporter: John D. Ament >Assignee: Romain Manni-Bucau > Fix For: 1.7.2 > > > https://lists.apache.org/thread.html/73efae4ef5b2462af7165d5cb233557b8f97393355c8edb704eff53f@%3Cusers.deltaspike.apache.org%3E > for more context > It appears that if a method returns void it cannot be used with the > Futureable interceptor. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1203) create jpa examples
[ https://issues.apache.org/jira/browse/DELTASPIKE-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15492669#comment-15492669 ] ASF GitHub Bot commented on DELTASPIKE-1203: GitHub user subaochen opened a pull request: https://github.com/apache/deltaspike/pull/65 DELTASPIKE-1203:jpa example hi, Here is the basic Deltaspike JPA example, please double check it, thanks! You can merge this pull request into a Git repository by running: $ git pull https://github.com/subaochen/deltaspike DELTASPIKE-1203 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/deltaspike/pull/65.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #65 commit 9cd33317c128109efb53e83196d5d41d19ff68fd Author: subaochen Date: 2016-09-11T13:54:07Z DELTASPIKE-1203:jpa example > create jpa examples > --- > > Key: DELTASPIKE-1203 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-1203 > Project: DeltaSpike > Issue Type: Improvement > Components: Examples >Affects Versions: 1.7.2 >Reporter: Su Baochen >Priority: Minor > Labels: examples > Fix For: 1.7.2 > > > create new examples to show how to use jpa module -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1201) add logout link to security example
[ https://issues.apache.org/jira/browse/DELTASPIKE-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15469803#comment-15469803 ] ASF GitHub Bot commented on DELTASPIKE-1201: GitHub user subaochen opened a pull request: https://github.com/apache/deltaspike/pull/64 DELTASPIKE-1201: add logout link to secured/home.xhtml Hi, recreate the PR with DELTASPIKE-1201, please double check it, thanks! You can merge this pull request into a Git repository by running: $ git pull https://github.com/subaochen/deltaspike DELTASPIKE-1201 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/deltaspike/pull/64.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #64 commit 85f4d08786152e04c8029fee03230a18019af6e9 Author: subaochen Date: 2016-09-07T06:58:47Z DELTASPIKE-1201: add logout link to secured/home.xhtml > add logout link to security example > --- > > Key: DELTASPIKE-1201 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-1201 > Project: DeltaSpike > Issue Type: Improvement > Components: Examples >Affects Versions: 1.7.2, 1.8.0 > Environment: ubuntu 15.04, wildfly 10.0.0.Final, JDK 1.8 >Reporter: Su Baochen >Priority: Minor > Labels: examples > Fix For: 1.7.2 > > Original Estimate: 1h > Remaining Estimate: 1h > > add logout link to secured page, so people can logout to return the home > page, then can try to relogin and then on. > Also, move @Secured(LogginAccessDecisionVoter.class) to Folder, in order to > protect the whole secured folder. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1188) Improve contributor guide
[ https://issues.apache.org/jira/browse/DELTASPIKE-1188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15420518#comment-15420518 ] ASF GitHub Bot commented on DELTASPIKE-1188: Github user asfgit closed the pull request at: https://github.com/apache/deltaspike/pull/61 > Improve contributor guide > - > > Key: DELTASPIKE-1188 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-1188 > Project: DeltaSpike > Issue Type: Task > Components: Documentation >Reporter: John D. Ament >Assignee: John D. Ament > Fix For: 1.7.2 > > > Create an improved contributor guide that goes over the github PR process -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1176) Support void methods in Futureable
[ https://issues.apache.org/jira/browse/DELTASPIKE-1176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15400564#comment-15400564 ] ASF GitHub Bot commented on DELTASPIKE-1176: Github user rmannibucau commented on a diff in the pull request: https://github.com/apache/deltaspike/pull/60#discussion_r72884376 --- Diff: deltaspike/core/impl/src/main/java/org/apache/deltaspike/core/impl/future/DefaultFutureableStrategy.java --- @@ -202,6 +203,13 @@ public Object call() throws Exception }; final ExecutorService pool = getOrCreatePool(ic); + +if (void.class.isAssignableFrom(returnType)) --- End diff -- for me yes > Support void methods in Futureable > -- > > Key: DELTASPIKE-1176 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-1176 > Project: DeltaSpike > Issue Type: New Feature > Components: Core >Affects Versions: 1.7.0 >Reporter: John D. Ament >Assignee: Romain Manni-Bucau > Fix For: 1.7.2 > > > https://lists.apache.org/thread.html/73efae4ef5b2462af7165d5cb233557b8f97393355c8edb704eff53f@%3Cusers.deltaspike.apache.org%3E > for more context > It appears that if a method returns void it cannot be used with the > Futureable interceptor. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1176) Support void methods in Futureable
[ https://issues.apache.org/jira/browse/DELTASPIKE-1176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15400358#comment-15400358 ] ASF GitHub Bot commented on DELTASPIKE-1176: Github user johnament commented on a diff in the pull request: https://github.com/apache/deltaspike/pull/60#discussion_r72879629 --- Diff: deltaspike/core/impl/src/main/java/org/apache/deltaspike/core/impl/future/DefaultFutureableStrategy.java --- @@ -202,6 +203,13 @@ public Object call() throws Exception }; final ExecutorService pool = getOrCreatePool(ic); + +if (void.class.isAssignableFrom(returnType)) --- End diff -- good to merge then? > Support void methods in Futureable > -- > > Key: DELTASPIKE-1176 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-1176 > Project: DeltaSpike > Issue Type: New Feature > Components: Core >Affects Versions: 1.7.0 >Reporter: John D. Ament >Assignee: Romain Manni-Bucau > Fix For: 1.7.2 > > > https://lists.apache.org/thread.html/73efae4ef5b2462af7165d5cb233557b8f97393355c8edb704eff53f@%3Cusers.deltaspike.apache.org%3E > for more context > It appears that if a method returns void it cannot be used with the > Futureable interceptor. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1189) Migrate index.html into git
[ https://issues.apache.org/jira/browse/DELTASPIKE-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391114#comment-15391114 ] ASF GitHub Bot commented on DELTASPIKE-1189: GitHub user oscerd opened a pull request: https://github.com/apache/deltaspike/pull/62 DELTASPIKE-1189 Migrate index.html into git Hi all, The PR is related to: https://issues.apache.org/jira/browse/DELTASPIKE-1189 Thanks! :-) You can merge this pull request into a Git repository by running: $ git pull https://github.com/oscerd/deltaspike Deltaspike-1189 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/deltaspike/pull/62.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #62 commit 9699512a7cd5ce0b7d3c9d1f90169d5b440cc41f Author: Andrea Cosentino Date: 2016-07-24T17:12:55Z DELTASPIKE-1189 Migrate index.html into git > Migrate index.html into git > --- > > Key: DELTASPIKE-1189 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-1189 > Project: DeltaSpike > Issue Type: Task > Components: Documentation >Reporter: John D. Ament > Fix For: 1.7.2 > > > Our index.html is still managed in subversion. We should move this into git. > Source file can be found at > http://svn.apache.org/repos/asf/deltaspike/site/trunk/content/index.html > It should end up in the site module of the build. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1176) Support void methods in Futureable
[ https://issues.apache.org/jira/browse/DELTASPIKE-1176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391054#comment-15391054 ] ASF GitHub Bot commented on DELTASPIKE-1176: Github user rmannibucau commented on a diff in the pull request: https://github.com/apache/deltaspike/pull/60#discussion_r71988281 --- Diff: deltaspike/core/impl/src/main/java/org/apache/deltaspike/core/impl/future/DefaultFutureableStrategy.java --- @@ -202,6 +203,13 @@ public Object call() throws Exception }; final ExecutorService pool = getOrCreatePool(ic); + +if (void.class.isAssignableFrom(returnType)) --- End diff -- think void is enough, using Void is a workaround IMO and not a clean programming model we should promote. If we get some feedbacks justifying this we can add it later. Alternative is to add a Handler depending the returned type and a kind of SPI but looks overkilled today. > Support void methods in Futureable > -- > > Key: DELTASPIKE-1176 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-1176 > Project: DeltaSpike > Issue Type: New Feature > Components: Core >Affects Versions: 1.7.0 >Reporter: John D. Ament >Assignee: Romain Manni-Bucau > Fix For: 1.7.2 > > > https://lists.apache.org/thread.html/73efae4ef5b2462af7165d5cb233557b8f97393355c8edb704eff53f@%3Cusers.deltaspike.apache.org%3E > for more context > It appears that if a method returns void it cannot be used with the > Futureable interceptor. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1176) Support void methods in Futureable
[ https://issues.apache.org/jira/browse/DELTASPIKE-1176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391053#comment-15391053 ] ASF GitHub Bot commented on DELTASPIKE-1176: Github user r-tt commented on a diff in the pull request: https://github.com/apache/deltaspike/pull/60#discussion_r71988266 --- Diff: deltaspike/core/impl/src/main/java/org/apache/deltaspike/core/impl/future/DefaultFutureableStrategy.java --- @@ -202,6 +203,13 @@ public Object call() throws Exception }; final ExecutorService pool = getOrCreatePool(ic); + +if (void.class.isAssignableFrom(returnType)) --- End diff -- think `void` is enough, using Void is a workaround IMO and not a clean programming model we should promote. If we get some feedbacks justifying this we can add it later. Alternative is to add a `Handler` depending the returned type and a kind of SPI but looks overkilled _today_. > Support void methods in Futureable > -- > > Key: DELTASPIKE-1176 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-1176 > Project: DeltaSpike > Issue Type: New Feature > Components: Core >Affects Versions: 1.7.0 >Reporter: John D. Ament >Assignee: Romain Manni-Bucau > Fix For: 1.7.2 > > > https://lists.apache.org/thread.html/73efae4ef5b2462af7165d5cb233557b8f97393355c8edb704eff53f@%3Cusers.deltaspike.apache.org%3E > for more context > It appears that if a method returns void it cannot be used with the > Futureable interceptor. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1176) Support void methods in Futureable
[ https://issues.apache.org/jira/browse/DELTASPIKE-1176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391034#comment-15391034 ] ASF GitHub Bot commented on DELTASPIKE-1176: Github user johnament commented on a diff in the pull request: https://github.com/apache/deltaspike/pull/60#discussion_r71987310 --- Diff: deltaspike/core/impl/src/main/java/org/apache/deltaspike/core/impl/future/DefaultFutureableStrategy.java --- @@ -202,6 +203,13 @@ public Object call() throws Exception }; final ExecutorService pool = getOrCreatePool(ic); + +if (void.class.isAssignableFrom(returnType)) --- End diff -- Should we also check for `Void` in addition to `void`? > Support void methods in Futureable > -- > > Key: DELTASPIKE-1176 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-1176 > Project: DeltaSpike > Issue Type: New Feature > Components: Core >Affects Versions: 1.7.0 >Reporter: John D. Ament >Assignee: Romain Manni-Bucau > Fix For: 1.7.2 > > > https://lists.apache.org/thread.html/73efae4ef5b2462af7165d5cb233557b8f97393355c8edb704eff53f@%3Cusers.deltaspike.apache.org%3E > for more context > It appears that if a method returns void it cannot be used with the > Futureable interceptor. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1188) Improve contributor guide
[ https://issues.apache.org/jira/browse/DELTASPIKE-1188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15390741#comment-15390741 ] ASF GitHub Bot commented on DELTASPIKE-1188: GitHub user johnament opened a pull request: https://github.com/apache/deltaspike/pull/61 DELTASPIKE-1188 Added some PR based contribution workflow. Replaced … …the mail archive link with pony. You can merge this pull request into a Git repository by running: $ git pull https://github.com/johnament/deltaspike DELTASPIKE-1188 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/deltaspike/pull/61.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #61 commit 4caa3f917670be22925fc926a9316c4ff5fc14e2 Author: John D. Ament Date: 2016-07-23T15:58:18Z DELTASPIKE-1188 Added some PR based contribution workflow. Replaced the mail archive link with pony. > Improve contributor guide > - > > Key: DELTASPIKE-1188 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-1188 > Project: DeltaSpike > Issue Type: Task > Components: Documentation >Reporter: John D. Ament >Assignee: John D. Ament > Fix For: 1.7.2 > > > Create an improved contributor guide that goes over the github PR process -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1185) Allow customization (name, description) of JMX managed methods' parameters
[
https://issues.apache.org/jira/browse/DELTASPIKE-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389325#comment-15389325
]
ASF GitHub Bot commented on DELTASPIKE-1185:
Github user asfgit closed the pull request at:
https://github.com/apache/deltaspike/pull/59
> Allow customization (name, description) of JMX managed methods' parameters
> --
>
> Key: DELTASPIKE-1185
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1185
> Project: DeltaSpike
> Issue Type: Wish
> Components: Core
>Affects Versions: 1.7.0
>Reporter: Xavier Dury
>Assignee: Xavier Dury
>Priority: Trivial
>
> Currently, it is not possible to name or give a description to parameters of
> {{@JmxManaged}} methods as {{DynamicMBeanWrapper}} uses the simple
> {{MBeanOperationInfo}} constructor which gives generic names to parameters
> like p0, p1, p2...
> It would be nice if we could annotate parameters with something like
> {{@JmxParameter(name = ..., description = ...)}} or - if using java 8 - use
> the parameter name which is available via reflection.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1176) Support void methods in Futureable
[ https://issues.apache.org/jira/browse/DELTASPIKE-1176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389315#comment-15389315 ] ASF GitHub Bot commented on DELTASPIKE-1176: GitHub user kalgon opened a pull request: https://github.com/apache/deltaspike/pull/60 DELTASPIKE-1176 Support void methods in Futureable You can merge this pull request into a Git repository by running: $ git pull https://github.com/kalgon/deltaspike DELTASPIKE-1176 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/deltaspike/pull/60.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #60 commit 0e9d0ba38dcbbd638fee4ef3ac98879ce9d9eb41 Author: Xavier Dury Date: 2016-07-22T10:56:59Z DELTASPIKE-1176 Support void methods in Futureable > Support void methods in Futureable > -- > > Key: DELTASPIKE-1176 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-1176 > Project: DeltaSpike > Issue Type: New Feature > Components: Core >Affects Versions: 1.7.0 >Reporter: John D. Ament > Fix For: 1.7.2 > > > https://lists.apache.org/thread.html/73efae4ef5b2462af7165d5cb233557b8f97393355c8edb704eff53f@%3Cusers.deltaspike.apache.org%3E > for more context > It appears that if a method returns void it cannot be used with the > Futureable interceptor. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1185) Allow customization (name, description) of JMX managed methods' parameters
[
https://issues.apache.org/jira/browse/DELTASPIKE-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387020#comment-15387020
]
ASF GitHub Bot commented on DELTASPIKE-1185:
Github user johnament commented on a diff in the pull request:
https://github.com/apache/deltaspike/pull/59#discussion_r71637833
--- Diff:
deltaspike/core/api/src/main/java/org/apache/deltaspike/core/util/ParameterUtil.java
---
@@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.deltaspike.core.util;
+
+import java.lang.reflect.InvocationTargetException;
+import java.lang.reflect.Method;
+
+import javax.enterprise.inject.Typed;
+
+@Typed()
+public abstract class ParameterUtil
+{
+private static boolean parameterSupported = true;
+private static Class parameterClass;
+private static Method getNameMethod;
+private static Method getParametersMethod;
+
+static
+{
+try
+{
+parameterClass = Class.forName("java.lang.reflect.Parameter");
--- End diff --
This is super useful, we'll be able to start adding named parameter support
in repos now.
> Allow customization (name, description) of JMX managed methods' parameters
> --
>
> Key: DELTASPIKE-1185
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1185
> Project: DeltaSpike
> Issue Type: Wish
> Components: Core
>Affects Versions: 1.7.0
>Reporter: Xavier Dury
>Priority: Trivial
>
> Currently, it is not possible to name or give a description to parameters of
> {{@JmxManaged}} methods as {{DynamicMBeanWrapper}} uses the simple
> {{MBeanOperationInfo}} constructor which gives generic names to parameters
> like p0, p1, p2...
> It would be nice if we could annotate parameters with something like
> {{@JmxParameter(name = ..., description = ...)}} or - if using java 8 - use
> the parameter name which is available via reflection.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-905) Missing OSGi headers in Proxy modules
[
https://issues.apache.org/jira/browse/DELTASPIKE-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387004#comment-15387004
]
ASF GitHub Bot commented on DELTASPIKE-905:
---
Github user asfgit closed the pull request at:
https://github.com/apache/deltaspike/pull/38
> Missing OSGi headers in Proxy modules
> -
>
> Key: DELTASPIKE-905
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-905
> Project: DeltaSpike
> Issue Type: Bug
> Components: PartialBean
>Affects Versions: 1.4.0
>Reporter: Harald Wellmann
>Assignee: Rafael Benevides
> Fix For: 1.4.1
>
>
> {{deltaspike-partial-bean-module-impl}} imports package
> {{org.apache.deltaspike.proxy.api}}, but the new proxy modules are missing
> OSGi manifest headers.
> This breaks Partial Beans and Data modules for OSGi users.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-750) No error message if the filename provided PropertyFileConfig implementation isn't found.
[ https://issues.apache.org/jira/browse/DELTASPIKE-750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387002#comment-15387002 ] ASF GitHub Bot commented on DELTASPIKE-750: --- Github user asfgit closed the pull request at: https://github.com/apache/deltaspike/pull/11 > No error message if the filename provided PropertyFileConfig implementation > isn't found. > > > Key: DELTASPIKE-750 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-750 > Project: DeltaSpike > Issue Type: Bug > Components: Configuration >Affects Versions: 1.0.3 >Reporter: Corey Puffalt >Assignee: Gerhard Petracek > Fix For: 1.2.0 > > > As per summary, I have a simple PropertyFileConfig implementation class > providing a configuration filename for the configuration module to pick up, > but I've been frustrated by the lack of error handling because it just > quietly ignores invalid/missing filenames instead of providing an error > message. > Ideally, an issue like this would prevent bootstrapping and fail-fast with a > relevant error message. > I'm not familiar enough with the code base to be sure but it looks to me like > this should be fixed in PropertyFileUtils.resolvePropertyFiles() which > should throw a FileNotFoundException if it doesn't find the given file on the > classpath? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-822) Repository method lookup in super interfaces
[ https://issues.apache.org/jira/browse/DELTASPIKE-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387006#comment-15387006 ] ASF GitHub Bot commented on DELTASPIKE-822: --- Github user asfgit closed the pull request at: https://github.com/apache/deltaspike/pull/15 > Repository method lookup in super interfaces > > > Key: DELTASPIKE-822 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-822 > Project: DeltaSpike > Issue Type: Bug > Components: Data-Module >Affects Versions: 1.2.1 >Reporter: Daniel Heinrich >Assignee: Thomas Hug > Fix For: 1.4.0 > > > When repository methods are looked up only methods from interfaces which are > implemented directly by the repository class or a super class are considered. > In the case of: > interface BaseRepository extends EntityRepository > @Repository > interface UserRepository extends BaseRepository > The UserRepository does not have any default repository methods at runtime. > NullPointerException at: > QueryHandler#createContext->CdiQueryInvocationContext() > this could be fixed at: > org.apache.deltaspike.data.impl.meta.RepositoryComponent#collectClasses -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1031) Update profiles for Wildfly
[
https://issues.apache.org/jira/browse/DELTASPIKE-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387001#comment-15387001
]
ASF GitHub Bot commented on DELTASPIKE-1031:
Github user asfgit closed the pull request at:
https://github.com/apache/deltaspike/pull/46
> Update profiles for Wildfly
> ---
>
> Key: DELTASPIKE-1031
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1031
> Project: DeltaSpike
> Issue Type: Improvement
> Components: Configuration, Tests
>Affects Versions: 1.5.1
>Reporter: Matej Novotny
>Assignee: Rafael Benevides
> Fix For: 1.5.2
>
>
> Taking a closer look at how test structure looks like, I saw that running
> tests against Wildfly:
> {{mvn clean verify -Pwildfly-managed}}
> will launch Arquillian profile named {{jbossas-managed-7}}.
> Similar situation is with remote profile (and maybe other tiny bits).
> This naming seems inappropriate and highly confusing when (for instance) you
> need to temper with Arq. settings in order to debug code.
> I would suggest adding separate profiles to {{arquillian-jboss.xml}}.
> Apart from this, what do you think about updating the default WFLY from 8 to
> 9 (or even 10, there is CR4 already)?
> Will send a PR with these tiny changes soon.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-839) Data module test deployments pack individual classes instead of JARs
[
https://issues.apache.org/jira/browse/DELTASPIKE-839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387007#comment-15387007
]
ASF GitHub Bot commented on DELTASPIKE-839:
---
Github user asfgit closed the pull request at:
https://github.com/apache/deltaspike/pull/19
> Data module test deployments pack individual classes instead of JARs
>
>
> Key: DELTASPIKE-839
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-839
> Project: DeltaSpike
> Issue Type: Bug
> Components: Data-Module, Tests
>Affects Versions: 1.2.1
>Reporter: Ron Smeral
>Assignee: Daniel Cunha
>Priority: Minor
> Fix For: 1.5.2
>
>
> Tests of all other modules pack dependencies using ShrinkWrap's
> {{addLibrary}}, but data module tests add api and impl classes individually
> using {{addClass}}. This reduces the fidelity of the tests.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-680) Lazy init should not rely on BeanManagerProvider
[
https://issues.apache.org/jira/browse/DELTASPIKE-680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387003#comment-15387003
]
ASF GitHub Bot commented on DELTASPIKE-680:
---
Github user asfgit closed the pull request at:
https://github.com/apache/deltaspike/pull/8
> Lazy init should not rely on BeanManagerProvider
>
>
> Key: DELTASPIKE-680
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-680
> Project: DeltaSpike
> Issue Type: Improvement
> Components: Data-Module
>Affects Versions: 1.0.1
>Reporter: Harald Wellmann
>Assignee: Harald Wellmann
>
> Trying to work with DeltaSpike Data in OSGi (with on-the-fly OSGification,
> see DELTASPIKE-660), I found that things break when the TCCL is not set to
> the classloader of the current repository.
> This is caused by lazy initialization of {{RepositoryComponent}} using
> {{BeanManagerProvider}}.
> Now the current strategies of {{BeanManagerProvider}} to locate the "current"
> {{BeanManager}} do not work in OSGi where each bundle may have its own
> BeanManager and there is no obvious interpretation of "current", and the TCCL
> is not by default set to anything useful for this problem.
> However, in the context of DeltaSpike Data, is it easy to avoid the
> {{BeanManagerProvider}} even with lazy initialization. The correct
> {{BeanManager}} is known when a {{RepositoryComponent}} is instantiated, so
> its sufficient to keep a reference to this {{BeanManager}} to perform lazy
> initialization.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-594) Memory leak in RepositoryComponents singleton
[
https://issues.apache.org/jira/browse/DELTASPIKE-594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387005#comment-15387005
]
ASF GitHub Bot commented on DELTASPIKE-594:
---
Github user asfgit closed the pull request at:
https://github.com/apache/deltaspike/pull/39
> Memory leak in RepositoryComponents singleton
> -
>
> Key: DELTASPIKE-594
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-594
> Project: DeltaSpike
> Issue Type: Bug
> Components: Data-Module
>Affects Versions: 0.7
>Reporter: Harald Wellmann
>Assignee: Daniel Cunha
> Fix For: 1.4.1
>
>
> {{RepositoryComponentsFactory}} has a static singleton member of type
> {{RepositoryComponents}}.
> Repository classes are added to this singleton, but are never deleted.
> This will cause a classloader leak when the DeltaSpike modules live longer
> than application modules, e.g. in OSGi when each DeltaSpike module is a
> separate bundle, or in WildFly when DeltaSpike is installed as a JBoss module.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1185) Allow customization (name, description) of JMX managed methods' parameters
[
https://issues.apache.org/jira/browse/DELTASPIKE-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385908#comment-15385908
]
ASF GitHub Bot commented on DELTASPIKE-1185:
GitHub user kalgon opened a pull request:
https://github.com/apache/deltaspike/pull/59
DELTASPIKE-1185 Allow customization (name, description) of JMX managed...
Hi,
Here is a first try at implementing the customization (name + description)
of JMX operations' parameters.
I didn't know if it was better to make a new `@JmxParameter` annotation or
reuse the existing `@JmxManaged` (which would have needed a new `name`
attribute).
I opted for the first solution but I can change it if needed. In the 2nd
solution, adding a new `name` attribute to `@JmxManaged` could also allow to
override the operation name.
Regards,
Xavier
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kalgon/deltaspike DELTASPIKE-1185
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/deltaspike/pull/59.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #59
commit 0ab7e7043e0464e1ff66df8ed1f6a5ce9a021326
Author: Xavier Dury
Date: 2016-07-20T13:49:27Z
DELTASPIKE-1185 Allow customization (name, description) of JMX managed
methods' parameters
> Allow customization (name, description) of JMX managed methods' parameters
> --
>
> Key: DELTASPIKE-1185
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1185
> Project: DeltaSpike
> Issue Type: Wish
> Components: Core
>Affects Versions: 1.7.0
>Reporter: Xavier Dury
>Priority: Trivial
>
> Currently, it is not possible to name or give a description to parameters of
> {{@JmxManaged}} methods as {{DynamicMBeanWrapper}} uses the simple
> {{MBeanOperationInfo}} constructor which gives generic names to parameters
> like p0, p1, p2...
> It would be nice if we could annotate parameters with something like
> {{@JmxParameter(name = ..., description = ...)}} or - if using java 8 - use
> the parameter name which is available via reflection.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1180) Remove unused imports
[ https://issues.apache.org/jira/browse/DELTASPIKE-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15361761#comment-15361761 ] ASF GitHub Bot commented on DELTASPIKE-1180: Github user asfgit closed the pull request at: https://github.com/apache/deltaspike/pull/57 > Remove unused imports > - > > Key: DELTASPIKE-1180 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-1180 > Project: DeltaSpike > Issue Type: Improvement >Reporter: Ivan Junckes Filho >Assignee: Ivan Junckes Filho >Priority: Trivial > Fix For: 1.7.1 > > > There are several unused imports. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1180) Remove unused imports
[ https://issues.apache.org/jira/browse/DELTASPIKE-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15361289#comment-15361289 ] ASF GitHub Bot commented on DELTASPIKE-1180: GitHub user ivanjunckes opened a pull request: https://github.com/apache/deltaspike/pull/57 DELTASPIKE-1180 - fix unused imports You can merge this pull request into a Git repository by running: $ git pull https://github.com/ivanjunckes/deltaspike master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/deltaspike/pull/57.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #57 commit 81b390e29f2a767dce3be0c1a7c60cd9b278247d Author: Ivan Junckes Filho Date: 2016-07-02T18:39:34Z DELTASPIKE-1180 - fix unused imports > Remove unused imports > - > > Key: DELTASPIKE-1180 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-1180 > Project: DeltaSpike > Issue Type: Improvement >Reporter: Ivan Junckes Filho >Assignee: Ivan Junckes Filho >Priority: Trivial > Fix For: 1.7.1 > > > There are several unused imports. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1180) Remove unused imports
[ https://issues.apache.org/jira/browse/DELTASPIKE-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15361288#comment-15361288 ] ASF GitHub Bot commented on DELTASPIKE-1180: Github user ivanjunckes closed the pull request at: https://github.com/apache/deltaspike/pull/56 > Remove unused imports > - > > Key: DELTASPIKE-1180 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-1180 > Project: DeltaSpike > Issue Type: Improvement >Reporter: Ivan Junckes Filho >Assignee: Ivan Junckes Filho >Priority: Trivial > Fix For: 1.7.1 > > > There are several unused imports. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1160) Not possible to select non Entity or other Entity object via Native query
[
https://issues.apache.org/jira/browse/DELTASPIKE-1160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15318056#comment-15318056
]
ASF GitHub Bot commented on DELTASPIKE-1160:
Github user Danny02 closed the pull request at:
https://github.com/apache/deltaspike/pull/52
> Not possible to select non Entity or other Entity object via Native query
> -
>
> Key: DELTASPIKE-1160
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1160
> Project: DeltaSpike
> Issue Type: New Feature
> Components: Data-Module
>Affects Versions: 0.6, 0.7, 1.0.0, 1.0.1, 1.0.2, 1.0.3, 1.1.0, 1.2.0,
> 1.2.1, 1.3.0, 1.4.0, 1.4.1, 1.4.2, 1.5.0, 1.5.1, 1.5.2, 1.5.3, 1.5.4, 1.6.0,
> 1.6.1
>Reporter: Daniel Heinrich
>Assignee: Daniel Heinrich
>Priority: Minor
> Fix For: 1.7.0
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> [DELTASPIKE-1089|https://issues.apache.org/jira/browse/DELTASPIKE-1089]
> enabled to return none mapped types from a native query from a Repository.
> This was done with an extra flag on the Query annotation.
> The default for native Queries in Repositories is to return the entity type
> fo the repository.
> It should be possible to return other entity types from queries of the same
> repository.
> e.g.
> {code:java}
> interface FooRepository extends EntityRepository
> {
> @Query(isNative = true,value = "SELECT Bar.* FROM Foo JOIN Bar ON
> Foo.bar_fk = Bar.pk WHERE Foo.pk = ?1")
> Bar getBarFromFooByPk(long fooPk);
> @Query(isNative = true,value = "SELECT Bar.* FROM Foo JOIN Bar ON
> Foo.bar_fk = Bar.pk WHERE Foo.age = ?1")
> List getBarFromFooWithAge(int age);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1160) Not possible to select non Entity or other Entity object via Native query
[
https://issues.apache.org/jira/browse/DELTASPIKE-1160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15314322#comment-15314322
]
ASF GitHub Bot commented on DELTASPIKE-1160:
Github user johnament commented on a diff in the pull request:
https://github.com/apache/deltaspike/pull/52#discussion_r65732553
--- Diff:
deltaspike/modules/data/api/src/main/java/org/apache/deltaspike/data/api/Query.java
---
@@ -83,7 +82,11 @@
/**
* For native queries only, whether or not this query returns the
defined entity class or not.
* Due to type erasure from generics, we don't have runtime
information about the return collection
+ *
+ * @deprecated Native queries can deduce the correct return type and
mapping. This property has no effect and can be
+ * removed safely.
*/
+@Deprecated
boolean returnsEntity() default true;
--- End diff --
Please delete this parameter, just like in your original PR. This was only
added this week to address this problem originally.
> Not possible to select non Entity or other Entity object via Native query
> -
>
> Key: DELTASPIKE-1160
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1160
> Project: DeltaSpike
> Issue Type: New Feature
> Components: Data-Module
>Affects Versions: 0.6, 0.7, 1.0.0, 1.0.1, 1.0.2, 1.0.3, 1.1.0, 1.2.0,
> 1.2.1, 1.3.0, 1.4.0, 1.4.1, 1.4.2, 1.5.0, 1.5.1, 1.5.2, 1.5.3, 1.5.4, 1.6.0,
> 1.6.1
>Reporter: Daniel Heinrich
>Assignee: Daniel Heinrich
>Priority: Minor
> Fix For: 1.7.0
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> [DELTASPIKE-1089|https://issues.apache.org/jira/browse/DELTASPIKE-1089]
> enabled to return none mapped types from a native query from a Repository.
> This was done with an extra flag on the Query annotation.
> The default for native Queries in Repositories is to return the entity type
> fo the repository.
> It should be possible to return other entity types from queries of the same
> repository.
> e.g.
> {code:java}
> interface FooRepository extends EntityRepository
> {
> @Query(isNative = true,value = "SELECT Bar.* FROM Foo JOIN Bar ON
> Foo.bar_fk = Bar.pk WHERE Foo.pk = ?1")
> Bar getBarFromFooByPk(long fooPk);
> @Query(isNative = true,value = "SELECT Bar.* FROM Foo JOIN Bar ON
> Foo.bar_fk = Bar.pk WHERE Foo.age = ?1")
> List getBarFromFooWithAge(int age);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1160) Not possible to select non Entity or other Entity object via Native query
[
https://issues.apache.org/jira/browse/DELTASPIKE-1160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15312305#comment-15312305
]
ASF GitHub Bot commented on DELTASPIKE-1160:
Github user Danny02 commented on a diff in the pull request:
https://github.com/apache/deltaspike/pull/52#discussion_r65539505
--- Diff:
deltaspike/modules/data/impl/src/main/java/org/apache/deltaspike/data/impl/builder/AnnotatedQueryBuilder.java
---
@@ -88,4 +83,12 @@ else if (query.isNative())
return context.applyRestrictions(result);
}
+private Class getMethodResultEntityClass(Method m){
--- End diff --
done
> Not possible to select non Entity or other Entity object via Native query
> -
>
> Key: DELTASPIKE-1160
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1160
> Project: DeltaSpike
> Issue Type: Bug
> Components: Data-Module
>Affects Versions: 0.6, 0.7, 1.0.0, 1.0.1, 1.0.2, 1.0.3, 1.1.0, 1.2.0,
> 1.2.1, 1.3.0, 1.4.0, 1.4.1, 1.4.2, 1.5.0, 1.5.1, 1.5.2, 1.5.3, 1.5.4, 1.6.0,
> 1.6.1
>Reporter: Daniel Heinrich
>Priority: Minor
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> [DELTASPIKE-1089|https://issues.apache.org/jira/browse/DELTASPIKE-1089]
> enabled to return none mapped types from a native query from a Repository.
> This was done with an extra flag on the Query annotation.
> The default for native Queries in Repositories is to return the entity type
> fo the repository.
> It should be possible to return other entity types from queries of the same
> repository.
> e.g.
> {code:java}
> interface FooRepository extends EntityRepository
> {
> @Query(isNative = true,value = "SELECT Bar.* FROM Foo JOIN Bar ON
> Foo.bar_fk = Bar.pk WHERE Foo.pk = ?1")
> Bar getBarFromFooByPk(long fooPk);
> @Query(isNative = true,value = "SELECT Bar.* FROM Foo JOIN Bar ON
> Foo.bar_fk = Bar.pk WHERE Foo.age = ?1")
> List getBarFromFooWithAge(int age);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1160) Not possible to select non Entity or other Entity object via Native query
[
https://issues.apache.org/jira/browse/DELTASPIKE-1160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15312294#comment-15312294
]
ASF GitHub Bot commented on DELTASPIKE-1160:
Github user johnament commented on a diff in the pull request:
https://github.com/apache/deltaspike/pull/52#discussion_r65538667
--- Diff:
deltaspike/modules/data/impl/src/main/java/org/apache/deltaspike/data/impl/builder/AnnotatedQueryBuilder.java
---
@@ -88,4 +83,12 @@ else if (query.isNative())
return context.applyRestrictions(result);
}
+private Class getMethodResultEntityClass(Method m){
--- End diff --
Either is fine, your commit message doesn't include a JIRA ticket.
> Not possible to select non Entity or other Entity object via Native query
> -
>
> Key: DELTASPIKE-1160
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1160
> Project: DeltaSpike
> Issue Type: Bug
> Components: Data-Module
>Affects Versions: 0.6, 0.7, 1.0.0, 1.0.1, 1.0.2, 1.0.3, 1.1.0, 1.2.0,
> 1.2.1, 1.3.0, 1.4.0, 1.4.1, 1.4.2, 1.5.0, 1.5.1, 1.5.2, 1.5.3, 1.5.4, 1.6.0,
> 1.6.1
>Reporter: Daniel Heinrich
>Priority: Minor
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> [DELTASPIKE-1089|https://issues.apache.org/jira/browse/DELTASPIKE-1089]
> enabled to return none mapped types from a native query from a Repository.
> This was done with an extra flag on the Query annotation.
> The default for native Queries in Repositories is to return the entity type
> fo the repository.
> It should be possible to return other entity types from queries of the same
> repository.
> e.g.
> {code:java}
> interface FooRepository extends EntityRepository
> {
> @Query(isNative = true,value = "SELECT Bar.* FROM Foo JOIN Bar ON
> Foo.bar_fk = Bar.pk WHERE Foo.pk = ?1")
> Bar getBarFromFooByPk(long fooPk);
> @Query(isNative = true,value = "SELECT Bar.* FROM Foo JOIN Bar ON
> Foo.bar_fk = Bar.pk WHERE Foo.age = ?1")
> List getBarFromFooWithAge(int age);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1160) Not possible to select non Entity or other Entity object via Native query
[
https://issues.apache.org/jira/browse/DELTASPIKE-1160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15312178#comment-15312178
]
ASF GitHub Bot commented on DELTASPIKE-1160:
Github user Danny02 commented on a diff in the pull request:
https://github.com/apache/deltaspike/pull/52#discussion_r65525461
--- Diff:
deltaspike/modules/data/impl/src/main/java/org/apache/deltaspike/data/impl/builder/AnnotatedQueryBuilder.java
---
@@ -88,4 +83,12 @@ else if (query.isNative())
return context.applyRestrictions(result);
}
+private Class getMethodResultEntityClass(Method m){
--- End diff --
[QueryBuilder](https://github.com/apache/deltaspike/blob/master/deltaspike/modules/data/impl/src/main/java/org/apache/deltaspike/data/impl/builder/QueryBuilder.java#L64)
also only checks for java.util.List
> Not possible to select non Entity or other Entity object via Native query
> -
>
> Key: DELTASPIKE-1160
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1160
> Project: DeltaSpike
> Issue Type: Bug
> Components: Data-Module
>Affects Versions: 0.6, 0.7, 1.0.0, 1.0.1, 1.0.2, 1.0.3, 1.1.0, 1.2.0,
> 1.2.1, 1.3.0, 1.4.0, 1.4.1, 1.4.2, 1.5.0, 1.5.1, 1.5.2, 1.5.3, 1.5.4, 1.6.0,
> 1.6.1
>Reporter: Daniel Heinrich
>Priority: Minor
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> [DELTASPIKE-1089|https://issues.apache.org/jira/browse/DELTASPIKE-1089]
> enabled to return none mapped types from a native query from a Repository.
> This was done with an extra flag on the Query annotation.
> The default for native Queries in Repositories is to return the entity type
> fo the repository.
> It should be possible to return other entity types from queries of the same
> repository.
> e.g.
> {code:java}
> interface FooRepository extends EntityRepository
> {
> @Query(isNative = true,value = "SELECT Bar.* FROM Foo JOIN Bar ON
> Foo.bar_fk = Bar.pk WHERE Foo.pk = ?1")
> Bar getBarFromFooByPk(long fooPk);
> @Query(isNative = true,value = "SELECT Bar.* FROM Foo JOIN Bar ON
> Foo.bar_fk = Bar.pk WHERE Foo.age = ?1")
> List getBarFromFooWithAge(int age);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1160) Not possible to select non Entity or other Entity object via Native query
[
https://issues.apache.org/jira/browse/DELTASPIKE-1160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15312172#comment-15312172
]
ASF GitHub Bot commented on DELTASPIKE-1160:
Github user Danny02 commented on a diff in the pull request:
https://github.com/apache/deltaspike/pull/52#discussion_r65524755
--- Diff:
deltaspike/modules/data/impl/src/main/java/org/apache/deltaspike/data/impl/builder/AnnotatedQueryBuilder.java
---
@@ -88,4 +83,12 @@ else if (query.isNative())
return context.applyRestrictions(result);
}
+private Class getMethodResultEntityClass(Method m){
--- End diff --
sry, but which original ticket do you mean?
[DELTASPIKE-1089](https://issues.apache.org/jira/browse/DELTASPIKE-1089)?
> Not possible to select non Entity or other Entity object via Native query
> -
>
> Key: DELTASPIKE-1160
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1160
> Project: DeltaSpike
> Issue Type: Bug
> Components: Data-Module
>Affects Versions: 0.6, 0.7, 1.0.0, 1.0.1, 1.0.2, 1.0.3, 1.1.0, 1.2.0,
> 1.2.1, 1.3.0, 1.4.0, 1.4.1, 1.4.2, 1.5.0, 1.5.1, 1.5.2, 1.5.3, 1.5.4, 1.6.0,
> 1.6.1
>Reporter: Daniel Heinrich
>Priority: Minor
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> [DELTASPIKE-1089|https://issues.apache.org/jira/browse/DELTASPIKE-1089]
> enabled to return none mapped types from a native query from a Repository.
> This was done with an extra flag on the Query annotation.
> The default for native Queries in Repositories is to return the entity type
> fo the repository.
> It should be possible to return other entity types from queries of the same
> repository.
> e.g.
> {code:java}
> interface FooRepository extends EntityRepository
> {
> @Query(isNative = true,value = "SELECT Bar.* FROM Foo JOIN Bar ON
> Foo.bar_fk = Bar.pk WHERE Foo.pk = ?1")
> Bar getBarFromFooByPk(long fooPk);
> @Query(isNative = true,value = "SELECT Bar.* FROM Foo JOIN Bar ON
> Foo.bar_fk = Bar.pk WHERE Foo.age = ?1")
> List getBarFromFooWithAge(int age);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1160) Not possible to select non Entity or other Entity object via Native query
[
https://issues.apache.org/jira/browse/DELTASPIKE-1160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15312162#comment-15312162
]
ASF GitHub Bot commented on DELTASPIKE-1160:
Github user johnament commented on a diff in the pull request:
https://github.com/apache/deltaspike/pull/52#discussion_r65524383
--- Diff:
deltaspike/modules/data/impl/src/main/java/org/apache/deltaspike/data/impl/builder/AnnotatedQueryBuilder.java
---
@@ -88,4 +83,12 @@ else if (query.isNative())
return context.applyRestrictions(result);
}
+private Class getMethodResultEntityClass(Method m){
--- End diff --
HI Danny, good catch, thats what happens when I'm looking at this too late
in the evening.
Can you please commit this all under the original ticket? and can you
expand this method to check for collection types?
> Not possible to select non Entity or other Entity object via Native query
> -
>
> Key: DELTASPIKE-1160
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1160
> Project: DeltaSpike
> Issue Type: Bug
> Components: Data-Module
>Affects Versions: 0.6, 0.7, 1.0.0, 1.0.1, 1.0.2, 1.0.3, 1.1.0, 1.2.0,
> 1.2.1, 1.3.0, 1.4.0, 1.4.1, 1.4.2, 1.5.0, 1.5.1, 1.5.2, 1.5.3, 1.5.4, 1.6.0,
> 1.6.1
>Reporter: Daniel Heinrich
>Priority: Minor
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> [DELTASPIKE-1089|https://issues.apache.org/jira/browse/DELTASPIKE-1089]
> enabled to return none mapped types from a native query from a Repository.
> This was done with an extra flag on the Query annotation.
> The default for native Queries in Repositories is to return the entity type
> fo the repository.
> It should be possible to return other entity types from queries of the same
> repository.
> e.g.
> {code:java}
> interface FooRepository extends EntityRepository
> {
> @Query(isNative = true,value = "SELECT Bar.* FROM Foo JOIN Bar ON
> Foo.bar_fk = Bar.pk WHERE Foo.pk = ?1")
> Bar getBarFromFooByPk(long fooPk);
> @Query(isNative = true,value = "SELECT Bar.* FROM Foo JOIN Bar ON
> Foo.bar_fk = Bar.pk WHERE Foo.age = ?1")
> List getBarFromFooWithAge(int age);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1141) @Futureable @Locked and @EnableInterceptor cannot work with CDI 1.0/Weld 1.x
[
https://issues.apache.org/jira/browse/DELTASPIKE-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15276594#comment-15276594
]
ASF GitHub Bot commented on DELTASPIKE-1141:
Github user asfgit closed the pull request at:
https://github.com/apache/deltaspike/pull/51
> @Futureable @Locked and @EnableInterceptor cannot work with CDI 1.0/Weld 1.x
>
>
> Key: DELTASPIKE-1141
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1141
> Project: DeltaSpike
> Issue Type: Bug
>Affects Versions: 1.6.1
> Environment: CDI 1.x/Weld 1.x
> EAP 6/JBoss AS 7
>Reporter: Matej Novotny
>Assignee: Matej Novotny
>
> Follow-up on DELTASPIKE-1138.
> There is still a problem which affects at least two DS features - @Futureable
> and @Locked.
> Both of them have an interceptor enabled in DS core jar file (via beans.xml).
> However this will not work with CDI 1.0/Weld 1.x!
> The reason is the eternal holy war for what exactly is a 'bean archive' :-).
> Weld will consider the interceptor enabled only for the core jar itself hence
> it will not kick in.
> How to reproduce:
> * Run DS on JBoss AS 7 (JDK 1.7 or lower) or EAP 6 (all JDKs)
> ** {{mvn clean verify -Pjbossas-build-managed-7 -Dweld.version=1.1.33.Final
> -Dtest=FutureableTest}}
> * To make the test pass, you can add {{beans.xml}} containing the interceptor
> [here|https://github.com/apache/deltaspike/blob/master/deltaspike/core/impl/src/test/java/org/apache/deltaspike/test/core/impl/future/FutureableTest.java#L45]
> (same works for LockedTest)
> ** *The above trick is not a fix though!* Merely a workaround allowing Weld
> to enable the interceptor within test archive
> ** I think any user aiming to use these features with Weld 1.x would need to
> use this workaround in his/her deployments which is ugly
> Notes:
> * {{@Priority}} cannot be used here (for CDI 1.0)
> * GlobalInterceptorExtension won't help either as it is working since CDI 1.1+
> * This is not a problem for embedded container (e.g. running via {{-PWeld1}})
> ** This is probably because of different structure of embedded deployments
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1141) @Futureable @Locked and @EnableInterceptor cannot work with CDI 1.0/Weld 1.x
[
https://issues.apache.org/jira/browse/DELTASPIKE-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15272145#comment-15272145
]
ASF GitHub Bot commented on DELTASPIKE-1141:
GitHub user manovotn opened a pull request:
https://github.com/apache/deltaspike/pull/51
DELTASPIKE-1141 fix EnableInterceptorsTest for CDI 1.0/Weld 1.x
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/manovotn/deltaspike enableIntercTestFix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/deltaspike/pull/51.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #51
commit 07f5199529a0e2cdb6dfbda20e4b16f060378b84
Author: Matej Novotny
Date: 2016-05-05T09:58:55Z
DELTASPIKE-1141 fix EnableInterceptorsTest for CDI 1.0/Weld 1.x
> @Futureable @Locked and @EnableInterceptor cannot work with CDI 1.0/Weld 1.x
>
>
> Key: DELTASPIKE-1141
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1141
> Project: DeltaSpike
> Issue Type: Bug
>Affects Versions: 1.6.1
> Environment: CDI 1.x/Weld 1.x
> EAP 6/JBoss AS 7
>Reporter: Matej Novotny
>
> Follow-up on DELTASPIKE-1138.
> There is still a problem which affects at least two DS features - @Futureable
> and @Locked.
> Both of them have an interceptor enabled in DS core jar file (via beans.xml).
> However this will not work with CDI 1.0/Weld 1.x!
> The reason is the eternal holy war for what exactly is a 'bean archive' :-).
> Weld will consider the interceptor enabled only for the core jar itself hence
> it will not kick in.
> How to reproduce:
> * Run DS on JBoss AS 7 (JDK 1.7 or lower) or EAP 6 (all JDKs)
> ** {{mvn clean verify -Pjbossas-build-managed-7 -Dweld.version=1.1.33.Final
> -Dtest=FutureableTest}}
> * To make the test pass, you can add {{beans.xml}} containing the interceptor
> [here|https://github.com/apache/deltaspike/blob/master/deltaspike/core/impl/src/test/java/org/apache/deltaspike/test/core/impl/future/FutureableTest.java#L45]
> (same works for LockedTest)
> ** *The above trick is not a fix though!* Merely a workaround allowing Weld
> to enable the interceptor within test archive
> ** I think any user aiming to use these features with Weld 1.x would need to
> use this workaround in his/her deployments which is ugly
> Notes:
> * {{@Priority}} cannot be used here (for CDI 1.0)
> * GlobalInterceptorExtension won't help either as it is working since CDI 1.1+
> * This is not a problem for embedded container (e.g. running via {{-PWeld1}})
> ** This is probably because of different structure of embedded deployments
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1141) @Futureable and @Locked cannot work with CDI 1.0/Weld 1.x
[
https://issues.apache.org/jira/browse/DELTASPIKE-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15271293#comment-15271293
]
ASF GitHub Bot commented on DELTASPIKE-1141:
Github user asfgit closed the pull request at:
https://github.com/apache/deltaspike/pull/50
> @Futureable and @Locked cannot work with CDI 1.0/Weld 1.x
> -
>
> Key: DELTASPIKE-1141
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1141
> Project: DeltaSpike
> Issue Type: Bug
>Affects Versions: 1.6.1
> Environment: CDI 1.x/Weld 1.x
> EAP 6/JBoss AS 7
>Reporter: Matej Novotny
>
> Follow-up on DELTASPIKE-1138.
> There is still a problem which affects at least two DS features - @Futureable
> and @Locked.
> Both of them have an interceptor enabled in DS core jar file (via beans.xml).
> However this will not work with CDI 1.0/Weld 1.x!
> The reason is the eternal holy war for what exactly is a 'bean archive' :-).
> Weld will consider the interceptor enabled only for the core jar itself hence
> it will not kick in.
> How to reproduce:
> * Run DS on JBoss AS 7 (JDK 1.7 or lower) or EAP 6 (all JDKs)
> ** {{mvn clean verify -Pjbossas-build-managed-7 -Dweld.version=1.1.33.Final
> -Dtest=FutureableTest}}
> * To make the test pass, you can add {{beans.xml}} containing the interceptor
> [here|https://github.com/apache/deltaspike/blob/master/deltaspike/core/impl/src/test/java/org/apache/deltaspike/test/core/impl/future/FutureableTest.java#L45]
> (same works for LockedTest)
> ** *The above trick is not a fix though!* Merely a workaround allowing Weld
> to enable the interceptor within test archive
> ** I think any user aiming to use these features with Weld 1.x would need to
> use this workaround in his/her deployments which is ugly
> Notes:
> * {{@Priority}} cannot be used here (for CDI 1.0)
> * GlobalInterceptorExtension won't help either as it is working since CDI 1.1+
> * This is not a problem for embedded container (e.g. running via {{-PWeld1}})
> ** This is probably because of different structure of embedded deployments
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1141) @Futureable and @Locked cannot work with CDI 1.0/Weld 1.x
[
https://issues.apache.org/jira/browse/DELTASPIKE-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15270599#comment-15270599
]
ASF GitHub Bot commented on DELTASPIKE-1141:
GitHub user manovotn opened a pull request:
https://github.com/apache/deltaspike/pull/50
DELTASPIKE-1141 modify FutureableTest and LockedTest to contain beans…
….xml with relevant interceptors.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/manovotn/deltaspike ds1141
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/deltaspike/pull/50.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #50
commit d2558b7ddf682e41bc829d69bbdafa4927c23887
Author: Matej Novotny
Date: 2016-05-04T13:07:00Z
DELTASPIKE-1141 modify FutureableTest and LockedTest to contain beans.xml
with relevant interceptors.
> @Futureable and @Locked cannot work with CDI 1.0/Weld 1.x
> -
>
> Key: DELTASPIKE-1141
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1141
> Project: DeltaSpike
> Issue Type: Bug
>Affects Versions: 1.6.1
> Environment: CDI 1.x/Weld 1.x
> EAP 6/JBoss AS 7
>Reporter: Matej Novotny
>
> Follow-up on DELTASPIKE-1138.
> There is still a problem which affects at least two DS features - @Futureable
> and @Locked.
> Both of them have an interceptor enabled in DS core jar file (via beans.xml).
> However this will not work with CDI 1.0/Weld 1.x!
> The reason is the eternal holy war for what exactly is a 'bean archive' :-).
> Weld will consider the interceptor enabled only for the core jar itself hence
> it will not kick in.
> How to reproduce:
> * Run DS on JBoss AS 7 (JDK 1.7 or lower) or EAP 6 (all JDKs)
> ** {{mvn clean verify -Pjbossas-build-managed-7 -Dweld.version=1.1.33.Final
> -Dtest=FutureableTest}}
> * To make the test pass, you can add {{beans.xml}} containing the interceptor
> [here|https://github.com/apache/deltaspike/blob/master/deltaspike/core/impl/src/test/java/org/apache/deltaspike/test/core/impl/future/FutureableTest.java#L45]
> (same works for LockedTest)
> ** *The above trick is not a fix though!* Merely a workaround allowing Weld
> to enable the interceptor within test archive
> ** I think any user aiming to use these features with Weld 1.x would need to
> use this workaround in his/her deployments which is ugly
> Notes:
> * {{@Priority}} cannot be used here (for CDI 1.0)
> * GlobalInterceptorExtension won't help either as it is working since CDI 1.1+
> * This is not a problem for embedded container (e.g. running via {{-PWeld1}})
> ** This is probably because of different structure of embedded deployments
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1091) Weld core BOM update in next 2.3/3.x release
[
https://issues.apache.org/jira/browse/DELTASPIKE-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15268766#comment-15268766
]
ASF GitHub Bot commented on DELTASPIKE-1091:
Github user asfgit closed the pull request at:
https://github.com/apache/deltaspike/pull/49
> Weld core BOM update in next 2.3/3.x release
>
>
> Key: DELTASPIKE-1091
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1091
> Project: DeltaSpike
> Issue Type: Improvement
> Components: Build
>Reporter: Matej Novotny
>Assignee: Rafael Benevides
>
> The next release of Weld 2.3 (2.3.4.Final) and 3.x (3.0.Alpha16) will also
> contain a refactored weld-core BOM files.
> This is per request in [WELD-2115|https://issues.jboss.org/browse/WELD-2115].
> BOM will no longer provide direct dependencies, but only
> {{dependencyManagement}} section. Looking at deltaspike dependencies, this
> will affect
> [{{parent/code/pom.xml}}|https://github.com/apache/deltaspike/blob/master/deltaspike/parent/code/pom.xml#L355]
> and will require changes.
> The PRs for BOM changes are:
> * 2.3 branch -> https://github.com/weld/core/pull/1295
> * master -> https://github.com/weld/core/pull/1296
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1091) Weld core BOM update in next 2.3/3.x release
[
https://issues.apache.org/jira/browse/DELTASPIKE-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15268672#comment-15268672
]
ASF GitHub Bot commented on DELTASPIKE-1091:
Github user manovotn commented on a diff in the pull request:
https://github.com/apache/deltaspike/pull/49#discussion_r61877744
--- Diff: deltaspike/parent/pom.xml ---
@@ -49,7 +49,8 @@
1.6
1.2.7
-1.1.28.Final
+
+1.1.9.Final
--- End diff --
This is based on a Gerhard's comment. He claimed that the idea is to list
the minimal supported version. Although I strongly dislike dislike this
approach, I put it here.
However if you look into Weld1 profile, you can see it is overriden by
current version (1.1.33.Final). So this version declaration is naught but a
mere information :)
> Weld core BOM update in next 2.3/3.x release
>
>
> Key: DELTASPIKE-1091
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1091
> Project: DeltaSpike
> Issue Type: Improvement
> Components: Build
>Reporter: Matej Novotny
>Assignee: Rafael Benevides
>
> The next release of Weld 2.3 (2.3.4.Final) and 3.x (3.0.Alpha16) will also
> contain a refactored weld-core BOM files.
> This is per request in [WELD-2115|https://issues.jboss.org/browse/WELD-2115].
> BOM will no longer provide direct dependencies, but only
> {{dependencyManagement}} section. Looking at deltaspike dependencies, this
> will affect
> [{{parent/code/pom.xml}}|https://github.com/apache/deltaspike/blob/master/deltaspike/parent/code/pom.xml#L355]
> and will require changes.
> The PRs for BOM changes are:
> * 2.3 branch -> https://github.com/weld/core/pull/1295
> * master -> https://github.com/weld/core/pull/1296
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1091) Weld core BOM update in next 2.3/3.x release
[
https://issues.apache.org/jira/browse/DELTASPIKE-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15268644#comment-15268644
]
ASF GitHub Bot commented on DELTASPIKE-1091:
Github user johnament commented on a diff in the pull request:
https://github.com/apache/deltaspike/pull/49#discussion_r61874887
--- Diff: deltaspike/parent/code/pom.xml ---
@@ -41,7 +41,7 @@
1.0.2.Final
3.1.2.2
4.0
-12.1
+12.1
--- End diff --
please clean up the whitespace
> Weld core BOM update in next 2.3/3.x release
>
>
> Key: DELTASPIKE-1091
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1091
> Project: DeltaSpike
> Issue Type: Improvement
> Components: Build
>Reporter: Matej Novotny
>Assignee: Rafael Benevides
>
> The next release of Weld 2.3 (2.3.4.Final) and 3.x (3.0.Alpha16) will also
> contain a refactored weld-core BOM files.
> This is per request in [WELD-2115|https://issues.jboss.org/browse/WELD-2115].
> BOM will no longer provide direct dependencies, but only
> {{dependencyManagement}} section. Looking at deltaspike dependencies, this
> will affect
> [{{parent/code/pom.xml}}|https://github.com/apache/deltaspike/blob/master/deltaspike/parent/code/pom.xml#L355]
> and will require changes.
> The PRs for BOM changes are:
> * 2.3 branch -> https://github.com/weld/core/pull/1295
> * master -> https://github.com/weld/core/pull/1296
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1091) Weld core BOM update in next 2.3/3.x release
[
https://issues.apache.org/jira/browse/DELTASPIKE-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15268643#comment-15268643
]
ASF GitHub Bot commented on DELTASPIKE-1091:
Github user johnament commented on a diff in the pull request:
https://github.com/apache/deltaspike/pull/49#discussion_r61874873
--- Diff: deltaspike/parent/pom.xml ---
@@ -49,7 +49,8 @@
1.6
1.2.7
-1.1.28.Final
+
+1.1.9.Final
--- End diff --
why downgrade?
> Weld core BOM update in next 2.3/3.x release
>
>
> Key: DELTASPIKE-1091
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1091
> Project: DeltaSpike
> Issue Type: Improvement
> Components: Build
>Reporter: Matej Novotny
>Assignee: Rafael Benevides
>
> The next release of Weld 2.3 (2.3.4.Final) and 3.x (3.0.Alpha16) will also
> contain a refactored weld-core BOM files.
> This is per request in [WELD-2115|https://issues.jboss.org/browse/WELD-2115].
> BOM will no longer provide direct dependencies, but only
> {{dependencyManagement}} section. Looking at deltaspike dependencies, this
> will affect
> [{{parent/code/pom.xml}}|https://github.com/apache/deltaspike/blob/master/deltaspike/parent/code/pom.xml#L355]
> and will require changes.
> The PRs for BOM changes are:
> * 2.3 branch -> https://github.com/weld/core/pull/1295
> * master -> https://github.com/weld/core/pull/1296
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1091) Weld core BOM update in next 2.3/3.x release
[
https://issues.apache.org/jira/browse/DELTASPIKE-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15268335#comment-15268335
]
ASF GitHub Bot commented on DELTASPIKE-1091:
GitHub user manovotn opened a pull request:
https://github.com/apache/deltaspike/pull/49
DELTASPIKE-1091 add default values to Weld profiles.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/manovotn/deltaspike weldProfiles
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/deltaspike/pull/49.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #49
commit 1482edcdc9fa7f7727b1169b74a83766c0d74b58
Author: Matej Novotny
Date: 2016-05-03T08:04:53Z
DELTASPIKE-1091 add default values to Weld profiles.
> Weld core BOM update in next 2.3/3.x release
>
>
> Key: DELTASPIKE-1091
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1091
> Project: DeltaSpike
> Issue Type: Improvement
> Components: Build
>Reporter: Matej Novotny
>Assignee: Rafael Benevides
>
> The next release of Weld 2.3 (2.3.4.Final) and 3.x (3.0.Alpha16) will also
> contain a refactored weld-core BOM files.
> This is per request in [WELD-2115|https://issues.jboss.org/browse/WELD-2115].
> BOM will no longer provide direct dependencies, but only
> {{dependencyManagement}} section. Looking at deltaspike dependencies, this
> will affect
> [{{parent/code/pom.xml}}|https://github.com/apache/deltaspike/blob/master/deltaspike/parent/code/pom.xml#L355]
> and will require changes.
> The PRs for BOM changes are:
> * 2.3 branch -> https://github.com/weld/core/pull/1295
> * master -> https://github.com/weld/core/pull/1296
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1091) Weld core BOM update in next 2.3/3.x release
[
https://issues.apache.org/jira/browse/DELTASPIKE-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15267018#comment-15267018
]
ASF GitHub Bot commented on DELTASPIKE-1091:
Github user asfgit closed the pull request at:
https://github.com/apache/deltaspike/pull/47
> Weld core BOM update in next 2.3/3.x release
>
>
> Key: DELTASPIKE-1091
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1091
> Project: DeltaSpike
> Issue Type: Improvement
> Components: Build
>Reporter: Matej Novotny
>Assignee: Rafael Benevides
>
> The next release of Weld 2.3 (2.3.4.Final) and 3.x (3.0.Alpha16) will also
> contain a refactored weld-core BOM files.
> This is per request in [WELD-2115|https://issues.jboss.org/browse/WELD-2115].
> BOM will no longer provide direct dependencies, but only
> {{dependencyManagement}} section. Looking at deltaspike dependencies, this
> will affect
> [{{parent/code/pom.xml}}|https://github.com/apache/deltaspike/blob/master/deltaspike/parent/code/pom.xml#L355]
> and will require changes.
> The PRs for BOM changes are:
> * 2.3 branch -> https://github.com/weld/core/pull/1295
> * master -> https://github.com/weld/core/pull/1296
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1137) core/impl test suite freezes in embedded container with Weld 1.x
[
https://issues.apache.org/jira/browse/DELTASPIKE-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15262050#comment-15262050
]
ASF GitHub Bot commented on DELTASPIKE-1137:
GitHub user manovotn opened a pull request:
https://github.com/apache/deltaspike/pull/47
DELTASPIKE-1137, created separate profiles for Weld versions, changed…
… docs accordingly.
I created 3 separate profiles for Weld 1/2/3 respectively.
As all three profiles have part of their build management/dependencies in
common, I took those out and put them into a separate profile
(`Weld-common-setup`).
`Weld-common-setup` is automatically triggered when you use
`-Dweld.version=...` when executing tests (which you do like...all the time? :)
). I couldn't really come up with other solution which would allow to avoid
copying this setup into all three profiles. The downside of this is that once
you run the tests without `-Dweld.version`, it will not work.
Last but not least, I modified docs (`build.adoc` to be more precise) to
reflect these changes.
Ideas/comments are welcome!
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/manovotn/deltaspike weldProfileRefactoring
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/deltaspike/pull/47.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #47
commit ae16e7a4c6a3303657fe657c059a5a7da7a9ebbf
Author: Matej Novotny
Date: 2016-04-28T12:15:36Z
DELTASPIKE-1137, created separate profiles for Weld versions, changed docs
accordingly.
> core/impl test suite freezes in embedded container with Weld 1.x
>
>
> Key: DELTASPIKE-1137
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1137
> Project: DeltaSpike
> Issue Type: Bug
> Components: Tests
>Affects Versions: 1.6.1
> Environment: Embedded container
> Weld 1.x
>Reporter: Matej Novotny
>
> According to DS
> [documentation|https://deltaspike.apache.org/documentation/build.html], the
> basic way to build DS with Weld should be by running {{$ mvn clean install
> -PWeld}}.
> Running this will indeed start the build but will then freeze mid-way through
> with no response/failure. For me, the last (successfully) executed test was
> {{org.apache.deltaspike.test.core.impl.resourceloader.ClasspathResourceTest}}
> and then it just froze, doing nothing untill killed.
> The build always freezes on {{deltaspike/core/impl}} tests. So the fastest
> way to reproduce it to run the command from there.
> The above written command will, by default, use (an outdated) version
> 1.1.28.Final of Weld.
> To use more up to date version, one can add something like this -
> {{-Dweld.version=1.1.33.Final}}. Anyway, version makes no difference here, it
> still freezes.
> The tests are executed within embedded container.
> NOTE: This only affects Weld 1.x, using Weld 2.x or 3.x works perfectly fine.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1031) Update profiles for Wildfly
[
https://issues.apache.org/jira/browse/DELTASPIKE-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15016709#comment-15016709
]
ASF GitHub Bot commented on DELTASPIKE-1031:
GitHub user manovotn opened a pull request:
https://github.com/apache/deltaspike/pull/46
DELTASPIKE-1031 update profiles for WFLY
Created separate arq. profiles for managed and remote WFLY. This should
make it obvious which profiles are related to which server in case one needs to
modify the settings.
I also updated WFLY default version to latest Final release which is 9.0.2.
Although I think there could even be WFLY 10 (currently at CR4). But should you
insist on leaving it at 8, I will revert it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/manovotn/deltaspike master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/deltaspike/pull/46.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #46
commit cbcc9cb7159d7070c7c563986c1b641dcdfe9a2a
Author: Matej Novotny
Date: 2015-11-20T12:13:20Z
DELTASPIKE-1031 update profiles for WFLY
> Update profiles for Wildfly
> ---
>
> Key: DELTASPIKE-1031
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1031
> Project: DeltaSpike
> Issue Type: Improvement
> Components: Configuration, Tests
>Affects Versions: 1.5.1
>Reporter: Matej Novotny
>
> Taking a closer look at how test structure looks like, I saw that running
> tests against Wildfly:
> {{mvn clean verify -Pwildfly-managed}}
> will launch Arquillian profile named {{jbossas-managed-7}}.
> Similar situation is with remote profile (and maybe other tiny bits).
> This naming seems inappropriate and highly confusing when (for instance) you
> need to temper with Arq. settings in order to debug code.
> I would suggest adding separate profiles to {{arquillian-jboss.xml}}.
> Apart from this, what do you think about updating the default WFLY from 8 to
> 9 (or even 10, there is CR4 already)?
> Will send a PR with these tiny changes soon.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-985) It's not possible to run tests against latest WildFly
[ https://issues.apache.org/jira/browse/DELTASPIKE-985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14730357#comment-14730357 ] ASF GitHub Bot commented on DELTASPIKE-985: --- Github user tremes closed the pull request at: https://github.com/apache/deltaspike/pull/43 > It's not possible to run tests against latest WildFly > - > > Key: DELTASPIKE-985 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-985 > Project: DeltaSpike > Issue Type: Bug > Components: Tests >Affects Versions: 1.5.0 >Reporter: Tomas Remes >Assignee: Rafael Benevides > Fix For: 1.5.1 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-985) It's not possible to run tests against latest WildFly
[ https://issues.apache.org/jira/browse/DELTASPIKE-985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14728570#comment-14728570 ] ASF GitHub Bot commented on DELTASPIKE-985: --- GitHub user tremes opened a pull request: https://github.com/apache/deltaspike/pull/43 DELTASPIKE-985 - make it possible to test against latest WildFly. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tremes/deltaspike wf-update Alternatively you can review and apply these changes as the patch at: https://github.com/apache/deltaspike/pull/43.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #43 commit 52422b95d75d0e1166047cd85070f6e62982ab0d Author: Tomas Remes Date: 2015-08-27T08:58:07Z DELTASPIKE-985 - make it possible to test against latest WildFly. > It's not possible to run tests against latest WildFly > - > > Key: DELTASPIKE-985 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-985 > Project: DeltaSpike > Issue Type: Bug > Components: Tests >Affects Versions: 1.5.0 >Reporter: Tomas Remes > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-965) EntityRepository.save() is broken for entities with String ID
[
https://issues.apache.org/jira/browse/DELTASPIKE-965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14643242#comment-14643242
]
ASF GitHub Bot commented on DELTASPIKE-965:
---
Github user asfgit closed the pull request at:
https://github.com/apache/deltaspike/pull/40
> EntityRepository.save() is broken for entities with String ID
> -
>
> Key: DELTASPIKE-965
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-965
> Project: DeltaSpike
> Issue Type: Bug
> Components: Data-Module
>Affects Versions: 1.4.2
>Reporter: Harald Wellmann
>Assignee: Daniel Cunha (soro)
>Priority: Blocker
> Fix For: 1.4.3
>
>
> EntityRepository.save() generates illegal SQL when the entity identity is of
> String type.
> This is a regression introduced in 1.4.2 with
> {{org.apache.deltaspike.data.impl.handler.CdiQueryInvocationContext.countCheck(Object)}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-965) EntityRepository.save() is broken for entities with String ID
[
https://issues.apache.org/jira/browse/DELTASPIKE-965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14643038#comment-14643038
]
ASF GitHub Bot commented on DELTASPIKE-965:
---
GitHub user hwellmann opened a pull request:
https://github.com/apache/deltaspike/pull/40
DELTASPIKE-965 use query parameter to interpolate ID value
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hwellmann/deltaspike DELTASPIKE-965
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/deltaspike/pull/40.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #40
commit e56035aa82babce38ec092a73e45a33488f681e5
Author: Harald Wellmann
Date: 2015-07-27T16:04:07Z
DELTASPIKE-965 failing test demonstrating the problem
commit b11d8174bf4a090db6b78666f06aeab04555b37b
Author: Harald Wellmann
Date: 2015-07-27T16:07:31Z
DELTASPIKE-965 Use query parameter to properly interpolate ID values
> EntityRepository.save() is broken for entities with String ID
> -
>
> Key: DELTASPIKE-965
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-965
> Project: DeltaSpike
> Issue Type: Bug
> Components: Data-Module
>Affects Versions: 1.4.2
>Reporter: Harald Wellmann
>Assignee: Daniel Cunha (soro)
>Priority: Blocker
> Fix For: 1.4.3
>
>
> EntityRepository.save() generates illegal SQL when the entity identity is of
> String type.
> This is a regression introduced in 1.4.2 with
> {{org.apache.deltaspike.data.impl.handler.CdiQueryInvocationContext.countCheck(Object)}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-594) Memory leak in RepositoryComponents singleton
[
https://issues.apache.org/jira/browse/DELTASPIKE-594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14579207#comment-14579207
]
ASF GitHub Bot commented on DELTASPIKE-594:
---
GitHub user hwellmann opened a pull request:
https://github.com/apache/deltaspike/pull/39
DELTASPIKE-594 removed static singleton RepositoryComponents
This is now an application-scoped bean, thus fixing a potential
classloader leak when application is undeployed.
Had to remove RepositoryComponentsFactory.instance() API, which probably
shouldn't have been there in the first place. It was not used anywhere in DS.
Tested with -Pwildfly-remote.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hwellmann/deltaspike DELTASPIKE-594
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/deltaspike/pull/39.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #39
commit 9c022e2fecdb6c9cd2e25f6efb96d96ec6210dc8
Author: Harald Wellmann
Date: 2015-06-09T16:52:38Z
DELTASPIKE-594 removed static singleton RepositoryComponents
This is now an application-scoped bean, thus fixing a potential
classloader leak when application is undeployed.
> Memory leak in RepositoryComponents singleton
> -
>
> Key: DELTASPIKE-594
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-594
> Project: DeltaSpike
> Issue Type: Bug
> Components: Data-Module
>Affects Versions: 0.7
>Reporter: Harald Wellmann
>Assignee: Harald Wellmann
>
> {{RepositoryComponentsFactory}} has a static singleton member of type
> {{RepositoryComponents}}.
> Repository classes are added to this singleton, but are never deleted.
> This will cause a classloader leak when the DeltaSpike modules live longer
> than application modules, e.g. in OSGi when each DeltaSpike module is a
> separate bundle, or in WildFly when DeltaSpike is installed as a JBoss module.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-905) Missing OSGi headers in Proxy modules
[
https://issues.apache.org/jira/browse/DELTASPIKE-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14573268#comment-14573268
]
ASF GitHub Bot commented on DELTASPIKE-905:
---
Github user rafabene closed the pull request at:
https://github.com/apache/deltaspike/pull/36
> Missing OSGi headers in Proxy modules
> -
>
> Key: DELTASPIKE-905
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-905
> Project: DeltaSpike
> Issue Type: Bug
> Components: PartialBean
>Affects Versions: 1.4.0
>Reporter: Harald Wellmann
>Assignee: Rafael Benevides
> Fix For: 1.4.1
>
>
> {{deltaspike-partial-bean-module-impl}} imports package
> {{org.apache.deltaspike.proxy.api}}, but the new proxy modules are missing
> OSGi manifest headers.
> This breaks Partial Beans and Data modules for OSGi users.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-905) Missing OSGi headers in Proxy modules
[
https://issues.apache.org/jira/browse/DELTASPIKE-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14573247#comment-14573247
]
ASF GitHub Bot commented on DELTASPIKE-905:
---
GitHub user hwellmann opened a pull request:
https://github.com/apache/deltaspike/pull/38
DELTASPIKE-905 refactored ProxyClassGeneratorLookup to inner class
Reworked Rafael's patch which did not work since an abstract class cannot
be instantiated by SCR. Now using a concrete inner class.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hwellmann/deltaspike DELTASPIKE-905
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/deltaspike/pull/38.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #38
commit aa9175842bc44e402a534c68f151ad4686ae7937
Author: Harald Wellmann
Date: 2015-06-04T17:47:15Z
DELTASPIKE-905 refactored ProxyClassGeneratorLookup to inner class
> Missing OSGi headers in Proxy modules
> -
>
> Key: DELTASPIKE-905
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-905
> Project: DeltaSpike
> Issue Type: Bug
> Components: PartialBean
>Affects Versions: 1.4.0
>Reporter: Harald Wellmann
>Assignee: Rafael Benevides
> Fix For: 1.4.1
>
>
> {{deltaspike-partial-bean-module-impl}} imports package
> {{org.apache.deltaspike.proxy.api}}, but the new proxy modules are missing
> OSGi manifest headers.
> This breaks Partial Beans and Data modules for OSGi users.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-916) Weld 2.3 and 3.x support
[ https://issues.apache.org/jira/browse/DELTASPIKE-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14572737#comment-14572737 ] ASF GitHub Bot commented on DELTASPIKE-916: --- Github user jharting closed the pull request at: https://github.com/apache/deltaspike/pull/37 > Weld 2.3 and 3.x support > > > Key: DELTASPIKE-916 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-916 > Project: DeltaSpike > Issue Type: Task >Affects Versions: 1.4.0 >Reporter: Jozef Hartinger >Assignee: Jozef Hartinger > Fix For: 1.4.1 > > > Weld 2.3 and 3.0 are using different maven coordinates for some of the Java > EE API dependencies. We'll need to change the Weld profile in the parent pom > slightly for it to work with all Weld versions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-916) Weld 2.3 and 3.x support
[ https://issues.apache.org/jira/browse/DELTASPIKE-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14572363#comment-14572363 ] ASF GitHub Bot commented on DELTASPIKE-916: --- GitHub user jharting opened a pull request: https://github.com/apache/deltaspike/pull/37 DELTASPIKE-916 Weld 2.3 and 3.x support You can merge this pull request into a Git repository by running: $ git pull https://github.com/jharting/deltaspike DELTASPIKE-916 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/deltaspike/pull/37.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #37 commit ad0ee03f667d575822f54fdb805e20fc449ecd6a Author: Jozef Hartinger Date: 2015-06-04T08:11:39Z DELTASPIKE-916 Weld 2.3 and 3.x support > Weld 2.3 and 3.x support > > > Key: DELTASPIKE-916 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-916 > Project: DeltaSpike > Issue Type: Task >Affects Versions: 1.4.0 >Reporter: Jozef Hartinger >Assignee: Jozef Hartinger > Fix For: 1.4.1 > > > Weld 2.3 and 3.0 are using different maven coordinates for some of the Java > EE API dependencies. We'll need to change the Weld profile in the parent pom > slightly for it to work with all Weld versions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-911) Criteria API - Add support for accept multiple columns in orderBy
[ https://issues.apache.org/jira/browse/DELTASPIKE-911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14571474#comment-14571474 ] ASF GitHub Bot commented on DELTASPIKE-911: --- Github user danielsoro closed the pull request at: https://github.com/apache/deltaspike/pull/34 > Criteria API - Add support for accept multiple columns in orderBy > - > > Key: DELTASPIKE-911 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-911 > Project: DeltaSpike > Issue Type: Improvement > Components: Data-Module >Affects Versions: 1.4.0 >Reporter: Daniel Cunha (soro) > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-905) Missing OSGi headers in Proxy modules
[
https://issues.apache.org/jira/browse/DELTASPIKE-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14569596#comment-14569596
]
ASF GitHub Bot commented on DELTASPIKE-905:
---
GitHub user rafabene opened a pull request:
https://github.com/apache/deltaspike/pull/36
DELTASPIKE-905 - move the code from ProxyClassGeneratorLookup to Delt…
…aSpikeProxyFactory (1:1)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rafabene/deltaspike DELTASPIKE-905
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/deltaspike/pull/36.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #36
commit 9805337380a7cc621c35d5ccc053cf025e9a3c09
Author: Rafael Benevides
Date: 2015-06-02T19:15:06Z
DELTASPIKE-905 - move the code from ProxyClassGeneratorLookup to
DeltaSpikeProxyFactory (1:1)
> Missing OSGi headers in Proxy modules
> -
>
> Key: DELTASPIKE-905
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-905
> Project: DeltaSpike
> Issue Type: Bug
> Components: PartialBean
>Affects Versions: 1.4.0
>Reporter: Harald Wellmann
>Assignee: Rafael Benevides
> Fix For: 1.4.1
>
>
> {{deltaspike-partial-bean-module-impl}} imports package
> {{org.apache.deltaspike.proxy.api}}, but the new proxy modules are missing
> OSGi manifest headers.
> This breaks Partial Beans and Data modules for OSGi users.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-905) Missing OSGi headers in Proxy modules
[
https://issues.apache.org/jira/browse/DELTASPIKE-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14568162#comment-14568162
]
ASF GitHub Bot commented on DELTASPIKE-905:
---
Github user asfgit closed the pull request at:
https://github.com/apache/deltaspike/pull/35
> Missing OSGi headers in Proxy modules
> -
>
> Key: DELTASPIKE-905
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-905
> Project: DeltaSpike
> Issue Type: Bug
> Components: PartialBean
>Affects Versions: 1.4.0
>Reporter: Harald Wellmann
> Fix For: 1.4.1
>
>
> {{deltaspike-partial-bean-module-impl}} imports package
> {{org.apache.deltaspike.proxy.api}}, but the new proxy modules are missing
> OSGi manifest headers.
> This breaks Partial Beans and Data modules for OSGi users.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-905) Missing OSGi headers in Proxy modules
[
https://issues.apache.org/jira/browse/DELTASPIKE-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14568007#comment-14568007
]
ASF GitHub Bot commented on DELTASPIKE-905:
---
GitHub user hwellmann opened a pull request:
https://github.com/apache/deltaspike/pull/35
DELTASPIKE-905 OSGi support for Proxy Module
Added OSGi manifest headers and introduced a local adapter between
ServiceUtils and OSGi Declarative Services.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hwellmann/deltaspike DELTASPIKE-905
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/deltaspike/pull/35.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #35
commit 54d37558cab1ad731b68fbee7152436829a9f32c
Author: Harald Wellmann
Date: 2015-06-01T21:04:54Z
DELTASPIKE-905 OSGi support for Proxy Module
> Missing OSGi headers in Proxy modules
> -
>
> Key: DELTASPIKE-905
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-905
> Project: DeltaSpike
> Issue Type: Bug
> Components: PartialBean
>Affects Versions: 1.4.0
>Reporter: Harald Wellmann
> Fix For: 1.4.1
>
>
> {{deltaspike-partial-bean-module-impl}} imports package
> {{org.apache.deltaspike.proxy.api}}, but the new proxy modules are missing
> OSGi manifest headers.
> This breaks Partial Beans and Data modules for OSGi users.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-911) Criteria API - Add support for accept multiple columns in orderBy
[ https://issues.apache.org/jira/browse/DELTASPIKE-911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14559735#comment-14559735 ] ASF GitHub Bot commented on DELTASPIKE-911: --- GitHub user danielsoro opened a pull request: https://github.com/apache/deltaspike/pull/34 Fixed: DELTASPIKE-911 Criteria API - Add support for accept multiple … …columns in orderBy You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsoro/deltaspike DELTASPIKE-911 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/deltaspike/pull/34.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #34 commit fa0c0f2c438728be001db476c6b589d51138a0bc Author: Daniel Cunha (soro) Date: 2015-05-26T19:52:14Z Fixed: DELTASPIKE-911 Criteria API - Add support for accept multiple columns in orderBy > Criteria API - Add support for accept multiple columns in orderBy > - > > Key: DELTASPIKE-911 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-911 > Project: DeltaSpike > Issue Type: Bug > Components: Data-Module >Affects Versions: 1.4.0 >Reporter: Daniel Cunha (soro) > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-603) removeBy* - similiar to findBy*
[ https://issues.apache.org/jira/browse/DELTASPIKE-603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14556852#comment-14556852 ] ASF GitHub Bot commented on DELTASPIKE-603: --- Github user asfgit closed the pull request at: https://github.com/apache/deltaspike/pull/33 > removeBy* - similiar to findBy* > --- > > Key: DELTASPIKE-603 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-603 > Project: DeltaSpike > Issue Type: Improvement > Components: Data-Module >Reporter: Thomas Andraschko >Assignee: Thomas Hug > > It would be great to allow a removeBy* - simliar to findBy* > e.g. > void removeByBrandId(String brandId); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-603) removeBy* - similiar to findBy*
[ https://issues.apache.org/jira/browse/DELTASPIKE-603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14556713#comment-14556713 ] ASF GitHub Bot commented on DELTASPIKE-603: --- GitHub user danielsoro opened a pull request: https://github.com/apache/deltaspike/pull/33 Fixed: DELTASPIKE-603 removeBy* - similiar to findBy* You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsoro/deltaspike DELTASPIKE-603 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/deltaspike/pull/33.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #33 commit 1238dbaee3fb8c52d99661ada6f4df200d065507 Author: Daniel Cunha (soro) Date: 2015-05-22T19:26:45Z Fixed: DELTASPIKE-603 removeBy* - similiar to findBy* > removeBy* - similiar to findBy* > --- > > Key: DELTASPIKE-603 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-603 > Project: DeltaSpike > Issue Type: Improvement > Components: Data-Module >Reporter: Thomas Andraschko >Assignee: Thomas Hug > > It would be great to allow a removeBy* - simliar to findBy* > e.g. > void removeByBrandId(String brandId); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-908) org.apache.deltaspike.test.scheduler.custom.CustomSchedulerWarFileTest fails with Weld
[
https://issues.apache.org/jira/browse/DELTASPIKE-908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14556554#comment-14556554
]
ASF GitHub Bot commented on DELTASPIKE-908:
---
Github user asfgit closed the pull request at:
https://github.com/apache/deltaspike/pull/32
> org.apache.deltaspike.test.scheduler.custom.CustomSchedulerWarFileTest fails
> with Weld
> --
>
> Key: DELTASPIKE-908
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-908
> Project: DeltaSpike
> Issue Type: Bug
> Components: Scheduler
>Affects Versions: 1.3.0
>Reporter: Tomas Remes
>Assignee: Gerhard Petracek
>Priority: Minor
> Fix For: 1.4.1
>
>
> {noformat}
> junit.framework.AssertionFailedError: expected:<1> but was:<0>
> at junit.framework.Assert.fail(Assert.java:50)
> at junit.framework.Assert.failNotEquals(Assert.java:287)
> at junit.framework.Assert.assertEquals(Assert.java:67)
> at junit.framework.Assert.assertEquals(Assert.java:199)
> at junit.framework.Assert.assertEquals(Assert.java:205)
> at
> org.apache.deltaspike.test.scheduler.custom.CustomSchedulerTest.checkAutoRegisteredSchedulerJob(CustomSchedulerTest.java:54)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:483)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42)
> at org.jboss.arquillian.junit.Arquillian$6$1.invoke(Arquillian.java:273)
> at
> org.jboss.arquillian.container.test.impl.execution.LocalTestExecuter.execute(LocalTestExecuter.java:60)
> {noformat}
> I am not sure what's the cause yet. I need to do further investigation. Weld
> version doesn't matter here.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-908) org.apache.deltaspike.test.scheduler.custom.CustomSchedulerWarFileTest fails with Weld
[
https://issues.apache.org/jira/browse/DELTASPIKE-908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14556515#comment-14556515
]
ASF GitHub Bot commented on DELTASPIKE-908:
---
GitHub user danielsoro opened a pull request:
https://github.com/apache/deltaspike/pull/32
Fixed: [DELTASPIKE-908] org.apache.deltaspike.test.scheduler.custom.C…
…ustomSchedulerWarFileTest fails with Weld
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/danielsoro/deltaspike DELTASPIKE-908
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/deltaspike/pull/32.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #32
commit 00df37802d61fdd93cf477235daa82baf2ffe344
Author: Daniel Cunha (soro)
Date: 2015-05-22T17:55:45Z
Fixed: [DELTASPIKE-908]
org.apache.deltaspike.test.scheduler.custom.CustomSchedulerWarFileTest fails
with Weld
> org.apache.deltaspike.test.scheduler.custom.CustomSchedulerWarFileTest fails
> with Weld
> --
>
> Key: DELTASPIKE-908
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-908
> Project: DeltaSpike
> Issue Type: Bug
> Components: Scheduler
>Affects Versions: 1.3.0
>Reporter: Tomas Remes
>Assignee: Gerhard Petracek
>Priority: Minor
> Fix For: 1.4.1
>
>
> {noformat}
> junit.framework.AssertionFailedError: expected:<1> but was:<0>
> at junit.framework.Assert.fail(Assert.java:50)
> at junit.framework.Assert.failNotEquals(Assert.java:287)
> at junit.framework.Assert.assertEquals(Assert.java:67)
> at junit.framework.Assert.assertEquals(Assert.java:199)
> at junit.framework.Assert.assertEquals(Assert.java:205)
> at
> org.apache.deltaspike.test.scheduler.custom.CustomSchedulerTest.checkAutoRegisteredSchedulerJob(CustomSchedulerTest.java:54)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:483)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42)
> at org.jboss.arquillian.junit.Arquillian$6$1.invoke(Arquillian.java:273)
> at
> org.jboss.arquillian.container.test.impl.execution.LocalTestExecuter.execute(LocalTestExecuter.java:60)
> {noformat}
> I am not sure what's the cause yet. I need to do further investigation. Weld
> version doesn't matter here.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-906) Extract debug information in pom.xml and put in documentation.
[ https://issues.apache.org/jira/browse/DELTASPIKE-906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14551277#comment-14551277 ] ASF GitHub Bot commented on DELTASPIKE-906: --- Github user asfgit closed the pull request at: https://github.com/apache/deltaspike/pull/31 > Extract debug information in pom.xml and put in documentation. > -- > > Key: DELTASPIKE-906 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-906 > Project: DeltaSpike > Issue Type: Task >Reporter: Daniel Cunha (soro) >Priority: Trivial > > In parent/code/pom.xml we have this: > * DEBUGGING: > * mvn test -Ptomee-build-managed -Dtest=UnitTestName > -Dopenejb.server.debug=true > * then use remote debuggig at port 5005 > Maybe this information should be in DeltaSpike documentation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-660) OSGi support for DeltaSpike Data and its dependencies
[ https://issues.apache.org/jira/browse/DELTASPIKE-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14505046#comment-14505046 ] ASF GitHub Bot commented on DELTASPIKE-660: --- Github user hwellmann closed the pull request at: https://github.com/apache/deltaspike/pull/12 > OSGi support for DeltaSpike Data and its dependencies > - > > Key: DELTASPIKE-660 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-660 > Project: DeltaSpike > Issue Type: Improvement >Affects Versions: 1.0.0 >Reporter: Harald Wellmann >Assignee: Rafael Benevides > Fix For: 1.2.1 > > > Goal: > Users can work with DeltaSpike Data in OSGi applications, using Pax CDI. > Some DeltaSpike modules already have OSGi manifest headers (see > DELTASPIKE-210), others don't. > There is a working test case in Pax CDI which wraps DeltaSpike JARs on the > fly, adding all missing headers: > https://github.com/ops4j/org.ops4j.pax.cdi/blob/master/itest/src/it/itest-cdi10/src/test/java/org/ops4j/pax/cdi/test/TransactionalTest.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-556) Impl-Weld tests: Unpacking causes ambiguous dependencies
[ https://issues.apache.org/jira/browse/DELTASPIKE-556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14504925#comment-14504925 ] ASF GitHub Bot commented on DELTASPIKE-556: --- Github user bafco closed the pull request at: https://github.com/apache/deltaspike/pull/2 > Impl-Weld tests: Unpacking causes ambiguous dependencies > > > Key: DELTASPIKE-556 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-556 > Project: DeltaSpike > Issue Type: Task > Components: CdiControl, Tests >Affects Versions: 0.6 >Reporter: Matej Briškár >Assignee: Mark Struberg > Fix For: 0.7 > > > Unpacking the maven .jar file to the local test-classes folder using maven > plugin causes Weld to see both, .jar file and the unpacked classes. This > leads to ambiguous dependency > tests output url: > https://builds.apache.org/view/A-D/view/DeltaSpike/job/DeltaSpike%20Weld%202.2.0.Beta2/5/testReport/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-860) documentation says "@LoggedIn User user", but that's impossible
[
https://issues.apache.org/jira/browse/DELTASPIKE-860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14504760#comment-14504760
]
ASF GitHub Bot commented on DELTASPIKE-860:
---
Github user The-Alchemist closed the pull request at:
https://github.com/apache/deltaspike/pull/23
> documentation says "@LoggedIn User user", but that's impossible
> ---
>
> Key: DELTASPIKE-860
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-860
> Project: DeltaSpike
> Issue Type: Bug
> Components: Documentation
>Reporter: The Alchemist
>Assignee: Rafael Benevides
>Priority: Minor
>
> h3. Documentation Snippet
> http://deltaspike.apache.org/documentation/security.html
> {noformat}
> Create the Authorizer
> @ApplicationScoped
> public class CustomAuthorizer
> {
> @Secures
> @CustomSecurityBinding
> public boolean doSecuredCheck(InvocationContext invocationContext,
> BeanManager manager, @LoggedIn User user) throws Exception
> {
> return user.isLoggedIn(); // perform security check
> }
> }
> {noformat}
> h3. Compilation Error
> {noformat}
> The annotation @LoggedIn is disallowed for this location
> {noformat}
> h3. Explanation?
> I think it's because {{LoggedIn}} is missing a {{@Target}} of {{PARAMETER}}.
> {code:java,title=LoggedIn.java}
> @Retention(value = RetentionPolicy.RUNTIME)
> @Target({ ElementType.TYPE, ElementType.METHOD })
> @Documented
> @SecurityBindingType
> public @interface LoggedIn {
> {code}
> h3. Conclusion
> Not sure if this is supposed to work, given that {{LoggedIn}} is part of
> PicketLink, not DeltaSpike.
> Is there a workaround for this type of situation?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-813) improve basic core documentation
[ https://issues.apache.org/jira/browse/DELTASPIKE-813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14504761#comment-14504761 ] ASF GitHub Bot commented on DELTASPIKE-813: --- Github user rsmeral closed the pull request at: https://github.com/apache/deltaspike/pull/27 > improve basic core documentation > > > Key: DELTASPIKE-813 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-813 > Project: DeltaSpike > Issue Type: Task > Components: Documentation >Affects Versions: 1.2.1 >Reporter: Gerhard Petracek >Assignee: Rafael Benevides > Fix For: 1.3.1 > > > in this first step we should improve everything which is marked red or yellow > in the documentation column and green or yellow in the "importance for > average users" column ( see > https://cwiki.apache.org/confluence/display/DeltaSpike/DS-Core+Overview ) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-876) Website navigation bar active tab highlighting broken
[ https://issues.apache.org/jira/browse/DELTASPIKE-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14504735#comment-14504735 ] ASF GitHub Bot commented on DELTASPIKE-876: --- Github user rsmeral closed the pull request at: https://github.com/apache/deltaspike/pull/29 > Website navigation bar active tab highlighting broken > - > > Key: DELTASPIKE-876 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-876 > Project: DeltaSpike > Issue Type: Bug > Components: Documentation >Reporter: Ron Smeral >Assignee: Ron Smeral >Priority: Minor > > The website currently always shows "Home" as the active tab. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-875) HTTPS support for site and documentation
[ https://issues.apache.org/jira/browse/DELTASPIKE-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14504736#comment-14504736 ] ASF GitHub Bot commented on DELTASPIKE-875: --- Github user rsmeral closed the pull request at: https://github.com/apache/deltaspike/pull/28 > HTTPS support for site and documentation > > > Key: DELTASPIKE-875 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-875 > Project: DeltaSpike > Issue Type: Improvement > Components: Documentation >Reporter: Ron Smeral >Assignee: Ron Smeral >Priority: Minor > > Currently, HTTPS access to DS website is slightly broken due to some HTTP > elements which should be HTTPS (google site search, font awesome link, ..). > That yields browser warnings and broken icons in documentation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-876) Website navigation bar active tab highlighting broken
[ https://issues.apache.org/jira/browse/DELTASPIKE-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498458#comment-14498458 ] ASF GitHub Bot commented on DELTASPIKE-876: --- GitHub user rsmeral opened a pull request: https://github.com/apache/deltaspike/pull/29 DELTASPIKE-876 Website navigation bar active tab highlighting broken Also, removed toc attribute from all documents, since TOC generation is handled in the template. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rsmeral/deltaspike DELTASPIKE-876 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/deltaspike/pull/29.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #29 commit 21f9cc05b465301f395a4ce4fffaad472e15e0bd Author: Ron Smeral Date: 2015-04-16T18:22:37Z DELTASPIKE-876 Website navigation bar active tab highlighting broken > Website navigation bar active tab highlighting broken > - > > Key: DELTASPIKE-876 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-876 > Project: DeltaSpike > Issue Type: Bug > Components: Documentation >Reporter: Ron Smeral >Priority: Minor > > The website currently always shows "Home" as the active tab. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-875) HTTPS support for site and documentation
[ https://issues.apache.org/jira/browse/DELTASPIKE-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14497995#comment-14497995 ] ASF GitHub Bot commented on DELTASPIKE-875: --- GitHub user rsmeral opened a pull request: https://github.com/apache/deltaspike/pull/28 DELTASPIKE-875 HTTPS support for site and documentation You can merge this pull request into a Git repository by running: $ git pull https://github.com/rsmeral/deltaspike DELTASPIKE-875 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/deltaspike/pull/28.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #28 commit e7af2a7848ee724d3e62aa870af398cfe9a56e90 Author: Ron Smeral Date: 2015-04-16T12:05:16Z DELTASPIKE-875 HTTPS support for site and documentation > HTTPS support for site and documentation > > > Key: DELTASPIKE-875 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-875 > Project: DeltaSpike > Issue Type: Improvement > Components: Documentation >Reporter: Ron Smeral >Priority: Minor > > Currently, HTTPS access to DS website is slightly broken due to some HTTP > elements which should be HTTPS (google site search, font awesome link, ..). > That yields browser warnings and broken icons in documentation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-813) improve basic core documentation
[ https://issues.apache.org/jira/browse/DELTASPIKE-813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14494017#comment-14494017 ] ASF GitHub Bot commented on DELTASPIKE-813: --- Github user rsmeral commented on a diff in the pull request: https://github.com/apache/deltaspike/pull/27#discussion_r28320133 --- Diff: documentation/src/main/asciidoc/core.adoc --- @@ -123,6 +124,29 @@ fields. BeanProvider.injectFields(myObject); += DependentProvider + +`DependentProvider` must be used instead of `BeanProvider` to obtain instances of dependent-scoped beans to allow for +their proper destruction. + +When obtaining contextual instances using `@Inject`, the normal-scoped ones get destroyed along with their associated +context. However, instances of dependent-scoped beans -- as implied by their name -- depend on the lifecycle of +the contextual instance which declares them and get destroyed along with this declaring bean's instance. + +However, if dependent-scoped instances are obtained programmatically using `DependentProvider`, there's no +"declaring bean" to speak of and they *must be destroyed manually*. --- End diff -- Not 100% sure about this, can someone confirm? > improve basic core documentation > > > Key: DELTASPIKE-813 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-813 > Project: DeltaSpike > Issue Type: Task > Components: Documentation >Affects Versions: 1.2.1 >Reporter: Gerhard Petracek >Assignee: Rafael Benevides > Fix For: 1.3.1 > > > in this first step we should improve everything which is marked red or yellow > in the documentation column and green or yellow in the "importance for > average users" column ( see > https://cwiki.apache.org/confluence/display/DeltaSpike/DS-Core+Overview ) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-813) improve basic core documentation
[ https://issues.apache.org/jira/browse/DELTASPIKE-813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14494016#comment-14494016 ] ASF GitHub Bot commented on DELTASPIKE-813: --- GitHub user rsmeral opened a pull request: https://github.com/apache/deltaspike/pull/27 DELTASPIKE-813 Core docs: added DependentProvider, AnnotationInstancePro... ...vider, AnnotationUtils You can merge this pull request into a Git repository by running: $ git pull https://github.com/rsmeral/deltaspike DELTASPIKE-813-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/deltaspike/pull/27.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #27 commit 71944dc78490bdea038b71843d3f96709848fab4 Author: Ron Smeral Date: 2015-04-14T11:57:14Z DELTASPIKE-813 Core docs: added DependentProvider, AnnotationInstanceProvider, AnnotationUtils > improve basic core documentation > > > Key: DELTASPIKE-813 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-813 > Project: DeltaSpike > Issue Type: Task > Components: Documentation >Affects Versions: 1.2.1 >Reporter: Gerhard Petracek >Assignee: Rafael Benevides > Fix For: 1.3.1 > > > in this first step we should improve everything which is marked red or yellow > in the documentation column and green or yellow in the "importance for > average users" column ( see > https://cwiki.apache.org/confluence/display/DeltaSpike/DS-Core+Overview ) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-846) Docs: Clarify that scheduler module has manual dependencies
[ https://issues.apache.org/jira/browse/DELTASPIKE-846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14483246#comment-14483246 ] ASF GitHub Bot commented on DELTASPIKE-846: --- Github user rsmeral closed the pull request at: https://github.com/apache/deltaspike/pull/20 > Docs: Clarify that scheduler module has manual dependencies > --- > > Key: DELTASPIKE-846 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-846 > Project: DeltaSpike > Issue Type: Improvement > Components: Documentation >Affects Versions: 1.2.1 >Reporter: Ron Smeral >Priority: Minor > > See DELTASPIKE-824. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-850) Add Weld 3 profile
[ https://issues.apache.org/jira/browse/DELTASPIKE-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14482792#comment-14482792 ] ASF GitHub Bot commented on DELTASPIKE-850: --- Github user rsmeral closed the pull request at: https://github.com/apache/deltaspike/pull/21 > Add Weld 3 profile > -- > > Key: DELTASPIKE-850 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-850 > Project: DeltaSpike > Issue Type: Task > Components: Build >Reporter: Ron Smeral >Assignee: Rafael Benevides >Priority: Trivial > > Weld 3 is now split into several modules and the weld-core module is renamed > to weld-core-impl, so the "Weld" profile no longer works for Weld 3. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-867) Clarify that Test-Control module has manual dependencies on CDI implementations
[ https://issues.apache.org/jira/browse/DELTASPIKE-867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14482790#comment-14482790 ] ASF GitHub Bot commented on DELTASPIKE-867: --- Github user rsmeral closed the pull request at: https://github.com/apache/deltaspike/pull/25 > Clarify that Test-Control module has manual dependencies on CDI > implementations > --- > > Key: DELTASPIKE-867 > URL: https://issues.apache.org/jira/browse/DELTASPIKE-867 > Project: DeltaSpike > Issue Type: Bug > Components: Documentation >Reporter: Ron Smeral >Assignee: Rafael Benevides >Priority: Minor > > It is kind of obvious, but it may be easier for beginners to start with > DeltaSpike Test-Control module if this is mentioned - that openwebbeans-impl > or weld-se-core needs to be added as a dependency manually. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
