[jira] [Commented] (DELTASPIKE-1091) Weld core BOM update in next 2.3/3.x release

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268766#comment-15268766
 ] 

ASF GitHub Bot commented on DELTASPIKE-1091:


Github user asfgit closed the pull request at:

https://github.com/apache/deltaspike/pull/49


> Weld core BOM update in next 2.3/3.x release
> 
>
> Key: DELTASPIKE-1091
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1091
> Project: DeltaSpike
>  Issue Type: Improvement
>  Components: Build
>Reporter: Matej Novotny
>Assignee: Rafael Benevides
>
> The next release of Weld 2.3 (2.3.4.Final) and 3.x (3.0.Alpha16) will also 
> contain a refactored weld-core BOM files.
> This is per request in [WELD-2115|https://issues.jboss.org/browse/WELD-2115].
> BOM will no longer provide direct dependencies, but only 
> {{dependencyManagement}} section. Looking at deltaspike dependencies, this 
> will affect 
> [{{parent/code/pom.xml}}|https://github.com/apache/deltaspike/blob/master/deltaspike/parent/code/pom.xml#L355]
>  and will require changes.
> The PRs for BOM changes are:
> * 2.3 branch -> https://github.com/weld/core/pull/1295
> * master -> https://github.com/weld/core/pull/1296



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DELTASPIKE-1091) Weld core BOM update in next 2.3/3.x release

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268672#comment-15268672
 ] 

ASF GitHub Bot commented on DELTASPIKE-1091:


Github user manovotn commented on a diff in the pull request:

https://github.com/apache/deltaspike/pull/49#discussion_r61877744
  
--- Diff: deltaspike/parent/pom.xml ---
@@ -49,7 +49,8 @@
 
 1.6
 1.2.7
-1.1.28.Final
+
+1.1.9.Final
--- End diff --

This is based on a Gerhard's comment. He claimed that the idea is to list 
the minimal supported version. Although I strongly dislike dislike this 
approach, I put it here.
However if you look into Weld1 profile, you can see it is overriden by 
current version (1.1.33.Final). So this version declaration is naught but a 
mere information :)


> Weld core BOM update in next 2.3/3.x release
> 
>
> Key: DELTASPIKE-1091
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1091
> Project: DeltaSpike
>  Issue Type: Improvement
>  Components: Build
>Reporter: Matej Novotny
>Assignee: Rafael Benevides
>
> The next release of Weld 2.3 (2.3.4.Final) and 3.x (3.0.Alpha16) will also 
> contain a refactored weld-core BOM files.
> This is per request in [WELD-2115|https://issues.jboss.org/browse/WELD-2115].
> BOM will no longer provide direct dependencies, but only 
> {{dependencyManagement}} section. Looking at deltaspike dependencies, this 
> will affect 
> [{{parent/code/pom.xml}}|https://github.com/apache/deltaspike/blob/master/deltaspike/parent/code/pom.xml#L355]
>  and will require changes.
> The PRs for BOM changes are:
> * 2.3 branch -> https://github.com/weld/core/pull/1295
> * master -> https://github.com/weld/core/pull/1296



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DELTASPIKE-1091) Weld core BOM update in next 2.3/3.x release

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268643#comment-15268643
 ] 

ASF GitHub Bot commented on DELTASPIKE-1091:


Github user johnament commented on a diff in the pull request:

https://github.com/apache/deltaspike/pull/49#discussion_r61874873
  
--- Diff: deltaspike/parent/pom.xml ---
@@ -49,7 +49,8 @@
 
 1.6
 1.2.7
-1.1.28.Final
+
+1.1.9.Final
--- End diff --

why downgrade?


> Weld core BOM update in next 2.3/3.x release
> 
>
> Key: DELTASPIKE-1091
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1091
> Project: DeltaSpike
>  Issue Type: Improvement
>  Components: Build
>Reporter: Matej Novotny
>Assignee: Rafael Benevides
>
> The next release of Weld 2.3 (2.3.4.Final) and 3.x (3.0.Alpha16) will also 
> contain a refactored weld-core BOM files.
> This is per request in [WELD-2115|https://issues.jboss.org/browse/WELD-2115].
> BOM will no longer provide direct dependencies, but only 
> {{dependencyManagement}} section. Looking at deltaspike dependencies, this 
> will affect 
> [{{parent/code/pom.xml}}|https://github.com/apache/deltaspike/blob/master/deltaspike/parent/code/pom.xml#L355]
>  and will require changes.
> The PRs for BOM changes are:
> * 2.3 branch -> https://github.com/weld/core/pull/1295
> * master -> https://github.com/weld/core/pull/1296



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DELTASPIKE-1091) Weld core BOM update in next 2.3/3.x release

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268335#comment-15268335
 ] 

ASF GitHub Bot commented on DELTASPIKE-1091:


GitHub user manovotn opened a pull request:

https://github.com/apache/deltaspike/pull/49

DELTASPIKE-1091 add default values to Weld profiles.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/manovotn/deltaspike weldProfiles

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/deltaspike/pull/49.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #49


commit 1482edcdc9fa7f7727b1169b74a83766c0d74b58
Author: Matej Novotny 
Date:   2016-05-03T08:04:53Z

DELTASPIKE-1091 add default values to Weld profiles.




> Weld core BOM update in next 2.3/3.x release
> 
>
> Key: DELTASPIKE-1091
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1091
> Project: DeltaSpike
>  Issue Type: Improvement
>  Components: Build
>Reporter: Matej Novotny
>Assignee: Rafael Benevides
>
> The next release of Weld 2.3 (2.3.4.Final) and 3.x (3.0.Alpha16) will also 
> contain a refactored weld-core BOM files.
> This is per request in [WELD-2115|https://issues.jboss.org/browse/WELD-2115].
> BOM will no longer provide direct dependencies, but only 
> {{dependencyManagement}} section. Looking at deltaspike dependencies, this 
> will affect 
> [{{parent/code/pom.xml}}|https://github.com/apache/deltaspike/blob/master/deltaspike/parent/code/pom.xml#L355]
>  and will require changes.
> The PRs for BOM changes are:
> * 2.3 branch -> https://github.com/weld/core/pull/1295
> * master -> https://github.com/weld/core/pull/1296



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DELTASPIKE-1091) Weld core BOM update in next 2.3/3.x release

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15267018#comment-15267018
 ] 

ASF GitHub Bot commented on DELTASPIKE-1091:


Github user asfgit closed the pull request at:

https://github.com/apache/deltaspike/pull/47


> Weld core BOM update in next 2.3/3.x release
> 
>
> Key: DELTASPIKE-1091
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1091
> Project: DeltaSpike
>  Issue Type: Improvement
>  Components: Build
>Reporter: Matej Novotny
>Assignee: Rafael Benevides
>
> The next release of Weld 2.3 (2.3.4.Final) and 3.x (3.0.Alpha16) will also 
> contain a refactored weld-core BOM files.
> This is per request in [WELD-2115|https://issues.jboss.org/browse/WELD-2115].
> BOM will no longer provide direct dependencies, but only 
> {{dependencyManagement}} section. Looking at deltaspike dependencies, this 
> will affect 
> [{{parent/code/pom.xml}}|https://github.com/apache/deltaspike/blob/master/deltaspike/parent/code/pom.xml#L355]
>  and will require changes.
> The PRs for BOM changes are:
> * 2.3 branch -> https://github.com/weld/core/pull/1295
> * master -> https://github.com/weld/core/pull/1296



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DELTASPIKE-1091) Weld core BOM update in next 2.3/3.x release

[Matej Novotny (JIRA)]

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15262059#comment-15262059
 ] 

Matej Novotny commented on DELTASPIKE-1091:
---

[~gpetracek] I created a PR for this - 
https://github.com/apache/deltaspike/pull/47
A more in-depth explanation of my solution can be found in the PR comment.

BTW at first I accidentaly created the PR as "DELTAPIKE-1137", hence your bot 
didnt link it here. I already edited that.

Comments to the PR are welcome :)

> Weld core BOM update in next 2.3/3.x release
> 
>
> Key: DELTASPIKE-1091
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1091
> Project: DeltaSpike
>  Issue Type: Improvement
>  Components: Build
>Reporter: Matej Novotny
>Assignee: Rafael Benevides
>
> The next release of Weld 2.3 (2.3.4.Final) and 3.x (3.0.Alpha16) will also 
> contain a refactored weld-core BOM files.
> This is per request in [WELD-2115|https://issues.jboss.org/browse/WELD-2115].
> BOM will no longer provide direct dependencies, but only 
> {{dependencyManagement}} section. Looking at deltaspike dependencies, this 
> will affect 
> [{{parent/code/pom.xml}}|https://github.com/apache/deltaspike/blob/master/deltaspike/parent/code/pom.xml#L355]
>  and will require changes.
> The PRs for BOM changes are:
> * 2.3 branch -> https://github.com/weld/core/pull/1295
> * master -> https://github.com/weld/core/pull/1296



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DELTASPIKE-1091) Weld core BOM update in next 2.3/3.x release

[Matej Novotny (JIRA)]

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15249623#comment-15249623
 ] 

Matej Novotny commented on DELTASPIKE-1091:
---

We have just incorporated this change into master and 2.3 branches.
ATM we are working on the 2.3.4.release and 3.0.0.Alpha16 will follow shortly 
afterwards (within 2 weeks).

Obviously, DS test suite now fails with {{ClassNotFound}} as the dependencies 
do not get pulled in.
You can try that yourself, if you build Weld from [2.3.4.Final 
tag|https://github.com/weld/core/tree/2.3.4.Final] and then run your test suit 
with {{mvn clean verify -PWeld -Dweld.version=2.3.4.Final}}.

DS needs to adjust to this. The simplest way would probably be to introduce 
profiles for different Weld versions?

> Weld core BOM update in next 2.3/3.x release
> 
>
> Key: DELTASPIKE-1091
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1091
> Project: DeltaSpike
>  Issue Type: Improvement
>  Components: Build
>Reporter: Matej Novotny
>Assignee: Rafael Benevides
>
> The next release of Weld 2.3 (2.3.4.Final) and 3.x (3.0.Alpha16) will also 
> contain a refactored weld-core BOM files.
> This is per request in [WELD-2115|https://issues.jboss.org/browse/WELD-2115].
> BOM will no longer provide direct dependencies, but only 
> {{dependencyManagement}} section. Looking at deltaspike dependencies, this 
> will affect 
> [{{parent/code/pom.xml}}|https://github.com/apache/deltaspike/blob/master/deltaspike/parent/code/pom.xml#L355]
>  and will require changes.
> The PRs for BOM changes are:
> * 2.3 branch -> https://github.com/weld/core/pull/1295
> * master -> https://github.com/weld/core/pull/1296



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)