[jira] [Commented] (DELTASPIKE-1117) add cache(long ms) to ConfigResolver.TypedResolver

2016-04-06 Thread Romain Manni-Bucau (JIRA)

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228329#comment-15228329
 ] 

Romain Manni-Bucau commented on DELTASPIKE-1117:


[~struberg] would it makes sense to not do it in DS but wire it to a Storage 
then user can use any caching impl he wants instead of redoing it in DS? The 
SPI would be pretty thin.

> add cache(long ms) to ConfigResolver.TypedResolver
> --
>
> Key: DELTASPIKE-1117
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1117
> Project: DeltaSpike
>  Issue Type: Bug
>  Components: Configuration
>Affects Versions: 1.6.0
>Reporter: Mark Struberg
>Assignee: Mark Struberg
> Fix For: 1.6.1
>
>
> add a method to automatically cache resolved values until for a specific time



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (DELTASPIKE-1117) add cache(long ms) to ConfigResolver.TypedResolver

2016-04-06 Thread Mark Struberg (JIRA)

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228350#comment-15228350
 ] 

Mark Struberg commented on DELTASPIKE-1117:
---

Users can already do that. But adding this simple method to the builder is a 
big gain and does not cost much (2 longs internally).

> add cache(long ms) to ConfigResolver.TypedResolver
> --
>
> Key: DELTASPIKE-1117
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1117
> Project: DeltaSpike
>  Issue Type: Bug
>  Components: Configuration
>Affects Versions: 1.6.0
>Reporter: Mark Struberg
>Assignee: Mark Struberg
> Fix For: 1.6.1
>
>
> add a method to automatically cache resolved values until for a specific time



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (DELTASPIKE-1117) add cache(long ms) to ConfigResolver.TypedResolver

2016-04-06 Thread Romain Manni-Bucau (JIRA)

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228363#comment-15228363
 ] 

Romain Manni-Bucau commented on DELTASPIKE-1117:


[~struberg] it does since then you need evict(key) and you will likely want 
this caching at source level too or by key pattern next time. Having a cache 
SPI will allow to rely on widely used cache implementation and get it for free 
letting the user design its configuration/keys as he wants (= add Cache SPI in 
DS and not cache in a map internally if provided but use that cache, this is 
not doable today or if it is this feature is useless, no?).

> add cache(long ms) to ConfigResolver.TypedResolver
> --
>
> Key: DELTASPIKE-1117
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1117
> Project: DeltaSpike
>  Issue Type: Bug
>  Components: Configuration
>Affects Versions: 1.6.0
>Reporter: Mark Struberg
>Assignee: Mark Struberg
> Fix For: 1.6.1
>
>
> add a method to automatically cache resolved values until for a specific time



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (DELTASPIKE-1117) add cache(long ms) to ConfigResolver.TypedResolver

2016-04-06 Thread Mark Struberg (JIRA)

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228426#comment-15228426
 ] 

Mark Struberg commented on DELTASPIKE-1117:
---

there is no Map in DS. It's really a simple long reloadAfter logic + the last 
value. That's it. Of couse, every value has it's own timeout. If you need a 
full cache, then it's a different story.

> add cache(long ms) to ConfigResolver.TypedResolver
> --
>
> Key: DELTASPIKE-1117
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1117
> Project: DeltaSpike
>  Issue Type: Bug
>  Components: Configuration
>Affects Versions: 1.6.0
>Reporter: Mark Struberg
>Assignee: Mark Struberg
> Fix For: 1.6.1
>
>
> add a method to automatically cache resolved values until for a specific time



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)