[jira] [Commented] (DELTASPIKE-1141) @Futureable and @Locked cannot work with CDI 1.0/Weld 1.x
[
https://issues.apache.org/jira/browse/DELTASPIKE-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15270354#comment-15270354
]
Martin Kouba commented on DELTASPIKE-1141:
--
It's not a problem for arquillian-weld-ee-embedded-1.1 because it's using a
"flat" deployment structure - all bean classes share the same bean archive and
all {{beans.xml}} descriptors are automatically merged into one.
> @Futureable and @Locked cannot work with CDI 1.0/Weld 1.x
> -
>
> Key: DELTASPIKE-1141
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1141
> Project: DeltaSpike
> Issue Type: Bug
>Affects Versions: 1.6.1
> Environment: CDI 1.x/Weld 1.x
> EAP 6/JBoss AS 7
>Reporter: Matej Novotny
>
> Follow-up on DELTASPIKE-1138.
> There is still a problem which affects at least two DS features - @Futureable
> and @Locked.
> Both of them have an interceptor enabled in DS core jar file (via beans.xml).
> However this will not work with CDI 1.0/Weld 1.x!
> The reason is the eternal holy war for what exactly is a 'bean archive' :-).
> Weld will consider the interceptor enabled only for the core jar itself hence
> it will not kick in.
> How to reproduce:
> * Run DS on JBoss AS 7 (JDK 1.7 or lower) or EAP 6 (all JDKs)
> ** {{mvn clean verify -Pjbossas-build-managed-7 -Dweld.version=1.1.33.Final
> -Dtest=FutureableTest}}
> * To make the test pass, you can add {{beans.xml}} containing the interceptor
> [here|https://github.com/apache/deltaspike/blob/master/deltaspike/core/impl/src/test/java/org/apache/deltaspike/test/core/impl/future/FutureableTest.java#L45]
> (same works for LockedTest)
> ** *The above trick is not a fix though!* Merely a workaround allowing Weld
> to enable the interceptor within test archive
> ** I think any user aiming to use these features with Weld 1.x would need to
> use this workaround in his/her deployments which is ugly
> Notes:
> * {{@Priority}} cannot be used here (for CDI 1.0)
> * GlobalInterceptorExtension won't help either as it is working since CDI 1.1+
> * This is not a problem for embedded container (e.g. running via {{-PWeld1}})
> ** This is probably because of different structure of embedded deployments
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1141) @Futureable and @Locked cannot work with CDI 1.0/Weld 1.x
[
https://issues.apache.org/jira/browse/DELTASPIKE-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15270590#comment-15270590
]
Matej Novotny commented on DELTASPIKE-1141:
---
So to sum this up:
* it is considered to be common practice for weld 1 users to add interceptors
to their beans.xml in order to enable certain DS features
* same principle applies to these two features discussed here
* hence this is not a bug and a solution is therefore to simply fix the tests
by adding the relevant beans.xml
Will send a PR shortly.
> @Futureable and @Locked cannot work with CDI 1.0/Weld 1.x
> -
>
> Key: DELTASPIKE-1141
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1141
> Project: DeltaSpike
> Issue Type: Bug
>Affects Versions: 1.6.1
> Environment: CDI 1.x/Weld 1.x
> EAP 6/JBoss AS 7
>Reporter: Matej Novotny
>
> Follow-up on DELTASPIKE-1138.
> There is still a problem which affects at least two DS features - @Futureable
> and @Locked.
> Both of them have an interceptor enabled in DS core jar file (via beans.xml).
> However this will not work with CDI 1.0/Weld 1.x!
> The reason is the eternal holy war for what exactly is a 'bean archive' :-).
> Weld will consider the interceptor enabled only for the core jar itself hence
> it will not kick in.
> How to reproduce:
> * Run DS on JBoss AS 7 (JDK 1.7 or lower) or EAP 6 (all JDKs)
> ** {{mvn clean verify -Pjbossas-build-managed-7 -Dweld.version=1.1.33.Final
> -Dtest=FutureableTest}}
> * To make the test pass, you can add {{beans.xml}} containing the interceptor
> [here|https://github.com/apache/deltaspike/blob/master/deltaspike/core/impl/src/test/java/org/apache/deltaspike/test/core/impl/future/FutureableTest.java#L45]
> (same works for LockedTest)
> ** *The above trick is not a fix though!* Merely a workaround allowing Weld
> to enable the interceptor within test archive
> ** I think any user aiming to use these features with Weld 1.x would need to
> use this workaround in his/her deployments which is ugly
> Notes:
> * {{@Priority}} cannot be used here (for CDI 1.0)
> * GlobalInterceptorExtension won't help either as it is working since CDI 1.1+
> * This is not a problem for embedded container (e.g. running via {{-PWeld1}})
> ** This is probably because of different structure of embedded deployments
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1141) @Futureable and @Locked cannot work with CDI 1.0/Weld 1.x
[
https://issues.apache.org/jira/browse/DELTASPIKE-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15270599#comment-15270599
]
ASF GitHub Bot commented on DELTASPIKE-1141:
GitHub user manovotn opened a pull request:
https://github.com/apache/deltaspike/pull/50
DELTASPIKE-1141 modify FutureableTest and LockedTest to contain beans…
….xml with relevant interceptors.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/manovotn/deltaspike ds1141
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/deltaspike/pull/50.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #50
commit d2558b7ddf682e41bc829d69bbdafa4927c23887
Author: Matej Novotny
Date: 2016-05-04T13:07:00Z
DELTASPIKE-1141 modify FutureableTest and LockedTest to contain beans.xml
with relevant interceptors.
> @Futureable and @Locked cannot work with CDI 1.0/Weld 1.x
> -
>
> Key: DELTASPIKE-1141
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1141
> Project: DeltaSpike
> Issue Type: Bug
>Affects Versions: 1.6.1
> Environment: CDI 1.x/Weld 1.x
> EAP 6/JBoss AS 7
>Reporter: Matej Novotny
>
> Follow-up on DELTASPIKE-1138.
> There is still a problem which affects at least two DS features - @Futureable
> and @Locked.
> Both of them have an interceptor enabled in DS core jar file (via beans.xml).
> However this will not work with CDI 1.0/Weld 1.x!
> The reason is the eternal holy war for what exactly is a 'bean archive' :-).
> Weld will consider the interceptor enabled only for the core jar itself hence
> it will not kick in.
> How to reproduce:
> * Run DS on JBoss AS 7 (JDK 1.7 or lower) or EAP 6 (all JDKs)
> ** {{mvn clean verify -Pjbossas-build-managed-7 -Dweld.version=1.1.33.Final
> -Dtest=FutureableTest}}
> * To make the test pass, you can add {{beans.xml}} containing the interceptor
> [here|https://github.com/apache/deltaspike/blob/master/deltaspike/core/impl/src/test/java/org/apache/deltaspike/test/core/impl/future/FutureableTest.java#L45]
> (same works for LockedTest)
> ** *The above trick is not a fix though!* Merely a workaround allowing Weld
> to enable the interceptor within test archive
> ** I think any user aiming to use these features with Weld 1.x would need to
> use this workaround in his/her deployments which is ugly
> Notes:
> * {{@Priority}} cannot be used here (for CDI 1.0)
> * GlobalInterceptorExtension won't help either as it is working since CDI 1.1+
> * This is not a problem for embedded container (e.g. running via {{-PWeld1}})
> ** This is probably because of different structure of embedded deployments
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-1141) @Futureable and @Locked cannot work with CDI 1.0/Weld 1.x
[
https://issues.apache.org/jira/browse/DELTASPIKE-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15271293#comment-15271293
]
ASF GitHub Bot commented on DELTASPIKE-1141:
Github user asfgit closed the pull request at:
https://github.com/apache/deltaspike/pull/50
> @Futureable and @Locked cannot work with CDI 1.0/Weld 1.x
> -
>
> Key: DELTASPIKE-1141
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1141
> Project: DeltaSpike
> Issue Type: Bug
>Affects Versions: 1.6.1
> Environment: CDI 1.x/Weld 1.x
> EAP 6/JBoss AS 7
>Reporter: Matej Novotny
>
> Follow-up on DELTASPIKE-1138.
> There is still a problem which affects at least two DS features - @Futureable
> and @Locked.
> Both of them have an interceptor enabled in DS core jar file (via beans.xml).
> However this will not work with CDI 1.0/Weld 1.x!
> The reason is the eternal holy war for what exactly is a 'bean archive' :-).
> Weld will consider the interceptor enabled only for the core jar itself hence
> it will not kick in.
> How to reproduce:
> * Run DS on JBoss AS 7 (JDK 1.7 or lower) or EAP 6 (all JDKs)
> ** {{mvn clean verify -Pjbossas-build-managed-7 -Dweld.version=1.1.33.Final
> -Dtest=FutureableTest}}
> * To make the test pass, you can add {{beans.xml}} containing the interceptor
> [here|https://github.com/apache/deltaspike/blob/master/deltaspike/core/impl/src/test/java/org/apache/deltaspike/test/core/impl/future/FutureableTest.java#L45]
> (same works for LockedTest)
> ** *The above trick is not a fix though!* Merely a workaround allowing Weld
> to enable the interceptor within test archive
> ** I think any user aiming to use these features with Weld 1.x would need to
> use this workaround in his/her deployments which is ugly
> Notes:
> * {{@Priority}} cannot be used here (for CDI 1.0)
> * GlobalInterceptorExtension won't help either as it is working since CDI 1.1+
> * This is not a problem for embedded container (e.g. running via {{-PWeld1}})
> ** This is probably because of different structure of embedded deployments
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
