[jira] [Commented] (DELTASPIKE-591) Add a ProjectStage aware resource Servlet

2014-05-15 Thread Romain Manni-Bucau (JIRA)

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13997565#comment-13997565
 ] 

Romain Manni-Bucau commented on DELTASPIKE-591:
---

Yep + we can surely activate it by default with a ServletContainerInitializer 
(deactivable with an init param in the context) since it will be chrooted in 
a subcontext.

 Add a ProjectStage aware resource Servlet
 -

 Key: DELTASPIKE-591
 URL: https://issues.apache.org/jira/browse/DELTASPIKE-591
 Project: DeltaSpike
  Issue Type: New Feature
  Components: Servlet-Module
Reporter: Daniel Sachse
Assignee: Christian Kaltepoth
 Attachments: DELTASPIKE-591.patch






--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (DELTASPIKE-591) Add a ProjectStage aware resource Servlet

2014-05-15 Thread Thomas Andraschko (JIRA)

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13997522#comment-13997522
 ] 

Thomas Andraschko commented on DELTASPIKE-591:
--

+1 Romain. So the servlet would just listen to a static url pattern instead of 
filtering all requests.

 Add a ProjectStage aware resource Servlet
 -

 Key: DELTASPIKE-591
 URL: https://issues.apache.org/jira/browse/DELTASPIKE-591
 Project: DeltaSpike
  Issue Type: New Feature
  Components: Servlet-Module
Reporter: Daniel Sachse
Assignee: Christian Kaltepoth
 Attachments: DELTASPIKE-591.patch






--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (DELTASPIKE-591) Add a ProjectStage aware resource Servlet

2014-05-13 Thread Daniel Sachse (JIRA)

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13996286#comment-13996286
 ] 

Daniel Sachse commented on DELTASPIKE-591:
--

The benefit to us would be, that given the current ProjectStage is Production 
and you request a file e.g. /configuration.js, the filter would try to find a 
file /Production/configuration.js . If the ProjectStage changes to Development 
then the filter would try to find /Development/configuration.js

This would be an easy way for us to deliver different files depending on the 
environment. It basically is a mapping of the ProjectStage aware configuration 
into the context of file resources.

 Add a ProjectStage aware resource Servlet
 -

 Key: DELTASPIKE-591
 URL: https://issues.apache.org/jira/browse/DELTASPIKE-591
 Project: DeltaSpike
  Issue Type: New Feature
  Components: Servlet-Module
Reporter: Daniel Sachse
 Attachments: DELTASPIKE-591.patch






--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (DELTASPIKE-591) Add a ProjectStage aware resource Servlet

2014-05-13 Thread Gerhard Petracek (JIRA)

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13996300#comment-13996300
 ] 

Gerhard Petracek commented on DELTASPIKE-591:
-

@thomas: +1 esp. since resource-paths are quite different in projects

 Add a ProjectStage aware resource Servlet
 -

 Key: DELTASPIKE-591
 URL: https://issues.apache.org/jira/browse/DELTASPIKE-591
 Project: DeltaSpike
  Issue Type: New Feature
  Components: Servlet-Module
Reporter: Daniel Sachse
Assignee: Christian Kaltepoth
 Attachments: DELTASPIKE-591.patch






--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (DELTASPIKE-591) Add a ProjectStage aware resource Servlet

2014-05-13 Thread Romain Manni-Bucau (JIRA)

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13996302#comment-13996302
 ] 

Romain Manni-Bucau commented on DELTASPIKE-591:
---

Hi

I'd go for a servlet and not a filter to be able to intercept it easily.

I'd get the project stage in init() and not by request to be more deterministic 
regarding the whole app (we can think to allow overriding by url but then 
project stage wouldn't make much sense)


 Add a ProjectStage aware resource Servlet
 -

 Key: DELTASPIKE-591
 URL: https://issues.apache.org/jira/browse/DELTASPIKE-591
 Project: DeltaSpike
  Issue Type: New Feature
  Components: Servlet-Module
Reporter: Daniel Sachse
Assignee: Christian Kaltepoth
 Attachments: DELTASPIKE-591.patch






--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (DELTASPIKE-591) Add a ProjectStage aware resource Servlet

2014-05-13 Thread Gerhard Petracek (JIRA)

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13996294#comment-13996294
 ] 

Gerhard Petracek commented on DELTASPIKE-591:
-

ok - then please adjust the test a bit (the mapping with '/*' is a bit 
confusing).
such use-case based tests should show the intention clearly.

 Add a ProjectStage aware resource Servlet
 -

 Key: DELTASPIKE-591
 URL: https://issues.apache.org/jira/browse/DELTASPIKE-591
 Project: DeltaSpike
  Issue Type: New Feature
  Components: Servlet-Module
Reporter: Daniel Sachse
 Attachments: DELTASPIKE-591.patch






--
This message was sent by Atlassian JIRA
(v6.2#6252)