[jira] [Commented] (DELTASPIKE-850) Add Weld 3 profile
[ https://issues.apache.org/jira/browse/DELTASPIKE-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14482792#comment-14482792 ] ASF GitHub Bot commented on DELTASPIKE-850: --- Github user rsmeral closed the pull request at: https://github.com/apache/deltaspike/pull/21 Add Weld 3 profile -- Key: DELTASPIKE-850 URL: https://issues.apache.org/jira/browse/DELTASPIKE-850 Project: DeltaSpike Issue Type: Task Components: Build Reporter: Ron Smeral Assignee: Rafael Benevides Priority: Trivial Weld 3 is now split into several modules and the weld-core module is renamed to weld-core-impl, so the Weld profile no longer works for Weld 3. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-850) Add Weld 3 profile
[ https://issues.apache.org/jira/browse/DELTASPIKE-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14388428#comment-14388428 ] Ron Smeral commented on DELTASPIKE-850: --- There is this Weld JIRA: https://issues.jboss.org/browse/WELD-1892 It's not clear yet, when this will be fixed. So, in the meantime, I suppose there are these options: a) apply my PR which fixes DeltaSpike testing on Weld SE 3.x (at least until WELD-1892 gets fixed) b) reject the PR and keep DS testing on Weld SE 3.x broken c) (find other solution) Add Weld 3 profile -- Key: DELTASPIKE-850 URL: https://issues.apache.org/jira/browse/DELTASPIKE-850 Project: DeltaSpike Issue Type: Task Components: Build Reporter: Ron Smeral Assignee: Rafael Benevides Priority: Trivial Weld 3 is now split into several modules and the weld-core module is renamed to weld-core-impl, so the Weld profile no longer works for Weld 3. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-850) Add Weld 3 profile
[ https://issues.apache.org/jira/browse/DELTASPIKE-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14384617#comment-14384617 ] Rafael Benevides commented on DELTASPIKE-850: - Hi [~rsmeral] Do you have a reference Jira for Weld ? I'd like to know what version of Weld will have this fix? Btw, regarding the PR. Will you closed it? Thanks Add Weld 3 profile -- Key: DELTASPIKE-850 URL: https://issues.apache.org/jira/browse/DELTASPIKE-850 Project: DeltaSpike Issue Type: Task Components: Build Reporter: Ron Smeral Assignee: Rafael Benevides Priority: Trivial Weld 3 is now split into several modules and the weld-core module is renamed to weld-core-impl, so the Weld profile no longer works for Weld 3. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-850) Add Weld 3 profile
[ https://issues.apache.org/jira/browse/DELTASPIKE-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14352680#comment-14352680 ] Jozef Hartinger commented on DELTASPIKE-850: The lack of weld-core artifact is an oversight and we'll be adding it back. Add Weld 3 profile -- Key: DELTASPIKE-850 URL: https://issues.apache.org/jira/browse/DELTASPIKE-850 Project: DeltaSpike Issue Type: Task Components: Build Reporter: Ron Smeral Priority: Trivial Weld 3 is now split into several modules and the weld-core module is renamed to weld-core-impl, so the Weld profile no longer works for Weld 3. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-850) Add Weld 3 profile
[ https://issues.apache.org/jira/browse/DELTASPIKE-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14352737#comment-14352737 ] Ron Smeral commented on DELTASPIKE-850: --- [~jharting] OK, good to know. However, it is correct to just depend on weld-core-bom and let it pull in whatever is correct for any given version, right? Also, the weld-core-bom is in fact something like a depchain and not a BOM (given how the terms are commonly used, AFAIK), since the weld-core-bom declares dependencies instead of dependencyManagement. That has the benefit that I can depend on it and have all required dependencies pulled in even _regardless of their name_. However, if I needed just some of them, I need to use the ugliness that is exclusions instead of managing weld-core-bom and depending on individual artifacts. Add Weld 3 profile -- Key: DELTASPIKE-850 URL: https://issues.apache.org/jira/browse/DELTASPIKE-850 Project: DeltaSpike Issue Type: Task Components: Build Reporter: Ron Smeral Priority: Trivial Weld 3 is now split into several modules and the weld-core module is renamed to weld-core-impl, so the Weld profile no longer works for Weld 3. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-850) Add Weld 3 profile
[
https://issues.apache.org/jira/browse/DELTASPIKE-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14352750#comment-14352750
]
Jozef Hartinger commented on DELTASPIKE-850:
{quote}Also, the weld-core-bom is in fact something like a depchain and not a
BOM (given how the terms are commonly used, AFAIK), since the weld-core-bom
declares dependencies instead of dependencyManagement.{quote}
Ah, yes, that should be fixed also.
Add Weld 3 profile
--
Key: DELTASPIKE-850
URL: https://issues.apache.org/jira/browse/DELTASPIKE-850
Project: DeltaSpike
Issue Type: Task
Components: Build
Reporter: Ron Smeral
Priority: Trivial
Weld 3 is now split into several modules and the weld-core module is renamed
to weld-core-impl, so the Weld profile no longer works for Weld 3.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-850) Add Weld 3 profile
[ https://issues.apache.org/jira/browse/DELTASPIKE-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14350325#comment-14350325 ] Ron Smeral commented on DELTASPIKE-850: --- https://github.com/apache/deltaspike/pull/21/ Add Weld 3 profile -- Key: DELTASPIKE-850 URL: https://issues.apache.org/jira/browse/DELTASPIKE-850 Project: DeltaSpike Issue Type: Task Components: Build Reporter: Ron Smeral Priority: Trivial Weld 3 is now split into several modules and the weld-core module is renamed to weld-core-impl, so the Weld profile no longer works for Weld 3. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
