[jira] [Commented] (DELTASPIKE-894) Trim for CriteriaSupport API

2015-06-08 Thread Daniel Cunha (soro) (JIRA) 

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577328#comment-14577328
 ] 

Daniel Cunha (soro) commented on DELTASPIKE-894:


Thank you, [~thomashug] and [~rafabene].

I'll fix it and apply later.

> Trim for CriteriaSupport API
> 
>
> Key: DELTASPIKE-894
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-894
> Project: DeltaSpike
>  Issue Type: New Feature
>  Components: Data-Module
>Reporter: Daniel Cunha (soro)
>Assignee: Thomas Hug
>Priority: Minor
> Attachments: DELTASPIKE-894.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DELTASPIKE-894) Trim for CriteriaSupport API

2015-06-08 Thread Thomas Hug (JIRA) 

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577290#comment-14577290
 ] 

Thomas Hug commented on DELTASPIKE-894:
---

Looks good on the API side. For the impl I'd use a single Trim and always trim 
with a Trimspec - use the default BOTH if not specified by the user.

> Trim for CriteriaSupport API
> 
>
> Key: DELTASPIKE-894
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-894
> Project: DeltaSpike
>  Issue Type: New Feature
>  Components: Data-Module
>Reporter: Daniel Cunha (soro)
>Assignee: Thomas Hug
>Priority: Minor
> Attachments: DELTASPIKE-894.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DELTASPIKE-894) Trim for CriteriaSupport API

2015-05-13 Thread Rafael Benevides (JIRA) 

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14542334#comment-14542334
 ] 

Rafael Benevides commented on DELTASPIKE-894:
-

It looks ok but I'd like a second opinion here on the API.

> Trim for CriteriaSupport API
> 
>
> Key: DELTASPIKE-894
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-894
> Project: DeltaSpike
>  Issue Type: New Feature
>  Components: Data-Module
>Reporter: Daniel Cunha (soro)
>Assignee: Thomas Hug
>Priority: Minor
> Attachments: DELTASPIKE-894.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)