[jira] [Commented] (DELTASPIKE-905) Missing OSGi headers in Proxy modules
[
https://issues.apache.org/jira/browse/DELTASPIKE-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387004#comment-15387004
]
ASF GitHub Bot commented on DELTASPIKE-905:
---
Github user asfgit closed the pull request at:
https://github.com/apache/deltaspike/pull/38
> Missing OSGi headers in Proxy modules
> -
>
> Key: DELTASPIKE-905
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-905
> Project: DeltaSpike
> Issue Type: Bug
> Components: PartialBean
>Affects Versions: 1.4.0
>Reporter: Harald Wellmann
>Assignee: Rafael Benevides
> Fix For: 1.4.1
>
>
> {{deltaspike-partial-bean-module-impl}} imports package
> {{org.apache.deltaspike.proxy.api}}, but the new proxy modules are missing
> OSGi manifest headers.
> This breaks Partial Beans and Data modules for OSGi users.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-905) Missing OSGi headers in Proxy modules
[
https://issues.apache.org/jira/browse/DELTASPIKE-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14573247#comment-14573247
]
ASF GitHub Bot commented on DELTASPIKE-905:
---
GitHub user hwellmann opened a pull request:
https://github.com/apache/deltaspike/pull/38
DELTASPIKE-905 refactored ProxyClassGeneratorLookup to inner class
Reworked Rafael's patch which did not work since an abstract class cannot
be instantiated by SCR. Now using a concrete inner class.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hwellmann/deltaspike DELTASPIKE-905
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/deltaspike/pull/38.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #38
commit aa9175842bc44e402a534c68f151ad4686ae7937
Author: Harald Wellmann harald.wellm...@gmx.de
Date: 2015-06-04T17:47:15Z
DELTASPIKE-905 refactored ProxyClassGeneratorLookup to inner class
Missing OSGi headers in Proxy modules
-
Key: DELTASPIKE-905
URL: https://issues.apache.org/jira/browse/DELTASPIKE-905
Project: DeltaSpike
Issue Type: Bug
Components: PartialBean
Affects Versions: 1.4.0
Reporter: Harald Wellmann
Assignee: Rafael Benevides
Fix For: 1.4.1
{{deltaspike-partial-bean-module-impl}} imports package
{{org.apache.deltaspike.proxy.api}}, but the new proxy modules are missing
OSGi manifest headers.
This breaks Partial Beans and Data modules for OSGi users.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-905) Missing OSGi headers in Proxy modules
[
https://issues.apache.org/jira/browse/DELTASPIKE-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14573268#comment-14573268
]
ASF GitHub Bot commented on DELTASPIKE-905:
---
Github user rafabene closed the pull request at:
https://github.com/apache/deltaspike/pull/36
Missing OSGi headers in Proxy modules
-
Key: DELTASPIKE-905
URL: https://issues.apache.org/jira/browse/DELTASPIKE-905
Project: DeltaSpike
Issue Type: Bug
Components: PartialBean
Affects Versions: 1.4.0
Reporter: Harald Wellmann
Assignee: Rafael Benevides
Fix For: 1.4.1
{{deltaspike-partial-bean-module-impl}} imports package
{{org.apache.deltaspike.proxy.api}}, but the new proxy modules are missing
OSGi manifest headers.
This breaks Partial Beans and Data modules for OSGi users.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-905) Missing OSGi headers in Proxy modules
[
https://issues.apache.org/jira/browse/DELTASPIKE-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14573181#comment-14573181
]
Rafael Benevides commented on DELTASPIKE-905:
-
Thanks
Missing OSGi headers in Proxy modules
-
Key: DELTASPIKE-905
URL: https://issues.apache.org/jira/browse/DELTASPIKE-905
Project: DeltaSpike
Issue Type: Bug
Components: PartialBean
Affects Versions: 1.4.0
Reporter: Harald Wellmann
Assignee: Rafael Benevides
Fix For: 1.4.1
{{deltaspike-partial-bean-module-impl}} imports package
{{org.apache.deltaspike.proxy.api}}, but the new proxy modules are missing
OSGi manifest headers.
This breaks Partial Beans and Data modules for OSGi users.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-905) Missing OSGi headers in Proxy modules
[
https://issues.apache.org/jira/browse/DELTASPIKE-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14573168#comment-14573168
]
Harald Wellmann commented on DELTASPIKE-905:
Sorry, test failed. I'll take a closer look and try to fix it in another PR.
Missing OSGi headers in Proxy modules
-
Key: DELTASPIKE-905
URL: https://issues.apache.org/jira/browse/DELTASPIKE-905
Project: DeltaSpike
Issue Type: Bug
Components: PartialBean
Affects Versions: 1.4.0
Reporter: Harald Wellmann
Assignee: Rafael Benevides
Fix For: 1.4.1
{{deltaspike-partial-bean-module-impl}} imports package
{{org.apache.deltaspike.proxy.api}}, but the new proxy modules are missing
OSGi manifest headers.
This breaks Partial Beans and Data modules for OSGi users.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-905) Missing OSGi headers in Proxy modules
[
https://issues.apache.org/jira/browse/DELTASPIKE-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14573413#comment-14573413
]
Harald Wellmann commented on DELTASPIKE-905:
Looks good now - retested with master. Thanks!
Missing OSGi headers in Proxy modules
-
Key: DELTASPIKE-905
URL: https://issues.apache.org/jira/browse/DELTASPIKE-905
Project: DeltaSpike
Issue Type: Bug
Components: PartialBean
Affects Versions: 1.4.0
Reporter: Harald Wellmann
Assignee: Rafael Benevides
Fix For: 1.4.1
{{deltaspike-partial-bean-module-impl}} imports package
{{org.apache.deltaspike.proxy.api}}, but the new proxy modules are missing
OSGi manifest headers.
This breaks Partial Beans and Data modules for OSGi users.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-905) Missing OSGi headers in Proxy modules
[
https://issues.apache.org/jira/browse/DELTASPIKE-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14573398#comment-14573398
]
Rafael Benevides commented on DELTASPIKE-905:
-
That's true. Thanks.
I merged the right one.
Missing OSGi headers in Proxy modules
-
Key: DELTASPIKE-905
URL: https://issues.apache.org/jira/browse/DELTASPIKE-905
Project: DeltaSpike
Issue Type: Bug
Components: PartialBean
Affects Versions: 1.4.0
Reporter: Harald Wellmann
Assignee: Rafael Benevides
Fix For: 1.4.1
{{deltaspike-partial-bean-module-impl}} imports package
{{org.apache.deltaspike.proxy.api}}, but the new proxy modules are missing
OSGi manifest headers.
This breaks Partial Beans and Data modules for OSGi users.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-905) Missing OSGi headers in Proxy modules
[
https://issues.apache.org/jira/browse/DELTASPIKE-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14569596#comment-14569596
]
ASF GitHub Bot commented on DELTASPIKE-905:
---
GitHub user rafabene opened a pull request:
https://github.com/apache/deltaspike/pull/36
DELTASPIKE-905 - move the code from ProxyClassGeneratorLookup to Delt…
…aSpikeProxyFactory (1:1)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rafabene/deltaspike DELTASPIKE-905
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/deltaspike/pull/36.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #36
commit 9805337380a7cc621c35d5ccc053cf025e9a3c09
Author: Rafael Benevides rafab...@gmail.com
Date: 2015-06-02T19:15:06Z
DELTASPIKE-905 - move the code from ProxyClassGeneratorLookup to
DeltaSpikeProxyFactory (1:1)
Missing OSGi headers in Proxy modules
-
Key: DELTASPIKE-905
URL: https://issues.apache.org/jira/browse/DELTASPIKE-905
Project: DeltaSpike
Issue Type: Bug
Components: PartialBean
Affects Versions: 1.4.0
Reporter: Harald Wellmann
Assignee: Rafael Benevides
Fix For: 1.4.1
{{deltaspike-partial-bean-module-impl}} imports package
{{org.apache.deltaspike.proxy.api}}, but the new proxy modules are missing
OSGi manifest headers.
This breaks Partial Beans and Data modules for OSGi users.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-905) Missing OSGi headers in Proxy modules
[
https://issues.apache.org/jira/browse/DELTASPIKE-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14569598#comment-14569598
]
Rafael Benevides commented on DELTASPIKE-905:
-
[~hwellmann]
Can you test the following changes, please
https://github.com/apache/deltaspike/pull/36 ?
Thanks
Missing OSGi headers in Proxy modules
-
Key: DELTASPIKE-905
URL: https://issues.apache.org/jira/browse/DELTASPIKE-905
Project: DeltaSpike
Issue Type: Bug
Components: PartialBean
Affects Versions: 1.4.0
Reporter: Harald Wellmann
Assignee: Rafael Benevides
Fix For: 1.4.1
{{deltaspike-partial-bean-module-impl}} imports package
{{org.apache.deltaspike.proxy.api}}, but the new proxy modules are missing
OSGi manifest headers.
This breaks Partial Beans and Data modules for OSGi users.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-905) Missing OSGi headers in Proxy modules
[
https://issues.apache.org/jira/browse/DELTASPIKE-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14569701#comment-14569701
]
Gerhard Petracek commented on DELTASPIKE-905:
-
@harald:
in ds we keep the api as clean as possible and therefore it should only contain
parts which are important to users.
Missing OSGi headers in Proxy modules
-
Key: DELTASPIKE-905
URL: https://issues.apache.org/jira/browse/DELTASPIKE-905
Project: DeltaSpike
Issue Type: Bug
Components: PartialBean
Affects Versions: 1.4.0
Reporter: Harald Wellmann
Assignee: Rafael Benevides
Fix For: 1.4.1
{{deltaspike-partial-bean-module-impl}} imports package
{{org.apache.deltaspike.proxy.api}}, but the new proxy modules are missing
OSGi manifest headers.
This breaks Partial Beans and Data modules for OSGi users.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-905) Missing OSGi headers in Proxy modules
[
https://issues.apache.org/jira/browse/DELTASPIKE-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14569653#comment-14569653
]
Harald Wellmann commented on DELTASPIKE-905:
If you delete {{ProxyClassGeneratorLookup.java}}, you'll also have to adapt
{{deltaspike/modules/proxy/api/src/main/resources/OSGI-INF/ProxyClassGeneratorLookup.xml}}
which I don't see in your PR.
By the way, what's the motivation for inlining this class? It shouldn't make
much of a difference one way or the other, I'm just curious about the point
you're trying to improve which seems to escape me.
Missing OSGi headers in Proxy modules
-
Key: DELTASPIKE-905
URL: https://issues.apache.org/jira/browse/DELTASPIKE-905
Project: DeltaSpike
Issue Type: Bug
Components: PartialBean
Affects Versions: 1.4.0
Reporter: Harald Wellmann
Assignee: Rafael Benevides
Fix For: 1.4.1
{{deltaspike-partial-bean-module-impl}} imports package
{{org.apache.deltaspike.proxy.api}}, but the new proxy modules are missing
OSGi manifest headers.
This breaks Partial Beans and Data modules for OSGi users.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-905) Missing OSGi headers in Proxy modules
[
https://issues.apache.org/jira/browse/DELTASPIKE-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14568007#comment-14568007
]
ASF GitHub Bot commented on DELTASPIKE-905:
---
GitHub user hwellmann opened a pull request:
https://github.com/apache/deltaspike/pull/35
DELTASPIKE-905 OSGi support for Proxy Module
Added OSGi manifest headers and introduced a local adapter between
ServiceUtils and OSGi Declarative Services.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hwellmann/deltaspike DELTASPIKE-905
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/deltaspike/pull/35.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #35
commit 54d37558cab1ad731b68fbee7152436829a9f32c
Author: Harald Wellmann harald.wellm...@gmx.de
Date: 2015-06-01T21:04:54Z
DELTASPIKE-905 OSGi support for Proxy Module
Missing OSGi headers in Proxy modules
-
Key: DELTASPIKE-905
URL: https://issues.apache.org/jira/browse/DELTASPIKE-905
Project: DeltaSpike
Issue Type: Bug
Components: PartialBean
Affects Versions: 1.4.0
Reporter: Harald Wellmann
Fix For: 1.4.1
{{deltaspike-partial-bean-module-impl}} imports package
{{org.apache.deltaspike.proxy.api}}, but the new proxy modules are missing
OSGi manifest headers.
This breaks Partial Beans and Data modules for OSGi users.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-905) Missing OSGi headers in Proxy modules
[
https://issues.apache.org/jira/browse/DELTASPIKE-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14568165#comment-14568165
]
Rafael Benevides commented on DELTASPIKE-905:
-
PR merged
Missing OSGi headers in Proxy modules
-
Key: DELTASPIKE-905
URL: https://issues.apache.org/jira/browse/DELTASPIKE-905
Project: DeltaSpike
Issue Type: Bug
Components: PartialBean
Affects Versions: 1.4.0
Reporter: Harald Wellmann
Fix For: 1.4.1
{{deltaspike-partial-bean-module-impl}} imports package
{{org.apache.deltaspike.proxy.api}}, but the new proxy modules are missing
OSGi manifest headers.
This breaks Partial Beans and Data modules for OSGi users.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-905) Missing OSGi headers in Proxy modules
[
https://issues.apache.org/jira/browse/DELTASPIKE-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14555741#comment-14555741
]
Gerhard Petracek commented on DELTASPIKE-905:
-
i'm not sure what you mean, because we are using
ServiceUtils#loadServiceImplementations quite often and not only for
ProxyClassGenerator.
- if we have an issue here, there is why more to check than just the
proxy-module.
Missing OSGi headers in Proxy modules
-
Key: DELTASPIKE-905
URL: https://issues.apache.org/jira/browse/DELTASPIKE-905
Project: DeltaSpike
Issue Type: Bug
Components: PartialBean
Affects Versions: 1.4.0
Reporter: Harald Wellmann
Fix For: 1.4.1
{{deltaspike-partial-bean-module-impl}} imports package
{{org.apache.deltaspike.proxy.api}}, but the new proxy modules are missing
OSGi manifest headers.
This breaks Partial Beans and Data modules for OSGi users.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-905) Missing OSGi headers in Proxy modules
[
https://issues.apache.org/jira/browse/DELTASPIKE-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14556300#comment-14556300
]
Harald Wellmann commented on DELTASPIKE-905:
{{java.util.ServiceLoader}} does not really work well in OSGi in general. See
http://aries.apache.org/modules/spi-fly.html.
I know it's a more general issue, but so far I only had to fix it in this one
place, presumably because in all other use cases I've tested in the context of
DeltaSpike data, the TCCL just happens to be suitable.
The question is how much OSGi-awareness (in terms of compile-time or run-time
dependencies) is acceptable for DeltaSpike - this will determine the approach
to a more generic solution.
Missing OSGi headers in Proxy modules
-
Key: DELTASPIKE-905
URL: https://issues.apache.org/jira/browse/DELTASPIKE-905
Project: DeltaSpike
Issue Type: Bug
Components: PartialBean
Affects Versions: 1.4.0
Reporter: Harald Wellmann
Fix For: 1.4.1
{{deltaspike-partial-bean-module-impl}} imports package
{{org.apache.deltaspike.proxy.api}}, but the new proxy modules are missing
OSGi manifest headers.
This breaks Partial Beans and Data modules for OSGi users.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-905) Missing OSGi headers in Proxy modules
[
https://issues.apache.org/jira/browse/DELTASPIKE-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14556656#comment-14556656
]
Gerhard Petracek commented on DELTASPIKE-905:
-
cdi itself is based on that concept (with
javax.enterprise.inject.spi.Extension) so it sounds strange that it works for
the (cdi-)container, but not for ds itself.
imo the only difference should be that owb as well as weld implement/ed it
manually to support jdk5 back then.
Missing OSGi headers in Proxy modules
-
Key: DELTASPIKE-905
URL: https://issues.apache.org/jira/browse/DELTASPIKE-905
Project: DeltaSpike
Issue Type: Bug
Components: PartialBean
Affects Versions: 1.4.0
Reporter: Harald Wellmann
Fix For: 1.4.1
{{deltaspike-partial-bean-module-impl}} imports package
{{org.apache.deltaspike.proxy.api}}, but the new proxy modules are missing
OSGi manifest headers.
This breaks Partial Beans and Data modules for OSGi users.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-905) Missing OSGi headers in Proxy modules
[
https://issues.apache.org/jira/browse/DELTASPIKE-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14550995#comment-14550995
]
Harald Wellmann commented on DELTASPIKE-905:
I'll work on a patch. First tests show that just adding manifest headers won't
be enough, there has to be an OSGi-compatible way of looking up the
{{ProxyClassGenerator}} service.
Missing OSGi headers in Proxy modules
-
Key: DELTASPIKE-905
URL: https://issues.apache.org/jira/browse/DELTASPIKE-905
Project: DeltaSpike
Issue Type: Bug
Components: PartialBean
Affects Versions: 1.4.0
Reporter: Harald Wellmann
Fix For: 1.4.1
{{deltaspike-partial-bean-module-impl}} imports package
{{org.apache.deltaspike.proxy.api}}, but the new proxy modules are missing
OSGi manifest headers.
This breaks Partial Beans and Data modules for OSGi users.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
