[jira] [Updated] (DELTASPIKE-894) Trim for CriteriaSupport API
[ https://issues.apache.org/jira/browse/DELTASPIKE-894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gerhard Petracek updated DELTASPIKE-894: Fix Version/s: 1.4.1 Trim for CriteriaSupport API Key: DELTASPIKE-894 URL: https://issues.apache.org/jira/browse/DELTASPIKE-894 Project: DeltaSpike Issue Type: New Feature Components: Data-Module Reporter: Daniel Cunha (soro) Assignee: Daniel Cunha (soro) Priority: Minor Fix For: 1.4.1 Attachments: DELTASPIKE-894.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (DELTASPIKE-894) Trim for CriteriaSupport API
[ https://issues.apache.org/jira/browse/DELTASPIKE-894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Cunha (soro) reassigned DELTASPIKE-894: -- Assignee: Daniel Cunha (soro) (was: Thomas Hug) Trim for CriteriaSupport API Key: DELTASPIKE-894 URL: https://issues.apache.org/jira/browse/DELTASPIKE-894 Project: DeltaSpike Issue Type: New Feature Components: Data-Module Reporter: Daniel Cunha (soro) Assignee: Daniel Cunha (soro) Priority: Minor Attachments: DELTASPIKE-894.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (DELTASPIKE-894) Trim for CriteriaSupport API
[ https://issues.apache.org/jira/browse/DELTASPIKE-894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Cunha (soro) resolved DELTASPIKE-894. Resolution: Fixed Trim for CriteriaSupport API Key: DELTASPIKE-894 URL: https://issues.apache.org/jira/browse/DELTASPIKE-894 Project: DeltaSpike Issue Type: New Feature Components: Data-Module Reporter: Daniel Cunha (soro) Assignee: Daniel Cunha (soro) Priority: Minor Attachments: DELTASPIKE-894.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-894) Trim for CriteriaSupport API
[ https://issues.apache.org/jira/browse/DELTASPIKE-894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14577290#comment-14577290 ] Thomas Hug commented on DELTASPIKE-894: --- Looks good on the API side. For the impl I'd use a single Trim and always trim with a Trimspec - use the default BOTH if not specified by the user. Trim for CriteriaSupport API Key: DELTASPIKE-894 URL: https://issues.apache.org/jira/browse/DELTASPIKE-894 Project: DeltaSpike Issue Type: New Feature Components: Data-Module Reporter: Daniel Cunha (soro) Assignee: Thomas Hug Priority: Minor Attachments: DELTASPIKE-894.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DELTASPIKE-894) Trim for CriteriaSupport API
[ https://issues.apache.org/jira/browse/DELTASPIKE-894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14577328#comment-14577328 ] Daniel Cunha (soro) commented on DELTASPIKE-894: Thank you, [~thomashug] and [~rafabene]. I'll fix it and apply later. Trim for CriteriaSupport API Key: DELTASPIKE-894 URL: https://issues.apache.org/jira/browse/DELTASPIKE-894 Project: DeltaSpike Issue Type: New Feature Components: Data-Module Reporter: Daniel Cunha (soro) Assignee: Thomas Hug Priority: Minor Attachments: DELTASPIKE-894.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: CriteriaSupport API
Romain, Nice. I get it, I'll try do it. Thomas, Rafael help me on last week and we can fix some issues pending. Anyway, we have 2 patches that needs to a second opinion. (DELTASPIKE-894 and DELTASPIKE-701). I started a fix for DELTASPIKE-910, but I had a doubt ( http://mail-archives.apache.org/mod_mbox/openjpa-dev/201505.mbox/%3CCAHLHu44T8%3DtYGAmwKfv5JuYNbEs90wfxMzUC%2BPo5BSrA6gwZDQ%40mail.gmail.com%3E), anyway I have a fix using EntityUtils, but I don't know if is enough ( https://github.com/danielsoro/deltaspike/commit/4de2fd06f3641f864b7920b43e9d09d0125e5dee ). On Tue, May 19, 2015 at 7:30 PM, Romain Manni-Bucau rmannibu...@gmail.com wrote: think we can do it while it doesnt break the project. Romain Manni-Bucau @rmannibucau https://twitter.com/rmannibucau | Blog http://rmannibucau.wordpress.com | Github https://github.com/rmannibucau | LinkedIn https://www.linkedin.com/in/rmannibucau | Tomitriber http://www.tomitribe.com 2015-05-20 0:25 GMT+02:00 Daniel Cunha daniels...@gmail.com: HI Thomas, I'm very happy to announce that we don't have problem with https://issues.apache.org/jira/browse/DELTASPIKE-901, but I attached a patch with a new test in data-module. Romain have a observation for data-module: rmannibucau soro, do you care testing against 1.3.0? rmannibucau but it really looks like my app rmannibucau which openjpa version? rmannibucau 2.4.0? soro rmannibucau, tomee 1.7.0 rmannibucau can be sthg fixed in openjpa 2.4 then soro Do you want that I test in DS 1.3.0? soro I can do it. NP. :) rmannibucau well my envrt was tomee 7 (openjpa 2.4) + ds 1.3.0 rmannibucau but i suspect more openjpa to have validated the query rmannibucau 1.7.0 uses a custom version rmannibucau pre-2.4 soro hmm soro rmannibucau, anyway, I'll push this patch. Sounds good? rmannibucau yep rmannibucau we should have the same kind of testing that for containers but for jpa only in ds-data rmannibucau even if embedded Romain, Do we need to open a new issue to your suggestion to put test for jpa only in ds-data? For this change, I don't know if necessary discuss about or simply doing it. :) On Fri, May 15, 2015 at 4:28 AM, Thomas Hug thomas@gmail.com wrote: Wow, thnx for churning out those fixes! :) (and also to Rafael for reviewing!) Will take some time for me to get to it but will try to do this asap. Cheers, Thomas On Thu, May 14, 2015 at 10:17 PM, Daniel Cunha daniels...@gmail.com wrote: Hi Thomas, I've working in some issues and I would like to send my result on work in DS. I have attached patch for: https://issues.apache.org/jira/browse/DELTASPIKE-603 https://issues.apache.org/jira/browse/DELTASPIKE-894 https://issues.apache.org/jira/browse/DELTASPIKE-701 https://issues.apache.org/jira/browse/DELTASPIKE-902 I had an help of the Rafael Benevides (rbenevides), he reviewed my patchs in (DELTASPIKE-894, DELTASPIKE-701). Let me know if the patchs is good or need improvement. I would like to help more :) I'll start work on DELTASPIKE-901. See you. Thank you. On Wed, May 13, 2015 at 1:10 PM, Daniel Cunha daniels...@gmail.com wrote: Hi Thomas, I'm looking to DELTASPIKE-701 and DELTASPIKE-603 I'm preparing to start with DELTASPIKE-603. Do you have something for it or did something? I would like to fix it, if you don't have time to do. :) On Wed, May 13, 2015 at 1:00 PM, Thomas Hug thomas@gmail.com wrote: Hi Daniel I definitely don't have as much time for DS as I'd like to have (right now close to none ;) so any help is welcome :). Let me know if you have any specific issue in mind and we can check what's needed. Cheers, Thomas On Wed, May 13, 2015 at 12:13 AM, Daniel Cunha daniels...@gmail.com wrote: Hi Thomas, I can to see that we have some issues opened and not fixed if you want I can try help you with this tasks. Let me know if you need help to fix another issues in data-module. :) On Mon, May 11, 2015 at 4:55 AM, Thomas Hug thomas@gmail.com wrote: Hi Daniel Thanks for the patch! I should have some bandwidth the next week to do some DS coding and take care about it. There's indeed room for improvement for the criteria API. I was not really sure how useful people find it and started with a simplified version, but if it gets more adoption it's definitely worth filling the gaps. Feedback and PRs always welcome :) Cheers, Thomas On Fri, May 8, 2015 at 10:51 PM, Daniel Cunha daniels...@gmail.com wrote: Hi folks, I started to change something in
Re: CriteriaSupport API
HI Thomas, I'm very happy to announce that we don't have problem with https://issues.apache.org/jira/browse/DELTASPIKE-901, but I attached a patch with a new test in data-module. Romain have a observation for data-module: rmannibucau soro, do you care testing against 1.3.0? rmannibucau but it really looks like my app rmannibucau which openjpa version? rmannibucau 2.4.0? soro rmannibucau, tomee 1.7.0 rmannibucau can be sthg fixed in openjpa 2.4 then soro Do you want that I test in DS 1.3.0? soro I can do it. NP. :) rmannibucau well my envrt was tomee 7 (openjpa 2.4) + ds 1.3.0 rmannibucau but i suspect more openjpa to have validated the query rmannibucau 1.7.0 uses a custom version rmannibucau pre-2.4 soro hmm soro rmannibucau, anyway, I'll push this patch. Sounds good? rmannibucau yep rmannibucau we should have the same kind of testing that for containers but for jpa only in ds-data rmannibucau even if embedded Romain, Do we need to open a new issue to your suggestion to put test for jpa only in ds-data? For this change, I don't know if necessary discuss about or simply doing it. :) On Fri, May 15, 2015 at 4:28 AM, Thomas Hug thomas@gmail.com wrote: Wow, thnx for churning out those fixes! :) (and also to Rafael for reviewing!) Will take some time for me to get to it but will try to do this asap. Cheers, Thomas On Thu, May 14, 2015 at 10:17 PM, Daniel Cunha daniels...@gmail.com wrote: Hi Thomas, I've working in some issues and I would like to send my result on work in DS. I have attached patch for: https://issues.apache.org/jira/browse/DELTASPIKE-603 https://issues.apache.org/jira/browse/DELTASPIKE-894 https://issues.apache.org/jira/browse/DELTASPIKE-701 https://issues.apache.org/jira/browse/DELTASPIKE-902 I had an help of the Rafael Benevides (rbenevides), he reviewed my patchs in (DELTASPIKE-894, DELTASPIKE-701). Let me know if the patchs is good or need improvement. I would like to help more :) I'll start work on DELTASPIKE-901. See you. Thank you. On Wed, May 13, 2015 at 1:10 PM, Daniel Cunha daniels...@gmail.com wrote: Hi Thomas, I'm looking to DELTASPIKE-701 and DELTASPIKE-603 I'm preparing to start with DELTASPIKE-603. Do you have something for it or did something? I would like to fix it, if you don't have time to do. :) On Wed, May 13, 2015 at 1:00 PM, Thomas Hug thomas@gmail.com wrote: Hi Daniel I definitely don't have as much time for DS as I'd like to have (right now close to none ;) so any help is welcome :). Let me know if you have any specific issue in mind and we can check what's needed. Cheers, Thomas On Wed, May 13, 2015 at 12:13 AM, Daniel Cunha daniels...@gmail.com wrote: Hi Thomas, I can to see that we have some issues opened and not fixed if you want I can try help you with this tasks. Let me know if you need help to fix another issues in data-module. :) On Mon, May 11, 2015 at 4:55 AM, Thomas Hug thomas@gmail.com wrote: Hi Daniel Thanks for the patch! I should have some bandwidth the next week to do some DS coding and take care about it. There's indeed room for improvement for the criteria API. I was not really sure how useful people find it and started with a simplified version, but if it gets more adoption it's definitely worth filling the gaps. Feedback and PRs always welcome :) Cheers, Thomas On Fri, May 8, 2015 at 10:51 PM, Daniel Cunha daniels...@gmail.com wrote: Hi folks, I started to change something in data-module, I don't know if we have time to do it, but, let me know if DELTASPIKE-894 could be apply in next release. We don't support all methods. Do we want support for all methods? I can to see that some methods like 'isTrue', 'isFalse', etc.. of the Criteria not is supported by DS data-module. -- Best regard, Daniel Cunha (soro) -- Best regard, Daniel Cunha (soro) -- Best regard, Daniel Cunha (soro) -- Best regard, Daniel Cunha (soro) -- Best regard, Daniel Cunha (soro)
Re: CriteriaSupport API
think we can do it while it doesnt break the project. Romain Manni-Bucau @rmannibucau https://twitter.com/rmannibucau | Blog http://rmannibucau.wordpress.com | Github https://github.com/rmannibucau | LinkedIn https://www.linkedin.com/in/rmannibucau | Tomitriber http://www.tomitribe.com 2015-05-20 0:25 GMT+02:00 Daniel Cunha daniels...@gmail.com: HI Thomas, I'm very happy to announce that we don't have problem with https://issues.apache.org/jira/browse/DELTASPIKE-901, but I attached a patch with a new test in data-module. Romain have a observation for data-module: rmannibucau soro, do you care testing against 1.3.0? rmannibucau but it really looks like my app rmannibucau which openjpa version? rmannibucau 2.4.0? soro rmannibucau, tomee 1.7.0 rmannibucau can be sthg fixed in openjpa 2.4 then soro Do you want that I test in DS 1.3.0? soro I can do it. NP. :) rmannibucau well my envrt was tomee 7 (openjpa 2.4) + ds 1.3.0 rmannibucau but i suspect more openjpa to have validated the query rmannibucau 1.7.0 uses a custom version rmannibucau pre-2.4 soro hmm soro rmannibucau, anyway, I'll push this patch. Sounds good? rmannibucau yep rmannibucau we should have the same kind of testing that for containers but for jpa only in ds-data rmannibucau even if embedded Romain, Do we need to open a new issue to your suggestion to put test for jpa only in ds-data? For this change, I don't know if necessary discuss about or simply doing it. :) On Fri, May 15, 2015 at 4:28 AM, Thomas Hug thomas@gmail.com wrote: Wow, thnx for churning out those fixes! :) (and also to Rafael for reviewing!) Will take some time for me to get to it but will try to do this asap. Cheers, Thomas On Thu, May 14, 2015 at 10:17 PM, Daniel Cunha daniels...@gmail.com wrote: Hi Thomas, I've working in some issues and I would like to send my result on work in DS. I have attached patch for: https://issues.apache.org/jira/browse/DELTASPIKE-603 https://issues.apache.org/jira/browse/DELTASPIKE-894 https://issues.apache.org/jira/browse/DELTASPIKE-701 https://issues.apache.org/jira/browse/DELTASPIKE-902 I had an help of the Rafael Benevides (rbenevides), he reviewed my patchs in (DELTASPIKE-894, DELTASPIKE-701). Let me know if the patchs is good or need improvement. I would like to help more :) I'll start work on DELTASPIKE-901. See you. Thank you. On Wed, May 13, 2015 at 1:10 PM, Daniel Cunha daniels...@gmail.com wrote: Hi Thomas, I'm looking to DELTASPIKE-701 and DELTASPIKE-603 I'm preparing to start with DELTASPIKE-603. Do you have something for it or did something? I would like to fix it, if you don't have time to do. :) On Wed, May 13, 2015 at 1:00 PM, Thomas Hug thomas@gmail.com wrote: Hi Daniel I definitely don't have as much time for DS as I'd like to have (right now close to none ;) so any help is welcome :). Let me know if you have any specific issue in mind and we can check what's needed. Cheers, Thomas On Wed, May 13, 2015 at 12:13 AM, Daniel Cunha daniels...@gmail.com wrote: Hi Thomas, I can to see that we have some issues opened and not fixed if you want I can try help you with this tasks. Let me know if you need help to fix another issues in data-module. :) On Mon, May 11, 2015 at 4:55 AM, Thomas Hug thomas@gmail.com wrote: Hi Daniel Thanks for the patch! I should have some bandwidth the next week to do some DS coding and take care about it. There's indeed room for improvement for the criteria API. I was not really sure how useful people find it and started with a simplified version, but if it gets more adoption it's definitely worth filling the gaps. Feedback and PRs always welcome :) Cheers, Thomas On Fri, May 8, 2015 at 10:51 PM, Daniel Cunha daniels...@gmail.com wrote: Hi folks, I started to change something in data-module, I don't know if we have time to do it, but, let me know if DELTASPIKE-894 could be apply in next release. We don't support all methods. Do we want support for all methods? I can to see that some methods like 'isTrue', 'isFalse', etc.. of the Criteria not is supported by DS data-module. -- Best regard, Daniel Cunha (soro) -- Best regard, Daniel Cunha (soro) -- Best regard, Daniel Cunha (soro) -- Best regard, Daniel Cunha (soro) -- Best regard, Daniel Cunha (soro)
Re: CriteriaSupport API
Wow, thnx for churning out those fixes! :) (and also to Rafael for reviewing!) Will take some time for me to get to it but will try to do this asap. Cheers, Thomas On Thu, May 14, 2015 at 10:17 PM, Daniel Cunha daniels...@gmail.com wrote: Hi Thomas, I've working in some issues and I would like to send my result on work in DS. I have attached patch for: https://issues.apache.org/jira/browse/DELTASPIKE-603 https://issues.apache.org/jira/browse/DELTASPIKE-894 https://issues.apache.org/jira/browse/DELTASPIKE-701 https://issues.apache.org/jira/browse/DELTASPIKE-902 I had an help of the Rafael Benevides (rbenevides), he reviewed my patchs in (DELTASPIKE-894, DELTASPIKE-701). Let me know if the patchs is good or need improvement. I would like to help more :) I'll start work on DELTASPIKE-901. See you. Thank you. On Wed, May 13, 2015 at 1:10 PM, Daniel Cunha daniels...@gmail.com wrote: Hi Thomas, I'm looking to DELTASPIKE-701 and DELTASPIKE-603 I'm preparing to start with DELTASPIKE-603. Do you have something for it or did something? I would like to fix it, if you don't have time to do. :) On Wed, May 13, 2015 at 1:00 PM, Thomas Hug thomas@gmail.com wrote: Hi Daniel I definitely don't have as much time for DS as I'd like to have (right now close to none ;) so any help is welcome :). Let me know if you have any specific issue in mind and we can check what's needed. Cheers, Thomas On Wed, May 13, 2015 at 12:13 AM, Daniel Cunha daniels...@gmail.com wrote: Hi Thomas, I can to see that we have some issues opened and not fixed if you want I can try help you with this tasks. Let me know if you need help to fix another issues in data-module. :) On Mon, May 11, 2015 at 4:55 AM, Thomas Hug thomas@gmail.com wrote: Hi Daniel Thanks for the patch! I should have some bandwidth the next week to do some DS coding and take care about it. There's indeed room for improvement for the criteria API. I was not really sure how useful people find it and started with a simplified version, but if it gets more adoption it's definitely worth filling the gaps. Feedback and PRs always welcome :) Cheers, Thomas On Fri, May 8, 2015 at 10:51 PM, Daniel Cunha daniels...@gmail.com wrote: Hi folks, I started to change something in data-module, I don't know if we have time to do it, but, let me know if DELTASPIKE-894 could be apply in next release. We don't support all methods. Do we want support for all methods? I can to see that some methods like 'isTrue', 'isFalse', etc.. of the Criteria not is supported by DS data-module. -- Best regard, Daniel Cunha (soro) -- Best regard, Daniel Cunha (soro) -- Best regard, Daniel Cunha (soro) -- Best regard, Daniel Cunha (soro)
Re: CriteriaSupport API
Hi Thomas, I've working in some issues and I would like to send my result on work in DS. I have attached patch for: https://issues.apache.org/jira/browse/DELTASPIKE-603 https://issues.apache.org/jira/browse/DELTASPIKE-894 https://issues.apache.org/jira/browse/DELTASPIKE-701 https://issues.apache.org/jira/browse/DELTASPIKE-902 I had an help of the Rafael Benevides (rbenevides), he reviewed my patchs in (DELTASPIKE-894, DELTASPIKE-701). Let me know if the patchs is good or need improvement. I would like to help more :) I'll start work on DELTASPIKE-901. See you. Thank you. On Wed, May 13, 2015 at 1:10 PM, Daniel Cunha daniels...@gmail.com wrote: Hi Thomas, I'm looking to DELTASPIKE-701 and DELTASPIKE-603 I'm preparing to start with DELTASPIKE-603. Do you have something for it or did something? I would like to fix it, if you don't have time to do. :) On Wed, May 13, 2015 at 1:00 PM, Thomas Hug thomas@gmail.com wrote: Hi Daniel I definitely don't have as much time for DS as I'd like to have (right now close to none ;) so any help is welcome :). Let me know if you have any specific issue in mind and we can check what's needed. Cheers, Thomas On Wed, May 13, 2015 at 12:13 AM, Daniel Cunha daniels...@gmail.com wrote: Hi Thomas, I can to see that we have some issues opened and not fixed if you want I can try help you with this tasks. Let me know if you need help to fix another issues in data-module. :) On Mon, May 11, 2015 at 4:55 AM, Thomas Hug thomas@gmail.com wrote: Hi Daniel Thanks for the patch! I should have some bandwidth the next week to do some DS coding and take care about it. There's indeed room for improvement for the criteria API. I was not really sure how useful people find it and started with a simplified version, but if it gets more adoption it's definitely worth filling the gaps. Feedback and PRs always welcome :) Cheers, Thomas On Fri, May 8, 2015 at 10:51 PM, Daniel Cunha daniels...@gmail.com wrote: Hi folks, I started to change something in data-module, I don't know if we have time to do it, but, let me know if DELTASPIKE-894 could be apply in next release. We don't support all methods. Do we want support for all methods? I can to see that some methods like 'isTrue', 'isFalse', etc.. of the Criteria not is supported by DS data-module. -- Best regard, Daniel Cunha (soro) -- Best regard, Daniel Cunha (soro) -- Best regard, Daniel Cunha (soro) -- Best regard, Daniel Cunha (soro)
Re: CriteriaSupport API
Hi Daniel I definitely don't have as much time for DS as I'd like to have (right now close to none ;) so any help is welcome :). Let me know if you have any specific issue in mind and we can check what's needed. Cheers, Thomas On Wed, May 13, 2015 at 12:13 AM, Daniel Cunha daniels...@gmail.com wrote: Hi Thomas, I can to see that we have some issues opened and not fixed if you want I can try help you with this tasks. Let me know if you need help to fix another issues in data-module. :) On Mon, May 11, 2015 at 4:55 AM, Thomas Hug thomas@gmail.com wrote: Hi Daniel Thanks for the patch! I should have some bandwidth the next week to do some DS coding and take care about it. There's indeed room for improvement for the criteria API. I was not really sure how useful people find it and started with a simplified version, but if it gets more adoption it's definitely worth filling the gaps. Feedback and PRs always welcome :) Cheers, Thomas On Fri, May 8, 2015 at 10:51 PM, Daniel Cunha daniels...@gmail.com wrote: Hi folks, I started to change something in data-module, I don't know if we have time to do it, but, let me know if DELTASPIKE-894 could be apply in next release. We don't support all methods. Do we want support for all methods? I can to see that some methods like 'isTrue', 'isFalse', etc.. of the Criteria not is supported by DS data-module. -- Best regard, Daniel Cunha (soro) -- Best regard, Daniel Cunha (soro)
Re: CriteriaSupport API
Hi Thomas, I'm looking to DELTASPIKE-701 and DELTASPIKE-603 I'm preparing to start with DELTASPIKE-603. Do you have something for it or did something? I would like to fix it, if you don't have time to do. :) On Wed, May 13, 2015 at 1:00 PM, Thomas Hug thomas@gmail.com wrote: Hi Daniel I definitely don't have as much time for DS as I'd like to have (right now close to none ;) so any help is welcome :). Let me know if you have any specific issue in mind and we can check what's needed. Cheers, Thomas On Wed, May 13, 2015 at 12:13 AM, Daniel Cunha daniels...@gmail.com wrote: Hi Thomas, I can to see that we have some issues opened and not fixed if you want I can try help you with this tasks. Let me know if you need help to fix another issues in data-module. :) On Mon, May 11, 2015 at 4:55 AM, Thomas Hug thomas@gmail.com wrote: Hi Daniel Thanks for the patch! I should have some bandwidth the next week to do some DS coding and take care about it. There's indeed room for improvement for the criteria API. I was not really sure how useful people find it and started with a simplified version, but if it gets more adoption it's definitely worth filling the gaps. Feedback and PRs always welcome :) Cheers, Thomas On Fri, May 8, 2015 at 10:51 PM, Daniel Cunha daniels...@gmail.com wrote: Hi folks, I started to change something in data-module, I don't know if we have time to do it, but, let me know if DELTASPIKE-894 could be apply in next release. We don't support all methods. Do we want support for all methods? I can to see that some methods like 'isTrue', 'isFalse', etc.. of the Criteria not is supported by DS data-module. -- Best regard, Daniel Cunha (soro) -- Best regard, Daniel Cunha (soro) -- Best regard, Daniel Cunha (soro)
[jira] [Commented] (DELTASPIKE-894) Trim for CriteriaSupport API
[ https://issues.apache.org/jira/browse/DELTASPIKE-894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14542334#comment-14542334 ] Rafael Benevides commented on DELTASPIKE-894: - It looks ok but I'd like a second opinion here on the API. Trim for CriteriaSupport API Key: DELTASPIKE-894 URL: https://issues.apache.org/jira/browse/DELTASPIKE-894 Project: DeltaSpike Issue Type: New Feature Components: Data-Module Reporter: Daniel Cunha (soro) Assignee: Thomas Hug Priority: Minor Attachments: DELTASPIKE-894.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: CriteriaSupport API
Hi Thomas, I can to see that we have some issues opened and not fixed if you want I can try help you with this tasks. Let me know if you need help to fix another issues in data-module. :) On Mon, May 11, 2015 at 4:55 AM, Thomas Hug thomas@gmail.com wrote: Hi Daniel Thanks for the patch! I should have some bandwidth the next week to do some DS coding and take care about it. There's indeed room for improvement for the criteria API. I was not really sure how useful people find it and started with a simplified version, but if it gets more adoption it's definitely worth filling the gaps. Feedback and PRs always welcome :) Cheers, Thomas On Fri, May 8, 2015 at 10:51 PM, Daniel Cunha daniels...@gmail.com wrote: Hi folks, I started to change something in data-module, I don't know if we have time to do it, but, let me know if DELTASPIKE-894 could be apply in next release. We don't support all methods. Do we want support for all methods? I can to see that some methods like 'isTrue', 'isFalse', etc.. of the Criteria not is supported by DS data-module. -- Best regard, Daniel Cunha (soro) -- Best regard, Daniel Cunha (soro)
Re: CriteriaSupport API
Hi Daniel Thanks for the patch! I should have some bandwidth the next week to do some DS coding and take care about it. There's indeed room for improvement for the criteria API. I was not really sure how useful people find it and started with a simplified version, but if it gets more adoption it's definitely worth filling the gaps. Feedback and PRs always welcome :) Cheers, Thomas On Fri, May 8, 2015 at 10:51 PM, Daniel Cunha daniels...@gmail.com wrote: Hi folks, I started to change something in data-module, I don't know if we have time to do it, but, let me know if DELTASPIKE-894 could be apply in next release. We don't support all methods. Do we want support for all methods? I can to see that some methods like 'isTrue', 'isFalse', etc.. of the Criteria not is supported by DS data-module. -- Best regard, Daniel Cunha (soro)
[jira] [Updated] (DELTASPIKE-894) Trim for CriteriaSupport API
[ https://issues.apache.org/jira/browse/DELTASPIKE-894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gerhard Petracek updated DELTASPIKE-894: Assignee: Thomas Hug Trim for CriteriaSupport API Key: DELTASPIKE-894 URL: https://issues.apache.org/jira/browse/DELTASPIKE-894 Project: DeltaSpike Issue Type: New Feature Components: Data-Module Reporter: Daniel Cunha (soro) Assignee: Thomas Hug Priority: Minor Attachments: DELTASPIKE-894.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
CriteriaSupport API
Hi folks, I started to change something in data-module, I don't know if we have time to do it, but, let me know if DELTASPIKE-894 could be apply in next release. We don't support all methods. Do we want support for all methods? I can to see that some methods like 'isTrue', 'isFalse', etc.. of the Criteria not is supported by DS data-module. -- Best regard, Daniel Cunha (soro)
[jira] [Created] (DELTASPIKE-894) Trim for CriteriaSupport API
Daniel Cunha (soro) created DELTASPIKE-894: -- Summary: Trim for CriteriaSupport API Key: DELTASPIKE-894 URL: https://issues.apache.org/jira/browse/DELTASPIKE-894 Project: DeltaSpike Issue Type: New Feature Components: Data-Module Reporter: Daniel Cunha (soro) Priority: Minor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (DELTASPIKE-894) Trim for CriteriaSupport API
[ https://issues.apache.org/jira/browse/DELTASPIKE-894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Cunha (soro) updated DELTASPIKE-894: --- Attachment: DELTASPIKE-894.patch Trim for CriteriaSupport API Key: DELTASPIKE-894 URL: https://issues.apache.org/jira/browse/DELTASPIKE-894 Project: DeltaSpike Issue Type: New Feature Components: Data-Module Reporter: Daniel Cunha (soro) Priority: Minor Attachments: DELTASPIKE-894.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
