Re: Info: directory-project 45 release

2021-05-13 Thread Stefan Seelmann
Awesome!

I assume the maven-bundle-plugin is updated to version 5.1.2? That's
required to build the projects with Java 16 and 17-ea.


On 5/14/21 7:33 AM, Emmanuel Lécharny wrote:
> Hi,
> 
> I'm going to release apache directory-project 45 in the coming hours if
> no one objects.
> 
> I have tested it with API and Server. (note: the maven surefire plugin
> will remain in 3.0.0-M3, the M4 and M5 version are making the tests
> failing)
> 
> It will contain many updated plugin versions:
> 
> 
> Thanks !


-
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org



Info: directory-project 45 release

2021-05-13 Thread Emmanuel Lécharny

Hi,

I'm going to release apache directory-project 45 in the coming hours if 
no one objects.


I have tested it with API and Server. (note: the maven surefire plugin 
will remain in 3.0.0-M3, the M4 and M5 version are making the tests failing)


It will contain many updated plugin versions:


Thanks !
--
*Emmanuel Lécharny - CTO* 205 Promenade des Anglais – 06200 NICE
T. +33 (0)4 89 97 36 50
P. +33 (0)6 08 33 32 61
emmanuel.lecha...@busit.com https://www.busit.com/

-
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org



Re: directory-project and directory-buildtools cross dependence

2021-05-13 Thread Stefan Seelmann
On 5/14/21 6:23 AM, Emmanuel Lécharny wrote:
> or simpler to release checkstyle-configuration-2.0.1 refering to
> project-44, which should not be such a big deal as we don't have any
> dependencies in the directoy-buildtools projects...

That workaround sounds good to me.




-
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org



directory-project and directory-buildtools cross dependence

2021-05-13 Thread Emmanuel Lécharny

Hi,

while working on a new release of directory-project (45), I found out 
that it has a reference on 
org.apache.directory.buildtools.checkstyle-configuration, which itself 
has a dependences on directory-project:


in directory-project/pom.xml:

  
...

2.0.1-SNAPSHOT
  

...


  org.apache.maven.plugins
  maven-checkstyle-plugin
  3.1.2
  

  com.puppycrawl.tools
  checkstyle
  8.42


  org.apache.directory.buildtools
  checkstyle-configuration

${org.apache.directory.checkstyle-configuration.version}



in directory-buildtools/pom.xml:

https://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="https://maven.apache.org/POM/4.0.0 
https://maven.apache.org/maven-v4_0_0.xsd;>

  4.0.0
  
org.apache.directory.project
project
45-SNAPSHOT

  


This is not exactly expected (although in the current 44 version of the 
directopry-project pom, we refer to a released version of 
checkstyle-configuration, AKA 2.0.0


This  is kind of problematic, as we can't really have both release 
depending on the latest release of the other one...


The only way to get the release proper is to:
- first release project-45 refering to checkstyle-configuration-2.0.0
- then release checkstyle-configuration-2.0.1 refering in project-45 
(refering to checkstyle-configuration-2.0.0 itself...)
- then to release project-46 refering to checkstyle-configuration-2.0.1 
(which will be refering to project-45...)


or simpler to release checkstyle-configuration-2.0.1 refering to 
project-44, which should not be such a big deal as we don't have any 
dependencies in the directoy-buildtools projects...


wdyt ?

--
*Emmanuel Lécharny - CTO* 205 Promenade des Anglais – 06200 NICE
T. +33 (0)4 89 97 36 50
P. +33 (0)6 08 33 32 61
emmanuel.lecha...@busit.com https://www.busit.com/

-
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org



Re: project & checkstyle update

2021-05-13 Thread Emmanuel Lécharny

Many thanks, Stefan !


On 13/05/2021 09:42, Stefan Seelmann wrote:

Committed and pushed, all issues are resolved, OSGi tests work again.

On 5/13/21 9:20 AM, Emmanuel Lécharny wrote:

OH, GREAT !

Please commit, I'll check for the missing deps.


On 13/05/2021 08:46, Stefan Seelmann wrote:

I got them to run, but some fail because of unresolved requirements. Let
me know if I should commit it and investigate further:

diff --git a/osgi-integ/pom.xml b/osgi-integ/pom.xml
index f993450965..527b31c51f 100644
--- a/osgi-integ/pom.xml
+++ b/osgi-integ/pom.xml
@@ -249,8 +249,8 @@
   

   
-  org.junit.jupiter
-  junit-jupiter-engine
+  junit
+  junit
     test
   

@@ -312,6 +312,7 @@
   
     runtime

${project.build.directory}/test-classes/deps.txt
+
org.junit.jupiter,org.junit.platform,org.apiguardian

   
     
   
@@ -327,6 +328,13 @@

1
   1
     
+  
+    
+  org.apache.maven.surefire
+  surefire-junit47
+  3.0.0-M3
+    
+  
   
   



On 5/13/21 8:13 AM, Emmanuel Lécharny wrote:

The weird thing is that there is only one difference between the working
osgi-integ version and the not running one:

  
    org.junit.jupiter
    junit-jupiter-engine
    test
  

replaced

  
    junit
    junit
    test
  


If I roll back this change, I get the same result.

So it must be something on the parent pom.

On 13/05/2021 07:45, Emmanuel Lécharny wrote:

Ok, I know that the OSGi tests were running on commit
2ec1117fec41919a68d04ba3a51724562e3b46f8 ("Updating Jetty to
9.4.34.v20201102", made by Colm on Nov 6th) and stopped being run with
commit 04212704be56cdcb750ca571081a5e55fa03bfb8 ("Started the
migration to Junit 5", made by me on Dec, 23th).



On 12/05/2021 09:18, Emmanuel Lécharny wrote:

Will analyse further tonite.

FTR I have added a test class, which get executed, which means the
tests are somehow visible. May be an issue with the
RunWith(PaxExam.class) ?

On 12/05/2021 06:47, Stefan Seelmann wrote:

On 5/11/21 11:45 PM, Emmanuel Lécharny wrote:

And after going back to the existing project (44) parent, I can't
have
the osgi-integ test run at all :

[INFO] --- maven-surefire-plugin:3.0.0-M3:test (default-test) @
apacheds-osgi-integ ---
[INFO]
[INFO] ---
[INFO]  T E S T S
[INFO] ---
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
[INFO]
...


This is more than bizarre...


Same happens currently in master e.g. on Jenkins. I assume we need to
add the junit-vintage dependency.


-
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org










-
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org






-
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org



--
*Emmanuel Lécharny - CTO* 205 Promenade des Anglais – 06200 NICE
T. +33 (0)4 89 97 36 50
P. +33 (0)6 08 33 32 61
emmanuel.lecha...@busit.com https://www.busit.com/

-
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org



[jira] [Created] (FC-293) [fortress-web] CVE-2020-11976

2021-05-13 Thread Shawn McKinney (Jira)
Shawn McKinney created FC-293:
-

 Summary: [fortress-web] CVE-2020-11976
 Key: FC-293
 URL: https://issues.apache.org/jira/browse/FC-293
 Project: FORTRESS
  Issue Type: Improvement
Reporter: Shawn McKinney


h5. [CVE-2020-11976|https://github.com/advisories/GHSA-64gv-3pqv-299h]
 high severity 
*Vulnerable versions:* >= 8.0.0, < 8.9.0
*Patched version:* 8.9.0
By crafting a special URL it is possible to make Wicket deliver unprocessed 
HTML templates. This would allow an attacker to see possibly sensitive 
information inside a HTML template that is usually removed during rendering. 
Affected are Apache Wicket versions 7.16.0, 8.8.0 and 9.0.0-M5



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org



[jira] [Commented] (DIRSERVER-2322) ApacheDS default server instance not starting - Error 1067

2021-05-13 Thread Stefan Seelmann (Jira)


[ 
https://issues.apache.org/jira/browse/DIRSERVER-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17343967#comment-17343967
 ] 

Stefan Seelmann commented on DIRSERVER-2322:


Fix: https://github.com/apache/directory-server/pull/49

> ApacheDS default server instance not starting - Error 1067
> --
>
> Key: DIRSERVER-2322
> URL: https://issues.apache.org/jira/browse/DIRSERVER-2322
> Project: Directory ApacheDS
>  Issue Type: Bug
>  Components: installer
>Affects Versions: 2.0.0.AM26
>Reporter: yangsoo song
>Priority: Blocker
>  Labels: newbie
> Fix For: 2.0.0.AM27
>
> Attachments: Screen Shot 2020-07-22 at 1.58.01 PM.png
>
>
> !Screen Shot 2020-07-22 at 1.58.01 PM.png!
> Hey guys, 
> I followed official documents to install ApacheDS on my windows machine. I've 
> been trying to start the ApacheDS - default service but keep getting this 
> error, I've tried it on multiple machines but still getting the same message. 
> Has anyone encountered this issue and resolved it?
> Thank you.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org



[jira] [Assigned] (DIRSERVER-2322) ApacheDS default server instance not starting - Error 1067

2021-05-13 Thread Stefan Seelmann (Jira)


 [ 
https://issues.apache.org/jira/browse/DIRSERVER-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seelmann reassigned DIRSERVER-2322:
--

Assignee: Stefan Seelmann

> ApacheDS default server instance not starting - Error 1067
> --
>
> Key: DIRSERVER-2322
> URL: https://issues.apache.org/jira/browse/DIRSERVER-2322
> Project: Directory ApacheDS
>  Issue Type: Bug
>  Components: installer
>Affects Versions: 2.0.0.AM26
>Reporter: yangsoo song
>Assignee: Stefan Seelmann
>Priority: Blocker
>  Labels: newbie
> Fix For: 2.0.0.AM27
>
> Attachments: Screen Shot 2020-07-22 at 1.58.01 PM.png
>
>
> !Screen Shot 2020-07-22 at 1.58.01 PM.png!
> Hey guys, 
> I followed official documents to install ApacheDS on my windows machine. I've 
> been trying to start the ApacheDS - default service but keep getting this 
> error, I've tried it on multiple machines but still getting the same message. 
> Has anyone encountered this issue and resolved it?
> Thank you.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org



[GitHub] [directory-server] seelmann opened a new pull request #49: DIRSERVER-2322: Move tmp directory into instance layout

2021-05-13 Thread GitBox


seelmann opened a new pull request #49:
URL: https://github.com/apache/directory-server/pull/49


   Configure system property `java.io.tmpdir` in the wrapper to point to the 
instance layout. Fixes issue when running ApacheDS on Windows because the 
original tempdir doesn't exist. Also updated some installer test docker images 
and java versions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org



[GitHub] [directory-server] coheigea merged pull request #48: Removing apache-felix, non-osgi-dependencies, service-osg…

2021-05-13 Thread GitBox


coheigea merged pull request #48:
URL: https://github.com/apache/directory-server/pull/48


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org



Re: project & checkstyle update

2021-05-13 Thread Stefan Seelmann
Committed and pushed, all issues are resolved, OSGi tests work again.

On 5/13/21 9:20 AM, Emmanuel Lécharny wrote:
> OH, GREAT !
> 
> Please commit, I'll check for the missing deps.
> 
> 
> On 13/05/2021 08:46, Stefan Seelmann wrote:
>> I got them to run, but some fail because of unresolved requirements. Let
>> me know if I should commit it and investigate further:
>>
>> diff --git a/osgi-integ/pom.xml b/osgi-integ/pom.xml
>> index f993450965..527b31c51f 100644
>> --- a/osgi-integ/pom.xml
>> +++ b/osgi-integ/pom.xml
>> @@ -249,8 +249,8 @@
>>   
>>
>>   
>> -  org.junit.jupiter
>> -  junit-jupiter-engine
>> +  junit
>> +  junit
>>     test
>>   
>>
>> @@ -312,6 +312,7 @@
>>   
>>     runtime
>>
>> ${project.build.directory}/test-classes/deps.txt
>> +
>> org.junit.jupiter,org.junit.platform,org.apiguardian
>>
>>   
>>     
>>   
>> @@ -327,6 +328,13 @@
>>
>> 1
>>   1
>>     
>> +  
>> +    
>> +  org.apache.maven.surefire
>> +  surefire-junit47
>> +  3.0.0-M3
>> +    
>> +  
>>   
>>   
>>
>>
>>
>> On 5/13/21 8:13 AM, Emmanuel Lécharny wrote:
>>> The weird thing is that there is only one difference between the working
>>> osgi-integ version and the not running one:
>>>
>>>  
>>>    org.junit.jupiter
>>>    junit-jupiter-engine
>>>    test
>>>  
>>>
>>> replaced
>>>
>>>  
>>>    junit
>>>    junit
>>>    test
>>>  
>>>
>>>
>>> If I roll back this change, I get the same result.
>>>
>>> So it must be something on the parent pom.
>>>
>>> On 13/05/2021 07:45, Emmanuel Lécharny wrote:
 Ok, I know that the OSGi tests were running on commit
 2ec1117fec41919a68d04ba3a51724562e3b46f8 ("Updating Jetty to
 9.4.34.v20201102", made by Colm on Nov 6th) and stopped being run with
 commit 04212704be56cdcb750ca571081a5e55fa03bfb8 ("Started the
 migration to Junit 5", made by me on Dec, 23th).



 On 12/05/2021 09:18, Emmanuel Lécharny wrote:
> Will analyse further tonite.
>
> FTR I have added a test class, which get executed, which means the
> tests are somehow visible. May be an issue with the
> RunWith(PaxExam.class) ?
>
> On 12/05/2021 06:47, Stefan Seelmann wrote:
>> On 5/11/21 11:45 PM, Emmanuel Lécharny wrote:
>>> And after going back to the existing project (44) parent, I can't
>>> have
>>> the osgi-integ test run at all :
>>>
>>> [INFO] --- maven-surefire-plugin:3.0.0-M3:test (default-test) @
>>> apacheds-osgi-integ ---
>>> [INFO]
>>> [INFO] ---
>>> [INFO]  T E S T S
>>> [INFO] ---
>>> [INFO]
>>> [INFO] Results:
>>> [INFO]
>>> [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
>>> [INFO]
>>> ...
>>>
>>>
>>> This is more than bizarre...
>>
>> Same happens currently in master e.g. on Jenkins. I assume we need to
>> add the junit-vintage dependency.
>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
>> For additional commands, e-mail: dev-h...@directory.apache.org
>>
>

>>>
>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
>> For additional commands, e-mail: dev-h...@directory.apache.org
>>
> 


-
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org



[GitHub] [directory-server] elecharny commented on pull request #48: Removing apache-felix, bulkloader, non-osgi-dependencies, service-osg…

2021-05-13 Thread GitBox


elecharny commented on pull request #48:
URL: https://github.com/apache/directory-server/pull/48#issuecomment-840373793


   I would keep the bulk-loader module atm.
   
   All the others can be removed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org



Re: project & checkstyle update

2021-05-13 Thread Emmanuel Lécharny




On 13/05/2021 09:02, Stefan Seelmann wrote:

apacheds-core-annotation and apacheds-server-annotation still have
dependencies to junit4 (org.junit.runner package)


This is probably something to remove...

-
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org



Re: project & checkstyle update

2021-05-13 Thread Emmanuel Lécharny

OH, GREAT !

Please commit, I'll check for the missing deps.


On 13/05/2021 08:46, Stefan Seelmann wrote:

I got them to run, but some fail because of unresolved requirements. Let
me know if I should commit it and investigate further:

diff --git a/osgi-integ/pom.xml b/osgi-integ/pom.xml
index f993450965..527b31c51f 100644
--- a/osgi-integ/pom.xml
+++ b/osgi-integ/pom.xml
@@ -249,8 +249,8 @@
  

  
-  org.junit.jupiter
-  junit-jupiter-engine
+  junit
+  junit
test
  

@@ -312,6 +312,7 @@
  
runtime

${project.build.directory}/test-classes/deps.txt
+
org.junit.jupiter,org.junit.platform,org.apiguardian
  

  
@@ -327,6 +328,13 @@

1
  1

+  
+
+  org.apache.maven.surefire
+  surefire-junit47
+  3.0.0-M3
+
+  
  
  



On 5/13/21 8:13 AM, Emmanuel Lécharny wrote:

The weird thing is that there is only one difference between the working
osgi-integ version and the not running one:

     
   org.junit.jupiter
   junit-jupiter-engine
   test
     

replaced

     
   junit
   junit
   test
     


If I roll back this change, I get the same result.

So it must be something on the parent pom.

On 13/05/2021 07:45, Emmanuel Lécharny wrote:

Ok, I know that the OSGi tests were running on commit
2ec1117fec41919a68d04ba3a51724562e3b46f8 ("Updating Jetty to
9.4.34.v20201102", made by Colm on Nov 6th) and stopped being run with
commit 04212704be56cdcb750ca571081a5e55fa03bfb8 ("Started the
migration to Junit 5", made by me on Dec, 23th).



On 12/05/2021 09:18, Emmanuel Lécharny wrote:

Will analyse further tonite.

FTR I have added a test class, which get executed, which means the
tests are somehow visible. May be an issue with the
RunWith(PaxExam.class) ?

On 12/05/2021 06:47, Stefan Seelmann wrote:

On 5/11/21 11:45 PM, Emmanuel Lécharny wrote:

And after going back to the existing project (44) parent, I can't have
the osgi-integ test run at all :

[INFO] --- maven-surefire-plugin:3.0.0-M3:test (default-test) @
apacheds-osgi-integ ---
[INFO]
[INFO] ---
[INFO]  T E S T S
[INFO] ---
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
[INFO]
...


This is more than bizarre...


Same happens currently in master e.g. on Jenkins. I assume we need to
add the junit-vintage dependency.


-
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org










-
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org



--
*Emmanuel Lécharny - CTO* 205 Promenade des Anglais – 06200 NICE
T. +33 (0)4 89 97 36 50
P. +33 (0)6 08 33 32 61
emmanuel.lecha...@busit.com https://www.busit.com/

-
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org



[GitHub] [directory-server] coheigea opened a new pull request #48: Removing apache-felix, bulkloader, non-osgi-dependencies, service-osg…

2021-05-13 Thread GitBox


coheigea opened a new pull request #48:
URL: https://github.com/apache/directory-server/pull/48


   …i, component-hub modules


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org



Re: project & checkstyle update

2021-05-13 Thread Stefan Seelmann
apacheds-core-annotation and apacheds-server-annotation still have
dependencies to junit4 (org.junit.runner package)

On 5/13/21 8:46 AM, Stefan Seelmann wrote:
> I got them to run, but some fail because of unresolved requirements. Let
> me know if I should commit it and investigate further:
> 
> diff --git a/osgi-integ/pom.xml b/osgi-integ/pom.xml
> index f993450965..527b31c51f 100644
> --- a/osgi-integ/pom.xml
> +++ b/osgi-integ/pom.xml
> @@ -249,8 +249,8 @@
>  
> 
>  
> -  org.junit.jupiter
> -  junit-jupiter-engine
> +  junit
> +  junit
>test
>  
> 
> @@ -312,6 +312,7 @@
>  
>runtime
> 
> ${project.build.directory}/test-classes/deps.txt
> +
> org.junit.jupiter,org.junit.platform,org.apiguardian
>  
>
>  
> @@ -327,6 +328,13 @@
> 
> 1
>  1
>
> +  
> +
> +  org.apache.maven.surefire
> +  surefire-junit47
> +  3.0.0-M3
> +
> +  
>  
>  
> 
> 
> 
> On 5/13/21 8:13 AM, Emmanuel Lécharny wrote:
>> The weird thing is that there is only one difference between the working
>> osgi-integ version and the not running one:
>>
>>     
>>   org.junit.jupiter
>>   junit-jupiter-engine
>>   test
>>     
>>
>> replaced
>>
>>     
>>   junit
>>   junit
>>   test
>>     
>>
>>
>> If I roll back this change, I get the same result.
>>
>> So it must be something on the parent pom.
>>
>> On 13/05/2021 07:45, Emmanuel Lécharny wrote:
>>> Ok, I know that the OSGi tests were running on commit
>>> 2ec1117fec41919a68d04ba3a51724562e3b46f8 ("Updating Jetty to
>>> 9.4.34.v20201102", made by Colm on Nov 6th) and stopped being run with
>>> commit 04212704be56cdcb750ca571081a5e55fa03bfb8 ("Started the
>>> migration to Junit 5", made by me on Dec, 23th).
>>>
>>>
>>>
>>> On 12/05/2021 09:18, Emmanuel Lécharny wrote:
 Will analyse further tonite.

 FTR I have added a test class, which get executed, which means the
 tests are somehow visible. May be an issue with the
 RunWith(PaxExam.class) ?

 On 12/05/2021 06:47, Stefan Seelmann wrote:
> On 5/11/21 11:45 PM, Emmanuel Lécharny wrote:
>> And after going back to the existing project (44) parent, I can't have
>> the osgi-integ test run at all :
>>
>> [INFO] --- maven-surefire-plugin:3.0.0-M3:test (default-test) @
>> apacheds-osgi-integ ---
>> [INFO]
>> [INFO] ---
>> [INFO]  T E S T S
>> [INFO] ---
>> [INFO]
>> [INFO] Results:
>> [INFO]
>> [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
>> [INFO]
>> ...
>>
>>
>> This is more than bizarre...
>
> Same happens currently in master e.g. on Jenkins. I assume we need to
> add the junit-vintage dependency.
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
> For additional commands, e-mail: dev-h...@directory.apache.org
>

>>>
>>
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
> For additional commands, e-mail: dev-h...@directory.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org



Re: project & checkstyle update

2021-05-13 Thread Stefan Seelmann
I got them to run, but some fail because of unresolved requirements. Let
me know if I should commit it and investigate further:

diff --git a/osgi-integ/pom.xml b/osgi-integ/pom.xml
index f993450965..527b31c51f 100644
--- a/osgi-integ/pom.xml
+++ b/osgi-integ/pom.xml
@@ -249,8 +249,8 @@
 

 
-  org.junit.jupiter
-  junit-jupiter-engine
+  junit
+  junit
   test
 

@@ -312,6 +312,7 @@
 
   runtime

${project.build.directory}/test-classes/deps.txt
+
org.junit.jupiter,org.junit.platform,org.apiguardian
 
   
 
@@ -327,6 +328,13 @@

1
 1
   
+  
+
+  org.apache.maven.surefire
+  surefire-junit47
+  3.0.0-M3
+
+  
 
 



On 5/13/21 8:13 AM, Emmanuel Lécharny wrote:
> The weird thing is that there is only one difference between the working
> osgi-integ version and the not running one:
> 
>     
>   org.junit.jupiter
>   junit-jupiter-engine
>   test
>     
> 
> replaced
> 
>     
>   junit
>   junit
>   test
>     
> 
> 
> If I roll back this change, I get the same result.
> 
> So it must be something on the parent pom.
> 
> On 13/05/2021 07:45, Emmanuel Lécharny wrote:
>> Ok, I know that the OSGi tests were running on commit
>> 2ec1117fec41919a68d04ba3a51724562e3b46f8 ("Updating Jetty to
>> 9.4.34.v20201102", made by Colm on Nov 6th) and stopped being run with
>> commit 04212704be56cdcb750ca571081a5e55fa03bfb8 ("Started the
>> migration to Junit 5", made by me on Dec, 23th).
>>
>>
>>
>> On 12/05/2021 09:18, Emmanuel Lécharny wrote:
>>> Will analyse further tonite.
>>>
>>> FTR I have added a test class, which get executed, which means the
>>> tests are somehow visible. May be an issue with the
>>> RunWith(PaxExam.class) ?
>>>
>>> On 12/05/2021 06:47, Stefan Seelmann wrote:
 On 5/11/21 11:45 PM, Emmanuel Lécharny wrote:
> And after going back to the existing project (44) parent, I can't have
> the osgi-integ test run at all :
>
> [INFO] --- maven-surefire-plugin:3.0.0-M3:test (default-test) @
> apacheds-osgi-integ ---
> [INFO]
> [INFO] ---
> [INFO]  T E S T S
> [INFO] ---
> [INFO]
> [INFO] Results:
> [INFO]
> [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
> [INFO]
> ...
>
>
> This is more than bizarre...

 Same happens currently in master e.g. on Jenkins. I assume we need to
 add the junit-vintage dependency.


 -
 To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
 For additional commands, e-mail: dev-h...@directory.apache.org

>>>
>>
> 


-
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org



Re: project & checkstyle update

2021-05-13 Thread Emmanuel Lécharny
The weird thing is that there is only one difference between the working 
osgi-integ version and the not running one:



  org.junit.jupiter
  junit-jupiter-engine
  test


replaced


  junit
  junit
  test



If I roll back this change, I get the same result.

So it must be something on the parent pom.

On 13/05/2021 07:45, Emmanuel Lécharny wrote:
Ok, I know that the OSGi tests were running on commit 
2ec1117fec41919a68d04ba3a51724562e3b46f8 ("Updating Jetty to 
9.4.34.v20201102", made by Colm on Nov 6th) and stopped being run with 
commit 04212704be56cdcb750ca571081a5e55fa03bfb8 ("Started the migration 
to Junit 5", made by me on Dec, 23th).




On 12/05/2021 09:18, Emmanuel Lécharny wrote:

Will analyse further tonite.

FTR I have added a test class, which get executed, which means the 
tests are somehow visible. May be an issue with the 
RunWith(PaxExam.class) ?


On 12/05/2021 06:47, Stefan Seelmann wrote:

On 5/11/21 11:45 PM, Emmanuel Lécharny wrote:

And after going back to the existing project (44) parent, I can't have
the osgi-integ test run at all :

[INFO] --- maven-surefire-plugin:3.0.0-M3:test (default-test) @
apacheds-osgi-integ ---
[INFO]
[INFO] ---
[INFO]  T E S T S
[INFO] ---
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
[INFO]
...


This is more than bizarre...


Same happens currently in master e.g. on Jenkins. I assume we need to
add the junit-vintage dependency.


-
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org







--
*Emmanuel Lécharny - CTO* 205 Promenade des Anglais – 06200 NICE
T. +33 (0)4 89 97 36 50
P. +33 (0)6 08 33 32 61
emmanuel.lecha...@busit.com https://www.busit.com/

-
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org