[jira] [Created] (DIRSERVER-2395) SIMILAR_BRANCHES in ../codec/types/PaDataType.java
e.bykhanova created DIRSERVER-2395:
--
Summary: SIMILAR_BRANCHES in ../codec/types/PaDataType.java
Key: DIRSERVER-2395
URL: https://issues.apache.org/jira/browse/DIRSERVER-2395
Project: Directory ApacheDS
Issue Type: Bug
Affects Versions: 2.0.0.AM26
Reporter: e.bykhanova
Attachments: image-2024-03-05-18-48-50-123.png,
image-2024-03-05-18-49-32-439.png
The static analyzer has detected {*}SIMILAR_BRANCHES{*}: here we have identical
branches in switch node.
All branches in this *switch* (function '{_}public static PaDataType
getTypeByValue(int type){_}') correspond to the values of '{_}public enum
Datatype{_}' (PaDataType.java:28-121). In this *enum* {*}PA_PK_AS_REQ{*}-value
corresponds to the order *14* and \{*}PA_PK_AS_REP{*}-value corresponds to the
order \{*}15{*}. It seems that the developer just overlooked that _the last
letter_ in the values at PaDataType.java:184 and PaDataType.java:186 _should be
different_ - the parameters PA_PK_AS_REQ and PA_PK_AS_REP look quite similar :)
!image-2024-03-05-18-48-50-123.png!
!image-2024-03-05-18-49-32-439.png!
Found by Linux Verification Center (portal.linuxtesting.ru) with SVACE.
Author E. Bykhanova (e.bykhan...@fobos-nt.ru).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org
Re: [PR] Bump actions/setup-java from 4.0.0 to 4.1.0 [directory-ldap-api]
coheigea commented on PR #81: URL: https://github.com/apache/directory-ldap-api/pull/81#issuecomment-1978835222 @dependabot recreate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For additional commands, e-mail: dev-h...@directory.apache.org
[jira] [Comment Edited] (DIRAPI-397) Update Copyright year
[
https://issues.apache.org/jira/browse/DIRAPI-397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823626#comment-17823626
]
Emmanuel Lécharny edited comment on DIRAPI-397 at 3/5/24 1:52 PM:
--
The proposal to set the upper bound to 'present' should be fine.
Legally speaking (afaik), the upper range is useless. The idea is to 'stamp'
the original release, and optionally all the other releases.
What is important is the date from which the copyright applies. So we could
perfectly only set the first date (like 2003):
{code:java}
"The copyright notice should include the year in which you finished preparing
the release (so if you finished it in 1998 but didn't post it until 1999, use
1998). You should add the proper year for each past release; for example,
“Copyright 1998, 1999 Terry Jones” if some releases were finished in 1998 and
some were finished in 1999. If several people helped write the code, use all
their names.
For software with several releases over multiple years, it's okay to use a
range (“2008-2010”) instead of listing individual years (“2008, 2009, 2010”) if
and only if every year in the range, inclusive, really is a “copyrightable”
year that would be listed individually; and you make an explicit statement in
your documentation about this usage."
{code}
(see [The GNU copyright Notice|https://www.gnu.org/licenses/gpl-howto.en.html])
But for clarity, 'present' as an upper bound makes sense.
was (Author: elecharny):
The proposal to set the upper bound to 'present' should be fine.
Legally speaking (afaik), the upper range is useless. The idea is to 'stamp'
the original release, and optionally all the other releases.
What is important is the date from which the copyright applies. So we could
perfectly only set the first date (like 2003):
{code:java}
"The copyright notice should include the year in which you finished preparing
the release (so if you finished it in 1998 but didn't post it until 1999, use
1998). You should add the proper year for each past release; for example,
“Copyright 1998, 1999 Terry Jones” if some releases were finished in 1998 and
some were finished in 1999. If several people helped write the code, use all
their names.
For software with several releases over multiple years, it's okay to use a
range (“2008-2010”) instead of listing individual years (“2008, 2009, 2010”) if
and only if every year in the range, inclusive, really is a “copyrightable”
year that would be listed individually; and you make an explicit statement in
your documentation about this usage."
{code}
(see [The GNU copyright Notice|https//www.gnu.org/licenses/gpl-howto.en.html])
But for clarity, 'present' as an upper bound makes sense.
> Update Copyright year
> --
>
> Key: DIRAPI-397
> URL: https://issues.apache.org/jira/browse/DIRAPI-397
> Project: Directory Client API
> Issue Type: Improvement
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>
> Set to 2024
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org
Re: [PR] Bump ch.qos.logback:logback-classic from 1.5.1 to 1.5.3 [directory-server]
coheigea merged PR #157: URL: https://github.com/apache/directory-server/pull/157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For additional commands, e-mail: dev-h...@directory.apache.org
Re: [PR] Bump actions/setup-java from 4.0.0 to 4.1.0 [directory-server]
coheigea merged PR #156: URL: https://github.com/apache/directory-server/pull/156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For additional commands, e-mail: dev-h...@directory.apache.org
[jira] [Comment Edited] (DIRAPI-397) Update Copyright year
[
https://issues.apache.org/jira/browse/DIRAPI-397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823626#comment-17823626
]
Emmanuel Lécharny edited comment on DIRAPI-397 at 3/5/24 1:51 PM:
--
The proposal to set the upper bound to 'present' should be fine.
Legally speaking (afaik), the upper range is useless. The idea is to 'stamp'
the original release, and optionally all the other releases.
What is important is the date from which the copyright applies. So we could
perfectly only set the first date (like 2003):
{code:java}
"The copyright notice should include the year in which you finished preparing
the release (so if you finished it in 1998 but didn't post it until 1999, use
1998). You should add the proper year for each past release; for example,
“Copyright 1998, 1999 Terry Jones” if some releases were finished in 1998 and
some were finished in 1999. If several people helped write the code, use all
their names.
For software with several releases over multiple years, it's okay to use a
range (“2008-2010”) instead of listing individual years (“2008, 2009, 2010”) if
and only if every year in the range, inclusive, really is a “copyrightable”
year that would be listed individually; and you make an explicit statement in
your documentation about this usage."
{code}
(see [The GNU copyright Notice|https//www.gnu.org/licenses/gpl-howto.en.html])
But for clarity, 'present' as an upper bound makes sense.
was (Author: elecharny):
The proposal to set the upper bound to 'present' should be fine.
Legally speaking (afaik), the upper range is useless. The idea is to 'stamp'
the original release, and optionally all the other releases.
What is important is the date from which the copyright applies. So we could
perfectly only set the first date (like 2003):
{code:java}
"The copyright notice should include the year in which you finished preparing
the release (so if you finished it in 1998 but didn't post it until 1999, use
1998). You should add the proper year for each past release; for example,
“Copyright 1998, 1999 Terry Jones” if some releases were finished in 1998 and
some were finished in 1999. If several people helped write the code, use all
their names.
For software with several releases over multiple years, it's okay to use a
range (“2008-2010”) instead of listing individual years (“2008, 2009, 2010”) if
and only if every year in the range, inclusive, really is a “copyrightable”
year that would be listed individually; and you make an explicit statement in
your documentation about this usage."
{code}
(see [The GNU copyright Notice|https//www.gnu.org/licenses/gpl-howto.en.html])
But for clarity, 'present' as an upper bound makes sense.
> Update Copyright year
> --
>
> Key: DIRAPI-397
> URL: https://issues.apache.org/jira/browse/DIRAPI-397
> Project: Directory Client API
> Issue Type: Improvement
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>
> Set to 2024
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org
Re: [PR] Bump github/codeql-action from 3.24.5 to 3.24.6 [directory-kerby]
coheigea merged PR #342: URL: https://github.com/apache/directory-kerby/pull/342 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For additional commands, e-mail: dev-h...@directory.apache.org
Re: [PR] Bump actions/setup-java from 4.0.0 to 4.1.0 [directory-kerby]
coheigea merged PR #343: URL: https://github.com/apache/directory-kerby/pull/343 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For additional commands, e-mail: dev-h...@directory.apache.org
[jira] [Comment Edited] (DIRAPI-397) Update Copyright year
[
https://issues.apache.org/jira/browse/DIRAPI-397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823626#comment-17823626
]
Emmanuel Lécharny edited comment on DIRAPI-397 at 3/5/24 1:50 PM:
--
The proposal to set the upper bound to 'present' should be fine.
Legally speaking (afaik), the upper range is useless. The idea is to 'stamp'
the original release, and optionally all the other releases.
What is important is the date from which the copyright applies. So we could
perfectly only set the first date (like 2003):
{code:java}
"The copyright notice should include the year in which you finished preparing
the release (so if you finished it in 1998 but didn't post it until 1999, use
1998). You should add the proper year for each past release; for example,
“Copyright 1998, 1999 Terry Jones” if some releases were finished in 1998 and
some were finished in 1999. If several people helped write the code, use all
their names.
For software with several releases over multiple years, it's okay to use a
range (“2008-2010”) instead of listing individual years (“2008, 2009, 2010”) if
and only if every year in the range, inclusive, really is a “copyrightable”
year that would be listed individually; and you make an explicit statement in
your documentation about this usage."
{code}
(see [The GNU copyright Notice|https//www.gnu.org/licenses/gpl-howto.en.html])
But for clarity, 'present' as an upper bound makes sense.
was (Author: elecharny):
The proposal to set the upper bound to 'present' should be fine.
Legally speaking (afaik), the upper range is useless. The idea is to 'stamp'
the original release, and optionally all the other releases.
What is important is the date from which the copyright applies. So we could
perfectly only set the first date (like 2003):
{code:java}
"The copyright notice should include the year in which you finished preparing
the release (so if you finished it in 1998 but didn't post it until 1999, use
1998). You should add the proper year for each past release; for example,
“Copyright 1998, 1999 Terry Jones” if some releases were finished in 1998 and
some were finished in 1999. If several people helped write the code, use all
their names.
For software with several releases over multiple years, it's okay to use a
range (“2008-2010”) instead of listing individual years (“2008, 2009, 2010”) if
and only if every year in the range, inclusive, really is a “copyrightable”
year that would be listed individually; and you make an explicit statement in
your documentation about this usage."
{code}
(see [The GNU copyright Notice|//www.gnu.org/licenses/gpl-howto.en.html])
But for clarity, 'present' as an upper bound makes sense.
> Update Copyright year
> --
>
> Key: DIRAPI-397
> URL: https://issues.apache.org/jira/browse/DIRAPI-397
> Project: Directory Client API
> Issue Type: Improvement
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>
> Set to 2024
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org
[jira] [Commented] (DIRAPI-397) Update Copyright year
[
https://issues.apache.org/jira/browse/DIRAPI-397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823626#comment-17823626
]
Emmanuel Lécharny commented on DIRAPI-397:
--
The proposal to set the upper bound to 'present' should be fine.
Legally speaking (afaik), the upper range is useless. The idea is to 'stamp'
the original release, and optionally all the other releases.
What is important is the date from which the copyright applies. So we could
perfectly only set the first date (like 2003):
{code:java}
"The copyright notice should include the year in which you finished preparing
the release (so if you finished it in 1998 but didn't post it until 1999, use
1998). You should add the proper year for each past release; for example,
“Copyright 1998, 1999 Terry Jones” if some releases were finished in 1998 and
some were finished in 1999. If several people helped write the code, use all
their names.
For software with several releases over multiple years, it's okay to use a
range (“2008-2010”) instead of listing individual years (“2008, 2009, 2010”) if
and only if every year in the range, inclusive, really is a “copyrightable”
year that would be listed individually; and you make an explicit statement in
your documentation about this usage."
{code}
(see [The GNU copyright Notice|//www.gnu.org/licenses/gpl-howto.en.html])
But for clarity, 'present' as an upper bound makes sense.
> Update Copyright year
> --
>
> Key: DIRAPI-397
> URL: https://issues.apache.org/jira/browse/DIRAPI-397
> Project: Directory Client API
> Issue Type: Improvement
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>
> Set to 2024
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org
Re: [PR] DIRAPI-397 Update Copyright Year [directory-ldap-api]
elecharny merged PR #78: URL: https://github.com/apache/directory-ldap-api/pull/78 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For additional commands, e-mail: dev-h...@directory.apache.org
