[jira] [Created] (DIRSERVER-2397) FB.ES_COMPARING_STRINGS_WITH_EQ in ../server/xdbm/search/impl/DefaultOptimizer.java
e.bykhanova created DIRSERVER-2397:
--
Summary: FB.ES_COMPARING_STRINGS_WITH_EQ in
../server/xdbm/search/impl/DefaultOptimizer.java
Key: DIRSERVER-2397
URL: https://issues.apache.org/jira/browse/DIRSERVER-2397
Project: Directory ApacheDS
Issue Type: Bug
Affects Versions: 2.0.0.AM26
Reporter: e.bykhanova
Attachments: image-2024-03-06-21-46-08-238.png,
image-2024-03-06-21-47-20-926.png
The static analyzer has detected FB.ES_COMPARING_STRINGS_WITH_EQ: comparison of
String objects using == or != in [{_}getScopeScan(PartitionTxn,
ScopeNode)](https://github.com/apache/directory-server/blob/8c9b56bdcc0703b04b8e2dbdc4f045ed5d83a064/xdbm-partition/src/main/java/org/apache/directory/server/xdbm/search/impl/DefaultOptimizer.java#L497C2-L523C2).{_}
!image-2024-03-06-21-47-20-926.png!
The ES_COMPARING_STRINGS_WITH_EQ detector worked because in Java the ==
operator compares objects for reference equality, but not string literals
contained in these objects.
According to
[one](https://github.com/apache/directory-server/commit/cfa2152efaa693368634e5d278890f7f5d2c9914#diff-90992891001769bbc1422416e6c9fe2e0ff73afbc5660f877244f2545b95f58fL353)
of the previous commits, here we have the following logic: we excpected to get
the comparison of string literals contained in these objects.
!image-2024-03-06-21-46-08-238.png!
Using the _equals(Object)_ method here seems to be a better practice.
Found by Linux Verification Center (portal.linuxtesting.ru) with SVACE.
Author E. Bykhanova (e.bykhan...@fobos-nt.ru).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org
[jira] [Created] (DIRSTUDIO-1337) Remove gthe Kerberos part as the Directory Server does not anymore contains the lib
Emmanuel Lécharny created DIRSTUDIO-1337: Summary: Remove gthe Kerberos part as the Directory Server does not anymore contains the lib Key: DIRSTUDIO-1337 URL: https://issues.apache.org/jira/browse/DIRSTUDIO-1337 Project: Directory Studio Issue Type: Task Components: studio-apacheds Affects Versions: 2.0.0-M17 Reporter: Emmanuel Lécharny Fix For: 2.0.0-M18 ApacheDS does not anymore contain the Kerberos server. All the associated configuration should be removed from Studio. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For additional commands, e-mail: dev-h...@directory.apache.org
[jira] [Created] (DIRSERVER-2396) SIMILAR_BRANCHES in ../codec/types/PaDataType.java
e.bykhanova created DIRSERVER-2396:
--
Summary: SIMILAR_BRANCHES in ../codec/types/PaDataType.java
Key: DIRSERVER-2396
URL: https://issues.apache.org/jira/browse/DIRSERVER-2396
Project: Directory ApacheDS
Issue Type: Bug
Affects Versions: 2.0.0.AM26
Reporter: e.bykhanova
Attachments: image-2024-03-06-10-53-02-886.png,
image-2024-03-06-10-53-41-922.png
The static analyzer has detected {*}SIMILAR_BRANCHES{*}: here we have identical
branches in switch node.
The values for all cases are defined in '{_}public enum PaDataType'{_} **
(PaDataType.java:28-121). There are comments from the developer: _Constant for
the "encryption info"_ for {*}PA_ENCTYPE_INFO{*}(11) and _Constant for the
"encryption info2"_ for \{*}PA_ENCTYPE_INFO2{*}(19) - it seems that something
like "{_}Encryption info2{_}." would be more logical to use in print-function
at {_}PaDataType.java:249{_}.
!image-2024-03-06-10-53-02-886.png!
!image-2024-03-06-10-53-41-922.png!
Found by Linux Verification Center (portal.linuxtesting.ru) with SVACE.
Author E. Bykhanova (e.bykhan...@fobos-nt.ru).
h4.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org
