[jira] [Resolved] (DIRSERVER-2399) Unused variable in OperationalAttributeInterceptor.java
[ https://issues.apache.org/jira/browse/DIRSERVER-2399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emmanuel Lécharny resolved DIRSERVER-2399. -- Fix Version/s: 2.0.0.AM28 Resolution: Fixed Fixed in master. Thanks! > Unused variable in OperationalAttributeInterceptor.java > > > Key: DIRSERVER-2399 > URL: https://issues.apache.org/jira/browse/DIRSERVER-2399 > Project: Directory ApacheDS > Issue Type: Bug >Affects Versions: 2.0.0.AM27 >Reporter: Galkin Alexey >Priority: Minor > Fix For: 2.0.0.AM28 > > > PR: > [https://github.com/apache/directory-server/pull/161/commits/5130e4364998907ec845f460e5398723ecb738ed] > > The variable "topStructural", declared on page 759, is not used anywhere > > Found by Linux Verification Center (portal.linuxtesting.ru) with SVACE. > Author A. Galkin. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For additional commands, e-mail: dev-h...@directory.apache.org
[jira] [Resolved] (DIRSERVER-2398) FB.ES_COMPARING_STRINGS_WITH_EQ in ../server/core/authz/GroupCache.java
[
https://issues.apache.org/jira/browse/DIRSERVER-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Emmanuel Lécharny resolved DIRSERVER-2398.
--
Fix Version/s: 2.0.0.AM28
Resolution: Fixed
Thanks, good catch again!
Fixed in master.
> FB.ES_COMPARING_STRINGS_WITH_EQ in ../server/core/authz/GroupCache.java
> ---
>
> Key: DIRSERVER-2398
> URL: https://issues.apache.org/jira/browse/DIRSERVER-2398
> Project: Directory ApacheDS
> Issue Type: Bug
>Affects Versions: 2.0.0.AM26
>Reporter: e.bykhanova
>Priority: Major
> Fix For: 2.0.0.AM28
>
> Attachments: image-2024-03-08-10-35-42-632.png
>
>
> The static analyzer has detected FB.ES_COMPARING_STRINGS_WITH_EQ: Comparison
> of String objects using == or != in [groupModified(Dn, List, Entry,
> SchemaManager)|[https://github.com/apache/directory-server/blob/8c9b56bdcc0703b04b8e2dbdc4f045ed5d83a064/interceptors/authz/src/main/java/org/apache/directory/server/core/authz/GroupCache.java#L394-L438].]
>
> !image-2024-03-08-10-35-42-632.png!
>
> _memberAttr.getOid()_ and _modification.getAttribute().getId()_ are _two
> different instances_ of the class, so operator '{*}=='{*} will get
> '{*}false'{*} at GroupCache.java:420 even if the string literals are
> identical. Operator '{*}=='{*} {_}compares two pointers{_}, but for
> _character-by-character comparison_ of strings, it is necessary to use method
> {*}equals(){*}.
> _To confirm_ or {_}refute the verdict{_}, we consider it necessary to clarify
> with the developers if they expect _a comparison of string literals or
> pointers_ at GroupCache.java:420.
>
> Found by Linux Verification Center (portal.linuxtesting.ru) with SVACE.
> Author E. Bykhanova (e.bykhan...@fobos-nt.ru).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org
[jira] [Resolved] (DIRSERVER-2396) SIMILAR_BRANCHES in ../codec/types/PaDataType.java
[
https://issues.apache.org/jira/browse/DIRSERVER-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Emmanuel Lécharny resolved DIRSERVER-2396.
--
Fix Version/s: 2.0.0.AM28
Resolution: Fixed
Not any more part of the next release, Kerberos has been removed.
> SIMILAR_BRANCHES in ../codec/types/PaDataType.java
> --
>
> Key: DIRSERVER-2396
> URL: https://issues.apache.org/jira/browse/DIRSERVER-2396
> Project: Directory ApacheDS
> Issue Type: Bug
>Affects Versions: 2.0.0.AM26
>Reporter: e.bykhanova
>Priority: Trivial
> Fix For: 2.0.0.AM28
>
> Attachments: image-2024-03-06-10-53-02-886.png,
> image-2024-03-06-10-53-41-922.png
>
>
> The static analyzer has detected {*}SIMILAR_BRANCHES{*}: here we have
> identical branches in switch node.
> The values for all cases are defined in '{_}public enum PaDataType'{_} **
> (PaDataType.java:28-121). There are comments from the developer: _Constant
> for the "encryption info"_ for {*}PA_ENCTYPE_INFO{*}(11) and _Constant for
> the "encryption info2"_ for \{*}PA_ENCTYPE_INFO2{*}(19) - it seems that
> something like "{_}Encryption info2{_}." would be more logical to use in
> print-function at {_}PaDataType.java:249{_}.
>
> !image-2024-03-06-10-53-02-886.png!
>
> !image-2024-03-06-10-53-41-922.png!
>
> Found by Linux Verification Center (portal.linuxtesting.ru) with SVACE.
> Author E. Bykhanova (e.bykhan...@fobos-nt.ru).
> h4.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org
[jira] [Resolved] (DIRSERVER-2395) SIMILAR_BRANCHES in ../codec/types/PaDataType.java
[
https://issues.apache.org/jira/browse/DIRSERVER-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Emmanuel Lécharny resolved DIRSERVER-2395.
--
Fix Version/s: 2.0.0.AM28
Resolution: Fixed
The Kerberos related code has been removed from the server.
> SIMILAR_BRANCHES in ../codec/types/PaDataType.java
> --
>
> Key: DIRSERVER-2395
> URL: https://issues.apache.org/jira/browse/DIRSERVER-2395
> Project: Directory ApacheDS
> Issue Type: Bug
>Affects Versions: 2.0.0.AM26
>Reporter: e.bykhanova
>Priority: Trivial
> Fix For: 2.0.0.AM28
>
> Attachments: image-2024-03-05-18-48-50-123.png,
> image-2024-03-05-18-49-32-439.png
>
>
> The static analyzer has detected {*}SIMILAR_BRANCHES{*}: here we have
> identical branches in switch node.
> All branches in this *switch* (function '{_}public static PaDataType
> getTypeByValue(int type){_}') correspond to the values of '{_}public enum
> Datatype{_}' (PaDataType.java:28-121). In this *enum*
> {*}PA_PK_AS_REQ{*}-value corresponds to the order *14* and
> \{*}PA_PK_AS_REP{*}-value corresponds to the order \{*}15{*}. It seems that
> the developer just overlooked that _the last letter_ in the values at
> PaDataType.java:184 and PaDataType.java:186 _should be different_ - the
> parameters PA_PK_AS_REQ and PA_PK_AS_REP look quite similar :)
>
> !image-2024-03-05-18-48-50-123.png!
>
> !image-2024-03-05-18-49-32-439.png!
> Found by Linux Verification Center (portal.linuxtesting.ru) with SVACE.
> Author E. Bykhanova (e.bykhan...@fobos-nt.ru).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org
[jira] [Commented] (DIRSERVER-2394) org.apache.mina.core.write.WriteToClosedSessionException every 40-60 seconds
[
https://issues.apache.org/jira/browse/DIRSERVER-2394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17832669#comment-17832669
]
Emmanuel Lécharny commented on DIRSERVER-2394:
--
Not a bug.
It's a client session that has been shutdown and the server reacts to this fact
bu closing the TCP session on its side.
> org.apache.mina.core.write.WriteToClosedSessionException every 40-60 seconds
>
>
> Key: DIRSERVER-2394
> URL: https://issues.apache.org/jira/browse/DIRSERVER-2394
> Project: Directory ApacheDS
> Issue Type: Bug
> Components: core
>Affects Versions: 2.0.0.AM27
>Reporter: Oleksandr Andreiev
>Priority: Major
>
> I see such an exception after moving from 2.0.0.AM26 to 2.0.0.AM27.
> {{WARN [org.apache.directory.server.ldap.LdapProtocolHandler] - Unexpected
> exception forcing session to close: sending disconnect notice to client.
> org.apache.mina.core.write.WriteToClosedSessionException
> at
> org.apache.mina.core.polling.AbstractPollingIoProcessor$Processor.clearWriteRequestQueue(AbstractPollingIoProcessor.java:1192)
> at
> org.apache.mina.core.polling.AbstractPollingIoProcessor$Processor.removeNow(AbstractPollingIoProcessor.java:1153)
> at
> org.apache.mina.core.polling.AbstractPollingIoProcessor$Processor.removeSessions(AbstractPollingIoProcessor.java:864)
> at
> org.apache.mina.core.polling.AbstractPollingIoProcessor$Processor.run(AbstractPollingIoProcessor.java:694)
> at
> org.apache.mina.util.NamePreservingRunnable.run(NamePreservingRunnable.java:64)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
> at java.base/java.lang.Thread.run(Thread.java:833)
> }}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org
[jira] [Resolved] (DIRAPI-398) Release Pooled LDAP Connections when closed
[ https://issues.apache.org/jira/browse/DIRAPI-398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emmanuel Lécharny resolved DIRAPI-398. -- Fix Version/s: 2.1.7 Resolution: Fixed Thanks Brian! I committed the second proposal. > Release Pooled LDAP Connections when closed > --- > > Key: DIRAPI-398 > URL: https://issues.apache.org/jira/browse/DIRAPI-398 > Project: Directory Client API > Issue Type: Improvement >Reporter: Brian Demers >Priority: Major > Fix For: 2.1.7 > > > Connections returned from a connection pool should be "released" instead of > closed. > Ultimately the usage of a Pooled connection should be similar to a _regular_ > connection. > It can be used in a try-with-resource block, then auto closed. In the case > of a pooled connection, that `close()` call should return the connection to > the pool. > Related mailing list thread: > https://lists.apache.org/thread/jpsg6g3sfspsgfpgn30kx4orspksnzm7 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For additional commands, e-mail: dev-h...@directory.apache.org
[jira] [Resolved] (DIRSERVER-2397) FB.ES_COMPARING_STRINGS_WITH_EQ in ../server/xdbm/search/impl/DefaultOptimizer.java
[
https://issues.apache.org/jira/browse/DIRSERVER-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Emmanuel Lécharny resolved DIRSERVER-2397.
--
Fix Version/s: 2.0.0.AM28
Resolution: Fixed
Thanks and good catch!
Fixed with commit 004437a5a35c36cc128a3a2e4e5b392a8df83102
> FB.ES_COMPARING_STRINGS_WITH_EQ in
> ../server/xdbm/search/impl/DefaultOptimizer.java
> ---
>
> Key: DIRSERVER-2397
> URL: https://issues.apache.org/jira/browse/DIRSERVER-2397
> Project: Directory ApacheDS
> Issue Type: Bug
>Affects Versions: 2.0.0.AM26
>Reporter: e.bykhanova
>Priority: Major
> Fix For: 2.0.0.AM28
>
> Attachments: image-2024-03-06-21-46-08-238.png,
> image-2024-03-06-21-47-20-926.png
>
>
> The static analyzer has detected FB.ES_COMPARING_STRINGS_WITH_EQ: comparison
> of String objects using == or != in [{_}getScopeScan(PartitionTxn,
> ScopeNode)](https://github.com/apache/directory-server/blob/8c9b56bdcc0703b04b8e2dbdc4f045ed5d83a064/xdbm-partition/src/main/java/org/apache/directory/server/xdbm/search/impl/DefaultOptimizer.java#L497C2-L523C2).{_}
> !image-2024-03-06-21-47-20-926.png!
> The ES_COMPARING_STRINGS_WITH_EQ detector worked because in Java the ==
> operator compares objects for reference equality, but not string literals
> contained in these objects.
> According to
> [one](https://github.com/apache/directory-server/commit/cfa2152efaa693368634e5d278890f7f5d2c9914#diff-90992891001769bbc1422416e6c9fe2e0ff73afbc5660f877244f2545b95f58fL353)
> of the previous commits, here we have the following logic: we excpected to
> get the comparison of string literals contained in these objects.
>
> !image-2024-03-06-21-46-08-238.png!
> Using the _equals(Object)_ method here seems to be a better practice.
>
> Found by Linux Verification Center (portal.linuxtesting.ru) with SVACE.
> Author E. Bykhanova (e.bykhan...@fobos-nt.ru).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org
Re: [PR] Bump org.cyclonedx:cyclonedx-maven-plugin from 2.7.11 to 2.8.0 [directory-ldap-api]
asfgit merged PR #84: URL: https://github.com/apache/directory-ldap-api/pull/84 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For additional commands, e-mail: dev-h...@directory.apache.org
Re: [PR] Bump de.thetaphi:forbiddenapis from 3.6 to 3.7 [directory-ldap-api]
asfgit merged PR #85: URL: https://github.com/apache/directory-ldap-api/pull/85 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For additional commands, e-mail: dev-h...@directory.apache.org
Re: [PR] Bump actions/setup-java from 4.0.0 to 4.2.1 [directory-ldap-api]
asfgit merged PR #83: URL: https://github.com/apache/directory-ldap-api/pull/83 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For additional commands, e-mail: dev-h...@directory.apache.org
Re: [PR] Bump actions/checkout from 4.1.1 to 4.1.2 [directory-ldap-api]
asfgit merged PR #82: URL: https://github.com/apache/directory-ldap-api/pull/82 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For additional commands, e-mail: dev-h...@directory.apache.org
