[GitHub] [directory-scimple] erant10 commented on pull request #213: Draft: Applying Patches to resources
erant10 commented on PR #213: URL: https://github.com/apache/directory-scimple/pull/213#issuecomment-1397557528 > Related I created #233, (only the last commit is relevant) But it tries to abstract out some of the common filter logic to help folks map filters into other objects I like that change. do you think it makes sense to merge it as a separate PR, or rather include it in this one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For additional commands, e-mail: dev-h...@directory.apache.org
[GitHub] [directory-scimple] erant10 commented on pull request #213: Draft: Applying Patches to resources
erant10 commented on PR #213: URL: https://github.com/apache/directory-scimple/pull/213#issuecomment-1387484443 @bdemers Sorry for the delay, just got back from vacation :) I will take a look at your commits and add my latests changes to the branch. I'll keep you posted! and yes I agree we can definitely squash commits before merging (assuming we still want to go down this route :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For additional commands, e-mail: dev-h...@directory.apache.org
[GitHub] [directory-scimple] erant10 commented on pull request #213: Draft: Applying Patches to resources
erant10 commented on PR #213: URL: https://github.com/apache/directory-scimple/pull/213#issuecomment-1370204659 @bdemers My main concern with this implementation is that PatchHandler is coupled with InMemoryFilterExpression, which is only meant to be used with the in-memory implementation... I wonder if there is a way to abstract-ify this FilterExpression so that it can be easily modified for non-demo purposes... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For additional commands, e-mail: dev-h...@directory.apache.org
