[jira] [Commented] (DIRKRB-543) Add XDR to remote kadmin to implement addPrincipal

[Jiajia Li (JIRA)]

[ 
https://issues.apache.org/jira/browse/DIRKRB-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15255933#comment-15255933
 ] 

Jiajia Li commented on DIRKRB-543:
--

Thanks for the great work, looking forward to successfully pass the add 
principal feature test.
commit c1e324d73fecab2d8e3e4203bd8d42172830a1dc
Author: plusplusjiajia 
Date:   Mon Apr 25 13:54:32 2016 +0800

DIRKRB-543 Add XDR to remote kadmin to implement addPrincipal. Contributed 
by Yan.


> Add XDR to remote kadmin to implement addPrincipal
> --
>
> Key: DIRKRB-543
> URL: https://issues.apache.org/jira/browse/DIRKRB-543
> Project: Directory Kerberos
>  Issue Type: New Feature
>Reporter: YanYan
>Assignee: YanYan
> Attachments: DIRKRB-543-v1.patch, DIRKRB-543-v2.patch, 
> DIRKRB-543-v3.patch
>
>
> Use {{XDR}} to encode  the message send from {{admin}} to {{adminServer}}, 
> mainly for {{AddPrincipal}} request.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DIRKRB-543) Add XDR to remote kadmin to implement addPrincipal

[YanYan (JIRA)]

[ 
https://issues.apache.org/jira/browse/DIRKRB-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15221396#comment-15221396
 ] 

YanYan commented on DIRKRB-543:
---

Yep, it is really a large patch:)
This is because encoding and decoding using {{XDR}} will affect both 
{{AdminServer}} and {{Admin}}, 
and in each {{Admin Request}}, such as {{AdRequest}}, {{DeRequest}}, etc.
And in addition, I add some more kinds of {{AdminRequest}} or {{AdminMessage}}, 
which makes the patch even bigger.

I think I can break it into several parts. Let me think this through and open 
some more JIRAs in specific.

About the "^M" problem, I am wondering why it didn't occur before.
I could not see it from my side, so I didn't find it out.
I'll try to avoid this.

> Add XDR to remote kadmin to implement addPrincipal
> --
>
> Key: DIRKRB-543
> URL: https://issues.apache.org/jira/browse/DIRKRB-543
> Project: Directory Kerberos
>  Issue Type: New Feature
>Reporter: YanYan
>Assignee: YanYan
> Attachments: DIRKRB-543-v1.patch
>
>
> Use {{XDR}} to encode  the message send from {{admin}} to {{adminServer}}, 
> mainly for {{AddPrincipal}} request.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DIRKRB-543) Add XDR to remote kadmin to implement addPrincipal

[Kai Zheng (JIRA)]

[ 
https://issues.apache.org/jira/browse/DIRKRB-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15221379#comment-15221379
 ] 

Kai Zheng commented on DIRKRB-543:
--

The patch looks so large, can it break down?
bq. Some files with "^M" end of the line
It's because it uses DOS format. Please dos2unix in a Linux console.

> Add XDR to remote kadmin to implement addPrincipal
> --
>
> Key: DIRKRB-543
> URL: https://issues.apache.org/jira/browse/DIRKRB-543
> Project: Directory Kerberos
>  Issue Type: New Feature
>Reporter: YanYan
>Assignee: YanYan
> Attachments: DIRKRB-543-v1.patch
>
>
> Use {{XDR}} to encode  the message send from {{admin}} to {{adminServer}}, 
> mainly for {{AddPrincipal}} request.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DIRKRB-543) Add XDR to remote kadmin to implement addPrincipal

[Jiajia Li (JIRA)]

[ 
https://issues.apache.org/jira/browse/DIRKRB-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15221350#comment-15221350
 ] 

Jiajia Li commented on DIRKRB-543:
--

Some files with "^M" end of the line, better to remove it.

> Add XDR to remote kadmin to implement addPrincipal
> --
>
> Key: DIRKRB-543
> URL: https://issues.apache.org/jira/browse/DIRKRB-543
> Project: Directory Kerberos
>  Issue Type: New Feature
>Reporter: YanYan
>Assignee: YanYan
> Attachments: DIRKRB-543-v1.patch
>
>
> Use {{XDR}} to encode  the message send from {{admin}} to {{adminServer}}, 
> mainly for {{AddPrincipal}} request.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)