[jira] [Commented] (DIRKRB-635) Backends should be optional when building kerby
[ https://issues.apache.org/jira/browse/DIRKRB-635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16098181#comment-16098181 ] Kai Zheng commented on DIRKRB-635: -- Thanks Colm! And thanks [~zenglinx] for the contribution. > Backends should be optional when building kerby > --- > > Key: DIRKRB-635 > URL: https://issues.apache.org/jira/browse/DIRKRB-635 > Project: Directory Kerberos > Issue Type: Improvement >Reporter: Lin Zeng >Assignee: Lin Zeng > Fix For: 1.0.1 > > Attachments: DIRKRB-635-01.patch, DIRKRB-635-02.patch > > > Now all the backends have been built when building kerby. It's too > time-consuming, and most users only need the json backend. > Besides the json backend, we should make backends optional in the building > phase. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (DIRKRB-635) Backends should be optional when building kerby
[ https://issues.apache.org/jira/browse/DIRKRB-635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16098068#comment-16098068 ] Colm O hEigeartaigh commented on DIRKRB-635: OK I'll defer to you on this [~drankye]. I will merge the patch. > Backends should be optional when building kerby > --- > > Key: DIRKRB-635 > URL: https://issues.apache.org/jira/browse/DIRKRB-635 > Project: Directory Kerberos > Issue Type: Improvement >Reporter: Lin Zeng >Assignee: Lin Zeng > Fix For: 1.0.1 > > Attachments: DIRKRB-635-01.patch, DIRKRB-635-02.patch > > > Now all the backends have been built when building kerby. It's too > time-consuming, and most users only need the json backend. > Besides the json backend, we should make backends optional in the building > phase. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (DIRKRB-635) Backends should be optional when building kerby
[ https://issues.apache.org/jira/browse/DIRKRB-635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096870#comment-16096870 ] Kai Zheng commented on DIRKRB-635: -- IMO "skipBackends" looks a better fit because that's what the new profile does. Why the json back end isn't skipped is because the back end is used by default for KDC integration tests and it relies on very little. > Backends should be optional when building kerby > --- > > Key: DIRKRB-635 > URL: https://issues.apache.org/jira/browse/DIRKRB-635 > Project: Directory Kerberos > Issue Type: Improvement >Reporter: Lin Zeng >Assignee: Lin Zeng > Attachments: DIRKRB-635-01.patch, DIRKRB-635-02.patch > > > Now all the backends have been built when building kerby. It's too > time-consuming, and most users only need the json backend. > Besides the json backend, we should make backends optional in the building > phase. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (DIRKRB-635) Backends should be optional when building kerby
[ https://issues.apache.org/jira/browse/DIRKRB-635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096131#comment-16096131 ] Colm O hEigeartaigh commented on DIRKRB-635: I think instead of "skipBackends" it would be clearer if the profile were called something like "jsonBackend". > Backends should be optional when building kerby > --- > > Key: DIRKRB-635 > URL: https://issues.apache.org/jira/browse/DIRKRB-635 > Project: Directory Kerberos > Issue Type: Improvement >Reporter: Lin Zeng >Assignee: Lin Zeng > Attachments: DIRKRB-635-01.patch, DIRKRB-635-02.patch > > > Now all the backends have been built when building kerby. It's too > time-consuming, and most users only need the json backend. > Besides the json backend, we should make backends optional in the building > phase. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (DIRKRB-635) Backends should be optional when building kerby
[ https://issues.apache.org/jira/browse/DIRKRB-635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094538#comment-16094538 ] Kai Zheng commented on DIRKRB-635: -- I wonder if there are any usages for some back ends. IMO, they were made in too early before matured, and nobody maintains them. For new contributors, why is it unnecessarily hard to get a good start? bq. The default profile must build everything though. I agree with your point and could appreciate more if it wasn't a must :). > Backends should be optional when building kerby > --- > > Key: DIRKRB-635 > URL: https://issues.apache.org/jira/browse/DIRKRB-635 > Project: Directory Kerberos > Issue Type: Improvement >Reporter: Lin Zeng >Assignee: Lin Zeng > Attachments: DIRKRB-635-01.patch > > > Now all the backends have been built when building kerby. It's too > time-consuming, and most users only need the json backend. > Besides the json backend, we should make backends optional in the building > phase. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (DIRKRB-635) Backends should be optional when building kerby
[ https://issues.apache.org/jira/browse/DIRKRB-635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094467#comment-16094467 ] Colm O hEigeartaigh commented on DIRKRB-635: There are Apache projects that take many hours to go through the build/test cycle :-) As I said above, I'm fine with adding profiles to only build particular backends. The default profile must build everything though. > Backends should be optional when building kerby > --- > > Key: DIRKRB-635 > URL: https://issues.apache.org/jira/browse/DIRKRB-635 > Project: Directory Kerberos > Issue Type: Improvement >Reporter: Lin Zeng >Assignee: Lin Zeng > Attachments: DIRKRB-635-01.patch > > > Now all the backends have been built when building kerby. It's too > time-consuming, and most users only need the json backend. > Besides the json backend, we should make backends optional in the building > phase. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (DIRKRB-635) Backends should be optional when building kerby
[ https://issues.apache.org/jira/browse/DIRKRB-635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094461#comment-16094461 ] Lin Zeng commented on DIRKRB-635: - Hi [~coheigea], in China, maven download dependencies spend too much time. In my test, all the dependencies have been downloaded. And if not, it will takes more than 7 minutes. > Backends should be optional when building kerby > --- > > Key: DIRKRB-635 > URL: https://issues.apache.org/jira/browse/DIRKRB-635 > Project: Directory Kerberos > Issue Type: Improvement >Reporter: Lin Zeng >Assignee: Lin Zeng > Attachments: DIRKRB-635-01.patch > > > Now all the backends have been built when building kerby. It's too > time-consuming, and most users only need the json backend. > Besides the json backend, we should make backends optional in the building > phase. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (DIRKRB-635) Backends should be optional when building kerby
[ https://issues.apache.org/jira/browse/DIRKRB-635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094456#comment-16094456 ] Lin Zeng commented on DIRKRB-635: - Thanks [~Kai Zheng] for comment, I updated the test result. > Backends should be optional when building kerby > --- > > Key: DIRKRB-635 > URL: https://issues.apache.org/jira/browse/DIRKRB-635 > Project: Directory Kerberos > Issue Type: Improvement >Reporter: Lin Zeng >Assignee: Lin Zeng > Attachments: DIRKRB-635-01.patch > > > Now all the backends have been built when building kerby. It's too > time-consuming, and most users only need the json backend. > Besides the json backend, we should make backends optional in the building > phase. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (DIRKRB-635) Backends should be optional when building kerby
[ https://issues.apache.org/jira/browse/DIRKRB-635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094405#comment-16094405 ] Colm O hEigeartaigh commented on DIRKRB-635: I don't really agree with the reasoning behind this patch...it takes just over 3 minutes on my machine to build all of the modules and run the tests. At the very least, all of the modules should be built by default, and you could add the optional profiles to only build some of the backends if required. Colm. > Backends should be optional when building kerby > --- > > Key: DIRKRB-635 > URL: https://issues.apache.org/jira/browse/DIRKRB-635 > Project: Directory Kerberos > Issue Type: Improvement >Reporter: Lin Zeng >Assignee: Lin Zeng > Attachments: DIRKRB-635-01.patch > > > Now all the backends have been built when building kerby. It's too > time-consuming, and most users only need the json backend. > Besides the json backend, we should make backends optional in the building > phase. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (DIRKRB-635) Backends should be optional when building kerby
[ https://issues.apache.org/jira/browse/DIRKRB-635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094264#comment-16094264 ] Kai Zheng commented on DIRKRB-635: -- Hi [~zenglinx], great to see the approach. Maybe you could post the results there directly, or how much time saved if we can use the default profile not building the backends? Thanks. > Backends should be optional when building kerby > --- > > Key: DIRKRB-635 > URL: https://issues.apache.org/jira/browse/DIRKRB-635 > Project: Directory Kerberos > Issue Type: Improvement >Reporter: Lin Zeng >Assignee: Lin Zeng > Attachments: DIRKRB-635-01.patch > > > Now all the backends have been built when building kerby. It's too > time-consuming, and most users only need the json backend. > Besides the json backend, we should make backends optional in the building > phase. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (DIRKRB-635) Backends should be optional when building kerby
[ https://issues.apache.org/jira/browse/DIRKRB-635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094184#comment-16094184 ] Lin Zeng commented on DIRKRB-635: - I test the build time when building the json backend or all the backends, the result like following: * json backend: https://photos.app.goo.gl/1iQW3H0xtb3SdDPJ3 * all backends: !https://photos.app.goo.gl/3JFBLdxVaYLYGyct1! > Backends should be optional when building kerby > --- > > Key: DIRKRB-635 > URL: https://issues.apache.org/jira/browse/DIRKRB-635 > Project: Directory Kerberos > Issue Type: Improvement >Reporter: Lin Zeng >Assignee: Lin Zeng > Attachments: DIRKRB-635-01.patch > > > Now all the backends have been built when building kerby. It's too > time-consuming, and most users only need the json backend. > Besides the json backend, we should make backends optional in the building > phase. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
