[jira] [Updated] (DL-107) Added unregistering gauges for distributedlog-core and distributedlog-benchmark

2016-12-20 Thread Sijie Guo (JIRA) 

 [ 
https://issues.apache.org/jira/browse/DL-107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sijie Guo updated DL-107:
-
Assignee: Philip Su

> Added unregistering gauges for distributedlog-core and 
> distributedlog-benchmark
> ---
>
> Key: DL-107
> URL: https://issues.apache.org/jira/browse/DL-107
> Project: DistributedLog
>  Issue Type: Bug
>  Components: distributedlog-core
>Reporter: Sijie Guo
>Assignee: Philip Su
> Fix For: 0.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (DL-86) Improve handling of lock conflicts in zk session lock

2016-12-20 Thread Sijie Guo (JIRA) 

 [ 
https://issues.apache.org/jira/browse/DL-86?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sijie Guo resolved DL-86.
-
Resolution: Fixed

> Improve handling of lock conflicts in zk session lock
> -
>
> Key: DL-86
> URL: https://issues.apache.org/jira/browse/DL-86
> Project: DistributedLog
>  Issue Type: Improvement
>  Components: distributedlog-core
>Reporter: Sijie Guo
>Assignee: Sijie Guo
> Fix For: 0.4.0
>
>
> - lock reacquire could happen in foreground and background thread. so use a 
> semaphore to make sure there is only on e  outstanding  acquire 
> operation. and  check if already hold lock before reacquire.
> - fix handling zk sibling znode logic. as the znode is sequential znode, 
> the name would be different each time. so onlycomparing the client id and 
> session id of the znodes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (DL-123) Every tests should have timeout

2016-12-20 Thread Sijie Guo (JIRA) 

 [ 
https://issues.apache.org/jira/browse/DL-123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sijie Guo resolved DL-123.
--
   Resolution: Fixed
Fix Version/s: 0.4.0

Thank you [~boyork]

> Every tests should have timeout
> ---
>
> Key: DL-123
> URL: https://issues.apache.org/jira/browse/DL-123
> Project: DistributedLog
>  Issue Type: Bug
>Reporter: Gerrit Sundaram
>Assignee: Brennon York
>  Labels: help-wanted
> Fix For: 0.4.0
>
>
> Currently not every test has timeout value.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (DL-89) add flag to enable thrift mux on DL monitor service

2016-12-20 Thread Sijie Guo (JIRA) 

 [ 
https://issues.apache.org/jira/browse/DL-89?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sijie Guo resolved DL-89.
-
Resolution: Fixed

> add flag to enable thrift mux on DL monitor service
> ---
>
> Key: DL-89
> URL: https://issues.apache.org/jira/browse/DL-89
> Project: DistributedLog
>  Issue Type: Bug
>  Components: distributedlog-service
>Reporter: Sijie Guo
>Assignee: David Rusek
> Fix For: 0.4.0
>
>
> provide the ability to enable thriftmux on monitor service



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (DL-87) Introduce periodic keepalive control record in writer

2016-12-20 Thread Sijie Guo (JIRA) 

 [ 
https://issues.apache.org/jira/browse/DL-87?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sijie Guo resolved DL-87.
-
Resolution: Fixed

> Introduce periodic keepalive control record in writer
> -
>
> Key: DL-87
> URL: https://issues.apache.org/jira/browse/DL-87
> Project: DistributedLog
>  Issue Type: New Feature
>Reporter: Sijie Guo
>Assignee: Leigh Stewart
> Fix For: 0.4.0
>
>
> the writer will periodically write 'keepalive' control record to make sure 
> the stream is alive. so if the write proxy is disconnected from bookies, the 
> control record will fail to write hence write proxy gets a chance to drop the 
> ownership.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (DL-88) remove watches when unregister children watches

2016-12-20 Thread Sijie Guo (JIRA) 

 [ 
https://issues.apache.org/jira/browse/DL-88?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sijie Guo resolved DL-88.
-
Resolution: Fixed

> remove watches when unregister children watches
> ---
>
> Key: DL-88
> URL: https://issues.apache.org/jira/browse/DL-88
> Project: DistributedLog
>  Issue Type: New Feature
>  Components: distributedlog-core
>Reporter: Sijie Guo
>Assignee: Sijie Guo
> Fix For: 0.4.0
>
>
> use the new zk removeWatches api to remove watchers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (DL-122) Use assertions from Junit rather than assert() for tests

2016-12-20 Thread Sijie Guo (JIRA) 

 [ 
https://issues.apache.org/jira/browse/DL-122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sijie Guo resolved DL-122.
--
   Resolution: Fixed
Fix Version/s: 0.4.0

[~boyork] thank you for your contribution.

> Use assertions from Junit rather than assert() for tests
> 
>
> Key: DL-122
> URL: https://issues.apache.org/jira/browse/DL-122
> Project: DistributedLog
>  Issue Type: Bug
>  Components: distributedlog-core
>Reporter: Gerrit Sundaram
>Assignee: Brennon York
> Fix For: 0.4.0
>
>
> there are too many places in test using 'assert()' rather than using 
> assertions from junit. it would be good that we can change that.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DL-28) generate java code failed using scrooge

2016-12-20 Thread Sijie Guo (JIRA) 

[ 
https://issues.apache.org/jira/browse/DL-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15765842#comment-15765842
 ] 

Sijie Guo commented on DL-28:
-

[~JoshuaAndrew] [~fonan] can you check if it addresses your issue?

> generate java code failed using scrooge
> ---
>
> Key: DL-28
> URL: https://issues.apache.org/jira/browse/DL-28
> Project: DistributedLog
>  Issue Type: Bug
>  Components: distributedlog-protocol
>Affects Versions: 0.4.0
> Environment: Apache Maven 3.2.5
> Maven home: C:\apache-maven-3.2.5
> Java version: 1.8.0_60, vendor: Oracle Corporation
> Java home: C:\Java\jdk1.8.0_60\jre
> Default locale: zh_CN, platform encoding: UTF-8
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "dos"
>Reporter: weiwei
>Assignee: Liang Xie
>Priority: Blocker
>  Labels: build
> Fix For: 0.4.0
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] distributedlog . SUCCESS [  0.002 
> s]
> [INFO] DistributedLog Protocol  FAILURE [  1.081 
> s]
> [INFO] DistributedLog Core Library  SKIPPED
> [INFO] DistributedLog Client .. SKIPPED
> [INFO] DistributedLog Service . SKIPPED
> [INFO] DistributedLog Benchmark ... SKIPPED
> [INFO] DistributedLog Example . SKIPPED
> [INFO] DistributedLog Basics .. SKIPPED
> [INFO] DistributedLog Messaging Tutorial .. SKIPPED
> [INFO] DistributedLog Kafka Tutorial .. SKIPPED
> [INFO] DistributedLog MapReduce ... SKIPPED
> [INFO] DistributedLog Tutorials ... SKIPPED
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 1.321 s
> [INFO] Finished at: 2016-08-02T13:26:31+08:00
> [INFO] Final Memory: 12M/150M
> [INFO] 
> 
> [ERROR] Exception parsing: 
> E:\incubator-distributedlog\distributedlog-protocol\src\main\thrift\service.thrift:
>  [3.1] failure: string matching regex `\z' expected but `/' found
> [ERROR] 
> [ERROR] // Response stats codes
> [ERROR] 
> [ERROR] ^
> [ERROR] -> [Help 1]
> com.twitter.scrooge.frontend.FileParseException: Exception parsing: 
> E:\isoftstone\workspacedeis\incubator-distributedlog\distributedlog-protocol\src\main\thrift\service.thrift
>   at 
> com.twitter.scrooge.frontend.ThriftParser$$anonfun$parse$1.apply(ThriftParser.scala:427)
>   at 
> com.twitter.scrooge.frontend.ThriftParser$$anonfun$parse$1.apply(ThriftParser.scala:427)
>   at scala.Option.map(Option.scala:145)
>   at 
> com.twitter.scrooge.frontend.ThriftParser.parse(ThriftParser.scala:420)
>   at 
> com.twitter.scrooge.frontend.ThriftParser.parseFile(ThriftParser.scala:448)
>   at com.twitter.scrooge.Compiler$$anonfun$run$2.apply(Compiler.scala:66)
>   at com.twitter.scrooge.Compiler$$anonfun$run$2.apply(Compiler.scala:64)
>   at scala.collection.immutable.List.foreach(List.scala:318)
>   at 
> scala.collection.generic.TraversableForwarder$class.foreach(TraversableForwarder.scala:32)
>   at scala.collection.mutable.ListBuffer.foreach(ListBuffer.scala:45)
>   at com.twitter.scrooge.Compiler.run(Compiler.scala:64)
>   at com.twitter.ScroogeRunner.compile(ScroogeRunner.scala:45)
>   at 
> com.twitter.AbstractMavenScroogeMojo.execute(AbstractMavenScroogeMojo.java:239)
>   at 
> com.twitter.MavenScroogeCompileMojo.execute(MavenScroogeCompileMojo.java:22)
>   at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:132)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
>   at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:120)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:355)
>   at

[jira] [Resolved] (DL-28) generate java code failed using scrooge

2016-12-20 Thread Sijie Guo (JIRA) 

 [ 
https://issues.apache.org/jira/browse/DL-28?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sijie Guo resolved DL-28.
-
Resolution: Fixed

Thanks [~xieliang007] for the fix.

> generate java code failed using scrooge
> ---
>
> Key: DL-28
> URL: https://issues.apache.org/jira/browse/DL-28
> Project: DistributedLog
>  Issue Type: Bug
>  Components: distributedlog-protocol
>Affects Versions: 0.4.0
> Environment: Apache Maven 3.2.5
> Maven home: C:\apache-maven-3.2.5
> Java version: 1.8.0_60, vendor: Oracle Corporation
> Java home: C:\Java\jdk1.8.0_60\jre
> Default locale: zh_CN, platform encoding: UTF-8
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "dos"
>Reporter: weiwei
>Assignee: Liang Xie
>Priority: Blocker
>  Labels: build
> Fix For: 0.4.0
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] distributedlog . SUCCESS [  0.002 
> s]
> [INFO] DistributedLog Protocol  FAILURE [  1.081 
> s]
> [INFO] DistributedLog Core Library  SKIPPED
> [INFO] DistributedLog Client .. SKIPPED
> [INFO] DistributedLog Service . SKIPPED
> [INFO] DistributedLog Benchmark ... SKIPPED
> [INFO] DistributedLog Example . SKIPPED
> [INFO] DistributedLog Basics .. SKIPPED
> [INFO] DistributedLog Messaging Tutorial .. SKIPPED
> [INFO] DistributedLog Kafka Tutorial .. SKIPPED
> [INFO] DistributedLog MapReduce ... SKIPPED
> [INFO] DistributedLog Tutorials ... SKIPPED
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 1.321 s
> [INFO] Finished at: 2016-08-02T13:26:31+08:00
> [INFO] Final Memory: 12M/150M
> [INFO] 
> 
> [ERROR] Exception parsing: 
> E:\incubator-distributedlog\distributedlog-protocol\src\main\thrift\service.thrift:
>  [3.1] failure: string matching regex `\z' expected but `/' found
> [ERROR] 
> [ERROR] // Response stats codes
> [ERROR] 
> [ERROR] ^
> [ERROR] -> [Help 1]
> com.twitter.scrooge.frontend.FileParseException: Exception parsing: 
> E:\isoftstone\workspacedeis\incubator-distributedlog\distributedlog-protocol\src\main\thrift\service.thrift
>   at 
> com.twitter.scrooge.frontend.ThriftParser$$anonfun$parse$1.apply(ThriftParser.scala:427)
>   at 
> com.twitter.scrooge.frontend.ThriftParser$$anonfun$parse$1.apply(ThriftParser.scala:427)
>   at scala.Option.map(Option.scala:145)
>   at 
> com.twitter.scrooge.frontend.ThriftParser.parse(ThriftParser.scala:420)
>   at 
> com.twitter.scrooge.frontend.ThriftParser.parseFile(ThriftParser.scala:448)
>   at com.twitter.scrooge.Compiler$$anonfun$run$2.apply(Compiler.scala:66)
>   at com.twitter.scrooge.Compiler$$anonfun$run$2.apply(Compiler.scala:64)
>   at scala.collection.immutable.List.foreach(List.scala:318)
>   at 
> scala.collection.generic.TraversableForwarder$class.foreach(TraversableForwarder.scala:32)
>   at scala.collection.mutable.ListBuffer.foreach(ListBuffer.scala:45)
>   at com.twitter.scrooge.Compiler.run(Compiler.scala:64)
>   at com.twitter.ScroogeRunner.compile(ScroogeRunner.scala:45)
>   at 
> com.twitter.AbstractMavenScroogeMojo.execute(AbstractMavenScroogeMojo.java:239)
>   at 
> com.twitter.MavenScroogeCompileMojo.execute(MavenScroogeCompileMojo.java:22)
>   at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:132)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
>   at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:120)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:355)
>   at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:155)
>   at

[jira] [Updated] (DL-28) generate java code failed using scrooge

2016-12-20 Thread Sijie Guo (JIRA) 

 [ 
https://issues.apache.org/jira/browse/DL-28?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sijie Guo updated DL-28:

Assignee: Liang Xie  (was: Sijie Guo)

> generate java code failed using scrooge
> ---
>
> Key: DL-28
> URL: https://issues.apache.org/jira/browse/DL-28
> Project: DistributedLog
>  Issue Type: Bug
>  Components: distributedlog-protocol
>Affects Versions: 0.4.0
> Environment: Apache Maven 3.2.5
> Maven home: C:\apache-maven-3.2.5
> Java version: 1.8.0_60, vendor: Oracle Corporation
> Java home: C:\Java\jdk1.8.0_60\jre
> Default locale: zh_CN, platform encoding: UTF-8
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "dos"
>Reporter: weiwei
>Assignee: Liang Xie
>Priority: Blocker
>  Labels: build
> Fix For: 0.4.0
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] distributedlog . SUCCESS [  0.002 
> s]
> [INFO] DistributedLog Protocol  FAILURE [  1.081 
> s]
> [INFO] DistributedLog Core Library  SKIPPED
> [INFO] DistributedLog Client .. SKIPPED
> [INFO] DistributedLog Service . SKIPPED
> [INFO] DistributedLog Benchmark ... SKIPPED
> [INFO] DistributedLog Example . SKIPPED
> [INFO] DistributedLog Basics .. SKIPPED
> [INFO] DistributedLog Messaging Tutorial .. SKIPPED
> [INFO] DistributedLog Kafka Tutorial .. SKIPPED
> [INFO] DistributedLog MapReduce ... SKIPPED
> [INFO] DistributedLog Tutorials ... SKIPPED
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 1.321 s
> [INFO] Finished at: 2016-08-02T13:26:31+08:00
> [INFO] Final Memory: 12M/150M
> [INFO] 
> 
> [ERROR] Exception parsing: 
> E:\incubator-distributedlog\distributedlog-protocol\src\main\thrift\service.thrift:
>  [3.1] failure: string matching regex `\z' expected but `/' found
> [ERROR] 
> [ERROR] // Response stats codes
> [ERROR] 
> [ERROR] ^
> [ERROR] -> [Help 1]
> com.twitter.scrooge.frontend.FileParseException: Exception parsing: 
> E:\isoftstone\workspacedeis\incubator-distributedlog\distributedlog-protocol\src\main\thrift\service.thrift
>   at 
> com.twitter.scrooge.frontend.ThriftParser$$anonfun$parse$1.apply(ThriftParser.scala:427)
>   at 
> com.twitter.scrooge.frontend.ThriftParser$$anonfun$parse$1.apply(ThriftParser.scala:427)
>   at scala.Option.map(Option.scala:145)
>   at 
> com.twitter.scrooge.frontend.ThriftParser.parse(ThriftParser.scala:420)
>   at 
> com.twitter.scrooge.frontend.ThriftParser.parseFile(ThriftParser.scala:448)
>   at com.twitter.scrooge.Compiler$$anonfun$run$2.apply(Compiler.scala:66)
>   at com.twitter.scrooge.Compiler$$anonfun$run$2.apply(Compiler.scala:64)
>   at scala.collection.immutable.List.foreach(List.scala:318)
>   at 
> scala.collection.generic.TraversableForwarder$class.foreach(TraversableForwarder.scala:32)
>   at scala.collection.mutable.ListBuffer.foreach(ListBuffer.scala:45)
>   at com.twitter.scrooge.Compiler.run(Compiler.scala:64)
>   at com.twitter.ScroogeRunner.compile(ScroogeRunner.scala:45)
>   at 
> com.twitter.AbstractMavenScroogeMojo.execute(AbstractMavenScroogeMojo.java:239)
>   at 
> com.twitter.MavenScroogeCompileMojo.execute(MavenScroogeCompileMojo.java:22)
>   at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:132)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
>   at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:120)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:355)
>   at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:155)
>   at

[jira] [Closed] (DL-126) Fix the url of distributedlog blog post

2016-12-20 Thread Sijie Guo (JIRA) 

 [ 
https://issues.apache.org/jira/browse/DL-126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sijie Guo closed DL-126.

Resolution: Fixed

> Fix the url of distributedlog blog post
> ---
>
> Key: DL-126
> URL: https://issues.apache.org/jira/browse/DL-126
> Project: DistributedLog
>  Issue Type: Bug
>  Components: website
>Reporter: Sijie Guo
>Assignee: Sijie Guo
> Fix For: 0.4.0
>
>
> The URL states 2015. It should be 2016.
> http://distributedlog.incubator.apache.org/technical-review/2015/09/19/kafka-vs-distributedlog



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (DL-91) Be able to close writer within a timeout duration

2016-12-20 Thread Sijie Guo (JIRA) 

 [ 
https://issues.apache.org/jira/browse/DL-91?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sijie Guo closed DL-91.
---
   Resolution: Fixed
Fix Version/s: 0.4.0

> Be able to close writer within a timeout duration
> -
>
> Key: DL-91
> URL: https://issues.apache.org/jira/browse/DL-91
> Project: DistributedLog
>  Issue Type: Bug
>  Components: distributedlog-client
>Reporter: Sijie Guo
>Assignee: Leigh Stewart
> Fix For: 0.4.0
>
>
> If a stream is hanging on closing the writer on write proxy, it will cause 
> STEAM_UNAVAILABLE.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (DL-136) Avoid empty catch blocks

2016-12-20 Thread Sijie Guo (JIRA) 

 [ 
https://issues.apache.org/jira/browse/DL-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sijie Guo resolved DL-136.
--
Resolution: Fixed

> Avoid empty catch blocks
> 
>
> Key: DL-136
> URL: https://issues.apache.org/jira/browse/DL-136
> Project: DistributedLog
>  Issue Type: Task
>Reporter: Sijie Guo
>Assignee: Brennon York
>  Labels: help-wanted
> Fix For: 0.4.0
>
>
> Based on the code analysis here : 
> https://www.kiuwan.com/blog/analyzing_distributedlog_twitter-2/, there are 22 
> Times: Catching exceptions with empty bodies.
> {quote}
> There are exceptions of different types: InterruptedException, 
> KeeperException, Exception, etc.. Even though we think that these exceptions 
> should never occur, if they are captured it means that they are technically 
> possible. In case that they do happen, it will be very difficult to know what 
> is happening and to diagnose the problem. It is very recommendable, at least 
> to add a log trace, in case these exceptions are triggered.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Reopened] (DL-136) Avoid empty catch blocks

2016-12-20 Thread Sijie Guo (JIRA) 

 [ 
https://issues.apache.org/jira/browse/DL-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sijie Guo reopened DL-136:
--

> Avoid empty catch blocks
> 
>
> Key: DL-136
> URL: https://issues.apache.org/jira/browse/DL-136
> Project: DistributedLog
>  Issue Type: Task
>Reporter: Sijie Guo
>Assignee: Brennon York
>  Labels: help-wanted
> Fix For: 0.4.0
>
>
> Based on the code analysis here : 
> https://www.kiuwan.com/blog/analyzing_distributedlog_twitter-2/, there are 22 
> Times: Catching exceptions with empty bodies.
> {quote}
> There are exceptions of different types: InterruptedException, 
> KeeperException, Exception, etc.. Even though we think that these exceptions 
> should never occur, if they are captured it means that they are technically 
> possible. In case that they do happen, it will be very difficult to know what 
> is happening and to diagnose the problem. It is very recommendable, at least 
> to add a log trace, in case these exceptions are triggered.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DL-129) Enable check style for distributedlog-protocol module

2016-12-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DL-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15765730#comment-15765730
 ] 

ASF GitHub Bot commented on DL-129:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-distributedlog/pull/54


> Enable check style for distributedlog-protocol module
> -
>
> Key: DL-129
> URL: https://issues.apache.org/jira/browse/DL-129
> Project: DistributedLog
>  Issue Type: Sub-task
>  Components: distributedlog-protocol
>Reporter: Xi Liu
>Assignee: Xi Liu
> Fix For: 0.4.0
>
>
> Enable check style plugin for distributedlog-protocol module



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (DL-129) Enable check style for distributedlog-protocol module

2016-12-20 Thread Sijie Guo (JIRA) 

 [ 
https://issues.apache.org/jira/browse/DL-129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sijie Guo resolved DL-129.
--
Resolution: Fixed

Merged the pull request. [~xi.liu.ant] Thank you for your contribution.

> Enable check style for distributedlog-protocol module
> -
>
> Key: DL-129
> URL: https://issues.apache.org/jira/browse/DL-129
> Project: DistributedLog
>  Issue Type: Sub-task
>  Components: distributedlog-protocol
>Reporter: Xi Liu
>Assignee: Xi Liu
> Fix For: 0.4.0
>
>
> Enable check style plugin for distributedlog-protocol module



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[1/3] incubator-distributedlog git commit: DL-129: Enable checkstyle plugin for distributedlog-protocol module

2016-12-20 Thread sijie 
Repository: incubator-distributedlog
Updated Branches:
  refs/heads/master 26942a91a -> 3bd162027


http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/blob/3bd16202/distributedlog-protocol/src/main/java/com/twitter/distributedlog/exceptions/LogRecordTooLongException.java
--
diff --git 
a/distributedlog-protocol/src/main/java/com/twitter/distributedlog/exceptions/LogRecordTooLongException.java
 
b/distributedlog-protocol/src/main/java/com/twitter/distributedlog/exceptions/LogRecordTooLongException.java
index 0521133..76a1aa2 100644
--- 
a/distributedlog-protocol/src/main/java/com/twitter/distributedlog/exceptions/LogRecordTooLongException.java
+++ 
b/distributedlog-protocol/src/main/java/com/twitter/distributedlog/exceptions/LogRecordTooLongException.java
@@ -19,6 +19,11 @@ package com.twitter.distributedlog.exceptions;
 
 import com.twitter.distributedlog.thrift.service.StatusCode;
 
+/**
+ * Exception is thrown when attempting to write a record whose size is too 
larger.
+ *
+ * The size limit of a log record is {@link 
com.twitter.distributedlog.LogRecord#MAX_LOGRECORD_SIZE}.
+ */
 public class LogRecordTooLongException extends DLException {
 
 private static final long serialVersionUID = 2788274084603111386L;

http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/blob/3bd16202/distributedlog-protocol/src/main/java/com/twitter/distributedlog/exceptions/MetadataException.java
--
diff --git 
a/distributedlog-protocol/src/main/java/com/twitter/distributedlog/exceptions/MetadataException.java
 
b/distributedlog-protocol/src/main/java/com/twitter/distributedlog/exceptions/MetadataException.java
index 76ab573..cb62e7c 100644
--- 
a/distributedlog-protocol/src/main/java/com/twitter/distributedlog/exceptions/MetadataException.java
+++ 
b/distributedlog-protocol/src/main/java/com/twitter/distributedlog/exceptions/MetadataException.java
@@ -19,6 +19,9 @@ package com.twitter.distributedlog.exceptions;
 
 import com.twitter.distributedlog.thrift.service.StatusCode;
 
+/**
+ * Exception is thrown when encountering metadata errors.
+ */
 public class MetadataException extends DLException {
 
 private static final long serialVersionUID = 6683578078046016125L;

http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/blob/3bd16202/distributedlog-protocol/src/main/java/com/twitter/distributedlog/exceptions/NotYetImplementedException.java
--
diff --git 
a/distributedlog-protocol/src/main/java/com/twitter/distributedlog/exceptions/NotYetImplementedException.java
 
b/distributedlog-protocol/src/main/java/com/twitter/distributedlog/exceptions/NotYetImplementedException.java
index 7c703e4..04edb01 100644
--- 
a/distributedlog-protocol/src/main/java/com/twitter/distributedlog/exceptions/NotYetImplementedException.java
+++ 
b/distributedlog-protocol/src/main/java/com/twitter/distributedlog/exceptions/NotYetImplementedException.java
@@ -19,6 +19,9 @@ package com.twitter.distributedlog.exceptions;
 
 import com.twitter.distributedlog.thrift.service.StatusCode;
 
+/**
+ * Exception is thrown when a method is not implemented yet.
+ */
 public class NotYetImplementedException extends DLException {
 
 private static final long serialVersionUID = -6002036746792556106L;

http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/blob/3bd16202/distributedlog-protocol/src/main/java/com/twitter/distributedlog/exceptions/OverCapacityException.java
--
diff --git 
a/distributedlog-protocol/src/main/java/com/twitter/distributedlog/exceptions/OverCapacityException.java
 
b/distributedlog-protocol/src/main/java/com/twitter/distributedlog/exceptions/OverCapacityException.java
index ab46f64..d564758 100644
--- 
a/distributedlog-protocol/src/main/java/com/twitter/distributedlog/exceptions/OverCapacityException.java
+++ 
b/distributedlog-protocol/src/main/java/com/twitter/distributedlog/exceptions/OverCapacityException.java
@@ -19,6 +19,12 @@ package com.twitter.distributedlog.exceptions;
 
 import com.twitter.distributedlog.thrift.service.StatusCode;
 
+/**
+ * Exception is thrown when the system is over capacity.
+ *
+ * When this exception is received, the client (either writer or reader) 
should take actions to not
+ * overwhelm the system. For example, backoff sending any requests.
+ */
 public class OverCapacityException extends DLException {
 
 private static final long serialVersionUID = -6398949404860680263L;

http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/blob/3bd16202/distributedlog-protocol/src/main/java/com/twitter/distributedlog/exceptions/OwnershipAcquireFailedException.java
--
diff --git

[2/3] incubator-distributedlog git commit: DL-129: Enable checkstyle plugin for distributedlog-protocol module

2016-12-20 Thread sijie 
http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/blob/3bd16202/distributedlog-build-tools/src/main/resources/ide/eclipse/DL_formatter.xml
--
diff --git 
a/distributedlog-build-tools/src/main/resources/ide/eclipse/DL_formatter.xml 
b/distributedlog-build-tools/src/main/resources/ide/eclipse/DL_formatter.xml
new file mode 100644
index 000..a73e7c4
--- /dev/null
+++ b/distributedlog-build-tools/src/main/resources/ide/eclipse/DL_formatter.xml
@@ -0,0 +1,310 @@
+
+  
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+

http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/blob/3bd16202/distributedlog-protocol/pom.xml
--
diff --git a/distributedlog-protocol/pom.xml b/distributedlog-protocol/pom.xml
index 4417d14..3adae05 100644
--- a/distributedlog-protocol/pom.xml
+++ b/distributedlog-protocol/pom.xml
@@ -113,6 +113,39 @@
   
${basedir}/src/main/resources/findbugsExclude.xml
 
   
+  
+org.apache.maven.plugins
+maven-checkstyle-plugin
+2.17
+
+  
+com.puppycrawl.tools
+checkstyle
+6.19
+  
+  
+com.twitter
+distributedlog-build-tools
+${project.version}
+  
+
+
+  distributedlog/checkstyle.xml
+  
distributedlog/suppressions.xml
+  true
+  true
+  false
+  true
+
+
+  
+test-compile
+
+  check
+
+  
+
+  
 
   
 

http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/blob/3bd16202/distributedlog-protocol/src/main/java/com/twitter/distributedlog/DLSN.java
--
diff --git 
a/distributedlog-protocol/src/main/java/com/twitter/distributedlog/DLSN.java 
b/distributedlog-protocol/src/main/java/com/twitter/distributedlog/DLSN.java
index 9e3b76c..57cc0ef 100644
--- a/distributedlog-protocol/src/main/java/com/twitter/distributedlog/DLSN.java
+++ b/distributedlog-protocol/src/main/java/com/twitter/distributedlog/DLSN.java
@@ -17,12 +17,13 @@
  */
 package com.twitter.distributedlog;
 
+import static com.google.common.base.Preconditions.checkArgument;
+
 import com.google.common.annotations.VisibleForTesting;
-import com.google.common.base.Preconditions;
+import java.nio.ByteBuffer;
 import org.apache.commons.codec.binary.Base64;
 import org.apache.commons.codec.binary.Hex;
 
-import java.nio.ByteBuffer;
 
 /**
  * DistributedLog Sequence Number (DLSN) is the system generated sequence 
number for log record.
@@ -46,7 +47,7 @@ public class DLSN implements Comparable {
 // The non-inclusive lower bound DLSN
 public static final DLSN NonInclusiveLowerBound = new DLSN(1, 0 , -1);
 // Invalid DLSN
-public static final DLSN InvalidDLSN = new DLSN(0,-1,-1);
+public static final DLSN InvalidDLSN = new DLSN(0, -1, -1);
 
 static final byte CUR_VERSION = VERSION1;
 static final int VERSION0_LEN = Long.SIZE * 3 + Byte.SIZE;
@@ -72,14 +73,6 @@ public class DLSN implements Comparable {
 }
 
 /**
- * use {@link #getLogSegmentSequenceNo()} instead
- */
-@Deprecated
-long getLedgerSequenceNo() {
-return logSegmentSequenceNo;
-}
-
-/**
  * Return the entry id of the batch that the record is written to.
  *
  * @return entry id of the batch that the record is written to.
@@ -100,11 +93,11 @@ public class DLSN implements Comparable {
 @Override
 public int compareTo(DLSN that) {
 if (this.logSegmentSequenceNo != that.logSegmentSequenceNo) {
-return (this.logSegmentSequenceNo < that.logSegmentSequenceNo)? -1 
: 1;
+return (this.logSegmentSequenceNo < that.logSegmentSequenceNo) ? 
-1 : 1;
 } else if (this.entryId != that.entryId) {
-return (this.entryId < that.entryId)? -1 : 1;
+return (this.entryId < that.entryId) ? -1 : 1;
 } else {
-return (this.slotId < that.slotId)? -1 : (this.slotId == 
that.slotId)? 0 : 1;
+return (this.slotId < that.slotId) ? -1 : (this.slotId == 
that.slotId) ? 0 : 1;
 }
 }
 
@@ -125,7 +118,7 @@ public class DLSN implements Comparable {
  * @return the

[GitHub] incubator-distributedlog pull request #54: DL-129: Enable checkstyle plugin ...

2016-12-20 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-distributedlog/pull/54


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (DL-148) Not providing net-util 0.0.100 via 'mvn clean install -DskipTests'

2016-12-20 Thread Asko Kauppi (JIRA) 

[ 
https://issues.apache.org/jira/browse/DL-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15765450#comment-15765450
 ] 

Asko Kauppi commented on DL-148:


I think `com.twitter.common.zookeeper:client:0.0.76` is the one bringing the 
faulty 0.0.100 in.

> Not providing net-util 0.0.100 via 'mvn clean install -DskipTests'
> --
>
> Key: DL-148
> URL: https://issues.apache.org/jira/browse/DL-148
> Project: DistributedLog
>  Issue Type: Bug
>  Components: builds
>Reporter: Asko Kauppi
>Priority: Minor
>
> I was building a Scala wrapper for DistributedLog 0.4.0, and wanted to get 
> the JVM artefacts via local Maven repo.
> It works, for most of them, but the 
> `com.twitter.common#net-util;0.0.100!net-util.jar` is not available.
> Looking at `~/.m2/repository` shows that 0.0.97 has a jar but 0.0.100 doesn't.
> <<
> $ find /Users/akauppi/.m2/repository/ -name "*net-util*"
> /Users/akauppi/.m2/repository//com/twitter/common/net-util
> /Users/akauppi/.m2/repository//com/twitter/common/net-util/0.0.100/net-util-0.0.100.pom
> /Users/akauppi/.m2/repository//com/twitter/common/net-util/0.0.100/net-util-0.0.100.pom.lastUpdated
> /Users/akauppi/.m2/repository//com/twitter/common/net-util/0.0.100/net-util-0.0.100.pom.sha1
> /Users/akauppi/.m2/repository//com/twitter/common/net-util/0.0.97/net-util-0.0.97.jar
> /Users/akauppi/.m2/repository//com/twitter/common/net-util/0.0.97/net-util-0.0.97.jar.lastUpdated
> /Users/akauppi/.m2/repository//com/twitter/common/net-util/0.0.97/net-util-0.0.97.jar.sha1
> /Users/akauppi/.m2/repository//com/twitter/common/net-util/0.0.97/net-util-0.0.97.pom
> /Users/akauppi/.m2/repository//com/twitter/common/net-util/0.0.97/net-util-0.0.97.pom.lastUpdated
> /Users/akauppi/.m2/repository//com/twitter/common/net-util/0.0.97/net-util-0.0.97.pom.sha1
> <<
> My error on customer project / Scala side:
> <<
> $ sbt update
> [info] Loading global plugins from /Users/akauppi/.sbt/0.13/plugins
> [info] Loading project definition from 
> /Users/akauppi/Source/sleeves-distributedlog/project
> [info] Set current project to sleeves-distributedlog (in build 
> file:/Users/akauppi/Source/sleeves-distributedlog/)
> [info] Updating 
> {file:/Users/akauppi/Source/sleeves-distributedlog/}sleeves-distributedlog...
> [info] Resolving jline#jline;2.12.1 ...
> [info] downloading 
> https://repo1.maven.org/maven2/org/apache/zookeeper/zookeeper/3.5.1-alpha/zookeeper-3.5.1-alpha.jar
>  ...
> [info][SUCCESSFUL ] 
> org.apache.zookeeper#zookeeper;3.5.1-alpha!zookeeper.jar (680ms)
> [info] downloading 
> https://repo1.maven.org/maven2/com/twitter/util-core_2.11/6.34.0/util-core_2.11-6.34.0.jar
>  ...
> [info][SUCCESSFUL ] 
> com.twitter#util-core_2.11;6.34.0!util-core_2.11.jar (787ms)
> [info] downloading 
> https://repo1.maven.org/maven2/com/twitter/scrooge-core_2.11/4.6.0/scrooge-core_2.11-4.6.0.jar
>  ...
> [info][SUCCESSFUL ] 
> com.twitter#scrooge-core_2.11;4.6.0!scrooge-core_2.11.jar (177ms)
> [info] downloading 
> https://repo1.maven.org/maven2/commons-cli/commons-cli/1.1/commons-cli-1.1.jar
>  ...
> [info][SUCCESSFUL ] commons-cli#commons-cli;1.1!commons-cli.jar (69ms)
> [info] downloading 
> https://repo1.maven.org/maven2/log4j/log4j/1.2.16/log4j-1.2.16.jar ...
> [info][SUCCESSFUL ] log4j#log4j;1.2.16!log4j.jar(bundle) (269ms)
> [info] downloading 
> https://repo1.maven.org/maven2/net/java/dev/javacc/javacc/5.0/javacc-5.0.jar 
> ...
> [info][SUCCESSFUL ] net.java.dev.javacc#javacc;5.0!javacc.jar (200ms)
> [info] downloading 
> https://repo1.maven.org/maven2/com/google/inject/guice/3.0/guice-3.0.jar ...
> [info][SUCCESSFUL ] com.google.inject#guice;3.0!guice.jar (431ms)
> [info] downloading 
> https://repo1.maven.org/maven2/org/sonatype/sisu/inject/cglib/2.2.1-v20090111/cglib-2.2.1-v20090111.jar
>  ...
> [info][SUCCESSFUL ] 
> org.sonatype.sisu.inject#cglib;2.2.1-v20090111!cglib.jar (247ms)
> [info] downloading https://repo1.maven.org/maven2/asm/asm/3.1/asm-3.1.jar ...
> [info][SUCCESSFUL ] asm#asm;3.1!asm.jar (82ms)
> [info] downloading 
> https://repo1.maven.org/maven2/com/twitter/util-function_2.11/6.34.0/util-function_2.11-6.34.0.jar
>  ...
> [info][SUCCESSFUL ] 
> com.twitter#util-function_2.11;6.34.0!util-function_2.11.jar (160ms)
> [info] downloading 
> https://repo1.maven.org/maven2/com/twitter/jsr166e/1.0.0/jsr166e-1.0.0.jar ...
> [info][SUCCESSFUL ] com.twitter#jsr166e;1.0.0!jsr166e.jar (57ms)
> [info] downloading 
> https://repo1.maven.org/maven2/commons-configuration/commons-configuration/1.6/commons-configuration-1.6.jar
>  ...
> [info][SUCCESSFUL ] 
> commons-configuration#commons-configuration;1.6!commons-configuration.jar 
> (207ms)
> [info] downloading 
>

[jira] [Commented] (DL-148) Not providing net-util 0.0.100 via 'mvn clean install -DskipTests'

2016-12-20 Thread Sijie Guo (JIRA) 

[ 
https://issues.apache.org/jira/browse/DL-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15765384#comment-15765384
 ] 

Sijie Guo commented on DL-148:
--

[~akauppi] I think net-util is hosted at repository (http://maven.twttr.com/). 
Did you run 'mvn install' or did you configure sbt to locate maven.twttr.com?

http://mvnrepository.com/artifact/com.twitter.common/net-util/0.0.100

> Not providing net-util 0.0.100 via 'mvn clean install -DskipTests'
> --
>
> Key: DL-148
> URL: https://issues.apache.org/jira/browse/DL-148
> Project: DistributedLog
>  Issue Type: Bug
>  Components: builds
>Reporter: Asko Kauppi
>Priority: Minor
>
> I was building a Scala wrapper for DistributedLog 0.4.0, and wanted to get 
> the JVM artefacts via local Maven repo.
> It works, for most of them, but the 
> `com.twitter.common#net-util;0.0.100!net-util.jar` is not available.
> Looking at `~/.m2/repository` shows that 0.0.97 has a jar but 0.0.100 doesn't.
> <<
> $ find /Users/akauppi/.m2/repository/ -name "*net-util*"
> /Users/akauppi/.m2/repository//com/twitter/common/net-util
> /Users/akauppi/.m2/repository//com/twitter/common/net-util/0.0.100/net-util-0.0.100.pom
> /Users/akauppi/.m2/repository//com/twitter/common/net-util/0.0.100/net-util-0.0.100.pom.lastUpdated
> /Users/akauppi/.m2/repository//com/twitter/common/net-util/0.0.100/net-util-0.0.100.pom.sha1
> /Users/akauppi/.m2/repository//com/twitter/common/net-util/0.0.97/net-util-0.0.97.jar
> /Users/akauppi/.m2/repository//com/twitter/common/net-util/0.0.97/net-util-0.0.97.jar.lastUpdated
> /Users/akauppi/.m2/repository//com/twitter/common/net-util/0.0.97/net-util-0.0.97.jar.sha1
> /Users/akauppi/.m2/repository//com/twitter/common/net-util/0.0.97/net-util-0.0.97.pom
> /Users/akauppi/.m2/repository//com/twitter/common/net-util/0.0.97/net-util-0.0.97.pom.lastUpdated
> /Users/akauppi/.m2/repository//com/twitter/common/net-util/0.0.97/net-util-0.0.97.pom.sha1
> <<
> My error on customer project / Scala side:
> <<
> $ sbt update
> [info] Loading global plugins from /Users/akauppi/.sbt/0.13/plugins
> [info] Loading project definition from 
> /Users/akauppi/Source/sleeves-distributedlog/project
> [info] Set current project to sleeves-distributedlog (in build 
> file:/Users/akauppi/Source/sleeves-distributedlog/)
> [info] Updating 
> {file:/Users/akauppi/Source/sleeves-distributedlog/}sleeves-distributedlog...
> [info] Resolving jline#jline;2.12.1 ...
> [info] downloading 
> https://repo1.maven.org/maven2/org/apache/zookeeper/zookeeper/3.5.1-alpha/zookeeper-3.5.1-alpha.jar
>  ...
> [info][SUCCESSFUL ] 
> org.apache.zookeeper#zookeeper;3.5.1-alpha!zookeeper.jar (680ms)
> [info] downloading 
> https://repo1.maven.org/maven2/com/twitter/util-core_2.11/6.34.0/util-core_2.11-6.34.0.jar
>  ...
> [info][SUCCESSFUL ] 
> com.twitter#util-core_2.11;6.34.0!util-core_2.11.jar (787ms)
> [info] downloading 
> https://repo1.maven.org/maven2/com/twitter/scrooge-core_2.11/4.6.0/scrooge-core_2.11-4.6.0.jar
>  ...
> [info][SUCCESSFUL ] 
> com.twitter#scrooge-core_2.11;4.6.0!scrooge-core_2.11.jar (177ms)
> [info] downloading 
> https://repo1.maven.org/maven2/commons-cli/commons-cli/1.1/commons-cli-1.1.jar
>  ...
> [info][SUCCESSFUL ] commons-cli#commons-cli;1.1!commons-cli.jar (69ms)
> [info] downloading 
> https://repo1.maven.org/maven2/log4j/log4j/1.2.16/log4j-1.2.16.jar ...
> [info][SUCCESSFUL ] log4j#log4j;1.2.16!log4j.jar(bundle) (269ms)
> [info] downloading 
> https://repo1.maven.org/maven2/net/java/dev/javacc/javacc/5.0/javacc-5.0.jar 
> ...
> [info][SUCCESSFUL ] net.java.dev.javacc#javacc;5.0!javacc.jar (200ms)
> [info] downloading 
> https://repo1.maven.org/maven2/com/google/inject/guice/3.0/guice-3.0.jar ...
> [info][SUCCESSFUL ] com.google.inject#guice;3.0!guice.jar (431ms)
> [info] downloading 
> https://repo1.maven.org/maven2/org/sonatype/sisu/inject/cglib/2.2.1-v20090111/cglib-2.2.1-v20090111.jar
>  ...
> [info][SUCCESSFUL ] 
> org.sonatype.sisu.inject#cglib;2.2.1-v20090111!cglib.jar (247ms)
> [info] downloading https://repo1.maven.org/maven2/asm/asm/3.1/asm-3.1.jar ...
> [info][SUCCESSFUL ] asm#asm;3.1!asm.jar (82ms)
> [info] downloading 
> https://repo1.maven.org/maven2/com/twitter/util-function_2.11/6.34.0/util-function_2.11-6.34.0.jar
>  ...
> [info][SUCCESSFUL ] 
> com.twitter#util-function_2.11;6.34.0!util-function_2.11.jar (160ms)
> [info] downloading 
> https://repo1.maven.org/maven2/com/twitter/jsr166e/1.0.0/jsr166e-1.0.0.jar ...
> [info][SUCCESSFUL ] com.twitter#jsr166e;1.0.0!jsr166e.jar (57ms)
> [info] downloading 
> https://repo1.maven.org/maven2/commons-configuration/commons-configuration/1.6/commons-configuration-1.6.jar
>  ...
> [info][SUCCESSFUL ] 
>

[jira] [Created] (DL-148) Not providing net-util 0.0.100 via 'mvn clean install -DskipTests'

2016-12-20 Thread Asko Kauppi (JIRA) 
Asko Kauppi created DL-148:
--

 Summary: Not providing net-util 0.0.100 via 'mvn clean install 
-DskipTests'
 Key: DL-148
 URL: https://issues.apache.org/jira/browse/DL-148
 Project: DistributedLog
  Issue Type: Bug
  Components: builds
Reporter: Asko Kauppi
Priority: Minor


I was building a Scala wrapper for DistributedLog 0.4.0, and wanted to get the 
JVM artefacts via local Maven repo.

It works, for most of them, but the 
`com.twitter.common#net-util;0.0.100!net-util.jar` is not available.

Looking at `~/.m2/repository` shows that 0.0.97 has a jar but 0.0.100 doesn't.

<<
$ find /Users/akauppi/.m2/repository/ -name "*net-util*"
/Users/akauppi/.m2/repository//com/twitter/common/net-util
/Users/akauppi/.m2/repository//com/twitter/common/net-util/0.0.100/net-util-0.0.100.pom
/Users/akauppi/.m2/repository//com/twitter/common/net-util/0.0.100/net-util-0.0.100.pom.lastUpdated
/Users/akauppi/.m2/repository//com/twitter/common/net-util/0.0.100/net-util-0.0.100.pom.sha1
/Users/akauppi/.m2/repository//com/twitter/common/net-util/0.0.97/net-util-0.0.97.jar
/Users/akauppi/.m2/repository//com/twitter/common/net-util/0.0.97/net-util-0.0.97.jar.lastUpdated
/Users/akauppi/.m2/repository//com/twitter/common/net-util/0.0.97/net-util-0.0.97.jar.sha1
/Users/akauppi/.m2/repository//com/twitter/common/net-util/0.0.97/net-util-0.0.97.pom
/Users/akauppi/.m2/repository//com/twitter/common/net-util/0.0.97/net-util-0.0.97.pom.lastUpdated
/Users/akauppi/.m2/repository//com/twitter/common/net-util/0.0.97/net-util-0.0.97.pom.sha1
<<

My error on customer project / Scala side:

<<
$ sbt update
[info] Loading global plugins from /Users/akauppi/.sbt/0.13/plugins
[info] Loading project definition from 
/Users/akauppi/Source/sleeves-distributedlog/project
[info] Set current project to sleeves-distributedlog (in build 
file:/Users/akauppi/Source/sleeves-distributedlog/)
[info] Updating 
{file:/Users/akauppi/Source/sleeves-distributedlog/}sleeves-distributedlog...
[info] Resolving jline#jline;2.12.1 ...
[info] downloading 
https://repo1.maven.org/maven2/org/apache/zookeeper/zookeeper/3.5.1-alpha/zookeeper-3.5.1-alpha.jar
 ...
[info]  [SUCCESSFUL ] org.apache.zookeeper#zookeeper;3.5.1-alpha!zookeeper.jar 
(680ms)
[info] downloading 
https://repo1.maven.org/maven2/com/twitter/util-core_2.11/6.34.0/util-core_2.11-6.34.0.jar
 ...
[info]  [SUCCESSFUL ] com.twitter#util-core_2.11;6.34.0!util-core_2.11.jar 
(787ms)
[info] downloading 
https://repo1.maven.org/maven2/com/twitter/scrooge-core_2.11/4.6.0/scrooge-core_2.11-4.6.0.jar
 ...
[info]  [SUCCESSFUL ] com.twitter#scrooge-core_2.11;4.6.0!scrooge-core_2.11.jar 
(177ms)
[info] downloading 
https://repo1.maven.org/maven2/commons-cli/commons-cli/1.1/commons-cli-1.1.jar 
...
[info]  [SUCCESSFUL ] commons-cli#commons-cli;1.1!commons-cli.jar (69ms)
[info] downloading 
https://repo1.maven.org/maven2/log4j/log4j/1.2.16/log4j-1.2.16.jar ...
[info]  [SUCCESSFUL ] log4j#log4j;1.2.16!log4j.jar(bundle) (269ms)
[info] downloading 
https://repo1.maven.org/maven2/net/java/dev/javacc/javacc/5.0/javacc-5.0.jar ...
[info]  [SUCCESSFUL ] net.java.dev.javacc#javacc;5.0!javacc.jar (200ms)
[info] downloading 
https://repo1.maven.org/maven2/com/google/inject/guice/3.0/guice-3.0.jar ...
[info]  [SUCCESSFUL ] com.google.inject#guice;3.0!guice.jar (431ms)
[info] downloading 
https://repo1.maven.org/maven2/org/sonatype/sisu/inject/cglib/2.2.1-v20090111/cglib-2.2.1-v20090111.jar
 ...
[info]  [SUCCESSFUL ] org.sonatype.sisu.inject#cglib;2.2.1-v20090111!cglib.jar 
(247ms)
[info] downloading https://repo1.maven.org/maven2/asm/asm/3.1/asm-3.1.jar ...
[info]  [SUCCESSFUL ] asm#asm;3.1!asm.jar (82ms)
[info] downloading 
https://repo1.maven.org/maven2/com/twitter/util-function_2.11/6.34.0/util-function_2.11-6.34.0.jar
 ...
[info]  [SUCCESSFUL ] 
com.twitter#util-function_2.11;6.34.0!util-function_2.11.jar (160ms)
[info] downloading 
https://repo1.maven.org/maven2/com/twitter/jsr166e/1.0.0/jsr166e-1.0.0.jar ...
[info]  [SUCCESSFUL ] com.twitter#jsr166e;1.0.0!jsr166e.jar (57ms)
[info] downloading 
https://repo1.maven.org/maven2/commons-configuration/commons-configuration/1.6/commons-configuration-1.6.jar
 ...
[info]  [SUCCESSFUL ] 
commons-configuration#commons-configuration;1.6!commons-configuration.jar 
(207ms)
[info] downloading 
https://repo1.maven.org/maven2/net/java/dev/jna/jna/3.2.7/jna-3.2.7.jar ...
[info]  [SUCCESSFUL ] net.java.dev.jna#jna;3.2.7!jna.jar (587ms)
[info] downloading 
https://repo1.maven.org/maven2/commons-digester/commons-digester/1.8/commons-digester-1.8.jar
 ...
[info]  [SUCCESSFUL ] 
commons-digester#commons-digester;1.8!commons-digester.jar (124ms)
[info] downloading 
https://repo1.maven.org/maven2/commons-beanutils/commons-beanutils-core/1.8.0/commons-beanutils-core-1.8.0.jar
 ...
[info]  [SUCCESSFUL ] 
commons-beanutils#commons-beanutils-core;1.8.0!commons-beanutils-core.jar

[jira] [Commented] (DL-129) Enable check style for distributedlog-protocol module

2016-12-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DL-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15763642#comment-15763642
 ] 

ASF GitHub Bot commented on DL-129:
---

Github user xiliuant commented on the issue:

https://github.com/apache/incubator-distributedlog/pull/54
  
@sijie I addressed most of your comments. please let me know if you have 
any other comments.


> Enable check style for distributedlog-protocol module
> -
>
> Key: DL-129
> URL: https://issues.apache.org/jira/browse/DL-129
> Project: DistributedLog
>  Issue Type: Sub-task
>  Components: distributedlog-protocol
>Reporter: Xi Liu
>Assignee: Xi Liu
> Fix For: 0.4.0
>
>
> Enable check style plugin for distributedlog-protocol module



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-distributedlog issue #54: DL-129: Enable checkstyle plugin for dis...

2016-12-20 Thread xiliuant 
Github user xiliuant commented on the issue:

https://github.com/apache/incubator-distributedlog/pull/54
  
@sijie I addressed most of your comments. please let me know if you have 
any other comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-distributedlog pull request #54: DL-129: Enable checkstyle plugin ...

2016-12-20 Thread xiliuant 
Github user xiliuant commented on a diff in the pull request:


https://github.com/apache/incubator-distributedlog/pull/54#discussion_r93190694
  
--- Diff: 
distributedlog-build-tools/src/main/resources/distributedlog/checkstyle.xml ---
@@ -0,0 +1,443 @@
+
+
+http://www.puppycrawl.com/dtds/configuration_1_3.dtd;>
+
+
+
+
+
+  
+
+  
+
+  
+
+
+
+
+  
+
+  
+
+
+
+  
+
+  
+
+
+
+  
+
+  
+  
+
+  
+
+  
+  
+
+
+
+  
+  
+
+  
+
+  
+  
+
+  
+  
+
+
+  
+  
+
+
+
+
+
+  
+  
+  
+
+
+
+  
+  
+  
+  
+  
+  
+  
+
+
+
+  
+
+
+
+  
--- End diff --

fixed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (DL-129) Enable check style for distributedlog-protocol module

2016-12-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DL-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15763641#comment-15763641
 ] 

ASF GitHub Bot commented on DL-129:
---

Github user xiliuant commented on a diff in the pull request:


https://github.com/apache/incubator-distributedlog/pull/54#discussion_r93190694
  
--- Diff: 
distributedlog-build-tools/src/main/resources/distributedlog/checkstyle.xml ---
@@ -0,0 +1,443 @@
+
+
+http://www.puppycrawl.com/dtds/configuration_1_3.dtd;>
+
+
+
+
+
+  
+
+  
+
+  
+
+
+
+
+  
+
+  
+
+
+
+  
+
+  
+
+
+
+  
+
+  
+  
+
+  
+
+  
+  
+
+
+
+  
+  
+
+  
+
+  
+  
+
+  
+  
+
+
+  
+  
+
+
+
+
+
+  
+  
+  
+
+
+
+  
+  
+  
+  
+  
+  
+  
+
+
+
+  
+
+
+
+  
--- End diff --

fixed.


> Enable check style for distributedlog-protocol module
> -
>
> Key: DL-129
> URL: https://issues.apache.org/jira/browse/DL-129
> Project: DistributedLog
>  Issue Type: Sub-task
>  Components: distributedlog-protocol
>Reporter: Xi Liu
>Assignee: Xi Liu
> Fix For: 0.4.0
>
>
> Enable check style plugin for distributedlog-protocol module



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-distributedlog pull request #54: DL-129: Enable checkstyle plugin ...

2016-12-20 Thread xiliuant 
Github user xiliuant commented on a diff in the pull request:


https://github.com/apache/incubator-distributedlog/pull/54#discussion_r93190638
  
--- Diff: distributedlog-build-tools/pom.xml ---
@@ -0,0 +1,30 @@
+
--- End diff --

I moved the eclipse setting to the build-tools module. I will create a jira 
for findbugs settings.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (DL-145) Fix the flaky testServiceTimeout

2016-12-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DL-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15763630#comment-15763630
 ] 

ASF GitHub Bot commented on DL-145:
---

Github user xieliang commented on the issue:

https://github.com/apache/incubator-distributedlog/pull/78
  
The failure cases are not related with current change, please see 
https://issues.apache.org/jira/browse/DL-147 for further working on it.


> Fix the flaky testServiceTimeout
> 
>
> Key: DL-145
> URL: https://issues.apache.org/jira/browse/DL-145
> Project: DistributedLog
>  Issue Type: Test
>  Components: distributedlog-service
>Affects Versions: 0.4.0
>Reporter: Liang Xie
>Assignee: Liang Xie
>
> The TestDistributedLogService#testServiceTimeout case is not stable, e.g. 
> https://builds.apache.org/job/distributedlog-precommit-pullrequest/22/com.twitter$distributedlog-service/testReport/com.twitter.distributedlog.service/TestDistributedLogService/testServiceTimeout/
> It could be reproduced on my box occasionally, and the failures were stable 
> if i tuned the ServiceTimeoutMs from 200 to 150, and always passed if tuned 
> to a larger value, e.g. 1000(btw, my disk is SSD type)
> After digging into it, shows it related with starting a new log segment 
> corner case.
> For a good case, once service time out occurs, steam status : ERROR -> 
> CLOSING -> CLOSED, calling Abortables.asyncAbort will trigger the cached 
> logsegment be aborted, then writeOp will be injected an exception, e.g. write 
> cancel exception.
> For a bad case, since no log records be written before, so there'll be an 
> async start new log segment, once the timeout occurs, the segment starting 
> still not be done, so no cache, then asyncAbort has no change to abort that 
> segment.
> I think change the test timeout value to a larger one should be fine for this 
> special test corner case.
> will attach a minor patch later.  Any suggestions are welcome.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-distributedlog issue #78: DL-145 : the write requests should be er...

2016-12-20 Thread xieliang 
Github user xieliang commented on the issue:

https://github.com/apache/incubator-distributedlog/pull/78
  
The failure cases are not related with current change, please see 
https://issues.apache.org/jira/browse/DL-147 for further working on it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (DL-147) Improve DistributedLogServerTestCase

2016-12-20 Thread Liang Xie (JIRA) 
Liang Xie created DL-147:


 Summary: Improve DistributedLogServerTestCase
 Key: DL-147
 URL: https://issues.apache.org/jira/browse/DL-147
 Project: DistributedLog
  Issue Type: Test
  Components: distributedlog-service
Reporter: Liang Xie


See 
https://builds.apache.org/job/distributedlog-precommit-pullrequest/38/com.twitter$distributedlog-service/testReport/

Currently, the port is hard-code:
{code}
@Before
public void setup() throws Exception {
dlServer = createDistributedLogServer(7001);
dlClient = createDistributedLogClient("test");
}
{code}

Therefore "java.net.BindException: Address already in use" will be seen under a 
not-cleaned or shared env. we should introduce a fall-back mechanism



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DL-91) Be able to close writer within a timeout duration

2016-12-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DL-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15763578#comment-15763578
 ] 

ASF GitHub Bot commented on DL-91:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-distributedlog/pull/64


> Be able to close writer within a timeout duration
> -
>
> Key: DL-91
> URL: https://issues.apache.org/jira/browse/DL-91
> Project: DistributedLog
>  Issue Type: Bug
>  Components: distributedlog-client
>Reporter: Sijie Guo
>Assignee: Leigh Stewart
>
> If a stream is hanging on closing the writer on write proxy, it will cause 
> STEAM_UNAVAILABLE.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

incubator-distributedlog git commit: DL-91: Be able to close writer within a timeout duration

2016-12-20 Thread sijie 
Repository: incubator-distributedlog
Updated Branches:
  refs/heads/master 6e67a377f -> 26942a91a


DL-91: Be able to close writer within a timeout duration

merge twitter's change on closing writer.

Author: Sijie Guo 
Author: Sijie Guo 
Author: Jordan Bull 
Author: Leigh Stewart 
Author: Dave Rusek 
Author: Dave Rusek 

Reviewers: Leigh Stewart 

Closes #64 from sijie/merge/DL-91


Project: http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/repo
Commit: 
http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/commit/26942a91
Tree: 
http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/tree/26942a91
Diff: 
http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/diff/26942a91

Branch: refs/heads/master
Commit: 26942a91a67e1d0052b46db278e7ba8bdb414269
Parents: 6e67a37
Author: Sijie Guo 
Authored: Tue Dec 20 00:04:51 2016 -0800
Committer: Sijie Guo 
Committed: Tue Dec 20 00:04:51 2016 -0800

--
 .../distributedlog/BKAsyncLogWriter.java| 33 +---
 .../distributedlog/util/FutureUtils.java| 20 +++-
 .../service/config/ServerConfiguration.java | 25 +++
 .../service/stream/StreamFactoryImpl.java   |  6 +++-
 .../service/stream/StreamImpl.java  | 32 +--
 5 files changed, 99 insertions(+), 17 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/blob/26942a91/distributedlog-core/src/main/java/com/twitter/distributedlog/BKAsyncLogWriter.java
--
diff --git 
a/distributedlog-core/src/main/java/com/twitter/distributedlog/BKAsyncLogWriter.java
 
b/distributedlog-core/src/main/java/com/twitter/distributedlog/BKAsyncLogWriter.java
index f1594f9..79f5f5e 100644
--- 
a/distributedlog-core/src/main/java/com/twitter/distributedlog/BKAsyncLogWriter.java
+++ 
b/distributedlog-core/src/main/java/com/twitter/distributedlog/BKAsyncLogWriter.java
@@ -212,8 +212,10 @@ public class BKAsyncLogWriter extends BKAbstractLogWriter 
implements AsyncLogWri
boolean rollLog,
boolean 
allowMaxTxID) {
 Stopwatch stopwatch = Stopwatch.createStarted();
-return doGetLogSegmentWriter(firstTxid, bestEffort, rollLog, 
allowMaxTxID)
-.addEventListener(new 
OpStatsListener(getWriterOpStatsLogger, stopwatch));
+return FutureUtils.stats(
+doGetLogSegmentWriter(firstTxid, bestEffort, rollLog, 
allowMaxTxID),
+getWriterOpStatsLogger,
+stopwatch);
 }
 
 private Future doGetLogSegmentWriter(final long 
firstTxid,
@@ -415,8 +417,10 @@ public class BKAsyncLogWriter extends BKAbstractLogWriter 
implements AsyncLogWri
 @Override
 public Future write(final LogRecord record) {
 final Stopwatch stopwatch = Stopwatch.createStarted();
-return asyncWrite(record, true)
-.addEventListener(new 
OpStatsListener(writeOpStatsLogger, stopwatch));
+return FutureUtils.stats(
+asyncWrite(record, true),
+writeOpStatsLogger,
+stopwatch);
 }
 
 /**
@@ -430,8 +434,10 @@ public class BKAsyncLogWriter extends BKAbstractLogWriter 
implements AsyncLogWri
 @Override
 public Future> writeBulk(final List records) 
{
 final Stopwatch stopwatch = Stopwatch.createStarted();
-return Future.value(asyncWriteBulk(records))
-.addEventListener(new 
OpStatsListener>(bulkWriteOpStatsLogger, stopwatch));
+return FutureUtils.stats(
+Future.value(asyncWriteBulk(records)),
+bulkWriteOpStatsLogger,
+stopwatch);
 }
 
 @Override
@@ -478,12 +484,15 @@ public class BKAsyncLogWriter extends BKAbstractLogWriter 
implements AsyncLogWri
 logSegmentWriterFuture = getLogSegmentWriterForEndOfStream();
 }
 
-return logSegmentWriterFuture.flatMap(new 
AbstractFunction1() {
-@Override
-public Future apply(BKLogSegmentWriter w) {
-return w.markEndOfStream();
-}
-}).addEventListener(new 
OpStatsListener(markEndOfStreamOpStatsLogger, stopwatch));
+return FutureUtils.stats(
+logSegmentWriterFuture.flatMap(new 
AbstractFunction1() {
+@Override
+public Future apply(BKLogSegmentWriter w) {
+return w.markEndOfStream();
+