[GitHub] incubator-distributedlog issue #123: DL-193: Bumped up the Guava version

2017-03-18 Thread sijie
Github user sijie commented on the issue:

https://github.com/apache/incubator-distributedlog/pull/123
  
LGTM +1. Thanks @arvindkandhare 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-distributedlog issue #123: DL-193: Bumped up the Guava version

2017-03-17 Thread sijie
Github user sijie commented on the issue:

https://github.com/apache/incubator-distributedlog/pull/123
  
@arvindkandhare - I merged your change in bookkeeper and released a version 
- 4.3.7-TWTTR-OSS 

Can you update your pull request for this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-distributedlog issue #123: DL-193: Bumped up the Guava version

2017-03-15 Thread sijie
Github user sijie commented on the issue:

https://github.com/apache/incubator-distributedlog/pull/123
  
gotcha. Is it possible to shade the guava in bookkeeper?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-distributedlog issue #123: DL-193: Bumped up the Guava version

2017-03-14 Thread sijie
Github user sijie commented on the issue:

https://github.com/apache/incubator-distributedlog/pull/123
  
@arvindkandhare can you just exclude "guava" from the bookkeeper dependency 
and use 0.20 here? I am trying to understand if we really need a new bk version 
from twitter branch. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-distributedlog issue #123: DL-193: Bumped up the Guava version

2017-03-14 Thread jiazhai
Github user jiazhai commented on the issue:

https://github.com/apache/incubator-distributedlog/pull/123
  
Thanks for the fix.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-distributedlog issue #123: DL-193: Bumped up the Guava version

2017-03-08 Thread sijie
Github user sijie commented on the issue:

https://github.com/apache/incubator-distributedlog/pull/123
  
Seems both travis CI and Jenkins failed with similar error

`
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on 
project distributedlog-service_2.11: ExecutionException The forked VM 
terminated without properly saying goodbye. VM crash or System.exit called?
[ERROR] Command was /bin/sh -c cd 
/Users/travis/build/apache/incubator-distributedlog/distributedlog-service && 
/Library/Java/JavaVirtualMachines/jdk1.8.0_92.jdk/Contents/Home/jre/bin/java 
-Xmx3G -Djava.net.preferIPv4Stack=true -XX:MaxDirectMemorySize=2G -jar 
/Users/travis/build/apache/incubator-distributedlog/distributedlog-service/target/surefire/surefirebooter1574788574072023345.jar
 
/Users/travis/build/apache/incubator-distributedlog/distributedlog-service/target/surefire/surefire1040382260065287155tmp
 
/Users/travis/build/apache/incubator-distributedlog/distributedlog-service/target/surefire/surefire_871857929376723744956tmp
`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-distributedlog issue #123: DL-193: Bumped up the Guava version

2017-03-08 Thread arvindkandhare
Github user arvindkandhare commented on the issue:

https://github.com/apache/incubator-distributedlog/pull/123
  
Looking in to this. mvn compile passed for me locally. Maybe I should try 
running mvn clean install? Giving it a shot.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-distributedlog issue #123: DL-193: Bumped up the Guava version

2017-03-07 Thread hsaputra
Github user hsaputra commented on the issue:

https://github.com/apache/incubator-distributedlog/pull/123
  
Couldnt figure out why our Jenkins build failed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-distributedlog issue #123: DL-193: Bumped up the Guava version

2017-03-07 Thread hsaputra
Github user hsaputra commented on the issue:

https://github.com/apache/incubator-distributedlog/pull/123
  
LGTM
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---