[GitHub] incubator-distributedlog pull request #104: DL-174: added getParent method t...

2017-04-12 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-distributedlog/pull/104


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-distributedlog pull request #104: DL-174: added getParent method t...

2017-01-31 Thread leighst
Github user leighst commented on a diff in the pull request:


https://github.com/apache/incubator-distributedlog/pull/104#discussion_r98693213
  
--- Diff: 
distributedlog-core/src/main/java/com/twitter/distributedlog/util/Utils.java ---
@@ -604,4 +604,35 @@ public static void closeQuietly(@Nullable 
AsyncCloseable closeable) {
 executorService).map(VoidFunctions.LIST_TO_VOID_FUNC);
 }
 
+/**
+ * Gets the parent of a path.
+ *
+ * @param path
+ *path to get the parent of
+ * @return parent of the path or null if no parent exists.
+ */
+public static String getParent(final String path) {
--- End diff --

could we add zk or unix to the name? 

ex. getZkParent, just to be really clear


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---