Re: Git Workflow on Windows
Chris, This is very informative and useful. Thank you so much for sharing this. I will try this out. Yeah I think most of the issues come from path and symlinks. I think Tracy already figured the problems out. Looking forward to the contribution. - Sijie On Wed, Jan 4, 2017 at 11:24 AM, Chris Nauroth wrote: > Microsoft offers free MSDN licenses to Apache committers. The request > process is documented here: > > https://s.apache.org/BDIK > > You'll need to be able to authenticate with your ASF account to access that > link. > > This means that for committers who don't usually work on Windows, you have > an option for running a Windows VM at no personal cost, in case you want to > verify a patch running on Windows. The approval process for the license > can take a long time though. > > From past experience working on Windows compatibility for other projects > like Hadoop and ZooKeeper, it's very common for software developed > initially on Linux to assume '/' as the file path separator, and it looks > like that's what is happening here. If DistributedLog wants to support > Windows as a development platform, then the effort would involve tracking > down incompatibilities like this and fixing them. > > This could be a great area for a developer working on Windows to start > contributing some patches too! > > > > Chris Nauroth > > On Wed, Jan 4, 2017 at 4:56 AM, Tracy Martin > wrote: > > > Pasted log here: > > > > https://gist.github.com/adamtracymartin/2ec2585d9d8efa8f81cbbcaaa2a2ed90 > > > > > > -Original Message- > > From: Franck Cuny [mailto:franck.c...@gmail.com] > > Sent: Tuesday, January 03, 2017 7:57 PM > > To: dev@distributedlog.incubator.apache.org > > Subject: Re: Git Workflow on Windows > > > > Hello Tracy, > > > > could you paste the complete output of the command you run somewhere ? > > > > As far as I know, we haven't tried to build DLog on a windows system, and > > I don't think we've made any effort to support this so far. > > > > On Tue, Jan 3, 2017 at 11:35 AM Tracy Martin > > wrote: > > > > > I am fixing DL-28 after the merge, and I am following the "Git > Workflow" > > > described here: > > > > > > https://cwiki.apache.org/confluence/display/DL/Contributing+to+Distrib > > > utedLog > > > > > > I am getting many failures running step 4 > > > > > > mvn clean apache-rat:check package findbugs:check > > > > > > from my Windows desktop. > > > > > > I know the error received in DL-28 was related to running the build on > > > Windows instead of Unix. Many of the errors that I see in the tests > > > point to a Windows only problem. Most of the errors reports are "Path > > > must start with / character". > > > > > > I know when I was first reading about DistributedLog that it required > > > Unix. Is the plan to only run from Unix systems? If so, I will look > > > at creating a Unix environment for building, testing, and running. > > > This e-mail and any attachments, contain Genuine Parts Company > > > confidential information that is proprietary, privileged, and > > > protected by applicable laws. If you have received this message in > > > error and are not the intended recipient, you should not retain, > > > distribute, disclose or use any of this information and you should > > > destroy this e-mail, any attachments or copies therein forthwith. > > > Please notify the sender immediately by e-mail if you have received > this > > e-mail in error. > > > > > > "This e-mail and any attachments, contain Genuine Parts Company > > > confidential information that is proprietary, privileged, and > > > protected by applicable laws. If you have received this message in > > > error and are not the intended recipient, you should not retain, > > > distribute, disclose or use any of this information and you should > > > destroy this e-mail, any attachments or copies therein forthwith. > > > Please notify the sender immediately by e-mail if you have received > this > > e-mail in error." > > > > > -- > > -franck > > This e-mail and any attachments, contain Genuine Parts Company > > confidential information that is proprietary, privileged, and protected > by > > applicable laws. If you have received this message in error and are not > the > > intended recipient, you should not retain, distribute, disclose or use > any >
Re: Git Workflow on Windows
Microsoft offers free MSDN licenses to Apache committers. The request process is documented here: https://s.apache.org/BDIK You'll need to be able to authenticate with your ASF account to access that link. This means that for committers who don't usually work on Windows, you have an option for running a Windows VM at no personal cost, in case you want to verify a patch running on Windows. The approval process for the license can take a long time though. >From past experience working on Windows compatibility for other projects like Hadoop and ZooKeeper, it's very common for software developed initially on Linux to assume '/' as the file path separator, and it looks like that's what is happening here. If DistributedLog wants to support Windows as a development platform, then the effort would involve tracking down incompatibilities like this and fixing them. This could be a great area for a developer working on Windows to start contributing some patches too! Chris Nauroth On Wed, Jan 4, 2017 at 4:56 AM, Tracy Martin wrote: > Pasted log here: > > https://gist.github.com/adamtracymartin/2ec2585d9d8efa8f81cbbcaaa2a2ed90 > > > -Original Message- > From: Franck Cuny [mailto:franck.c...@gmail.com] > Sent: Tuesday, January 03, 2017 7:57 PM > To: dev@distributedlog.incubator.apache.org > Subject: Re: Git Workflow on Windows > > Hello Tracy, > > could you paste the complete output of the command you run somewhere ? > > As far as I know, we haven't tried to build DLog on a windows system, and > I don't think we've made any effort to support this so far. > > On Tue, Jan 3, 2017 at 11:35 AM Tracy Martin > wrote: > > > I am fixing DL-28 after the merge, and I am following the "Git Workflow" > > described here: > > > > https://cwiki.apache.org/confluence/display/DL/Contributing+to+Distrib > > utedLog > > > > I am getting many failures running step 4 > > > > mvn clean apache-rat:check package findbugs:check > > > > from my Windows desktop. > > > > I know the error received in DL-28 was related to running the build on > > Windows instead of Unix. Many of the errors that I see in the tests > > point to a Windows only problem. Most of the errors reports are "Path > > must start with / character". > > > > I know when I was first reading about DistributedLog that it required > > Unix. Is the plan to only run from Unix systems? If so, I will look > > at creating a Unix environment for building, testing, and running. > > This e-mail and any attachments, contain Genuine Parts Company > > confidential information that is proprietary, privileged, and > > protected by applicable laws. If you have received this message in > > error and are not the intended recipient, you should not retain, > > distribute, disclose or use any of this information and you should > > destroy this e-mail, any attachments or copies therein forthwith. > > Please notify the sender immediately by e-mail if you have received this > e-mail in error. > > > > "This e-mail and any attachments, contain Genuine Parts Company > > confidential information that is proprietary, privileged, and > > protected by applicable laws. If you have received this message in > > error and are not the intended recipient, you should not retain, > > distribute, disclose or use any of this information and you should > > destroy this e-mail, any attachments or copies therein forthwith. > > Please notify the sender immediately by e-mail if you have received this > e-mail in error." > > > -- > -franck > This e-mail and any attachments, contain Genuine Parts Company > confidential information that is proprietary, privileged, and protected by > applicable laws. If you have received this message in error and are not the > intended recipient, you should not retain, distribute, disclose or use any > of this information and you should destroy this e-mail, any attachments or > copies therein forthwith. Please notify the sender immediately by e-mail if > you have received this e-mail in error. > > "This e-mail and any attachments, contain Genuine Parts Company > confidential information that is proprietary, privileged, and protected by > applicable laws. If you have received this message in error and are not the > intended recipient, you should not retain, distribute, disclose or use any > of this information and you should destroy this e-mail, any attachments or > copies therein forthwith. Please notify the sender immediately by e-mail if > you have received this e-mail in error." >
RE: Git Workflow on Windows
Pasted log here: https://gist.github.com/adamtracymartin/2ec2585d9d8efa8f81cbbcaaa2a2ed90 -Original Message- From: Franck Cuny [mailto:franck.c...@gmail.com] Sent: Tuesday, January 03, 2017 7:57 PM To: dev@distributedlog.incubator.apache.org Subject: Re: Git Workflow on Windows Hello Tracy, could you paste the complete output of the command you run somewhere ? As far as I know, we haven't tried to build DLog on a windows system, and I don't think we've made any effort to support this so far. On Tue, Jan 3, 2017 at 11:35 AM Tracy Martin wrote: > I am fixing DL-28 after the merge, and I am following the "Git Workflow" > described here: > > https://cwiki.apache.org/confluence/display/DL/Contributing+to+Distrib > utedLog > > I am getting many failures running step 4 > > mvn clean apache-rat:check package findbugs:check > > from my Windows desktop. > > I know the error received in DL-28 was related to running the build on > Windows instead of Unix. Many of the errors that I see in the tests > point to a Windows only problem. Most of the errors reports are "Path > must start with / character". > > I know when I was first reading about DistributedLog that it required > Unix. Is the plan to only run from Unix systems? If so, I will look > at creating a Unix environment for building, testing, and running. > This e-mail and any attachments, contain Genuine Parts Company > confidential information that is proprietary, privileged, and > protected by applicable laws. If you have received this message in > error and are not the intended recipient, you should not retain, > distribute, disclose or use any of this information and you should > destroy this e-mail, any attachments or copies therein forthwith. > Please notify the sender immediately by e-mail if you have received this > e-mail in error. > > "This e-mail and any attachments, contain Genuine Parts Company > confidential information that is proprietary, privileged, and > protected by applicable laws. If you have received this message in > error and are not the intended recipient, you should not retain, > distribute, disclose or use any of this information and you should > destroy this e-mail, any attachments or copies therein forthwith. > Please notify the sender immediately by e-mail if you have received this > e-mail in error." > -- -franck This e-mail and any attachments, contain Genuine Parts Company confidential information that is proprietary, privileged, and protected by applicable laws. If you have received this message in error and are not the intended recipient, you should not retain, distribute, disclose or use any of this information and you should destroy this e-mail, any attachments or copies therein forthwith. Please notify the sender immediately by e-mail if you have received this e-mail in error. "This e-mail and any attachments, contain Genuine Parts Company confidential information that is proprietary, privileged, and protected by applicable laws. If you have received this message in error and are not the intended recipient, you should not retain, distribute, disclose or use any of this information and you should destroy this e-mail, any attachments or copies therein forthwith. Please notify the sender immediately by e-mail if you have received this e-mail in error."
RE: Git Workflow on Windows
I think that most of the issues are in the test cases at this point. I will paste the output later when I am at my desk. I suspect that bookkeeper has similar issues. The Readme on gitgub says to use a Unix system to build. I tried to run the same mvn command with tests on 4.3.6 and received error in the tests. I can work on making the changes for Windows. Should we create a separate ticket in Jira? Also, I could not create an issue in Jira. Sent from my T-Mobile 4G LTE Device Original message From: Sijie Guo Date: 1/4/17 3:29 AM (GMT-05:00) To: dev@distributedlog.incubator.apache.org Subject: Re: Git Workflow on Windows We definitely want to support running distributedlog in other environments. And in theory, it is a Java system, it should be able to run on different platforms. But as what Franck mentioned, the major problem is most of us don't have a windows environment :/ I tried to have a Jenkins job or Travis CI job to build distributedlog on windows. But unfortunately, it is inconvenient for me to debug what it failed. Based on the conversation in the jiras, it seems that the major problems are a compilation problem and a symlink problem. So fixing these two should be able to compile and run distributedlog on windows. However, in order to validate the performance on windows, we might seek for helps from the people who have more experiences on windows. - Sijie On Tue, Jan 3, 2017 at 4:56 PM, Franck Cuny wrote: > Hello Tracy, > > could you paste the complete output of the command you run somewhere ? > > As far as I know, we haven't tried to build DLog on a windows system, and I > don't think we've made any effort to support this so far. > > On Tue, Jan 3, 2017 at 11:35 AM Tracy Martin > wrote: > > > I am fixing DL-28 after the merge, and I am following the "Git Workflow" > > described here: > > > > https://cwiki.apache.org/confluence/display/DL/ > Contributing+to+DistributedLog > > > > I am getting many failures running step 4 > > > > mvn clean apache-rat:check package findbugs:check > > > > from my Windows desktop. > > > > I know the error received in DL-28 was related to running the build on > > Windows instead of Unix. Many of the errors that I see in the tests > point > > to a Windows only problem. Most of the errors reports are "Path must > start > > with / character". > > > > I know when I was first reading about DistributedLog that it required > > Unix. Is the plan to only run from Unix systems? If so, I will look at > > creating a Unix environment for building, testing, and running. > > This e-mail and any attachments, contain Genuine Parts Company > > confidential information that is proprietary, privileged, and protected > by > > applicable laws. If you have received this message in error and are not > the > > intended recipient, you should not retain, distribute, disclose or use > any > > of this information and you should destroy this e-mail, any attachments > or > > copies therein forthwith. Please notify the sender immediately by e-mail > if > > you have received this e-mail in error. > > > > "This e-mail and any attachments, contain Genuine Parts Company > > confidential information that is proprietary, privileged, and protected > by > > applicable laws. If you have received this message in error and are not > the > > intended recipient, you should not retain, distribute, disclose or use > any > > of this information and you should destroy this e-mail, any attachments > or > > copies therein forthwith. Please notify the sender immediately by e-mail > if > > you have received this e-mail in error." > > > -- > -franck > This e-mail and any attachments, contain Genuine Parts Company confidential information that is proprietary, privileged, and protected by applicable laws. If you have received this message in error and are not the intended recipient, you should not retain, distribute, disclose or use any of this information and you should destroy this e-mail, any attachments or copies therein forthwith. Please notify the sender immediately by e-mail if you have received this e-mail in error. "This e-mail and any attachments, contain Genuine Parts Company confidential information that is proprietary, privileged, and protected by applicable laws. If you have received this message in error and are not the intended recipient, you should not retain, distribute, disclose or use any of this information and you should destroy this e-mail, any attachments or copies therein forthwith. Please notify the sender immediately by e-mail if you have received this e-mail in error."
Re: Git Workflow on Windows
We definitely want to support running distributedlog in other environments. And in theory, it is a Java system, it should be able to run on different platforms. But as what Franck mentioned, the major problem is most of us don't have a windows environment :/ I tried to have a Jenkins job or Travis CI job to build distributedlog on windows. But unfortunately, it is inconvenient for me to debug what it failed. Based on the conversation in the jiras, it seems that the major problems are a compilation problem and a symlink problem. So fixing these two should be able to compile and run distributedlog on windows. However, in order to validate the performance on windows, we might seek for helps from the people who have more experiences on windows. - Sijie On Tue, Jan 3, 2017 at 4:56 PM, Franck Cuny wrote: > Hello Tracy, > > could you paste the complete output of the command you run somewhere ? > > As far as I know, we haven't tried to build DLog on a windows system, and I > don't think we've made any effort to support this so far. > > On Tue, Jan 3, 2017 at 11:35 AM Tracy Martin > wrote: > > > I am fixing DL-28 after the merge, and I am following the "Git Workflow" > > described here: > > > > https://cwiki.apache.org/confluence/display/DL/ > Contributing+to+DistributedLog > > > > I am getting many failures running step 4 > > > > mvn clean apache-rat:check package findbugs:check > > > > from my Windows desktop. > > > > I know the error received in DL-28 was related to running the build on > > Windows instead of Unix. Many of the errors that I see in the tests > point > > to a Windows only problem. Most of the errors reports are "Path must > start > > with / character". > > > > I know when I was first reading about DistributedLog that it required > > Unix. Is the plan to only run from Unix systems? If so, I will look at > > creating a Unix environment for building, testing, and running. > > This e-mail and any attachments, contain Genuine Parts Company > > confidential information that is proprietary, privileged, and protected > by > > applicable laws. If you have received this message in error and are not > the > > intended recipient, you should not retain, distribute, disclose or use > any > > of this information and you should destroy this e-mail, any attachments > or > > copies therein forthwith. Please notify the sender immediately by e-mail > if > > you have received this e-mail in error. > > > > "This e-mail and any attachments, contain Genuine Parts Company > > confidential information that is proprietary, privileged, and protected > by > > applicable laws. If you have received this message in error and are not > the > > intended recipient, you should not retain, distribute, disclose or use > any > > of this information and you should destroy this e-mail, any attachments > or > > copies therein forthwith. Please notify the sender immediately by e-mail > if > > you have received this e-mail in error." > > > -- > -franck >
Re: Git Workflow on Windows
Hello Tracy, could you paste the complete output of the command you run somewhere ? As far as I know, we haven't tried to build DLog on a windows system, and I don't think we've made any effort to support this so far. On Tue, Jan 3, 2017 at 11:35 AM Tracy Martin wrote: > I am fixing DL-28 after the merge, and I am following the "Git Workflow" > described here: > > https://cwiki.apache.org/confluence/display/DL/Contributing+to+DistributedLog > > I am getting many failures running step 4 > > mvn clean apache-rat:check package findbugs:check > > from my Windows desktop. > > I know the error received in DL-28 was related to running the build on > Windows instead of Unix. Many of the errors that I see in the tests point > to a Windows only problem. Most of the errors reports are "Path must start > with / character". > > I know when I was first reading about DistributedLog that it required > Unix. Is the plan to only run from Unix systems? If so, I will look at > creating a Unix environment for building, testing, and running. > This e-mail and any attachments, contain Genuine Parts Company > confidential information that is proprietary, privileged, and protected by > applicable laws. If you have received this message in error and are not the > intended recipient, you should not retain, distribute, disclose or use any > of this information and you should destroy this e-mail, any attachments or > copies therein forthwith. Please notify the sender immediately by e-mail if > you have received this e-mail in error. > > "This e-mail and any attachments, contain Genuine Parts Company > confidential information that is proprietary, privileged, and protected by > applicable laws. If you have received this message in error and are not the > intended recipient, you should not retain, distribute, disclose or use any > of this information and you should destroy this e-mail, any attachments or > copies therein forthwith. Please notify the sender immediately by e-mail if > you have received this e-mail in error." > -- -franck
