[GitHub] [incubator-dlab] ofuks merged pull request #842: [DLAB-1935] Audit adjustments
ofuks merged pull request #842: URL: https://github.com/apache/incubator-dlab/pull/842 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] ppapou commented on a change in pull request #842: [DLAB-1935] Audit adjustments
ppapou commented on a change in pull request #842:
URL: https://github.com/apache/incubator-dlab/pull/842#discussion_r467085832
##
File path:
services/self-service/src/main/java/com/epam/dlab/backendapi/service/impl/ProjectServiceImpl.java
##
@@ -344,10 +344,14 @@ private String getUpdateBudgetAudit(ProjectDTO p) {
if (!configuration.isAuditEnabled()) {
return null;
}
- Integer value =
Optional.ofNullable(get(p.getName()).getBudget())
+ ProjectDTO projectDTO = get(p.getName());
+ Integer value = Optional.ofNullable(projectDTO.getBudget())
.map(BudgetDTO::getValue)
.orElse(null);
- return String.format(AUDIT_UPDATE_BUDGET, value,
p.getBudget().getValue());
+ boolean monthlyBudget =
Optional.ofNullable(projectDTO.getBudget())
Review comment:
Primitive has been changed
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org
For additional commands, e-mail: dev-h...@dlab.apache.org
[jira] [Updated] (DLAB-1974) Show 'invalid version' if lib installation fails due to wrong version
[ https://issues.apache.org/jira/browse/DLAB-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonid Frolov updated DLAB-1974: Description: 1. If lib installation fails due to wrong version convey invalid version How it works now (for example if version contains space): - R package: Docker runs with '0', shows 'installation error' and it is retry - Pip/apt/yum packages: Docker runs with '1' and status is still in 'installing' (i) removed versions from tmp log file name, for R it shows invalid version in version contains invalid characters. 2. Augment error message for library installation ( from r package). Available version value is empty (i) "available_versions": [""] was not empty, now it is []. error message is installation_error 3. For EMR pandas/matplotlib are installed but it is shown 'error installation' due to some dependencies are not installed. This case is reproduced for pip3 group. 4. For EMR ggplot2 (r package) is not installed via DLab UI, but it can be installed via terminal 5. If user does not type library version and installation fails - convey 'installation error' instead of 'invalid version'. It was found for EMR (others group) 'pivottable' (i) previously returned invalid version with available versions = none. Now returns installation_error with error message 6. For EMR (it was found on RStudio, perhaps it is reproduced and for the other template): If install library from apt/yum package and indicate wrong version docker runs with '1' and library status remains 'installing' in DLab UI 7. Rstudio (others group): Pivottablejs installation with correct version <0.2.0> was stuck in 'installing' status and docker run with '1' (i) there was a whitespace in version < 0.2.0> was: 1. If lib installation fails due to wrong version convey invalid version How it works now (for example if version contains space): - R package: Docker runs with '0', shows 'installation error' and it is retry - Pip/apt/yum packages: Docker runs with '1' and status is still in 'installing' (i) removed versions from tmp log file name, for R it shows invalid version in version contains invalid characters. 2. Augment error message for library installation ( from r package). Available version value is empty (i) "available_versions": [""] was not empty, now it is []. error message is installation_error 3. For EMR pandas/matplotlib are installed but it is shown 'error installation' due to some dependencies are not installed. This case is reproduced for pip3 group. 4. For EMR ggplot2 (r package) is not installed via DLab UI, but it can be installed via terminal 5. If user does not type library version and installation fails - convey 'installation error' instead of 'invalid version'. It was found for EMR (others group) 'pivottable' 6. For EMR (it was found on RStudio, perhaps it is reproduced and for the other template): If install library from apt/yum package and indicate wrong version docker runs with '1' and library status remains 'installing' in DLab UI 7. Rstudio (others group): Pivottablejs installation with correct version <0.2.0> was stuck in 'installing' status and docker run with '1' (i) there was a whitespace in version < 0.2.0> > Show 'invalid version' if lib installation fails due to wrong version > - > > Key: DLAB-1974 > URL: https://issues.apache.org/jira/browse/DLAB-1974 > Project: Apache DLab > Issue Type: Task >Reporter: Vira Vitanska >Assignee: Leonid Frolov >Priority: Minor > Labels: AWS, AZURE, Debian, DevOps, GCP, RedHat > Attachments: Augment error message.png, Augment2.png, Available > version.png, P5 - pivottable 2.png, P6 -docker.png, P6 provisioning.png, P6 > response.png, P7 - docker 2.png, P7 - provisioning.png, P7-docker1.png, > P7-rstudio UI.png, Pandas1.png, Pandas2.png, Pandas3.png, Pip.png, Point 6 > UI.png, apt-yum.png, ggplot2.png, p5 - Pivottable.png > > > 1. If lib installation fails due to wrong version convey invalid version > How it works now (for example if version contains space): > - R package: Docker runs with '0', shows 'installation error' and it is retry > - Pip/apt/yum packages: Docker runs with '1' and status is still in > 'installing' > (i) removed versions from tmp log file name, for R it shows invalid version > in version contains invalid characters. > 2. Augment error message for library installation ( from r package). > Available version value is empty (i) "available_versions": [""] was not > empty, now it is []. error message is installation_error > 3. For EMR pandas/matplotlib are installed but it is shown 'error > installation' due to some dependencies are not installed. This case is > reproduced for pip3 group. > 4. For EMR ggplot2 (r package) is
[GitHub] [incubator-dlab] DG1202 merged pull request #849: [DLAB-1984]: Added 'invalid name' status if installed lib name is wrong
DG1202 merged pull request #849: URL: https://github.com/apache/incubator-dlab/pull/849 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[jira] [Updated] (DLAB-1838) [Branch-515][Azure]: Very often Notebook creation/starting fails
[ https://issues.apache.org/jira/browse/DLAB-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vira Vitanska updated DLAB-1838: Description: Very often this case is reproduced for Jupyter and RStudio. However this bug is related to all notebook templates. *Preconditions:* 1. SSN is created from branch-515 on Azure *Steps to reproduce:* # Create any notebook # Start notebook after previous stopping *Actual result:* # Notebook creation fails # Notebook starting fails *Expected result:* 1. Notebook creation is successful 2. Notebook starting is successful was: *Preconditions:* 1. SSN is created from branch-515 on Azure *Steps to reproduce:* # Create any notebook # Start notebook after previous stopping *Actual result:* # Notebook creation fails # Notebook starting fails *Expected result:* 1. Notebook creation is successful 2. Notebook starting is successful > [Branch-515][Azure]: Very often Notebook creation/starting fails > > > Key: DLAB-1838 > URL: https://issues.apache.org/jira/browse/DLAB-1838 > Project: Apache DLab > Issue Type: Bug > Components: DLab Main >Affects Versions: v.2.4 > Environment: Branch-515 >Reporter: Vira Vitanska >Assignee: Leonid Frolov >Priority: Critical > Labels: AZURE, Debian, DevOps, RedHat > Attachments: Azure Notebook creation.png, Azure notebook starting.png > > > Very often this case is reproduced for Jupyter and RStudio. However this bug > is related to all notebook templates. > *Preconditions:* > 1. SSN is created from branch-515 on Azure > *Steps to reproduce:* > # Create any notebook > # Start notebook after previous stopping > *Actual result:* > # Notebook creation fails > # Notebook starting fails > *Expected result:* > 1. Notebook creation is successful > 2. Notebook starting is successful -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[jira] [Updated] (DLAB-1834) [Branch-515][Azure][RStudio]: RStudio creation fails
[ https://issues.apache.org/jira/browse/DLAB-1834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vira Vitanska updated DLAB-1834: Summary: [Branch-515][Azure][RStudio]: RStudio creation fails (was: [Branch-515][Azure][RStudio][Jupyter]: Notebook creation fails) > [Branch-515][Azure][RStudio]: RStudio creation fails > > > Key: DLAB-1834 > URL: https://issues.apache.org/jira/browse/DLAB-1834 > Project: Apache DLab > Issue Type: Bug > Components: DLab Main >Affects Versions: v.2.4 > Environment: Branch-515 >Reporter: Vira Vitanska >Assignee: Leonid Frolov >Priority: Major > Labels: AZURE, Debian, DevOps, RedHat > Attachments: Azure Rstudio2.png > > > This bug was reproduced when image for RStudio was available, so I guess > Rstudio creation fails when using general image for RStudio. > *Preconditions:* > # SSN is created on Azure from branch-515 > # Image for RStudio is available > *Steps to reproduce:* > 1. Create RStudio from general image > *Actual result:* > 1. RStudio creation fails > *Expected result:* > 1. RStudio creation is successful -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[jira] [Updated] (DLAB-1834) [Branch-515][Azure][RStudio][Jupyter]: Notebook creation fails
[ https://issues.apache.org/jira/browse/DLAB-1834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vira Vitanska updated DLAB-1834: Summary: [Branch-515][Azure][RStudio][Jupyter]: Notebook creation fails (was: [Branch-515][Azure][RStudio]: RStudio creation fails) > [Branch-515][Azure][RStudio][Jupyter]: Notebook creation fails > -- > > Key: DLAB-1834 > URL: https://issues.apache.org/jira/browse/DLAB-1834 > Project: Apache DLab > Issue Type: Bug > Components: DLab Main >Affects Versions: v.2.4 > Environment: Branch-515 >Reporter: Vira Vitanska >Assignee: Leonid Frolov >Priority: Major > Labels: AZURE, Debian, DevOps, RedHat > Attachments: Azure Rstudio2.png > > > This bug was reproduced when image for RStudio was available, so I guess > Rstudio creation fails when using general image for RStudio. > *Preconditions:* > # SSN is created on Azure from branch-515 > # Image for RStudio is available > *Steps to reproduce:* > 1. Create RStudio from general image > *Actual result:* > 1. RStudio creation fails > *Expected result:* > 1. RStudio creation is successful -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[jira] [Updated] (DLAB-1974) Show 'invalid version' if lib installation fails due to wrong version
[ https://issues.apache.org/jira/browse/DLAB-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonid Frolov updated DLAB-1974: Description: 1. If lib installation fails due to wrong version convey invalid version How it works now (for example if version contains space): - R package: Docker runs with '0', shows 'installation error' and it is retry - Pip/apt/yum packages: Docker runs with '1' and status is still in 'installing' (i) removed versions from tmp log file name, for R it shows invalid version in version contains invalid characters. 2. Augment error message for library installation ( from r package). Available version value is empty (i) "available_versions": [""] was not empty, now it is []. error message is installation_error 3. For EMR pandas/matplotlib are installed but it is shown 'error installation' due to some dependencies are not installed. This case is reproduced for pip3 group. 4. For EMR ggplot2 (r package) is not installed via DLab UI, but it can be installed via terminal 5. If user does not type library version and installation fails - convey 'installation error' instead of 'invalid version'. It was found for EMR (others group) 'pivottable' 6. For EMR (it was found on RStudio, perhaps it is reproduced and for the other template): If install library from apt/yum package and indicate wrong version docker runs with '1' and library status remains 'installing' in DLab UI 7. Rstudio (others group): Pivottablejs installation with correct version <0.2.0> was stuck in 'installing' status and docker run with '1' (i) there was a whitespace in version < 0.2.0> was: 1. If lib installation fails due to wrong version convey invalid version How it works now (for example if version contains space): - R package: Docker runs with '0', shows 'installation error' and it is retry - Pip/apt/yum packages: Docker runs with '1' and status is still in 'installing' 2. Augment error message for library installation ( from r package). Available version value is empty 3. For EMR pandas/matplotlib are installed but it is shown 'error installation' due to some dependencies are not installed. This case is reproduced for pip3 group. 4. For EMR ggplot2 (r package) is not installed via DLab UI, but it can be installed via terminal 5. If user does not type library version and installation fails - convey 'installation error' instead of 'invalid version'. It was found for EMR (others group) 'pivottable' 6. For EMR (it was found on RStudio, perhaps it is reproduced and for the other template): If install library from apt/yum package and indicate wrong version docker runs with '1' and library status remains 'installing' in DLab UI 7. Rstudio (others group): Pivottablejs installation with correct version <0.2.0> was stuck in 'installing' status and docker run with '1' (i) there was a whitespace in version < 0.2.0> > Show 'invalid version' if lib installation fails due to wrong version > - > > Key: DLAB-1974 > URL: https://issues.apache.org/jira/browse/DLAB-1974 > Project: Apache DLab > Issue Type: Task >Reporter: Vira Vitanska >Assignee: Leonid Frolov >Priority: Minor > Labels: AWS, AZURE, Debian, DevOps, GCP, RedHat > Attachments: Augment error message.png, Augment2.png, Available > version.png, P5 - pivottable 2.png, P6 -docker.png, P6 provisioning.png, P6 > response.png, P7 - docker 2.png, P7 - provisioning.png, P7-docker1.png, > P7-rstudio UI.png, Pandas1.png, Pandas2.png, Pandas3.png, Pip.png, Point 6 > UI.png, apt-yum.png, ggplot2.png, p5 - Pivottable.png > > > 1. If lib installation fails due to wrong version convey invalid version > How it works now (for example if version contains space): > - R package: Docker runs with '0', shows 'installation error' and it is retry > - Pip/apt/yum packages: Docker runs with '1' and status is still in > 'installing' > (i) removed versions from tmp log file name, for R it shows invalid version > in version contains invalid characters. > 2. Augment error message for library installation ( from r package). > Available version value is empty (i) "available_versions": [""] was not > empty, now it is []. error message is installation_error > 3. For EMR pandas/matplotlib are installed but it is shown 'error > installation' due to some dependencies are not installed. This case is > reproduced for pip3 group. > 4. For EMR ggplot2 (r package) is not installed via DLab UI, but it can be > installed via terminal > 5. If user does not type library version and installation fails - convey > 'installation error' instead of 'invalid version'. It was found for EMR > (others group) 'pivottable' > 6. For EMR (it was found on RStudio, perhaps it is reproduced and for the > other template):
Add validation for library version
Hi Dima, I was wondering if you could add validation for library version? Jira ticket: https://issues.apache.org/jira/browse/DLAB-1986 Best regards, Vira Vitanska - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[jira] [Created] (DLAB-1986) Add validation for library version
Vira Vitanska created DLAB-1986: --- Summary: Add validation for library version Key: DLAB-1986 URL: https://issues.apache.org/jira/browse/DLAB-1986 Project: Apache DLab Issue Type: Task Components: DLab Main Reporter: Vira Vitanska Assignee: Dmytro Gnatyshyn Version field can contain only the following: Apt/yum/pip/r package/others Groups: <0-9> <-> <_> <:> <~> <.> <+> -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] DG1202 opened a new pull request #849: [DLAB-1984]: Added 'invalid name' status if installed lib name is wrong
DG1202 opened a new pull request #849: URL: https://github.com/apache/incubator-dlab/pull/849 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[jira] [Updated] (DLAB-1974) Show 'invalid version' if lib installation fails due to wrong version
[ https://issues.apache.org/jira/browse/DLAB-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonid Frolov updated DLAB-1974: Description: 1. If lib installation fails due to wrong version convey invalid version How it works now (for example if version contains space): - R package: Docker runs with '0', shows 'installation error' and it is retry - Pip/apt/yum packages: Docker runs with '1' and status is still in 'installing' 2. Augment error message for library installation ( from r package). Available version value is empty 3. For EMR pandas/matplotlib are installed but it is shown 'error installation' due to some dependencies are not installed. This case is reproduced for pip3 group. 4. For EMR ggplot2 (r package) is not installed via DLab UI, but it can be installed via terminal 5. If user does not type library version and installation fails - convey 'installation error' instead of 'invalid version'. It was found for EMR (others group) 'pivottable' 6. For EMR (it was found on RStudio, perhaps it is reproduced and for the other template): If install library from apt/yum package and indicate wrong version docker runs with '1' and library status remains 'installing' in DLab UI 7. Rstudio (others group): Pivottablejs installation with correct version <0.2.0> was stuck in 'installing' status and docker run with '1' (i) there was a whitespace in version < 0.2.0> was: 1. If lib installation fails due to wrong version convey invalid version How it works now (for example if version contains space): - R package: Docker runs with '0', shows 'installation error' and it is retry - Pip/apt/yum packages: Docker runs with '1' and status is still in 'installing' 2. Augment error message for library installation ( from r package). Available version value is empty 3. For EMR pandas/matplotlib are installed but it is shown 'error installation' due to some dependencies are not installed. This case is reproduced for pip3 group. 4. For EMR ggplot2 (r package) is not installed via DLab UI, but it can be installed via terminal 5. If user does not type library version and installation fails - convey 'installation error' instead of 'invalid version'. It was found for EMR (others group) 'pivottable' 6. For EMR (it was found on RStudio, perhaps it is reproduced and for the other template): If install library from apt/yum package and indicate wrong version docker runs with '1' and library status remains 'installing' in DLab UI 7. Rstudio (others group): Pivottablejs installation with correct version <0.2.0> was stuck in 'installing' status and docker run with '1' there was a whitespace in version < 0.2.0> > Show 'invalid version' if lib installation fails due to wrong version > - > > Key: DLAB-1974 > URL: https://issues.apache.org/jira/browse/DLAB-1974 > Project: Apache DLab > Issue Type: Task >Reporter: Vira Vitanska >Assignee: Leonid Frolov >Priority: Minor > Labels: AWS, AZURE, Debian, DevOps, GCP, RedHat > Attachments: Augment error message.png, Augment2.png, Available > version.png, P5 - pivottable 2.png, P6 -docker.png, P6 provisioning.png, P6 > response.png, P7 - docker 2.png, P7 - provisioning.png, P7-docker1.png, > P7-rstudio UI.png, Pandas1.png, Pandas2.png, Pandas3.png, Pip.png, Point 6 > UI.png, apt-yum.png, ggplot2.png, p5 - Pivottable.png > > > 1. If lib installation fails due to wrong version convey invalid version > How it works now (for example if version contains space): > - R package: Docker runs with '0', shows 'installation error' and it is retry > - Pip/apt/yum packages: Docker runs with '1' and status is still in > 'installing' > 2. Augment error message for library installation ( from r package). > Available version value is empty > 3. For EMR pandas/matplotlib are installed but it is shown 'error > installation' due to some dependencies are not installed. This case is > reproduced for pip3 group. > 4. For EMR ggplot2 (r package) is not installed via DLab UI, but it can be > installed via terminal > 5. If user does not type library version and installation fails - convey > 'installation error' instead of 'invalid version'. It was found for EMR > (others group) 'pivottable' > 6. For EMR (it was found on RStudio, perhaps it is reproduced and for the > other template): If install library from apt/yum package and indicate wrong > version docker runs with '1' and library status remains 'installing' in DLab > UI > 7. Rstudio (others group): Pivottablejs installation with correct version > <0.2.0> was stuck in 'installing' status and docker run with '1' (i) there > was a whitespace in version < 0.2.0> -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (DLAB-1974) Show 'invalid version' if lib installation fails due to wrong version
[ https://issues.apache.org/jira/browse/DLAB-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonid Frolov updated DLAB-1974: Description: 1. If lib installation fails due to wrong version convey invalid version How it works now (for example if version contains space): - R package: Docker runs with '0', shows 'installation error' and it is retry - Pip/apt/yum packages: Docker runs with '1' and status is still in 'installing' 2. Augment error message for library installation ( from r package). Available version value is empty 3. For EMR pandas/matplotlib are installed but it is shown 'error installation' due to some dependencies are not installed. This case is reproduced for pip3 group. 4. For EMR ggplot2 (r package) is not installed via DLab UI, but it can be installed via terminal 5. If user does not type library version and installation fails - convey 'installation error' instead of 'invalid version'. It was found for EMR (others group) 'pivottable' 6. For EMR (it was found on RStudio, perhaps it is reproduced and for the other template): If install library from apt/yum package and indicate wrong version docker runs with '1' and library status remains 'installing' in DLab UI 7. Rstudio (others group): Pivottablejs installation with correct version <0.2.0> was stuck in 'installing' status and docker run with '1' there was a whitespace in version < 0.2.0> was: 1. If lib installation fails due to wrong version convey invalid version How it works now (for example if version contains space): - R package: Docker runs with '0', shows 'installation error' and it is retry - Pip/apt/yum packages: Docker runs with '1' and status is still in 'installing' 2. Augment error message for library installation ( from r package). Available version value is empty 3. For EMR pandas/matplotlib are installed but it is shown 'error installation' due to some dependencies are not installed. This case is reproduced for pip3 group. 4. For EMR ggplot2 (r package) is not installed via DLab UI, but it can be installed via terminal 5. If user does not type library version and installation fails - convey 'installation error' instead of 'invalid version'. It was found for EMR (others group) 'pivottable' 6. For EMR (it was found on RStudio, perhaps it is reproduced and for the other template): If install library from apt/yum package and indicate wrong version docker runs with '1' and library status remains 'installing' in DLab UI 7. Rstudio (others group): Pivottablejs installation with correct version <0.2.0> was stuck in 'installing' status and docker run with '1' > Show 'invalid version' if lib installation fails due to wrong version > - > > Key: DLAB-1974 > URL: https://issues.apache.org/jira/browse/DLAB-1974 > Project: Apache DLab > Issue Type: Task >Reporter: Vira Vitanska >Assignee: Leonid Frolov >Priority: Minor > Labels: AWS, AZURE, Debian, DevOps, GCP, RedHat > Attachments: Augment error message.png, Augment2.png, Available > version.png, P5 - pivottable 2.png, P6 -docker.png, P6 provisioning.png, P6 > response.png, P7 - docker 2.png, P7 - provisioning.png, P7-docker1.png, > P7-rstudio UI.png, Pandas1.png, Pandas2.png, Pandas3.png, Pip.png, Point 6 > UI.png, apt-yum.png, ggplot2.png, p5 - Pivottable.png > > > 1. If lib installation fails due to wrong version convey invalid version > How it works now (for example if version contains space): > - R package: Docker runs with '0', shows 'installation error' and it is retry > - Pip/apt/yum packages: Docker runs with '1' and status is still in > 'installing' > 2. Augment error message for library installation ( from r package). > Available version value is empty > 3. For EMR pandas/matplotlib are installed but it is shown 'error > installation' due to some dependencies are not installed. This case is > reproduced for pip3 group. > 4. For EMR ggplot2 (r package) is not installed via DLab UI, but it can be > installed via terminal > 5. If user does not type library version and installation fails - convey > 'installation error' instead of 'invalid version'. It was found for EMR > (others group) 'pivottable' > 6. For EMR (it was found on RStudio, perhaps it is reproduced and for the > other template): If install library from apt/yum package and indicate wrong > version docker runs with '1' and library status remains 'installing' in DLab > UI > 7. Rstudio (others group): Pivottablejs installation with correct version > <0.2.0> was stuck in 'installing' status and docker run with '1' there was a > whitespace in version < 0.2.0> -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail:
[jira] [Updated] (DLAB-1983) [DevOps]: Convey 'invalid name' status if it is tryout to install lib with wrong name
[ https://issues.apache.org/jira/browse/DLAB-1983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vira Vitanska updated DLAB-1983: Sprint: Apache DLab release 2.4 > [DevOps]: Convey 'invalid name' status if it is tryout to install lib with > wrong name > - > > Key: DLAB-1983 > URL: https://issues.apache.org/jira/browse/DLAB-1983 > Project: Apache DLab > Issue Type: Task > Components: DLab Main >Reporter: Vira Vitanska >Assignee: Leonid Frolov >Priority: Major > Labels: AWS, AZURE, Debian, DevOps, GCP, RedHat > > If user installs library with wrong name - convey invalid name in status > column. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[jira] [Updated] (DLAB-1981) [Back-end]: Convey 'invalid name' status if it is tryout to install lib with wrong name
[ https://issues.apache.org/jira/browse/DLAB-1981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vira Vitanska updated DLAB-1981: Sprint: Apache DLab release 2.4 > [Back-end]: Convey 'invalid name' status if it is tryout to install lib with > wrong name > --- > > Key: DLAB-1981 > URL: https://issues.apache.org/jira/browse/DLAB-1981 > Project: Apache DLab > Issue Type: Task > Components: DLab Main >Reporter: Vira Vitanska >Assignee: Oleg Fuks >Priority: Major > Labels: AWS, AZURE, Back-end, Debian, GCP, RedHat > > If user installs library with wrong name - convey invalid name in status > column. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[GitHub] [incubator-dlab] ofuks commented on a change in pull request #842: [DLAB-1935] Audit adjustments
ofuks commented on a change in pull request #842:
URL: https://github.com/apache/incubator-dlab/pull/842#discussion_r466890619
##
File path:
services/self-service/src/main/java/com/epam/dlab/backendapi/service/impl/ProjectServiceImpl.java
##
@@ -344,10 +344,14 @@ private String getUpdateBudgetAudit(ProjectDTO p) {
if (!configuration.isAuditEnabled()) {
return null;
}
- Integer value =
Optional.ofNullable(get(p.getName()).getBudget())
+ ProjectDTO projectDTO = get(p.getName());
+ Integer value = Optional.ofNullable(projectDTO.getBudget())
.map(BudgetDTO::getValue)
.orElse(null);
- return String.format(AUDIT_UPDATE_BUDGET, value,
p.getBudget().getValue());
+ boolean monthlyBudget =
Optional.ofNullable(projectDTO.getBudget())
Review comment:
Can you use primitive here? Because you assign **null** in
**orElse(null)**
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org
For additional commands, e-mail: dev-h...@dlab.apache.org
[jira] [Updated] (DLAB-1847) [GNTX]: Add possibility to use predefined subnet for a project
[ https://issues.apache.org/jira/browse/DLAB-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vira Vitanska updated DLAB-1847: Affects Version/s: v.2.4 > [GNTX]: Add possibility to use predefined subnet for a project > -- > > Key: DLAB-1847 > URL: https://issues.apache.org/jira/browse/DLAB-1847 > Project: Apache DLab > Issue Type: Bug > Components: DLab Main >Affects Versions: v.2.4 >Reporter: Vira Vitanska >Assignee: Mykola Bodnar >Priority: Major > Labels: AWS, AZURE, Debian, GCP, RedHat > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[jira] [Updated] (DLAB-1847) [GNTX]: Add possibility to use predefined subnet for a project
[ https://issues.apache.org/jira/browse/DLAB-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vira Vitanska updated DLAB-1847: Sprint: (was: Apache DLab release 2.4) > [GNTX]: Add possibility to use predefined subnet for a project > -- > > Key: DLAB-1847 > URL: https://issues.apache.org/jira/browse/DLAB-1847 > Project: Apache DLab > Issue Type: Bug > Components: DLab Main >Reporter: Vira Vitanska >Assignee: Mykola Bodnar >Priority: Major > Labels: AWS, AZURE, Debian, GCP, RedHat > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[jira] [Updated] (DLAB-1846) [GNTX]: Edge should be created with custom DNS zone
[ https://issues.apache.org/jira/browse/DLAB-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vira Vitanska updated DLAB-1846: Summary: [GNTX]: Edge should be created with custom DNS zone (was: Edge should be created with custom DNS zone) > [GNTX]: Edge should be created with custom DNS zone > --- > > Key: DLAB-1846 > URL: https://issues.apache.org/jira/browse/DLAB-1846 > Project: Apache DLab > Issue Type: Bug > Components: DLab Main >Reporter: Vira Vitanska >Assignee: Mykola Bodnar >Priority: Major > Labels: AWS, Debian, DevOps > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[jira] [Updated] (DLAB-1847) [GNTX]: Add possibility to use predefined subnet for a project
[ https://issues.apache.org/jira/browse/DLAB-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vira Vitanska updated DLAB-1847: Summary: [GNTX]: Add possibility to use predefined subnet for a project (was: Add possibility to use predefined subnet for a project) > [GNTX]: Add possibility to use predefined subnet for a project > -- > > Key: DLAB-1847 > URL: https://issues.apache.org/jira/browse/DLAB-1847 > Project: Apache DLab > Issue Type: Bug > Components: DLab Main >Reporter: Vira Vitanska >Assignee: Mykola Bodnar >Priority: Major > Labels: AWS, AZURE, Debian, GCP, RedHat > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[jira] [Updated] (DLAB-1839) [GNTX]: SSN fails if parameter
[ https://issues.apache.org/jira/browse/DLAB-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vira Vitanska updated DLAB-1839: Affects Version/s: v.2.4 > [GNTX]: SSN fails if parameter > --- > > Key: DLAB-1839 > URL: https://issues.apache.org/jira/browse/DLAB-1839 > Project: Apache DLab > Issue Type: Bug > Components: DLab Main >Affects Versions: v.2.4 >Reporter: Vira Vitanska >Assignee: Mykola Bodnar >Priority: Major > Labels: AWS, AZURE, Debian, DevOps, GCP, RedHat > > *Steps to reproduce:* > 1. Create SSN where parameter conf_stepcerts_enabled = false > *Actual result:* > 1. SSN creation fails > *Expected result:* > 1. SSN creation is successful > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[jira] [Updated] (DLAB-1846) [GNTX]: Edge should be created with custom DNS zone
[ https://issues.apache.org/jira/browse/DLAB-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vira Vitanska updated DLAB-1846: Affects Version/s: v.2.4 > [GNTX]: Edge should be created with custom DNS zone > --- > > Key: DLAB-1846 > URL: https://issues.apache.org/jira/browse/DLAB-1846 > Project: Apache DLab > Issue Type: Bug > Components: DLab Main >Affects Versions: v.2.4 >Reporter: Vira Vitanska >Assignee: Mykola Bodnar >Priority: Major > Labels: AWS, Debian, DevOps > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[jira] [Updated] (DLAB-1846) [GNTX]: Edge should be created with custom DNS zone
[ https://issues.apache.org/jira/browse/DLAB-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vira Vitanska updated DLAB-1846: Sprint: (was: Apache DLab release 2.4) > [GNTX]: Edge should be created with custom DNS zone > --- > > Key: DLAB-1846 > URL: https://issues.apache.org/jira/browse/DLAB-1846 > Project: Apache DLab > Issue Type: Bug > Components: DLab Main >Reporter: Vira Vitanska >Assignee: Mykola Bodnar >Priority: Major > Labels: AWS, Debian, DevOps > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[jira] [Updated] (DLAB-1839) [GNTX]: SSN fails if parameter
[ https://issues.apache.org/jira/browse/DLAB-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vira Vitanska updated DLAB-1839: Sprint: (was: Apache DLab release 2.4) > [GNTX]: SSN fails if parameter > --- > > Key: DLAB-1839 > URL: https://issues.apache.org/jira/browse/DLAB-1839 > Project: Apache DLab > Issue Type: Bug > Components: DLab Main >Reporter: Vira Vitanska >Assignee: Mykola Bodnar >Priority: Major > Labels: AWS, AZURE, Debian, DevOps, GCP, RedHat > > *Steps to reproduce:* > 1. Create SSN where parameter conf_stepcerts_enabled = false > *Actual result:* > 1. SSN creation fails > *Expected result:* > 1. SSN creation is successful > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[jira] [Updated] (DLAB-1839) [GNTX]: SSN fails if parameter
[ https://issues.apache.org/jira/browse/DLAB-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vira Vitanska updated DLAB-1839: Summary: [GNTX]: SSN fails if parameter (was: SSN fails if parameter ) > [GNTX]: SSN fails if parameter > --- > > Key: DLAB-1839 > URL: https://issues.apache.org/jira/browse/DLAB-1839 > Project: Apache DLab > Issue Type: Bug > Components: DLab Main >Reporter: Vira Vitanska >Assignee: Mykola Bodnar >Priority: Major > Labels: AWS, AZURE, Debian, DevOps, GCP, RedHat > > *Steps to reproduce:* > 1. Create SSN where parameter conf_stepcerts_enabled = false > *Actual result:* > 1. SSN creation fails > *Expected result:* > 1. SSN creation is successful > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[jira] [Updated] (DLAB-1835) [AWS][GNTX]: Could not resolve host in specific cases
[ https://issues.apache.org/jira/browse/DLAB-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vira Vitanska updated DLAB-1835: Affects Version/s: v.2.4 > [AWS][GNTX]: Could not resolve host in specific cases > - > > Key: DLAB-1835 > URL: https://issues.apache.org/jira/browse/DLAB-1835 > Project: Apache DLab > Issue Type: Bug > Components: DLab Main >Affects Versions: v.2.4 >Reporter: Vira Vitanska >Assignee: Mykola Bodnar >Priority: Major > Labels: AWS, Debian, DevOps, RedHat > Attachments: Resolve host.png > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[jira] [Updated] (DLAB-1835) [AWS][GNTX]: Could not resolve host in specific cases
[ https://issues.apache.org/jira/browse/DLAB-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vira Vitanska updated DLAB-1835: Sprint: (was: Apache DLab release 2.4) > [AWS][GNTX]: Could not resolve host in specific cases > - > > Key: DLAB-1835 > URL: https://issues.apache.org/jira/browse/DLAB-1835 > Project: Apache DLab > Issue Type: Bug > Components: DLab Main >Reporter: Vira Vitanska >Assignee: Mykola Bodnar >Priority: Major > Labels: AWS, Debian, DevOps, RedHat > Attachments: Resolve host.png > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
[jira] [Updated] (DLAB-1835) [AWS][GNTX]: Could not resolve host in specific cases
[ https://issues.apache.org/jira/browse/DLAB-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vira Vitanska updated DLAB-1835: Summary: [AWS][GNTX]: Could not resolve host in specific cases (was: [AWS]: Could not resolve host in specific cases) > [AWS][GNTX]: Could not resolve host in specific cases > - > > Key: DLAB-1835 > URL: https://issues.apache.org/jira/browse/DLAB-1835 > Project: Apache DLab > Issue Type: Bug > Components: DLab Main >Reporter: Vira Vitanska >Assignee: Mykola Bodnar >Priority: Major > Labels: AWS, Debian, DevOps, RedHat > Attachments: Resolve host.png > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org For additional commands, e-mail: dev-h...@dlab.apache.org
