[dpdk-dev] [PATCH] doc: add more tested platforms and nics and OSes
> > Add more tested platforms and nics and OSes to the release notes. > > > > Signed-off-by: Yulong Pei > > Acked-by: John McNamara Applied, thanks
[dpdk-dev] [PATCH v2] doc: add known issue on QAT PMD into release notes
> > Issue is with the digest appended feature on QAT PMD. > > A workaround is also documented. > > > > Signed-off-by: Fiona Trahe > > Acked-by: John McNamara > Acked-by: John Griffin Applied, thanks
[dpdk-dev] [PATCH] pdump: fix log message to display correct error number
> > The ethdev Rx/Tx remove callback apis doesn't set rte_errno during
> > failures, instead they just return negative error number, so using
> > that number in logs instead of rte_errno upon Rx and Tx callback
> > removal failures.
> >
> > Fixes: 278f9454 ("pdump: add new library for packet capture")
> >
> > Signed-off-by: Reshma Pattan
>
> Acked-by: Pablo de Lara
Applied, thanks
[dpdk-dev] [PATCH] app/test: fix crash of lpm test
> > The test recently added accesses to lpm->tbl8[ip >> 8] with is much larger
> > than
> > the size of the table, causing a crash of the test application.
> >
> > Fix this typo by replacing tbl8 by tbl24.
> >
> > Fixes: 231fa88ed522 ("app/test: verify LPM tbl8 recycle")
> >
> > Signed-off-by: Olivier Matz
> Acked-by: Wei Dai
Applied, thanks
[dpdk-dev] [PATCH v2] mempool: Free memzone if mempool populate phys fails
> > This patch fixes the issue of memzone not being freed incase the
> > rte_mempool_populate_phys fails in the rte_mempool_populate_default
> >
> > This issue was identified when testing with OVS ~2.6
> > - configure the system with low memory (e.g. < 500 MB)
> > - add bridge and dpdk interfaces
> > - delete brigde
> > - keep on repeating the above sequence.
> >
> > Fixes: d1d914ebbc25 ("mempool: allocate in several memory chunks by
> > default")
> >
> > Signed-off-by: Nipun Gupta
>
> Acked-by: Olivier Matz
Applied, thanks
[dpdk-dev] [PATCH v2] net/qede: fix unknown speed errmsg for 25G link
2016-11-11 09:41, Harish Patil:
> - Fix to use bitmapped values in NVM configuration for speed capability
> advertisement. This issue is specific to 25G NIC since it is capable
> of 25G and 10G speeds.
>
> - Update feature list.
>
> Fixes: 64c239b7f8b7 ("net/qede: fix advertising link speed capability")
>
> Signed-off-by: Harish Patil
Applied, thanks
[dpdk-dev] [PATCH] improve git diff
2016-11-11 17:28, Ferruh Yigit: > On 11/11/2016 4:21 PM, Thomas Monjalon wrote: > > 2016-11-11 11:22, Ferruh Yigit: > >> On 11/9/2016 3:44 PM, Thomas Monjalon wrote: > >>> Sometimes git does not print the name of the function being changed > >>> after @@. It happens especially after a goto label which is not indented. > >>> Giving a hint about the languages of files .c, .h and .py > >>> will improve hunk headers of "git diff" rendering. > >>> > >>> Signed-off-by: Thomas Monjalon > > [...] > >>> --- /dev/null > >>> +++ b/.gitattributes > >>> @@ -0,0 +1,3 @@ > >>> +*.c diff=cpp > >>> +*.h diff=cpp > >> > >> Can't git auto detect to use C/C++ language diff use for .c/.h files? > > > > No > > > >> Do you have a sample that generates bad hunk header, just to test? > > > > Yes, you'll find a lot of them with "git log -p | grep '@@.*:'" > > Example: > > git show bb6722f | grep '@@.*:' > > Without the patch, it is a goto label in the hunk header. > > > > You are right, I was expecting better from git J Sometimes, less is more :)
[dpdk-dev] Clarification for eth_driver changes
Hello Ferruh, (Please ignore if line wrappings are not correct. Using a possibly unconfigured mail client). > -Original Message- > From: Ferruh Yigit [mailto:ferruh.yigit at intel.com] > Sent: Saturday, November 12, 2016 12:46 AM > To: Shreyansh Jain ; David Marchand > > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] Clarification for eth_driver changes > > On 11/10/2016 11:05 AM, Shreyansh Jain wrote: > > Hello David, > > > > On Thursday 10 November 2016 01:46 PM, David Marchand wrote: > >> Hello Shreyansh, > >> > >> On Thu, Nov 10, 2016 at 8:26 AM, Shreyansh Jain > wrote: > >>> I need some help and clarification regarding some changes I am doing to > >>> cleanup the EAL code. > >>> > >>> There are some changes which should be done for eth_driver/rte_eth_device > >>> structures: > >>> > >>> 1. most obvious, eth_driver should be renamed to rte_eth_driver. > >>> 2. eth_driver currently has rte_pci_driver embedded in it > >>> - there can be ethernet devices which are _not_ PCI > >>> - in which case, this structure should be removed. > >> > >> Do we really need to keep a eth_driver ? > > > > No. As you have rightly mentioned below (as well as in your Jan'16 > > post), it is a mere convenience. > > Isn't it good to separate the logic related which bus device connected > and what functionality it provides. Because these two can be flexible: Indeed. The very idea of a Bus model is to make a hierarchy which allows for pluggability/flexibility in terms of devices being used. But, until now I have only considered placement hierarchy and not functional hierarchy. (more below) > > device -> virtual_bus -> ethernet_functionality > device -> pci_bus -> crypto_functionality > device -> x_bus -> y_function > Ok. > > what about: > > create generic bus driver/device and all eal level deal with generic > bus. different buses inherit from generic bus logic
[dpdk-dev] reassembly app doesn't send pkt
Hi, When I test ip_reassembly app on vmxnet3 nic works fine, but when I change to the nics 82599ES 10-Gigabit SFI/SFP+, it stop to send the packet "reassembled" on tx nic. when I remove the code bellow on rte_ipv4_reassembly.c source code, it sends pkt but truncated. rte_pktmbuf_chain(fp->frags[IP_FIRST_FRAG_IDX].mb, m); Anybody has some tip? I printed all functions like send_single_packet and send_burst and it seems Ok, when I compare ping pkt and udp frag pkt.
