RE: [PATCH v2] net/mlx5: add stub functions to null drv ops
Hi, > -Original Message- > From: Asaf Penso > Sent: Wednesday, December 28, 2022 8:37 PM > To: dev@dpdk.org > Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) ; > Slava Ovsiienko ; Matan Azrad > ; Raslan Darawsheh > Subject: [PATCH v2] net/mlx5: add stub functions to null drv ops > > There are several functions implementation that queries the drv type to > understand which fops function to use. > In case the type is DV, the function gets the concrete DV function and calls > it. > In case it’s not, the function returns an error. > > The current implementation is not flexible enough and will not support > future concrete functions in a good way. > > This patch adds more stub functions that include error handling and are > assigned to the null drv ops struct. > This allows the functions to always call the virtual function without basing > the > decision on a specific drv type. > > Signed-off-by: Asaf Penso Patch applied to next-net-mlx, Kindest regards Raslan Darawsheh
RE: [PATCH v2] net/mlx5: add debug support for dumping all rte ports
Hi, > -Original Message- > From: Alex Vesker > Sent: Wednesday, December 21, 2022 12:10 PM > To: dev@dpdk.org > Cc: Slava Ovsiienko ; Matan Azrad > ; Raslan Darawsheh > Subject: [PATCH v2] net/mlx5: add debug support for dumping all rte ports > > Add a special value max_uint16 to request dump of all > rte ethernet ports. This is useful for collecting the > full info from all the ports in a single dump. > > Signed-off-by: Alex Vesker > Reviewed-by: Ori Kam > --- > drivers/net/mlx5/linux/mlx5_socket.c | 39 ++-- > 1 file changed, 26 insertions(+), 13 deletions(-) > > v2: Fix iteration function to use only mlx5 devices > Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh
RE: [PATCH] net/mlx5: fix wait descriptor opcode for ConnectX-7
Hi,
> -Original Message-
> From: Slava Ovsiienko
> Sent: Tuesday, January 3, 2023 1:11 PM
> To: dev@dpdk.org
> Cc: Matan Azrad ; Raslan Darawsheh
> ; Ori Kam ; sta...@dpdk.org
> Subject: [PATCH] net/mlx5: fix wait descriptor opcode for ConnectX-7
>
> Since ConnectX-7 the special hardware capability to schedule
> packet sending on specified time is provided. It uses special
> WAIT WQE (hardware descriptor) with wait condition defined
> by opcode. The CYCLIC_BIGGER was wrongly used instead of
> CYCLIC_SMALLER. This caused arbitrary and stale time shift
> in traffic scheduling.
>
> Fixes: 49e8797619e40 ("net/mlx5: support wait on time in Tx")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Viacheslav Ovsiienko
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH] net/mlx5: fix irrelevant send skew devarg warning
Hi,
> -Original Message-
> From: Slava Ovsiienko
> Sent: Tuesday, January 3, 2023 1:11 PM
> To: dev@dpdk.org
> Cc: Matan Azrad ; Raslan Darawsheh
> ; Ori Kam ; sta...@dpdk.org
> Subject: [PATCH] net/mlx5: fix irrelevant send skew devarg warning
>
> Since ConnectX-7 hardware supports the send scheduling
> on explicitly specified timestamp, if this feature support
> is detected by PMD the tx_skew devarg becomes applicable
> and appropriate warning should not be emitted.
>
> Fixes: 49e8797619e40 ("net/mlx5: support wait on time in Tx")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Viacheslav Ovsiienko
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH] net/mlx5: fix read device clock in real time mode
Hi,
> -Original Message-
> From: Slava Ovsiienko
> Sent: Tuesday, January 3, 2023 1:12 PM
> To: dev@dpdk.org
> Cc: Matan Azrad ; Raslan Darawsheh
> ; Ori Kam ; sta...@dpdk.org
> Subject: [PATCH] net/mlx5: fix read device clock in real time mode
>
> Since ConnectX-6DX the real time timestamp mode is supported.
> The rte_eth_read_clock() routine queries current timestamp value from the
> PMD.
>
> The mlx5 PMD has special infrastructure to schedule packet sending in real
> time mode which can be engaged with tx_pp devarg.
> This infrastructure provides the timestamp reading from the special queue
> CEQs directly from the host memory in user space, without involving kernel
> calls.
>
> The ConnectX-7 NIC has hardware capability to schedule packet sending
> without special infrastructure and tx_pp devarg can be omitted. If there is no
> tx_pp devarg specified the mlx5 uses kernel calls to query current timestamp
> value. The kernel can be completely unaware about engaged real time
> mode, also kernel might use its internal queue CQEs to get timestamps, that
> is neither precise nor reliable, inconsistent values might be returned,
> causing
> send scheduling malfunction.
>
> The HCA PCI BAR provides the real time direct reading from hardware.
> This patch maps PCI resource to the process address space on demand and
> allows reading the real time timestamp values from the NIC directly.
>
> Fixes: b94d93ca73803 ("net/mlx5: support reading device clock")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Viacheslav Ovsiienko
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH v2 00/10] Support resource sharing among ibv_devices
Hi, > -Original Message- > From: Erez Shitrit > Sent: Thursday, January 5, 2023 3:03 PM > To: dev@dpdk.org > Cc: Alex Vesker ; Raslan Darawsheh > > Subject: [PATCH v2 00/10] Support resource sharing among ibv_devices > > Add the option to use resources (Tables, Matchers, Actions, etc.) from one > gvmi (AKA ibv_cntext) to other gvmi's. > > When specific gvmi allows other to use its resources, steering objects Will > created and used on that gvmi. > > It is done by aliases objects that map between local resources to > shared/remote resources. > > That in order to allow sharing between few ports. > > --- > Changes from V1: > - remove mailing list patch from that series, it will be sent separately > - remove the duplicated set that sent by mistake > --- > > Erez Shitrit (5): > net/mlx5/hws: add capabilities fields for vhca access > net/mlx5/hws: add vhca identifier ID to the caps > net/mlx5/hws: support shared ibv-context with local one > net/mlx5/hws: support actions while shared resources is used > net/mlx5/hws: add debug details for cross gvmi > > Yevgeny Kliteynik (5): > net/mlx5/hws: remove wrong PRM capability macros > net/mlx5/hws: add PRM definitions for cross-vhca capabilities > net/mlx5/hws: read cross-vhca capabilities > net/mlx5/hws: added allow-other-vhca-access command > net/mlx5/hws: added command to create alias objects > > drivers/common/mlx5/mlx5_prm.h | 83 -- > drivers/net/mlx5/hws/mlx5dr.h | 7 +- > drivers/net/mlx5/hws/mlx5dr_action.c | 69 +++- > drivers/net/mlx5/hws/mlx5dr_action.h | 3 + > drivers/net/mlx5/hws/mlx5dr_cmd.c | 118 - > drivers/net/mlx5/hws/mlx5dr_cmd.h | 25 +++ > drivers/net/mlx5/hws/mlx5dr_context.c | 34 +++- > drivers/net/mlx5/hws/mlx5dr_context.h | 22 +++ > drivers/net/mlx5/hws/mlx5dr_debug.c| 24 ++- > drivers/net/mlx5/hws/mlx5dr_internal.h | 1 + > drivers/net/mlx5/hws/mlx5dr_matcher.c | 218 > +++-- > drivers/net/mlx5/hws/mlx5dr_matcher.h | 9 + > drivers/net/mlx5/hws/mlx5dr_table.c| 191 +- > drivers/net/mlx5/hws/mlx5dr_table.h| 4 +- > drivers/net/mlx5/mlx5_devx.c | 2 +- > 15 files changed, 749 insertions(+), 61 deletions(-) > > -- > 2.18.2 Series applied to next-net-mlx, Kindest regards, Raslan Darawsheh
RE: [PATCH] net/mlx5: support ESP item in Verbs interface
Hi, > -Original Message- > From: Maayan Kashani > Sent: Wednesday, January 4, 2023 1:59 PM > To: dev@dpdk.org > Cc: Maayan Kashani ; Matan Azrad > ; Raslan Darawsheh ; Slava > Ovsiienko > Subject: [PATCH] net/mlx5: support ESP item in Verbs interface > > ESP item is not currently supported in Verbs interface. > > Validate/translate ESP item in Verbs interface. > > Signed-off-by: Maayan Kashani > Acked-by: Matan Azrad Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh
RE: [PATCH 1/4] net/mlx5/hws: definitions for Hash Split/Linear Lookup tbls
Hi, > -Original Message- > From: Yevgeny Kliteynik > Sent: Thursday, January 12, 2023 3:49 PM > To: Yevgeny Kliteynik ; Slava Ovsiienko > ; NBU-Contact-Thomas Monjalon (EXTERNAL) > ; Suanming Mou ; > Matan Azrad > Cc: dev@dpdk.org; Ori Kam > Subject: [PATCH 1/4] net/mlx5/hws: definitions for Hash Split/Linear Lookup > tbls > > Added PRM bits for new RTC types: Hash Split and Linear Lookup tables, > as well as for HASH_RESULT field that contains hash result of the > Hash Split table calculation. > > Signed-off-by: Yevgeny Kliteynik Series applied to next-net-mlx, Kindest regards, Raslan Darawsheh
Expect slowness in CI during the week of Feb 5
Hi Guys, Because we are migrating our servers from MTR to MTL, We need to have a shutdown for some of our services/servers in MTR which will affect our CI. In general, the services should continue working, but with a slower resolution time. One of our services (dpdk-tests) will be fully down (can’t be running per PR) during this time. For that, we need your help to make sure you are running the cloud regression yourself on each PR you have. (follow this guideline<https://confluence.nvidia.com/display/NSWX/How+to+run+DPDK+regression+on+cloud+setups>) Kindest regards, Raslan Darawsheh
RE: Expect slowness in CI during the week of Feb 5
You can disregard this email! It was sent by mistake to the wrong mailing address. Sorry for the spam! Kindest regards, Raslan Darawsheh From: Raslan Darawsheh Sent: Monday, January 30, 2023 12:34 PM To: dpdk-team ; dpdk-dev ; shys-org Cc: Ali Alnubani ; Shy Shyman Subject: Expect slowness in CI during the week of Feb 5 Importance: High Hi Guys, Because we are migrating our servers from MTR to MTL, We need to have a shutdown for some of our services/servers in MTR which will affect our CI. In general, the services should continue working, but with a slower resolution time. One of our services (dpdk-tests) will be fully down (can’t be running per PR) during this time. For that, we need your help to make sure you are running the cloud regression yourself on each PR you have. (follow this guideline<https://confluence.nvidia.com/display/NSWX/How+to+run+DPDK+regression+on+cloud+setups>) Kindest regards, Raslan Darawsheh
RE: [PATCH v1 0/4] Enable yellow meter hierarchy
Hi, > -Original Message- > From: Shun Hao > Sent: Friday, May 13, 2022 10:33 AM > To: Slava Ovsiienko ; Matan Azrad > ; Ori Kam > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH v1 0/4] Enable yellow meter hierarchy > > To support yellow meter hierarchy, need to support meter action in yellow > policy flow, so both green and yellow packet can go to next meter. Currently > there's the limitation that only the same next meter supported for green and > yellow. > > Meanwhile, color aware mode is supported, so the next meter can be aware > of the previous color, so can have different process strategy. > > Shun Hao (4): > net/mlx5: support previous meter color aware > net/mlx5: support yellow meter action in hierarchy > net/mlx5: support yellow meter action for hierarchy tag rule > net/mlx5: add validation for yellow meter action > > doc/guides/nics/mlx5.rst | 6 +- > drivers/net/mlx5/mlx5.c| 8 +- > drivers/net/mlx5/mlx5.h| 10 +- > drivers/net/mlx5/mlx5_flow_aso.c | 19 +- > drivers/net/mlx5/mlx5_flow_dv.c| 406 +++-- > drivers/net/mlx5/mlx5_flow_meter.c | 60 +++-- > 6 files changed, 345 insertions(+), 164 deletions(-) > > -- > 2.20.0 Series applied to next-net-mlx, Kindest regards, Raslan Darawsheh
RE: [PATCH] net/mlx5: fix Tx recovery
Hi,
> -Original Message-
> From: Raja Zidane
> Sent: Wednesday, May 18, 2022 12:43 PM
> To: dev@dpdk.org
> Cc: Matan Azrad ; sta...@dpdk.org; Dmitry Kozlyuk
>
> Subject: [PATCH] net/mlx5: fix Tx recovery
>
> When an error occurs in Tx, and it is moved to ERROR state, it is not
> recoverable, during recovery it's state cannot be modified to INIT. to modify
> state from RESET to INIT, the port must be passed in modify attributes, and in
> case of ERROR to READY modification path, it was not provided.
>
> Provide port number when changing state from RESET to INIT.
>
> Fixes: 3a87b964edd3 ("net/mlx5: create Tx queues with DevX")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Raja Zidane
> Acked-by: Matan Azrad
> Acked-by: Dmitry Kozlyuk
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH v1] net/mlx5: add Rx drop counters to xstats
Hi, > -Original Message- > From: Rongwei Liu > Sent: Thursday, May 26, 2022 5:50 AM > To: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon (EXTERNAL) > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH v1] net/mlx5: add Rx drop counters to xstats > > Add two kinds of Rx drop counters to DPDK xstats which are physical port > scope. > > 1. rx_prio[0-7]_buf_discard >The number of unicast packets dropped due to lack of shared >buffer resources. > 2. rx_prio[0-7]_cong_discard >The number of packets that is dropped by the Weighted Random >Early Detection (WRED) function. > > Prio[0-7] is determined by VLAN PCP value which is 0 by default. > Both counters are retrieved from kernel ethtool API which calls PRM > command finally. > > Signed-off-by: Rongwei Liu > Acked-by: Viacheslav Ovsiienko Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh
RE: [PATCH] net/mlx5: fix linux stats gathering function
Hi,
> -Original Message-
> From: Geoffrey Le Gourriérec
> Sent: Thursday, March 17, 2022 3:24 PM
> To: dev@dpdk.org
> Cc: Didier Pallard ; Matan Azrad
> ; Slava Ovsiienko
> Subject: [PATCH] net/mlx5: fix linux stats gathering function
>
> This patch encompasses a few fixes carried by a previous patch
> that aimed to support bonding device stats counting.
>
> - If mlx5_os_read_dev_stat fails, it returns 1 instead of a
> negative value, causing mlx5_xstats_get to return an invalid
> number of counters. Since this error is not blocking, do not
> mess ret value with mlx5_os_read_dev_stat returned value.
>
> This allows avoiding the very annoying log:
> "n_xstats != n_xstats_names => skipping"
>
> - Invert the check for mlx5_os_read_dev_stat(), currently leading
> us to store the result if the function failed, and use a
> backup value if it succeeded, which is the opposite of what we
> actually want. Revert to the original (correct) test.
>
> - Add missing test on _mlx5_os_read_dev_counters() to prevent
> using trash stats values.
>
> Fixes: 7ed15acdcd69 ("net/mlx5: improve xstats of bonding port")
> Signed-off-by: Didier Pallard
> Signed-off-by: Geoffrey Le Gourriérec
>
> ---
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH] common/mlx5: fix list unused lcore check
Hi,
> -Original Message-
> From: Suanming Mou
> Sent: Tuesday, May 31, 2022 4:26 AM
> To: Slava Ovsiienko ; Matan Azrad
>
> Cc: Raslan Darawsheh ; dev@dpdk.org;
> sta...@dpdk.org
> Subject: [PATCH] common/mlx5: fix list unused lcore check
>
> While non-lcore list operations were supported, non-lcore index will be
> converted to MLX5_LIST_NLCORE. In that case, no need to check the lcore
> index be -1 or not anymore.
>
> This commit removes the unused lcore check in list.
>
> Fixes: 7e1cf892711b ("common/mlx5: support list non-lcore operations")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Suanming Mou
> Acked-by: Matan Azrad
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH] net/mlx5: fix entry size in HWS construct data ipool
Hi,
> -Original Message-
> From: Michael Baum
> Sent: Thursday, June 2, 2022 2:39 PM
> To: dev@dpdk.org
> Cc: Matan Azrad ; Raslan Darawsheh
> ; Slava Ovsiienko ;
> Suanming Mou ; sta...@dpdk.org
> Subject: [PATCH] net/mlx5: fix entry size in HWS construct data ipool
>
> The mlx5_action_construct_data structure memory is managed by ipool
> named acts_ipool.
>
> The size of one entry in this ipool is mistakenly defined as size of
> rte_flow_hw structure.
> This size is used to reset in the allocated part. When the size is incorrect
> it
> resets memory that does not belong to it.
>
> This patch defines the correct size.
>
> Fixes: f13fab23922b ("net/mlx5: add flow jump action")
> Cc: suanmi...@nvidia.com
> Cc: sta...@dpdk.org
>
> Signed-off-by: Michael Baum
> Acked-by: Matan Azrad
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH] net/mlx5: support ESP item on Windows
Hi, > -Original Message- > From: Raja Zidane > Sent: Thursday, June 2, 2022 4:03 PM > To: dev@dpdk.org > Cc: Matan Azrad > Subject: [PATCH] net/mlx5: support ESP item on Windows > > ESP item is not supported on windows, yet it is expanded from the > expansion graph when trying to create default flow to RSS all packets. > > Support ESP item match (without ability to match on SPI field on windows). > Split ESP validation per OS. > > Signed-off-by: Raja Zidane > Acked-by: Matan Azrad Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh
RE: [v2] net/mlx5: support represented port item
Hi, > -Original Message- > From: Sean Zhang > Sent: Tuesday, June 7, 2022 2:18 PM > To: NBU-Contact-Thomas Monjalon (EXTERNAL) ; > Matan Azrad ; Slava Ovsiienko > > Cc: dev@dpdk.org > Subject: [v2] net/mlx5: support represented port item > > Add support for represented_port item in pattern. And if the spec and mask > both are NULL, translate function will not add source vport to matcher. > > For example, testpmd starts with PF, VF-rep0 and VF-rep1, below command > will redirect packets from VF0 and VF1 to wire: > testpmd> flow create 0 ingress transfer group 0 pattern eth / > represented_port / end actions represented_port ethdev_id is 0 / end > > Signed-off-by: Sean Zhang > Acked-by: Viacheslav Ovsiienko > --- > v2 -- add missing doc Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh
RE: [v2 0/3] Add support for modifying ECN in IPv4/IPv6 header
Hi, > -Original Message- > From: Sean Zhang > Sent: Tuesday, June 7, 2022 2:19 PM > To: NBU-Contact-Thomas Monjalon (EXTERNAL) > Cc: dev@dpdk.org > Subject: [v2 0/3] Add support for modifying ECN in IPv4/IPv6 header > > This patch set adds support for modifying ECN fields in IPv4/IPv6 header, and > also adds support for modify_filed action in meter. > > --- > v2 --- rebase and add missing doc > --- > Sean Zhang (3): > common/mlx5: add modify ECN capability check > net/mlx5: add support to modify ECN field > net/mlx5: add modify field support in meter > > doc/guides/nics/mlx5.rst | 5 ++- > doc/guides/rel_notes/release_22_07.rst | 1 + > drivers/common/mlx5/mlx5_devx_cmds.c | 3 ++ > drivers/common/mlx5/mlx5_devx_cmds.h | 1 + > drivers/common/mlx5/mlx5_prm.h | 62 > +- > drivers/net/mlx5/mlx5_flow.c | 5 ++- > drivers/net/mlx5/mlx5_flow.h | 2 + > drivers/net/mlx5/mlx5_flow_dv.c| 69 > -- > drivers/net/mlx5/mlx5_flow_meter.c | 2 +- > 9 files changed, 141 insertions(+), 9 deletions(-) > > -- > 1.8.3.1 Series applied to next-net-mlx, Kindest regards, Raslan Darawsheh
RE: [PATCH 1/2] common/mlx5: update log format after devx_general_cmd error
Hi, > -Original Message- > From: Gregory Etelson > Sent: Wednesday, June 8, 2022 2:58 PM > To: dev@dpdk.org; Gregory Etelson > Cc: Raslan Darawsheh ; Matan Azrad > ; Slava Ovsiienko > Subject: [PATCH 1/2] common/mlx5: update log format after > devx_general_cmd error > > Application can fetch syndrome value after FW operation failure > starting from Mellanox OFED-5.6. > The patch updates log data issued after devx_general_cmd error. > > Signed-off-by: Gregory Etelson > Acked-by: Matan Azrad Series applied to next-net-mlx, Kindest regards, Raslan Darawsheh
DPDK Compilation consuming too much memory
Hi, I've been facing an issue while building DPDK (mostly noticeable when building cross compilation on arm64) as follows: meson --werror --buildtype=debugoptimized --cross-file config/arm/arm64_armv8_linux_gcc -Dexamples=all /tmp/build-aarch64-gcc; ninja -C /tmp/build-aarch64-gcc/ I can see the memory footprint for it is around 52G which basically took all my system memory. It happens when linking CNXK drivers. Kindest regards, Raslan Darawsheh
RE: [PATCH v2] net/mlx5: fix build with clang 14
Hi,
> -Original Message-
> From: Ali Alnubani
> Sent: Wednesday, May 11, 2022 7:41 PM
> To: dev@dpdk.org
> Cc: Michael Baum ; sta...@dpdk.org
> Subject: [PATCH v2] net/mlx5: fix build with clang 14
>
> Use fgets instead of fscanf to resolve the following warning reported by
> clang 14.0.0 in Fedora 37 (Rawhide):
>
> drivers/net/mlx5/linux/mlx5_ethdev_os.c:1137:52: error:
> 'fscanf' may overflow; destination buffer in argument 3 has size 16,
> but the corresponding specifier may require size 17
> [-Werror,-Wfortify-source]
> ret = fscanf(file, "%" RTE_STR(IF_NAMESIZE) "s", port_name);
>
> Fixes: 63d1db710fbc ("net/mlx5: fix unlimited parsing of switch info")
> Cc: michae...@mellanox.com
> Cc: sta...@dpdk.org
>
> Signed-off-by: Ali Alnubani
> ---
> Changes in v2:
> - Removed unnecessary variable.
>
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH v10 0/6] introduce per-queue available descriptor threshold and host shaper
Hi, > -Original Message- > From: Spike Du > Sent: Thursday, June 16, 2022 11:42 AM > To: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon (EXTERNAL) > Cc: andrew.rybche...@oktetlabs.ru; step...@networkplumber.org; > m...@smartsharesystems.com; dev@dpdk.org; Raslan Darawsheh > > Subject: [PATCH v10 0/6] introduce per-queue available descriptor threshold > and host shaper > > available descriptor threshold(ADT for short) is per RX queue attribute, when > RX queue available descriptors for HW is below ADT, HW sends an event to > application. > Host shaper can configure shaper rate and avail_thresh-triggered for a host > port. > The shaper limits the rate of traffic from host port to embedded ARM rx port > on Nvidia BlueField 2 NIC. > If avail_thresh-triggered is enabled, a 100Mbps shaper is enabled > automatically when one of the host port's Rx queues receives available > descriptor threshold event. > > These two features can combine to control traffic from host port to wire port > for BlueField 2 NIC. > The traffic flows from host to embedded ARM, then to the physical port. > The work flow is on the ARM system, configure available descriptor threshold > to RX queue and enable avail_thresh-triggered flag in host shaper, after > receiving available descriptor threshold event, delay a while until RX queue > is > empty , then disable the shaper. We recycle this work flow to reduce RX > queue drops on ARM system. > > Add new libethdev API to set available descriptor threshold, add rte event > RTE_ETH_EVENT_RX_AVAIL_THRESH to handle available descriptor threshold > event. For host shaper, because it doesn't align to existing DPDK framework > and is specific to Nvidia NIC, use PMD private API. > > For integration with testpmd, put the private cmdline function and available > descriptor threshold event handler in mlx5 PMD directory by adding a new > file mlx5_testpmd.c. Follow David Marchand's driver specific commands > framework to add mlx5 specific commands. > > Spike Du (6): > net/mlx5: add LWM support for Rxq > common/mlx5: share interrupt management > net/mlx5: add LWM event handling support > net/mlx5: support Rx queue based available descriptor threshold > net/mlx5: add private API to config host port shaper > app/testpmd: add Host Shaper command > > app/test-pmd/testpmd.c | 7 + > doc/guides/nics/mlx5.rst | 93 + > doc/guides/rel_notes/release_22_07.rst | 2 + > drivers/common/mlx5/linux/meson.build| 13 ++ > drivers/common/mlx5/linux/mlx5_common_os.c | 131 > drivers/common/mlx5/linux/mlx5_common_os.h | 11 + > drivers/common/mlx5/mlx5_prm.h | 26 +++ > drivers/common/mlx5/version.map | 2 + > drivers/common/mlx5/windows/mlx5_common_os.h | 24 +++ > drivers/net/mlx5/linux/mlx5_ethdev_os.c | 71 --- > drivers/net/mlx5/linux/mlx5_os.c | 132 +++- > drivers/net/mlx5/linux/mlx5_socket.c | 53 + > drivers/net/mlx5/meson.build | 3 + > drivers/net/mlx5/mlx5.c | 68 +++ > drivers/net/mlx5/mlx5.h | 12 +- > drivers/net/mlx5/mlx5_devx.c | 60 +- > drivers/net/mlx5/mlx5_devx.h | 1 + > drivers/net/mlx5/mlx5_rx.c | 288 > +++ > drivers/net/mlx5/mlx5_rx.h | 13 ++ > drivers/net/mlx5/mlx5_testpmd.c | 205 +++ > drivers/net/mlx5/mlx5_testpmd.h | 26 +++ > drivers/net/mlx5/mlx5_txpp.c | 28 +-- > drivers/net/mlx5/rte_pmd_mlx5.h | 30 +++ > drivers/net/mlx5/version.map | 2 + > drivers/net/mlx5/windows/mlx5_ethdev_os.c| 22 -- > drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 48 + > 26 files changed, 1063 insertions(+), 308 deletions(-) create mode 100644 > drivers/net/mlx5/mlx5_testpmd.c create mode 100644 > drivers/net/mlx5/mlx5_testpmd.h > > -- > 1.8.3.1 Series applied to next-net-mlx, Kindest regards, Raslan Darawsheh
RE: [PATCH v1 0/2] Fix meter flow fail when matching E-Switch Manager
Hi, > -Original Message- > From: Shun Hao > Sent: Sunday, June 19, 2022 6:21 AM > To: Slava Ovsiienko ; Matan Azrad > ; Ori Kam > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH v1 0/2] Fix meter flow fail when matching E-Switch Manager > > When using a meter in flow that matches E-Switch Manager, it will fail due to > not handling E-Switch Manager match item correctly. This series fix this by > using correct handling of parsing E-Switch Manager item. > > Shun Hao (2): > net/mlx5: add limitation for E-Switch Manager match > net/mlx5: fix meter fail when used on E-Switch Manager > > doc/guides/nics/mlx5.rst| 4 ++ > drivers/net/mlx5/mlx5_flow.c| 93 > - > drivers/net/mlx5/mlx5_flow.h| 10 > drivers/net/mlx5/mlx5_flow_dv.c | 42 +++ > 4 files changed, 100 insertions(+), 49 deletions(-) > > -- > 2.20.0 Series applied to next-net-mlx, Kindest regards, Raslan Darawsheh
RE: [PATCH] net/mlx5: fix RSS expansion for patterns with ICMP item
Hi,
> -Original Message-
> From: Gregory Etelson
> Sent: Friday, June 17, 2022 8:23 AM
> To: dev@dpdk.org; Gregory Etelson
> Cc: Raslan Darawsheh ; sta...@dpdk.org; Matan
> Azrad ; Slava Ovsiienko ;
> Ferruh Yigit ; Dekel Peled
> Subject: [PATCH] net/mlx5: fix RSS expansion for patterns with ICMP item
>
> MLX5 PMD RSS expansion implementation added L4 UDP or TCP
> headers after ICMP.
> For example:
> ETH / IPv4 / ICMP expanded into ETH / IPv4 / ICMP / {UDP | TCP}
> ETH / IPv6 / ICMPv6 expanded into ETH / IPv6 / ICMPv6 / {UDP | TCP}
>
> The patch updates PMD expansion scheme to handle ICMP and ICMPv6
> types
> as non-expandable for RSS.
>
> cc: sta...@dpdk.org
>
> Fixes: c7870bfe09dc ("ethdev: move RSS expansion code to mlx5 driver")
> Signed-off-by: Gregory Etelson
> Acked-by: Matan Azrad
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [dpdk-dev] [PATCH 1/1] net/mlx5: fix stack buffer overflow of hrxq's rss_key
Hi,
> -Original Message-
> From: Yunjian Wang
> Sent: Friday, December 24, 2021 5:06 AM
> To: dev@dpdk.org
> Cc: Matan Azrad ; Slava Ovsiienko
> ; Michael Baum ;
> dingxiaoxi...@huawei.com; xudin...@huawei.com; Yunjian Wang
> ; sta...@dpdk.org
> Subject: [dpdk-dev] [PATCH 1/1] net/mlx5: fix stack buffer overflow of hrxq's
> rss_key
>
> The mlx5_drop_action_create function use mlx5_malloc for allocating
> 'hrxq', but don't allocate for 'rss_key'. This is wrong and it can
> cause buffer overflow.
>
> Detected with address sanitizer:
> 0 (/usr/lib64/libasan.so.4+0x7b8e2)
> 1 in mlx5_devx_tir_attr_set ../drivers/net/mlx5/mlx5_devx.c:765
> 2 in mlx5_devx_hrxq_new ../drivers/net/mlx5/mlx5_devx.c:800
> 3 in mlx5_devx_drop_action_create ../drivers/net/mlx5/mlx5_devx.c:1051
> 4 in mlx5_drop_action_create ../drivers/net/mlx5/mlx5_rxq.c:2846
> 5 in mlx5_dev_spawn ../drivers/net/mlx5/linux/mlx5_os.c:1743
> 6 in mlx5_os_pci_probe_pf ../drivers/net/mlx5/linux/mlx5_os.c:2501
> 7 in mlx5_os_pci_probe ../drivers/net/mlx5/linux/mlx5_os.c:2647
> 8 in mlx5_os_net_probe ../drivers/net/mlx5/linux/mlx5_os.c:2722
> 9 in drivers_probe ../drivers/common/mlx5/mlx5_common.c:657
> 10 in mlx5_common_dev_probe
> ../drivers/common/mlx5/mlx5_common.c:711
> 11 in mlx5_common_pci_probe
> ../drivers/common/mlx5/mlx5_common_pci.c:150
> 12 in rte_pci_probe_one_driver ../drivers/bus/pci/pci_common.c:269
> 13 in pci_probe_all_drivers ../drivers/bus/pci/pci_common.c:353
> 14 in pci_probe ../drivers/bus/pci/pci_common.c:380
> 15 in rte_bus_probe ../lib/eal/common/eal_common_bus.c:72
> 16 in rte_eal_init ../lib/eal/linux/eal.c:1286
> 17 in main ../app/test-pmd/testpmd.c:4112
>
> Fixes: 0c762e81da9b ("net/mlx5: share Rx queue drop action code")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Yunjian Wang
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH] net/mlx5: fix thread termination check on Windows
Hi,
> -Original Message-
> From: Tal Shnaiderman
> Sent: Wednesday, October 12, 2022 9:50 AM
> To: dev@dpdk.org
> Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) ;
> Matan Azrad ; Slava Ovsiienko
> ; Raslan Darawsheh ;
> paul203...@gmail.com; Idan Hackmon ;
> sta...@dpdk.org
> Subject: [PATCH] net/mlx5: fix thread termination check on Windows
>
> The mlx5_is_thread_alive function always returns false
> (terminated) regardless to the actual thread state.
>
> Fixed to return the correct thread state.
>
> Bugzilla ID: 1089
> Fixes: 5d55a494f4e62f2 ("net/mlx5: split multi-thread flow handling per OS")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Tal Shnaiderman
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH] net/mlx5: fix thread workspace memory leak
Hi,
> -Original Message-
> From: Bill Zhou
> Sent: Thursday, October 13, 2022 12:34 PM
> To: Slava Ovsiienko ; Matan Azrad
>
> Cc: dev@dpdk.org; Raslan Darawsheh ;
> Xueming(Steven) Li ; sta...@dpdk.org
> Subject: [PATCH] net/mlx5: fix thread workspace memory leak
>
> The thread workspace push/pop should be paired. In the "flow_list_create"
> routine, if error happened the workspace pop was missed. This patch shares
> the workspace pop for all return paths.
>
> Fixes: 0064bf431899 ("net/mlx5: fix nested flow creation")
> Cc: xuemi...@nvidia.com
> Cc: sta...@dpdk.org
>
> Signed-off-by: Dong Zhou
> Acked-by: Viacheslav Ovsiienko
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH v2 2/4] net/mlx5: introduce new mlx5 action flag
Hi, > -Original Message- > From: Michael Savisko > Sent: Wednesday, October 19, 2022 9:40 PM > To: dev@dpdk.org > Cc: Michael Savisko ; Ori Kam ; > Slava Ovsiienko ; Asaf Penso > ; Matan Azrad > Subject: [PATCH v2 2/4] net/mlx5: introduce new mlx5 action flag > > Add new mlx5 action flag MLX5_FLOW_ACTION_SEND_TO_KERNEL. > > Add element MLX5_FLOW_FATE_SEND_TO_KERNEL in enum > mlx5_flow_fate_type. > For that purpose field 'fate_action' in structure mlx5_flow_handle must be > expanded from 3 bits to 4 bits. > > Signed-off-by: Michael Savisko > Acked-by: Matan Azrad > --- > drivers/net/mlx5/mlx5_flow.h| 7 +-- > drivers/net/mlx5/mlx5_flow_dv.c | 17 + Missing doc update for features list, I'll handle during integration Kindest regards, Raslan Darawsheh
RE: [PATCH v2 0/4] net/mlx5: implement send to kernel action
Hi,
> -Original Message-
> From: Michael Savisko
> Sent: Wednesday, October 19, 2022 9:40 PM
> To: dev@dpdk.org
> Cc: Michael Savisko ; Ori Kam ;
> Slava Ovsiienko ; Asaf Penso
> ; Matan Azrad
> Subject: [PATCH v2 0/4] net/mlx5: implement send to kernel action
>
> This patchset provides mlx5 implementation of new rte_flow action
> RTE_FLOW_ACTION_TYPE_SEND_TO_KERNEL.
>
> Depends-on: patch-6838dd4bf976 ("ethdev: add send to kernel action")
>
> Signed-off-by: Michael Savisko
> Acked-by: Matan Azrad
> ---
> v2:
> - updated after code review
>
> v1:
> https://patches.dpdk.org/project/dpdk/list/?series=24734
>
> ---
> Michael Savisko (4):
> common/mlx5: new glue callback for send to kernel action
> net/mlx5: introduce new mlx5 action flag
> net/mlx5: add send to kernel action resource holder
> net/mlx5: translation of rte flow send to kernel action
>
> doc/guides/nics/features/default.ini| 1 +
> doc/guides/nics/features/mlx5.ini | 1 +
> drivers/common/mlx5/linux/meson.build | 2 +
> drivers/common/mlx5/linux/mlx5_glue.c | 17 ++
> drivers/common/mlx5/linux/mlx5_glue.h | 2 +
> drivers/net/mlx5/linux/mlx5_flow_os.h | 22
> drivers/net/mlx5/linux/mlx5_os.c| 13 +
> drivers/net/mlx5/mlx5.h | 6 ++
> drivers/net/mlx5/mlx5_flow.c| 32 +++
> drivers/net/mlx5/mlx5_flow.h| 10 +++-
> drivers/net/mlx5/mlx5_flow_dv.c | 74 +++--
> drivers/net/mlx5/mlx5_flow_hw.c | 3 +
> drivers/net/mlx5/windows/mlx5_flow_os.h | 24
> 13 files changed, 200 insertions(+), 7 deletions(-)
>
> --
> 2.27.0
Series applied to next-net-mlx,
With a small fix for the missing doc on the features list,
Kindest regards,
Raslan Darawsheh
RE: [v6 00/18] net/mlx5: Add HW steering low level support
|9 +-
> drivers/net/mlx5/mlx5.h |8 +-
> drivers/net/mlx5/mlx5_defs.h |2 +
> drivers/net/mlx5/mlx5_devx.c |2 +-
> drivers/net/mlx5/mlx5_dr.c | 383 ---
> drivers/net/mlx5/mlx5_flow.c | 29 +-
> drivers/net/mlx5/mlx5_flow.h | 174 +-
> drivers/net/mlx5/mlx5_flow_dv.c | 2567 +-
> drivers/net/mlx5/mlx5_flow_hw.c | 115 +-
> 48 files changed, 14368 insertions(+), 1694 deletions(-) create mode 100644
> drivers/net/mlx5/hws/meson.build rename drivers/net/mlx5/{mlx5_dr.h =>
> hws/mlx5dr.h} (67%) create mode 100644
> drivers/net/mlx5/hws/mlx5dr_action.c
> create mode 100644 drivers/net/mlx5/hws/mlx5dr_action.h
> create mode 100644 drivers/net/mlx5/hws/mlx5dr_buddy.c
> create mode 100644 drivers/net/mlx5/hws/mlx5dr_buddy.h
> create mode 100644 drivers/net/mlx5/hws/mlx5dr_cmd.c create mode
> 100644 drivers/net/mlx5/hws/mlx5dr_cmd.h create mode 100644
> drivers/net/mlx5/hws/mlx5dr_context.c
> create mode 100644 drivers/net/mlx5/hws/mlx5dr_context.h
> create mode 100644 drivers/net/mlx5/hws/mlx5dr_debug.c
> create mode 100644 drivers/net/mlx5/hws/mlx5dr_debug.h
> create mode 100644 drivers/net/mlx5/hws/mlx5dr_definer.c
> create mode 100644 drivers/net/mlx5/hws/mlx5dr_definer.h
> create mode 100644 drivers/net/mlx5/hws/mlx5dr_internal.h
> create mode 100644 drivers/net/mlx5/hws/mlx5dr_matcher.c
> create mode 100644 drivers/net/mlx5/hws/mlx5dr_matcher.h
> create mode 100644 drivers/net/mlx5/hws/mlx5dr_pat_arg.c
> create mode 100644 drivers/net/mlx5/hws/mlx5dr_pat_arg.h
> create mode 100644 drivers/net/mlx5/hws/mlx5dr_pool.c
> create mode 100644 drivers/net/mlx5/hws/mlx5dr_pool.h
> create mode 100644 drivers/net/mlx5/hws/mlx5dr_rule.c
> create mode 100644 drivers/net/mlx5/hws/mlx5dr_rule.h
> create mode 100644 drivers/net/mlx5/hws/mlx5dr_send.c
> create mode 100644 drivers/net/mlx5/hws/mlx5dr_send.h
> create mode 100644 drivers/net/mlx5/hws/mlx5dr_table.c
> create mode 100644 drivers/net/mlx5/hws/mlx5dr_table.h
> delete mode 100644 drivers/net/mlx5/mlx5_dr.c
>
> --
> 2.18.1
Series applied to next-net-mlx with small modifications to the commit logs,
Kindest regards,
Raslan Darawsheh
RE: [PATCH v6 00/18] net/mlx5: HW steering PMD update
Hi, > -Original Message- > From: Suanming Mou > Sent: Thursday, October 20, 2022 6:42 PM > Cc: dev@dpdk.org; Raslan Darawsheh ; Ori Kam > > Subject: [PATCH v6 00/18] net/mlx5: HW steering PMD update > > The skeleton of mlx5 HW steering(HWS) has been updated into upstream for > pretty a long time, but not updated anymore due to missing of the low-level > steering layer code. Luckily, better late than never, the steering layer > finnaly > comes[1]. > > This series will add more features to the existing PMD code: > - FDB and metadata copy. > - Modify field. > - Meter color. > - Counter. > - Aging. > - Action template pre-parser optimization. > - Connection tracking. > - Control flow. > > Some features such as meter/aging/ct touches the public API, and public API > changes have been sent to ML much earily in other threads in order not to be > swallowed by this big series. > > The dpends patches as below: > [1]https://inbox.dpdk.org/dev/20220922190345.394-1-va...@nvidia.com/ > > --- > > v6: > - Rebase to the latest version. > > v5: > - Rebase to the latest version. > > v4: > - Disable aging due to the flow age API change still in progress. > https://patches.dpdk.org/project/dpdk/cover/20221019144904.2543586-1- > michae...@nvidia.com/ > - Add control flow for HWS. > > v3: > - Fixed flow can't be aged out. > - Fix error not be filled properly while table creat failed. > - Remove transfer_mode in flow attributes before ethdev layer applied. > https://patches.dpdk.org/project/dpdk/patch/20220928092425.68214-1- > rongw...@nvidia.com/ > > v2: > - Remove the rte_flow patches as they will be integrated in other thread. > - Fix compilation issues. > - Make the patches be better organized. > > Alexander Kozyrev (2): > net/mlx5: add HW steering meter action > net/mlx5: implement METER MARK indirect action for HWS > > Bing Zhao (1): > net/mlx5: add extended metadata mode for hardware steering > > Dariusz Sosnowski (5): > net/mlx5: add HW steering port action > net/mlx5: support DR action template API > net/mlx5: support device control for E-Switch default rule > net/mlx5: support device control of representor matching > net/mlx5: create control flow rules with HWS > > Gregory Etelson (2): > net/mlx5: add HW steering VLAN push, pop and VID modify flow actions > net/mlx5: support flow integrity in HWS group 0 > > Michael Baum (1): > net/mlx5: add HWS AGE action support > > Suanming Mou (6): > net/mlx5: fix invalid flow attributes > net/mlx5: fix IPv6 and TCP RSS hash fields > net/mlx5: add shared header reformat support > net/mlx5: add modify field hws support > net/mlx5: add HW steering connection tracking support > net/mlx5: add async action push and pull support > > Xiaoyu Min (1): > net/mlx5: add HW steering counter action > > doc/guides/nics/features/default.ini |1 + > doc/guides/nics/features/mlx5.ini |2 + > doc/guides/nics/mlx5.rst | 43 +- > doc/guides/rel_notes/release_22_11.rst |8 +- > drivers/common/mlx5/mlx5_devx_cmds.c | 50 + > drivers/common/mlx5/mlx5_devx_cmds.h | 27 + > drivers/common/mlx5/mlx5_prm.h | 22 +- > drivers/common/mlx5/version.map|1 + > drivers/net/mlx5/linux/mlx5_os.c | 78 +- > drivers/net/mlx5/meson.build |1 + > drivers/net/mlx5/mlx5.c| 126 +- > drivers/net/mlx5/mlx5.h| 322 +- > drivers/net/mlx5/mlx5_defs.h |5 + > drivers/net/mlx5/mlx5_flow.c | 409 +- > drivers/net/mlx5/mlx5_flow.h | 335 +- > drivers/net/mlx5/mlx5_flow_aso.c | 797 ++- > drivers/net/mlx5/mlx5_flow_dv.c| 1128 +-- > drivers/net/mlx5/mlx5_flow_hw.c| 8789 +--- > drivers/net/mlx5/mlx5_flow_meter.c | 776 ++- > drivers/net/mlx5/mlx5_flow_verbs.c |8 +- > drivers/net/mlx5/mlx5_hws_cnt.c| 1247 > drivers/net/mlx5/mlx5_hws_cnt.h| 703 ++ > drivers/net/mlx5/mlx5_rxq.c|3 +- > drivers/net/mlx5/mlx5_trigger.c| 272 +- > drivers/net/mlx5/mlx5_tx.h |1 + > drivers/net/mlx5/mlx5_txq.c| 47 + > drivers/net/mlx5/mlx5_utils.h | 10 +- > drivers/net/mlx5/rte_pmd_mlx5.h | 17 + > drivers/net/mlx5/version.map |1 + > 29 files changed, 13589 insertions(+), 1640 deletions(-) create mode 100644 > drivers/net/mlx5/mlx5_hws_cnt.c create mode 100644 > drivers/net/mlx5/mlx5_hws_cnt.h > > -- > 2.25.1 Series applied to next-net-mlx with small modifications to the commit logs. Kindest regards, Raslan Darawsheh
RE: [PATCH] net/mlx5: fix wrong free function in HWS AGE info
Hi,
> -Original Message-
> From: Michael Baum
> Sent: Monday, October 24, 2022 4:28 PM
> To: dev@dpdk.org
> Cc: Matan Azrad ; Raslan Darawsheh
> ; Slava Ovsiienko ; Michael
> Baum
> Subject: [PATCH] net/mlx5: fix wrong free function in HWS AGE info
>
> In AGE info initialization, the mlx5_hws_q_age_info structure is allocated by
> "mlx5_malloc" function.
>
> However, in case of failure, this structure is released by "rte_free".
>
> This patch changes it to use "mlx5_free".
>
> Fixes: 32c98171674f ("net/mlx5: add HWS AGE action support")
> Cc: michae...@nvidia.com
>
> Signed-off-by: Michael Baum
> Acked-by: Matan Azrad
Patch squashed into relevant commit in next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH] net/mlx5: fix RSS expansion buffer size
Hi,
> -Original Message-
> From: Gregory Etelson
> Sent: Thursday, October 20, 2022 12:59 PM
> To: dev@dpdk.org
> Cc: Gregory Etelson ; Matan Azrad
> ; Raslan Darawsheh ; Slava
> Ovsiienko ; Lior Margalit
> Subject: [PATCH] net/mlx5: fix RSS expansion buffer size
>
> Increase expansion buffer size to accumulate more RSS types.
>
> Fixes: 3f02c7ff6815 ("net/mlx5: fix RSS expansion for inner tunnel VLAN")
>
> Signed-off-by: Gregory Etelson
> Acked-by: Matan Azrad
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH] net/mlx5: fix tunnel header with IPIP offload
Hi,
> -Original Message-
> From: Jiawei(Jonny) Wang
> Sent: Thursday, October 20, 2022 3:56 PM
> To: Slava Ovsiienko ; Matan Azrad
> ; Ori Kam ; Raslan Darawsheh
> ; Lior Margalit
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: [PATCH] net/mlx5: fix tunnel header with IPIP offload
>
> For the flows with multiple tunnel layers and containing tunnel decap and
> modify actions, for example:
>
> ... / vxlan / eth / ipv4 proto is 4 / end actions raw_decap / modify_field /
> ...
> (note: proto 4 means we have the IP-over-IP tunnel in VXLAN payload)
>
> We have added the multiple tunnel layers validation rejecting the flows like
> above mentioned one.
>
> The hardware supports the above match combination till the inner IP-over-IP
> header (not including the last one), both for IP-over-IPv4 and IP-over-IPv6,
> so we should not blindly reject. Also, for the modify actions following the
> decap we should set the layer attributes correctly.
>
> This patch reverts the below code changes to support the match, and adjusts
> the layers update in case of decap with outer tunnel header.
>
> Fixes: fa06906a48ee ("net/mlx5: fix IPIP multi-tunnel validation")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Jiawei Wang
> Acked-by: Slava Ovsiienko
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [v4] net/mlx5: support matching flow on port representor ID
Hi, > -Original Message- > From: Sean Zhang > Sent: Tuesday, October 25, 2022 9:31 AM > To: NBU-Contact-Thomas Monjalon (EXTERNAL) ; > Matan Azrad ; Slava Ovsiienko > > Cc: dev@dpdk.org > Subject: [v4] net/mlx5: support matching flow on port representor ID > > Add support for port_representor item, it will match on traffic originated > from representor port specified in the pattern. This item is supported in FDB > steering domain only (in the flow with transfer attribute). > > For example, below flow will redirect the destination of traffic from ethdev 1 > to ethdev 2. > > testpmd> ... pattern eth / port_representor port_id is 1 / end actions > represented_port ethdev_port_id 2 / ... > > To handle abovementioned item, Tx queue matching is added in the driver, > and the flow will be expanded to number of the Tx queues. If the spec of > port_representor is NULL, the flow will not be expanded and match on traffic > from any representor port. > > Signed-off-by: Sean Zhang > Acked-by: Viacheslav Ovsiienko > --- > The depending patches as below: > > [1] http://patches.dpdk.org/project/dpdk/cover/20220930125315.5079-1- > suanmi...@nvidia.com > --- > v4 - update the commit title > v3 - rebase to the latest version > v2 - commit message updated and add missing feature in doc > --- Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh
RE: [PATCH 0/2] mlx5: fix miss NULL check in devargs parsing
Hi, > -Original Message- > From: Michael Baum > Sent: Monday, October 24, 2022 3:34 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Slava Ovsiienko > Subject: [PATCH 0/2] mlx5: fix miss NULL check in devargs parsing > > The MLX5 PMD parses the devargs in several places. > It gets structure called "devargs" as a member of EAL device containing all > needed information. > > When "devargs" structure is invalid, the PMD avoids parsing it. > However, when it valid but its field "args" is invalid, the PMD tries to > parse it > and dereference to NULL pointer. > > Those patches add checks to avoid these NULL dereferencing. > > > Michael Baum (2): > common/mlx5: fix miss null check in devargs parsing > net/mlx5: fix miss null check in ETH devargs parsing > > drivers/common/mlx5/mlx5_common.c | 8 +--- > drivers/net/mlx5/linux/mlx5_os.c | 2 +- > 2 files changed, 6 insertions(+), 4 deletions(-) > > -- > 2.25.1 Series applied to next-net-mlx, Kindest regards, Raslan Darawsheh
RE: [PATCH] net/mlx5: fix assert failure in item translation
Hi,
> -Original Message-
> From: Suanming Mou
> Sent: Wednesday, October 26, 2022 5:09 AM
> To: Matan Azrad ; Slava Ovsiienko
>
> Cc: dev@dpdk.org; Raslan Darawsheh
> Subject: [PATCH] net/mlx5: fix assert failure in item translation
>
> When HW Steering is enabled, mlx5dr translates flow items using DV
> item translation functions to configure flows in root flow table.
> Represented port item stores vport metadata tag in thread-local
> workspace when translate to DV spec. Due to the thread-local workspace
> was not created in HW Steering, it caused an assertion in
> mlx5_flow_get_thread_workspace()
>
> This patch adds initialization of thread-local workspace when flow items
> are translated to DV spec in HW Steering mode.
>
> Fixes: cfddba76af4f ("net/mlx5: add hardware steering item translation
> function")
>
> Signed-off-by: Suanming Mou
> Acked-by: Viacheslav Ovsiienko
Squashed into relevant commit in next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH] net/mlx5/hws: set ft_type on root matcher creation
Hi,
> -Original Message-
> From: Suanming Mou
> Sent: Wednesday, October 26, 2022 5:10 AM
> To: Matan Azrad ; Slava Ovsiienko
>
> Cc: dev@dpdk.org; Raslan Darawsheh ; Alex Vesker
>
> Subject: [PATCH] net/mlx5/hws: set ft_type on root matcher creation
>
> The ft_type should be provided to mlx5dv_create_flow_matcher
> if the matcher attributes exist, not only for FDB but for NIC
> as well. If the ft_type is not provided, matcher/rule creation
> might fail.
>
> Fixes: ac7931dd1908 ("net/mlx5/hws: add HWS matcher object")
>
> Signed-off-by: Alex Vesker
> Signed-off-by: Suanming Mou
> Acked-by: Viacheslav Ovsiienko
Squashed into relevant commit in next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH] net/mlx5: remove unneeded SQ null checking
Hi,
> -Original Message-
> From: Suanming Mou
> Sent: Wednesday, October 26, 2022 9:33 AM
> To: Matan Azrad ; Slava Ovsiienko
>
> Cc: dev@dpdk.org; Raslan Darawsheh
> Subject: [PATCH] net/mlx5: remove unneeded SQ null checking
>
> The ASO SQ is a dynamic array in the ASO pool struct. That means
> the checking of the SQ pointer is incorrect and not needed. And
> the mlx5_aso_destroy_sq() function internally also checks if inside
> the SQ any resources need to be released or not. There is no need
> to have that extra checking.
>
> This commit removes the redundant checking code.
>
> Fixes: aa90929cd5db ("net/mlx5: add HW steering connection tracking
> support")
>
> Signed-off-by: Suanming Mou
> Acked-by: Matan Azrad
Squashed into relevant commit into next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH] doc: add Rx buffer split capability for mlx5
Hi,
> -Original Message-
> From: Thomas Monjalon
> Sent: Sunday, October 9, 2022 11:20 PM
> To: dev@dpdk.org
> Cc: ferruh.yi...@amd.com; andrew.rybche...@oktetlabs.ru;
> sta...@dpdk.org; Matan Azrad ; Slava Ovsiienko
>
> Subject: [PATCH] doc: add Rx buffer split capability for mlx5
>
> When adding buffer split feature to mlx in DPDK 20.11, it has been forgotten
> to fill the feature matrix.
>
> Fixes: 6c8f7f1c1877 ("net/mlx5: report Rx buffer split capabilities")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Thomas Monjalon
Acked-by: Raslan Darawsheh
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: Impact due to the Electricity Shutdown next week
FYI, This means that we’ll not have any regression tonight. And work on features can continue only on local setups. Kindest regards, Raslan Darawsheh From: Eyal Gruber Sent: Wednesday, November 2, 2022 1:32 PM To: yarong-org Subject: RE: Impact due to the Electricity Shutdown next week Remainder, The cloud will be down starting today at ~15:00 until tomorrow Thanks, Eyal From: Eyal Gruber Sent: Wednesday, 26 October 2022 11:58 To: yarong-org mailto:yarong-...@exchange.nvidia.com>> Subject: Impact due to the Electricity Shutdown next week Importance: High Hi, Next week there will be an electricity Shutdown at Hermon Building (see attached mail) * When: Start time: Wednesday, November 2, 3pm, IL time (the shutdown itself starts at 4pm. Our services will go down 1 hour before) End time: Thursday, November 3, 9am, IL time * Impacted services: * Regressions * CI * OFED builds * Linux cloud Please be aware that additional services which are not provided by our team might also be impacted by the shutdown. Thanks, Eyal
RE: [PATCH 03/13] net/idpf: support device initialization
IRTCHNL2_CAP_TX_CSUM_GENERIC |
> + VIRTCHNL2_CAP_RX_CSUM_L3_IPV4 |
> + VIRTCHNL2_CAP_RX_CSUM_L4_IPV4_TCP |
> + VIRTCHNL2_CAP_RX_CSUM_L4_IPV4_UDP |
> + VIRTCHNL2_CAP_RX_CSUM_L4_IPV4_SCTP |
> + VIRTCHNL2_CAP_RX_CSUM_L4_IPV6_TCP |
> + VIRTCHNL2_CAP_RX_CSUM_L4_IPV6_UDP |
> + VIRTCHNL2_CAP_RX_CSUM_L4_IPV6_SCTP |
> + VIRTCHNL2_CAP_RX_CSUM_GENERIC;
> +
> + caps_msg.seg_caps =
> + VIRTCHNL2_CAP_SEG_IPV4_TCP |
> + VIRTCHNL2_CAP_SEG_IPV4_UDP |
> + VIRTCHNL2_CAP_SEG_IPV4_SCTP|
> + VIRTCHNL2_CAP_SEG_IPV6_TCP |
> + VIRTCHNL2_CAP_SEG_IPV6_UDP |
> + VIRTCHNL2_CAP_SEG_IPV6_SCTP|
> + VIRTCHNL2_CAP_SEG_GENERIC;
> +
> + caps_msg.rss_caps =
> + VIRTCHNL2_CAP_RSS_IPV4_TCP |
> + VIRTCHNL2_CAP_RSS_IPV4_UDP |
> + VIRTCHNL2_CAP_RSS_IPV4_SCTP|
> + VIRTCHNL2_CAP_RSS_IPV4_OTHER |
> + VIRTCHNL2_CAP_RSS_IPV6_TCP |
> + VIRTCHNL2_CAP_RSS_IPV6_UDP |
> + VIRTCHNL2_CAP_RSS_IPV6_SCTP|
> + VIRTCHNL2_CAP_RSS_IPV6_OTHER |
> + VIRTCHNL2_CAP_RSS_IPV4_AH |
> + VIRTCHNL2_CAP_RSS_IPV4_ESP |
> + VIRTCHNL2_CAP_RSS_IPV4_AH_ESP |
> + VIRTCHNL2_CAP_RSS_IPV6_AH |
> + VIRTCHNL2_CAP_RSS_IPV6_ESP |
> + VIRTCHNL2_CAP_RSS_IPV6_AH_ESP;
> +
> + caps_msg.hsplit_caps =
> + VIRTCHNL2_CAP_RX_HSPLIT_AT_L2 |
> + VIRTCHNL2_CAP_RX_HSPLIT_AT_L3 |
> + VIRTCHNL2_CAP_RX_HSPLIT_AT_L4V4|
> + VIRTCHNL2_CAP_RX_HSPLIT_AT_L4V6;
> +
> + caps_msg.rsc_caps =
> + VIRTCHNL2_CAP_RSC_IPV4_TCP |
> + VIRTCHNL2_CAP_RSC_IPV4_SCTP|
> + VIRTCHNL2_CAP_RSC_IPV6_TCP |
> + VIRTCHNL2_CAP_RSC_IPV6_SCTP;
> +
> + caps_msg.other_caps =
> + VIRTCHNL2_CAP_RDMA |
> + VIRTCHNL2_CAP_SRIOV|
> + VIRTCHNL2_CAP_MACFILTER|
> + VIRTCHNL2_CAP_FLOW_DIRECTOR|
> + VIRTCHNL2_CAP_SPLITQ_QSCHED|
> + VIRTCHNL2_CAP_CRC |
> + VIRTCHNL2_CAP_WB_ON_ITR|
> + VIRTCHNL2_CAP_PROMISC |
> + VIRTCHNL2_CAP_LINK_SPEED |
> + VIRTCHNL2_CAP_VLAN;
> +
> + args.ops = VIRTCHNL2_OP_GET_CAPS;
> + args.in_args = (uint8_t *)&caps_msg;
> + args.in_args_size = sizeof(caps_msg);
> + args.out_buffer = adapter->mbx_resp;
> + args.out_size = IDPF_DFLT_MBX_BUF_SIZE;
> +
> + err = idpf_execute_vc_cmd(adapter, &args);
> + if (err) {
> + PMD_DRV_LOG(ERR,
> + "Failed to execute command of
> VIRTCHNL2_OP_GET_CAPS");
> + return err;
> + }
> +
> + rte_memcpy(adapter->caps, args.out_buffer, sizeof(caps_msg));
> +
> + return err;
> +}
> +
> +int
> +idpf_create_vport(__rte_unused struct rte_eth_dev *dev) {
> + uint16_t idx = adapter->next_vport_idx;
> + struct virtchnl2_create_vport *vport_req_info =
> +
RE: [PATCH] net/mlx5/hws: remove deprecated rte_atomic
Hi,
> -Original Message-
> From: Alex Vesker
> Sent: Sunday, October 30, 2022 6:12 PM
> To: Alex Vesker ; Slava Ovsiienko
> ; NBU-Contact-Thomas Monjalon (EXTERNAL)
> ; Suanming Mou ;
> Matan Azrad
> Cc: dev@dpdk.org; Ori Kam
> Subject: [PATCH] net/mlx5/hws: remove deprecated rte_atomic
>
> The use of rte_atomic functions is deprecated and is not required in HWS
> code. HWS refcounts are used only during control and always under lock.
>
> Fixes: f8c8a6d8440d ("net/mlx5/hws: add action object")
> Signed-off-by: Alex Vesker
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH] net/mlx5: enable flow aging action
Hi, > -Original Message- > From: Suanming Mou > Sent: Monday, October 31, 2022 10:21 AM > To: Matan Azrad ; Slava Ovsiienko > > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH] net/mlx5: enable flow aging action > > As the queue-based aging API has been integrated[1], the flow aging action > support in HWS steering code can be enabled now. > > [1]: > https://patchwork.dpdk.org/project/dpdk/cover/20221026214943.3686635- > 1-michae...@nvidia.com/ > > Signed-off-by: Suanming Mou Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh
RE: [PATCH 0/5] net/mlx5: some counter fixes
Hi, > -Original Message- > From: Michael Baum > Sent: Monday, October 31, 2022 6:08 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Slava Ovsiienko > Subject: [PATCH 0/5] net/mlx5: some counter fixes > > Some fixes for HW/SW steering counters. > > Michael Baum (5): > net/mlx5: fix race condition in counter pool resizing > net/mlx5: fix accessing the wrong counter > net/mlx5: fix missing counter elements copies in r2r cases > net/mlx5: add assertions in counter get/put > net/mlx5: assert for enough space in counter rings > > drivers/net/mlx5/mlx5.c| 28 ++- > drivers/net/mlx5/mlx5.h| 7 +- > drivers/net/mlx5/mlx5_flow.c | 24 +++--- > drivers/net/mlx5/mlx5_flow_dv.c| 53 +++-- > drivers/net/mlx5/mlx5_flow_hw.c| 2 +- > drivers/net/mlx5/mlx5_flow_verbs.c | 23 ++ > drivers/net/mlx5/mlx5_hws_cnt.c| 25 +++--- > drivers/net/mlx5/mlx5_hws_cnt.h| 117 - > 8 files changed, 131 insertions(+), 148 deletions(-) > > -- > 2.25.1 Series applied to next-net-mlx, Kindest regards, Raslan Darawsheh
RE: [PATCH v1] net/mlx5: fix action flag data type
Hi,
> -Original Message-
> From: Shun Hao
> Sent: Tuesday, November 1, 2022 12:07 PM
> To: Slava Ovsiienko ; Matan Azrad
> ; Ori Kam ; Bing Zhao
>
> Cc: dev@dpdk.org; Raslan Darawsheh ;
> sta...@dpdk.org
> Subject: [PATCH v1] net/mlx5: fix action flag data type
>
> MLX5_FLOW_ACTION flags are used as uint64_t now, but some old flags
> are not defined as 64 bits. So if they are type casted to uint64 after
> bitwise operations, the high 32-bit data might be incorrect.
>
> E.g. Currently MLX5_FLOW_ACTION_DROP is defined as 0x1u, when it is
> used
> like:
> (action_flags & ~MLX5_FLOW_ACTION_DROP)
> action_flags is uint64_t so (~MLX5_FLOW_ACTION_DROP) will be casted to
> uint64_t as well, but its high 32 bits will be all 0s. This will make the
> result not as expected.
>
> This patch fixes this by making all action flags definition as 64-bit
> data type.
>
> Fixes: 4b7bf3ff ("net/mlx5: support yellow in meter policy validation")
> Cc: sta...@dpdk.org
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH 0/2] net/mlx5: fix some sample/mirror issues
Hi, > -Original Message- > From: Jiawei(Jonny) Wang > Sent: Wednesday, November 2, 2022 3:44 PM > To: Slava Ovsiienko ; Matan Azrad > > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH 0/2] net/mlx5: fix some sample/mirror issues > > Some fixes for sample/mirror issues. > > Jiawei Wang (2): > net/mlx5: fix flow source port checking in sample flow rule > net/mlx5: fix mirror flow validation with ASO action > > drivers/net/mlx5/mlx5_flow.c| 55 +--- > drivers/net/mlx5/mlx5_flow.h| 19 ++ > drivers/net/mlx5/mlx5_flow_dv.c | 110 > 3 files changed, 133 insertions(+), 51 deletions(-) > > -- > 2.18.1 Series applied to next-net-mlx, Kindest regards, Raslan Darawsheh
RE: [PATCH] net/mlx5: forbid direction attributes in transfer flow rules
Hi,
> -Original Message-
> From: Dariusz Sosnowski
> Sent: Thursday, November 3, 2022 12:10 PM
> To: Matan Azrad ; Slava Ovsiienko
>
> Cc: dev@dpdk.org; Raslan Darawsheh
> Subject: [PATCH] net/mlx5: forbid direction attributes in transfer flow rules
>
> Since [1] flow API forbids usage of direction attributes in transfer
> flow rules. This patch adapts mlx5 PMD to this requirement.
>
> From this patch, flow rule validation in mxl5 PMD will reject transfer
> flow rules with any of the direction attributes set
> (i.e. 'ingress' or 'egress').
> As a result flow rule can only have one of 'ingress', 'egress' or
> 'transfer' attributes set.
>
> This patch also changes the following:
>
> - Control flow rules used in FDB are 'transfer' only.
> - Checks which assumed that 'transfer' can be used
> with 'ingress' and 'egress' are reduced to just checking
> for direction attributes, since all attributes are exclusive.
> - Flow rules for updating flow_tag are created for both ingress
> and transfer flow rules which have MARK action.
> - Moves mlx5_flow_validate_attributes() function from generic flow
> implementation to legacy Verbs flow engine implementation,
> since it was used only there. Function is renamed accordingly.
> Also removes checking if E-Switch uses DV in that
> function, since if legacy Verbs flow engine is used,
> then that is always not the case.
>
> [1] commit bd2a4d4b2e3a ("ethdev: forbid direction attribute in
> transfer flow rules")
>
> Signed-off-by: Dariusz Sosnowski
> Acked-by: Matan Azrad
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH] common/mlx5: fix shared mempool subscription
Hi,
> -Original Message-
> From: Gregory Etelson
> Sent: Thursday, November 3, 2022 12:44 PM
> To: dev@dpdk.org
> Cc: Gregory Etelson ; Matan Azrad
> ; Raslan Darawsheh ;
> sta...@dpdk.org; Slava Ovsiienko ; Anatoly
> Burakov ; Dmitry Kozlyuk
>
> Subject: [PATCH] common/mlx5: fix shared mempool subscription
>
> MLX5 PMD counted each mempool subscribe invocation. The PMD expected
> that the mempool subscription will be deleted after the mempool counter
> dropped to 0. However, current PMD design unsubscribes mempool
> callbacks only once.
> As the result, the PMD destroyed mlx5_common_device but kept shared RX
> subscription callback. EAL tried to activate that callback and crashed.
>
> The patch removes mempool subscriptions counter.
> The PMD registers mempool subscription once only. An attempt to register
> existing subscription returns EEXIST.
> Also, the PMD expects to remove subscription when mempool unsubscribe
> was activated.
>
> Fixes: 8ad97e4b3215 ("common/mlx5: fix multi-process mempool
> registration")
>
> Cc: sta...@dpdk.org
>
> Signed-off-by: Gregory Etelson
> Acked-by: Matan Azrad
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH v1] net/mlx5: fix incorrect match mask for meter flow
Hi,
> -Original Message-
> From: Shun Hao
> Sent: Thursday, November 3, 2022 5:33 PM
> To: Slava Ovsiienko ; Matan Azrad
> ; Ori Kam ; Suanming Mou
>
> Cc: dev@dpdk.org; Raslan Darawsheh ;
> sta...@dpdk.org
> Subject: [PATCH v1] net/mlx5: fix incorrect match mask for meter flow
>
> There's an issue introduced by the change of splitting item matcher
> and value translation, that the matcher mask value for color is not
> set correctly in meter policy flow creation.
>
> This patch fixes this by providing the correct color mask.
>
> Fixes: cd4ab74206 ("net/mlx5: split flow item matcher and value translation")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Shun Hao
> Acked-by: Matan Azrad
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH v2] net/mlx5: fix Windows flow table and queue routine
Hi,
> -Original Message-
> From: Suanming Mou
> Sent: Sunday, November 6, 2022 5:26 AM
> To: Matan Azrad ; Slava Ovsiienko
>
> Cc: dev@dpdk.org; Raslan Darawsheh
> Subject: [PATCH v2] net/mlx5: fix Windows flow table and queue routine
>
> The macro HAVE_MLX5_HWS_SUPPORT was introduced for HWS only. And
> HWS was not supported on Windows. So macro
> HAVE_MLX5_HWS_SUPPORT
> should be only around the code which HWS uses, but avoid including
> the code block shared by Linux and Windows.
>
> Fixes: 22681deead3e ("net/mlx5/hws: enable hardware steering")
>
> Signed-off-by: Suanming Mou
> Acked-by: Viacheslav Ovsiienko
> ---
> v2:
> - add ack info.
> - fix typo.
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH] net/mlx5: fix shared Rx queue config reuse
Hi,
> -Original Message-
> From: Alexander Kozyrev
> Sent: Wednesday, November 2, 2022 4:25 PM
> To: dev@dpdk.org
> Cc: sta...@dpdk.org; Raslan Darawsheh ; Slava
> Ovsiienko ; Matan Azrad ;
> Xueming(Steven) Li
> Subject: [PATCH] net/mlx5: fix shared Rx queue config reuse
>
> There is a check for the configuration match between all the Rx queues
> shared among multiple ports in DPDK.
> This check ensures that the configuration is the same.
>
> The issue is this check takes place before the queue is released and
> configured again in case of reconfiguration.
> That leads to checking against the old configuration and preventing the
> shared Rx queue to start properly.
>
> Release the old configuration and prepare a new Rx queue before checking
> that its parameters match the config.
>
> Fixes: 09c2555303 ("net/mlx5: support shared Rx queue")
>
> Signed-off-by: Alexander Kozyrev
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH v2] mlx5/testpmd: fix crash on quit with avail thresh enabled
Hi,
> -Original Message-
> From: Spike Du
> Sent: Wednesday, November 2, 2022 1:44 PM
> To: Matan Azrad ; Slava Ovsiienko
> ; Ori Kam ; NBU-Contact-
> Thomas Monjalon (EXTERNAL) ; Shahaf Shuler
>
> Cc: dev@dpdk.org; Raslan Darawsheh ;
> sta...@dpdk.org
> Subject: [PATCH v2] mlx5/testpmd: fix crash on quit with avail thresh enabled
>
> When testpmd quit with mlx5 avail_thresh enabled, a rte timer handler
> delays to reconfigure rx queue to re-arm this event. However at the same
> time, testpmd is destroying rx queues.
> It's never a valid use case for mlx5 avail_thresh. Before testpmd quit,
> user should disable avail_thresh configuration to not handle the events.
> This is documented in mlx5 driver guide.
>
> To avoid the crash in such use case, check port status, if it is not
> RTE_PORT_STARTED, don't process the avail_thresh event.
>
> Fixes: f41a5092e6ae ("app/testpmd: add host shaper command")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Spike Du
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH] net/mlx5/hws: fix possible negative return on sq create
Hi,
> -Original Message-
> From: Alex Vesker
> Sent: Thursday, November 3, 2022 2:52 PM
> To: Alex Vesker ; Slava Ovsiienko
> ; NBU-Contact-Thomas Monjalon (EXTERNAL)
> ; Suanming Mou ;
> Matan Azrad
> Cc: dev@dpdk.org; Ori Kam
> Subject: [PATCH] net/mlx5/hws: fix possible negative return on sq create
>
> The sysconf call can return a negative value (-1) on failure
> this will lead to posix_memalign to fail. This is not a realistic
> case which was found by the static checkers.
>
> Fixes: 3eb7488 ("net/mlx5/hws: add send layer")
missing empty line between fixes and signed-off-by will handle during
integration.
> Signed-off-by: Alex Vesker
> Reviewed-by: Erez Shitrit
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH v2] net/mlx5/hws: fix possible action setter segmenation fault
Hi,
> -Original Message-
> From: Alex Vesker
> Sent: Monday, November 7, 2022 12:18 PM
> To: Alex Vesker ; Slava Ovsiienko
> ; NBU-Contact-Thomas Monjalon (EXTERNAL)
> ; Suanming Mou ;
> Matan Azrad
> Cc: dev@dpdk.org; Ori Kam
> Subject: [PATCH v2] net/mlx5/hws: fix possible action setter segmenation
> fault
>
> When the maximum action combination in RX is used we can get a segfault
> due to an incorrecrt max array size define.
> This bug can happen on RX/TX or FDB in the most complex cases.
> Current max was set to 7, but actual max is:
> Max TX: 8, Max RX: 10, Max FDB: 9
>
> Fixes: f8c8a6d ("net/mlx5/hws: add action object")
missing empty line - will handle during integration
> Signed-off-by: Alex Vesker
> Reviewed-by: Erez Shitrit
> Acked-by: Matan Azrad
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH v2] net/mlx5/hws: fix action creation check for HWS support
Hi,
> -Original Message-
> From: Alex Vesker
> Sent: Monday, November 7, 2022 1:04 PM
> To: Alex Vesker ; Slava Ovsiienko
> ; NBU-Contact-Thomas Monjalon (EXTERNAL)
> ; Suanming Mou ;
> Matan Azrad
> Cc: dev@dpdk.org; Ori Kam
> Subject: [PATCH v2] net/mlx5/hws: fix action creation check for HWS support
>
> Fix segmentation fault when a user will request to allocate a HWS action
> while current device doesn't support HWS.
>
> Fixes: f8c8a6d ("net/mlx5/hws: add action object")
> Signed-off-by: Alex Vesker
> Reviewed-by: Erez Shitrit
> Acked-by: Matan Azrad
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH v2] net/mlx5/hws: fix capability check to allow HWS on non esw-mngr
Hi,
> -Original Message-
> From: Alex Vesker
> Sent: Monday, November 7, 2022 1:07 PM
> To: Alex Vesker ; Slava Ovsiienko
> ; NBU-Contact-Thomas Monjalon (EXTERNAL)
> ; Suanming Mou ;
> Matan Azrad
> Cc: dev@dpdk.org; Ori Kam
> Subject: [PATCH v2] net/mlx5/hws: fix capability check to allow HWS on non
> esw-mngr
>
changed commit title a bit,
> On context initialization the reparse capability support
> for NIC and FDB tables was required for allowing HWS. This
> caused a problem for devices that only want to run NIC
> steering and are not the esw-manager fow which FDB reparse
> is disabled. Modified the check to require FDB reparse only for
> esw-manager.
>
> Fixes: b0290e5 ("net/mlx5/hws: add context object")
added missing empty line
> Signed-off-by: Alex Vesker
> Reviewed-by: Erez Shitrit
> Acked-by: Matan Azrad
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH] net/mlx5: fix hairpin split with set VLAN VID action
Hi,
> -Original Message-
> From: Dariusz Sosnowski
> Sent: Monday, November 7, 2022 12:29 PM
> To: Matan Azrad ; Slava Ovsiienko
>
> Cc: dev@dpdk.org; Raslan Darawsheh ;
> sta...@dpdk.org
> Subject: [PATCH] net/mlx5: fix hairpin split with set VLAN VID action
>
> Before this patch any flow rule which works on hairpin queues and which has
> OF_SET_VLAN_VID action was split into 2 flow rules:
>
> - one subflow for Rx,
> - one subflow for Tx.
>
> OF_SET_VLAN_VID action was always placed in the Tx subflow.
>
> Assuming a flow rule which matches VLAN traffic and has both
> OF_SET_VLAN_VID action, and MODIFY_FIELD action on VLAN VID, but no
> OF_PUSH_VLAN action, the following happened:
>
> - MODIFY_FIELD action was placed in Rx subflow,
> - OF_SET_VLAN_VID action was placed in Tx subflow,
> - OF_SET_VLAN_VID action is internally compiled to a header modify
> command.
>
> This caused the following issues:
>
> 1. Since OF_SET_VLAN_VID was placed in Tx subflow, 2 header modify
>actions were allocated. One for Rx and one for Tx.
> 2. If OF_SET_VLAN_VID action was placed before MODIFY_FIELD on VLAN
> VID,
>the flow rule executed header modifications in reverse order.
>MODIFY_FIELD actions were executed first in the Rx subflow and
>OF_SET_VLAN_VID was executed second in Tx subflow.
>
> This patch fixes this behavior by not splitting hairpin flow rules if
> OF_SET_VLAN_VID action is used without OF_PUSH_VLAN.
> On top of that, if flow rule is split, the OF_SET_VLAN_VID action is not moved
> to Tx subflow (for flow rules mentioned above).
>
> Fixes: 210008309b45 ("net/mlx5: fix VLAN push action on hairpin queue")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Dariusz Sosnowski
> Acked-by: Viacheslav Ovsiienko
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH v1 0/2] Fix src port match in meter hierarchy
Hi, > -Original Message- > From: Shun Hao > Sent: Tuesday, November 8, 2022 12:04 PM > To: Slava Ovsiienko ; Matan Azrad > ; Ori Kam > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH v1 0/2] Fix src port match in meter hierarchy > > In meter hierarchy, if policy flow contains modify_field or port_id action, a > src > port matching will be added to determine the position of meter in action list. > > Currently the src port is static, using the port id policy belongs to. > This patch set enables creation of multiple policy flows using src port from > user flow dynamically to match different src port, so the meter hierarchy can > always be used by different src ports. > > Shun Hao (2): > net/mlx5: fix meter hierarchy with modify header > net/mlx5: fix meter policy with port ID destination > > doc/guides/nics/mlx5.rst| 3 + > drivers/net/mlx5/mlx5.h | 8 +- > drivers/net/mlx5/mlx5_flow.c| 2 +- > drivers/net/mlx5/mlx5_flow_dv.c | 126 +--- > 4 files changed, 77 insertions(+), 62 deletions(-) > > -- > 2.20.0 Series applied to next-net-mlx, Kindest regards, Raslan Darawsheh
RE: [PATCH v1] net/mlx5: fix representor item and meter
Hi,
> -Original Message-
> From: Shun Hao
> Sent: Tuesday, November 8, 2022 10:51 AM
> To: Slava Ovsiienko ; Matan Azrad
> ; Ori Kam ; Sean Zhang
> (Networking SW)
> Cc: dev@dpdk.org; Raslan Darawsheh ;
> sta...@dpdk.org
> Subject: [PATCH v1] net/mlx5: fix representor item and meter
>
Small change to the commit title:
net/mlx5: fix representor item with meter
> When creating flow matching port representor item with meter action, it
> will fail due to incorrect parsing the item.
>
> This patch fixes this issue by adding the correct item parse for port
> representor in validation.
>
> Fixes: 707d5e7d79 ("net/mlx5: support flow matching on representor ID")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Shun Hao
> Acked-by: Matan Azrad
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH] net/mlx5: fix the first segment inline length
Hi,
> -Original Message-
> From: Alexander Kozyrev
> Sent: Tuesday, November 8, 2022 3:45 PM
> To: dev@dpdk.org
> Cc: sta...@dpdk.org; Raslan Darawsheh ; Slava
> Ovsiienko ; Matan Azrad ;
> Michael Baum
> Subject: [PATCH] net/mlx5: fix the first segment inline length
>
> Packets can be split into several mbufs with various data sizes.
> There is no limitation on how small these segments can be.
> But there is a limitation on Tx side for inline configuration:
> send WQEs with inline headers less than the required are dropped.
> The very first segment must be more than minimal inline eth segment.
> Enforce this requirement by merging a few segments in this case.
>
> Fixes: ec837ad0fc7 ("net/mlx5: fix multi-segment inline for the first
> segments")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Alexander Kozyrev
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH] net/mlx5: remove unneeded GENEVE option length assert
Hi,
> -Original Message-
> From: Suanming Mou
> Sent: Wednesday, November 9, 2022 3:40 AM
> To: Matan Azrad ; Slava Ovsiienko
>
> Cc: dev@dpdk.org; Raslan Darawsheh
> Subject: [PATCH] net/mlx5: remove unneeded GENEVE option length assert
>
> In order to share flow items translate code, flow items translation of spec
> and mask was split individually.
>
> In that case, the assert for GENEVE option length with mask becomes invalid,
> since the length in mask is bitmask. And as memcpy around the assert
> already checks the GENEVE option length, the assert looks redundant.
>
> This commit removes the unneeded GENEVE option length assert.
>
> Fixes: cd4ab742064a ("net/mlx5: split flow item matcher and value
> translation")
>
> Signed-off-by: Suanming Mou
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH] net/mlx5: fix assert when creating meter policy
Hi,
> -Original Message-
> From: Shun Hao
> Sent: Wednesday, November 9, 2022 9:53 AM
> To: Slava Ovsiienko ; Matan Azrad
> ; Ori Kam ; Jiawei(Jonny) Wang
>
> Cc: dev@dpdk.org; Raslan Darawsheh ;
> sta...@dpdk.org
> Subject: [PATCH] net/mlx5: fix assert when creating meter policy
>
> When creating meter policy rules, it's possible to use flow items
> translation to add src port match criteria. Currently the items
> translation process needs to get thread workspace to store vport
> metadata tag, but in policy creation, the thread workspace was not
> initialized so it will cause assert failure.
>
> This patch adds initialization of thread-local workspace when creating
> meter policy rules to avoid that assert.
>
> Fixes: 65c86202 ("net/mlx5: fix flow source port checking in sample flow
> rule")
> CC: sta...@dpdk.org
>
> Signed-off-by: Shun Hao
> Acked-by: Matan Azrad
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH v2] net/mlx5/hws: fix timestamp format on Tx queue creation
Hi,
> -Original Message-
> From: Slava Ovsiienko
> Sent: Wednesday, November 9, 2022 9:58 AM
> To: dev@dpdk.org
> Cc: Matan Azrad ; Raslan Darawsheh
> ; Alex Vesker
> Subject: [PATCH v2] net/mlx5/hws: fix timestamp format on Tx queue
> creation
>
> The NIC since 6DX supports multiple timestamp formats
> in CQEs configured via firmware. If real time timestamp
> format has been configured the correct attributes should
> be specified on queue creation via DevX. These attributes
> setting was missed on steering queue creation and hardware
> steering initialization failed.
>
> Fixes: 3eb748869d2d ("net/mlx5/hws: add send layer")
>
> Signed-off-by: Viacheslav Ovsiienko
> ---
> drivers/net/mlx5/hws/mlx5dr_cmd.c | 4
> drivers/net/mlx5/hws/mlx5dr_cmd.h | 2 ++
> drivers/net/mlx5/hws/mlx5dr_send.c | 4
> 3 files changed, 10 insertions(+)
>
> v1:
> - http://patches.dpdk.org/project/dpdk/patch/20221108185650.15489-1-
> viachesl...@nvidia.com/
> v2:
> - minor style changes
> - removed unnessesary variables
>
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH 0/2] net/mlx5/hws: fix matcher clean up for FDB tables
Hi, > -Original Message- > From: Dariusz Sosnowski > Sent: Wednesday, November 9, 2022 11:54 AM > To: Matan Azrad ; Slava Ovsiienko > ; Alex Vesker ; Erez Shitrit > > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH 0/2] net/mlx5/hws: fix matcher clean up for FDB tables > > Before these patches, if an application was configured to run with HW > Steering and E-Switch enabled, on EAL cleanup the assertion in > mlx5_dev_hw_global_release() was triggered - PD release was unsuccessful. > > Root cause of this issue was linked to an inability to destroy RTC objects > used > internally in mlx5, in HW Steering implementation. > PMD was unable to destroy RTC objects, because of dangling references to > those objects. More specifically, if all matchers connected to a single flow > table were created, this flow table was still referencing RTC objects when > theye were being destroyed. > > This patch series fixes that behavior. > Matcher uninitilization is updated to remove the references to RTC objects > from flow table object if the last matcher related to the flow table was > destroyed. > > Erez Shitrit (2): > net/mlx5/hws: fix order of destroying default tables > net/mlx5/hws: fix disconnecting matcher > > drivers/net/mlx5/hws/mlx5dr_matcher.c | 35 > +++ > drivers/net/mlx5/hws/mlx5dr_table.c | 2 +- > 2 files changed, 36 insertions(+), 1 deletion(-) > > -- > 2.25.1 series applied to next-net-mlx, Kindest regards, Raslan Darawsheh
RE: [PATCH] net/mlx5: fix indexed pool local cache crash
Hi,
> -Original Message-
> From: Alexander Kozyrev
> Sent: Wednesday, November 9, 2022 2:58 PM
> To: dev@dpdk.org
> Cc: sta...@dpdk.org; Raslan Darawsheh ; Slava
> Ovsiienko ; Matan Azrad ;
> Michael Baum
> Subject: [PATCH] net/mlx5: fix indexed pool local cache crash
>
> Local cache for an indexed pool is not initialized in the situation when
> all the indices are allocated on one CPU core and freed on another one.
> That leads to a crash once we try to check its reference counter.
> Check that the local cache is initialized before accessing this counter.
>
> Fixes: d15c0946be ("net/mlx5: add indexed pool local cache")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Alexander Kozyrev
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH] net/mlx5: fix port initialization with small LRO
Hi,
> -Original Message-
> From: Gregory Etelson
> Sent: Wednesday, November 9, 2022 6:51 PM
> To: dev@dpdk.org
> Cc: Gregory Etelson ; Matan Azrad
> ; Raslan Darawsheh ;
> sta...@dpdk.org; Slava Ovsiienko
> Subject: [PATCH] net/mlx5: fix port initialization with small LRO
>
> If application provided maximal LRO size was less than expected PMD
> minimum, the PMD either crashed with assert, if asserts were enabled,
> or proceeded with port initialization to set port private maximal
> LRO size below supported minimum.
>
> The patch terminates port start if LRO size
> does not match PMD requirements and TCP LRO offload was requested
> at least for one Rx queue.
>
> Fixes: 50c00baff763 ("net/mlx5: limit LRO size to maximum Rx packet")
>
> Cc: sta...@dpdk.org
>
> Signed-off-by: Gregory Etelson
> Acked-by: Matan Azrad
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH v2] net/mlx5: fix port's event cleaning order
Hi,
> -Original Message-
> From: Michael Baum
> Sent: Thursday, November 10, 2022 12:30 AM
> To: dev@dpdk.org
> Cc: Matan Azrad ; Raslan Darawsheh
> ; Slava Ovsiienko ;
> dkozl...@nvidia.com; sta...@dpdk.org
> Subject: [PATCH v2] net/mlx5: fix port's event cleaning order
>
> The shared IB device (sh) has per port data with filed for interrupt
> handler port_id. It used by shared interrupt handler to find the
> corresponding rte_eth device by IB port index.
> If value is equal or greater RTE_MAX_ETHPORTS it means there is no
> subhandler installed for specified IB port index.
>
> When a few ports are created under same sh, the sh is created with the
> first port and the interrupt handler port_id is initialized to
> RTE_MAX_ETHPORTS for each port.
> In port creation, the interrupt handler port_id is updated with the
> correct value. Since this updating, the mlx5_dev_interrupt_nl_cb
> function uses this port and its priv structure.
> However, when the ports are closed, this filed isn't updated and the
> interrupt handler continue working until it is uninstalled in SH
> destruction.
> If mlx5_dev_interrupt_nl_cb is called between port closing and SH
> destruction, it uses invalid port causing a crash.
>
> This patch adds interrupt handler port_id updating to the close function
> and add memory barrier to make sure it is done before priv reset.
>
> Fixes: 655c3c26c11e ("net/mlx5: fix initial link status detection")
> Cc: dkozl...@nvidia.com
> Cc: sta...@dpdk.org
>
> Signed-off-by: Michael Baum
> Acked-by: Matan Azrad
> ---
>
> v2: fix typo in commit message.
>
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH v1] net/mlx5: fix missing marks on received packets
Hi,
> -Original Message-
> From: Rongwei Liu
> Sent: Thursday, November 10, 2022 4:10 AM
> To: Matan Azrad ; Slava Ovsiienko
> ; Ori Kam ; NBU-Contact-
> Thomas Monjalon (EXTERNAL) ; Suanming Mou
>
> Cc: dev@dpdk.org; Raslan Darawsheh ;
> sta...@dpdk.org
> Subject: [PATCH v1] net/mlx5: fix missing marks on received packets
>
> If HW Steering is enabled, Rx queues were configured to receive MARKs
> when a table with MARK actions was created. After stopping the port, Rx
> queue configuration is released, but during starting the port the mark flag
> was not updated in the Rx queue configuration.
>
> This patch introduces a reference count on the MARK action and it
> increases/decreases per template_table create/destroy.
>
> When the port is stopped, Rx queue configuration is not cleared if reference
> count is not zero.
>
> Fixes: 3a2f674b6aa8 ("net/mlx5: add queue and RSS HW steering action")
> Cc: sta...@dpdk.org
> Signed-off-by: Rongwei Liu
> Acked-by: Matan Azrad
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH] net/mlx5: fix drop action validation
Hi,
> -Original Message-
> From: Shun Hao
> Sent: Thursday, November 10, 2022 8:59 AM
> To: Slava Ovsiienko ; Matan Azrad
> ; Ori Kam
> Cc: dev@dpdk.org; Raslan Darawsheh ;
> sta...@dpdk.org
> Subject: [PATCH] net/mlx5: fix drop action validation
>
> Currently there's limitation for Drop action that can only co-exist with
> Count action.
>
> Sample and Age actions are also able to exist with Drop within the same
> flow, and this patch includes them in the Drop action validation.
>
> Fixes: acb67cc8 ("net/mlx5: fix action flag data type")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Shun Hao
> Acked-by: Matan Azrad
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH] common/mlx5: fix DevX register read error severity
Hi,
> -Original Message-
> From: Gregory Etelson
> Sent: Thursday, November 10, 2022 3:05 PM
> To: dev@dpdk.org
> Cc: Gregory Etelson ; Matan Azrad
> ; Raslan Darawsheh ;
> sta...@dpdk.org; Slava Ovsiienko
> Subject: [PATCH] common/mlx5: fix DevX register read error severity
>
> PMD attempt to read HW UTC counter properties can fail because the
> feature
> has no support in port FW or mlx5 kernel module.
>
> In that case PMD still can produce correct time-stamps if it runs on core with
> nanosecond time resolution.
>
> Fixes: b0067860959d ("common/mlx5: update log for DevX general command
> failure")
> removed extra blank line
> Cc: sta...@dpdk.org
>
added reported-by tag
> Signed-off-by: Gregory Etelson
> Acked-by: Matan Azrad
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH] net/mlx5: fix wrong error log in async flow destruction
Hi,
> -Original Message-
> From: Michael Baum
> Sent: Sunday, November 13, 2022 1:07 PM
> To: dev@dpdk.org
> Cc: Matan Azrad ; Raslan Darawsheh
> ; Slava Ovsiienko ;
> Suanming Mou ; sta...@dpdk.org
> Subject: [PATCH] net/mlx5: fix wrong error log in async flow destruction
>
> The flow_hw_async_flow_destroy() function fills the error structure in
> case of failure.
>
> The error log reported by function is "fail to create rte flow" while
> the correct failure is in destruction.
>
> This patch changes the error log to report "fail to destroy rte flow".
>
> Fixes: c40c061a022e ("net/mlx5: add basic flow queue operation")
> Cc: suanmi...@nvidia.com
> Cc: sta...@dpdk.org
>
> Signed-off-by: Michael Baum
> Acked-by: Matan Azrad
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH] net/mlx5: fix GENEVE resource management
Hi,
> -Original Message-
> From: Suanming Mou
> Sent: Wednesday, November 16, 2022 11:37 AM
> To: Matan Azrad ; Slava Ovsiienko
>
> Cc: dev@dpdk.org; Raslan Darawsheh
> Subject: [PATCH] net/mlx5: fix GENEVE resource management
>
> The item translation split causes GENEVE TLV option resource register
> function flow_dev_geneve_tlv_option_resource_register() to be called
> twice incorrectly both in spec and mask translation.
>
> In SWS mode the refcnt will only be decreased by 1 in flow release.
> The refcnt will never be 0 again, it causes the resource be leaked.
> In HWS mode the resource is allocated as global, the refcnt should
> not be increased after the resource be allocated. And the resource
> should be released during PMD exists.
>
> This commit fixes GENEVE resource management.
>
> Fixes: 75a00812b18f ("net/mlx5: add hardware steering item translation")
> Fixes: cd4ab742064a ("net/mlx5: split flow item matcher and value
> translation")
>
> Signed-off-by: Suanming Mou
> Acked-by: Viacheslav Ovsiienko
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH] net/mlx5: fix push VLAN action mask iteration
Hi,
> -Original Message-
> From: Dariusz Sosnowski
> Sent: Thursday, November 17, 2022 12:07 PM
> To: Matan Azrad ; Slava Ovsiienko
> ; Gregory Etelson
> Cc: dev@dpdk.org; Raslan Darawsheh
> Subject: [PATCH] net/mlx5: fix push VLAN action mask iteration
>
> Before this patch, during translation of OF_PUSH_VLAN actions iterator
> was moved forward to the position of OF_SET_VLAN_VID or
> OF_SET_VLAN_PCP, but masks iterator was not updated.
> As a result, the following actions were incorrectly translated,
> because iterators were not aligned.
>
> This patch fixes this behavior by properly adjusting masks iterator
> alognside actions iterator.
>
> Fixes: 773ca0e91ba1 ("net/mlx5: support VLAN push/pop/modify with HWS")
> Cc: getel...@nvidia.com
>
> Signed-off-by: Dariusz Sosnowski
> Acked-by: Viacheslav Ovsiienko
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH 1/2] net/mlx5: fix port private max_lro_msg_size
Hi,
> -Original Message-
> From: Gregory Etelson
> Sent: Thursday, November 17, 2022 4:39 PM
> To: dev@dpdk.org
> Cc: Gregory Etelson ; Matan Azrad
> ; Raslan Darawsheh ; Slava
> Ovsiienko
> Subject: [PATCH 1/2] net/mlx5: fix port private max_lro_msg_size
>
> The PMD analyzes each Rx queue maximal LRO size and selects one that
> fits all queues to configure TIR LRO attribute.
> TIR LRO attribute is number of 256 bytes chunks that match the
> selected maximal LRO size.
>
> PMD used `priv->max_lro_msg_size` for selected maximal LRO size and
> number of TIR chunks.
>
> Fixes: 9f1035b5f71c ("net/mlx5: fix port initialization with small LRO")
>
> Signed-off-by: Gregory Etelson
> Acked-by: Matan Azrad
Series applied to next-net-mlx,
With small fixes to title.
Kindest regards,
Raslan Darawsheh
RE: [PATCH] net/mlx5: fix modify field operation validation
Hi,
> -Original Message-
> From: Dariusz Sosnowski
> Sent: Thursday, November 17, 2022 4:42 PM
> To: Matan Azrad ; Slava Ovsiienko
> ; Suanming Mou
> Cc: dev@dpdk.org; Raslan Darawsheh
> Subject: [PATCH] net/mlx5: fix modify field operation validation
>
> This patch removes the following checks from validation
> of modify field action:
>
> - rejection of ADD operation,
> - offsets should be aligned to 4 bytes.
>
> These limitations were removed in
> commit 0f4aa72b99da ("net/mlx5: support flow modify field with HWS"),
> but non-HWS validation was not updated.
>
> Notes about these limitations are removed from mlx5 PMD docs.
> On top of that, the current offsetting behavior in modify field action
> is clarified in the mlx5 docs.
>
> Fixes: 0f4aa72b99da ("net/mlx5: support flow modify field with HWS")
> Cc: suanmi...@nvidia.com
>
> Signed-off-by: Dariusz Sosnowski
> Acked-by: Viacheslav Ovsiienko
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH] net/mlx5: fix invalid memory access in port closing
Hi,
> -Original Message-
> From: Michael Baum
> Sent: Thursday, November 17, 2022 5:28 PM
> To: dev@dpdk.org
> Cc: Matan Azrad ; Raslan Darawsheh
> ; Slava Ovsiienko ; Michael
> Baum
> Subject: [PATCH] net/mlx5: fix invalid memory access in port closing
>
> The shared IB device (sh) has per port data updated in port creation.
> In port closing this port data is updated even when the SH still exist.
>
> However, this updating is happened after SH has been released and for last
> port it actually accesses to freed memory.
>
> This patch updates the port data before SH releasing.
>
> Fixes: 13c5c093905c ("net/mlx5: fix port event cleaning order")
> Cc: michae...@nvidia.com
>
> Signed-off-by: Michael Baum
> Acked-by: Matan Azrad
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
[PATCH] doc: add tested platforms with NVIDIA NICs
Add tested platforms with NVIDIA NICs to the 22.11 release notes. Signed-off-by: Raslan Darawsheh --- doc/guides/rel_notes/release_22_11.rst | 155 + 1 file changed, 155 insertions(+) diff --git a/doc/guides/rel_notes/release_22_11.rst b/doc/guides/rel_notes/release_22_11.rst index 5e091403ad..fad0bf2b40 100644 --- a/doc/guides/rel_notes/release_22_11.rst +++ b/doc/guides/rel_notes/release_22_11.rst @@ -635,3 +635,158 @@ Tested Platforms This section is a comment. Do not overwrite or remove it. Also, make sure to start the actual text at the margin. === + +* Intel\ |reg| platforms with NVIDIA \ |reg| NICs combinations + + * CPU: + +* Intel\ |reg| Xeon\ |reg| Gold 6154 CPU @ 3.00GHz +* Intel\ |reg| Xeon\ |reg| CPU E5-2697A v4 @ 2.60GHz +* Intel\ |reg| Xeon\ |reg| CPU E5-2697 v3 @ 2.60GHz +* Intel\ |reg| Xeon\ |reg| CPU E5-2680 v2 @ 2.80GHz +* Intel\ |reg| Xeon\ |reg| CPU E5-2670 0 @ 2.60GHz +* Intel\ |reg| Xeon\ |reg| CPU E5-2650 v4 @ 2.20GHz +* Intel\ |reg| Xeon\ |reg| CPU E5-2650 v3 @ 2.30GHz +* Intel\ |reg| Xeon\ |reg| CPU E5-2640 @ 2.50GHz +* Intel\ |reg| Xeon\ |reg| CPU E5-2650 0 @ 2.00GHz +* Intel\ |reg| Xeon\ |reg| CPU E5-2620 v4 @ 2.10GHz + + * OS: + +* Red Hat Enterprise Linux release 8.6 (Ootpa) +* Red Hat Enterprise Linux release 8.4 (Ootpa) +* Red Hat Enterprise Linux release 8.2 (Ootpa) +* Red Hat Enterprise Linux Server release 7.9 (Maipo) +* Red Hat Enterprise Linux Server release 7.8 (Maipo) +* Red Hat Enterprise Linux Server release 7.6 (Maipo) +* Red Hat Enterprise Linux Server release 7.5 (Maipo) +* Red Hat Enterprise Linux Server release 7.4 (Maipo) +* Ubuntu 22.04 +* Ubuntu 20.04 +* Ubuntu 18.04 +* SUSE Enterprise Linux 15 SP2 + + * OFED: + +* MLNX_OFED 5.8-1.0.1.1 and above +* MLNX_OFED 5.7-1.0.2.0 + + * upstream kernel: + +* Linux 6.1.0-rc3 and above + + * rdma-core: + +* rdma-core-43.0 and above + + * NICs: + +* NVIDIA\ |reg| ConnectX\ |reg|-3 Pro 40G MCX354A-FCC_Ax (2x40G) + + * Host interface: PCI Express 3.0 x8 + * Device ID: 15b3:1007 + * Firmware version: 2.42.5000 +* Red Hat Enterprise Linux release 8.4 (Ootpa) + +* NVIDIA\ |reg| ConnectX\ |reg|-3 Pro 40G MCX354A-FCCT (2x40G) + + * Host interface: PCI Express 3.0 x8 + * Device ID: 15b3:1007 + * Firmware version: 2.42.5000 + +* NVIDIA\ |reg| ConnectX\ |reg|-4 Lx 25G MCX4121A-ACAT (2x25G) + + * Host interface: PCI Express 3.0 x8 + * Device ID: 15b3:1015 + * Firmware version: 14.32.1010 and above + +* NVIDIA\ |reg| ConnectX\ |reg|-4 Lx 50G MCX4131A-GCAT (1x50G) + + * Host interface: PCI Express 3.0 x8 + * Device ID: 15b3:1015 + * Firmware version: 14.32.1010 and above + +* NVIDIA\ |reg| ConnectX\ |reg|-5 100G MCX516A-CCAT (2x100G) + + * Host interface: PCI Express 3.0 x16 + * Device ID: 15b3:1017 + * Firmware version: 16.35.1012 and above + +* NVIDIA\ |reg| ConnectX\ |reg|-5 100G MCX556A-ECAT (2x100G) + + * Host interface: PCI Express 3.0 x16 + * Device ID: 15b3:1017 + * Firmware version: 16.35.1012 and above + +* NVIDIA\ |reg| ConnectX\ |reg|-5 100G MCX556A-EDAT (2x100G) + + * Host interface: PCI Express 3.0 x16 + * Device ID: 15b3:1017 + * Firmware version: 16.35.1012 and above + +* NVIDIA\ |reg| ConnectX\ |reg|-5 Ex EN 100G MCX516A-CDAT (2x100G) + + * Host interface: PCI Express 4.0 x16 + * Device ID: 15b3:1019 + * Firmware version: 16.35.1012 and above + +* NVIDIA\ |reg| ConnectX\ |reg|-6 Dx EN 100G MCX623106AN-CDAT (2x100G) + + * Host interface: PCI Express 4.0 x16 + * Device ID: 15b3:101d + * Firmware version: 22.35.1012 and above + +* NVIDIA\ |reg| ConnectX\ |reg|-6 Lx EN 25G MCX631102AN-ADAT (2x25G) + + * Host interface: PCI Express 4.0 x8 + * Device ID: 15b3:101f + * Firmware version: 26.35.1012 and above + +* NVIDIA\ |reg| ConnectX\ |reg| 7 200G CX713106AE-HEA_QP1_Ax (2x200G) + + * Host interface: PCI Express 5.0 x16 + * Device ID: 15b3:1021 + * Firmware version: 28.35.1012 and above + +* NVIDIA \ |reg| BlueField\ |reg| SmartNIC + + * NVIDIA\ |reg| BlueField\ |reg| 2 SmartNIC MT41686 - MBF2H332A-AEEOT_A1 (2x25G) + +* Host interface: PCI Express 3.0 x16 +* Device ID: 15b3:a2d6 +* Firmware version: 24. 35.1012 and above + + * Embedded software: + +* Ubuntu 20.04.3 +* MLNX_OFED 5.8-1.0.1.1 and above +* DOCA 1.5 with BlueField 3.9.3 +* DPDK application running on Arm cores + +* IBM Power 9 platforms with NVIDIA\ |reg| NICs combinations + + * CPU: + +* POWER9 2.2 (pvr 004e 1202) + + * OS: + +* Ubuntu 20.04 + + * NICs: + +* NVIDIA\ |reg| ConnectX\ |reg|-5 100G MCX556A-ECAT (2x100G) + + * Host interface: PCI Express 4.0 x16 + * Device ID: 15b3:1017
[PATCH] compress/mlx5: add Bluefield-3 device ID
This adds the Bluefield-3 device ids to the list of
supported NVIDIA devices that run the MLX5 compress PMDs.
Signed-off-by: Raslan Darawsheh
---
drivers/compress/mlx5/mlx5_compress.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/compress/mlx5/mlx5_compress.c
b/drivers/compress/mlx5/mlx5_compress.c
index 3d2c45fcee..fb2bda9745 100644
--- a/drivers/compress/mlx5/mlx5_compress.c
+++ b/drivers/compress/mlx5/mlx5_compress.c
@@ -790,6 +790,10 @@ static const struct rte_pci_id mlx5_compress_pci_id_map[]
= {
RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
PCI_DEVICE_ID_MELLANOX_CONNECTX6DXBF)
},
+ {
+ RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
+ PCI_DEVICE_ID_MELLANOX_CONNECTX7BF)
+ },
{
.vendor_id = 0
}
--
2.25.1
[PATCH v2] compress/mlx5: add Bluefield-3 device ID
This adds the Bluefield-3 device ids to the list of
supported NVIDIA devices that run the MLX5 compress PMDs.
The devices is still in development stage.
Signed-off-by: Raslan Darawsheh
---
v2: update commit msg to mention the device is actually still in
development stage.
---
drivers/compress/mlx5/mlx5_compress.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/compress/mlx5/mlx5_compress.c
b/drivers/compress/mlx5/mlx5_compress.c
index 3d2c45fcee..fb2bda9745 100644
--- a/drivers/compress/mlx5/mlx5_compress.c
+++ b/drivers/compress/mlx5/mlx5_compress.c
@@ -790,6 +790,10 @@ static const struct rte_pci_id mlx5_compress_pci_id_map[]
= {
RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
PCI_DEVICE_ID_MELLANOX_CONNECTX6DXBF)
},
+ {
+ RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
+ PCI_DEVICE_ID_MELLANOX_CONNECTX7BF)
+ },
{
.vendor_id = 0
}
--
2.25.1
RE: [PATCH] net/mlx5: fix available tag registers calculation for HWS
Hi,
> -Original Message-
> From: Dariusz Sosnowski
> Sent: Tuesday, November 22, 2022 2:53 PM
> To: Matan Azrad ; Slava Ovsiienko
> ; Bing Zhao
> Cc: dev@dpdk.org; Raslan Darawsheh ; Ori Kam
>
> Subject: [PATCH] net/mlx5: fix available tag registers calculation for HWS
>
> Before this patch, if two ports in separate switch domains were probed by an
> application, the shared array of available TAG registers was calculated
> incorrectly.
>
> When the intersection of supported REG_C registers and available TAG
> registers was calculated, capabilities were checked against an index of the
> TAG array, not the register stored under that index.
>
> This patch fixes this behavior by comparing capabilities mask against
> registers
> stored in the TAG array.
> Available TAG registers calculation is also refactored to simplify the code.
>
> Fixes: 8a89038f40ca ("net/mlx5: provide available tag registers")
> Cc: bi...@nvidia.com
>
> Signed-off-by: Dariusz Sosnowski
> Reviewed-by: Bing Zhao
> Acked-by: Ori Kam
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH] net/mlx5: fix GENEVE resource overwritten
Hi,
> -Original Message-
> From: Suanming Mou
> Sent: Wednesday, November 23, 2022 1:57 PM
> To: Matan Azrad ; Slava Ovsiienko
>
> Cc: dev@dpdk.org; Raslan Darawsheh
> Subject: [PATCH] net/mlx5: fix GENEVE resource overwritten
>
> Currently, one rte_flow may be split to multiple sub mlx5_flows.
> While GENEVE option resource was allocated in the first mlx5_flow,
> the flag will be overwritten by next sub mlx5_flow. This caused
> GENEVE option resource leakage.
>
> This commit adds the check of GENEVE option resource to avoid the
> GENEVE option flag be overwritten.
>
> Fixes: cd4ab742064a ("net/mlx5: split flow item matcher and value
> translation")
>
> Signed-off-by: Suanming Mou
> Acked-by: Viacheslav Ovsiienko
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH] common/mlx5: improve AES-XTS tweek capability check
Hi, > -Original Message- > From: Suanming Mou > Sent: Tuesday, December 6, 2022 3:17 AM > To: Slava Ovsiienko ; Matan Azrad > > Cc: Raslan Darawsheh ; dev@dpdk.org > Subject: [PATCH] common/mlx5: improve AES-XTS tweek capability check > > Bluefield-3 and above devices use aes_xts_multi_block_be_tweak > bit to indicate AES-XTS capability. The devices below use > aes_xts_single_block_le_tweak bit. > > This commit adds the AES-XTS attribute set while one of the > bits is set to make the attribute compatible with all the > devices. > added Cc: sta...@dpdk.org > Signed-off-by: Suanming Mou > --- Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh
RE: [PATCH] net/mlx5/hws: fix incorrect dw_8_6_ext PRM offset
Hi,
> -Original Message-
> From: Alex Vesker
> Sent: Thursday, December 8, 2022 1:09 PM
> To: Alex Vesker ; Slava Ovsiienko
> ; NBU-Contact-Thomas Monjalon (EXTERNAL)
> ; Suanming Mou ;
> Matan Azrad
> Cc: dev@dpdk.org; Ori Kam
> Subject: [PATCH] net/mlx5/hws: fix incorrect dw_8_6_ext PRM offset
>
> The offset of format_select_dw_8_6_ext was incorrect.
> Update the reserved offsets to correct value.
>
> Fixes: 365cdf5f8ce7 ("net/mlx5/hws: add command layer")
Missing Cc: sta...@dpdk.org
Added during integration
> Signed-off-by: Alex Vesker
> Reviewed-by: Erez Shitrit
> ---
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH] net/mlx5: fix assert on getting register of sample flow
Hi,
> -Original Message-
> From: Jiawei(Jonny) Wang
> Sent: Friday, December 9, 2022 3:59 PM
> To: Slava Ovsiienko ; Matan Azrad
> ; Shahaf Shuler
> Cc: dev@dpdk.org; Raslan Darawsheh ; Jiawei(Jonny)
> Wang ; sta...@dpdk.org
> Subject: [PATCH] net/mlx5: fix assert on getting register of sample flow
>
> From: Jiawei Wang
>
> The sample flow tried to get the reserved metadata register for match
> implicitly, and if the reserved metadata register was invalid then back to use
> the application tag.
>
> The assertion failure was caused while getting register due to the reserved
> metadata regC is invalid on CX-5 trusted device(VF/SF).
>
> This patch adds the checking for reserved metadata register before getting
> the register, to avoid assertion failure.
>
> Fixes: 9a726360dd30 ("net/mlx5: fix sample flow action on trusted device")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Jiawei Wang
> Acked-by: Slava Ovsiienko
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [Patch v2] net/mlx4: fix verbs fd leak in the secondary process
Hi,
> -Original Message-
> From: lon...@linuxonhyperv.com
> Sent: Wednesday, July 6, 2022 8:49 PM
> To: Matan Azrad ; Ferruh Yigit
>
> Cc: dev@dpdk.org; Karanjot Singh ; NBU-
> Contact-longli (EXTERNAL)
> Subject: [Patch v2] net/mlx4: fix verbs fd leak in the secondary process
>
> From: Long Li
>
> FDs passed from rte_mp_msg are duplicated to the secondary process and
> need to be closed.
>
> Fixes: 0203d33a10 ("net/mlx4: support secondary process")
> Signed-off-by: Long Li
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [Patch v2] net/mlx5: fix verbs fd leak in the secondary process
Hi,
> -Original Message-
> From: lon...@linuxonhyperv.com
> Sent: Wednesday, July 6, 2022 8:49 PM
> To: Matan Azrad ; Ferruh Yigit
>
> Cc: dev@dpdk.org; Karanjot Singh ; NBU-
> Contact-longli (EXTERNAL)
> Subject: [Patch v2] net/mlx5: fix verbs fd leak in the secondary process
>
> From: Long Li
>
> FDs passed from rte_mp_msg are duplicated to the secondary process and
> need to be closed.
>
> Fixes: 9a8ab29b84 ("net/mlx5: replace IPC socket with EAL API")
> Signed-off-by: Long Li
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH v3] common/mlx5: update DevX error logging
Hi, > -Original Message- > From: Gregory Etelson > Sent: Sunday, July 10, 2022 7:03 PM > To: dev@dpdk.org > Cc: Gregory Etelson ; Matan Azrad > ; Raslan Darawsheh ; NBU- > Contact-Thomas Monjalon (EXTERNAL) ; Slava > Ovsiienko > Subject: [PATCH v3] common/mlx5: update DevX error logging > > Current PMD logs all DevX errors at error level. > > DevX interface can fail queue counters allocation on some hardware types. > That is a known issue. > PMD fallback to VERB API to allocate queue counters when it detects the > fault. > That DevX failure should not be logged as PMD error. > > The patch provides DevX with flexible API that selects log level. > > Signed-off-by: Gregory Etelson > Acked-by: Matan Azrad > --- > v2: fix warnings in old gcc versions > v3: remove cc stable Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh
RE: [PATCH] net/mlx5: fix detection of LRO support
Hi,
> -Original Message-
> From: Michael Baum
> Sent: Wednesday, July 27, 2022 3:24 PM
> To: dev@dpdk.org
> Cc: Matan Azrad ; Raslan Darawsheh
> ; Slava Ovsiienko ; Michael
> Baum ; sta...@dpdk.org; Gal Shalom
>
> Subject: [PATCH] net/mlx5: fix detection of LRO support
>
> One of the conditions to allow LRO offload is the DV configuration.
>
> The function incorrectly checks the DV configuration before initializing it by
> the user devarg; hence, LRO cannot be allowed.
>
> This patch moves this check to mlx5_shared_dev_ctx_args_config, where DV
> configuration is initialized.
>
> Fixes: c4b862013598 ("net/mlx5: refactor to detect operation by DevX")
> Cc: michae...@nvidia.com
> Cc: sta...@dpdk.org
>
> Signed-off-by: Michael Baum
> Reported-by: Gal Shalom
> Acked-by: Matan Azrad
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH] net/mlx5: fix matcher priority for esp item
Hi,
> -Original Message-
> From: Bassam Zaid AlKilani
> Sent: Thursday, July 28, 2022 5:12 PM
> To: dev@dpdk.org
> Cc: Raslan Darawsheh ; rzid...@nvidia.com;
> sta...@dpdk.org; Matan Azrad ; Slava Ovsiienko
>
> Subject: [PATCH] net/mlx5: fix matcher priority for esp item
>
> ESP is one of IPSec protocols over both IPv4 and IPv6 and is considered
> a tunnel layer that cannot be followed by any other layer. Taking that
> into consideration, esp is considered as a 4 layer.
>
> Not defining ESP's priority will make it match with the same priority as
> its prior IP layer, which has a layer 3 priority. This will lead to
> issues in matching and will match the packet with the first matching
> rule even if it doesn't have an esp layer in its pattern, disregarding
> any following rules that could have an esp item and can be actually
> a more accurate match since it will have a longer matching criterion.
>
> This is fixed by defining the priority for the ESP item to have a
> layer 4 priority, making the match be for the rule with the more
> accurate and longer matching criteria.
>
> Fixes: 18ca4a4ec73a ("net/mlx5: support ESP SPI match and RSS hash")
> Cc: rzid...@nvidia.com
> Cc: sta...@dpdk.org
>
> Signed-off-by: Bassam ZaidAlKilani [Raslan Darawsheh]
Acked-by: Raslan Darawsheh
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH] net/mlx5: fix check for orphan wait descriptor
Hi,
> -Original Message-
> From: Slava Ovsiienko
> Sent: Thursday, August 11, 2022 8:51 AM
> To: dev@dpdk.org
> Cc: ferruh.yi...@intel.com; Matan Azrad ; Raslan
> Darawsheh ; sta...@dpdk.org
> Subject: [PATCH] net/mlx5: fix check for orphan wait descriptor
>
> The mlx5 PMD supports send scheduling feature, it allows
> to send packets at specified moment of time, to do that
> PMD pushes special wait descriptor (WQE) to the hardware
> queue and then pushes descriptor for packet data as usual.
> If queue is close to be full or there is no enough elts
> buffers to store mbufs being sent the data descriptors might
> be not pushed and the orphan wait WQE (not followed by the
> data) might reside in queue on tx_burst routine exit.
>
> To avoid orphan wait WQEs there was the check for enough
> free space in the queue WQE buffer and enough amount of the
> free elts in queue mbuf storage. This check was incomplete
> and did not cover all the cases for Enhanced Multi-Packet
> Write descriptors.
>
> Fixes: 2f827f5ea6e1 ("net/mlx5: support scheduling on send routine
> template")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Viacheslav Ovsiienko
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH v2] net/mlx5: fix single not inline packet elts storing
Hi,
> -Original Message-
> From: Slava Ovsiienko
> Sent: Wednesday, August 17, 2022 10:04 AM
> To: dev@dpdk.org
> Cc: Matan Azrad ; Raslan Darawsheh
> ; sta...@dpdk.org
> Subject: [PATCH v2] net/mlx5: fix single not inline packet elts storing
>
> The mlx5 PMD can inline packet data into transmitting descriptor (WQE)
> and free mbuf immediately as data no longer needed, for non-inline
> packets the mbuf pointer should be stored in elts array for coming
> freeing on send completion. There was an optimization on storing
> pointers in batch and there was missed storing mbuf for single
> packet if non-inline was explicitly requested by flag.
>
> Fixes: cacb44a09962 ("net/mlx5: add no-inline Tx flag")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Viacheslav Ovsiienko
> ---
> v2: "Fixes tag" added
>
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: mlx5_common failed errno=121
Hi Panagiotis, Can you check if this will solve this issue? http://patches.dpdk.org/project/dpdk/patch/20220710160244.2934-1-getel...@nvidia.com/ Kindest regards, Raslan Darawsheh From: Panagiotis Famelis Sent: Wednesday, August 17, 2022 10:54 AM To: dev@dpdk.org Subject: mlx5_common failed errno=121 Hello, I am trying to run p4-dpdk-target (https://github.com/p4lang/p4-dpdk-target), with DPDK version 22.07.0-rc2 (the one provided by the p4-dpdk-target). However, when I run the bf_switchd I get the following error, by the dpdk driver: """ mlx5_common: DevX read access NIC register=0X9055 failed errno=121 status=0x3 syndrome=0x54e3a9 mlx5_common: DevX create q counter set failed errno=121 status=0x2 syndrome=0x8975f1 """ The same error appears when running dpdk-testpmd (by the above DPDK version). The NIC is an NVIDIA/ Mellanox Connect-X 5. I have also tested with DPDK version 21.11.0 and it doesn't show this error and works correctly. Do you have any suggestions on what that particular error might be and how to fix it? It seems like it tries to read a wrong register, but I am not sure. Thank you for your help. Best Regards, Panagiotis Famelis.
RE: [PATCH] net/mlx5: fix the inline length exceeding descriptor limit
Hi,
> -Original Message-
> From: Slava Ovsiienko
> Sent: Wednesday, August 17, 2022 5:14 PM
> To: dev@dpdk.org
> Cc: Matan Azrad ; Raslan Darawsheh
> ; Dmitry Kozlyuk ;
> sta...@dpdk.org
> Subject: [PATCH] net/mlx5: fix the inline length exceeding descriptor limit
>
> The hardware descriptor (WQE) length field is 6 bits wide
> and we have the native limitation for the overall descriptor
> length. To improve the PCIe bandwidth the packet data can be
> inline into descriptor. If PMD was configured to inline large
> amount of data it happened there was no enough space remaining
> in the descriptor to specify all the packet data segments and
> PMD rejected problematic packets.
>
> The patch tries to adjust the inline data length conservatively
> and allows to avoid error occurring.
>
> Fixes: 18a1c20044c0 ("net/mlx5: implement Tx burst template")
> Fixes: e2259f93ef45 ("net/mlx5: fix Tx when inlining is impossible")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Viacheslav Ovsiienko
> Reviewed-by: Dmitry Kozlyuk
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH] net/mlx5: fix condition to avoid Tx failure
Hi,
> -Original Message-
> From: Slava Ovsiienko
> Sent: Wednesday, August 17, 2022 5:15 PM
> To: dev@dpdk.org
> Cc: Matan Azrad ; Raslan Darawsheh
> ; Dmitry Kozlyuk ; Raja Zidane
> ; sta...@dpdk.org
> Subject: [PATCH] net/mlx5: fix condition to avoid Tx failure
>
> From: Raja Zidane
>
> If hardware descriptor (WQE) length exceeds one the HW can handle,
> the Tx queue failure occurs. PMD does the length check but there was
> a bug - the length limit was expressed in 16B units (WQEBB segments),
> while the calculated WQE length and limit were in 64B units (WQEBBs).
> Fix the condition to avoid subsequent Tx queue failure.
>
> Fixes: 18a1c20 ("net/mlx5: implement Tx burst template")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Raja Zidane
> Acked-by: Viacheslav Ovsiienko
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH v2] net/mlx5: fix modify action attributes detection
Hi,
> -Original Message-
> From: Jiawei(Jonny) Wang
> Sent: Thursday, September 1, 2022 5:12 AM
> To: Slava Ovsiienko ; Matan Azrad
> ; Ori Kam ; Suanming Mou
>
> Cc: dev@dpdk.org; Raslan Darawsheh ;
> sta...@dpdk.org
> Subject: [PATCH v2] net/mlx5: fix modify action attributes detection
>
> The driver splits the flow with sample action into two sub-flows,
> sub prefix flow and sub suffix flow.
>
> In the case of tunnel flow including a decap action, the driver should
> translate the inner as outer for actions coming after the decap action.
> In the case of flow splitting, the packet layers, used to detect the
> attributes, are inherited from the prefix flow to the suffix flow but
> the driver wrongly didn't handle the decap adjustment and the inner
> layers didn't shift to the outer.
>
> This patch adjusts the inherited layers in case of decap.
>
> Fixes: 6e77151286b2 ("net/mlx5: fix match information in meter")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Jiawei Wang
> Acked-by: Matan Azrad
> ---
> v2: fix the style warning
> ---
Patch applied to next-net-mlx,
Concerning this failure:
http://mails.dpdk.org/archives/test-report/2022-September/304146.html
Please note to send always in reply to your previous version,
Kindest regards,
Raslan Darawsheh
RE: [PATCH v1 0/3] Fix meter hierarchy issue for represented port
Hi, > -Original Message- > From: Shun Hao > Sent: Saturday, September 17, 2022 9:02 AM > To: Slava Ovsiienko ; Matan Azrad > ; Ori Kam > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH v1 0/3] Fix meter hierarchy issue for represented port > > When the represented port item was introduced, there's an issue that if a > flow matching represented port item uses a meter hierarchy action, it will > fail > due to the represented port item not supported correctly in meter hierarchy > creation. > > This patch set is adding the correct handling to support represented port. > And there're some limitation for the support that when matching all ports, > the meter hierarchy should not contain any meter having drop count. > > Shun Hao (3): > net/mlx5: fix meter hierarchy with represented port item > net/mlx5: add meter flow limitation when matching all ports > net/mlx5: fix meter ID tag for meter hierarchy > > doc/guides/nics/mlx5.rst| 1 + > drivers/net/mlx5/mlx5.h | 2 + > drivers/net/mlx5/mlx5_flow.c| 27 + > drivers/net/mlx5/mlx5_flow.h| 4 ++ > drivers/net/mlx5/mlx5_flow_dv.c | 71 ++-- > - > 5 files changed, 73 insertions(+), 32 deletions(-) > > -- > 2.20.0 Series applied to next-net-mlx, Kindest regards Raslan Darawsheh
RE: [PATCH v1] net/mlx5: fix meter profile delete fail
Hi,
> -Original Message-
> From: Shun Hao
> Sent: Sunday, September 18, 2022 3:58 AM
> To: Slava Ovsiienko ; Matan Azrad
> ; Ori Kam ; Suanming Mou
>
> Cc: dev@dpdk.org; Raslan Darawsheh ;
> sta...@dpdk.org; Matan Azrad
> Subject: [PATCH v1] net/mlx5: fix meter profile delete fail
>
> If a meter's profile is changed after meter disabled, there's an issue
> that will fail when deleting the old profile.
>
> This patch fixes this by adding the correct process to decrease the old
> profile's reference count when changing profile.
>
> Fixes: 63ffeb2ff2 ("net/mlx5: support meter profile update")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Shun Hao
> Acked-by: Matan Azrad
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
RE: [PATCH v2] doc: fix mlx5 flow integrity hardware support
Hi,
> -Original Message-
> From: Gregory Etelson
> Sent: Thursday, June 16, 2022 11:43 AM
> To: dev@dpdk.org
> Cc: Gregory Etelson ; Matan Azrad
> ; Raslan Darawsheh ;
> sta...@dpdk.org; Slava Ovsiienko
> Subject: [PATCH v2] doc: fix mlx5 flow integrity hardware support
>
> Current MLX5 PMD documentation stays that entire `ConnentX-6` family
> supports flow integrity feature.
>
> Flow integrity offload is not supported on vanilla `ConnectX-6`.
> It is available on `ConnectX-6 DX`, `ConnectX-6 LX` and `BlueField-2`.
>
> Cc: sta...@dpdk.org
>
> Fixes: 79f8952783d0 ("net/mlx5: support integrity flow item")
>
> Signed-off-by: Gregory Etelson
> Acked-by: Viacheslav Ovsiienko
> ---
> v2: Update Mellanox hardware types that support integrity bits.
> ---
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
