[dpdk-dev] [PATCH] app/test-pmd: fix incorrect port number check

[Yong Liu]

testpmd parameter "nb-port" mean the number of forwarding port.
It's incorrect to use function port_id_is_invalid to check number of ports.

Signed-off-by: Marvin Liu 

diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
index 11d9af0..f1daa6e 100644
--- a/app/test-pmd/parameters.c
+++ b/app/test-pmd/parameters.c
@@ -628,8 +628,7 @@ launch_args_parse(int argc, char** argv)
 #endif
if (!strcmp(lgopts[opt_idx].name, "nb-ports")) {
n = atoi(optarg);
-   if (n > 0 &&
-   !port_id_is_invalid(n, DISABLED_WARN))
+   if (n > 0 && n <= nb_ports)
nb_fwd_ports = (uint8_t) n;
else
rte_exit(EXIT_FAILURE,
-- 
1.9.3

[dpdk-dev] [PATCH] app/test-pmd: fix incorrect port number check

[Thomas Monjalon]

This patch was already applied:
http://dpdk.org/browse/dpdk/commit/?id=0a530f0d58b030

2015-03-19 11:16, Yong Liu:
> testpmd parameter "nb-port" mean the number of forwarding port.
> It's incorrect to use function port_id_is_invalid to check number of ports.
> 
> Signed-off-by: Marvin Liu 
> 
> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
> index 11d9af0..f1daa6e 100644
> --- a/app/test-pmd/parameters.c
> +++ b/app/test-pmd/parameters.c
> @@ -628,8 +628,7 @@ launch_args_parse(int argc, char** argv)
>  #endif
>   if (!strcmp(lgopts[opt_idx].name, "nb-ports")) {
>   n = atoi(optarg);
> - if (n > 0 &&
> - !port_id_is_invalid(n, DISABLED_WARN))
> + if (n > 0 && n <= nb_ports)
>   nb_fwd_ports = (uint8_t) n;
>   else
>   rte_exit(EXIT_FAILURE,
> 

[dpdk-dev] [PATCH] app/test-pmd: fix incorrect port number check

[Yong Liu]

testpmd parameter "nb-port" mean the number of forwarding port.
It's incorrect to use function port_id_is_invalid to check number of ports.

Signed-off-by: Marvin Liu 

diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
index 11d9af0..f1daa6e 100644
--- a/app/test-pmd/parameters.c
+++ b/app/test-pmd/parameters.c
@@ -628,8 +628,7 @@ launch_args_parse(int argc, char** argv)
 #endif
if (!strcmp(lgopts[opt_idx].name, "nb-ports")) {
n = atoi(optarg);
-   if (n > 0 &&
-   !port_id_is_invalid(n, DISABLED_WARN))
+   if (n > 0 && n <= nb_ports)
nb_fwd_ports = (uint8_t) n;
else
rte_exit(EXIT_FAILURE,
-- 
1.9.3

[dpdk-dev] [PATCH] app/test-pmd: fix incorrect port number check

[Thomas Monjalon]

2015-03-11 15:23, Yong Liu:
> testpmd parameter "nb-port" mean the number of forwarding port.
> It's incorrect to use function port_id_is_invalid to check number of ports.
> 
> Signed-off-by: Marvin Liu 

Acked-by: Thomas Monjalon 

Fixes: edab33b1c01d ("app/testpmd: support port hotplug")

Applied, thanks