[dpdk-dev] [PATCH] common/rte_memcpy: Fix x86intrin.h missed
On 3/13/2015 5:45 PM, Ananyev, Konstantin wrote: > Hi Michael, > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Michael Qiu >> Sent: Friday, March 13, 2015 7:03 AM >> To: dev at dpdk.org >> Subject: [dpdk-dev] [PATCH] common/rte_memcpy: Fix x86intrin.h missed >> >> rte_memcpy.h(46): catastrophic error: cannot open source file "x86intrin.h" >> >> For icc and old gcc, this header is not included. >> >> Signed-off-by: Michael Qiu >> --- >> lib/librte_eal/common/include/arch/x86/rte_memcpy.h | 20 >> >> 1 file changed, 20 insertions(+) >> >> diff --git a/lib/librte_eal/common/include/arch/x86/rte_memcpy.h >> b/lib/librte_eal/common/include/arch/x86/rte_memcpy.h >> index ac72069..bd10d36 100644 >> --- a/lib/librte_eal/common/include/arch/x86/rte_memcpy.h >> +++ b/lib/librte_eal/common/include/arch/x86/rte_memcpy.h >> @@ -43,7 +43,27 @@ >> #include >> #include >> #include >> +#if (defined(__ICC) || (__GNUC__ == 4 && __GNUC_MINOR__ < 4)) >> + >> +#ifdef __SSE__ >> +#include >> +#endif >> + >> +#ifdef __SSE2__ >> +#include >> +#endif >> + >> +#if defined(__SSE4_2__) || defined(__SSE4_1__) >> +#include >> +#endif >> + >> +#if defined(__AVX__) >> +#include >> +#endif >> + >> +#else >> #include >> +#endif >> >> #ifdef __cplusplus >> extern "C" { >> -- >> 1.9.3 > Wonder why to spread this thing over? > Why not just #include ? Yes, I will send other patch to fix this, Thanks, Michael > Konstantin > > > >
[dpdk-dev] [PATCH] common/rte_memcpy: Fix x86intrin.h missed
2015-03-16 17:39, Ananyev, Konstantin: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > I think that rte_common_vec.h should be moved into > > lib/librte_eal/common/include/arch/x86/rte_vec.h as it's x86-specific. > > Seems like a good thing to do. > Do you want me to submit a patch for 2.0 for that? It would be nice yes. Thanks
[dpdk-dev] [PATCH] common/rte_memcpy: Fix x86intrin.h missed
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Monday, March 16, 2015 4:05 PM > To: Ananyev, Konstantin > Cc: dev at dpdk.org; Qiu, Michael > Subject: Re: [dpdk-dev] [PATCH] common/rte_memcpy: Fix x86intrin.h missed > > 2015-03-13 09:44, Ananyev, Konstantin: > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Michael Qiu > > > > > > rte_memcpy.h(46): catastrophic error: cannot open source file > > > "x86intrin.h" > > > > > > For icc and old gcc, this header is not included. > > > > > > Signed-off-by: Michael Qiu > > > --- > > > lib/librte_eal/common/include/arch/x86/rte_memcpy.h | 20 > > > > > > 1 file changed, 20 insertions(+) > > > > > > diff --git a/lib/librte_eal/common/include/arch/x86/rte_memcpy.h > > > b/lib/librte_eal/common/include/arch/x86/rte_memcpy.h > > > index ac72069..bd10d36 100644 > > > --- a/lib/librte_eal/common/include/arch/x86/rte_memcpy.h > > > +++ b/lib/librte_eal/common/include/arch/x86/rte_memcpy.h > > > @@ -43,7 +43,27 @@ > > > #include > > > #include > > > #include > > > +#if (defined(__ICC) || (__GNUC__ == 4 && __GNUC_MINOR__ < 4)) > > > + > > > +#ifdef __SSE__ > > > +#include > > > +#endif > > > + > > > +#ifdef __SSE2__ > > > +#include > > > +#endif > > > + > > > +#if defined(__SSE4_2__) || defined(__SSE4_1__) > > > +#include > > > +#endif > > > + > > > +#if defined(__AVX__) > > > +#include > > > +#endif > > > + > > > +#else > > > #include > > > +#endif > > > > > > #ifdef __cplusplus > > > extern "C" { > > > -- > > > 1.9.3 > > > > Wonder why to spread this thing over? > > Why not just #include ? > > I agree to use rte_common_vec.h. > I pushed this approach to check every tested compilers: > http://dpdk.org/browse/dpdk/commit/?id=9a01c31b94e54384 > > I think that rte_common_vec.h should be moved into > lib/librte_eal/common/include/arch/x86/rte_vec.h as it's x86-specific. Seems like a good thing to do. Do you want me to submit a patch for 2.0 for that? Konstantin
[dpdk-dev] [PATCH] common/rte_memcpy: Fix x86intrin.h missed
2015-03-13 09:44, Ananyev, Konstantin: > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Michael Qiu > > > > rte_memcpy.h(46): catastrophic error: cannot open source file "x86intrin.h" > > > > For icc and old gcc, this header is not included. > > > > Signed-off-by: Michael Qiu > > --- > > lib/librte_eal/common/include/arch/x86/rte_memcpy.h | 20 > > > > 1 file changed, 20 insertions(+) > > > > diff --git a/lib/librte_eal/common/include/arch/x86/rte_memcpy.h > > b/lib/librte_eal/common/include/arch/x86/rte_memcpy.h > > index ac72069..bd10d36 100644 > > --- a/lib/librte_eal/common/include/arch/x86/rte_memcpy.h > > +++ b/lib/librte_eal/common/include/arch/x86/rte_memcpy.h > > @@ -43,7 +43,27 @@ > > #include > > #include > > #include > > +#if (defined(__ICC) || (__GNUC__ == 4 && __GNUC_MINOR__ < 4)) > > + > > +#ifdef __SSE__ > > +#include > > +#endif > > + > > +#ifdef __SSE2__ > > +#include > > +#endif > > + > > +#if defined(__SSE4_2__) || defined(__SSE4_1__) > > +#include > > +#endif > > + > > +#if defined(__AVX__) > > +#include > > +#endif > > + > > +#else > > #include > > +#endif > > > > #ifdef __cplusplus > > extern "C" { > > -- > > 1.9.3 > > Wonder why to spread this thing over? > Why not just #include ? I agree to use rte_common_vec.h. I pushed this approach to check every tested compilers: http://dpdk.org/browse/dpdk/commit/?id=9a01c31b94e54384 I think that rte_common_vec.h should be moved into lib/librte_eal/common/include/arch/x86/rte_vec.h as it's x86-specific.
[dpdk-dev] [PATCH] common/rte_memcpy: Fix x86intrin.h missed
On 3/13/2015 10:25 PM, Mcnamara, John wrote: >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Michael Qiu >> Sent: Friday, March 13, 2015 7:03 AM >> To: dev at dpdk.org >> Subject: [dpdk-dev] [PATCH] common/rte_memcpy: Fix x86intrin.h missed >> >> rte_memcpy.h(46): catastrophic error: cannot open source file >> "x86intrin.h" > > Hi Michael, > > How are you generating that error? For ICC compile, it will report this error, also in suse11sp2 i686 platform, also have this issue as internal report. Thanks, Michael > John >
[dpdk-dev] [PATCH] common/rte_memcpy: Fix x86intrin.h missed
rte_memcpy.h(46): catastrophic error: cannot open source file "x86intrin.h" For icc and old gcc, this header is not included. Signed-off-by: Michael Qiu --- lib/librte_eal/common/include/arch/x86/rte_memcpy.h | 20 1 file changed, 20 insertions(+) diff --git a/lib/librte_eal/common/include/arch/x86/rte_memcpy.h b/lib/librte_eal/common/include/arch/x86/rte_memcpy.h index ac72069..bd10d36 100644 --- a/lib/librte_eal/common/include/arch/x86/rte_memcpy.h +++ b/lib/librte_eal/common/include/arch/x86/rte_memcpy.h @@ -43,7 +43,27 @@ #include #include #include +#if (defined(__ICC) || (__GNUC__ == 4 && __GNUC_MINOR__ < 4)) + +#ifdef __SSE__ +#include +#endif + +#ifdef __SSE2__ +#include +#endif + +#if defined(__SSE4_2__) || defined(__SSE4_1__) +#include +#endif + +#if defined(__AVX__) +#include +#endif + +#else #include +#endif #ifdef __cplusplus extern "C" { -- 1.9.3
[dpdk-dev] [PATCH] common/rte_memcpy: Fix x86intrin.h missed
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Michael Qiu > Sent: Friday, March 13, 2015 7:03 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] common/rte_memcpy: Fix x86intrin.h missed > > rte_memcpy.h(46): catastrophic error: cannot open source file > "x86intrin.h" Hi Michael, How are you generating that error? John
[dpdk-dev] [PATCH] common/rte_memcpy: Fix x86intrin.h missed
Hi Michael, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Michael Qiu > Sent: Friday, March 13, 2015 7:03 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] common/rte_memcpy: Fix x86intrin.h missed > > rte_memcpy.h(46): catastrophic error: cannot open source file "x86intrin.h" > > For icc and old gcc, this header is not included. > > Signed-off-by: Michael Qiu > --- > lib/librte_eal/common/include/arch/x86/rte_memcpy.h | 20 > 1 file changed, 20 insertions(+) > > diff --git a/lib/librte_eal/common/include/arch/x86/rte_memcpy.h > b/lib/librte_eal/common/include/arch/x86/rte_memcpy.h > index ac72069..bd10d36 100644 > --- a/lib/librte_eal/common/include/arch/x86/rte_memcpy.h > +++ b/lib/librte_eal/common/include/arch/x86/rte_memcpy.h > @@ -43,7 +43,27 @@ > #include > #include > #include > +#if (defined(__ICC) || (__GNUC__ == 4 && __GNUC_MINOR__ < 4)) > + > +#ifdef __SSE__ > +#include > +#endif > + > +#ifdef __SSE2__ > +#include > +#endif > + > +#if defined(__SSE4_2__) || defined(__SSE4_1__) > +#include > +#endif > + > +#if defined(__AVX__) > +#include > +#endif > + > +#else > #include > +#endif > > #ifdef __cplusplus > extern "C" { > -- > 1.9.3 Wonder why to spread this thing over? Why not just #include ? Konstantin
[dpdk-dev] [PATCH] common/rte_memcpy: Fix x86intrin.h missed
> -Original Message- > From: Qiu, Michael > Sent: Friday, March 13, 2015 3:03 PM > To: dev at dpdk.org > Cc: Wang, Zhihong; Qiu, Michael > Subject: [PATCH] common/rte_memcpy: Fix x86intrin.h missed > > rte_memcpy.h(46): catastrophic error: cannot open source file "x86intrin.h" > > For icc and old gcc, this header is not included. > > Signed-off-by: Michael Qiu > --- > lib/librte_eal/common/include/arch/x86/rte_memcpy.h | 20 > > 1 file changed, 20 insertions(+) > > diff --git a/lib/librte_eal/common/include/arch/x86/rte_memcpy.h > b/lib/librte_eal/common/include/arch/x86/rte_memcpy.h > index ac72069..bd10d36 100644 > --- a/lib/librte_eal/common/include/arch/x86/rte_memcpy.h > +++ b/lib/librte_eal/common/include/arch/x86/rte_memcpy.h > @@ -43,7 +43,27 @@ > #include > #include > #include > +#if (defined(__ICC) || (__GNUC__ == 4 && __GNUC_MINOR__ < 4)) > + > +#ifdef __SSE__ > +#include > +#endif > + > +#ifdef __SSE2__ > +#include > +#endif > + > +#if defined(__SSE4_2__) || defined(__SSE4_1__) #include > +#endif > + > +#if defined(__AVX__) > +#include > +#endif > + > +#else > #include > +#endif > > #ifdef __cplusplus > extern "C" { > -- > 1.9.3 Acked-by: Wang, Zhihong