[dpdk-dev] [PATCH] cryptodev: fix crash on null dereference

[Jerin Jacob]

On Wed, Nov 30, 2016 at 03:10:14PM +, De Lara Guarch, Pablo wrote:
> Hi Jerin,
> 
> > -Original Message-
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jerin Jacob
> > Sent: Tuesday, November 15, 2016 7:12 PM
> > To: dev at dpdk.org
> > Cc: Doherty, Declan; Jerin Jacob
> > Subject: [dpdk-dev] [PATCH] cryptodev: fix crash on null dereference
> > 
> > crypodev->data->name will be null when
> > rte_cryptodev_get_dev_id() invoked without a valid
> > crypto device instance.
> > 
> > Signed-off-by: Jerin Jacob 
> 
> Could you add a "Fixes" line? 

Sure. I will send the v2 then

> 
> Thanks,
> Pablo

[dpdk-dev] [PATCH] cryptodev: fix crash on null dereference

[De Lara Guarch, Pablo]

Hi Jerin,

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jerin Jacob
> Sent: Tuesday, November 15, 2016 7:12 PM
> To: dev at dpdk.org
> Cc: Doherty, Declan; Jerin Jacob
> Subject: [dpdk-dev] [PATCH] cryptodev: fix crash on null dereference
> 
> crypodev->data->name will be null when
> rte_cryptodev_get_dev_id() invoked without a valid
> crypto device instance.
> 
> Signed-off-by: Jerin Jacob 

Could you add a "Fixes" line? 

Thanks,
Pablo

[dpdk-dev] [PATCH] cryptodev: fix crash on null dereference

[Kusztal, ArkadiuszX]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jerin Jacob
> Sent: Tuesday, November 15, 2016 7:12 PM
> To: dev at dpdk.org
> Cc: Doherty, Declan ; Jerin Jacob
> 
> Subject: [dpdk-dev] [PATCH] cryptodev: fix crash on null dereference
> 
> crypodev->data->name will be null when
> rte_cryptodev_get_dev_id() invoked without a valid crypto device instance.
> 
> Signed-off-by: Jerin Jacob 
> ---
>  lib/librte_cryptodev/rte_cryptodev.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> --
> 2.5.5
Acked-by: Arek Kusztal 

[dpdk-dev] [PATCH] cryptodev: fix crash on null dereference

[Jerin Jacob]

crypodev->data->name will be null when
rte_cryptodev_get_dev_id() invoked without a valid
crypto device instance.

Signed-off-by: Jerin Jacob 
---
 lib/librte_cryptodev/rte_cryptodev.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lib/librte_cryptodev/rte_cryptodev.c 
b/lib/librte_cryptodev/rte_cryptodev.c
index 127e8d0..54e95d5 100644
--- a/lib/librte_cryptodev/rte_cryptodev.c
+++ b/lib/librte_cryptodev/rte_cryptodev.c
@@ -225,13 +225,14 @@ rte_cryptodev_create_vdev(const char *name, const char 
*args)
 }

 int
-rte_cryptodev_get_dev_id(const char *name) {
+rte_cryptodev_get_dev_id(const char *name)
+{
unsigned i;

if (name == NULL)
return -1;

-   for (i = 0; i < rte_cryptodev_globals->max_devs; i++)
+   for (i = 0; i < rte_cryptodev_globals->nb_devs; i++)
if ((strcmp(rte_cryptodev_globals->devs[i].data->name, name)
== 0) &&
(rte_cryptodev_globals->devs[i].attached ==
-- 
2.5.5